patina-ai 0.23.0

Context orchestration for AI development - captures and evolves patterns over time
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
1177
1178
1179
1180
1181
1182
1183
1184
1185
1186
1187
1188
1189
1190
1191
1192
1193
1194
1195
1196
1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
1207
1208
1209
1210
1211
1212
1213
1214
1215
1216
1217
1218
1219
1220
1221
1222
1223
1224
1225
1226
1227
1228
1229
1230
1231
1232
1233
1234
1235
1236
1237
1238
1239
1240
1241
1242
1243
1244
1245
1246
1247
1248
1249
1250
1251
1252
1253
1254
1255
1256
1257
1258
1259
1260
1261
1262
1263
1264
1265
1266
1267
1268
1269
1270
1271
1272
1273
1274
1275
1276
1277
1278
1279
1280
1281
1282
1283
1284
1285
1286
1287
1288
1289
1290
1291
1292
1293
1294
1295
1296
1297
1298
1299
1300
1301
1302
1303
1304
1305
1306
1307
1308
1309
1310
1311
1312
1313
1314
1315
1316
1317
1318
1319
1320
1321
1322
1323
1324
1325
1326
1327
1328
1329
1330
1331
1332
1333
1334
1335
1336
1337
1338
1339
1340
1341
1342
1343
1344
1345
1346
1347
1348
1349
1350
1351
1352
1353
1354
1355
1356
1357
1358
1359
1360
1361
1362
1363
1364
1365
1366
1367
1368
1369
1370
1371
1372
1373
1374
1375
1376
1377
1378
1379
1380
1381
1382
1383
1384
1385
1386
1387
1388
1389
1390
1391
1392
1393
1394
1395
1396
1397
1398
1399
1400
1401
1402
1403
1404
1405
1406
1407
1408
1409
1410
1411
1412
1413
1414
1415
1416
1417
1418
1419
1420
1421
1422
1423
1424
1425
1426
1427
1428
1429
1430
1431
1432
1433
1434
1435
1436
1437
1438
1439
1440
1441
1442
1443
1444
1445
1446
1447
1448
1449
1450
1451
1452
1453
1454
1455
1456
1457
1458
1459
1460
1461
1462
1463
1464
1465
1466
1467
1468
1469
1470
1471
1472
1473
1474
1475
1476
1477
1478
1479
1480
1481
1482
1483
1484
1485
1486
1487
1488
1489
1490
1491
1492
1493
1494
1495
1496
1497
1498
1499
1500
1501
1502
1503
1504
1505
1506
1507
1508
1509
1510
1511
1512
1513
1514
1515
1516
1517
1518
1519
1520
1521
1522
1523
1524
1525
1526
1527
1528
1529
1530
1531
1532
1533
1534
1535
1536
1537
1538
1539
//! Evaluation framework for validating retrieval quality
//!
//! Post-split eval modes:
//! - `--assay`: independent factual retrieval eval (FTS5)
//! - `--scry`: independent semantic retrieval eval (vectors) + scry-vs-assay comparison
//! - `--combined`: full pipeline eval (assay + scry together)
//!
//! Legacy eval modes (pre-split, kept for historical comparison):
//! - `--nl`: NL query eval against QueryEngine (52 queries from mixed-oracle era)
//! - `--feedback`: feedback loop eval from session data
//! - `--dimension`: structural/temporal/belief co-retrieval tests

mod internal;

use anyhow::{Context, Result};
use rusqlite::Connection;
use std::collections::{HashMap, HashSet};

use crate::retrieval::{FusedResult, QueryEngine, RetrievalConfig};

/// Evaluation results for one engine + test combination
#[derive(Debug)]
pub struct EvalResults {
    pub engine: String,
    pub test_name: String,
    pub num_queries: usize,
    pub precision_at_5: f32,
    pub precision_at_10: f32,
    pub random_baseline: f32,
}

/// Belief self-retrieval results (MRR-based)
#[derive(Debug)]
pub struct BeliefSelfResults {
    pub engine: String,
    pub num_queries: usize,
    pub mrr: f32,
    pub hit_rate: f32,
}

/// Belief-code co-retrieval results (split metrics per reviewer feedback)
#[derive(Debug)]
pub struct BeliefCoResults {
    pub engine: String,
    pub num_queries: usize,
    /// Fraction of queries where belief:<id> appeared in top-K
    pub belief_present_rate: f32,
    /// Avg(reached files in top-K / min(K, reach_count))
    pub reach_recall: f32,
    /// Fraction where belief present AND ≥1 reached file
    pub co_retrieval_rate: f32,
}

/// Run evaluation
pub fn execute(dimension: Option<String>) -> Result<()> {
    println!("📊 Evaluation Framework\n");
    println!("Testing retrieval quality: unified pipeline + per-oracle ablation\n");

    let db_path = ".patina/local/data/patina.db";
    let conn = Connection::open(db_path)?;

    // Create engines: unified (all oracles), ablation per-oracle, and belief delta
    let unified = QueryEngine::new();
    let semantic_only = QueryEngine::with_config(RetrievalConfig {
        oracle_filter: Some(vec!["semantic".to_string()]),
        ..Default::default()
    });
    let temporal_only = QueryEngine::with_config(RetrievalConfig {
        oracle_filter: Some(vec!["temporal".to_string()]),
        ..Default::default()
    });
    // D1 measurement: all oracles EXCEPT belief — delta measures belief impact
    let no_belief = QueryEngine::with_config(RetrievalConfig {
        oracle_filter: Some(vec![
            "semantic".to_string(),
            "lexical".to_string(),
            "temporal".to_string(),
            "persona".to_string(),
        ]),
        ..Default::default()
    });

    let mut all_results = Vec::new();

    // Semantic tests: --dimension narrows which tests run, not which engines
    if dimension.is_none() || dimension.as_deref() == Some("semantic") {
        println!("━━━ Unified Pipeline (code → same-file) ━━━\n");
        let results = eval_semantic_co_retrieval(&conn, &unified, "unified")?;
        print_results(&results);
        all_results.push(results);

        println!("\n━━━ Ablation: no-belief (code → same-file) ━━━\n");
        let results = eval_semantic_co_retrieval(&conn, &no_belief, "no-belief")?;
        print_results(&results);
        all_results.push(results);

        println!("\n━━━ Ablation: semantic-only (code → same-file) ━━━\n");
        let results = eval_semantic_co_retrieval(&conn, &semantic_only, "semantic-only")?;
        print_results(&results);
        all_results.push(results);
    }

    // Temporal tests
    if dimension.is_none() || dimension.as_deref() == Some("temporal") {
        // Score distribution (unified only, no ground truth)
        println!("\n━━━ Unified Pipeline (text → score distribution) ━━━\n");
        eval_temporal_text(&conn, &unified)?;

        // File co-change (unified + temporal-only)
        println!("\n━━━ Unified Pipeline (file → co-change) ━━━\n");
        let results = eval_temporal_file(&conn, &unified, "unified")?;
        print_results(&results);
        all_results.push(results);

        println!("\n━━━ Ablation: no-belief (file → co-change) ━━━\n");
        let results = eval_temporal_file(&conn, &no_belief, "no-belief")?;
        print_results(&results);
        all_results.push(results);

        println!("\n━━━ Ablation: temporal-only (file → co-change) ━━━\n");
        let results = eval_temporal_file(&conn, &temporal_only, "temporal-only")?;
        print_results(&results);
        all_results.push(results);
    }

    // Belief tests: knowledge-query ground truth
    let mut self_results = Vec::new();
    let mut co_results = Vec::new();

    if dimension.is_none() || dimension.as_deref() == Some("belief") {
        println!("\n━━━ Unified Pipeline (belief self-retrieval) ━━━\n");
        let results = eval_belief_self_retrieval(&conn, &unified, "unified")?;
        print_belief_self_results(&results);
        self_results.push(results);

        println!("\n━━━ Ablation: no-belief (belief self-retrieval) ━━━\n");
        let results = eval_belief_self_retrieval(&conn, &no_belief, "no-belief")?;
        print_belief_self_results(&results);
        self_results.push(results);

        println!("\n━━━ Unified Pipeline (belief→code co-retrieval) ━━━\n");
        let results = eval_belief_code_co_retrieval(&conn, &unified, "unified")?;
        print_belief_co_results(&results);
        co_results.push(results);

        println!("\n━━━ Ablation: no-belief (belief→code co-retrieval) ━━━\n");
        let results = eval_belief_code_co_retrieval(&conn, &no_belief, "no-belief")?;
        print_belief_co_results(&results);
        co_results.push(results);
    }

    // Summary table: structural tests
    println!("\n━━━ Summary ━━━\n");
    println!(
        "{:<35} {:>12} {:>12} {:>12}",
        "Pipeline", "P@5", "P@10", "vs Random"
    );
    println!("{}", "".repeat(75));
    for r in &all_results {
        let vs_random = if r.random_baseline > 0.0 {
            r.precision_at_10 / r.random_baseline
        } else {
            0.0
        };
        println!(
            "{:<35} {:>11.1}% {:>11.1}% {:>11.1}x",
            format!("{} ({})", r.engine, r.test_name),
            r.precision_at_5 * 100.0,
            r.precision_at_10 * 100.0,
            vs_random
        );
    }

    // Summary table: belief tests
    if !self_results.is_empty() {
        println!(
            "\n{:<35} {:>12} {:>12}",
            "Pipeline (self-retrieval)", "MRR", "Hit Rate"
        );
        println!("{}", "".repeat(63));
        for r in &self_results {
            println!(
                "{:<35} {:>12.3} {:>11.1}%",
                r.engine,
                r.mrr,
                r.hit_rate * 100.0,
            );
        }
    }

    if !co_results.is_empty() {
        println!(
            "\n{:<35} {:>10} {:>10} {:>10}",
            "Pipeline (co-retrieval)", "B.Pres", "ReachR", "Co-Retr"
        );
        println!("{}", "".repeat(69));
        for r in &co_results {
            println!(
                "{:<35} {:>9.1}% {:>9.1}% {:>9.1}%",
                r.engine,
                r.belief_present_rate * 100.0,
                r.reach_recall * 100.0,
                r.co_retrieval_rate * 100.0,
            );
        }
    }

    // D1 belief delta: full picture
    const STRUCTURAL_BUDGET_PP: f32 = 5.0; // max acceptable regression in percentage points
    let mut d1_pass = true;

    println!("\n━━━ D1 Belief Delta (unified vs no-belief) ━━━\n");
    println!(
        "{:<25} {:>12} {:>12} {:>8} {:>8}",
        "Test", "Unified", "No-Belief", "Delta", "Verdict"
    );
    println!("{}", "".repeat(69));

    // Self-retrieval delta (MRR)
    if let (Some(u), Some(nb)) = (
        self_results.iter().find(|r| r.engine == "unified"),
        self_results.iter().find(|r| r.engine == "no-belief"),
    ) {
        let delta = u.mrr - nb.mrr;
        let verdict = if delta >= 0.0 { "PASS" } else { "FAIL" };
        if delta < 0.0 {
            d1_pass = false;
        }
        println!(
            "{:<25} {:>8.3}MRR {:>8.3}MRR {:>+7.3} {:>8}",
            "self-retrieval", u.mrr, nb.mrr, delta, verdict
        );
    }

    // Co-retrieval delta (co_retrieval_rate)
    if let (Some(u), Some(nb)) = (
        co_results.iter().find(|r| r.engine == "unified"),
        co_results.iter().find(|r| r.engine == "no-belief"),
    ) {
        let delta = u.co_retrieval_rate - nb.co_retrieval_rate;
        let verdict = if delta >= 0.0 { "PASS" } else { "FAIL" };
        if delta < 0.0 {
            d1_pass = false;
        }
        println!(
            "{:<25} {:>9.1}%   {:>9.1}%   {:>+6.1}% {:>8}",
            "belief→code",
            u.co_retrieval_rate * 100.0,
            nb.co_retrieval_rate * 100.0,
            delta * 100.0,
            verdict
        );
    }

    // Structural test deltas (P@10, budget-enforced)
    let test_names: Vec<String> = all_results.iter().map(|r| r.test_name.clone()).collect();
    for test in test_names.iter().collect::<HashSet<_>>() {
        let unified_r = all_results
            .iter()
            .find(|r| r.engine == "unified" && &r.test_name == test);
        let no_belief_r = all_results
            .iter()
            .find(|r| r.engine == "no-belief" && &r.test_name == test);
        if let (Some(u), Some(nb)) = (unified_r, no_belief_r) {
            let delta_pp = (u.precision_at_10 - nb.precision_at_10) * 100.0;
            let within_budget = delta_pp >= -STRUCTURAL_BUDGET_PP;
            let verdict = if within_budget {
                "PASS"
            } else {
                d1_pass = false;
                "FAIL"
            };
            println!(
                "{:<25} {:>11.1}% {:>11.1}% {:>+6.1}pp {:>5} (budget: {}pp)",
                test,
                u.precision_at_10 * 100.0,
                nb.precision_at_10 * 100.0,
                delta_pp,
                verdict,
                STRUCTURAL_BUDGET_PP,
            );
        }
    }

    println!(
        "\n{}",
        if d1_pass {
            "D1 VERDICT: PASS — knowledge gains positive, structural regression within budget"
        } else {
            "D1 VERDICT: FAIL — see failing tests above"
        }
    );

    Ok(())
}

// ============================================================================
// Semantic evaluation: function_facts co-retrieval
// ============================================================================

/// Evaluate semantic retrieval: functions in same file should co-retrieve
///
/// Ground truth: function_facts table. Files with 3+ functions provide
/// query (one function description) and expected results (other functions
/// from same file). doc_ids are file::function format — unique per function,
/// no RRF dedup issue.
fn eval_semantic_co_retrieval(
    conn: &Connection,
    engine: &QueryEngine,
    engine_name: &str,
) -> Result<EvalResults> {
    // Load function_facts grouped by file
    let mut files: HashMap<String, Vec<(String, String)>> = HashMap::new();

    let mut stmt = conn.prepare(
        "SELECT file, name, parameters, return_type, is_public, is_async
         FROM function_facts
         ORDER BY file, name",
    )?;

    let mut rows = stmt.query([])?;
    while let Some(row) = rows.next()? {
        let file: String = row.get(0)?;
        let name: String = row.get(1)?;
        let params: Option<String> = row.get(2)?;
        let return_type: Option<String> = row.get(3)?;
        let is_public: bool = row.get(4)?;
        let is_async: bool = row.get(5)?;

        // Build description matching what's embedded in the semantic index
        let mut desc = format!("Function `{}` in `{}`", name, file);
        if is_public {
            desc.push_str(", public");
        }
        if is_async {
            desc.push_str(", async");
        }
        if let Some(ref p) = params {
            if !p.is_empty() {
                desc.push_str(&format!(", params: {}", p));
            }
        }
        if let Some(ref rt) = return_type {
            if !rt.is_empty() {
                desc.push_str(&format!(", returns: {}", rt));
            }
        }

        files.entry(file).or_default().push((name, desc));
    }

    // Files with 3+ functions have enough for query + expected results
    let valid_files: Vec<_> = files.iter().filter(|(_, funcs)| funcs.len() >= 3).collect();

    println!(
        "Found {} files with 3+ functions ({} total functions)",
        valid_files.len(),
        files.values().map(|v| v.len()).sum::<usize>()
    );

    if valid_files.is_empty() {
        return Ok(EvalResults {
            engine: engine_name.to_string(),
            test_name: "code→same-file".to_string(),
            num_queries: 0,
            precision_at_5: 0.0,
            precision_at_10: 0.0,
            random_baseline: 0.0,
        });
    }

    let mut total_precision_5 = 0.0;
    let mut total_precision_10 = 0.0;
    let mut num_queries = 0;

    // Sample up to 20 files, seeded for deterministic eval
    let sample_size = valid_files.len().min(20);
    let mut rng = fastrand::Rng::with_seed(42);

    for i in 0..sample_size {
        let idx = if sample_size < valid_files.len() {
            rng.usize(..valid_files.len())
        } else {
            i
        };

        let (file_path, functions) = valid_files[idx];

        // Use first function's description as query
        let query = &functions[0].1;
        let expected_file = normalize_path(file_path);
        let expected_count = functions.len() - 1; // exclude query function itself

        if let Ok(results) = engine.query(query, 10) {
            let hits_5 = count_file_hits(&results, &expected_file, 5);
            let hits_10 = count_file_hits(&results, &expected_file, 10);

            let p5 = hits_5 as f32 / 5.0_f32.min(expected_count as f32);
            let p10 = hits_10 as f32 / 10.0_f32.min(expected_count as f32);

            total_precision_5 += p5;
            total_precision_10 += p10;
            num_queries += 1;

            if num_queries <= 3 {
                println!(
                    "  {} ({} funcs): P@5={:.0}%, P@10={:.0}%",
                    file_path,
                    functions.len(),
                    p5 * 100.0,
                    p10 * 100.0
                );
            }
        }
    }

    if num_queries > 3 {
        println!("  ... and {} more queries", num_queries - 3);
    }

    // Random baseline: chance of hitting same-file function
    let total_functions: usize = files.values().map(|v| v.len()).sum();
    let avg_file_size = total_functions as f32 / files.len() as f32;
    let random_baseline = avg_file_size / total_functions as f32;

    Ok(EvalResults {
        engine: engine_name.to_string(),
        test_name: "code→same-file".to_string(),
        num_queries,
        precision_at_5: if num_queries > 0 {
            total_precision_5 / num_queries as f32
        } else {
            0.0
        },
        precision_at_10: if num_queries > 0 {
            total_precision_10 / num_queries as f32
        } else {
            0.0
        },
        random_baseline,
    })
}

// ============================================================================
// Temporal evaluation: co-change partners + score distribution
// ============================================================================

/// Evaluate temporal with text queries (score distribution, no ground truth)
///
/// Measures whether the unified pipeline returns meaningful score distributions
/// for text queries. No precision — just diagnostic.
fn eval_temporal_text(conn: &Connection, engine: &QueryEngine) -> Result<()> {
    let mut stmt = conn.prepare(
        "SELECT json_extract(data, '$.content') as content
         FROM eventlog
         WHERE event_type = 'session.observation'
           AND content IS NOT NULL AND length(content) > 50
         LIMIT 20",
    )?;

    let mut queries: Vec<String> = Vec::new();
    let mut rows = stmt.query([])?;
    while let Some(row) = rows.next()? {
        queries.push(row.get(0)?);
    }

    println!(
        "Testing {} text queries (score distribution)",
        queries.len()
    );

    let mut avg_top_score = 0.0;
    let mut avg_score_variance = 0.0;
    let mut num_queries = 0;

    for query in queries.iter().take(10) {
        if let Ok(results) = engine.query(query, 10) {
            if !results.is_empty() {
                let scores: Vec<f32> = results.iter().map(|r| r.fused_score).collect();
                let top = scores[0];
                let mean = scores.iter().sum::<f32>() / scores.len() as f32;
                let variance =
                    scores.iter().map(|s| (s - mean).powi(2)).sum::<f32>() / scores.len() as f32;

                avg_top_score += top;
                avg_score_variance += variance;
                num_queries += 1;
            }
        }
    }

    if num_queries > 0 {
        avg_top_score /= num_queries as f32;
        avg_score_variance /= num_queries as f32;
    }

    println!("  Avg top fused score: {:.4}", avg_top_score);
    println!(
        "  Avg score variance: {:.6} (low = results are random-ish)",
        avg_score_variance
    );
    println!("  Queries evaluated: {}", num_queries);

    Ok(())
}

/// Evaluate temporal with file queries: file → co-change partners
///
/// Ground truth: co_changes table. Files that frequently change together
/// should co-retrieve. Extract file path from FusedResult doc_id (strip
/// "./" prefix and "::suffix") before matching.
fn eval_temporal_file(
    conn: &Connection,
    engine: &QueryEngine,
    engine_name: &str,
) -> Result<EvalResults> {
    // Get files with known co-changes
    let mut stmt = conn.prepare(
        "SELECT file_a, file_b, count
         FROM co_changes
         WHERE count >= 3
         ORDER BY count DESC
         LIMIT 100",
    )?;

    let mut cochanges: HashMap<String, HashSet<String>> = HashMap::new();
    let mut rows = stmt.query([])?;
    while let Some(row) = rows.next()? {
        let file_a: String = row.get(0)?;
        let file_b: String = row.get(1)?;
        cochanges
            .entry(file_a.clone())
            .or_default()
            .insert(file_b.clone());
        cochanges.entry(file_b).or_default().insert(file_a);
    }

    // Files with 2+ co-change partners, sorted for deterministic eval
    let mut test_files: Vec<_> = cochanges
        .iter()
        .filter(|(_, partners)| partners.len() >= 2)
        .collect();
    test_files.sort_by(|a, b| b.1.len().cmp(&a.1.len()).then(a.0.cmp(b.0)));
    test_files.truncate(20);

    println!(
        "Testing {} files with known co-change partners",
        test_files.len()
    );

    if test_files.is_empty() {
        return Ok(EvalResults {
            engine: engine_name.to_string(),
            test_name: "file→co-change".to_string(),
            num_queries: 0,
            precision_at_5: 0.0,
            precision_at_10: 0.0,
            random_baseline: 0.0,
        });
    }

    let mut total_precision_5 = 0.0;
    let mut total_precision_10 = 0.0;
    let mut num_queries = 0;

    for (file_path, expected_partners) in &test_files {
        let query = format!("File: {} ({})", file_path, get_file_type(file_path));

        if let Ok(results) = engine.query(&query, 10) {
            // Extract and normalize file paths from FusedResult doc_ids
            let retrieved_files: Vec<String> = results
                .iter()
                .map(|r| extract_file_from_doc_id(&r.doc_id))
                .collect();

            // Normalize expected partners for comparison
            let normalized_partners: HashSet<String> = expected_partners
                .iter()
                .map(|p| normalize_path(p))
                .collect();

            let hits_5 = retrieved_files
                .iter()
                .take(5)
                .filter(|f| normalized_partners.contains(f.as_str()))
                .count();
            let hits_10 = retrieved_files
                .iter()
                .take(10)
                .filter(|f| normalized_partners.contains(f.as_str()))
                .count();

            let max_possible = normalized_partners.len().min(10);
            let p5 = hits_5 as f32 / 5.0_f32.min(max_possible as f32);
            let p10 = hits_10 as f32 / max_possible as f32;

            total_precision_5 += p5;
            total_precision_10 += p10;
            num_queries += 1;

            if num_queries <= 3 {
                println!(
                    "  {}: found {}/{} partners in top 10",
                    file_path,
                    hits_10,
                    expected_partners.len().min(10)
                );
            }
        }
    }

    if num_queries > 3 {
        println!("  ... and {} more queries", num_queries - 3);
    }

    // Random baseline
    let total_files = cochanges.len();
    let avg_partners =
        cochanges.values().map(|v| v.len()).sum::<usize>() as f32 / total_files as f32;
    let random_baseline = avg_partners / total_files as f32;

    Ok(EvalResults {
        engine: engine_name.to_string(),
        test_name: "file→co-change".to_string(),
        num_queries,
        precision_at_5: if num_queries > 0 {
            total_precision_5 / num_queries as f32
        } else {
            0.0
        },
        precision_at_10: if num_queries > 0 {
            total_precision_10 / num_queries as f32
        } else {
            0.0
        },
        random_baseline,
    })
}

// ============================================================================
// Belief evaluation: self-retrieval + code co-retrieval
// ============================================================================

/// Belief self-retrieval: query with belief statement, check if belief appears in results
///
/// Ground truth: beliefs table. MRR = average of 1/rank for each belief found.
/// Hit rate = fraction of beliefs found in top-K at all.
fn eval_belief_self_retrieval(
    conn: &Connection,
    engine: &QueryEngine,
    engine_name: &str,
) -> Result<BeliefSelfResults> {
    let mut stmt = conn.prepare("SELECT id, statement FROM beliefs ORDER BY id")?;
    let mut beliefs: Vec<(String, String)> = Vec::new();
    let mut rows = stmt.query([])?;
    while let Some(row) = rows.next()? {
        let id: String = row.get(0)?;
        let statement: String = row.get(1)?;
        beliefs.push((id, statement));
    }

    println!("Testing {} beliefs (self-retrieval)", beliefs.len());

    if beliefs.is_empty() {
        return Ok(BeliefSelfResults {
            engine: engine_name.to_string(),
            num_queries: 0,
            mrr: 0.0,
            hit_rate: 0.0,
        });
    }

    let k = 10;
    let mut total_rr = 0.0;
    let mut hits = 0;
    let mut num_queries = 0;

    for (id, statement) in &beliefs {
        let expected_doc_id = format!("belief:{}", id);

        if let Ok(results) = engine.query(statement, k) {
            let rank = results
                .iter()
                .position(|r| r.doc_id == expected_doc_id)
                .map(|pos| pos + 1); // 1-indexed

            if let Some(r) = rank {
                total_rr += 1.0 / r as f32;
                hits += 1;
            }

            num_queries += 1;

            if num_queries <= 5 {
                let rank_str = rank
                    .map(|r| format!("@{}", r))
                    .unwrap_or("miss".to_string());
                println!("  {}{}", id, rank_str);
            }
        }
    }

    if num_queries > 5 {
        println!("  ... and {} more beliefs", num_queries - 5);
    }

    let mrr = if num_queries > 0 {
        total_rr / num_queries as f32
    } else {
        0.0
    };
    let hit_rate = if num_queries > 0 {
        hits as f32 / num_queries as f32
    } else {
        0.0
    };

    Ok(BeliefSelfResults {
        engine: engine_name.to_string(),
        num_queries,
        mrr,
        hit_rate,
    })
}

/// Belief-code co-retrieval: query with belief statement, check for belief AND reached code
///
/// Split metrics:
/// - belief_present_rate: is belief:<id> in top-K?
/// - reach_recall@K: reached files in top-K / min(K, reach_count)
/// - co_retrieval_rate: belief present AND ≥1 reached file (the product claim)
fn eval_belief_code_co_retrieval(
    conn: &Connection,
    engine: &QueryEngine,
    engine_name: &str,
) -> Result<BeliefCoResults> {
    // Load beliefs that have code reach entries
    let mut stmt = conn.prepare(
        "SELECT b.id, b.statement, GROUP_CONCAT(bcr.file_path, '|') as files
         FROM beliefs b
         JOIN belief_code_reach bcr ON b.id = bcr.belief_id
         GROUP BY b.id
         HAVING COUNT(bcr.file_path) >= 1
         ORDER BY b.id",
    )?;

    let mut beliefs_with_reach: Vec<(String, String, Vec<String>)> = Vec::new();
    let mut rows = stmt.query([])?;
    while let Some(row) = rows.next()? {
        let id: String = row.get(0)?;
        let statement: String = row.get(1)?;
        let files_str: String = row.get(2)?;
        let files: Vec<String> = files_str.split('|').map(normalize_path).collect();
        beliefs_with_reach.push((id, statement, files));
    }

    println!(
        "Testing {} beliefs with code reach",
        beliefs_with_reach.len()
    );

    if beliefs_with_reach.is_empty() {
        return Ok(BeliefCoResults {
            engine: engine_name.to_string(),
            num_queries: 0,
            belief_present_rate: 0.0,
            reach_recall: 0.0,
            co_retrieval_rate: 0.0,
        });
    }

    let k = 10;
    let mut belief_present_count = 0;
    let mut total_reach_recall = 0.0;
    let mut co_retrieval_count = 0;
    let mut num_queries = 0;

    for (id, statement, reached_files) in &beliefs_with_reach {
        let expected_belief = format!("belief:{}", id);

        if let Ok(results) = engine.query(statement, k) {
            // Belief-present@K
            let belief_present = results.iter().any(|r| r.doc_id == expected_belief);
            if belief_present {
                belief_present_count += 1;
            }

            // Reach-hit@K: normalize by min(K, reach_count)
            let reached_set: HashSet<&str> = reached_files.iter().map(|f| f.as_str()).collect();
            let reach_hits = results
                .iter()
                .take(k)
                .filter(|r| {
                    let file = extract_file_from_doc_id(&r.doc_id);
                    reached_set.contains(file.as_str())
                })
                .count();
            let max_possible = k.min(reached_files.len());
            let recall = if max_possible > 0 {
                reach_hits as f32 / max_possible as f32
            } else {
                0.0
            };
            total_reach_recall += recall;

            // Co-retrieval: belief present AND ≥1 reached file
            if belief_present && reach_hits >= 1 {
                co_retrieval_count += 1;
            }

            num_queries += 1;

            if num_queries <= 5 {
                let bp = if belief_present { "" } else { "" };
                println!(
                    "  {} — belief:{} reach:{}/{} files",
                    id,
                    bp,
                    reach_hits,
                    reached_files.len()
                );
            }
        }
    }

    if num_queries > 5 {
        println!("  ... and {} more beliefs", num_queries - 5);
    }

    let belief_present_rate = if num_queries > 0 {
        belief_present_count as f32 / num_queries as f32
    } else {
        0.0
    };
    let reach_recall = if num_queries > 0 {
        total_reach_recall / num_queries as f32
    } else {
        0.0
    };
    let co_retrieval_rate = if num_queries > 0 {
        co_retrieval_count as f32 / num_queries as f32
    } else {
        0.0
    };

    Ok(BeliefCoResults {
        engine: engine_name.to_string(),
        num_queries,
        belief_present_rate,
        reach_recall,
        co_retrieval_rate,
    })
}

fn print_belief_self_results(results: &BeliefSelfResults) {
    println!("\nResults ({} beliefs):", results.num_queries);
    println!("  MRR:       {:.3}", results.mrr);
    println!("  Hit rate:  {:.1}%", results.hit_rate * 100.0);
}

fn print_belief_co_results(results: &BeliefCoResults) {
    println!(
        "\nResults ({} beliefs with code reach):",
        results.num_queries
    );
    println!(
        "  Belief present: {:.1}%",
        results.belief_present_rate * 100.0
    );
    println!("  Reach recall:   {:.1}%", results.reach_recall * 100.0);
    println!(
        "  Co-retrieval:   {:.1}% (belief + ≥1 code)",
        results.co_retrieval_rate * 100.0
    );
}

// ============================================================================
// Helpers
// ============================================================================

/// Extract file path from a FusedResult doc_id, normalized for comparison
///
/// Handles different oracle doc_id formats:
/// - "./src/main.rs::fn:main" → "src/main.rs" (SemanticOracle code facts)
/// - "src/main.rs" → "src/main.rs" (TemporalOracle co-changes)
/// - "persona:direct:..." → "persona:direct:..." (no file, won't match)
fn extract_file_from_doc_id(doc_id: &str) -> String {
    let path = if let Some(idx) = doc_id.find("::") {
        &doc_id[..idx]
    } else {
        doc_id
    };
    normalize_path(path)
}

/// Normalize path by stripping "./" prefix
fn normalize_path(path: &str) -> String {
    path.strip_prefix("./").unwrap_or(path).to_string()
}

/// Count results in top-K whose doc_id resolves to the expected file
fn count_file_hits(results: &[FusedResult], expected_file: &str, k: usize) -> usize {
    results
        .iter()
        .take(k)
        .filter(|r| extract_file_from_doc_id(&r.doc_id) == expected_file)
        .count()
}

fn get_file_type(path: &str) -> &'static str {
    let ext = path.rsplit('.').next().unwrap_or("");
    match ext {
        "rs" => "Rust source",
        "ts" => "TypeScript source",
        "js" => "JavaScript source",
        "py" => "Python source",
        "md" => "Markdown document",
        _ => "file",
    }
}

fn print_results(results: &EvalResults) {
    println!("\nResults ({} queries):", results.num_queries);
    println!("  Precision@5:  {:.1}%", results.precision_at_5 * 100.0);
    println!("  Precision@10: {:.1}%", results.precision_at_10 * 100.0);
    println!("  Random baseline: {:.2}%", results.random_baseline * 100.0);
    if results.random_baseline > 0.0 && results.precision_at_10 > 0.0 {
        println!(
            "  Improvement: {:.1}x over random",
            results.precision_at_10 / results.random_baseline
        );
    }
}

// ============================================================================
// Feedback Loop Evaluation (Phase 3)
// ============================================================================

use patina::eventlog;

/// Execute feedback loop evaluation - measure real-world precision
///
/// Materializes intermediate results into temp tables for performance,
/// then reports precision metrics from session query→commit correlation.
pub fn execute_feedback() -> Result<()> {
    println!("📊 Feedback Loop Evaluation\n");
    println!("Measuring real-world retrieval precision from session data...\n");

    let conn = Connection::open(eventlog::PATINA_DB)?;

    // Materialize commit files per session into a temp table (avoids repeated JSON parsing)
    conn.execute_batch(
        r#"
        DROP TABLE IF EXISTS _fb_commit_files;
        CREATE TEMP TABLE _fb_commit_files AS
        SELECT session_id, file_path FROM (
            SELECT
                json_extract(data, '$.session_id') as session_id,
                json_extract(f.value, '$.path') as file_path,
                ROW_NUMBER() OVER (
                    PARTITION BY json_extract(data, '$.sha'), json_extract(f.value, '$.path')
                    ORDER BY seq DESC
                ) as rn
            FROM eventlog, json_each(json_extract(data, '$.files')) as f
            WHERE event_type = 'git.commit'
              AND json_extract(data, '$.session_id') IS NOT NULL
        ) WHERE rn = 1;
        CREATE INDEX _fb_cf_session ON _fb_commit_files(session_id);
        CREATE INDEX _fb_cf_path ON _fb_commit_files(file_path);
        "#,
    )?;

    // Materialize query results with hits into a temp table.
    // Normalize doc_id: strip '::...' suffix and './' prefix before matching.
    conn.execute_batch(
        r#"
        DROP TABLE IF EXISTS _fb_query_hits;
        CREATE TEMP TABLE _fb_query_hits AS
        SELECT
            q_session_id as session_id,
            query,
            mode,
            query_time,
            doc_id as retrieved_doc_id,
            rank,
            score,
            CASE WHEN cf.file_path IS NOT NULL THEN 1 ELSE 0 END as is_hit
        FROM (
            SELECT
                json_extract(data, '$.session_id') as q_session_id,
                json_extract(data, '$.query') as query,
                json_extract(data, '$.mode') as mode,
                timestamp as query_time,
                json_extract(r.value, '$.doc_id') as doc_id,
                -- Normalize: strip '::...' suffix and './' prefix
                REPLACE(
                    CASE
                        WHEN INSTR(json_extract(r.value, '$.doc_id'), '::') > 0
                        THEN SUBSTR(json_extract(r.value, '$.doc_id'), 1,
                             INSTR(json_extract(r.value, '$.doc_id'), '::') - 1)
                        ELSE json_extract(r.value, '$.doc_id')
                    END,
                    './', '') as norm_doc_id,
                json_extract(r.value, '$.rank') as rank,
                json_extract(r.value, '$.score') as score
            FROM eventlog, json_each(json_extract(data, '$.results')) as r
            WHERE event_type = 'scry.query'
              AND json_extract(data, '$.session_id') IS NOT NULL
        ) q
        LEFT JOIN _fb_commit_files cf
            ON cf.session_id = q.q_session_id
            AND cf.file_path = q.norm_doc_id;
        "#,
    )?;

    // Get overall statistics
    let (total_queries, total_retrievals): (i64, i64) = conn.query_row(
        "SELECT COUNT(DISTINCT query), COUNT(*) FROM _fb_query_hits",
        [],
        |row| Ok((row.get(0)?, row.get(1)?)),
    )?;

    if total_queries == 0 {
        println!("No feedback data available yet.");
        println!("\nTo collect feedback data:");
        println!("  1. Start a session: /session-start");
        println!("  2. Run scry queries during development");
        println!("  3. Commit your changes");
        println!("  4. Run: patina scrape git");
        println!("  5. Then run: patina eval --feedback");
        return Ok(());
    }

    let total_hits: i64 = conn.query_row(
        "SELECT COUNT(*) FROM _fb_query_hits WHERE is_hit = 1",
        [],
        |row| row.get(0),
    )?;

    println!("━━━ Overall Statistics ━━━\n");
    println!("Queries with session data: {}", total_queries);
    println!("Total retrievals: {}", total_retrievals);
    println!("Retrievals that led to commits: {}", total_hits);
    println!(
        "Overall precision: {:.1}%",
        if total_retrievals > 0 {
            total_hits as f64 / total_retrievals as f64 * 100.0
        } else {
            0.0
        }
    );

    // Precision by rank
    println!("\n━━━ Precision by Rank ━━━\n");
    let mut stmt = conn.prepare(
        "SELECT rank, COUNT(*) as total, SUM(is_hit) as hits
         FROM _fb_query_hits
         GROUP BY rank
         ORDER BY rank",
    )?;

    let mut rows = stmt.query([])?;
    println!(
        "{:<8} {:>10} {:>10} {:>12}",
        "Rank", "Total", "Hits", "Precision"
    );
    println!("{}", "".repeat(44));

    while let Some(row) = rows.next()? {
        let rank: i64 = row.get(0)?;
        let total: i64 = row.get(1)?;
        let hits: i64 = row.get(2)?;
        let precision = if total > 0 {
            hits as f64 / total as f64 * 100.0
        } else {
            0.0
        };
        println!(
            "{:<8} {:>10} {:>10} {:>11.1}%",
            rank, total, hits, precision
        );
    }

    // Sessions with most feedback
    println!("\n━━━ Top Sessions by Queries ━━━\n");
    let mut stmt = conn.prepare(
        "SELECT session_id, COUNT(DISTINCT query) as queries,
                SUM(is_hit) as hits, COUNT(*) as retrievals
         FROM _fb_query_hits
         GROUP BY session_id
         ORDER BY queries DESC
         LIMIT 5",
    )?;

    let mut rows = stmt.query([])?;
    println!(
        "{:<20} {:>8} {:>10} {:>12}",
        "Session", "Queries", "Retrievals", "Precision"
    );
    println!("{}", "".repeat(54));

    while let Some(row) = rows.next()? {
        let session: String = row.get(0)?;
        let queries: i64 = row.get(1)?;
        let hits: i64 = row.get(2)?;
        let retrievals: i64 = row.get(3)?;
        let precision = if retrievals > 0 {
            hits as f64 / retrievals as f64 * 100.0
        } else {
            0.0
        };
        println!(
            "{:<20} {:>8} {:>10} {:>11.1}%",
            session, queries, retrievals, precision
        );
    }

    // High-value retrievals (files that were retrieved AND committed)
    println!("\n━━━ High-Value Retrievals ━━━\n");
    let mut stmt = conn.prepare(
        "SELECT retrieved_doc_id, COUNT(*) as times_retrieved, SUM(is_hit) as times_committed
         FROM _fb_query_hits
         WHERE is_hit = 1
         GROUP BY retrieved_doc_id
         ORDER BY times_committed DESC
         LIMIT 10",
    )?;

    let mut rows = stmt.query([])?;
    let mut has_hits = false;

    println!("{:<50} {:>12} {:>12}", "Document", "Retrieved", "Committed");
    println!("{}", "".repeat(76));

    while let Some(row) = rows.next()? {
        has_hits = true;
        let doc_id: String = row.get(0)?;
        let retrieved: i64 = row.get(1)?;
        let committed: i64 = row.get(2)?;
        // Truncate long doc_ids
        let display_id = if doc_id.len() > 48 {
            format!("...{}", &doc_id[doc_id.len() - 45..])
        } else {
            doc_id
        };
        println!("{:<50} {:>12} {:>12}", display_id, retrieved, committed);
    }

    if !has_hits {
        println!("(No retrievals have matched committed files yet)");
        println!("\nNote: Hits occur when retrieved doc_ids match committed file paths.");
        println!("Code queries (not session queries) are more likely to have hits.");
    }

    println!("\n{}", "".repeat(60));

    Ok(())
}

// ============================================================================
// Natural-Language Query Evaluation (Phase 2)
// ============================================================================

/// NL query test case loaded from JSON
#[derive(serde::Deserialize, Debug)]
struct NlQueryCase {
    query: String,
    expected: Vec<String>,
    category: String,
    split: String,
}

/// Aggregated NL eval metrics for one engine configuration
#[derive(Debug, Clone)]
struct NlMetrics {
    name: String,
    p5: f32,
    p10: f32,
    mrr: f32,
}

/// Score one engine against the NL test set, return aggregate metrics
fn score_nl_engine(engine: &QueryEngine, name: &str, cases: &[NlQueryCase]) -> Result<NlMetrics> {
    let mut total_p5 = 0.0f32;
    let mut total_p10 = 0.0f32;
    let mut total_rr = 0.0f32;

    for case in cases {
        let results = engine.query(&case.query, 10)?;
        let expected: HashSet<String> = case.expected.iter().map(|p| normalize_path(p)).collect();

        // Deduplicate by file — multiple doc_ids from the same file count once
        let unique_files_5: HashSet<String> = results
            .iter()
            .take(5)
            .map(|r| extract_file_from_doc_id(&r.doc_id))
            .filter(|f| expected.contains(f))
            .collect();
        let unique_files_10: HashSet<String> = results
            .iter()
            .take(10)
            .map(|r| extract_file_from_doc_id(&r.doc_id))
            .filter(|f| expected.contains(f))
            .collect();

        let denom_5 = expected.len().clamp(1, 5) as f32;
        let denom_10 = expected.len().clamp(1, 10) as f32;
        total_p5 += unique_files_5.len() as f32 / denom_5;
        total_p10 += unique_files_10.len() as f32 / denom_10;

        // MRR: rank of first hit (by file, not by doc_id — same result)
        total_rr += results
            .iter()
            .enumerate()
            .find(|(_, r)| expected.contains(&extract_file_from_doc_id(&r.doc_id)))
            .map(|(i, _)| 1.0 / (i as f32 + 1.0))
            .unwrap_or(0.0);
    }

    let n = cases.len();
    Ok(NlMetrics {
        name: name.to_string(),
        p5: total_p5 / n as f32,
        p10: total_p10 / n as f32,
        mrr: total_rr / n as f32,
    })
}

/// Score one engine against a subset of NL test cases (by reference)
fn score_nl_engine_refs(
    engine: &QueryEngine,
    name: &str,
    cases: &[&NlQueryCase],
) -> Result<NlMetrics> {
    let mut total_p5 = 0.0f32;
    let mut total_p10 = 0.0f32;
    let mut total_rr = 0.0f32;

    for case in cases {
        let results = engine.query(&case.query, 10)?;
        let expected: HashSet<String> = case.expected.iter().map(|p| normalize_path(p)).collect();

        let unique_files_5: HashSet<String> = results
            .iter()
            .take(5)
            .map(|r| extract_file_from_doc_id(&r.doc_id))
            .filter(|f| expected.contains(f))
            .collect();
        let unique_files_10: HashSet<String> = results
            .iter()
            .take(10)
            .map(|r| extract_file_from_doc_id(&r.doc_id))
            .filter(|f| expected.contains(f))
            .collect();

        let denom_5 = expected.len().clamp(1, 5) as f32;
        let denom_10 = expected.len().clamp(1, 10) as f32;
        total_p5 += unique_files_5.len() as f32 / denom_5;
        total_p10 += unique_files_10.len() as f32 / denom_10;

        total_rr += results
            .iter()
            .enumerate()
            .find(|(_, r)| expected.contains(&extract_file_from_doc_id(&r.doc_id)))
            .map(|(i, _)| 1.0 / (i as f32 + 1.0))
            .unwrap_or(0.0);
    }

    let n = cases.len();
    Ok(NlMetrics {
        name: name.to_string(),
        p5: total_p5 / n as f32,
        p10: total_p10 / n as f32,
        mrr: total_rr / n as f32,
    })
}

/// Execute NL query eval from curated test set
///
/// Loads queries from resources/eval/nl-queries.json, runs each through the
/// unified QueryEngine, and measures P@5, P@10, MRR against expected results.
/// Includes per-oracle ablation to measure each oracle's contribution.
pub fn execute_nl() -> Result<()> {
    println!("📊 Natural-Language Query Evaluation\n");
    println!("Testing retrieval quality with curated real-world queries...\n");

    // Load test set
    let test_path = "resources/eval/nl-queries.json";
    let content = std::fs::read_to_string(test_path).context(format!("Cannot read {test_path}"))?;
    let cases: Vec<NlQueryCase> =
        serde_json::from_str(&content).context("Failed to parse nl-queries.json")?;

    // --- Per-query detail for unified engine ---
    let unified = QueryEngine::new();

    let mut category_stats: HashMap<String, (f32, f32, f32, usize)> = HashMap::new();
    let mut split_stats: HashMap<String, (f32, f32, f32, usize)> = HashMap::new();

    let train_count = cases.iter().filter(|c| c.split == "train").count();
    let test_count = cases.iter().filter(|c| c.split == "test").count();
    println!(
        "Loaded {} test queries ({} train, {} test)\n",
        cases.len(),
        train_count,
        test_count
    );

    println!("{:<55} {:>6} {:>6} {:>6}", "Query", "P@5", "P@10", "RR");
    println!("{}", "".repeat(77));

    for case in &cases {
        let results = unified.query(&case.query, 10)?;
        let expected: HashSet<String> = case.expected.iter().map(|p| normalize_path(p)).collect();

        // Deduplicate by file — multiple doc_ids from the same file count once
        let unique_files_5: HashSet<String> = results
            .iter()
            .take(5)
            .map(|r| extract_file_from_doc_id(&r.doc_id))
            .filter(|f| expected.contains(f))
            .collect();
        let unique_files_10: HashSet<String> = results
            .iter()
            .take(10)
            .map(|r| extract_file_from_doc_id(&r.doc_id))
            .filter(|f| expected.contains(f))
            .collect();

        let denom_5 = expected.len().clamp(1, 5) as f32;
        let denom_10 = expected.len().clamp(1, 10) as f32;
        let p5 = unique_files_5.len() as f32 / denom_5;
        let p10 = unique_files_10.len() as f32 / denom_10;

        let rr = results
            .iter()
            .enumerate()
            .find(|(_, r)| expected.contains(&extract_file_from_doc_id(&r.doc_id)))
            .map(|(i, _)| 1.0 / (i as f32 + 1.0))
            .unwrap_or(0.0);

        let entry = category_stats
            .entry(case.category.clone())
            .or_insert((0.0, 0.0, 0.0, 0));
        entry.0 += p5;
        entry.1 += p10;
        entry.2 += rr;
        entry.3 += 1;

        let split_entry = split_stats
            .entry(case.split.clone())
            .or_insert((0.0, 0.0, 0.0, 0));
        split_entry.0 += p5;
        split_entry.1 += p10;
        split_entry.2 += rr;
        split_entry.3 += 1;

        let display_q = if case.query.len() > 53 {
            format!("{}...", &case.query[..50])
        } else {
            case.query.clone()
        };
        println!(
            "{:<55} {:>5.0}% {:>5.0}% {:>.3}",
            display_q,
            p5 * 100.0,
            p10 * 100.0,
            rr
        );
    }

    // Category breakdown
    println!("\n━━━ By Category ━━━\n");
    println!(
        "{:<20} {:>6} {:>8} {:>8} {:>8}",
        "Category", "N", "P@5", "P@10", "MRR"
    );
    println!("{}", "".repeat(54));

    let mut cats: Vec<_> = category_stats.iter().collect();
    cats.sort_by_key(|(k, _)| (*k).clone());
    for (cat, (p5, p10, rr, count)) in &cats {
        let n = *count as f32;
        println!(
            "{:<20} {:>6} {:>7.1}% {:>7.1}% {:>8.3}",
            cat,
            count,
            p5 / n * 100.0,
            p10 / n * 100.0,
            rr / n
        );
    }

    // Split breakdown (train vs test)
    println!("\n━━━ By Split (unified) ━━━\n");
    println!(
        "{:<20} {:>6} {:>8} {:>8} {:>8}",
        "Split", "N", "P@5", "P@10", "MRR"
    );
    println!("{}", "".repeat(54));

    for split_name in &["train", "test"] {
        if let Some((p5, p10, rr, count)) = split_stats.get(*split_name) {
            let n = *count as f32;
            println!(
                "{:<20} {:>6} {:>7.1}% {:>7.1}% {:>8.3}",
                split_name,
                count,
                p5 / n * 100.0,
                p10 / n * 100.0,
                rr / n
            );
        }
    }

    // --- Ablation: per-oracle contribution ---
    println!("\n━━━ Ablation: Per-Oracle Contribution ━━━\n");

    let oracles = ["semantic", "lexical", "temporal", "persona", "belief"];
    let mut ablation_results: Vec<NlMetrics> = Vec::new();

    // Unified baseline
    let unified_metrics = score_nl_engine(&unified, "unified (all)", &cases)?;
    ablation_results.push(unified_metrics.clone());

    // Each oracle in isolation
    for oracle_name in &oracles {
        let engine = QueryEngine::with_config(RetrievalConfig {
            oracle_filter: Some(vec![oracle_name.to_string()]),
            ..Default::default()
        });
        let metrics = score_nl_engine(&engine, &format!("{}-only", oracle_name), &cases)?;
        ablation_results.push(metrics);
    }

    // No-belief (all except belief)
    let no_belief = QueryEngine::with_config(RetrievalConfig {
        oracle_filter: Some(vec![
            "semantic".to_string(),
            "lexical".to_string(),
            "temporal".to_string(),
            "persona".to_string(),
        ]),
        ..Default::default()
    });
    let no_belief_metrics = score_nl_engine(&no_belief, "no-belief", &cases)?;
    ablation_results.push(no_belief_metrics);

    // Print ablation table
    println!(
        "{:<25} {:>8} {:>8} {:>8} {:>10}",
        "Pipeline", "P@5", "P@10", "MRR", "vs Unified"
    );
    println!("{}", "".repeat(63));

    let baseline_p10 = unified_metrics.p10;
    for m in &ablation_results {
        let delta = if m.name == "unified (all)" {
            "".to_string()
        } else {
            let d = (m.p10 - baseline_p10) * 100.0;
            format!("{:+.1}pp", d)
        };
        println!(
            "{:<25} {:>7.1}% {:>7.1}% {:>8.3} {:>10}",
            m.name,
            m.p5 * 100.0,
            m.p10 * 100.0,
            m.mrr,
            delta
        );
    }

    // Per-split ablation (unified only — quick view for tuning validation)
    let train_cases: Vec<&NlQueryCase> = cases.iter().filter(|c| c.split == "train").collect();
    let test_cases: Vec<&NlQueryCase> = cases.iter().filter(|c| c.split == "test").collect();

    if !train_cases.is_empty() && !test_cases.is_empty() {
        println!("\n━━━ Train vs Test (unified engine) ━━━\n");
        println!("{:<25} {:>8} {:>8} {:>8}", "Pipeline", "P@5", "P@10", "MRR");
        println!("{}", "".repeat(53));

        let train_m = score_nl_engine_refs(&unified, "unified (train)", &train_cases)?;
        let test_m = score_nl_engine_refs(&unified, "unified (test)", &test_cases)?;

        for m in &[&train_m, &test_m] {
            println!(
                "{:<25} {:>7.1}% {:>7.1}% {:>8.3}",
                m.name,
                m.p5 * 100.0,
                m.p10 * 100.0,
                m.mrr,
            );
        }

        let delta_p10 = (test_m.p10 - train_m.p10) * 100.0;
        println!(
            "\n  Train-test gap: {:+.1}pp P@10 (negative = potential overfit)",
            delta_p10
        );
    }

    // Summary
    println!("\n━━━ Summary ━━━\n");
    println!(
        "  Queries:     {} ({} train, {} test)",
        cases.len(),
        train_count,
        test_count
    );
    println!("  Mean P@5:    {:.1}%", unified_metrics.p5 * 100.0);
    println!("  Mean P@10:   {:.1}%", unified_metrics.p10 * 100.0);
    println!("  MRR:         {:.3}", unified_metrics.mrr);

    Ok(())
}

// ============================================================================
// Post-split eval modes (Phase 4: Eval Redesign)
// ============================================================================

/// Independent assay eval — tests factual retrieval (FTS5) in isolation
pub fn execute_assay() -> Result<()> {
    internal::assay_eval::execute()
}

/// Independent scry eval — tests semantic retrieval (vectors) + scry-vs-assay comparison
pub fn execute_scry() -> Result<()> {
    internal::scry_eval::execute()
}

/// Raw E5 diagnostic — brute-force cosine without projection (Phase 5d)
pub fn execute_scry_raw() -> Result<()> {
    internal::scry_eval::execute_raw()
}

/// Combined eval — tests the full retrieval pipeline (assay + scry together)
pub fn execute_combined() -> Result<()> {
    internal::combined_eval::execute()
}