pathfinder-mcp 0.22.0

Pathfinder — The Headless IDE MCP Server for AI Coding Agents
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
use crate::server::types::{Detail, ExploreParams};
use pathfinder_common::config::PathfinderConfig;
use pathfinder_common::sandbox::Sandbox;
use pathfinder_common::types::{Visibility, WorkspaceRoot};
use pathfinder_search::MockScout;
use pathfinder_treesitter::mock::MockSurgeon;
use pathfinder_treesitter::repo_map::RepoMapResult;
use pathfinder_treesitter::SurgeonError;
use std::collections::HashMap;
use std::sync::Arc;
use tempfile::tempdir;

fn default_params() -> ExploreParams {
    ExploreParams {
        path: ".".to_owned(),
        detail: Detail::Symbols,
        changed_since: String::new(),
        max_tokens: 16_000,
        max_tokens_per_file: 2_000,
        depth: 5,
        visibility: Visibility::Public,
        include_extensions: vec![],
        exclude_extensions: vec![],
    }
}

fn make_server(surgeon: MockSurgeon) -> (crate::server::PathfinderServer, tempfile::TempDir) {
    let ws_dir = tempdir().expect("tempdir");
    let ws = WorkspaceRoot::new(ws_dir.path()).expect("workspace");
    let config = PathfinderConfig::default();
    let sandbox = Sandbox::new(ws.path(), &config.sandbox);
    let server = crate::server::PathfinderServer::with_all_engines(
        ws,
        config,
        sandbox,
        Arc::new(MockScout::default()),
        Arc::new(surgeon),
        Arc::new(pathfinder_lsp::NoOpLawyer),
    );
    (server, ws_dir)
}

fn ok_result() -> RepoMapResult {
    RepoMapResult {
        skeleton: "# skeleton".to_owned(),
        tech_stack: vec!["rust".to_owned()],
        files_scanned: 3,
        files_truncated: 0,
        truncated_paths: vec![],
        files_in_scope: 3,
        coverage_percent: 100,
        version_hashes: HashMap::new(),
    }
}

// ── happy path ──────────────────────────────────────────────────────────

#[tokio::test]
async fn test_get_repo_map_returns_skeleton() {
    let surgeon = MockSurgeon::default();
    surgeon
        .generate_skeleton_results
        .lock()
        .unwrap()
        .push(Ok(ok_result()));
    let (server, _dir) = make_server(surgeon);

    let result = server.get_repo_map_impl(default_params()).await;
    assert!(result.is_ok(), "should succeed: {result:?}");
    let tool_result = result.unwrap();
    let text = tool_result
        .content
        .first()
        .and_then(|c| {
            if let rmcp::model::RawContent::Text(t) = &c.raw {
                Some(t.text.clone())
            } else {
                None
            }
        })
        .unwrap_or_default();
    assert!(text.contains("skeleton"), "skeleton text should be present");
}

// ── sandbox rejection ────────────────────────────────────────────────────

#[tokio::test]
async fn test_get_repo_map_rejects_sandbox_denied_path() {
    let (server, _dir) = make_server(MockSurgeon::default());
    let mut params = default_params();
    params.path = ".git/HEAD".to_owned(); // hardcoded deny pattern

    let result = server.get_repo_map_impl(params).await;
    assert!(result.is_err(), "sandbox should deny .git paths");
    let err = result.unwrap_err();
    let code = err
        .data
        .as_ref()
        .and_then(|d| d.get("error"))
        .and_then(|v| v.as_str())
        .unwrap_or("");
    assert_eq!(code, "ACCESS_DENIED");
}

// ── surgeon error ────────────────────────────────────────────────────────

#[tokio::test]
async fn test_get_repo_map_propagates_surgeon_error() {
    let surgeon = MockSurgeon::default();
    surgeon
        .generate_skeleton_results
        .lock()
        .unwrap()
        .push(Err(SurgeonError::Io(std::sync::Arc::new(
            std::io::Error::other("disk full"),
        ))));
    let (server, _dir) = make_server(surgeon);

    let result = server.get_repo_map_impl(default_params()).await;
    assert!(result.is_err(), "surgeon error should propagate");
}

// ── changed_since: empty file list returns early response ────────────────

#[tokio::test]
async fn test_get_repo_map_changed_since_empty_returns_early() {
    // MockSurgeon has no results queued — if skeleton is called, it panics.
    // The empty-changes path should short-circuit before calling surgeon.
    let ws_dir = tempdir().expect("tempdir");
    let ws = WorkspaceRoot::new(ws_dir.path()).expect("workspace");

    // Initialise an empty git repo so get_changed_files_since succeeds with []
    std::process::Command::new("git")
        .args(["init", "-q"])
        .current_dir(ws_dir.path())
        .status()
        .expect("git init");
    std::process::Command::new("git")
        .args(["commit", "--allow-empty", "-m", "init"])
        .env("GIT_AUTHOR_NAME", "test")
        .env("GIT_AUTHOR_EMAIL", "t@t.t")
        .env("GIT_COMMITTER_NAME", "test")
        .env("GIT_COMMITTER_EMAIL", "t@t.t")
        .current_dir(ws_dir.path())
        .status()
        .expect("git commit");

    let config = PathfinderConfig::default();
    let sandbox = Sandbox::new(ws.path(), &config.sandbox);
    let server = crate::server::PathfinderServer::with_all_engines(
        ws,
        config,
        sandbox,
        Arc::new(MockScout::default()),
        Arc::new(MockSurgeon::default()), // no results queued
        Arc::new(pathfinder_lsp::NoOpLawyer),
    );

    let mut params = default_params();
    params.changed_since = "HEAD".to_owned(); // nothing changed since HEAD

    let result = server.get_repo_map_impl(params).await;
    assert!(result.is_ok(), "empty changed_since should succeed");
    let tool_result = result.unwrap();
    let text = tool_result
        .content
        .first()
        .and_then(|c| {
            if let rmcp::model::RawContent::Text(t) = &c.raw {
                Some(t.text.clone())
            } else {
                None
            }
        })
        .unwrap_or_default();
    assert!(
        text.contains("No files changed"),
        "should return empty-changes message, got: {text}"
    );
}

// ── changed_since: git failure falls back to full map ────────────────────

#[tokio::test]
async fn test_get_repo_map_changed_since_git_failure_falls_back() {
    let surgeon = MockSurgeon::default();
    surgeon
        .generate_skeleton_results
        .lock()
        .unwrap()
        .push(Ok(ok_result()));
    let (server, _dir) = make_server(surgeon);

    let mut params = default_params();
    // Use a ref that doesn't exist → git error → fallback
    params.changed_since = "nonexistent-ref-xyzzy".to_owned();

    let result = server.get_repo_map_impl(params).await;
    assert!(
        result.is_ok(),
        "git failure should fall back to full map: {result:?}"
    );
    // Metadata should reflect degraded=true
    let tool_result = result.unwrap();
    let meta = tool_result.structured_content.as_ref().unwrap();
    assert_eq!(
        meta.get("degraded").and_then(serde_json::Value::as_bool),
        Some(true),
        "degraded flag should be set on git failure"
    );
}

/// LT-4: Verify that `get_repo_map` triggers pre-warm for detected languages.
///
/// This test verifies that the warmup spawn doesn't panic even with
/// a `NoOpLawyer` (which has default no-op `warm_start_for_languages`).
#[tokio::test]
async fn test_get_repo_map_triggers_lt4_prewarm() {
    let mut result = ok_result();
    result.tech_stack = vec!["rust".to_owned(), "go".to_owned()];

    let surgeon = MockSurgeon::default();
    surgeon
        .generate_skeleton_results
        .lock()
        .unwrap()
        .push(Ok(result));
    let (server, _dir) = make_server(surgeon);

    let result = server.get_repo_map_impl(default_params()).await;
    assert!(result.is_ok(), "get_repo_map should succeed: {result:?}");

    // Give the spawned warm_start_for_languages task a chance to run.
    // With NoOpLawyer, it's a no-op, but we verify no panics occur.
    tokio::time::sleep(std::time::Duration::from_millis(50)).await;
}

// ── 1.3 lsp_status flat map ──────────────────────────────────────────────

/// Verify that `derive_lsp_status` returns `None` when the capability map is empty.
/// (no LSP processes running → field absent from JSON)
#[test]
fn test_derive_lsp_status_empty_map_returns_none() {
    let empty: std::collections::HashMap<String, pathfinder_lsp::types::LspLanguageStatus> =
        std::collections::HashMap::new();
    assert!(
        super::derive_lsp_status(&empty).is_none(),
        "empty capability map must produce None lsp_status"
    );
}

/// Verify `derive_lsp_status` produces the correct status strings.
/// Matches `lsp_health_impl` two-phase readiness model:
/// - `navigation_ready=Some(true)` → `"ready"`
/// - `navigation_ready=Some(false)` OR `indexing_complete=Some(false)` → `"warming_up"`
/// - `uptime_seconds=Some(_)` but no capability info → `"starting"`
/// - neither → `"unavailable"`
#[allow(clippy::too_many_lines)]
#[test]
fn test_derive_lsp_status_correct_status_strings() {
    use pathfinder_lsp::types::LspLanguageStatus;

    let mut map = std::collections::HashMap::new();

    // ready: navigation_ready = Some(true)
    map.insert(
        "rust".to_owned(),
        LspLanguageStatus {
            validation: false,
            reason: String::new(),
            navigation_ready: Some(true),
            indexing_complete: None,
            uptime_seconds: Some(30),
            diagnostics_strategy: None,
            supports_definition: None,
            supports_call_hierarchy: None,
            supports_diagnostics: None,
            supports_formatting: None,
            server_name: None,
            indexing_source: None,
            indexing_duration_secs: None,
            indexing_progress_percent: None,
            registrations_received: None,
        },
    );

    // warming_up: navigation_ready = Some(false)
    map.insert(
        "csharp".to_owned(),
        LspLanguageStatus {
            validation: false,
            reason: String::new(),
            navigation_ready: Some(false),
            indexing_complete: None,
            uptime_seconds: Some(15),
            diagnostics_strategy: None,
            supports_definition: None,
            supports_call_hierarchy: None,
            supports_diagnostics: None,
            supports_formatting: None,
            server_name: None,
            indexing_source: None,
            indexing_duration_secs: None,
            indexing_progress_percent: None,
            registrations_received: None,
        },
    );

    // warming_up: indexing_complete = Some(false)
    map.insert(
        "go".to_owned(),
        LspLanguageStatus {
            validation: false,
            reason: String::new(),
            navigation_ready: None,
            indexing_complete: Some(false),
            uptime_seconds: Some(10),
            diagnostics_strategy: None,
            supports_definition: None,
            supports_call_hierarchy: None,
            supports_diagnostics: None,
            supports_formatting: None,
            server_name: None,
            indexing_source: None,
            indexing_duration_secs: None,
            indexing_progress_percent: None,
            registrations_received: None,
        },
    );

    // starting: uptime present, but no capability signals yet (lazy start)
    map.insert(
        "typescript".to_owned(),
        LspLanguageStatus {
            validation: false,
            reason: String::new(),
            navigation_ready: None,
            indexing_complete: None,
            uptime_seconds: Some(5),
            diagnostics_strategy: None,
            supports_definition: None,
            supports_call_hierarchy: None,
            supports_diagnostics: None,
            supports_formatting: None,
            server_name: None,
            indexing_source: None,
            indexing_duration_secs: None,
            indexing_progress_percent: None,
            registrations_received: None,
        },
    );

    // unavailable: no uptime, no navigation_ready
    map.insert(
        "python".to_owned(),
        LspLanguageStatus {
            validation: false,
            reason: String::new(),
            navigation_ready: None,
            indexing_complete: None,
            uptime_seconds: None,
            diagnostics_strategy: None,
            supports_definition: None,
            supports_call_hierarchy: None,
            supports_diagnostics: None,
            supports_formatting: None,
            server_name: None,
            indexing_source: None,
            indexing_duration_secs: None,
            indexing_progress_percent: None,
            registrations_received: None,
        },
    );

    let result = super::derive_lsp_status(&map).expect("non-empty map must return Some");

    assert_eq!(result.get("rust").map(String::as_str), Some("ready"));
    assert_eq!(result.get("csharp").map(String::as_str), Some("warming_up"));
    assert_eq!(result.get("go").map(String::as_str), Some("warming_up"));
    assert_eq!(
        result.get("typescript").map(String::as_str),
        Some("starting")
    );
    assert_eq!(
        result.get("python").map(String::as_str),
        Some("unavailable")
    );
}

/// Verify that LSP pre-warm is NOT triggered when `tech_stack` is empty.
#[tokio::test]
async fn test_get_repo_map_no_prewarm_when_tech_stack_empty() {
    let mut result = ok_result();
    result.tech_stack = vec![]; // Empty tech stack

    let surgeon = MockSurgeon::default();
    surgeon
        .generate_skeleton_results
        .lock()
        .unwrap()
        .push(Ok(result));
    let (server, _dir) = make_server(surgeon);

    let result = server.get_repo_map_impl(default_params()).await;
    assert!(result.is_ok(), "get_repo_map should succeed: {result:?}");

    // Give any spawned tasks a chance to run (there shouldn't be any)
    tokio::time::sleep(std::time::Duration::from_millis(50)).await;
    // No panic means the warm_start was not called (NoOpLawyer would panic if called unexpectedly)
}

/// Verify auto-scaling logic for large projects (>20 source files).
#[tokio::test]
async fn test_get_repo_map_auto_scaling_for_large_project() {
    let surgeon = MockSurgeon::default();
    surgeon
        .generate_skeleton_results
        .lock()
        .unwrap()
        .push(Ok(ok_result()));
    let (server, ws_dir) = make_server(surgeon);

    // Create >20 source files to trigger auto-scaling
    std::fs::create_dir_all(ws_dir.path().join("src")).unwrap();
    for i in 0..25 {
        std::fs::write(
            ws_dir.path().join(format!("src/file{i}.rs")),
            format!("fn func_{i}() {{}}"),
        )
        .unwrap();
    }

    let mut params = default_params();
    // Use default max_tokens to trigger auto-scaling
    params.max_tokens = 16_000;

    let result = server.get_repo_map_impl(params).await;
    assert!(result.is_ok(), "get_repo_map should succeed: {result:?}");
}

// ── Detail::Structure token clamping ────────────────────────────────────

#[tokio::test]
async fn test_get_repo_map_detail_structure_clamps_tokens() {
    let surgeon = MockSurgeon::default();
    surgeon
        .generate_skeleton_results
        .lock()
        .unwrap()
        .push(Ok(ok_result()));
    let (server, _dir) = make_server(surgeon);

    let mut params = default_params();
    params.detail = Detail::Structure;
    params.max_tokens = 10_000; // Should be clamped to min(10_000, 4_000) = 4_000

    let result = server.get_repo_map_impl(params).await;
    assert!(
        result.is_ok(),
        "Detail::Structure should succeed: {result:?}"
    );
    let tool_result = result.unwrap();
    let meta = tool_result.structured_content.as_ref().unwrap();
    let max_tokens_used = meta
        .get("max_tokens_used")
        .and_then(serde_json::Value::as_u64)
        .unwrap_or(0);
    assert_eq!(
        max_tokens_used, 4_000,
        "Detail::Structure should clamp max_tokens to 4000, got {max_tokens_used}"
    );
}

// ── Detail::Files depth + token clamping ────────────────────────────────

#[tokio::test]
async fn test_get_repo_map_detail_files_clamps_depth_and_tokens() {
    let surgeon = MockSurgeon::default();
    surgeon
        .generate_skeleton_results
        .lock()
        .unwrap()
        .push(Ok(ok_result()));
    let (server, _dir) = make_server(surgeon);

    let mut params = default_params();
    params.detail = Detail::Files;
    params.depth = 10; // Should be clamped to min(10, 3) = 3
    params.max_tokens = 20_000; // Should be clamped to min(20_000, 8_000) = 8_000

    let result = server.get_repo_map_impl(params).await;
    assert!(result.is_ok(), "Detail::Files should succeed: {result:?}");
    let tool_result = result.unwrap();
    let meta = tool_result.structured_content.as_ref().unwrap();
    let max_tokens_used = meta
        .get("max_tokens_used")
        .and_then(serde_json::Value::as_u64)
        .unwrap_or(0);
    assert_eq!(
        max_tokens_used, 8_000,
        "Detail::Files should clamp max_tokens to 8000, got {max_tokens_used}"
    );
}

// ── Degraded text includes notice prefix ────────────────────────────────

#[tokio::test]
async fn test_get_repo_map_degraded_text_contains_notice() {
    let surgeon = MockSurgeon::default();
    surgeon
        .generate_skeleton_results
        .lock()
        .unwrap()
        .push(Ok(ok_result()));
    let (server, _dir) = make_server(surgeon);

    let mut params = default_params();
    // Use a ref that doesn't exist → git error → fallback → degraded=true
    params.changed_since = "nonexistent-ref-for-notice-test".to_owned();

    let result = server.get_repo_map_impl(params).await;
    assert!(
        result.is_ok(),
        "git failure should fall back to full map: {result:?}"
    );
    let tool_result = result.unwrap();

    // Extract the text content
    let text = tool_result
        .content
        .first()
        .and_then(|c| {
            if let rmcp::model::RawContent::Text(t) = &c.raw {
                Some(t.text.clone())
            } else {
                None
            }
        })
        .unwrap_or_default();

    // Degraded text should have a notice prefix (from format_degraded_notice)
    assert!(
        text.contains("DEGRADED") || text.contains("degraded"),
        "degraded text should contain notice, got: {text}"
    );
    assert!(
        text.contains("skeleton"),
        "degraded text should still contain skeleton content"
    );
}

// ── mutually exclusive extensions error ───────────────────────────────

#[tokio::test]
async fn test_get_repo_map_mutually_exclusive_extensions_error() {
    let (server, _dir) = make_server(MockSurgeon::default());
    let mut params = default_params();
    params.include_extensions = vec!["rs".to_owned()];
    params.exclude_extensions = vec!["go".to_owned()];

    let result = server.get_repo_map_impl(params).await;
    assert!(
        result.is_err(),
        "should fail when both include and exclude extensions are provided"
    );
    let err = result.unwrap_err();
    assert_eq!(
        err.code,
        rmcp::model::ErrorCode::INVALID_PARAMS,
        "should be invalid params error"
    );
    assert!(
        err.message.contains("mutually exclusive"),
        "error message should mention mutual exclusion, got: {:?}",
        err.message
    );
}

#[tokio::test]
async fn test_get_repo_map_hint_when_coverage_under_100() {
    let mut low_cov = ok_result();
    low_cov.coverage_percent = 75; // Under 100%
    low_cov.files_scanned = 3;
    low_cov.files_in_scope = 4; // 3/4 = 75%

    let surgeon = MockSurgeon::default();
    surgeon
        .generate_skeleton_results
        .lock()
        .unwrap()
        .push(Ok(low_cov));
    let (server, _dir) = make_server(surgeon);

    let result = server.get_repo_map_impl(default_params()).await;
    assert!(result.is_ok(), "should succeed");
    let tool_result = result.unwrap();

    // Check text response contains hint with expected components
    let text = tool_result
        .content
        .first()
        .and_then(|c| {
            if let rmcp::model::RawContent::Text(t) = &c.raw {
                Some(t.text.clone())
            } else {
                None
            }
        })
        .unwrap_or_default();
    assert!(
        text.contains("Hint: Repository map is incomplete"),
        "text should contain the hint, got: {text}"
    );
    assert!(
        text.contains("3/4"),
        "hint should include files_scanned/files_in_scope, got: {text}"
    );
    assert!(
        text.contains("at least"),
        "hint should include a suggested token count, got: {text}"
    );
    // Suggested value must be >= current budget (16000) — regression guard for div_ceil logic
    assert!(
        text.contains("16000") || {
            // extract the suggested number after "at least"
            text.split("at least")
                .nth(1)
                .and_then(|s| s.split_whitespace().next())
                .and_then(|n| n.trim_end_matches('.').parse::<u64>().ok())
                .is_some_and(|n| n >= 16_000)
        },
        "suggested token count should be >= current budget 16000, got: {text}"
    );

    // Check metadata contains hint
    let meta = tool_result.structured_content.as_ref().unwrap();
    assert!(
        meta.get("hint")
            .and_then(serde_json::Value::as_str)
            .unwrap()
            .contains("Repository map is incomplete"),
        "metadata hint should be set, got: {:?}",
        meta.get("hint")
    );
}

/// Coverage=0% exercises the `saturating_mul(2)` fallback in the hint logic.
/// Must not panic or overflow, and must still emit the hint message.
#[tokio::test]
async fn test_get_repo_map_hint_coverage_zero_fallback() {
    let mut zero_cov = ok_result();
    zero_cov.coverage_percent = 0;
    zero_cov.files_scanned = 0;
    zero_cov.files_in_scope = 10;

    let surgeon = MockSurgeon::default();
    surgeon
        .generate_skeleton_results
        .lock()
        .unwrap()
        .push(Ok(zero_cov));
    let (server, _dir) = make_server(surgeon);

    let result = server.get_repo_map_impl(default_params()).await;
    assert!(result.is_ok(), "should succeed even with 0% coverage");
    let tool_result = result.unwrap();

    let text = tool_result
        .content
        .first()
        .and_then(|c| {
            if let rmcp::model::RawContent::Text(t) = &c.raw {
                Some(t.text.clone())
            } else {
                None
            }
        })
        .unwrap_or_default();
    assert!(
        text.contains("Hint: Repository map is incomplete"),
        "hint should be present for 0% coverage, got: {text}"
    );
    assert!(
        text.contains("0/10"),
        "hint should show 0/10 files, got: {text}"
    );
}

#[tokio::test]
async fn test_explore_suggested_max_tokens_present_when_truncated() {
    let mut low_cov = ok_result();
    low_cov.coverage_percent = 75;
    low_cov.files_scanned = 3;
    low_cov.files_in_scope = 4;

    let surgeon = MockSurgeon::default();
    surgeon
        .generate_skeleton_results
        .lock()
        .unwrap()
        .push(Ok(low_cov));
    let (server, _dir) = make_server(surgeon);

    let result = server.get_repo_map_impl(default_params()).await;
    assert!(result.is_ok());
    let tool_result = result.unwrap();
    let meta = tool_result.structured_content.as_ref().unwrap();

    let suggested = meta
        .get("suggested_max_tokens")
        .and_then(serde_json::Value::as_u64);
    assert!(
        suggested.is_some(),
        "suggested_max_tokens should be present when coverage < 100%"
    );
}

#[tokio::test]
async fn test_explore_suggested_max_tokens_none_when_full_coverage() {
    let surgeon = MockSurgeon::default();
    surgeon
        .generate_skeleton_results
        .lock()
        .unwrap()
        .push(Ok(ok_result()));
    let (server, _dir) = make_server(surgeon);

    let result = server.get_repo_map_impl(default_params()).await;
    assert!(result.is_ok());
    let tool_result = result.unwrap();
    let meta = tool_result.structured_content.as_ref().unwrap();

    assert!(
        meta.get("suggested_max_tokens").is_none(),
        "suggested_max_tokens should be absent when coverage == 100%"
    );
}

#[tokio::test]
async fn test_explore_suggested_max_tokens_rounded_to_4000() {
    let mut low_cov = ok_result();
    low_cov.coverage_percent = 75; // 16000 / 0.75 = 21333 -> ceil(21333/4000)*4000 = 24000
    low_cov.files_scanned = 3;
    low_cov.files_in_scope = 4;

    let surgeon = MockSurgeon::default();
    surgeon
        .generate_skeleton_results
        .lock()
        .unwrap()
        .push(Ok(low_cov));
    let (server, _dir) = make_server(surgeon);

    let result = server.get_repo_map_impl(default_params()).await;
    assert!(result.is_ok());
    let tool_result = result.unwrap();
    let meta = tool_result.structured_content.as_ref().unwrap();

    let suggested = meta
        .get("suggested_max_tokens")
        .and_then(serde_json::Value::as_u64)
        .unwrap();
    assert_eq!(
        suggested, 24000,
        "suggested_max_tokens should round up to nearest 4000"
    );
}

#[tokio::test]
async fn test_explore_suggested_max_tokens_capped_at_100000() {
    let mut low_cov = ok_result();
    low_cov.coverage_percent = 5; // 16000 / 0.05 = 320000 -> capped at 100000
    low_cov.files_scanned = 1;
    low_cov.files_in_scope = 20;

    let surgeon = MockSurgeon::default();
    surgeon
        .generate_skeleton_results
        .lock()
        .unwrap()
        .push(Ok(low_cov));
    let (server, _dir) = make_server(surgeon);

    let result = server.get_repo_map_impl(default_params()).await;
    assert!(result.is_ok());
    let tool_result = result.unwrap();
    let meta = tool_result.structured_content.as_ref().unwrap();

    let suggested = meta
        .get("suggested_max_tokens")
        .and_then(serde_json::Value::as_u64)
        .unwrap();
    assert_eq!(
        suggested, 100_000,
        "suggested_max_tokens should be capped at 100000"
    );
}

/// Coverage 0% with default budget: suggested = `saturating_mul(2)` = 32,000.
/// Verifies the structured metadata field is populated in the zero-coverage fallback path
/// (the existing hint text test only checked the text output, not the metadata).
#[tokio::test]
async fn test_explore_suggested_max_tokens_present_when_coverage_zero() {
    let mut zero_cov = ok_result();
    zero_cov.coverage_percent = 0;
    zero_cov.files_scanned = 0;
    zero_cov.files_in_scope = 10;

    let surgeon = MockSurgeon::default();
    surgeon
        .generate_skeleton_results
        .lock()
        .unwrap()
        .push(Ok(zero_cov));
    let (server, _dir) = make_server(surgeon);

    let result = server.get_repo_map_impl(default_params()).await;
    assert!(result.is_ok());
    let tool_result = result.unwrap();
    let meta = tool_result.structured_content.as_ref().unwrap();

    let suggested = meta
        .get("suggested_max_tokens")
        .and_then(serde_json::Value::as_u64);
    assert!(
        suggested.is_some(),
        "suggested_max_tokens must be present for 0% coverage"
    );
    // default_params uses max_tokens=16,000; saturating_mul(2) = 32,000 (under 100k cap)
    assert_eq!(
        suggested.unwrap(),
        32_000,
        "suggested should be 2x current budget for 0% coverage"
    );
}

/// Regression guard: with `max_tokens=80,000` and 0% coverage, `saturating_mul(2)` = 160,000.
/// Without the `.min(100_000)` cap that was missing from the else branch, this would exceed
/// the server's hard upper bound and cause an agent retry loop (server clamps to 100k,
/// result is still 0%, suggestion is still 160k — infinite cycle).
#[tokio::test]
async fn test_explore_suggested_max_tokens_capped_at_100000_for_zero_coverage() {
    let mut zero_cov = ok_result();
    zero_cov.coverage_percent = 0;
    zero_cov.files_scanned = 0;
    zero_cov.files_in_scope = 50;

    let surgeon = MockSurgeon::default();
    surgeon
        .generate_skeleton_results
        .lock()
        .unwrap()
        .push(Ok(zero_cov));
    let (server, _dir) = make_server(surgeon);

    // Use a large explicit max_tokens (80,000) so 2x = 160,000 would exceed the 100k cap.
    // Explicit value != default_max_tokens() so auto-scaling is bypassed.
    let mut params = default_params();
    params.max_tokens = 80_000;

    let result = server.get_repo_map_impl(params).await;
    assert!(result.is_ok());
    let tool_result = result.unwrap();
    let meta = tool_result.structured_content.as_ref().unwrap();

    let suggested = meta
        .get("suggested_max_tokens")
        .and_then(serde_json::Value::as_u64)
        .unwrap();
    assert_eq!(
        suggested, 100_000,
        "suggested_max_tokens must be capped at 100,000 even in the 0% coverage fallback"
    );
}