parley-cli 0.2.0

Terminal-first review tool for AI-generated code changes
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
//! AI session state and operations.
//!
//! Handles AI task lifecycle, progress tracking, and session management.

use super::helpers::format_timestamp_utc;
use super::*;
use crate::services::ai_session::json_text::collect_named_text;
use crate::utils::time::now_ms_utc;
use anyhow::{Context, Result};
use crossterm::event::{KeyCode, KeyEvent};
use std::collections::VecDeque;
use std::path::{Path, PathBuf};
use std::time::{Duration, Instant};
use tokio::fs;
use tokio::io::AsyncWriteExt;
use tokio::sync::mpsc;

const AI_TASK_LOG_HEARTBEAT_INTERVAL: Duration = Duration::from_secs(2);
const AI_LOG_FILE_NAME: &str = "ai.log";

impl TuiApp {
    pub(crate) fn dismiss_ai_progress_popup(&mut self) {
        self.ai_progress_visible = false;
    }

    pub(crate) fn dismiss_ai_activity_overlay(&mut self) {
        self.ai_activity_visible = false;
    }

    pub(crate) fn toggle_ai_progress_popup(&mut self) {
        if self.ai_progress_visible {
            self.ai_progress_visible = false;
            self.status_line = "ai progress popup hidden".into();
            return;
        }

        self.dismiss_blocking_overlays();
        self.ai_progress_visible = true;
        self.selected_ai_log_session_id = None;
        self.ai_progress_scroll_end();
        self.mark_ai_sessions_for_file_read(&self.ai_log_file_path());
        self.status_line = "ai progress popup visible".into();
    }

    pub(crate) fn toggle_ai_activity_overlay(&mut self) {
        if self.ai_activity_visible {
            self.ai_activity_visible = false;
            self.status_line = "ai activity hidden".into();
            return;
        }

        self.dismiss_blocking_overlays();
        self.ai_activity_visible = true;
        self.ai_activity_selected = self
            .ai_activity_selected
            .min(self.ai_activity_entries().len().saturating_sub(1));
        self.status_line = "ai activity visible".into();
    }

    pub(crate) fn ai_progress_scroll_up(&mut self, lines: usize) {
        if lines == 0 {
            return;
        }
        self.ai_progress_follow_tail = false;
        self.ai_progress_scroll = self.ai_progress_scroll.saturating_sub(lines);
    }

    pub(crate) fn ai_progress_scroll_down(&mut self, lines: usize) {
        if lines == 0 {
            return;
        }
        self.ai_progress_scroll = self.ai_progress_scroll.saturating_add(lines);
    }

    pub(crate) fn ai_progress_scroll_home(&mut self) {
        self.ai_progress_follow_tail = false;
        self.ai_progress_scroll = 0;
    }

    pub(crate) fn ai_progress_scroll_end(&mut self) {
        self.ai_progress_follow_tail = true;
        self.ai_progress_scroll = usize::MAX;
    }

    pub(crate) fn ai_progress_resolved_scroll(&mut self, max_scroll: usize) -> usize {
        if self.ai_progress_follow_tail {
            self.ai_progress_scroll = max_scroll;
            return max_scroll;
        }

        let clamped = self.ai_progress_scroll.min(max_scroll);
        self.ai_progress_scroll = clamped;
        clamped
    }

    pub(crate) fn ai_activity_scroll_up(&mut self, lines: usize) {
        self.ai_activity_scroll = self.ai_activity_scroll.saturating_sub(lines);
    }

    pub(crate) fn ai_activity_scroll_down(&mut self, lines: usize) {
        self.ai_activity_scroll = self.ai_activity_scroll.saturating_add(lines);
    }

    pub(crate) fn ai_activity_select_previous(&mut self) {
        self.ai_activity_selected = self.ai_activity_selected.saturating_sub(1);
    }

    pub(crate) fn ai_activity_select_next(&mut self) {
        let max_index = self.ai_activity_entries().len().saturating_sub(1);
        self.ai_activity_selected = (self.ai_activity_selected + 1).min(max_index);
    }

    pub(crate) fn ai_activity_jump_selected(&mut self) {
        let Some(entry) = self
            .ai_activity_entries()
            .get(self.ai_activity_selected)
            .cloned()
        else {
            self.status_line = "no ai activity selected".into();
            return;
        };
        let Some(file_index) = self
            .diff
            .files
            .iter()
            .position(|file| file.path == entry.file_path)
        else {
            self.selected_ai_log_session_id = Some(entry.session_id);
            self.mark_ai_sessions_for_file_read(&entry.file_path);
            self.ai_activity_visible = false;
            self.ai_progress_visible = true;
            self.ai_progress_scroll_end();
            self.status_line = format!("opened ai logs for unavailable file {}", entry.file_path);
            return;
        };
        self.select_file(file_index);
        self.selected_ai_log_session_id = Some(entry.session_id);
        self.mark_ai_sessions_for_file_read(&entry.file_path);
        self.ai_activity_visible = false;
        self.ai_progress_visible = true;
        self.ai_progress_scroll_end();
        self.status_line = format!("opened ai logs for {}", entry.file_path);
    }

    pub(crate) fn ai_activity_entries(&self) -> Vec<AiActivityEntry> {
        let mut entries = self
            .ai_log_sessions_by_file
            .values()
            .flat_map(|sessions| sessions.iter())
            .map(|session| AiActivityEntry {
                session_id: session.id,
                file_path: session.file_path.clone(),
                provider: session.provider,
                mode: session.mode,
                status: session.status,
                started_at_ms: session.started_at_ms,
                finished_at_ms: session.finished_at_ms,
                unread_events: session.unread_events,
                event_count: session.events.len(),
                last_event: session.events.back().cloned(),
            })
            .collect::<Vec<_>>();
        entries.sort_by(|left, right| {
            right
                .started_at_ms
                .cmp(&left.started_at_ms)
                .then_with(|| right.session_id.cmp(&left.session_id))
        });
        entries
    }

    pub(crate) fn ai_activity_unread_count(&self) -> usize {
        self.ai_log_sessions_by_file
            .values()
            .flat_map(|sessions| sessions.iter())
            .map(|session| session.unread_events)
            .sum()
    }

    pub(crate) fn ai_activity_running_count(&self) -> usize {
        self.ai_log_sessions_by_file
            .values()
            .flat_map(|sessions| sessions.iter())
            .filter(|session| matches!(session.status, AiLogSessionStatus::Running))
            .count()
    }

    pub(crate) async fn start_ai_log_session(
        &mut self,
        file_path: &str,
        provider: AiProvider,
        mode: AiSessionMode,
    ) -> u64 {
        let id = self.next_ai_log_session_id;
        self.next_ai_log_session_id = self.next_ai_log_session_id.saturating_add(1);
        let session = AiLogSession {
            id,
            file_path: file_path.to_string(),
            provider,
            mode,
            started_at: Instant::now(),
            started_at_ms: now_ms_utc(),
            finished_at_ms: None,
            status: AiLogSessionStatus::Running,
            unread_events: 0,
            events: VecDeque::with_capacity(AI_PROGRESS_MAX_LINES),
        };
        {
            let sessions = self
                .ai_log_sessions_by_file
                .entry(file_path.to_string())
                .or_insert_with(|| VecDeque::with_capacity(AI_LOG_MAX_SESSIONS_PER_FILE));
            sessions.push_back(session);
            while sessions.len() > AI_LOG_MAX_SESSIONS_PER_FILE {
                sessions.pop_front();
            }
        }
        self.push_ai_event_for_session(
            id,
            "system",
            format!("started session ({})", mode.as_str()),
        )
        .await;
        id
    }

    pub(crate) async fn push_ai_event_for_session(
        &mut self,
        session_id: u64,
        stream: &str,
        message: impl Into<String>,
    ) {
        let event = AiLogEvent {
            timestamp_ms: now_ms_utc(),
            stream: stream.to_string(),
            message: message.into(),
        };
        self.push_ai_log_event(session_id, event).await;
    }

    pub(crate) async fn push_ai_log_event(&mut self, session_id: u64, event: AiLogEvent) -> bool {
        let current_file_path = self.ai_log_file_path();
        let ai_log_path = self.ai_log_path();
        let mut log_line = None;
        let mut pushed = false;
        for sessions in self.ai_log_sessions_by_file.values_mut() {
            let Some(session) = sessions.iter_mut().find(|session| session.id == session_id) else {
                continue;
            };
            log_line = Some(format_ai_log_event_line(session, &event));
            if is_ai_waiting_event(&event)
                && let Some(last) = session.events.back_mut()
                && is_ai_waiting_event(last)
            {
                *last = event;
                if self.ai_progress_follow_tail {
                    self.ai_progress_scroll = usize::MAX;
                }
                pushed = true;
                break;
            } else {
                session.events.push_back(event);
                while session.events.len() > AI_PROGRESS_MAX_LINES {
                    session.events.pop_front();
                }
                let selected_session_visible =
                    self.ai_progress_visible && self.selected_ai_log_session_id == Some(session.id);
                let current_file_visible = self.ai_progress_visible
                    && self.selected_ai_log_session_id.is_none()
                    && session.file_path == current_file_path;
                if !(selected_session_visible || current_file_visible) {
                    session.unread_events = session.unread_events.saturating_add(1);
                }
                if self.ai_progress_follow_tail {
                    self.ai_progress_scroll = usize::MAX;
                }
                pushed = true;
                break;
            }
        }
        if !pushed {
            return false;
        }
        if let (Some(path), Some(line)) = (ai_log_path.as_deref(), log_line.as_deref())
            && let Err(error) = append_ai_log_line(path, line).await
        {
            self.status_line = format!("failed to write ai log: {error}");
        }
        true
    }

    pub(crate) fn mark_ai_sessions_for_file_read(&mut self, file_path: &str) {
        if let Some(sessions) = self.ai_log_sessions_by_file.get_mut(file_path) {
            for session in sessions {
                session.unread_events = 0;
            }
        }
    }

    pub(crate) fn update_ai_log_session_status(
        &mut self,
        session_id: u64,
        status: AiLogSessionStatus,
    ) {
        for sessions in self.ai_log_sessions_by_file.values_mut() {
            let Some(session) = sessions.iter_mut().find(|session| session.id == session_id) else {
                continue;
            };
            session.status = status;
            if !matches!(status, AiLogSessionStatus::Running) {
                session.finished_at_ms = Some(now_ms_utc());
            }
            return;
        }
    }

    pub(crate) fn ai_log_sessions_for_file(
        &self,
        file_path: &str,
    ) -> Option<&VecDeque<AiLogSession>> {
        self.ai_log_sessions_by_file.get(file_path)
    }

    pub(crate) fn ai_log_session_by_id(&self, session_id: u64) -> Option<&AiLogSession> {
        self.ai_log_sessions_by_file
            .values()
            .flat_map(|sessions| sessions.iter())
            .find(|session| session.id == session_id)
    }

    pub(crate) fn selected_ai_log_session(&self) -> Option<&AiLogSession> {
        self.selected_ai_log_session_id
            .and_then(|session_id| self.ai_log_session_by_id(session_id))
    }

    pub(crate) fn ai_progress_file_path(&self) -> String {
        self.selected_ai_log_session()
            .map(|session| session.file_path.clone())
            .unwrap_or_else(|| self.ai_log_file_path())
    }

    pub(crate) fn ai_progress_sessions(&self) -> VecDeque<AiLogSession> {
        if let Some(session) = self.selected_ai_log_session() {
            let mut sessions = VecDeque::with_capacity(1);
            sessions.push_back(session.clone());
            return sessions;
        }
        self.ai_log_sessions_for_file(&self.ai_log_file_path())
            .cloned()
            .unwrap_or_default()
    }

    pub(crate) fn queue_ai_log_pager(&mut self) {
        let Some(path) = self.ai_log_path() else {
            self.status_line = "ai log path unavailable".into();
            return;
        };
        self.pending_action = Some(PendingUiAction::OpenFileInPager(path.clone()));
        self.status_line = format!("opening ai log in pager: {}", path.display());
    }

    pub(crate) fn ai_log_path(&self) -> Option<PathBuf> {
        self.log_path
            .parent()
            .map(|parent| parent.join(AI_LOG_FILE_NAME))
    }

    pub(crate) fn ai_log_file_path(&self) -> String {
        self.current_file()
            .map(|file| file.path.clone())
            .unwrap_or_else(|| "(no file)".to_string())
    }

    pub(crate) fn running_ai_tasks_for_file(&self, file_path: &str) -> usize {
        self.ai_tasks
            .iter()
            .filter(|task| task.file_path == file_path)
            .count()
    }

    pub(crate) fn first_running_ai_task_for_file(&self, file_path: &str) -> Option<&AiRunTask> {
        self.ai_tasks
            .iter()
            .find(|task| task.file_path == file_path)
    }

    pub(crate) async fn record_ai_progress_for_file(
        &mut self,
        file_path: &str,
        session_id: u64,
        event: AiProgressEvent,
    ) -> bool {
        let Some(message) = Self::normalized_ai_stream_message(&event.stream, &event.message)
        else {
            return false;
        };
        let stream = match event.stream.as_str() {
            "stdout" => "agent",
            other => other,
        };
        let message = if event.stream == "stderr" {
            format!("stderr: {message}")
        } else {
            message
        };
        let pushed = self
            .push_ai_log_event(
                session_id,
                AiLogEvent {
                    timestamp_ms: event.timestamp_ms,
                    stream: stream.to_string(),
                    message,
                },
            )
            .await;
        if self.ai_progress_visible && self.ai_progress_file_path() == file_path {
            self.mark_ai_sessions_for_file_read(file_path);
        }
        pushed
    }

    pub(crate) fn handle_ai_activity_key(&mut self, key: KeyEvent) -> Result<bool> {
        match key.code {
            KeyCode::Esc | KeyCode::Char('L') => {
                self.dismiss_ai_activity_overlay();
                self.status_line = "ai activity hidden".into();
            }
            KeyCode::Up | KeyCode::Char('k') => {
                self.ai_activity_select_previous();
            }
            KeyCode::Down | KeyCode::Char('j') => {
                self.ai_activity_select_next();
            }
            KeyCode::PageUp => {
                self.ai_activity_selected = self.ai_activity_selected.saturating_sub(8);
            }
            KeyCode::PageDown => {
                let max_index = self.ai_activity_entries().len().saturating_sub(1);
                self.ai_activity_selected = (self.ai_activity_selected + 8).min(max_index);
            }
            KeyCode::Home | KeyCode::Char('g') => {
                self.ai_activity_selected = 0;
            }
            KeyCode::End | KeyCode::Char('G') => {
                self.ai_activity_selected = self.ai_activity_entries().len().saturating_sub(1);
            }
            KeyCode::Enter => {
                self.ai_activity_jump_selected();
            }
            KeyCode::Char('O' | 'o') => {
                self.queue_ai_log_pager();
            }
            _ => return Ok(false),
        }
        Ok(true)
    }

    pub(crate) async fn drain_ai_progress(&mut self) -> bool {
        let mut changed = false;
        let mut events = Vec::new();
        let mut heartbeats = Vec::new();
        let now = Instant::now();
        for task in &mut self.ai_tasks {
            let file_path = task.file_path.clone();
            let session_id = task.log_session_id;
            while let Ok(event) = task.progress_rx.try_recv() {
                events.push((file_path.clone(), session_id, event));
            }
            if now.duration_since(task.last_log_heartbeat_at) >= AI_TASK_LOG_HEARTBEAT_INTERVAL {
                task.last_log_heartbeat_at = now;
                heartbeats.push((
                    session_id,
                    format!(
                        "waiting for {} {} response ({}s elapsed)",
                        task.provider.as_str(),
                        task.mode.as_str(),
                        task.started_at.elapsed().as_secs()
                    ),
                ));
            }
        }
        for (file_path, session_id, event) in events {
            changed |= self
                .record_ai_progress_for_file(&file_path, session_id, event)
                .await;
        }
        for (session_id, message) in heartbeats {
            self.push_ai_event_for_session(session_id, "system", message)
                .await;
            changed = true;
        }
        changed
    }

    pub(crate) async fn cancel_ai_task(&mut self) {
        let file_path = self.ai_log_file_path();
        let mut remaining = Vec::with_capacity(self.ai_tasks.len());
        let mut cancelled = Vec::new();
        for task in self.ai_tasks.drain(..) {
            if task.file_path == file_path {
                cancelled.push(task);
            } else {
                remaining.push(task);
            }
        }
        self.ai_tasks = remaining;

        if cancelled.is_empty() {
            self.status_line = "no ai sessions running for current file".into();
            return;
        }

        let cancelled_count = cancelled.len();
        for mut task in cancelled {
            while let Ok(event) = task.progress_rx.try_recv() {
                self.record_ai_progress_for_file(&file_path, task.log_session_id, event)
                    .await;
            }
            let provider = task.provider;
            let elapsed_ms = task.started_at.elapsed().as_millis();
            task.handle.abort();
            self.update_ai_log_session_status(task.log_session_id, AiLogSessionStatus::Cancelled);
            self.push_ai_event_for_session(
                task.log_session_id,
                "system",
                format!("{} cancelled after {}ms", provider.as_str(), elapsed_ms),
            )
            .await;
        }
        self.status_line = format!("cancelled {cancelled_count} ai session(s) for current file");
    }

    pub(crate) async fn poll_ai_task(&mut self, service: &ReviewService) -> Result<bool> {
        let mut changed = self.drain_ai_progress().await;
        let mut finished_indices = self
            .ai_tasks
            .iter()
            .enumerate()
            .filter_map(|(index, task)| task.handle.is_finished().then_some(index))
            .collect::<Vec<_>>();
        if finished_indices.is_empty() {
            return Ok(changed);
        }

        let mut refresh_needed = false;
        finished_indices.reverse();
        for index in finished_indices {
            let mut task = self.ai_tasks.remove(index);
            let file_path = task.file_path.clone();
            while let Ok(event) = task.progress_rx.try_recv() {
                self.record_ai_progress_for_file(&file_path, task.log_session_id, event)
                    .await;
            }
            match task.handle.await {
                Ok(Ok(result)) => {
                    refresh_needed = true;
                    let failed = result.items.iter().find(|item| item.status == "failed");
                    let session_status = if result.failed > 0 {
                        AiLogSessionStatus::Failed
                    } else {
                        AiLogSessionStatus::Finished
                    };
                    self.update_ai_log_session_status(task.log_session_id, session_status);
                    self.status_line = if let Some(item) = failed {
                        format!("ai failed on #{}: {}", item.comment_id, item.message)
                    } else {
                        format!(
                            "ai session {} ({}) processed {} | skipped {} | failed {}",
                            result.provider,
                            result.mode,
                            result.processed,
                            result.skipped,
                            result.failed
                        )
                    };
                    self.last_ai_detail = Some(if result.processed > 0 {
                        format!("ai processed {} thread(s)", result.processed)
                    } else {
                        "ai session had no actionable threads".to_string()
                    });
                    self.push_ai_event_for_session(
                        task.log_session_id,
                        "system",
                        format!(
                            "{} finished (processed={} skipped={} failed={})",
                            result.provider, result.processed, result.skipped, result.failed
                        ),
                    )
                    .await;
                    changed = true;
                }
                Ok(Err(error)) => {
                    self.update_ai_log_session_status(
                        task.log_session_id,
                        AiLogSessionStatus::Failed,
                    );
                    self.ai_progress_visible = true;
                    self.ai_progress_scroll_end();
                    self.last_ai_detail = Some(format!("ai run failed: {error}"));
                    self.status_line = format!("run ai session failed: {error}");
                    self.push_ai_event_for_session(
                        task.log_session_id,
                        "system",
                        format!("run failed: {error}"),
                    )
                    .await;
                    changed = true;
                }
                Err(error) => {
                    self.update_ai_log_session_status(
                        task.log_session_id,
                        AiLogSessionStatus::Failed,
                    );
                    self.ai_progress_visible = true;
                    self.ai_progress_scroll_end();
                    self.last_ai_detail = Some(format!("ai task join failed: {error}"));
                    self.status_line = format!("run ai session failed: {error}");
                    self.push_ai_event_for_session(
                        task.log_session_id,
                        "system",
                        format!("task join failed: {error}"),
                    )
                    .await;
                    changed = true;
                }
            }
        }
        if refresh_needed {
            self.refresh_review_and_diff(service).await?;
        }
        Ok(changed)
    }

    pub(crate) async fn start_ai_session(
        &mut self,
        service: &ReviewService,
        selected_only: bool,
        mode: AiSessionMode,
    ) -> Result<()> {
        let file_path = self.ai_log_file_path();
        let mut comment_ids = Vec::new();
        if selected_only {
            let Some(comment) = self.selected_comment_details() else {
                self.status_line = "no thread selected".into();
                return Ok(());
            };
            comment_ids.push(comment.id);
        }

        let provider = self.ai_provider;
        let transport = self.ai_transport;
        let log_session_id = self.start_ai_log_session(&file_path, provider, mode).await;
        self.ai_progress_visible = true;
        self.selected_ai_log_session_id = Some(log_session_id);
        self.ai_progress_scroll_end();
        self.mark_ai_sessions_for_file_read(&file_path);
        let provider_config = self
            .config
            .ai
            .provider_config_for_transport(provider, transport);
        self.push_ai_event_for_session(
            log_session_id,
            "system",
            format!(
                "provider={} client={} transport={} model={}",
                provider.as_str(),
                provider_config.client,
                provider_config.transport.as_str(),
                provider_config.model.as_deref().unwrap_or("-")
            ),
        )
        .await;
        let input = RunAiSessionInput {
            review_name: self.review_name.clone(),
            provider,
            transport,
            comment_ids,
            mode,
            diff_source: self.diff_source.clone(),
        };
        let (progress_tx, progress_rx) = mpsc::unbounded_channel();
        let service_clone = service.clone();
        let handle = tokio::spawn(async move {
            run_ai_session_with_progress(&service_clone, input, progress_tx).await
        });

        self.ai_tasks.push(AiRunTask {
            log_session_id,
            started_at: Instant::now(),
            last_log_heartbeat_at: Instant::now(),
            file_path: file_path.clone(),
            provider,
            mode,
            handle,
            progress_rx,
        });
        self.last_ai_detail = Some(if selected_only {
            format!(
                "ai is processing selected thread with {} ({})",
                provider.as_str(),
                mode.as_str()
            )
        } else {
            format!(
                "ai is processing unresolved threads with {} ({})",
                provider.as_str(),
                mode.as_str()
            )
        });
        self.status_line = format!(
            "ai session started: provider={} scope={} mode={}",
            provider.as_str(),
            if selected_only { "thread" } else { "review" },
            mode.as_str()
        );
        Ok(())
    }

    pub(crate) async fn cycle_ai_provider(&mut self, service: &ReviewService) -> Result<()> {
        self.ai_provider = match self.ai_provider {
            AiProvider::Codex => AiProvider::Claude,
            AiProvider::Claude => AiProvider::Opencode,
            AiProvider::Opencode => AiProvider::Pi,
            AiProvider::Pi => AiProvider::Codex,
        };
        self.config.ai.default_provider = self.ai_provider;
        service.save_config(&self.config).await?;
        self.status_line = format!(
            "ai provider set to {} ({})",
            self.ai_provider.as_str(),
            self.effective_ai_transport().as_str()
        );
        Ok(())
    }

    pub(crate) async fn toggle_ai_transport(&mut self, service: &ReviewService) -> Result<()> {
        if matches!(self.ai_provider, AiProvider::Pi) {
            self.ai_transport = None;
            self.config.ai.default_transport = None;
            service.save_config(&self.config).await?;
            self.status_line = "pi uses pi_rpc; ACP/CLI toggle unavailable".into();
            return Ok(());
        }

        let next = match self
            .effective_ai_transport()
            .as_agent_transport()
            .unwrap_or_default()
        {
            AgentTransport::Acp => AgentTransport::Cli,
            AgentTransport::Cli => AgentTransport::Acp,
        };
        self.ai_transport = Some(next);
        self.config.ai.default_transport = Some(next);
        service.save_config(&self.config).await?;
        let provider_config = self
            .config
            .ai
            .provider_config_for_transport(self.ai_provider, self.ai_transport);
        self.status_line = format!(
            "ai transport set to {} for {} ({})",
            next.as_str(),
            self.ai_provider.as_str(),
            provider_config.client
        );
        Ok(())
    }

    pub(crate) fn effective_ai_transport(&self) -> ProviderTransport {
        self.config
            .ai
            .provider_config_for_transport(self.ai_provider, self.ai_transport)
            .transport
    }

    fn normalized_ai_stream_message(stream: &str, message: &str) -> Option<String> {
        if !matches!(stream, "stdout" | "stderr") {
            return Some(message.to_string());
        }

        let trimmed = message.trim();
        if trimmed.is_empty() {
            return None;
        }

        let json_candidate = trimmed.strip_prefix("data:").map_or(trimmed, str::trim);
        if let Ok(value) = serde_json::from_str::<serde_json::Value>(json_candidate) {
            let parts = collect_named_text(
                &value,
                &[
                    "content", "text", "body", "message", "reply", "output", "input",
                ],
            );
            let merged = parts.join("");
            let normalized = merged.trim();
            if !normalized.is_empty() {
                return Some(normalized.to_string());
            }

            let tag = Self::extract_ai_activity_tag(&value).unwrap_or_else(|| "event".to_string());
            if tag.ends_with(".started") || tag.ends_with(".completed") {
                return None;
            }
            return Some(format!("[{tag}]"));
        }

        Some(message.to_string())
    }

    fn extract_ai_activity_tag(value: &serde_json::Value) -> Option<String> {
        let map = value.as_object()?;
        for key in ["type", "event", "status", "phase", "kind", "name"] {
            let Some(raw) = map.get(key) else {
                continue;
            };
            let Some(text) = raw.as_str() else {
                continue;
            };
            let normalized = text.trim();
            if !normalized.is_empty() {
                return Some(normalized.to_string());
            }
        }
        None
    }
}

fn is_ai_waiting_event(event: &AiLogEvent) -> bool {
    event.stream == "system" && event.message.starts_with("waiting for ")
}

fn format_ai_log_event_line(session: &AiLogSession, event: &AiLogEvent) -> String {
    format!(
        "{} | session #{} | file={} | {}:{} | status={} | {}: {}",
        format_timestamp_utc(event.timestamp_ms),
        session.id,
        sanitize_ai_log_text(&session.file_path),
        session.provider.as_str(),
        session.mode.as_str(),
        session.status.as_str(),
        event.stream,
        sanitize_ai_log_text(event.message.trim())
    )
}

async fn append_ai_log_line(path: &Path, line: &str) -> Result<()> {
    if let Some(parent) = path.parent() {
        fs::create_dir_all(parent)
            .await
            .with_context(|| format!("failed to create ai log directory {}", parent.display()))?;
    }
    let mut file = fs::OpenOptions::new()
        .create(true)
        .append(true)
        .open(path)
        .await
        .with_context(|| format!("failed to open ai log {}", path.display()))?;
    file.write_all(line.as_bytes())
        .await
        .with_context(|| format!("failed to write ai log {}", path.display()))?;
    file.write_all(b"\n")
        .await
        .with_context(|| format!("failed to write ai log {}", path.display()))?;
    file.flush()
        .await
        .with_context(|| format!("failed to flush ai log {}", path.display()))?;
    Ok(())
}

fn sanitize_ai_log_text(value: &str) -> String {
    value
        .replace('\r', "\\r")
        .replace('\n', "\\n")
        .replace('\t', "\\t")
}

#[cfg(test)]
mod tests {
    use super::*;
    use crate::tui::app::state::tests::make_test_app;
    use anyhow::Result;
    use tempfile::tempdir;

    #[tokio::test]
    async fn ai_log_sessions_keep_events_scoped_to_file_and_session() -> Result<()> {
        let mut app = make_test_app(vec!["src/a.rs", "src/b.rs"], Vec::new())?;

        let session_id = app
            .start_ai_log_session("src/a.rs", AiProvider::Codex, AiSessionMode::Reply)
            .await;
        app.push_ai_log_event(
            session_id,
            AiLogEvent {
                timestamp_ms: 10,
                stream: "agent".to_string(),
                message: "answer".to_string(),
            },
        )
        .await;

        let sessions = app
            .ai_log_sessions_for_file("src/a.rs")
            .ok_or_else(|| anyhow::anyhow!("missing file sessions"))?;
        assert_eq!(sessions.len(), 1);
        assert_eq!(sessions[0].events.len(), 2);
        assert!(app.ai_log_sessions_for_file("src/b.rs").is_none());
        assert_eq!(app.ai_activity_entries()[0].session_id, session_id);
        assert_eq!(app.ai_activity_unread_count(), 2);

        app.mark_ai_sessions_for_file_read("src/a.rs");

        assert_eq!(app.ai_activity_unread_count(), 0);
        Ok(())
    }

    #[tokio::test]
    async fn ai_log_waiting_events_update_latest_waiting_row() -> Result<()> {
        let mut app = make_test_app(vec!["src/a.rs"], Vec::new())?;
        let session_id = app
            .start_ai_log_session("src/a.rs", AiProvider::Pi, AiSessionMode::Refactor)
            .await;

        app.push_ai_event_for_session(session_id, "system", "waiting for pi response (2s elapsed)")
            .await;
        app.push_ai_event_for_session(session_id, "system", "waiting for pi response (4s elapsed)")
            .await;
        app.push_ai_event_for_session(session_id, "thought", "checking imports")
            .await;
        app.push_ai_event_for_session(session_id, "system", "waiting for pi response (6s elapsed)")
            .await;

        let events = &app
            .ai_log_sessions_for_file("src/a.rs")
            .ok_or_else(|| anyhow::anyhow!("missing ai session"))?[0]
            .events;
        assert_eq!(events.len(), 4);
        assert_eq!(events[1].message, "waiting for pi response (4s elapsed)");
        assert_eq!(events[2].message, "checking imports");
        assert_eq!(events[3].message, "waiting for pi response (6s elapsed)");
        Ok(())
    }

    #[tokio::test]
    async fn ai_activity_jump_opens_selected_file_logs() -> Result<()> {
        let mut app = make_test_app(vec!["src/a.rs", "src/b.rs"], Vec::new())?;
        let session_id = app
            .start_ai_log_session("src/b.rs", AiProvider::Opencode, AiSessionMode::Refactor)
            .await;
        app.ai_activity_visible = true;
        app.ai_activity_selected = 0;

        app.ai_activity_jump_selected();

        assert_eq!(app.active_file_index(), 1);
        assert_eq!(app.selected_ai_log_session_id, Some(session_id));
        assert_eq!(app.ai_progress_file_path(), "src/b.rs");
        assert_eq!(app.ai_progress_sessions().len(), 1);
        assert!(app.ai_progress_visible);
        assert!(!app.ai_activity_visible);
        assert_eq!(app.ai_activity_unread_count(), 0);
        Ok(())
    }

    #[test]
    fn ai_log_pager_opens_existing_review_ai_log() -> Result<()> {
        let tempdir = tempdir()?;
        let mut app = make_test_app(vec!["src/a.rs"], Vec::new())?;
        app.log_path = tempdir.path().join("reviews/main/logs/tui.log");

        app.queue_ai_log_pager();

        let Some(PendingUiAction::OpenFileInPager(path)) = app.pending_action.as_ref() else {
            return Err(anyhow::anyhow!("missing pager action"));
        };
        assert_eq!(path, &tempdir.path().join("reviews/main/logs/ai.log"));
        Ok(())
    }

    #[tokio::test]
    async fn ai_log_events_are_persisted_to_review_ai_log() -> Result<()> {
        let tempdir = tempdir()?;
        let mut app = make_test_app(vec!["src/a.rs"], Vec::new())?;
        app.log_path = tempdir.path().join("reviews/main/logs/tui.log");
        let session_id = app
            .start_ai_log_session("src/a.rs", AiProvider::Codex, AiSessionMode::Reply)
            .await;

        app.push_ai_event_for_session(session_id, "stderr", "ACP auth failed\ninvalid_grant")
            .await;

        let log = fs::read_to_string(tempdir.path().join("reviews/main/logs/ai.log")).await?;
        assert!(log.contains("session #1"));
        assert!(log.contains("codex:reply"));
        assert!(log.contains("stderr: ACP auth failed\\ninvalid_grant"));
        Ok(())
    }
}