par-term 0.48.0

//! Coverage guards for the keybinding dispatch tables.
//!
//! `execute_keybinding_action` dispatches on `&str`, so it never had a
//! compile-time exhaustiveness check. What the `match` form it replaced *did*
//! give was `unreachable_patterns`: a duplicated string arm was a compiler
//! warning. A linear-scan table makes a duplicate key silently first-wins, so
//! `action_table_has_no_duplicate_keys` and its display-table twin exist to
//! replace exactly that guarantee.
//!
//! The remaining tests are guarantees the `match` form could not express:
//! cross-table disjointness, coverage of a frozen action inventory, and
//! coverage of every shipped default keybinding.

use super::keybinding_actions::ACTION_HANDLERS;
use super::keybinding_actions::{parse_agent_roster_focus_id, parse_plugin_action_id};
use super::keybinding_display_actions::DISPLAY_ACTION_HANDLERS;
use crate::app::window_state::WindowState;

/// Every action name `execute_keybinding_action` resolved by exact match
/// before ENH-004 converted the two `match` ladders into dispatch tables.
///
/// Captured from the pre-refactor arms of `keybinding_actions.rs` (42 names)
/// and `keybinding_display_actions.rs` (20 names) at commit `d807b90e`.
///
/// **Do not regenerate this list from the dispatch tables.** It is an
/// independent record of what the terminal used to answer to; a list derived
/// from the tables would pass no matter how many entries were dropped.
/// Adding a genuinely new action means adding it here too, deliberately.
const FROZEN_ACTION_INVENTORY: &[&str] = &[
    "clear_scrollback",
    "clear_screen",
    "close_pane",
    "close_tab",
    "close_window",
    "cycle_background_shader",
    "cycle_cursor_style",
    "decrease_font_size",
    "demote_tab_to_pane",
    "duplicate_tab",
    "enter_copy_mode",
    "increase_font_size",
    "maximize_vertically",
    "move_tab_left",
    "move_tab_right",
    "move_tab_to_new_window",
    "navigate_pane_down",
    "navigate_pane_left",
    "navigate_pane_right",
    "navigate_pane_up",
    "new_tab",
    "new_window",
    "next_tab",
    "open_settings",
    "paste_special",
    "prev_tab",
    "promote_pane_to_tab",
    "quit",
    "reload_config",
    "reload_dynamic_profiles",
    "reopen_closed_tab",
    "rename_pane",
    "reset_font_size",
    "resize_pane_down",
    "resize_pane_left",
    "resize_pane_right",
    "resize_pane_up",
    "save_arrangement",
    "scroll_down_page",
    "scroll_to_bottom",
    "scroll_to_next_mark",
    "scroll_to_previous_mark",
    "scroll_to_top",
    "scroll_up_page",
    "select_all",
    "select_pane_hint",
    "split_horizontal",
    "split_vertical",
    // UX.md T7 renamed the two above; they stay here because the old ids must
    // keep dispatching (as aliases, via `current_action_id`).
    "split_down",
    "split_right",
    "ssh_quick_connect",
    "swap_pane_down",
    "swap_pane_left",
    "swap_pane_right",
    "swap_pane_up",
    "switch_to_tab_1",
    "switch_to_tab_2",
    "switch_to_tab_3",
    "switch_to_tab_4",
    "switch_to_tab_5",
    "switch_to_tab_6",
    "switch_to_tab_7",
    "switch_to_tab_8",
    "switch_to_tab_9",
    "toggle_agent_usage_panel",
    "toggle_ai_inspector",
    "toggle_background_shader",
    "toggle_broadcast_input",
    "toggle_clipboard_history",
    "toggle_command_palette",
    "toggle_command_history",
    "toggle_copy_mode",
    "toggle_cursor_shader",
    "toggle_fps_overlay",
    "toggle_fullscreen",
    "toggle_help",
    "toggle_menu",
    "toggle_profile_drawer",
    "toggle_search",
    "toggle_session_logging",
    "toggle_shader_animation",
    "toggle_shader_readability_mode",
    "toggle_throughput_mode",
    "toggle_tmux_session_picker",
    // UX.md A16 renamed the one above; both stay (the old id is an alias).
    "toggle_session_picker",
    // Added deliberately (UX.md A20), not part of the frozen capture.
    "toggle_always_on_top",
    // UX.md P3 pane power features (A1, A7, A8, A9), added deliberately.
    "toggle_pane_zoom",
    "next_pane",
    "prev_pane",
    "last_pane",
    "restart_pane",
    "equalize_panes",
    "cycle_layout",
    "split_left",
    "split_up",
    "toggle_pane_broadcast",
    // UX P3b (A6), added deliberately.
    "enter_resize_mode",
    // UX P4 (A10-A14, A21, A23), added deliberately. `close_window` above is
    // now the real whole-window close; the smart close moved here.
    "close_tab_or_window",
    "next_window",
    "prev_window",
    "switch_to_window_1",
    "switch_to_window_2",
    "switch_to_window_3",
    "switch_to_window_4",
    "switch_to_window_5",
    "switch_to_window_6",
    "switch_to_window_7",
    "switch_to_window_8",
    "switch_to_window_9",
    "last_tab",
    "go_to_last_tab",
    "rename_tab",
    "close_other_tabs",
    "close_tabs_to_right",
    "detach",
    "new_mux_session",
    "focus_next_attention_agent",
    "toggle_tree_picker",
    "move_tab_to_window_picker",
    // UX MP3 profile surfaces (PR3/PR5/PR6).
    "manage_profiles",
    "edit_tab_profile",
    "toggle_tab_profile_pin",
    "toggle_profiles_panel",
];

fn action_keys() -> Vec<&'static str> {
    ACTION_HANDLERS.iter().map(|(name, _)| *name).collect()
}

fn display_keys() -> Vec<&'static str> {
    DISPLAY_ACTION_HANDLERS
        .iter()
        .map(|(name, _)| *name)
        .collect()
}

fn assert_no_duplicates(table: &str, mut keys: Vec<&'static str>) {
    keys.sort_unstable();
    let total = keys.len();
    keys.dedup();
    assert_eq!(
        total,
        keys.len(),
        "{table} has a duplicate key — a linear-scan table silently uses the \
         first entry, so the later one is dead code"
    );
}

/// Replaces the `unreachable_patterns` warning the `match` form provided.
#[test]
fn action_table_has_no_duplicate_keys() {
    assert_no_duplicates("ACTION_HANDLERS", action_keys());
}

/// Replaces the `unreachable_patterns` warning the `match` form provided.
#[test]
fn display_action_table_has_no_duplicate_keys() {
    assert_no_duplicates("DISPLAY_ACTION_HANDLERS", display_keys());
}

/// A guarantee that never existed: the display table is only consulted when
/// the main table misses, so a name present in both would have its display
/// entry silently shadowed.
#[test]
fn action_tables_are_disjoint() {
    let main = action_keys();
    let shadowed: Vec<&str> = display_keys()
        .into_iter()
        .filter(|k| main.contains(k))
        .collect();
    assert!(
        shadowed.is_empty(),
        "these names appear in both ACTION_HANDLERS and DISPLAY_ACTION_HANDLERS, \
         so the display entries are unreachable: {shadowed:?}"
    );
}

/// The anti-drop guard: a dispatch-table refactor fails silently, and this is
/// what makes it fail loudly instead.
#[test]
fn dispatch_tables_cover_the_frozen_action_inventory() {
    let mut live: Vec<&str> = action_keys();
    live.extend(display_keys());
    live.sort_unstable();

    // A renamed id is dispatchable only while the id it resolves to is a
    // live table key — an alias to nothing would be a dropped action.
    let missing: Vec<&&str> = FROZEN_ACTION_INVENTORY
        .iter()
        .filter(|name| {
            !live.contains(&par_term_config::config::keybindings_methods::current_action_id(name))
        })
        .collect();
    assert!(
        missing.is_empty(),
        "actions the terminal used to handle are no longer dispatchable: {missing:?}"
    );

    let added: Vec<&str> = live
        .iter()
        .filter(|name| !FROZEN_ACTION_INVENTORY.contains(name))
        .copied()
        .collect();
    assert!(
        added.is_empty(),
        "new actions are dispatchable but absent from FROZEN_ACTION_INVENTORY — \
         add them there deliberately: {added:?}"
    );
}

/// Driven from the shipped defaults rather than a copied list, so it cannot
/// drift: any default chord whose action no handler claims would be a shortcut
/// that does nothing.
#[test]
fn every_default_keybinding_resolves_to_a_handler() {
    let mut live: Vec<&str> = action_keys();
    live.extend(display_keys());

    // Prefix forms are resolved at runtime against the user's snippets,
    // actions, arrangements, and plugins, so they are dispatchable without a
    // table entry. No shipped default uses one today.
    const PREFIXES: &[&str] = &[
        "layout:",
        "snippet:",
        "action:",
        "restore_arrangement:",
        "plugin-action:",
    ];

    let defaults = crate::config::Config::default().keybindings;
    assert!(
        !defaults.is_empty(),
        "Config::default() shipped no keybindings — this test would be vacuous"
    );

    let unhandled: Vec<String> = defaults
        .iter()
        .filter(|kb| {
            !live.contains(&kb.action.as_str())
                && !PREFIXES.iter().any(|p| kb.action.starts_with(p))
        })
        .map(|kb| format!("{} -> {}", kb.key, kb.action))
        .collect();
    assert!(
        unhandled.is_empty(),
        "default keybindings whose action has no handler (the chord would do \
         nothing): {unhandled:?}"
    );
}

/// UX.md T7: every renamed id resolves to a live handler and is itself no
/// longer a table key, so the old and new ids cannot drift apart.
#[test]
fn renamed_action_ids_alias_a_live_handler() {
    let mut live: Vec<&str> = action_keys();
    live.extend(display_keys());
    for (previous, current) in par_term_config::config::keybindings_methods::ACTION_RENAMES {
        assert!(
            live.contains(current),
            "{previous} is renamed to {current}, which no handler claims"
        );
        assert!(
            !live.contains(previous),
            "{previous} is renamed but still has its own handler"
        );
    }
}

// --- plugin-action: dispatch (O2 action contributors) ---

/// A `WindowState` with no window, renderer, tabs, or discovered plugins —
/// the same seam `pane_transfer`'s tests use. Enough state for the
/// miss-path: the dispatch reaches `status_bar_ui`'s empty plugin host and
/// must return `false` without touching anything else.
fn test_window_state() -> WindowState {
    let runtime = std::sync::Arc::new(
        tokio::runtime::Builder::new_current_thread()
            .enable_all()
            .build()
            .expect("build test runtime"),
    );
    WindowState::new(crate::config::Config::default(), runtime)
}

#[test]
fn plugin_action_id_parses_into_plugin_and_action_halves() {
    assert_eq!(
        parse_plugin_action_id("plugin-action:com.example.greeter:greet"),
        Some(("com.example.greeter", "greet"))
    );
}

#[test]
fn close_tab_on_the_last_tab_closes_the_window_not_nothing() {
    // I15 cascade tail: the chord must not dead-end on the last tab
    // (Ctrl+Alt+W on Linux/Windows binds close_tab). Pre-fix the arm
    // guarded on has_multiple_tabs() and this assertion failed with
    // is_shutting_down still false — a silently dead chord.
    let mut state = test_window_state();
    assert!(!state.is_shutting_down);
    assert!(state.execute_keybinding_action("close_tab"));
    assert!(
        state.is_shutting_down,
        "closing the last tab via the chord must close the window"
    );
}

#[test]
fn agent_roster_focus_id_parses_the_pane() {
    assert_eq!(
        parse_agent_roster_focus_id("agent-roster-focus:42"),
        Some(42)
    );
    assert_eq!(parse_agent_roster_focus_id("agent-roster-focus:0"), Some(0));
}

#[test]
fn agent_roster_focus_id_rejects_malformed_ids() {
    assert_eq!(parse_agent_roster_focus_id("agent-roster-focus:"), None);
    assert_eq!(parse_agent_roster_focus_id("agent-roster-focus:abc"), None);
    assert_eq!(parse_agent_roster_focus_id("agent-roster-focus:4:2"), None);
    assert_eq!(parse_agent_roster_focus_id("toggle_search"), None);
}

#[test]
fn plugin_action_id_without_the_prefix_is_rejected() {
    assert_eq!(parse_plugin_action_id("greet"), None);
}

#[test]
fn plugin_action_id_with_no_second_colon_is_rejected() {
    assert_eq!(parse_plugin_action_id("plugin-action:only-plugin"), None);
}

#[test]
fn plugin_action_id_with_an_empty_half_is_rejected() {
    assert_eq!(parse_plugin_action_id("plugin-action:p:"), None);
    assert_eq!(parse_plugin_action_id("plugin-action::greet"), None);
}

#[test]
fn plugin_action_id_splits_once_leaving_later_colons_to_manifest_lookup() {
    // Split-once: whether an action id containing colons exists is the
    // manifest lookup's call, not the parser's.
    assert_eq!(
        parse_plugin_action_id("plugin-action:com.example.greeter:greet:extra"),
        Some(("com.example.greeter", "greet:extra"))
    );
}

#[test]
fn plugin_action_dispatch_for_an_undiscovered_plugin_returns_false() {
    let mut state = test_window_state();
    assert!(!state.execute_keybinding_action("plugin-action:nosuch:noop"));
}

#[test]
fn plugin_action_dispatch_for_a_malformed_id_returns_false() {
    let mut state = test_window_state();
    assert!(!state.execute_keybinding_action("plugin-action:only-plugin"));
}

// --- agent-cmd: dispatch (agent-authored commands) ---

#[test]
fn agent_cmd_dispatch_for_an_unknown_command_returns_false() {
    // The store loads the real commands dir; an id this implausible is not
    // on disk, so dispatch hits the miss-path (log + false) the same way a
    // stale palette row after a delete does.
    let mut state = test_window_state();
    assert!(!state.execute_keybinding_action("agent-cmd:definitely-not-a-real-command-id-xyz"));
}

#[test]
fn agent_cmd_prefix_is_routed_not_logged_as_unknown() {
    // The branch sits ahead of the unknown-action fallthrough; even a
    // malformed id (empty) is consumed by the agent-cmd arm rather than
    // reaching the generic warn path.
    let mut state = test_window_state();
    assert!(!state.execute_keybinding_action("agent-cmd:"));
}

// --- focused plugin overlay: key routing (overlay phase 2) ---

#[test]
fn focus_never_lands_without_a_live_interactive_overlay_and_escape_resolves() {
    // Without a live overlay in the host's (private) map, focus calls are
    // no-ops — the gate itself is the testable seam here. The full
    // ingest → focus → escape lifecycle against a real process is covered
    // in par-term-scripting's plugin_manager tests.
    let mut state = test_window_state();
    state
        .status_bar_ui
        .plugin_host_mut()
        .focus_overlay("com.test.hud");
    assert_eq!(state.status_bar_ui.plugin_host().focused_overlay(), None);

    // With no focus, the resolution is inert both ways (no panic, no
    // state change).
    state.resolve_focused_overlay_key(false);
    state.resolve_focused_overlay_key(true);
    assert_eq!(state.status_bar_ui.plugin_host().focused_overlay(), None);
}

// --- documentation coverage (UX.md DOC8) ---

/// KEYBOARD_SHORTCUTS.md's Available Actions names every dispatchable
/// action id, so a new action cannot ship undocumented.
#[test]
fn keyboard_shortcuts_doc_lists_every_dispatchable_action() {
    let doc = include_str!("../../../docs/guides/KEYBOARD_SHORTCUTS.md");
    let missing: Vec<&str> = action_keys()
        .into_iter()
        .chain(display_keys())
        .filter(|id| !doc.contains(&format!("`{id}`")))
        .collect();
    assert!(
        missing.is_empty(),
        "document these in KEYBOARD_SHORTCUTS.md › Available Actions: {missing:?}"
    );
}