papers 0.1.1

A library to allow creation and updates of Wikidata items for scientific publications, authors, and related info
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
use std::collections::HashMap;
use std::sync::Arc;

use async_trait::async_trait;

use self::identifiers::{GenericWorkIdentifier, GenericWorkType, IdProp};
use crate::{
    adapter_helpers::{fetch_doi_json, get_external_identifier_from_item},
    generic_author_info::GenericAuthorInfo,
    http_client::{HttpJsonFetcher, JsonFetcher},
    scientific_publication_adapter::ScientificPublicationAdapter,
    *,
};

pub struct DataCite2Wikidata {
    fetcher: Arc<dyn JsonFetcher>,
    author_cache: HashMap<String, String>,
    work_cache: HashMap<String, serde_json::Value>,
}

impl Default for DataCite2Wikidata {
    fn default() -> Self {
        Self::new(Arc::new(HttpJsonFetcher::default()))
    }
}

impl DataCite2Wikidata {
    /// New adapter with the given JSON fetcher. See [`crate::http_client`]
    /// for the production/mocking pair.
    pub fn new(fetcher: Arc<dyn JsonFetcher>) -> Self {
        DataCite2Wikidata {
            fetcher,
            author_cache: HashMap::new(),
            work_cache: HashMap::new(),
        }
    }

    pub fn get_cached_publication_from_id(
        &self,
        publication_id: &str,
    ) -> Option<&serde_json::Value> {
        self.work_cache.get(publication_id)
    }

    /// Returns the `data.attributes` object from the cached JSON:API response.
    fn get_attributes(&self, publication_id: &str) -> Option<&serde_json::Value> {
        let work = self.get_cached_publication_from_id(publication_id)?;
        work["data"]["attributes"].as_object().map(|_| &work["data"]["attributes"])
    }

    async fn fetch_doi_data(&self, doi: &str) -> Option<(String, serde_json::Value)> {
        let (pub_id, json) =
            fetch_doi_json(&*self.fetcher, doi, |d| format!("https://api.datacite.org/dois/{d}"))
                .await?;
        // DataCite-specific validation: real responses have data.attributes.
        json["data"]["attributes"].as_object()?;
        Some((pub_id, json))
    }

    async fn fetch_work_by_doi(&mut self, doi: &str) -> Option<String> {
        let (pub_id, json) = self.fetch_doi_data(doi).await?;
        self.work_cache.insert(pub_id.clone(), json);
        Some(pub_id)
    }

    /// Maps a DataCite `resourceTypeGeneral` value to a Wikidata Q-item.
    /// Thin wrapper around [`WorkType::from_datacite`] + [`WorkType::as_q`].
    fn datacite_type_to_q(resource_type: &str) -> Option<&'static str> {
        crate::scientific_publication_adapter::WorkType::from_datacite(resource_type)
            .map(crate::scientific_publication_adapter::WorkType::as_q)
    }
}

#[async_trait(?Send)]
impl ScientificPublicationAdapter for DataCite2Wikidata {
    fn name(&self) -> &str {
        "DataCite2Wikidata"
    }

    fn author_cache(&self) -> &HashMap<String, String> {
        &self.author_cache
    }

    fn author_cache_mut(&mut self) -> &mut HashMap<String, String> {
        &mut self.author_cache
    }

    async fn get_identifier_list(
        &mut self,
        ids: &[GenericWorkIdentifier],
    ) -> Vec<GenericWorkIdentifier> {
        let dois: Vec<&str> = ids
            .iter()
            .filter_map(|id| {
                if let GenericWorkType::Property(prop) = id.work_type() {
                    if *prop == IdProp::DOI {
                        return Some(id.id());
                    }
                }
                None
            })
            .collect();
        let results: Vec<_> = {
            let futures = dois.iter().map(|doi| self.fetch_doi_data(doi));
            futures::future::join_all(futures).await
        };
        for (pub_id, json) in results.into_iter().flatten() {
            self.work_cache.insert(pub_id, json);
        }
        let mut ret = vec![];
        for doi in &dois {
            let pub_id = doi.to_uppercase();
            if self.work_cache.contains_key(&pub_id) {
                ret.push(GenericWorkIdentifier::new_prop(IdProp::DOI, &pub_id));
            }
        }
        ret
    }

    async fn publication_id_from_item(&mut self, item: &Entity) -> Option<String> {
        let doi = get_external_identifier_from_item(item, &IdProp::DOI)?;
        self.fetch_work_by_doi(&doi).await
    }

    fn get_work_titles(&self, publication_id: &str) -> Vec<LocaleString> {
        let attrs = match self.get_attributes(publication_id) {
            Some(a) => a,
            None => return vec![],
        };
        match attrs["titles"].as_array() {
            Some(titles) if !titles.is_empty() => {
                if let Some(title) = titles[0]["title"].as_str() {
                    if !title.is_empty() {
                        return vec![LocaleString::new("en", title)];
                    }
                }
                vec![]
            },
            _ => vec![],
        }
    }

    fn get_work_type(&self, publication_id: &str) -> Option<String> {
        let attrs = self.get_attributes(publication_id)?;
        let resource_type = attrs["types"]["resourceTypeGeneral"].as_str()?;
        Self::datacite_type_to_q(resource_type).map(|s| s.to_string())
    }

    fn get_publication_date(&self, publication_id: &str) -> Option<(u32, Option<u8>, Option<u8>)> {
        let attrs = self.get_attributes(publication_id)?;
        // Try publicationYear first (always available)
        let year: u32 = attrs["publicationYear"].as_u64()? as u32;
        // Try to get more precise date from dates array
        if let Some(dates) = attrs["dates"].as_array() {
            for date_entry in dates {
                if date_entry["dateType"].as_str() == Some("Issued") {
                    if let Some(date_str) = date_entry["date"].as_str() {
                        let parts: Vec<&str> = date_str.split('-').collect();
                        if parts.len() >= 2 {
                            let month: Option<u8> = parts.get(1).and_then(|s| s.parse().ok());
                            let day: Option<u8> = parts.get(2).and_then(|s| s.parse().ok());
                            return Some((year, month, day));
                        }
                    }
                }
            }
        }
        Some((year, None, None))
    }

    async fn get_author_list(&mut self, publication_id: &str) -> Vec<GenericAuthorInfo> {
        let attrs = match self.get_attributes(publication_id) {
            Some(a) => a.clone(),
            None => return vec![],
        };
        let creators = match attrs["creators"].as_array() {
            Some(c) => c,
            None => return vec![],
        };
        creators
            .iter()
            .enumerate()
            .filter_map(|(num, creator)| {
                // Try familyName + givenName, fall back to name
                let name = match (creator["givenName"].as_str(), creator["familyName"].as_str()) {
                    (Some(given), Some(family)) => format!("{} {}", given, family),
                    _ => creator["name"].as_str()?.to_string(),
                };
                if name.is_empty() {
                    return None;
                }
                let mut entry = GenericAuthorInfo::new_from_name_num(&name, num + 1);
                // Check for ORCID in nameIdentifiers
                if let Some(identifiers) = creator["nameIdentifiers"].as_array() {
                    for ni in identifiers {
                        if ni["nameIdentifierScheme"].as_str() == Some("ORCID") {
                            if let Some(orcid) = ni["nameIdentifier"].as_str() {
                                // May be full URL or bare ID
                                let orcid =
                                    orcid.strip_prefix("https://orcid.org/").unwrap_or(orcid);
                                if !orcid.is_empty() {
                                    entry
                                        .prop2id_mut()
                                        .insert("P496".to_string(), orcid.to_string());
                                }
                            }
                        }
                    }
                }
                Some(entry)
            })
            .collect()
    }

    async fn update_statements_for_publication_id(
        &self,
        _publication_id: &str,
        _item: &mut Entity,
    ) {
        // No extra statements beyond the defaults
    }
}

#[cfg(test)]
mod tests {
    use super::*;

    fn make_datacite_work() -> serde_json::Value {
        json!({
            "data": {
                "attributes": {
                    "doi": "10.5281/zenodo.1234567",
                    "titles": [
                        {"title": "Test Dataset Title"}
                    ],
                    "types": {
                        "resourceTypeGeneral": "Dataset",
                        "resourceType": "Dataset"
                    },
                    "publicationYear": 2023,
                    "dates": [
                        {"date": "2023-03-15", "dateType": "Issued"},
                        {"date": "2023-03-10", "dateType": "Created"}
                    ],
                    "creators": [
                        {
                            "givenName": "Alice",
                            "familyName": "Smith",
                            "name": "Smith, Alice",
                            "nameIdentifiers": [
                                {
                                    "nameIdentifier": "https://orcid.org/0000-0001-2345-6789",
                                    "nameIdentifierScheme": "ORCID"
                                }
                            ]
                        },
                        {
                            "givenName": "Bob",
                            "familyName": "Jones",
                            "name": "Jones, Bob",
                            "nameIdentifiers": []
                        }
                    ]
                }
            }
        })
    }

    #[test]
    fn test_name() {
        let adapter = DataCite2Wikidata::default();
        assert_eq!(adapter.name(), "DataCite2Wikidata");
    }

    #[test]
    fn test_get_work_titles() {
        let mut adapter = DataCite2Wikidata::default();
        adapter
            .work_cache
            .insert("10.5281/ZENODO.1234567".to_string(), make_datacite_work());
        let titles = adapter.get_work_titles("10.5281/ZENODO.1234567");
        assert_eq!(titles.len(), 1);
        assert_eq!(titles[0].value(), "Test Dataset Title");
    }

    #[test]
    fn test_get_work_titles_missing() {
        let adapter = DataCite2Wikidata::default();
        assert!(adapter.get_work_titles("nonexistent").is_empty());
    }

    #[test]
    fn test_get_work_titles_empty_titles_array() {
        let mut adapter = DataCite2Wikidata::default();
        let mut work = make_datacite_work();
        work["data"]["attributes"]["titles"] = json!([]);
        adapter.work_cache.insert("10.5281/ZENODO.1234567".to_string(), work);
        assert!(adapter.get_work_titles("10.5281/ZENODO.1234567").is_empty());
    }

    #[test]
    fn test_get_work_type_dataset() {
        let mut adapter = DataCite2Wikidata::default();
        adapter
            .work_cache
            .insert("10.5281/ZENODO.1234567".to_string(), make_datacite_work());
        assert_eq!(adapter.get_work_type("10.5281/ZENODO.1234567"), Some("Q1172284".to_string()));
    }

    #[test]
    fn test_get_work_type_software() {
        let mut adapter = DataCite2Wikidata::default();
        let mut work = make_datacite_work();
        work["data"]["attributes"]["types"]["resourceTypeGeneral"] = json!("Software");
        adapter.work_cache.insert("10.5281/ZENODO.1234567".to_string(), work);
        assert_eq!(adapter.get_work_type("10.5281/ZENODO.1234567"), Some("Q7397".to_string()));
    }

    #[test]
    fn test_datacite_type_to_q() {
        assert_eq!(DataCite2Wikidata::datacite_type_to_q("Book"), Some("Q571"));
        assert_eq!(DataCite2Wikidata::datacite_type_to_q("Dataset"), Some("Q1172284"));
        assert_eq!(DataCite2Wikidata::datacite_type_to_q("JournalArticle"), Some("Q13442814"));
        assert_eq!(DataCite2Wikidata::datacite_type_to_q("Unknown"), None);
    }

    #[test]
    fn test_get_publication_date_with_issued_date() {
        let mut adapter = DataCite2Wikidata::default();
        adapter
            .work_cache
            .insert("10.5281/ZENODO.1234567".to_string(), make_datacite_work());
        assert_eq!(
            adapter.get_publication_date("10.5281/ZENODO.1234567"),
            Some((2023, Some(3), Some(15)))
        );
    }

    #[test]
    fn test_get_publication_date_year_only() {
        let mut adapter = DataCite2Wikidata::default();
        let mut work = make_datacite_work();
        work["data"]["attributes"]["dates"] = json!([]);
        adapter.work_cache.insert("10.5281/ZENODO.1234567".to_string(), work);
        assert_eq!(
            adapter.get_publication_date("10.5281/ZENODO.1234567"),
            Some((2023, None, None))
        );
    }

    #[tokio::test]
    async fn test_get_author_list() {
        let mut adapter = DataCite2Wikidata::default();
        adapter
            .work_cache
            .insert("10.5281/ZENODO.1234567".to_string(), make_datacite_work());
        let authors = adapter.get_author_list("10.5281/ZENODO.1234567").await;
        assert_eq!(authors.len(), 2);
        assert_eq!(authors[0].name(), Some("Alice Smith"));
        assert_eq!(authors[0].list_number(), Some("1"));
        assert_eq!(authors[0].prop2id().get("P496"), Some(&"0000-0001-2345-6789".to_string()));
        assert_eq!(authors[1].name(), Some("Bob Jones"));
        assert_eq!(authors[1].list_number(), Some("2"));
        assert!(!authors[1].prop2id().contains_key("P496"));
    }

    #[tokio::test]
    async fn test_get_author_list_name_only() {
        let mut adapter = DataCite2Wikidata::default();
        let mut work = make_datacite_work();
        work["data"]["attributes"]["creators"] = json!([
            {
                "name": "CERN Data Team",
                "nameIdentifiers": []
            }
        ]);
        adapter.work_cache.insert("10.5281/ZENODO.1234567".to_string(), work);
        let authors = adapter.get_author_list("10.5281/ZENODO.1234567").await;
        assert_eq!(authors.len(), 1);
        assert_eq!(authors[0].name(), Some("CERN Data Team"));
    }

    #[tokio::test]
    async fn test_get_author_list_empty() {
        let mut adapter = DataCite2Wikidata::default();
        let mut work = make_datacite_work();
        work["data"]["attributes"]["creators"] = json!([]);
        adapter.work_cache.insert("10.5281/ZENODO.1234567".to_string(), work);
        assert!(adapter.get_author_list("10.5281/ZENODO.1234567").await.is_empty());
    }

    // === HTTP-injected tests (P2-10) =======================================

    use crate::http_client::MockJsonFetcher;

    #[tokio::test]
    async fn fetch_work_by_doi_hits_expected_url_and_caches() {
        let fetcher = Arc::new(MockJsonFetcher::new());
        let url = "https://api.datacite.org/dois/10.5281/zenodo.999";
        fetcher.add_response(
            url,
            json!({"data": {"attributes": {"titles": [{"title": "X"}]}}}),
        );
        let mut adapter = DataCite2Wikidata::new(fetcher.clone());
        let pub_id = adapter.fetch_work_by_doi("10.5281/zenodo.999").await;
        // DataCite's fetch_doi_data uppercases the cache key.
        assert_eq!(pub_id, Some("10.5281/ZENODO.999".to_string()));
        assert_eq!(fetcher.captured_urls(), vec![url.to_string()]);
    }

    #[tokio::test]
    async fn fetch_work_by_doi_returns_none_on_fetch_failure() {
        let fetcher = Arc::new(MockJsonFetcher::new());
        let url = "https://api.datacite.org/dois/10.5281/zenodo.999";
        fetcher.add_failure(url);
        let mut adapter = DataCite2Wikidata::new(fetcher);
        assert!(adapter.fetch_work_by_doi("10.5281/zenodo.999").await.is_none());
    }

    #[tokio::test]
    async fn fetch_work_by_doi_returns_none_when_attributes_missing() {
        // Server returns 200 OK but the JSON has no `data.attributes` object;
        // the early guard in fetch_doi_data rejects this.
        let fetcher = Arc::new(MockJsonFetcher::new());
        let url = "https://api.datacite.org/dois/10.5281/zenodo.999";
        fetcher.add_response(url, json!({"data": {}}));
        let mut adapter = DataCite2Wikidata::new(fetcher);
        assert!(adapter.fetch_work_by_doi("10.5281/zenodo.999").await.is_none());
    }
}