panache 2.37.0

An LSP, formatter, and linter for Pandoc markdown, Quarto, and RMarkdown
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
//! List conversion utilities for code actions.
//!
//! Provides functions to convert lists between loose/compact and bullet/ordered/task styles.

use crate::syntax::{AstNode, List, ListKind, SyntaxKind, SyntaxNode, SyntaxToken};
use tower_lsp_server::ls_types::{Range, TextEdit};

use super::super::conversions::offset_to_position;

/// Find the innermost LIST node at the given position.
pub fn find_list_at_position(tree: &SyntaxNode, offset: usize) -> Option<SyntaxNode> {
    // Find the deepest node at this offset
    let text_size = rowan::TextSize::from(offset as u32);
    let token = tree.token_at_offset(text_size).right_biased()?;

    // Walk up the tree to find the innermost LIST node
    token
        .parent_ancestors()
        .find(|node| node.kind() == SyntaxKind::LIST)
}

/// Detects the marker style for a list using the first list item's marker token.
pub fn detect_list_type(list_node: &SyntaxNode) -> Option<ListKind> {
    let list = List::cast(list_node.clone())?;
    list.kind()
}

/// Convert a compact list to a loose list by inserting blank lines between items.
///
/// Returns a list of TextEdits that insert blank lines after each list item
/// (except the last one, to avoid adding trailing blank lines).
pub fn convert_to_loose(list_node: &SyntaxNode, text: &str) -> Vec<TextEdit> {
    let list = match List::cast(list_node.clone()) {
        Some(l) => l,
        None => return vec![],
    };

    if list.is_loose() {
        // Already loose, nothing to do
        return vec![];
    }

    let mut edits = Vec::new();
    let items: Vec<_> = list.items().collect();

    // Insert blank line after each item except the last
    for (idx, item) in items.iter().enumerate() {
        if idx == items.len() - 1 {
            // Don't add blank line after last item
            continue;
        }

        // Find the end of this item (right after its last newline)
        let item_end = item.syntax().text_range().end().into();

        // Insert a blank line
        let position = offset_to_position(text, item_end);
        edits.push(TextEdit {
            range: Range {
                start: position,
                end: position,
            },
            new_text: "\n".to_string(),
        });
    }

    edits
}

/// Convert a loose list to a compact list by removing blank lines between items.
///
/// Returns a list of TextEdits that remove blank lines between list items.
pub fn convert_to_compact(list_node: &SyntaxNode, text: &str) -> Vec<TextEdit> {
    let list = match List::cast(list_node.clone()) {
        Some(l) => l,
        None => return vec![],
    };

    if list.is_compact() {
        // Already compact, nothing to do
        return vec![];
    }

    let mut edits = Vec::new();

    // Find all BLANK_LINE nodes that are between LIST_ITEM nodes
    let children: Vec<_> = list_node.children_with_tokens().collect();
    let mut prev_was_item = false;

    for (idx, child) in children.iter().enumerate() {
        if let Some(node) = child.as_node() {
            if node.kind() == SyntaxKind::LIST_ITEM {
                prev_was_item = true;
            } else if node.kind() == SyntaxKind::BLANK_LINE && prev_was_item {
                // Check if next non-blank node is also a LIST_ITEM
                let has_next_item = children[idx + 1..]
                    .iter()
                    .find(|c| {
                        c.as_node()
                            .map(|n| n.kind() != SyntaxKind::BLANK_LINE)
                            .unwrap_or(false)
                    })
                    .and_then(|c| c.as_node())
                    .map(|n| n.kind() == SyntaxKind::LIST_ITEM)
                    .unwrap_or(false);

                if has_next_item {
                    // Remove this blank line
                    let start = offset_to_position(text, node.text_range().start().into());
                    let end = offset_to_position(text, node.text_range().end().into());
                    edits.push(TextEdit {
                        range: Range { start, end },
                        new_text: String::new(),
                    });
                }
            }
        } else if let Some(token) = child.as_token()
            && token.kind() == SyntaxKind::BLANK_LINE
            && prev_was_item
        {
            // Check if next non-blank element is also a LIST_ITEM
            let has_next_item = children[idx + 1..]
                .iter()
                .find(|c| {
                    if let Some(n) = c.as_node() {
                        n.kind() != SyntaxKind::BLANK_LINE
                    } else if let Some(t) = c.as_token() {
                        t.kind() != SyntaxKind::BLANK_LINE
                    } else {
                        false
                    }
                })
                .and_then(|c| c.as_node())
                .map(|n| n.kind() == SyntaxKind::LIST_ITEM)
                .unwrap_or(false);

            if has_next_item {
                // Remove this blank line token
                let start = offset_to_position(text, token.text_range().start().into());
                let end = offset_to_position(text, token.text_range().end().into());
                edits.push(TextEdit {
                    range: Range { start, end },
                    new_text: String::new(),
                });
            }
        }
    }

    edits
}

/// Convert a bullet list to an ordered list by replacing markers with 1., 2., ...
pub fn convert_to_ordered(list_node: &SyntaxNode, text: &str) -> Vec<TextEdit> {
    if detect_list_type(list_node) != Some(ListKind::Bullet) {
        return vec![];
    }

    let Some(list) = List::cast(list_node.clone()) else {
        return vec![];
    };

    list.items()
        .enumerate()
        .filter_map(|(idx, item)| {
            let marker = first_item_marker_token(item.syntax())?;
            let start = offset_to_position(text, marker.text_range().start().into());
            let end = offset_to_position(text, marker.text_range().end().into());
            Some(TextEdit {
                range: Range { start, end },
                new_text: format!("{}.", idx + 1),
            })
        })
        .collect()
}

/// Convert an ordered list to a bullet list by replacing markers with "-".
pub fn convert_to_bullet(list_node: &SyntaxNode, text: &str) -> Vec<TextEdit> {
    if !matches!(
        detect_list_type(list_node),
        Some(ListKind::Ordered | ListKind::Task)
    ) {
        return vec![];
    }

    let Some(list) = List::cast(list_node.clone()) else {
        return vec![];
    };

    list.items()
        .flat_map(|item| {
            let mut edits = Vec::new();
            let Some(marker) = first_item_marker_token(item.syntax()) else {
                return edits;
            };
            let start = offset_to_position(text, marker.text_range().start().into());
            let end = offset_to_position(text, marker.text_range().end().into());
            edits.push(TextEdit {
                range: Range { start, end },
                new_text: "-".to_string(),
            });

            if let Some(checkbox) = task_checkbox_token(item.syntax()) {
                let checkbox_start = offset_to_position(text, checkbox.text_range().start().into());
                let checkbox_end = offset_to_position(
                    text,
                    checkbox_removal_end_offset(text, checkbox.text_range().end().into()),
                );
                edits.push(TextEdit {
                    range: Range {
                        start: checkbox_start,
                        end: checkbox_end,
                    },
                    new_text: String::new(),
                });
            }

            edits
        })
        .collect()
}

/// Convert a non-task list to a task list by inserting an unchecked checkbox after each marker.
///
/// Ordered lists are converted to bullet task lists (`- [ ]`) to match canonical
/// Pandoc/GFM task-list form.
pub fn convert_to_task(list_node: &SyntaxNode, text: &str) -> Vec<TextEdit> {
    let list_type = detect_list_type(list_node);
    if !matches!(list_type, Some(ListKind::Bullet | ListKind::Ordered)) {
        return vec![];
    }

    let Some(list) = List::cast(list_node.clone()) else {
        return vec![];
    };

    list.items()
        .flat_map(|item| {
            let mut edits = Vec::new();
            let marker = first_item_marker_token(item.syntax())?;

            if list_type == Some(ListKind::Ordered) {
                let marker_start = offset_to_position(text, marker.text_range().start().into());
                let marker_end = offset_to_position(text, marker.text_range().end().into());
                edits.push(TextEdit {
                    range: Range {
                        start: marker_start,
                        end: marker_end,
                    },
                    new_text: "-".to_string(),
                });
            }

            let insert_at = offset_to_position(text, marker.text_range().end().into());
            edits.push(TextEdit {
                range: Range {
                    start: insert_at,
                    end: insert_at,
                },
                new_text: " [ ]".to_string(),
            });

            Some(edits)
        })
        .flatten()
        .collect()
}

/// Convert a task list to an ordered list by replacing markers and removing checkboxes.
pub fn convert_task_to_ordered(list_node: &SyntaxNode, text: &str) -> Vec<TextEdit> {
    if detect_list_type(list_node) != Some(ListKind::Task) {
        return vec![];
    }

    let Some(list) = List::cast(list_node.clone()) else {
        return vec![];
    };

    list.items()
        .enumerate()
        .flat_map(|(idx, item)| {
            let mut edits = Vec::new();
            let Some(marker) = first_item_marker_token(item.syntax()) else {
                return edits;
            };

            let marker_start = offset_to_position(text, marker.text_range().start().into());
            let marker_end = offset_to_position(text, marker.text_range().end().into());
            edits.push(TextEdit {
                range: Range {
                    start: marker_start,
                    end: marker_end,
                },
                new_text: format!("{}.", idx + 1),
            });

            if let Some(checkbox) = task_checkbox_token(item.syntax()) {
                let checkbox_start = offset_to_position(text, checkbox.text_range().start().into());
                let checkbox_end = offset_to_position(
                    text,
                    checkbox_removal_end_offset(text, checkbox.text_range().end().into()),
                );
                edits.push(TextEdit {
                    range: Range {
                        start: checkbox_start,
                        end: checkbox_end,
                    },
                    new_text: String::new(),
                });
            }

            edits
        })
        .collect()
}

fn first_item_marker_token(item_node: &SyntaxNode) -> Option<SyntaxToken> {
    item_node
        .children_with_tokens()
        .find_map(|elem| elem.as_token().cloned())
        .filter(|token| token.kind() == SyntaxKind::LIST_MARKER)
}

fn task_checkbox_token(item_node: &SyntaxNode) -> Option<SyntaxToken> {
    item_node.children_with_tokens().find_map(|elem| {
        elem.as_token()
            .filter(|token| token.kind() == SyntaxKind::TASK_CHECKBOX)
            .cloned()
    })
}

fn checkbox_removal_end_offset(text: &str, checkbox_end: usize) -> usize {
    match text.as_bytes().get(checkbox_end) {
        Some(b' ' | b'\t') => checkbox_end + 1,
        _ => checkbox_end,
    }
}

#[cfg(test)]
mod tests {
    use super::*;
    use crate::parse;
    use tower_lsp_server::ls_types::Position;

    fn apply_text_edits(input: &str, edits: &[TextEdit]) -> String {
        fn position_to_offset(text: &str, position: Position) -> usize {
            let target_line = position.line as usize;
            let target_char = position.character as usize;
            let mut line = 0usize;
            let mut col = 0usize;

            for (idx, ch) in text.char_indices() {
                if line == target_line && col == target_char {
                    return idx;
                }
                if ch == '\n' {
                    line += 1;
                    col = 0;
                } else {
                    col += 1;
                }
            }
            text.len()
        }

        let mut result = input.to_string();
        let mut sorted = edits.to_vec();
        sorted.sort_by(|a, b| {
            let key_a = (
                a.range.start.line,
                a.range.start.character,
                a.range.end.line,
                a.range.end.character,
            );
            let key_b = (
                b.range.start.line,
                b.range.start.character,
                b.range.end.line,
                b.range.end.character,
            );
            key_b.cmp(&key_a)
        });

        for edit in sorted {
            let start = position_to_offset(&result, edit.range.start);
            let end = position_to_offset(&result, edit.range.end);
            result.replace_range(start..end, &edit.new_text);
        }
        result
    }

    #[test]
    fn find_list_at_position_finds_innermost() {
        let input = "- Outer\n  - Inner\n  - Inner2\n- Outer2\n";
        let tree = parse(input, None);

        // Offset inside "Inner" (should find inner list)
        let offset = input.find("Inner").unwrap();
        let list = find_list_at_position(&tree, offset).expect("Should find list");
        let wrapped = List::cast(list).expect("Should cast to List");

        // The inner list has 2 items
        assert_eq!(wrapped.items().count(), 2);
    }

    #[test]
    fn convert_compact_to_loose() {
        let input = "- First\n- Second\n- Third\n";
        let tree = parse(input, None);

        let list_node = tree
            .descendants()
            .find(|n| n.kind() == SyntaxKind::LIST)
            .expect("Should find list");

        let edits = convert_to_loose(&list_node, input);

        // Should have 2 edits (after first and second items)
        assert_eq!(edits.len(), 2);

        // First edit should insert after "First\n"
        assert_eq!(edits[0].new_text, "\n");
        assert_eq!(edits[0].range.start.line, 1);

        // Second edit should insert after "Second\n"
        assert_eq!(edits[1].new_text, "\n");
        assert_eq!(edits[1].range.start.line, 2);
    }

    #[test]
    fn convert_loose_to_compact() {
        let input = "- First\n\n- Second\n\n- Third\n";
        let tree = parse(input, None);

        let list_node = tree
            .descendants()
            .find(|n| n.kind() == SyntaxKind::LIST)
            .expect("Should find list");

        let edits = convert_to_compact(&list_node, input);

        // Should have 2 edits (remove 2 blank lines)
        assert_eq!(edits.len(), 2);

        // Each edit should remove one blank line
        for edit in &edits {
            assert_eq!(edit.new_text, "");
            assert!(edit.range.start != edit.range.end);
        }
    }

    #[test]
    fn already_loose_returns_empty() {
        let input = "- First\n\n- Second\n";
        let tree = parse(input, None);

        let list_node = tree
            .descendants()
            .find(|n| n.kind() == SyntaxKind::LIST)
            .expect("Should find list");

        let edits = convert_to_loose(&list_node, input);
        assert_eq!(edits.len(), 0, "Should return no edits for already loose");
    }

    #[test]
    fn already_compact_returns_empty() {
        let input = "- First\n- Second\n";
        let tree = parse(input, None);

        let list_node = tree
            .descendants()
            .find(|n| n.kind() == SyntaxKind::LIST)
            .expect("Should find list");

        let edits = convert_to_compact(&list_node, input);
        assert_eq!(edits.len(), 0, "Should return no edits for already compact");
    }

    #[test]
    fn detect_list_type_for_bullet_and_ordered() {
        let bullet_tree = parse("- First\n- Second\n", None);
        let bullet_list = bullet_tree
            .descendants()
            .find(|n| n.kind() == SyntaxKind::LIST)
            .expect("Should find bullet list");
        assert_eq!(detect_list_type(&bullet_list), Some(ListKind::Bullet));

        let ordered_tree = parse("1. First\n2. Second\n", None);
        let ordered_list = ordered_tree
            .descendants()
            .find(|n| n.kind() == SyntaxKind::LIST)
            .expect("Should find ordered list");
        assert_eq!(detect_list_type(&ordered_list), Some(ListKind::Ordered));
    }

    #[test]
    fn detect_list_type_for_task() {
        let task_tree = parse("- [ ] First\n- [x] Second\n", None);
        let task_list = task_tree
            .descendants()
            .find(|n| n.kind() == SyntaxKind::LIST)
            .expect("Should find task list");
        assert_eq!(detect_list_type(&task_list), Some(ListKind::Task));
    }

    #[test]
    fn convert_bullet_to_ordered() {
        let input = "- First\n- Second\n- Third\n";
        let tree = parse(input, None);
        let list_node = tree
            .descendants()
            .find(|n| n.kind() == SyntaxKind::LIST)
            .expect("Should find list");

        let edits = convert_to_ordered(&list_node, input);
        assert_eq!(edits.len(), 3);
        assert_eq!(edits[0].new_text, "1.");
        assert_eq!(edits[1].new_text, "2.");
        assert_eq!(edits[2].new_text, "3.");
    }

    #[test]
    fn convert_ordered_to_bullet() {
        let input = "1. First\n2. Second\n3. Third\n";
        let tree = parse(input, None);
        let list_node = tree
            .descendants()
            .find(|n| n.kind() == SyntaxKind::LIST)
            .expect("Should find list");

        let edits = convert_to_bullet(&list_node, input);
        assert_eq!(edits.len(), 3);
        assert!(edits.iter().all(|edit| edit.new_text == "-"));
    }

    #[test]
    fn convert_bullet_to_task() {
        let input = "- First\n- Second\n";
        let tree = parse(input, None);
        let list_node = tree
            .descendants()
            .find(|n| n.kind() == SyntaxKind::LIST)
            .expect("Should find list");

        let edits = convert_to_task(&list_node, input);
        assert_eq!(edits.len(), 2);
        assert!(edits.iter().all(|edit| edit.new_text == " [ ]"));
    }

    #[test]
    fn convert_ordered_to_task() {
        let input = "1. First\n2. Second\n";
        let tree = parse(input, None);
        let list_node = tree
            .descendants()
            .find(|n| n.kind() == SyntaxKind::LIST)
            .expect("Should find list");

        let edits = convert_to_task(&list_node, input);
        assert_eq!(edits.len(), 4, "marker + checkbox edit per item");
        assert_eq!(edits[0].new_text, "-");
        assert_eq!(edits[1].new_text, " [ ]");
        assert_eq!(edits[2].new_text, "-");
        assert_eq!(edits[3].new_text, " [ ]");
    }

    #[test]
    fn convert_task_to_bullet_removes_checkboxes() {
        let input = "- [ ] First\n- [x] Second\n";
        let tree = parse(input, None);
        let list_node = tree
            .descendants()
            .find(|n| n.kind() == SyntaxKind::LIST)
            .expect("Should find list");

        let edits = convert_to_bullet(&list_node, input);
        assert_eq!(edits.len(), 4, "marker + checkbox edit per item");
        assert_eq!(edits[0].new_text, "-");
        assert_eq!(edits[1].new_text, "");
        assert_eq!(edits[2].new_text, "-");
        assert_eq!(edits[3].new_text, "");
        let output = apply_text_edits(input, &edits);
        assert_eq!(output, "- First\n- Second\n");
    }

    #[test]
    fn convert_task_to_ordered_removes_checkboxes() {
        let input = "- [ ] First\n- [x] Second\n";
        let tree = parse(input, None);
        let list_node = tree
            .descendants()
            .find(|n| n.kind() == SyntaxKind::LIST)
            .expect("Should find list");

        let edits = convert_task_to_ordered(&list_node, input);
        assert_eq!(edits.len(), 4, "marker + checkbox edit per item");
        assert_eq!(edits[0].new_text, "1.");
        assert_eq!(edits[1].new_text, "");
        assert_eq!(edits[2].new_text, "2.");
        assert_eq!(edits[3].new_text, "");
        let output = apply_text_edits(input, &edits);
        assert_eq!(output, "1. First\n2. Second\n");
    }
}