paladin-memory 0.5.1

Memory adapters for the Paladin framework — Garrison (conversation history) and Sanctum (vector search)
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
/// RAG Retrieval Service
///
/// Handles retrieval of relevant memories from long-term storage (Sanctum)
/// for Retrieval-Augmented Generation (RAG).
///
/// This service:
/// - Generates embeddings for queries
/// - Searches Sanctum for similar memories
/// - Filters by similarity threshold
/// - Deduplicates near-identical memories
/// - Ranks by relevance
/// - Truncates to fit token budget
/// - Formats memories for prompt injection
use std::collections::HashSet;
use std::sync::Arc;

use paladin_ports::output::embedding_port::EmbeddingPort;
use paladin_ports::output::sanctum_port::{
    SanctumError, SanctumFilter, SanctumPort, SanctumQuery, SanctumSearchResult,
};

// RagConfig and RetrievalTrigger moved to crates/paladin-memory/src/config/rag.rs (Task 6.0)
pub use crate::config::rag::{RagConfig, RetrievalTrigger};

/// Service for retrieving relevant memories using RAG.
///
/// Depends only on port traits — contains no concrete adapter references.
pub struct RagRetrievalService {
    sanctum: Arc<dyn SanctumPort>,
    embedding: Arc<dyn EmbeddingPort>,
    config: RagConfig,
}

impl RagRetrievalService {
    /// Create a new RAG retrieval service.
    ///
    /// # Arguments
    ///
    /// * `sanctum` - Vector storage port for memory retrieval
    /// * `embedding` - Embedding generation port for query vectorization
    /// * `config` - RAG configuration parameters
    pub fn new(
        sanctum: Arc<dyn SanctumPort>,
        embedding: Arc<dyn EmbeddingPort>,
        config: RagConfig,
    ) -> Self {
        Self {
            sanctum,
            embedding,
            config,
        }
    }

    /// Retrieve relevant memories for a given query.
    ///
    /// # Arguments
    ///
    /// * `paladin_id` - ID of the Paladin requesting memories
    /// * `query` - The query text to find relevant memories for
    ///
    /// # Returns
    ///
    /// A vector of search results sorted by relevance (descending).
    ///
    /// # Errors
    ///
    /// Returns [`SanctumError`] if embedding generation or search fails.
    pub async fn retrieve_context(
        &self,
        paladin_id: &str,
        query: &str,
    ) -> Result<Vec<SanctumSearchResult>, SanctumError> {
        // Generate query embedding
        let embedding_result = self.embedding.embed_text(query).await.map_err(|e| {
            SanctumError::SearchError(format!("Embedding generation failed: {}", e))
        })?;

        // Build filter for this Paladin
        let filter = SanctumFilter::new().paladin_id(paladin_id.to_string());

        // Build search query
        let sanctum_query = SanctumQuery::new(embedding_result.vector, self.config.top_k)
            .with_filter(filter)
            .with_min_score(self.config.min_similarity);

        // Execute search
        let mut results = self.sanctum.search(sanctum_query).await?;

        log::debug!(
            "Retrieved {} memories for paladin {} with query: {}",
            results.len(),
            paladin_id,
            query
        );

        // Apply post-processing
        results = self.filter_by_similarity(results);
        results = self.deduplicate_memories(results);
        results = self.rank_by_relevance(results);
        results = self.truncate_to_token_budget(results);

        Ok(results)
    }

    /// Filter results by minimum similarity threshold.
    fn filter_by_similarity(&self, results: Vec<SanctumSearchResult>) -> Vec<SanctumSearchResult> {
        results
            .into_iter()
            .filter(|r| r.score >= self.config.min_similarity)
            .collect()
    }

    /// Deduplicate near-identical memories (>0.95 similarity).
    ///
    /// Removes memories that are very similar to each other, keeping only
    /// the highest-scoring instance.
    fn deduplicate_memories(
        &self,
        mut results: Vec<SanctumSearchResult>,
    ) -> Vec<SanctumSearchResult> {
        if results.len() <= 1 {
            return results;
        }

        // Sort by score descending to keep highest-scoring duplicates
        results.sort_by(|a, b| b.score.partial_cmp(&a.score).unwrap());

        let original_count = results.len();
        let mut deduplicated = Vec::new();
        let mut seen_contents = HashSet::new();

        for result in results {
            // Use content as deduplication key
            let content_key = result.entry.memory.content.trim().to_lowercase();

            // Check if we've seen very similar content
            let is_duplicate = seen_contents.iter().any(|seen: &String| {
                // Simple similarity: check if content is substring or vice versa
                content_key.contains(seen) || seen.contains(&content_key)
            });

            if !is_duplicate {
                seen_contents.insert(content_key);
                deduplicated.push(result);
            }
        }

        log::debug!(
            "Deduplication: {} -> {} memories",
            original_count,
            deduplicated.len()
        );

        deduplicated
    }

    /// Rank memories by relevance score (descending).
    fn rank_by_relevance(&self, mut results: Vec<SanctumSearchResult>) -> Vec<SanctumSearchResult> {
        results.sort_by(|a, b| {
            b.score
                .partial_cmp(&a.score)
                .unwrap_or(std::cmp::Ordering::Equal)
        });
        results
    }

    /// Truncate results to fit within token budget.
    ///
    /// Estimates tokens per memory and removes lowest-scoring memories
    /// to stay within the configured `max_tokens` limit.
    fn truncate_to_token_budget(
        &self,
        results: Vec<SanctumSearchResult>,
    ) -> Vec<SanctumSearchResult> {
        let mut total_tokens = 0;
        let mut truncated = Vec::new();

        for result in results {
            // Rough estimation: ~4 characters per token
            let estimated_tokens = result.entry.memory.content.len() / 4;

            if total_tokens + estimated_tokens <= self.config.max_tokens {
                total_tokens += estimated_tokens;
                truncated.push(result);
            } else {
                log::debug!(
                    "Truncating memories at token budget: {} tokens used of {} max",
                    total_tokens,
                    self.config.max_tokens
                );
                break;
            }
        }

        truncated
    }

    /// Format retrieved memories for prompt injection.
    ///
    /// Creates a structured text block suitable for including in the system
    /// prompt or user message.
    ///
    /// # Arguments
    ///
    /// * `memories` - The search results to format
    ///
    /// # Returns
    ///
    /// A formatted string containing the relevant context section.
    pub fn format_for_prompt(&self, memories: &[SanctumSearchResult]) -> String {
        if memories.is_empty() {
            return String::new();
        }

        let mut formatted = String::from("## Relevant Context\n\n");
        formatted.push_str("The following memories may be relevant to your current task:\n\n");

        for (idx, result) in memories.iter().enumerate() {
            let memory = &result.entry.memory;

            formatted.push_str(&format!(
                "**Memory {}** (Similarity: {:.2})\n",
                idx + 1,
                result.score
            ));
            formatted.push_str(&format!("Type: {:?}\n", memory.memory_type));
            formatted.push_str(&format!("Content: {}\n", memory.content));
            formatted.push_str(&format!(
                "Source: Conversation on {}\n\n",
                memory.created_at.format("%Y-%m-%d")
            ));
        }

        formatted.push_str("---\n\n");
        formatted
    }
}

/// Async wrapper for [`RagRetrievalService::retrieve_context`] with a timeout.
///
/// Returns an empty `Vec` on timeout to enable graceful degradation.
pub async fn retrieve_context_with_timeout(
    service: &RagRetrievalService,
    paladin_id: &str,
    query: &str,
    timeout_secs: u64,
) -> Result<Vec<SanctumSearchResult>, SanctumError> {
    match tokio::time::timeout(
        std::time::Duration::from_secs(timeout_secs),
        service.retrieve_context(paladin_id, query),
    )
    .await
    {
        Ok(result) => result,
        Err(_) => {
            log::warn!(
                "Memory retrieval timed out after {} seconds, continuing with empty context",
                timeout_secs
            );
            Ok(Vec::new())
        }
    }
}

#[cfg(test)]
mod tests {
    use super::*;
    use async_trait::async_trait;
    use paladin_core::platform::container::sanctum::{MemoryBuilder, MemoryType, SanctumEntry};
    use paladin_ports::output::embedding_port::{Embedding, EmbeddingError, EmbeddingPort};
    use paladin_ports::output::sanctum_port::{
        SanctumError, SanctumFilter, SanctumPort, SanctumQuery, SanctumSearchResult,
    };
    use std::sync::Arc;

    // ── Mock helpers ──────────────────────────────────────────────────────────

    struct MockEmbeddingPort;

    #[async_trait]
    impl EmbeddingPort for MockEmbeddingPort {
        async fn embed_text(&self, _text: &str) -> Result<Embedding, EmbeddingError> {
            Ok(Embedding {
                vector: vec![0.1, 0.2, 0.3, 0.4, 0.5],
                model: "mock-model".to_string(),
                dimension: 5,
                token_count: Some(10),
            })
        }

        async fn embed_batch(&self, texts: &[&str]) -> Result<Vec<Embedding>, EmbeddingError> {
            Ok(texts
                .iter()
                .map(|_| Embedding {
                    vector: vec![0.1, 0.2, 0.3, 0.4, 0.5],
                    model: "mock-model".to_string(),
                    dimension: 5,
                    token_count: Some(10),
                })
                .collect())
        }

        fn dimension(&self) -> usize {
            5
        }

        fn model_name(&self) -> &str {
            "mock-model"
        }
    }

    struct MockSanctumPort {
        results: Vec<SanctumSearchResult>,
    }

    #[async_trait]
    impl SanctumPort for MockSanctumPort {
        async fn store(&self, _entry: SanctumEntry) -> Result<(), SanctumError> {
            Ok(())
        }

        async fn store_batch(&self, _entries: Vec<SanctumEntry>) -> Result<(), SanctumError> {
            Ok(())
        }

        async fn search(
            &self,
            _query: SanctumQuery,
        ) -> Result<Vec<SanctumSearchResult>, SanctumError> {
            Ok(self.results.clone())
        }

        async fn delete(&self, _id: &str) -> Result<bool, SanctumError> {
            Ok(true)
        }

        async fn update(&self, _entry: SanctumEntry) -> Result<(), SanctumError> {
            Ok(())
        }

        async fn count(&self, _filter: Option<SanctumFilter>) -> Result<usize, SanctumError> {
            Ok(self.results.len())
        }
    }

    fn create_test_entry(
        paladin_id: &str,
        content: &str,
        importance: f32,
        score: f32,
    ) -> SanctumSearchResult {
        let memory = MemoryBuilder::new(paladin_id.to_string(), content.to_string())
            .importance(importance)
            .memory_type(MemoryType::Semantic)
            .build()
            .unwrap();
        let entry = SanctumEntry::new(memory, vec![0.1, 0.2, 0.3, 0.4, 0.5]).unwrap();
        SanctumSearchResult::new(entry, score)
    }

    // ── Config / trigger tests ────────────────────────────────────────────────

    #[test]
    fn test_rag_config_builder() {
        let config = RagConfig {
            top_k: 10,
            min_similarity: 0.8,
            max_tokens: 3000,
            timeout_seconds: 5,
            retrieval_trigger: RetrievalTrigger::KeywordBased,
        };

        assert_eq!(config.top_k, 10);
        assert_eq!(config.min_similarity, 0.8);
        assert_eq!(config.max_tokens, 3000);
    }

    #[test]
    fn test_retrieval_trigger_equality() {
        assert_eq!(RetrievalTrigger::Always, RetrievalTrigger::Always);
        assert_ne!(RetrievalTrigger::Always, RetrievalTrigger::KeywordBased);
    }

    #[test]
    fn test_rag_config_default() {
        let config = RagConfig::default();
        assert_eq!(config.top_k, 5);
        assert_eq!(config.min_similarity, 0.7);
        assert_eq!(config.max_tokens, 2000);
    }

    #[test]
    fn test_retrieval_trigger_variants() {
        let trigger = RetrievalTrigger::Always;
        assert!(matches!(trigger, RetrievalTrigger::Always));
    }

    // ── Async retrieval tests ─────────────────────────────────────────────────

    #[tokio::test]
    async fn test_successful_retrieval_with_multiple_memories() {
        let mock_results = vec![
            create_test_entry("paladin-1", "Memory 1", 0.9, 0.95),
            create_test_entry("paladin-1", "Memory 2", 0.8, 0.85),
            create_test_entry("paladin-1", "Memory 3", 0.7, 0.75),
        ];

        let sanctum = Arc::new(MockSanctumPort {
            results: mock_results,
        });
        let embedding = Arc::new(MockEmbeddingPort);
        let config = RagConfig::default();

        let service = RagRetrievalService::new(sanctum, embedding, config);
        let results = service
            .retrieve_context("paladin-1", "test query")
            .await
            .unwrap();

        assert_eq!(results.len(), 3);
    }

    #[tokio::test]
    async fn test_filtering_by_min_similarity() {
        let mock_results = vec![
            create_test_entry("paladin-1", "High score", 0.9, 0.95),
            create_test_entry("paladin-1", "Medium score", 0.8, 0.75),
            create_test_entry("paladin-1", "Low score", 0.7, 0.50),
        ];

        let sanctum = Arc::new(MockSanctumPort {
            results: mock_results,
        });
        let embedding = Arc::new(MockEmbeddingPort);
        let config = RagConfig {
            min_similarity: 0.7,
            ..Default::default()
        };

        let service = RagRetrievalService::new(sanctum, embedding, config);
        let results = service
            .retrieve_context("paladin-1", "test query")
            .await
            .unwrap();

        assert_eq!(results.len(), 2);
        assert!(results.iter().all(|r| r.score >= 0.7));
    }

    #[test]
    fn test_format_for_prompt() {
        let memories = vec![
            create_test_entry("paladin-1", "First memory", 0.9, 0.95),
            create_test_entry("paladin-1", "Second memory", 0.8, 0.85),
        ];

        let sanctum = Arc::new(MockSanctumPort { results: vec![] });
        let embedding = Arc::new(MockEmbeddingPort);
        let service = RagRetrievalService::new(sanctum, embedding, RagConfig::default());

        let formatted = service.format_for_prompt(&memories);

        assert!(formatted.contains("## Relevant Context"));
        assert!(formatted.contains("First memory"));
        assert!(formatted.contains("Second memory"));
        assert!(formatted.contains("0.95"));
        assert!(formatted.contains("0.85"));
    }

    #[tokio::test]
    async fn test_empty_results_graceful_handling() {
        let sanctum = Arc::new(MockSanctumPort { results: vec![] });
        let embedding = Arc::new(MockEmbeddingPort);
        let service = RagRetrievalService::new(sanctum, embedding, RagConfig::default());

        let results = service
            .retrieve_context("paladin-1", "test query")
            .await
            .unwrap();
        assert!(results.is_empty());
    }
}