pacsea 0.8.2

A fast, friendly TUI for browsing and installing Arch and AUR packages with built-in news and security scanning
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
1177
1178
1179
1180
1181
1182
1183
1184
1185
1186
1187
1188
1189
1190
1191
1192
1193
1194
1195
1196
1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
1207
1208
1209
1210
1211
1212
1213
1214
1215
1216
1217
1218
1219
1220
1221
1222
1223
1224
1225
1226
1227
1228
1229
1230
1231
1232
1233
1234
1235
1236
1237
1238
1239
1240
1241
1242
1243
1244
1245
1246
1247
1248
1249
1250
1251
1252
1253
1254
1255
1256
1257
1258
1259
1260
1261
1262
1263
1264
1265
1266
1267
1268
1269
1270
1271
1272
1273
1274
1275
1276
1277
1278
1279
1280
1281
1282
1283
1284
1285
1286
1287
1288
1289
1290
1291
1292
1293
1294
1295
1296
1297
1298
1299
1300
1301
1302
1303
1304
1305
1306
1307
1308
1309
1310
1311
1312
1313
1314
1315
1316
1317
1318
1319
1320
1321
1322
1323
1324
1325
1326
1327
1328
1329
1330
1331
1332
1333
1334
1335
1336
1337
1338
1339
1340
1341
1342
1343
1344
1345
1346
1347
1348
1349
1350
1351
1352
1353
1354
1355
1356
1357
1358
1359
1360
1361
1362
1363
1364
1365
1366
1367
1368
1369
1370
1371
1372
1373
//! Tests for Preflight modal event handling.

#[cfg(test)]
use super::display::{
    build_file_display_items, compute_display_items_len, compute_file_display_items_len,
};
#[cfg(test)]
use super::keys::handle_preflight_key;
#[cfg(test)]
use crate::state::modal::{
    CascadeMode, DependencyInfo, DependencySource, DependencyStatus, FileChange, FileChangeType,
    PackageFileInfo, ServiceImpact, ServiceRestartDecision,
};
#[cfg(test)]
use crate::state::{AppState, Modal, PackageItem, PreflightAction, PreflightTab, Source};
#[cfg(test)]
use crossterm::event::{KeyCode, KeyEvent, KeyModifiers};
#[cfg(test)]
use std::collections::HashSet;

/// What: Construct a minimal `PackageItem` fixture used by preflight tests.
///
/// Inputs:
/// - `name`: Package identifier to embed in the resulting fixture.
///
/// Output:
/// - `PackageItem` populated with deterministic metadata for assertions.
///
/// Details:
/// - Provides consistent version/description/source values so each test can focus on modal behaviour.
fn pkg(name: &str) -> PackageItem {
    PackageItem {
        name: name.into(),
        version: "1.0.0".into(),
        description: "pkg".into(),
        source: Source::Official {
            repo: "extra".into(),
            arch: "x86_64".into(),
        },
        popularity: None,
        out_of_date: None,
        orphaned: false,
    }
}

/// What: Build a `DependencyInfo` fixture describing a package edge for dependency tests.
///
/// Inputs:
/// - `name`: Dependency package name to populate the struct.
/// - `required_by`: Slice of package names that declare the dependency.
///
/// Output:
/// - `DependencyInfo` instance configured for deterministic assertions.
///
/// Details:
/// - Sets predictable version/status/source fields so tests can concentrate on tree expansion logic.
fn dep(name: &str, required_by: &[&str]) -> DependencyInfo {
    DependencyInfo {
        name: name.into(),
        version: ">=1".into(),
        status: DependencyStatus::ToInstall,
        source: DependencySource::Official {
            repo: "extra".into(),
        },
        required_by: required_by.iter().map(|s| (*s).into()).collect(),
        depends_on: Vec::new(),
        is_core: false,
        is_system: false,
    }
}

/// What: Build a `DependencyInfo` fixture with a specific status for testing status display.
///
/// Inputs:
/// - `name`: Dependency package name to populate the struct.
/// - `required_by`: Slice of package names that declare the dependency.
/// - `status`: Specific dependency status to test.
///
/// Output:
/// - `DependencyInfo` instance with the specified status for assertions.
///
/// Details:
/// - Allows testing different dependency statuses (`Installed`, `ToInstall`, etc.) to verify correct display.
fn dep_with_status(name: &str, required_by: &[&str], status: DependencyStatus) -> DependencyInfo {
    DependencyInfo {
        name: name.into(),
        version: ">=1".into(),
        status,
        source: DependencySource::Official {
            repo: "extra".into(),
        },
        required_by: required_by.iter().map(|s| (*s).into()).collect(),
        depends_on: Vec::new(),
        is_core: false,
        is_system: false,
    }
}

/// What: Create a `PackageFileInfo` fixture with a configurable number of synthetic files.
///
/// Inputs:
/// - `name`: Package identifier associated with the file changes.
/// - `file_count`: Number of file entries to generate.
///
/// Output:
/// - `PackageFileInfo` containing `file_count` new file records under `/tmp`.
///
/// Details:
/// - Each generated file is marked as a new change, allowing tests to validate expansion counts easily.
fn file_info(name: &str, file_count: usize) -> PackageFileInfo {
    let mut files = Vec::new();
    for idx in 0..file_count {
        files.push(FileChange {
            path: format!("/tmp/{name}_{idx}"),
            change_type: FileChangeType::New,
            package: name.into(),
            is_config: false,
            predicted_pacnew: false,
            predicted_pacsave: false,
        });
    }
    PackageFileInfo {
        name: name.into(),
        files,
        total_count: file_count,
        new_count: file_count,
        changed_count: 0,
        removed_count: 0,
        config_count: 0,
        pacnew_candidates: 0,
        pacsave_candidates: 0,
    }
}

/// What: Construct a `ServiceImpact` fixture representing a single unit for Services tab tests.
///
/// Inputs:
/// - `unit`: Fully-qualified systemd unit identifier to populate the struct.
/// - `decision`: Initial restart preference that the test expects to mutate.
///
/// Output:
/// - `ServiceImpact` configured with deterministic metadata for assertions.
///
/// Details:
/// - Marks the unit as active and needing restart so event handlers may flip the decision.
fn svc(unit: &str, decision: ServiceRestartDecision) -> ServiceImpact {
    ServiceImpact {
        unit_name: unit.into(),
        providers: vec!["target".into()],
        is_active: true,
        needs_restart: true,
        recommended_decision: ServiceRestartDecision::Restart,
        restart_decision: decision,
    }
}

#[test]
/// What: Ensure dependency display length counts unique entries when groups are expanded.
///
/// Inputs:
/// - Dependency list with duplicates and an expanded set containing the first package.
///
/// Output:
/// - Computed length includes headers plus unique dependencies, yielding four rows.
///
/// Details:
/// - Demonstrates deduplication of repeated dependency records across packages.
fn deps_display_len_counts_unique_expanded_dependencies() {
    let items = vec![pkg("app"), pkg("tool")];
    let deps = vec![
        dep("libfoo", &["app"]),
        dep("libbar", &["app", "tool"]),
        dep("libbar", &["app"]),
    ];
    let mut expanded = HashSet::new();
    expanded.insert("app".to_string());
    let len = compute_display_items_len(&items, &deps, &expanded);
    assert_eq!(len, 4);
}

#[test]
/// What: Verify the collapsed dependency view only counts package headers.
///
/// Inputs:
/// - Dependency list with multiple packages but an empty expanded set.
///
/// Output:
/// - Display length equals the number of packages (two).
///
/// Details:
/// - Confirms collapsed state omits dependency children entirely.
fn deps_display_len_collapsed_counts_only_headers() {
    let items = vec![pkg("app"), pkg("tool")];
    let deps = vec![dep("libfoo", &["app"]), dep("libbar", &["tool"])];
    let expanded = HashSet::new();
    let len = compute_display_items_len(&items, &deps, &expanded);
    assert_eq!(len, 2);
}

#[test]
/// What: Confirm file display counts add child rows only for expanded entries.
///
/// Inputs:
/// - File info for a package with two files and another with zero files.
///
/// Output:
/// - Collapsed count returns two (both packages shown); expanded count increases to four (2 headers + 2 files).
///
/// Details:
/// - Exercises the branch that toggles between header-only and expanded file listings.
fn file_display_len_respects_expansion_state() {
    let items = vec![pkg("pkg"), pkg("empty")];
    let info = vec![file_info("pkg", 2), file_info("empty", 0)];
    let mut expanded = HashSet::new();
    let collapsed = compute_file_display_items_len(&items, &info, &expanded);
    assert_eq!(collapsed, 2); // Both packages shown
    expanded.insert("pkg".to_string());
    let expanded_len = compute_file_display_items_len(&items, &info, &expanded);
    assert_eq!(expanded_len, 4); // 2 headers + 2 files from pkg
}

#[test]
/// What: Ensure file display item builder yields headers plus placeholder rows when expanded.
///
/// Inputs:
/// - File info with two entries for a single package and varying expansion sets.
///
/// Output:
/// - Collapsed result contains only the header; expanded result includes header plus two child slots.
///
/// Details:
/// - Helps guarantee alignment between item construction and length calculations.
fn build_file_items_match_expansion() {
    let items = vec![pkg("pkg")];
    let info = vec![file_info("pkg", 2)];
    let collapsed = build_file_display_items(&items, &info, &HashSet::new());
    assert_eq!(collapsed, vec![(true, "pkg".into())]);
    let mut expanded = HashSet::new();
    expanded.insert("pkg".to_string());
    let expanded_items = build_file_display_items(&items, &info, &expanded);
    assert_eq!(
        expanded_items,
        vec![
            (true, "pkg".into()),
            (false, String::new()),
            (false, String::new())
        ]
    );
}

/// What: Prepare an `AppState` with a seeded Preflight modal tailored for keyboard interaction tests.
///
/// Inputs:
/// - `tab`: Initial tab to display inside the Preflight modal.
/// - `dependency_info`: Pre-resolved dependency list to seed the modal state.
/// - `dep_selected`: Initial selection index for the dependency list.
/// - `dep_tree_expanded`: Set of package names that should start expanded.
///
/// Output:
/// - `AppState` instance whose `modal` field is pre-populated with consistent fixtures.
///
/// Details:
/// - Reduces duplication across tests that exercise navigation/expansion logic within the Preflight modal.
fn setup_preflight_app(
    tab: PreflightTab,
    dependency_info: Vec<DependencyInfo>,
    dep_selected: usize,
    dep_tree_expanded: HashSet<String>,
) -> AppState {
    let mut app = AppState::default();
    let items = vec![pkg("target")];
    app.modal = Modal::Preflight {
        items,
        action: PreflightAction::Install,
        tab,
        summary: None,
        summary_scroll: 0,
        header_chips: crate::state::modal::PreflightHeaderChips::default(),
        dependency_info,
        dep_selected,
        dep_tree_expanded,
        deps_error: None,
        file_info: Vec::new(),
        file_selected: 0,
        file_tree_expanded: HashSet::new(),
        files_error: None,
        service_info: Vec::new(),
        service_selected: 0,
        services_loaded: false,
        services_error: None,
        sandbox_info: Vec::new(),
        sandbox_selected: 0,
        sandbox_tree_expanded: std::collections::HashSet::new(),
        sandbox_loaded: false,
        sandbox_error: None,
        selected_optdepends: std::collections::HashMap::new(),
        cascade_mode: CascadeMode::Basic,
        cached_reverse_deps_report: None,
    };
    app
}

/// What: Build an `AppState` seeded with Services tab data for restart decision tests.
///
/// Inputs:
/// - `tab`: Initial tab to display inside the Preflight modal (expected to be Services).
/// - `service_info`: Collection of service impacts to expose through the modal.
/// - `service_selected`: Index that should be focused when the test begins.
///
/// Output:
/// - `AppState` populated with deterministic fixtures for Services tab interactions.
///
/// Details:
/// - Marks services as already loaded so handlers operate directly on the provided data.
fn setup_preflight_app_with_services(
    tab: PreflightTab,
    service_info: Vec<ServiceImpact>,
    service_selected: usize,
) -> AppState {
    let mut app = AppState::default();
    let items = vec![pkg("target")];
    app.modal = Modal::Preflight {
        items,
        action: PreflightAction::Install,
        tab,
        summary: None,
        summary_scroll: 0,
        header_chips: crate::state::modal::PreflightHeaderChips::default(),
        dependency_info: Vec::new(),
        dep_selected: 0,
        dep_tree_expanded: HashSet::new(),
        deps_error: None,
        file_info: Vec::new(),
        file_selected: 0,
        file_tree_expanded: HashSet::new(),
        files_error: None,
        service_info,
        service_selected,
        services_loaded: true,
        services_error: None,
        sandbox_info: Vec::new(),
        sandbox_selected: 0,
        sandbox_tree_expanded: std::collections::HashSet::new(),
        sandbox_loaded: false,
        sandbox_error: None,
        selected_optdepends: std::collections::HashMap::new(),
        cascade_mode: CascadeMode::Basic,
        cached_reverse_deps_report: None,
    };
    app
}

#[test]
/// What: Verify `Enter` toggles dependency expansion state within the preflight modal.
///
/// Inputs:
/// - Preflight modal focused on dependencies with an initial collapsed state.
///
/// Output:
/// - First `Enter` expands the target group; second `Enter` collapses it.
///
/// Details:
/// - Uses synthetic key events to mimic user interaction without rendering.
fn handle_enter_toggles_dependency_group() {
    let deps = vec![dep("libfoo", &["target"])];
    let mut app = setup_preflight_app(PreflightTab::Deps, deps, 0, HashSet::new());
    let enter = KeyEvent::new(KeyCode::Enter, KeyModifiers::empty());
    handle_preflight_key(enter, &mut app);
    if let Modal::Preflight {
        dep_tree_expanded, ..
    } = &app.modal
    {
        assert!(dep_tree_expanded.contains("target"));
    } else {
        panic!("expected Preflight modal");
    }
    let enter_again = KeyEvent::new(KeyCode::Enter, KeyModifiers::empty());
    handle_preflight_key(enter_again, &mut app);
    if let Modal::Preflight {
        dep_tree_expanded, ..
    } = &app.modal
    {
        assert!(!dep_tree_expanded.contains("target"));
    } else {
        panic!("expected Preflight modal");
    }
}

#[test]
/// What: Ensure navigation does not move past the last visible dependency row when expanded.
///
/// Inputs:
/// - Preflight modal with expanded dependencies and repeated `Down` key events.
///
/// Output:
/// - Selection stops at the final row instead of wrapping or overshooting.
///
/// Details:
/// - Exercises selection bounds checking for keyboard navigation.
fn handle_down_stops_at_last_visible_dependency_row() {
    let deps = vec![dep("libfoo", &["target"]), dep("libbar", &["target"])];
    let mut expanded = HashSet::new();
    expanded.insert("target".to_string());
    let mut app = setup_preflight_app(PreflightTab::Deps, deps, 0, expanded);
    handle_preflight_key(
        KeyEvent::new(KeyCode::Down, KeyModifiers::empty()),
        &mut app,
    );
    handle_preflight_key(
        KeyEvent::new(KeyCode::Down, KeyModifiers::empty()),
        &mut app,
    );
    handle_preflight_key(
        KeyEvent::new(KeyCode::Down, KeyModifiers::empty()),
        &mut app,
    );
    if let Modal::Preflight { dep_selected, .. } = &app.modal {
        assert_eq!(*dep_selected, 2);
    } else {
        panic!("expected Preflight modal");
    }
}

#[test]
/// What: Confirm spacebar toggles the service restart decision within the Services tab.
///
/// Inputs:
/// - Preflight modal focused on Services with a single restart-ready unit selected.
///
/// Output:
/// - First space press defers the restart; second space press restores the restart decision.
///
/// Details:
/// - Exercises the branch that flips `ServiceRestartDecision` without mutating selection.
fn handle_space_toggles_service_restart_decision() {
    let services = vec![svc("nginx.service", ServiceRestartDecision::Restart)];
    let mut app = setup_preflight_app_with_services(PreflightTab::Services, services, 0);
    handle_preflight_key(
        KeyEvent::new(KeyCode::Char(' '), KeyModifiers::empty()),
        &mut app,
    );
    if let Modal::Preflight { service_info, .. } = &app.modal {
        assert_eq!(
            service_info[0].restart_decision,
            ServiceRestartDecision::Defer
        );
    } else {
        panic!("expected Preflight modal");
    }
    handle_preflight_key(
        KeyEvent::new(KeyCode::Char(' '), KeyModifiers::empty()),
        &mut app,
    );
    if let Modal::Preflight { service_info, .. } = &app.modal {
        assert_eq!(
            service_info[0].restart_decision,
            ServiceRestartDecision::Restart
        );
    } else {
        panic!("expected Preflight modal");
    }
}

#[test]
/// What: Ensure dedicated shortcuts force service restart decisions regardless of current state.
///
/// Inputs:
/// - Services tab with one unit initially set to defer, then the `r` and `Shift+D` bindings.
///
/// Output:
/// - `r` enforces restart, `Shift+D` enforces defer on the focused service.
///
/// Details:
/// - Verifies that direct commands override any prior toggled state for the selected row.
fn handle_service_restart_shortcuts_force_decisions() {
    let services = vec![svc("postgresql.service", ServiceRestartDecision::Defer)];
    let mut app = setup_preflight_app_with_services(PreflightTab::Services, services, 0);
    handle_preflight_key(
        KeyEvent::new(KeyCode::Char('r'), KeyModifiers::empty()),
        &mut app,
    );
    if let Modal::Preflight { service_info, .. } = &app.modal {
        assert_eq!(
            service_info[0].restart_decision,
            ServiceRestartDecision::Restart
        );
    } else {
        panic!("expected Preflight modal");
    }
    handle_preflight_key(
        KeyEvent::new(KeyCode::Char('D'), KeyModifiers::SHIFT),
        &mut app,
    );
    if let Modal::Preflight { service_info, .. } = &app.modal {
        assert_eq!(
            service_info[0].restart_decision,
            ServiceRestartDecision::Defer
        );
    } else {
        panic!("expected Preflight modal");
    }
}

#[test]
/// What: Verify that installed dependencies are correctly included in the dependency list.
///
/// Inputs:
/// - Preflight modal with dependencies including installed ones.
///
/// Output:
/// - All dependencies, including installed ones, are present in `dependency_info`.
///
/// Details:
/// - Tests that installed dependencies are not filtered out and should display with checkmarks.
fn installed_dependencies_are_included_in_list() {
    let installed_dep = dep_with_status(
        "libinstalled",
        &["target"],
        DependencyStatus::Installed {
            version: "1.2.3".into(),
        },
    );
    let to_install_dep = dep("libnew", &["target"]);
    let deps = vec![installed_dep, to_install_dep];
    let app = setup_preflight_app(PreflightTab::Deps, deps, 0, HashSet::new());

    if let Modal::Preflight {
        dependency_info, ..
    } = &app.modal
    {
        assert_eq!(dependency_info.len(), 2);
        // Verify installed dependency is present
        assert!(
            dependency_info.iter().any(|d| d.name == "libinstalled"
                && matches!(d.status, DependencyStatus::Installed { .. }))
        );
        // Verify to-install dependency is present
        assert!(
            dependency_info
                .iter()
                .any(|d| d.name == "libnew" && matches!(d.status, DependencyStatus::ToInstall))
        );
    } else {
        panic!("expected Preflight modal");
    }
}

#[test]
/// What: Verify that cached dependencies are correctly loaded when switching to Deps tab.
///
/// Inputs:
/// - `AppState` with cached dependencies in `install_list_deps`.
/// - Preflight modal initially on Summary tab, then switching to Deps tab.
///
/// Output:
/// - Cached dependencies are loaded into `dependency_info` when switching to Deps tab.
///
/// Details:
/// - Tests the tab switching logic that loads cached dependencies from app state.
fn cached_dependencies_load_on_tab_switch() {
    let mut app = AppState::default();
    let items = vec![pkg("target")];
    let cached_deps = vec![dep("libcached", &["target"])];
    app.install_list_deps = cached_deps;
    app.modal = Modal::Preflight {
        items,
        action: PreflightAction::Install,
        tab: PreflightTab::Summary,
        summary: None,
        summary_scroll: 0,
        header_chips: crate::state::modal::PreflightHeaderChips::default(),
        dependency_info: Vec::new(),
        dep_selected: 0,
        dep_tree_expanded: HashSet::new(),
        deps_error: None,
        file_info: Vec::new(),
        file_selected: 0,
        file_tree_expanded: HashSet::new(),
        files_error: None,
        service_info: Vec::new(),
        service_selected: 0,
        services_loaded: false,
        services_error: None,
        sandbox_info: Vec::new(),
        sandbox_selected: 0,
        sandbox_tree_expanded: std::collections::HashSet::new(),
        sandbox_loaded: false,
        sandbox_error: None,
        selected_optdepends: std::collections::HashMap::new(),
        cascade_mode: CascadeMode::Basic,
        cached_reverse_deps_report: None,
    };

    // Switch to Deps tab
    handle_preflight_key(
        KeyEvent::new(KeyCode::Right, KeyModifiers::empty()),
        &mut app,
    );

    if let Modal::Preflight {
        tab,
        dependency_info,
        ..
    } = &app.modal
    {
        assert_eq!(*tab, PreflightTab::Deps);
        assert_eq!(dependency_info.len(), 1);
        assert_eq!(dependency_info[0].name, "libcached");
    } else {
        panic!("expected Preflight modal");
    }
}

#[test]
/// What: Verify that cached files are correctly loaded when switching to Files tab.
///
/// Inputs:
/// - `AppState` with cached files in `install_list_files`.
/// - Preflight modal initially on Summary tab, then switching to Files tab.
///
/// Output:
/// - Cached files are loaded into `file_info` when switching to Files tab.
///
/// Details:
/// - Tests the tab switching logic that loads cached files from app state.
fn cached_files_load_on_tab_switch() {
    let mut app = AppState::default();
    let items = vec![pkg("target")];
    let cached_files = vec![file_info("target", 3)];
    app.install_list_files = cached_files;
    app.modal = Modal::Preflight {
        items,
        action: PreflightAction::Install,
        tab: PreflightTab::Summary,
        summary: None,
        summary_scroll: 0,
        header_chips: crate::state::modal::PreflightHeaderChips::default(),
        dependency_info: Vec::new(),
        dep_selected: 0,
        dep_tree_expanded: HashSet::new(),
        deps_error: None,
        file_info: Vec::new(),
        file_selected: 0,
        file_tree_expanded: HashSet::new(),
        files_error: None,
        service_info: Vec::new(),
        service_selected: 0,
        services_loaded: false,
        services_error: None,
        sandbox_info: Vec::new(),
        sandbox_selected: 0,
        sandbox_tree_expanded: std::collections::HashSet::new(),
        sandbox_loaded: false,
        sandbox_error: None,
        selected_optdepends: std::collections::HashMap::new(),
        cascade_mode: CascadeMode::Basic,
        cached_reverse_deps_report: None,
    };

    // Switch to Files tab (Right twice: Summary -> Deps -> Files)
    handle_preflight_key(
        KeyEvent::new(KeyCode::Right, KeyModifiers::empty()),
        &mut app,
    );
    handle_preflight_key(
        KeyEvent::new(KeyCode::Right, KeyModifiers::empty()),
        &mut app,
    );

    if let Modal::Preflight { tab, file_info, .. } = &app.modal {
        assert_eq!(*tab, PreflightTab::Files);
        assert_eq!(file_info.len(), 1);
        assert_eq!(file_info[0].name, "target");
        assert_eq!(file_info[0].files.len(), 3);
    } else {
        panic!("expected Preflight modal");
    }
}

#[test]
/// What: Verify that dependencies with Installed status are counted correctly in display length.
///
/// Inputs:
/// - Dependency list containing both installed and to-install dependencies.
///
/// Output:
/// - Display length includes all dependencies regardless of status.
///
/// Details:
/// - Ensures installed dependencies are not excluded from the display count.
fn installed_dependencies_counted_in_display_length() {
    let items = vec![pkg("app")];
    let deps = vec![
        dep_with_status(
            "libinstalled",
            &["app"],
            DependencyStatus::Installed {
                version: "1.0.0".into(),
            },
        ),
        dep("libnew", &["app"]),
    ];
    let mut expanded = HashSet::new();
    expanded.insert("app".to_string());
    let len = compute_display_items_len(&items, &deps, &expanded);
    // Should count: 1 header + 2 dependencies = 3
    assert_eq!(len, 3);
}

#[test]
/// What: Verify that files are correctly displayed when `file_info` is populated.
///
/// Inputs:
/// - Preflight modal with `file_info` containing files for a package.
///
/// Output:
/// - File display length correctly counts files when package is expanded.
///
/// Details:
/// - Ensures files are not filtered out and are correctly counted for display.
fn files_displayed_when_file_info_populated() {
    let items = vec![pkg("pkg1"), pkg("pkg2")];
    let file_infos = vec![file_info("pkg1", 5), file_info("pkg2", 3)];
    let mut expanded = HashSet::new();
    expanded.insert("pkg1".to_string());
    let len = compute_file_display_items_len(&items, &file_infos, &expanded);
    // Should count: 2 headers + 5 files from pkg1 = 7
    assert_eq!(len, 7);

    // Expand both packages
    expanded.insert("pkg2".to_string());
    let len_expanded = compute_file_display_items_len(&items, &file_infos, &expanded);
    // Should count: 2 headers + 5 files + 3 files = 10
    assert_eq!(len_expanded, 10);
}

#[test]
/// What: Verify that empty `file_info` shows correct empty state.
///
/// Inputs:
/// - Preflight modal with empty `file_info` but packages in items.
///
/// Output:
/// - File display length returns 2 (all packages shown even if no file info).
///
/// Details:
/// - Ensures empty states are handled correctly without panicking.
fn empty_file_info_handled_correctly() {
    let items = vec![pkg("pkg1"), pkg("pkg2")];
    let file_infos = Vec::<PackageFileInfo>::new();
    let expanded = HashSet::new();
    let len = compute_file_display_items_len(&items, &file_infos, &expanded);
    // Should count: 2 headers (all packages shown even if no file info)
    assert_eq!(len, 2);
}

#[test]
/// What: Verify that dependencies are correctly filtered by `required_by` when loading from cache.
///
/// Inputs:
/// - `AppState` with cached dependencies, some matching current items and some not.
/// - Preflight modal switching to Deps tab.
///
/// Output:
/// - Only dependencies required by current items are loaded.
///
/// Details:
/// - Tests the filtering logic that ensures only relevant dependencies are shown.
fn dependencies_filtered_by_required_by_on_cache_load() {
    let mut app = AppState::default();
    let items = vec![pkg("target")];
    // Create dependencies: one for "target", one for "other" package
    let deps_for_target = dep("libtarget", &["target"]);
    let deps_for_other = dep("libother", &["other"]);
    app.install_list_deps = vec![deps_for_target, deps_for_other];
    app.modal = Modal::Preflight {
        items,
        action: PreflightAction::Install,
        tab: PreflightTab::Summary,
        summary: None,
        summary_scroll: 0,
        header_chips: crate::state::modal::PreflightHeaderChips::default(),
        dependency_info: Vec::new(),
        dep_selected: 0,
        dep_tree_expanded: HashSet::new(),
        deps_error: None,
        file_info: Vec::new(),
        file_selected: 0,
        file_tree_expanded: HashSet::new(),
        files_error: None,
        service_info: Vec::new(),
        service_selected: 0,
        services_loaded: false,
        services_error: None,
        sandbox_info: Vec::new(),
        sandbox_selected: 0,
        sandbox_tree_expanded: std::collections::HashSet::new(),
        sandbox_loaded: false,
        sandbox_error: None,
        selected_optdepends: std::collections::HashMap::new(),
        cascade_mode: CascadeMode::Basic,
        cached_reverse_deps_report: None,
    };

    // Switch to Deps tab
    handle_preflight_key(
        KeyEvent::new(KeyCode::Right, KeyModifiers::empty()),
        &mut app,
    );

    if let Modal::Preflight {
        dependency_info, ..
    } = &app.modal
    {
        // Should only load dependency for "target", not "other"
        assert_eq!(dependency_info.len(), 1);
        assert_eq!(dependency_info[0].name, "libtarget");
        assert!(
            dependency_info[0]
                .required_by
                .iter()
                .any(|req| req == "target")
        );
    } else {
        panic!("expected Preflight modal");
    }
}

#[test]
/// What: Verify that files are correctly filtered by package name when loading from cache.
///
/// Inputs:
/// - `AppState` with cached files for multiple packages.
/// - Preflight modal with only some packages in items.
///
/// Output:
/// - Only files for packages in items are loaded.
///
/// Details:
/// - Tests the filtering logic that ensures only relevant files are shown.
fn files_filtered_by_package_name_on_cache_load() {
    let mut app = AppState::default();
    let items = vec![pkg("target")];
    let files_for_target = file_info("target", 2);
    let files_for_other = file_info("other", 3);
    app.install_list_files = vec![files_for_target, files_for_other];
    app.modal = Modal::Preflight {
        items,
        action: PreflightAction::Install,
        tab: PreflightTab::Summary,
        summary: None,
        summary_scroll: 0,
        header_chips: crate::state::modal::PreflightHeaderChips::default(),
        dependency_info: Vec::new(),
        dep_selected: 0,
        dep_tree_expanded: HashSet::new(),
        deps_error: None,
        file_info: Vec::new(),
        file_selected: 0,
        file_tree_expanded: HashSet::new(),
        files_error: None,
        service_info: Vec::new(),
        service_selected: 0,
        services_loaded: false,
        services_error: None,
        sandbox_info: Vec::new(),
        sandbox_selected: 0,
        sandbox_tree_expanded: std::collections::HashSet::new(),
        sandbox_loaded: false,
        sandbox_error: None,
        selected_optdepends: std::collections::HashMap::new(),
        cascade_mode: CascadeMode::Basic,
        cached_reverse_deps_report: None,
    };

    // Switch to Files tab
    handle_preflight_key(
        KeyEvent::new(KeyCode::Right, KeyModifiers::empty()),
        &mut app,
    );
    handle_preflight_key(
        KeyEvent::new(KeyCode::Right, KeyModifiers::empty()),
        &mut app,
    );

    if let Modal::Preflight { file_info, .. } = &app.modal {
        // Should only load files for "target", not "other"
        assert_eq!(file_info.len(), 1);
        assert_eq!(file_info[0].name, "target");
        assert_eq!(file_info[0].files.len(), 2);
    } else {
        panic!("expected Preflight modal");
    }
}

// Key Handler Safety Tests
// These tests prevent the TUI from closing unexpectedly when using preflight key handlers

#[test]
/// What: Verify that pressing 'f' for file sync doesn't close the TUI.
///
/// Inputs:
///   - Preflight modal open on Files tab
///   - 'f' key pressed
///
/// Output:
///   - Handler returns `false` (TUI stays open)
///
/// Details:
///   - Verifies the fix for issue where 'f' key closed the TUI
fn test_f_key_file_sync_doesnt_close_tui() {
    let mut app = AppState {
        modal: Modal::Preflight {
            items: vec![pkg("test-package")],
            action: PreflightAction::Install,
            tab: PreflightTab::Files,
            summary: None,
            summary_scroll: 0,
            header_chips: crate::state::modal::PreflightHeaderChips::default(),
            dependency_info: Vec::new(),
            dep_selected: 0,
            dep_tree_expanded: HashSet::new(),
            deps_error: None,
            file_info: Vec::new(),
            file_selected: 0,
            file_tree_expanded: HashSet::new(),
            files_error: None,
            service_info: Vec::new(),
            service_selected: 0,
            services_loaded: false,
            services_error: None,
            sandbox_info: Vec::new(),
            sandbox_selected: 0,
            sandbox_tree_expanded: HashSet::new(),
            sandbox_loaded: false,
            sandbox_error: None,
            selected_optdepends: std::collections::HashMap::new(),
            cascade_mode: CascadeMode::Basic,
            cached_reverse_deps_report: None,
        },
        ..Default::default()
    };

    let key_event = KeyEvent::new(KeyCode::Char('f'), KeyModifiers::empty());
    let should_exit = handle_preflight_key(key_event, &mut app);

    assert!(
        !should_exit,
        "Pressing 'f' for file sync should not close the TUI"
    );
}

#[test]
/// What: Verify that pressing 'p' to proceed with install doesn't close the TUI.
///
/// Inputs:
///   - Preflight modal open with Install action
///   - 'p' key pressed
///
/// Output:
///   - Handler returns `false` (TUI stays open)
///
/// Details:
///   - Verifies the fix for issue where 'p' key closed the TUI
fn test_p_key_proceed_install_doesnt_close_tui() {
    let mut app = AppState {
        modal: Modal::Preflight {
            items: vec![pkg("test-package")],
            action: PreflightAction::Install,
            tab: PreflightTab::Summary,
            summary: None,
            summary_scroll: 0,
            header_chips: crate::state::modal::PreflightHeaderChips::default(),
            dependency_info: Vec::new(),
            dep_selected: 0,
            dep_tree_expanded: HashSet::new(),
            deps_error: None,
            file_info: Vec::new(),
            file_selected: 0,
            file_tree_expanded: HashSet::new(),
            files_error: None,
            service_info: Vec::new(),
            service_selected: 0,
            services_loaded: false,
            services_error: None,
            sandbox_info: Vec::new(),
            sandbox_selected: 0,
            sandbox_tree_expanded: HashSet::new(),
            sandbox_loaded: false,
            sandbox_error: None,
            selected_optdepends: std::collections::HashMap::new(),
            cascade_mode: CascadeMode::Basic,
            cached_reverse_deps_report: None,
        },
        ..Default::default()
    };

    let key_event = KeyEvent::new(KeyCode::Char('p'), KeyModifiers::empty());
    let should_exit = handle_preflight_key(key_event, &mut app);

    assert!(
        !should_exit,
        "Pressing 'p' to proceed should not close the TUI"
    );
}

#[test]
/// What: Verify that pressing 'p' to proceed with remove doesn't close the TUI.
///
/// Inputs:
///   - Preflight modal open with Remove action
///   - 'p' key pressed
///
/// Output:
///   - Handler returns `false` (TUI stays open)
///
/// Details:
///   - Verifies the fix for issue where 'p' key closed the TUI for remove action
fn test_p_key_proceed_remove_doesnt_close_tui() {
    let mut app = AppState {
        modal: Modal::Preflight {
            items: vec![pkg("test-package")],
            action: PreflightAction::Remove,
            tab: PreflightTab::Summary,
            summary: None,
            summary_scroll: 0,
            header_chips: crate::state::modal::PreflightHeaderChips::default(),
            dependency_info: Vec::new(),
            dep_selected: 0,
            dep_tree_expanded: HashSet::new(),
            deps_error: None,
            file_info: Vec::new(),
            file_selected: 0,
            file_tree_expanded: HashSet::new(),
            files_error: None,
            service_info: Vec::new(),
            service_selected: 0,
            services_loaded: false,
            services_error: None,
            sandbox_info: Vec::new(),
            sandbox_selected: 0,
            sandbox_tree_expanded: HashSet::new(),
            sandbox_loaded: false,
            sandbox_error: None,
            selected_optdepends: std::collections::HashMap::new(),
            cascade_mode: CascadeMode::Cascade,
            cached_reverse_deps_report: None, // Allow proceeding without dependency info
        },
        ..Default::default()
    };

    let key_event = KeyEvent::new(KeyCode::Char('p'), KeyModifiers::empty());
    let should_exit = handle_preflight_key(key_event, &mut app);

    assert!(
        !should_exit,
        "Pressing 'p' to proceed with remove should not close the TUI"
    );
}

#[test]
/// What: Verify that pressing 'q' to quit modal doesn't close the TUI.
///
/// Inputs:
///   - Preflight modal open
///   - 'q' key pressed
///
/// Output:
///   - Handler returns `false` (TUI stays open)
///   - Modal is closed but TUI continues
///
/// Details:
///   - Verifies the fix for issue where 'q' key closed the TUI
fn test_q_key_quit_modal_doesnt_close_tui() {
    let mut app = AppState {
        modal: Modal::Preflight {
            items: vec![pkg("test-package")],
            action: PreflightAction::Install,
            tab: PreflightTab::Summary,
            summary: None,
            summary_scroll: 0,
            header_chips: crate::state::modal::PreflightHeaderChips::default(),
            dependency_info: Vec::new(),
            dep_selected: 0,
            dep_tree_expanded: HashSet::new(),
            deps_error: None,
            file_info: Vec::new(),
            file_selected: 0,
            file_tree_expanded: HashSet::new(),
            files_error: None,
            service_info: Vec::new(),
            service_selected: 0,
            services_loaded: false,
            services_error: None,
            sandbox_info: Vec::new(),
            sandbox_selected: 0,
            sandbox_tree_expanded: HashSet::new(),
            sandbox_loaded: false,
            sandbox_error: None,
            selected_optdepends: std::collections::HashMap::new(),
            cascade_mode: CascadeMode::Basic,
            cached_reverse_deps_report: None,
        },
        ..Default::default()
    };

    let key_event = KeyEvent::new(KeyCode::Char('q'), KeyModifiers::empty());
    let should_exit = handle_preflight_key(key_event, &mut app);

    assert!(
        !should_exit,
        "Pressing 'q' to quit modal should not close the TUI"
    );
    assert!(
        matches!(app.modal, Modal::None),
        "Modal should be closed after pressing 'q'"
    );
}

#[test]
/// What: Verify that pressing Esc to close modal doesn't close the TUI.
///
/// Inputs:
///   - Preflight modal open
///   - Esc key pressed
///
/// Output:
///   - Handler returns `false` (TUI stays open)
///   - Modal is closed but TUI continues
///
/// Details:
///   - Verifies the fix for issue where Esc key closed the TUI
fn test_esc_key_close_modal_doesnt_close_tui() {
    let mut app = AppState {
        modal: Modal::Preflight {
            items: vec![pkg("test-package")],
            action: PreflightAction::Install,
            tab: PreflightTab::Summary,
            summary: None,
            summary_scroll: 0,
            header_chips: crate::state::modal::PreflightHeaderChips::default(),
            dependency_info: Vec::new(),
            dep_selected: 0,
            dep_tree_expanded: HashSet::new(),
            deps_error: None,
            file_info: Vec::new(),
            file_selected: 0,
            file_tree_expanded: HashSet::new(),
            files_error: None,
            service_info: Vec::new(),
            service_selected: 0,
            services_loaded: false,
            services_error: None,
            sandbox_info: Vec::new(),
            sandbox_selected: 0,
            sandbox_tree_expanded: HashSet::new(),
            sandbox_loaded: false,
            sandbox_error: None,
            selected_optdepends: std::collections::HashMap::new(),
            cascade_mode: CascadeMode::Basic,
            cached_reverse_deps_report: None,
        },
        ..Default::default()
    };

    let key_event = KeyEvent::new(KeyCode::Esc, KeyModifiers::empty());
    let should_exit = handle_preflight_key(key_event, &mut app);

    assert!(
        !should_exit,
        "Pressing Esc to close modal should not close the TUI"
    );
    assert!(
        matches!(app.modal, Modal::None),
        "Modal should be closed after pressing Esc"
    );
}

#[test]
/// What: Verify that pressing Enter doesn't close the TUI.
///
/// Inputs:
///   - Preflight modal open
///   - Enter key pressed
///
/// Output:
///   - Handler returns `false` (TUI stays open)
///
/// Details:
///   - Verifies the fix for issue where Enter key closed the TUI
fn test_enter_key_doesnt_close_tui() {
    let mut app = AppState {
        modal: Modal::Preflight {
            items: vec![pkg("test-package")],
            action: PreflightAction::Install,
            tab: PreflightTab::Summary,
            summary: None,
            summary_scroll: 0,
            header_chips: crate::state::modal::PreflightHeaderChips::default(),
            dependency_info: Vec::new(),
            dep_selected: 0,
            dep_tree_expanded: HashSet::new(),
            deps_error: None,
            file_info: Vec::new(),
            file_selected: 0,
            file_tree_expanded: HashSet::new(),
            files_error: None,
            service_info: Vec::new(),
            service_selected: 0,
            services_loaded: false,
            services_error: None,
            sandbox_info: Vec::new(),
            sandbox_selected: 0,
            sandbox_tree_expanded: HashSet::new(),
            sandbox_loaded: false,
            sandbox_error: None,
            selected_optdepends: std::collections::HashMap::new(),
            cascade_mode: CascadeMode::Basic,
            cached_reverse_deps_report: None,
        },
        ..Default::default()
    };

    let key_event = KeyEvent::new(KeyCode::Enter, KeyModifiers::empty());
    let should_exit = handle_preflight_key(key_event, &mut app);

    assert!(!should_exit, "Pressing Enter should not close the TUI");
}

#[test]
/// What: Verify that all preflight key handlers return false when modal is open.
///
/// Inputs:
///   - Preflight modal open
///   - Various key handlers called
///
/// Output:
///   - All handlers return `false` (TUI stays open)
///
/// Details:
///   - Comprehensive test to catch any future regressions
///   - Tests multiple key combinations
fn test_all_preflight_keys_return_false() {
    let keys_to_test = vec![
        (KeyCode::Char('f'), "f key"),
        (KeyCode::Char('F'), "F key"),
        (KeyCode::Char('p'), "p key"),
        (KeyCode::Char('P'), "P key"),
        (KeyCode::Char('q'), "q key"),
        (KeyCode::Char('Q'), "Q key"),
        (KeyCode::Char('s'), "s key"),
        (KeyCode::Char('S'), "S key"),
        (KeyCode::Char('c'), "c key"),
        (KeyCode::Char('m'), "m key"),
        (KeyCode::Char('d'), "d key"),
        (KeyCode::Char('?'), "? key"),
        (KeyCode::Esc, "Esc key"),
        (KeyCode::Enter, "Enter key"),
    ];

    for (key_code, key_name) in keys_to_test {
        let mut app = AppState::default();

        // Switch to Files tab for 'f' key test
        let tab = if matches!(key_code, KeyCode::Char('f' | 'F')) {
            PreflightTab::Files
        } else {
            PreflightTab::Summary
        };

        app.modal = Modal::Preflight {
            items: vec![pkg("test-package")],
            action: PreflightAction::Install,
            tab,
            summary: None,
            summary_scroll: 0,
            header_chips: crate::state::modal::PreflightHeaderChips::default(),
            dependency_info: Vec::new(),
            dep_selected: 0,
            dep_tree_expanded: HashSet::new(),
            deps_error: None,
            file_info: Vec::new(),
            file_selected: 0,
            file_tree_expanded: HashSet::new(),
            files_error: None,
            service_info: Vec::new(),
            service_selected: 0,
            services_loaded: false,
            services_error: None,
            sandbox_info: Vec::new(),
            sandbox_selected: 0,
            sandbox_tree_expanded: HashSet::new(),
            sandbox_loaded: false,
            sandbox_error: None,
            selected_optdepends: std::collections::HashMap::new(),
            cascade_mode: CascadeMode::Basic,
            cached_reverse_deps_report: None,
        };

        let key_event = KeyEvent::new(key_code, KeyModifiers::empty());
        let should_exit = handle_preflight_key(key_event, &mut app);

        assert!(
            !should_exit,
            "{key_name} should not close the TUI (returned true, expected false)"
        );
    }
}

#[test]
/// What: Verify that key handlers work correctly when modal is on different tabs.
///
/// Inputs:
///   - Preflight modal open on different tabs
///   - Keys pressed that are tab-specific
///
/// Output:
///   - Handlers return `false` regardless of tab
///
/// Details:
///   - Ensures tab-specific keys don't cause TUI to close
fn test_keys_return_false_on_all_tabs() {
    let tabs = vec![
        PreflightTab::Summary,
        PreflightTab::Deps,
        PreflightTab::Files,
        PreflightTab::Services,
        PreflightTab::Sandbox,
    ];

    for tab in tabs {
        let mut app = AppState {
            modal: Modal::Preflight {
                items: vec![pkg("test-package")],
                action: PreflightAction::Install,
                tab,
                summary: None,
                summary_scroll: 0,
                header_chips: crate::state::modal::PreflightHeaderChips::default(),
                dependency_info: Vec::new(),
                dep_selected: 0,
                dep_tree_expanded: HashSet::new(),
                deps_error: None,
                file_info: Vec::new(),
                file_selected: 0,
                file_tree_expanded: HashSet::new(),
                files_error: None,
                service_info: Vec::new(),
                service_selected: 0,
                services_loaded: false,
                services_error: None,
                sandbox_info: Vec::new(),
                sandbox_selected: 0,
                sandbox_tree_expanded: HashSet::new(),
                sandbox_loaded: false,
                sandbox_error: None,
                selected_optdepends: std::collections::HashMap::new(),
                cascade_mode: CascadeMode::Basic,
                cached_reverse_deps_report: None,
            },
            ..Default::default()
        };

        // Test 'p' key on each tab
        let key_event = KeyEvent::new(KeyCode::Char('p'), KeyModifiers::empty());
        let should_exit = handle_preflight_key(key_event, &mut app);

        assert!(
            !should_exit,
            "Pressing 'p' on {tab:?} tab should not close the TUI"
        );
    }
}