oxur-odm 0.2.0

An odd document manager - CLI tool for managing design documentation
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
//! Replace command - replaces a document while preserving its ID
//!
//! Moves the old document to dustbin/overwritten and installs the new one with the same number

use anyhow::{bail, Context, Result};
use colored::Colorize;
use design::doc::{build_yaml_frontmatter, DesignDoc, DocMetadata, DocState};
use design::filename::slugify;
use design::git;
use design::state::StateManager;
use std::path::PathBuf;
use uuid::Uuid;

/// Execute the replace command
pub fn execute(
    state_mgr: &mut StateManager,
    old_id_or_path: &str,
    new_file_path: &str,
    version_override: Option<String>,
) -> Result<()> {
    println!("{}", "Replacing document...".cyan().bold());
    println!();

    // Step 1: Find old document
    let old_number = state_mgr.resolve_number_or_path(old_id_or_path)?;

    let old_doc = state_mgr
        .state()
        .get(old_number)
        .ok_or_else(|| anyhow::anyhow!("Document {} not found", old_number))?;

    let old_title = old_doc.metadata.title.clone();
    let old_state = old_doc.metadata.state;
    let old_path = state_mgr.docs_dir().join(&old_doc.path);

    println!("{}", "Old Document:".cyan().bold());
    println!("  Number: {}", format!("{:04}", old_number).yellow());
    println!("  Title: {}", old_title.white());
    println!("  State: {}", old_state.as_str().cyan());
    println!();

    // Step 2: Load and validate new document
    let new_path = PathBuf::from(new_file_path);
    if !new_path.exists() {
        bail!("New file not found: {}", new_file_path);
    }

    let new_content = std::fs::read_to_string(&new_path).context("Failed to read new file")?;

    println!("{}", "New Document:".cyan().bold());
    println!("  File: {}", new_path.display().to_string().white());

    // Parse new document (may or may not have frontmatter)
    let new_doc = if new_content.trim_start().starts_with("---") {
        match DesignDoc::parse(&new_content, new_path.clone()) {
            Ok(doc) => doc,
            Err(_) => {
                // Partial/broken frontmatter - extract what we can
                println!("  {} Invalid frontmatter, will merge metadata", "âš ".yellow());
                extract_basic_doc(&new_content, &new_path)?
            }
        }
    } else {
        // No frontmatter
        extract_basic_doc(&new_content, &new_path)?
    };

    // Step 3: Merge metadata (preserve critical fields from old)
    let merged_metadata =
        merge_metadata(&old_doc.metadata, &new_doc.metadata, old_number, version_override)?;

    println!();
    println!("{}", "Merged Metadata:".cyan().bold());
    println!("  ✓ Preserved number: {}", format!("{:04}", merged_metadata.number).yellow());
    println!("  ✓ Preserved created: {}", merged_metadata.created.to_string().green());
    println!("  ✓ New title: {}", merged_metadata.title.white());
    println!("  ✓ New author: {}", merged_metadata.author.white());
    println!(
        "  {} Version: {} -> {}",
        "→".cyan(),
        old_doc.metadata.version,
        merged_metadata.version
    );
    println!();

    // Step 4: Move old document to dustbin as "overwritten"
    let dustbin_dir = state_mgr.docs_dir().join(".dustbin/overwritten");
    std::fs::create_dir_all(&dustbin_dir).context("Failed to create dustbin directory")?;

    let uuid = Uuid::new_v4();
    let uuid_short = uuid.to_string().split('-').next().unwrap().to_string();

    let old_filename = old_path.file_name().context("Invalid old file path")?.to_string_lossy();
    let new_dustbin_name = format!("{}-{}", old_filename.trim_end_matches(".md"), uuid_short);
    let dustbin_path = dustbin_dir.join(format!("{}.md", new_dustbin_name));

    println!("{}", "Moving old version to dustbin...".cyan().bold());

    if old_path.exists() {
        git::git_mv(&old_path, &dustbin_path).context("Failed to move old file to dustbin")?;
        println!("  ✓ Moved to: {}", dustbin_path.display().to_string().green());

        // Update old document's frontmatter to mark as overwritten
        if let Ok(content) = std::fs::read_to_string(&dustbin_path) {
            if let Ok(mut doc) = DesignDoc::parse(&content, dustbin_path.clone()) {
                doc.metadata.state = DocState::Overwritten;
                doc.metadata.updated = chrono::Local::now().naive_local().date();
                let updated_content = build_yaml_frontmatter(&doc.metadata) + &doc.content;
                std::fs::write(&dustbin_path, updated_content).ok();
            }
        }
    }

    // Update state tracking for old document
    state_mgr.record_file_move(&old_path, &dustbin_path)?;

    // Step 5: Install new document
    println!();
    println!("{}", "Installing new version...".cyan().bold());

    // Generate new filename based on old document's number
    let new_filename = format!("{:04}-{}.md", old_number, slugify(&merged_metadata.title));

    // Place in draft directory initially
    let new_dir = state_mgr.docs_dir().join("01-draft");
    std::fs::create_dir_all(&new_dir)?;
    let new_location = new_dir.join(&new_filename);

    // Create content with merged frontmatter
    let new_content_with_frontmatter =
        format!("{}\n{}", build_yaml_frontmatter(&merged_metadata), new_doc.content.trim());

    std::fs::write(&new_location, new_content_with_frontmatter)
        .context("Failed to write new document")?;
    println!("  ✓ Created: {}", new_location.display().to_string().green());

    // Stage with git
    git::git_add(&new_location).context("Failed to stage new file")?;
    println!("  ✓ Staged with git");

    // Update state tracking for new document
    state_mgr.record_file_change(&new_location)?;
    println!("  ✓ Updated state tracking");

    // Update the index to reflect the replacement
    println!();
    let index = design::index::DocumentIndex::from_state(state_mgr.state(), state_mgr.docs_dir())
        .context("Failed to create index")?;
    if let Err(e) = crate::commands::update_index::update_index(&index) {
        println!("{} Failed to update index", "Warning:".yellow());
        println!("  {}", e);
        println!("  Run 'odm update-index' manually to sync the index");
    }

    println!();
    println!("{}", "Document replaced successfully!".green().bold());
    println!("  Old version: {}", dustbin_path.display().to_string().yellow());
    println!("  New version: {}", new_location.display().to_string().green());
    println!();
    println!("To view: {}", format!("odm show {}", old_number).yellow());

    Ok(())
}

/// Extract basic document info when frontmatter is missing or invalid
fn extract_basic_doc(content: &str, path: &PathBuf) -> Result<DesignDoc> {
    let title = design::doc::extract_title_from_content(
        content,
        path.file_name().and_then(|n| n.to_str()).unwrap_or("untitled.md"),
    );

    let author = git::get_author(path);
    let created = chrono::Local::now().naive_local().date();
    let updated = created;

    Ok(DesignDoc {
        metadata: DocMetadata {
            number: 0, // Will be overridden
            title,
            author,
            component: None,
            tags: Vec::new(),
            created,
            updated,
            state: DocState::Draft,
            supersedes: None,
            superseded_by: None,
            version: "1.0".to_string(),
        },
        content: content.to_string(),
        path: path.clone(),
    })
}

/// Merge metadata from old and new documents
fn merge_metadata(
    old_meta: &DocMetadata,
    new_meta: &DocMetadata,
    preserve_number: u32,
    version_override: Option<String>,
) -> Result<DocMetadata> {
    // Always preserve from old document
    let number = preserve_number;
    let created = old_meta.created;

    // Use new document's values if present, otherwise fall back to old
    let title = if !new_meta.title.is_empty() && new_meta.title != "Untitled Document" {
        new_meta.title.clone()
    } else {
        old_meta.title.clone()
    };

    let author = if !new_meta.author.is_empty() && new_meta.author != "Unknown Author" {
        new_meta.author.clone()
    } else {
        old_meta.author.clone()
    };

    let updated = chrono::Local::now().naive_local().date();

    // For optional fields, prefer new but keep old if new is missing
    let supersedes = new_meta.supersedes.or(old_meta.supersedes);
    let superseded_by = new_meta.superseded_by.or(old_meta.superseded_by);

    // Determine new version
    let version = if let Some(override_ver) = version_override {
        // User provided explicit version - validate it's >= old version
        if let Ok(is_valid) =
            design::doc::is_version_valid_upgrade(&old_meta.version, &override_ver)
        {
            if !is_valid {
                return Err(anyhow::anyhow!(
                    "Version downgrade not allowed: {} -> {}. New version must be >= old version.",
                    old_meta.version,
                    override_ver
                ));
            }
            override_ver
        } else {
            // Override version is invalid format
            return Err(anyhow::anyhow!(
                "Invalid version format: '{}'. Expected 'major.minor' (e.g., '1.0', '2.3')",
                override_ver
            ));
        }
    } else {
        // Auto-increment minor version from old document
        match design::doc::increment_minor_version(&old_meta.version) {
            Ok(new_ver) => new_ver,
            Err(_) => {
                // Old version was invalid, default to 1.1 per user requirements
                println!(
                    "{} Old version '{}' is invalid, defaulting to 1.1",
                    "WARNING:".yellow().bold(),
                    old_meta.version
                );
                "1.1".to_string()
            }
        }
    };

    Ok(DocMetadata {
        number,
        title,
        author,
        component: new_meta.component.clone().or_else(|| old_meta.component.clone()),
        tags: if new_meta.tags.is_empty() { old_meta.tags.clone() } else { new_meta.tags.clone() },
        created,
        updated,
        state: DocState::Draft, // New version always starts as draft
        supersedes,
        superseded_by,
        version,
    })
}

#[cfg(test)]
mod tests {
    use super::*;
    use chrono::NaiveDate;
    use design::state::DocumentRecord;
    use serial_test::serial;
    use std::fs;
    use tempfile::TempDir;

    /// RAII guard to ensure current directory is restored after test
    struct DirGuard {
        original: std::path::PathBuf,
    }

    impl DirGuard {
        fn new() -> Self {
            Self { original: std::env::current_dir().expect("Failed to get current dir") }
        }

        fn change_to(&self, path: &std::path::Path) {
            std::env::set_current_dir(path).expect("Failed to change dir");
        }
    }

    impl Drop for DirGuard {
        fn drop(&mut self) {
            let _ = std::env::set_current_dir(&self.original);
        }
    }

    fn setup_git_repo(temp_dir: &std::path::Path) {
        use std::process::Command;
        Command::new("git").args(["init"]).current_dir(temp_dir).output().ok();
        Command::new("git")
            .args(["config", "user.name", "Test"])
            .current_dir(temp_dir)
            .output()
            .ok();
        Command::new("git")
            .args(["config", "user.email", "test@example.com"])
            .current_dir(temp_dir)
            .output()
            .ok();
    }

    fn create_test_doc(temp: &TempDir, num: u32, title: &str, with_frontmatter: bool) -> PathBuf {
        let content = if with_frontmatter {
            format!(
                "---\nnumber: {}\ntitle: \"{}\"\nauthor: \"Test Author\"\ncreated: 2024-01-01\nupdated: 2024-01-01\nstate: Draft\nsupersedes: null\nsuperseded-by: null\n---\n\nTest content",
                num, title
            )
        } else {
            format!("# {}\n\nTest content without frontmatter", title)
        };

        let path = temp.path().join(format!("new-doc-{}.md", num));
        fs::write(&path, content).unwrap();
        path
    }

    fn create_test_state_manager(temp: &TempDir) -> StateManager {
        let docs_dir = temp.path().join("docs");
        fs::create_dir_all(&docs_dir).unwrap();
        setup_git_repo(temp.path());

        let mut state_mgr = StateManager::new(&docs_dir).unwrap();

        // Add test document
        let meta = DocMetadata {
            number: 1,
            title: "Old Doc".to_string(),
            author: "Old Author".to_string(),
            component: None,
            tags: Vec::new(),
            created: NaiveDate::from_ymd_opt(2024, 1, 1).unwrap(),
            updated: NaiveDate::from_ymd_opt(2024, 1, 1).unwrap(),
            state: DocState::Active,
            supersedes: None,
            superseded_by: None,
            version: "1.0".to_string(),
        };

        let doc_path = docs_dir.join("05-active/0001-old-doc.md");
        fs::create_dir_all(doc_path.parent().unwrap()).unwrap();
        let content = format!(
            "---\n{}\n---\n\nOld content",
            serde_yaml::to_string(&meta).unwrap().trim_start_matches("---\n")
        );
        fs::write(&doc_path, content).unwrap();

        std::process::Command::new("git")
            .args(["add", "."])
            .current_dir(temp.path())
            .output()
            .unwrap();
        std::process::Command::new("git")
            .args(["commit", "-m", "Initial"])
            .current_dir(temp.path())
            .output()
            .unwrap();

        state_mgr.state_mut().upsert(
            1,
            DocumentRecord {
                metadata: meta,
                path: "05-active/0001-old-doc.md".to_string(),
                checksum: "abc123".to_string(),
                file_size: 100,
                modified: chrono::Utc::now(),
            },
        );

        state_mgr
    }

    #[test]
    #[serial]
    fn test_replace_by_number() {
        let temp = TempDir::new().unwrap();
        let _guard = DirGuard::new();
        _guard.change_to(temp.path());

        let mut state_mgr = create_test_state_manager(&temp);
        let new_doc = create_test_doc(&temp, 2, "New Doc", true);

        let result = execute(&mut state_mgr, "1", new_doc.to_str().unwrap(), None);
        assert!(result.is_ok());
    }

    #[test]
    #[serial]
    fn test_replace_by_path() {
        let temp = TempDir::new().unwrap();
        let _guard = DirGuard::new();
        _guard.change_to(temp.path());

        let mut state_mgr = create_test_state_manager(&temp);
        let new_doc = create_test_doc(&temp, 2, "New Doc", true);

        let result = execute(&mut state_mgr, "old-doc", new_doc.to_str().unwrap(), None);
        assert!(result.is_ok());
    }

    #[test]
    fn test_replace_old_not_found() {
        let temp = TempDir::new().unwrap();
        let mut state_mgr = create_test_state_manager(&temp);
        let new_doc = create_test_doc(&temp, 2, "New Doc", true);

        let result = execute(&mut state_mgr, "999", new_doc.to_str().unwrap(), None);
        assert!(result.is_err());
        assert!(result.unwrap_err().to_string().contains("not found"));
    }

    #[test]
    fn test_replace_new_file_not_found() {
        let temp = TempDir::new().unwrap();
        let mut state_mgr = create_test_state_manager(&temp);

        let result = execute(&mut state_mgr, "1", "/nonexistent/file.md", None);
        assert!(result.is_err());
        assert!(result.unwrap_err().to_string().contains("not found"));
    }

    #[test]
    #[serial]
    fn test_replace_without_frontmatter() {
        let temp = TempDir::new().unwrap();
        let _guard = DirGuard::new();
        _guard.change_to(temp.path());

        let mut state_mgr = create_test_state_manager(&temp);
        let new_doc = create_test_doc(&temp, 2, "New Doc", false);

        let result = execute(&mut state_mgr, "1", new_doc.to_str().unwrap(), None);
        assert!(result.is_ok());
    }

    #[test]
    #[serial]
    fn test_replace_preserves_number_and_created() {
        let temp = TempDir::new().unwrap();
        let _guard = DirGuard::new();
        _guard.change_to(temp.path());

        let mut state_mgr = create_test_state_manager(&temp);
        let old_doc = state_mgr.state().get(1).unwrap();
        let old_created = old_doc.metadata.created;

        let new_doc = create_test_doc(&temp, 2, "New Doc", true);
        execute(&mut state_mgr, "1", new_doc.to_str().unwrap(), None).unwrap();

        let updated_doc = state_mgr.state().get(1).unwrap();
        assert_eq!(updated_doc.metadata.number, 1);
        assert_eq!(updated_doc.metadata.created, old_created);
        assert_eq!(updated_doc.metadata.title, "New Doc");
    }

    #[test]
    #[serial]
    fn test_replace_creates_dustbin_overwritten() {
        let temp = TempDir::new().unwrap();
        let _guard = DirGuard::new();
        _guard.change_to(temp.path());

        let mut state_mgr = create_test_state_manager(&temp);
        let new_doc = create_test_doc(&temp, 2, "New Doc", true);

        execute(&mut state_mgr, "1", new_doc.to_str().unwrap(), None).unwrap();

        let dustbin = temp.path().join("docs/.dustbin/overwritten");
        assert!(dustbin.exists());
        let files: Vec<_> = fs::read_dir(&dustbin).unwrap().collect();
        assert_eq!(files.len(), 1);
    }

    #[test]
    #[serial]
    fn test_replace_new_doc_in_draft() {
        let temp = TempDir::new().unwrap();
        let _guard = DirGuard::new();
        _guard.change_to(temp.path());

        let mut state_mgr = create_test_state_manager(&temp);
        let new_doc = create_test_doc(&temp, 2, "New Doc", true);

        execute(&mut state_mgr, "1", new_doc.to_str().unwrap(), None).unwrap();

        let draft_dir = temp.path().join("docs/01-draft");
        assert!(draft_dir.exists());
        let new_file = draft_dir.join("0001-new-doc.md");
        assert!(new_file.exists());
    }

    #[test]
    fn test_merge_metadata_preserves_number() {
        let old_meta = DocMetadata {
            number: 42,
            title: "Old".to_string(),
            author: "Old Author".to_string(),
            component: None,
            tags: Vec::new(),
            created: NaiveDate::from_ymd_opt(2024, 1, 1).unwrap(),
            updated: NaiveDate::from_ymd_opt(2024, 1, 1).unwrap(),
            state: DocState::Active,
            supersedes: Some(10),
            superseded_by: None,
            version: "1.0".to_string(),
        };

        let new_meta = DocMetadata {
            number: 999,
            title: "New".to_string(),
            author: "New Author".to_string(),
            component: None,
            tags: Vec::new(),
            created: NaiveDate::from_ymd_opt(2024, 2, 1).unwrap(),
            updated: NaiveDate::from_ymd_opt(2024, 2, 1).unwrap(),
            state: DocState::Draft,
            supersedes: None,
            superseded_by: Some(50),
            version: "1.0".to_string(),
        };

        let merged = merge_metadata(&old_meta, &new_meta, 42, None).unwrap();

        assert_eq!(merged.number, 42);
        assert_eq!(merged.created, old_meta.created);
        assert_eq!(merged.title, "New");
        assert_eq!(merged.author, "New Author");
        assert_eq!(merged.state, DocState::Draft);
        assert_eq!(merged.version, "1.1"); // Auto-incremented from 1.0
    }

    #[test]
    fn test_merge_metadata_falls_back_to_old() {
        let old_meta = DocMetadata {
            number: 42,
            title: "Old".to_string(),
            author: "Old Author".to_string(),
            component: None,
            tags: Vec::new(),
            created: NaiveDate::from_ymd_opt(2024, 1, 1).unwrap(),
            updated: NaiveDate::from_ymd_opt(2024, 1, 1).unwrap(),
            state: DocState::Active,
            supersedes: None,
            superseded_by: None,
            version: "1.0".to_string(),
        };

        let new_meta = DocMetadata {
            number: 999,
            title: "Untitled Document".to_string(),
            author: "Unknown Author".to_string(),
            component: None,
            tags: Vec::new(),
            created: NaiveDate::from_ymd_opt(2024, 2, 1).unwrap(),
            updated: NaiveDate::from_ymd_opt(2024, 2, 1).unwrap(),
            state: DocState::Draft,
            supersedes: None,
            superseded_by: None,
            version: "1.0".to_string(),
        };

        let merged = merge_metadata(&old_meta, &new_meta, 42, None).unwrap();

        assert_eq!(merged.title, "Old");
        assert_eq!(merged.author, "Old Author");
    }

    #[test]
    fn test_replace_auto_increments_minor_version() {
        let old_meta = DocMetadata {
            number: 1,
            title: "Test".to_string(),
            author: "Author".to_string(),
            component: None,
            tags: Vec::new(),
            created: NaiveDate::from_ymd_opt(2024, 1, 1).unwrap(),
            updated: NaiveDate::from_ymd_opt(2024, 1, 1).unwrap(),
            state: DocState::Active,
            supersedes: None,
            superseded_by: None,
            version: "1.0".to_string(),
        };

        let new_meta = DocMetadata {
            number: 999,
            title: "Updated".to_string(),
            author: "Author".to_string(),
            component: None,
            tags: Vec::new(),
            created: NaiveDate::from_ymd_opt(2024, 2, 1).unwrap(),
            updated: NaiveDate::from_ymd_opt(2024, 2, 1).unwrap(),
            state: DocState::Draft,
            supersedes: None,
            superseded_by: None,
            version: "1.0".to_string(),
        };

        let merged = merge_metadata(&old_meta, &new_meta, 1, None).unwrap();
        assert_eq!(merged.version, "1.1");
    }

    #[test]
    fn test_replace_with_explicit_version() {
        let old_meta = DocMetadata {
            number: 1,
            title: "Test".to_string(),
            author: "Author".to_string(),
            component: None,
            tags: Vec::new(),
            created: NaiveDate::from_ymd_opt(2024, 1, 1).unwrap(),
            updated: NaiveDate::from_ymd_opt(2024, 1, 1).unwrap(),
            state: DocState::Active,
            supersedes: None,
            superseded_by: None,
            version: "1.0".to_string(),
        };

        let new_meta = DocMetadata {
            number: 999,
            title: "Updated".to_string(),
            author: "Author".to_string(),
            component: None,
            tags: Vec::new(),
            created: NaiveDate::from_ymd_opt(2024, 2, 1).unwrap(),
            updated: NaiveDate::from_ymd_opt(2024, 2, 1).unwrap(),
            state: DocState::Draft,
            supersedes: None,
            superseded_by: None,
            version: "1.0".to_string(),
        };

        let merged = merge_metadata(&old_meta, &new_meta, 1, Some("2.0".to_string())).unwrap();
        assert_eq!(merged.version, "2.0");
    }

    #[test]
    fn test_replace_prevents_version_downgrade() {
        let old_meta = DocMetadata {
            number: 1,
            title: "Test".to_string(),
            author: "Author".to_string(),
            component: None,
            tags: Vec::new(),
            created: NaiveDate::from_ymd_opt(2024, 1, 1).unwrap(),
            updated: NaiveDate::from_ymd_opt(2024, 1, 1).unwrap(),
            state: DocState::Active,
            supersedes: None,
            superseded_by: None,
            version: "2.0".to_string(),
        };

        let new_meta = DocMetadata {
            number: 999,
            title: "Updated".to_string(),
            author: "Author".to_string(),
            component: None,
            tags: Vec::new(),
            created: NaiveDate::from_ymd_opt(2024, 2, 1).unwrap(),
            updated: NaiveDate::from_ymd_opt(2024, 2, 1).unwrap(),
            state: DocState::Draft,
            supersedes: None,
            superseded_by: None,
            version: "1.0".to_string(),
        };

        let result = merge_metadata(&old_meta, &new_meta, 1, Some("1.0".to_string()));
        assert!(result.is_err());
        assert!(result.unwrap_err().to_string().contains("Version downgrade not allowed"));
    }

    #[test]
    fn test_replace_invalid_old_version_defaults_to_1_1() {
        let old_meta = DocMetadata {
            number: 1,
            title: "Test".to_string(),
            author: "Author".to_string(),
            component: None,
            tags: Vec::new(),
            created: NaiveDate::from_ymd_opt(2024, 1, 1).unwrap(),
            updated: NaiveDate::from_ymd_opt(2024, 1, 1).unwrap(),
            state: DocState::Active,
            supersedes: None,
            superseded_by: None,
            version: "bad-version".to_string(),
        };

        let new_meta = DocMetadata {
            number: 999,
            title: "Updated".to_string(),
            author: "Author".to_string(),
            component: None,
            tags: Vec::new(),
            created: NaiveDate::from_ymd_opt(2024, 2, 1).unwrap(),
            updated: NaiveDate::from_ymd_opt(2024, 2, 1).unwrap(),
            state: DocState::Draft,
            supersedes: None,
            superseded_by: None,
            version: "1.0".to_string(),
        };

        let merged = merge_metadata(&old_meta, &new_meta, 1, None).unwrap();
        assert_eq!(merged.version, "1.1");
    }
}