oxo-flow-cli 0.22.0

CLI for the oxo-flow bioinformatics pipeline engine
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
//! Extract per-key descriptions from `#` comments in a workflow's `[config]`
//! section.
//!
//! The engine's TOML parser discards comments, so `info` re-reads the raw
//! file text and associates comment lines with the `[config]` keys they
//! describe. The association rules are deliberately simple and were validated
//! against the oxo-community staging workflows:
//!
//! - a contiguous block of `#` lines immediately above a key line (no blank
//!   line in between) is that key's description;
//! - a trailing `#` comment on the key line itself is the fallback;
//! - a BLOCK description also describes the group it heads: bare keys that
//!   follow on consecutive lines inherit it (workflows write one comment
//!   block above a group of related params, e.g. "Binning options" above a
//!   dozen keys — live: mag/ampliseq). Trailing comments never propagate
//!   (they are key-specific), and a blank line or new section ends the
//!   group;
//! - comments inside multi-line values or outside `[config]` never associate;
//! - comments above `[config.<name>]` subtable headers describe the table key.
//!
//! Known limitation: bracket tracking covers `[...]`/`{...}` but not
//! triple-quoted `"""..."""` values — a blank line or `#`-prefixed line
//! INSIDE a `[config]` multi-line string can sever a group or seed the next
//! key's description. Rare in practice (multi-line `[config]` strings are
//! uncommon); descriptions are prose, never a correctness matter.

use std::collections::BTreeMap;

/// Extract `[config]` key descriptions from raw workflow text.
///
/// Description lines keep the author's line structure (joined with
/// newlines); empty `#` lines and pure decorator lines (`# ----`) are dropped.
pub fn extract_config_descriptions(text: &str) -> BTreeMap<String, String> {
    let mut descriptions: BTreeMap<String, String> = BTreeMap::new();
    let mut section: Option<String> = None;
    let mut pending: Vec<String> = Vec::new();
    let mut value_depth = 0usize;
    // Group propagation state: the most recent BLOCK description and
    // whether the previous significant line was a key (a group continues
    // over consecutive key lines only).
    let mut last_block_desc: Option<String> = None;
    let mut last_line_was_key = false;

    for line in text.lines() {
        let line = line.trim();

        // Inside a multi-line value: only track bracket balance. This runs
        // before header parsing so value lines like `["x"]` are never taken
        // for section headers. Comment lines here describe array elements,
        // not the parameter.
        if section.as_deref() == Some("config") && value_depth > 0 {
            value_depth = bracket_balance(line, value_depth);
            continue;
        }

        // `[name]`, `[name.sub]`, `[[name]]` — any header leaves `[config]`.
        if let Some(header) = section_header(line) {
            let is_config = header == "config";
            let is_subtable = header.starts_with("config.");
            section = Some(header.clone());
            // `[config.<name>]`: pending comments describe the table key.
            if is_subtable {
                attach(&mut descriptions, &mut pending, &header["config.".len()..]);
            }
            if !is_config && !is_subtable {
                pending.clear();
            }
            value_depth = 0;
            last_block_desc = None;
            last_line_was_key = false;
            continue;
        }
        if section.as_deref() != Some("config") {
            continue;
        }

        if let Some(comment) = comment_text(line) {
            // Empty `#` lines and pure decorator lines carry no meaning.
            if !comment.is_empty() && !is_decorator(&comment) {
                pending.push(comment);
            }
            last_line_was_key = false;
            continue;
        }

        if line.is_empty() {
            // A blank line severs the comment block from any following key.
            pending.clear();
            last_block_desc = None;
            last_line_was_key = false;
            continue;
        }

        let Some((key, value)) = key_line(line) else {
            continue;
        };
        value_depth = open_bracket_depth(value);
        if pending.is_empty() {
            if let Some(trailing) = trailing_comment(value) {
                descriptions.insert(key, trailing);
                last_block_desc = None;
            } else if last_line_was_key && let Some(desc) = last_block_desc.clone() {
                // Bare key directly under a block-described key: part of the
                // same group, inherits the group's description.
                descriptions.insert(key, desc);
            } else {
                last_block_desc = None;
            }
        } else {
            attach(&mut descriptions, &mut pending, &key);
            last_block_desc = descriptions.get(&key).cloned();
        }
        last_line_was_key = true;
    }
    descriptions
}

/// `[name]`, `[name.sub]`, `[[name]]` → header name (any trailing comment
/// stripped); other lines → `None`.
fn section_header(line: &str) -> Option<String> {
    let trimmed = line.trim();
    if !trimmed.starts_with('[') {
        return None;
    }
    let inner = trimmed.trim_start_matches('[');
    let inner = inner.strip_prefix('[').unwrap_or(inner);
    let end = inner.find(']')?;
    let name = inner[..end].trim();
    let rest = inner[end + 1..].trim_start();
    let closes = if rest.starts_with(']') { 1 } else { 0 };
    if closes == 0 && !rest.is_empty() && !rest.starts_with('#') {
        return None;
    }
    (!name.is_empty()).then(|| name.to_string())
}

/// `# comment` → `comment` (leading `#` and one space stripped, trimmed);
/// non-comment lines → `None`.
fn comment_text(line: &str) -> Option<String> {
    let trimmed = line.trim();
    if !trimmed.starts_with('#') {
        return None;
    }
    let body = trimmed.trim_start_matches('#').trim();
    Some(body.to_string())
}

/// Pure decorator lines (`# ----`, `# ====`) carry no meaning.
fn is_decorator(text: &str) -> bool {
    !text.is_empty() && text.chars().all(|c| c == '-' || c == '=')
}

/// `key = value` → `(key, value-after-=)` for bare TOML keys; `None` for
/// other lines. Value lines inside `[...]` arrays are handled by the caller.
fn key_line(line: &str) -> Option<(String, &str)> {
    let eq = line.find('=')?;
    let key = line[..eq].trim();
    if key.is_empty()
        || !key
            .chars()
            .all(|c| c.is_ascii_alphanumeric() || c == '_' || c == '-')
    {
        return None;
    }
    Some((key.to_string(), line[eq + 1..].trim()))
}

/// Bracket depth opened by a value line (`known_indels = [` → 1, balanced
/// arrays/strings → 0). Quote-aware so `"["` inside strings does not count.
fn open_bracket_depth(value: &str) -> usize {
    bracket_balance(value, 0)
}

/// New bracket depth after scanning `text`, starting from `depth` (which the
/// caller guarantees is > 0 when scanning continuation lines).
fn bracket_balance(text: &str, mut depth: usize) -> usize {
    let mut in_string: Option<char> = None;
    let mut escaped = false;
    for c in text.chars() {
        match in_string {
            Some(quote) => {
                if escaped {
                    escaped = false;
                } else if c == '\\' {
                    escaped = true;
                } else if c == quote {
                    in_string = None;
                }
            }
            None => match c {
                '"' | '\'' => in_string = Some(c),
                '[' => depth += 1,
                ']' => depth = depth.saturating_sub(1),
                _ => {}
            },
        }
    }
    depth
}

/// Trailing `# comment` outside quotes, with non-whitespace content;
/// `None` when the line has no trailing comment (e.g. `key = "#FF0000"`).
fn trailing_comment(value: &str) -> Option<String> {
    let mut in_string: Option<char> = None;
    let mut escaped = false;
    for (idx, c) in value.char_indices() {
        match in_string {
            Some(quote) => {
                if escaped {
                    escaped = false;
                } else if c == '\\' {
                    escaped = true;
                } else if c == quote {
                    in_string = None;
                }
            }
            None => match c {
                '"' | '\'' => in_string = Some(c),
                '#' => {
                    let comment = value[idx + 1..].trim();
                    return (!comment.is_empty()).then(|| comment.to_string());
                }
                _ => {}
            },
        }
    }
    None
}

/// Join pending comment lines into a description for `key`.
fn attach(descriptions: &mut BTreeMap<String, String>, pending: &mut Vec<String>, key: &str) {
    if let Some(description) = join(pending) {
        descriptions.insert(key.to_string(), description);
    }
    pending.clear();
}

/// `--- Banner line ---` (starts and ends with 3+ dashes).
fn is_banner(line: &str) -> bool {
    let trimmed = line.trim();
    trimmed.len() >= 6 && trimmed.starts_with("---") && trimmed.ends_with("---")
}

/// `--- MultiQC ---` → `MultiQC`.
fn strip_banner_dashes(line: &str) -> String {
    line.trim()
        .trim_start_matches('-')
        .trim()
        .trim_end_matches('-')
        .trim()
        .to_string()
}

/// Join comment lines with single spaces; `None` when nothing meaningful.
/// Banner lines (`--- section ---`) act as section markers: when the block
/// also has regular text they are dropped; a lone banner keeps its interior.
fn join(lines: &[String]) -> Option<String> {
    let kept: Vec<String> = if lines.iter().any(|line| !is_banner(line)) {
        lines
            .iter()
            .filter(|line| !is_banner(line))
            .cloned()
            .collect()
    } else {
        lines.iter().map(|line| strip_banner_dashes(line)).collect()
    };
    // Keep the author's line structure: a multi-line comment block is
    // prose (a reference_dir layout list, a stage walk-through), and a
    // single-run paragraph is unreadable in sites that render the
    // description (live: circrna reference_dir read as one run-on line).
    let description = kept.join("\n");
    if description.is_empty() {
        None
    } else {
        Some(description)
    }
}

#[cfg(test)]
mod tests {
    use super::*;

    #[test]
    fn single_comment_line_above_key_becomes_description() {
        let text = "[config]\n# Output directory.\nout_dir = \"results\"\n";
        assert_eq!(
            extract_config_descriptions(text),
            BTreeMap::from([("out_dir".to_string(), "Output directory.".to_string())])
        );
    }

    #[test]
    fn multi_line_block_keeps_structure_and_skips_empty_lines() {
        // A blank # line is skipped (no leading/inner blank), the author's
        // line structure survives so prose layouts render readably (live:
        // circrna's reference_dir layout comment folded to one run-on line
        // when joined with spaces).
        let text = "[config]\n# Optional: pre-trained classifier\n#\n# for the 16S region.\nclassifier = \"\"\n";
        assert_eq!(
            extract_config_descriptions(text),
            BTreeMap::from([(
                "classifier".to_string(),
                "Optional: pre-trained classifier\nfor the 16S region.".to_string()
            )])
        );
    }

    #[test]
    fn prose_layout_stays_multiline() {
        let text = "[config]\n# reference_dir/ layout: genome.fa, genes.gtf\n# star/ index, bowtie2/ index.\nreference_dir = \"./reference\"\n";
        assert_eq!(
            extract_config_descriptions(text),
            BTreeMap::from([(
                "reference_dir".to_string(),
                "reference_dir/ layout: genome.fa, genes.gtf\nstar/ index, bowtie2/ index."
                    .to_string()
            )])
        );
    }

    #[test]
    fn trailing_comment_is_fallback_when_no_block_above() {
        let text = "[config]\nsave_output_as_bam = false # CRAM output mode\n";
        assert_eq!(
            extract_config_descriptions(text),
            BTreeMap::from([(
                "save_output_as_bam".to_string(),
                "CRAM output mode".to_string()
            )])
        );
    }

    #[test]
    fn preceding_block_wins_over_trailing_comment() {
        let text = "[config]\n# Block comment.\nkey = 1 # trailing comment\n";
        assert_eq!(
            extract_config_descriptions(text),
            BTreeMap::from([("key".to_string(), "Block comment.".to_string())])
        );
    }

    #[test]
    fn hash_inside_quoted_value_is_not_a_trailing_comment() {
        let text = "[config]\ncolor = \"#FF0000\"\n";
        assert_eq!(extract_config_descriptions(text), BTreeMap::new());
    }

    #[test]
    fn blank_line_severs_comment_block_from_key() {
        // The comment reads as a section note, not a key description.
        let text = "[config]\n# Section-level note.\n\nrmats_cstat = 0.0001\n";
        assert_eq!(extract_config_descriptions(text), BTreeMap::new());
    }

    #[test]
    fn group_block_propagates_to_consecutive_bare_keys() {
        // One block above a group of related params describes them all
        // (live: mag "Binning options" above a dozen keys).
        let text = "[config]\n# Clipping (upstream params with the same defaults)\nclip_tool = \"fastp\"\nreads_minlength = 15\nfastp_qualified_quality = 15\n\n# Next group.\nnext = 1\n";
        let desc = "Clipping (upstream params with the same defaults)";
        assert_eq!(
            extract_config_descriptions(text),
            BTreeMap::from([
                ("clip_tool".to_string(), desc.to_string()),
                ("reads_minlength".to_string(), desc.to_string()),
                ("fastp_qualified_quality".to_string(), desc.to_string()),
                ("next".to_string(), "Next group.".to_string()),
            ])
        );
    }

    #[test]
    fn trailing_comment_does_not_propagate_to_next_key() {
        // Trailing comments are key-specific — a bare key after them
        // inherits nothing (live: save_align_intermeds' trailing note
        // must not leak onto out_dir).
        let text =
            "[config]\nsave_align_intermeds = true   # --create-bam flag\nout_dir = \"results\"\n";
        assert_eq!(
            extract_config_descriptions(text),
            BTreeMap::from([(
                "save_align_intermeds".to_string(),
                "--create-bam flag".to_string()
            )])
        );
    }

    #[test]
    fn blank_line_ends_group_propagation() {
        let text = "[config]\n# Group note.\na = 1\nb = 2\n\nc = 3\n";
        assert_eq!(
            extract_config_descriptions(text),
            BTreeMap::from([
                ("a".to_string(), "Group note.".to_string()),
                ("b".to_string(), "Group note.".to_string()),
            ])
        );
    }

    #[test]
    fn comments_inside_multiline_arrays_do_not_associate() {
        let text = "[config]\n# Known indels.\nknown_indels = [\n  # chr1\n  \"/a.vcf.gz\",\n  \"/b.vcf.gz\",\n]\n# Next key.\nnext_key = 1\n";
        assert_eq!(
            extract_config_descriptions(text),
            BTreeMap::from([
                ("known_indels".to_string(), "Known indels.".to_string()),
                ("next_key".to_string(), "Next key.".to_string()),
            ])
        );
    }

    #[test]
    fn bracket_inside_quoted_array_element_does_not_break_balance() {
        let text =
            "[config]\n# Paired brackets.\nkeys = [\n  \"a[b]\",\n]\n# After array.\nafter = 1\n";
        assert_eq!(
            extract_config_descriptions(text),
            BTreeMap::from([
                ("keys".to_string(), "Paired brackets.".to_string()),
                ("after".to_string(), "After array.".to_string()),
            ])
        );
    }

    #[test]
    fn comments_outside_config_section_are_ignored() {
        let text = "# Workflow-level note.\n[workflow]\nname = \"wf\"\n\n[config]\nkey = 1\n\n[[rules]]\n# Rule shell note — not a config description.\nname = \"align\"\n";
        assert_eq!(extract_config_descriptions(text), BTreeMap::new());
    }

    #[test]
    fn dangling_block_before_next_section_header_is_discarded() {
        // Mirrors gallery 06: a comment block above [[sample_groups]].
        let text = "[config]\nreference = \"/ref/genome.fa\"\n\n# Sample cohort for {sample} expansion.\n[[sample_groups]]\nname = \"cohort\"\n";
        assert_eq!(extract_config_descriptions(text), BTreeMap::new());
    }

    #[test]
    fn subtable_header_takes_pending_comments_for_table_key() {
        let text = "[config]\n# Alignment settings.\n[config.align]\nthreads = 4\n";
        assert_eq!(
            extract_config_descriptions(text),
            BTreeMap::from([("align".to_string(), "Alignment settings.".to_string())])
        );
    }

    #[test]
    fn decorator_lines_are_filtered_from_descriptions() {
        let text = "[config]\n# ----\n# Meaningful text.\n# ----\nkey = 1\n";
        assert_eq!(
            extract_config_descriptions(text),
            BTreeMap::from([("key".to_string(), "Meaningful text.".to_string())])
        );
    }

    #[test]
    fn comments_above_config_header_do_not_attach_to_first_key() {
        // Only comments INSIDE `[config]` associate.
        let text = "# User configuration.\n[config]\nkey = 1\n";
        assert_eq!(extract_config_descriptions(text), BTreeMap::new());
    }

    #[test]
    fn lone_banner_line_keeps_interior_text_without_dashes() {
        // `--- MultiQC ---` is a section marker; the interior names the
        // group the key belongs to.
        let text = "[config]\n# --- MultiQC ---\nmultiqc_title = \"\"\n";
        assert_eq!(
            extract_config_descriptions(text),
            BTreeMap::from([("multiqc_title".to_string(), "MultiQC".to_string())])
        );
    }

    #[test]
    fn banner_line_is_dropped_when_block_has_regular_text() {
        // Section marker + description: keep the description only.
        let text = "[config]\n# --- Input reads (upstream samplesheet) ---\n# Directory holding raw files.\nraw_dir = \"raw\"\n";
        assert_eq!(
            extract_config_descriptions(text),
            BTreeMap::from([(
                "raw_dir".to_string(),
                "Directory holding raw files.".to_string()
            )])
        );
    }

    #[test]
    fn array_element_line_that_looks_like_a_header_is_not_one() {
        // `["x"]` as the last array element (no trailing comma) must not be
        // parsed as a section header while inside the multi-line value.
        let text = "[config]\n# Nested arrays.\nkeys = [\n  [\"x\"]\n]\n# After.\nafter = 1\n";
        assert_eq!(
            extract_config_descriptions(text),
            BTreeMap::from([
                ("keys".to_string(), "Nested arrays.".to_string()),
                ("after".to_string(), "After.".to_string()),
            ])
        );
    }
}