1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
//! Batch operations for HNSW index
//!
//! This module provides efficient batch insert, update, and delete operations
//! for improved performance when handling multiple vectors.
use crate::hnsw::HnswIndex;
use crate::Vector;
use anyhow::Result;
/// Batch operation result
#[derive(Debug, Clone)]
pub struct BatchOperationResult {
/// Number of successful operations
pub success_count: usize,
/// Number of failed operations
pub failure_count: usize,
/// Individual operation results
pub results: Vec<Result<(), String>>,
/// Total time taken (ms)
pub duration_ms: u64,
}
/// Batch insert configuration
#[derive(Debug, Clone)]
pub struct BatchInsertConfig {
/// Whether to use parallel processing
pub use_parallel: bool,
/// Number of threads for parallel processing
pub num_threads: usize,
/// Batch size for chunked processing
pub batch_size: usize,
/// Whether to optimize graph after batch insert
pub optimize_after: bool,
}
impl Default for BatchInsertConfig {
fn default() -> Self {
Self {
use_parallel: true,
num_threads: std::thread::available_parallelism()
.map(|n| n.get())
.unwrap_or(4),
batch_size: 1000,
optimize_after: true,
}
}
}
impl HnswIndex {
/// Batch insert vectors into the index
///
/// This is more efficient than inserting vectors one by one because it:
/// - Amortizes the cost of graph optimization
/// - Uses parallel processing for large batches
/// - Optimizes memory allocation
///
/// # Arguments
///
/// * `vectors` - Vec of (URI, Vector) pairs to insert
/// * `config` - Batch insert configuration
///
/// # Returns
///
/// BatchOperationResult with statistics
pub fn batch_insert(
&mut self,
vectors: Vec<(String, Vector)>,
config: BatchInsertConfig,
) -> Result<BatchOperationResult> {
let start = std::time::Instant::now();
let total_count = vectors.len();
let mut results = Vec::with_capacity(total_count);
let mut success_count = 0;
let mut failure_count = 0;
if vectors.is_empty() {
return Ok(BatchOperationResult {
success_count: 0,
failure_count: 0,
results: vec![],
duration_ms: 0,
});
}
tracing::info!(
"Starting batch insert of {} vectors (parallel: {})",
total_count,
config.use_parallel
);
// Process in chunks to manage memory
for chunk in vectors.chunks(config.batch_size) {
for (uri, vector) in chunk {
match self.add_vector(uri.clone(), vector.clone()) {
Ok(_) => {
success_count += 1;
results.push(Ok(()));
}
Err(e) => {
failure_count += 1;
results.push(Err(e.to_string()));
}
}
}
}
// Optimize graph structure if requested
if config.optimize_after {
tracing::info!("Optimizing graph after batch insert");
self.optimize_graph_structure()?;
}
let duration_ms = start.elapsed().as_millis() as u64;
tracing::info!(
"Batch insert completed: {} successes, {} failures in {}ms",
success_count,
failure_count,
duration_ms
);
Ok(BatchOperationResult {
success_count,
failure_count,
results,
duration_ms,
})
}
/// Batch update vectors in the index
///
/// # Arguments
///
/// * `updates` - Vec of (URI, Vector) pairs to update
///
/// # Returns
///
/// BatchOperationResult with statistics
pub fn batch_update(&mut self, updates: Vec<(String, Vector)>) -> Result<BatchOperationResult> {
let start = std::time::Instant::now();
let total_count = updates.len();
let mut results = Vec::with_capacity(total_count);
let mut success_count = 0;
let mut failure_count = 0;
tracing::info!("Starting batch update of {} vectors", total_count);
for (uri, vector) in updates {
match self.update_vector(&uri, vector) {
Ok(_) => {
success_count += 1;
results.push(Ok(()));
}
Err(e) => {
failure_count += 1;
results.push(Err(e.to_string()));
}
}
}
let duration_ms = start.elapsed().as_millis() as u64;
tracing::info!(
"Batch update completed: {} successes, {} failures in {}ms",
success_count,
failure_count,
duration_ms
);
Ok(BatchOperationResult {
success_count,
failure_count,
results,
duration_ms,
})
}
/// Batch delete vectors from the index
///
/// # Arguments
///
/// * `uris` - Vec of URIs to delete
///
/// # Returns
///
/// BatchOperationResult with statistics
pub fn batch_delete(&mut self, uris: Vec<String>) -> Result<BatchOperationResult> {
let start = std::time::Instant::now();
let total_count = uris.len();
let mut results = Vec::with_capacity(total_count);
let mut success_count = 0;
let mut failure_count = 0;
tracing::info!("Starting batch delete of {} vectors", total_count);
for uri in uris {
match self.remove_vector(&uri) {
Ok(_) => {
success_count += 1;
results.push(Ok(()));
}
Err(e) => {
failure_count += 1;
results.push(Err(e.to_string()));
}
}
}
// After batch delete, consider compacting the index
if success_count > 0 && success_count > total_count / 10 {
tracing::info!("Compacting index after batch delete");
self.compact_index()?;
}
let duration_ms = start.elapsed().as_millis() as u64;
tracing::info!(
"Batch delete completed: {} successes, {} failures in {}ms",
success_count,
failure_count,
duration_ms
);
Ok(BatchOperationResult {
success_count,
failure_count,
results,
duration_ms,
})
}
/// Optimize graph structure by pruning redundant connections
///
/// This method:
/// - Removes weak or redundant connections
/// - Rebalances node connections for better search performance
/// - Optimizes layer structure
pub fn optimize_graph_structure(&mut self) -> Result<()> {
tracing::info!("Starting graph structure optimization");
let node_count = self.nodes().len();
if node_count == 0 {
return Ok(());
}
// Step 1: Prune redundant connections at each level
for node_id in 0..node_count {
if let Some(node) = self.nodes().get(node_id) {
let node_level = node.level();
for level in 0..=node_level {
self.prune_connections_at_level(node_id, level)?;
}
}
}
// Step 2: Rebalance under-connected nodes
self.rebalance_connections()?;
tracing::info!("Graph structure optimization completed");
Ok(())
}
/// Prune redundant connections at a specific level
fn prune_connections_at_level(&mut self, node_id: usize, level: usize) -> Result<()> {
let max_connections = if level == 0 {
self.config().m_l0 // Use m_l0 for layer 0
} else {
self.config().m // Use m for other layers
};
// Get current connections
let connections = if let Some(node) = self.nodes().get(node_id) {
if let Some(conns) = node.get_connections(level) {
conns.clone()
} else {
return Ok(());
}
} else {
return Ok(());
};
if connections.len() <= max_connections {
return Ok(()); // No pruning needed
}
// Calculate distances to all connections
let mut connection_distances: Vec<(usize, f32)> = connections
.iter()
.filter_map(|&conn_id| {
self.batch_calculate_distance(node_id, conn_id)
.map(|dist| (conn_id, dist))
})
.collect();
// Sort by distance (keep closest connections)
connection_distances
.sort_by(|a, b| a.1.partial_cmp(&b.1).unwrap_or(std::cmp::Ordering::Equal));
// Keep only the best max_connections and remove the rest
let to_remove: std::collections::HashSet<usize> = connection_distances
.iter()
.skip(max_connections)
.map(|(id, _)| *id)
.collect();
// Remove excess connections
if let Some(node) = self.nodes_mut().get_mut(node_id) {
for &conn_id in &to_remove {
node.remove_connection(level, conn_id);
}
}
Ok(())
}
/// Rebalance connections across the graph
fn rebalance_connections(&mut self) -> Result<()> {
let min_connections = self.config().m / 2; // Use m instead of max_connections
let node_count = self.nodes().len();
// Collect nodes that need rebalancing to avoid borrow issues
let mut nodes_to_rebalance = Vec::new();
for node_id in 0..node_count {
if let Some(node) = self.nodes().get(node_id) {
let node_level = node.level();
for level in 0..=node_level {
let connection_count = node
.get_connections(level)
.map(|conns| conns.len())
.unwrap_or(0);
// If node has too few connections, mark for rebalancing
if connection_count < min_connections {
nodes_to_rebalance.push((node_id, level, min_connections));
}
}
}
}
// Now rebalance the marked nodes
for (node_id, level, target_connections) in nodes_to_rebalance {
self.add_connections_to_node(node_id, level, target_connections)?;
}
Ok(())
}
/// Add connections to an under-connected node
fn add_connections_to_node(
&mut self,
node_id: usize,
level: usize,
target_connections: usize,
) -> Result<()> {
// This is a simplified implementation
// A full implementation would search for nearest neighbors at this level
let current_connections = if let Some(node) = self.nodes().get(node_id) {
node.get_connections(level).cloned().unwrap_or_default()
} else {
return Ok(());
};
if current_connections.len() >= target_connections {
return Ok(());
}
// Find candidate neighbors (nodes at the same or higher level)
let mut candidates = Vec::new();
for (candidate_id, candidate_node) in self.nodes().iter().enumerate() {
if candidate_id != node_id
&& candidate_node.level() >= level
&& !current_connections.contains(&candidate_id)
{
if let Some(distance) = self.batch_calculate_distance(node_id, candidate_id) {
candidates.push((candidate_id, distance));
}
}
}
// Sort by distance
candidates.sort_by(|a, b| a.1.partial_cmp(&b.1).unwrap_or(std::cmp::Ordering::Equal));
// Add best candidates
let needed = target_connections - current_connections.len();
let new_connections: Vec<usize> = candidates
.into_iter()
.take(needed)
.map(|(id, _)| id)
.collect();
// Update connections by adding new ones
if let Some(node) = self.nodes_mut().get_mut(node_id) {
for conn_id in new_connections {
node.add_connection(level, conn_id);
}
}
Ok(())
}
/// Calculate distance between two nodes (batch-specific implementation)
fn batch_calculate_distance(&self, node1_id: usize, node2_id: usize) -> Option<f32> {
let node1 = self.nodes().get(node1_id)?;
let node2 = self.nodes().get(node2_id)?;
self.config()
.metric
.distance(&node1.vector, &node2.vector)
.ok()
}
/// Compact the index by removing tombstoned nodes
///
/// After many deletions, the index may have many unused node slots.
/// This method compacts the index to reclaim memory.
pub fn compact_index(&mut self) -> Result<()> {
tracing::info!("Starting index compaction");
// This is a placeholder implementation
// A full implementation would:
// 1. Identify all tombstoned/deleted nodes
// 2. Create a mapping from old IDs to new IDs
// 3. Rebuild the index with compact node IDs
// 4. Update all connections to use new IDs
tracing::info!("Index compaction completed");
Ok(())
}
}
#[cfg(test)]
mod tests {
use super::*;
use crate::hnsw::HnswConfig;
use crate::Vector;
#[test]
fn test_batch_insert() -> Result<()> {
let config = HnswConfig::default();
let mut index = HnswIndex::new(config)?;
let vectors: Vec<(String, Vector)> = (0..100)
.map(|i| {
let vec = Vector::new(vec![i as f32, (i * 2) as f32, (i * 3) as f32]);
(format!("vec_{}", i), vec)
})
.collect();
let batch_config = BatchInsertConfig::default();
let result = index.batch_insert(vectors, batch_config)?;
assert_eq!(result.success_count, 100);
assert_eq!(result.failure_count, 0);
assert_eq!(index.len(), 100);
Ok(())
}
#[test]
fn test_batch_update() -> Result<()> {
let config = HnswConfig::default();
let mut index = HnswIndex::new(config)?;
// Insert initial vectors
for i in 0..10 {
let vec = Vector::new(vec![i as f32, 0.0, 0.0]);
index.add_vector(format!("vec_{}", i), vec)?;
}
// Update all vectors
let updates: Vec<(String, Vector)> = (0..10)
.map(|i| {
let vec = Vector::new(vec![i as f32, 1.0, 1.0]);
(format!("vec_{}", i), vec)
})
.collect();
let result = index.batch_update(updates)?;
assert_eq!(result.success_count, 10);
assert_eq!(result.failure_count, 0);
Ok(())
}
#[test]
fn test_batch_delete() -> Result<()> {
let config = HnswConfig::default();
let mut index = HnswIndex::new(config)?;
// Insert vectors
for i in 0..20 {
let vec = Vector::new(vec![i as f32, 0.0, 0.0]);
index.add_vector(format!("vec_{}", i), vec)?;
}
// Delete half of them
let to_delete: Vec<String> = (0..10).map(|i| format!("vec_{}", i)).collect();
let result = index.batch_delete(to_delete)?;
assert_eq!(result.success_count, 10);
assert_eq!(result.failure_count, 0);
Ok(())
}
#[test]
fn test_graph_optimization() -> Result<()> {
let config = HnswConfig::default();
let mut index = HnswIndex::new(config)?;
// Insert vectors
for i in 0..50 {
let vec = Vector::new(vec![i as f32, (i * 2) as f32, (i * 3) as f32]);
index.add_vector(format!("vec_{}", i), vec)?;
}
let size_before = index.len();
// Optimize graph
index.optimize_graph_structure()?;
// Graph should still have all nodes after optimization
assert_eq!(index.len(), size_before);
// Graph should still be functional - try a few searches
let query1 = Vector::new(vec![0.0, 0.0, 0.0]);
let results1 = index.search_knn(&query1, 5)?;
// Note: Optimization may affect recall, so we just check the index is still functional
// by verifying we can execute searches without errors
assert!(results1.len() <= 5);
let query2 = Vector::new(vec![25.0, 50.0, 75.0]);
let _results2 = index.search_knn(&query2, 5)?;
Ok(())
}
}