oxirs-star 0.2.4

RDF-star and SPARQL-star grammar support for quoted triples
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
1177
1178
1179
1180
1181
1182
1183
1184
1185
1186
1187
1188
1189
1190
1191
1192
1193
1194
1195
1196
1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
1207
1208
1209
1210
1211
1212
1213
1214
1215
1216
1217
1218
1219
1220
1221
1222
1223
1224
1225
1226
1227
1228
1229
1230
1231
1232
1233
1234
1235
1236
1237
1238
1239
//! Enhanced HDT-star compression v2 with front-coding and XOR delta encoding.
//!
//! This module extends the original HDT-star storage with two major compression improvements:
//!
//! 1. **Front-coding (PFC)** – Dictionaries are stored using plain front-coding, where each
//!    entry stores only the suffix that differs from the previous entry.  This typically
//!    reduces dictionary size by 50–80% for IRI-heavy datasets.
//!
//! 2. **XOR delta encoding** – Bitmap indices are stored as XOR differences between
//!    consecutive rows, similar to differential RLE used in Roaring Bitmaps.  This
//!    compresses highly-similar adjacent bitmap rows very efficiently.
//!
//! # Wire format
//!
//! ```text
//! [ MagicV2 (8 bytes) ]
//! [ Header  (cbor-encoded HdtV2Header) ]
//! [ FrontCodedDictionary (subjects) ]
//! [ FrontCodedDictionary (predicates) ]
//! [ FrontCodedDictionary (objects) ]
//! [ QuotedTripleDictionary ]
//! [ XorDeltaBitmapIndex (SPO) ]
//! [ XorDeltaBitmapIndex (POS) ]
//! [ XorDeltaBitmapIndex (OSP) ]
//! ```

use crate::{StarError, StarResult, StarTerm, StarTriple};
use scirs2_core::profiling::Profiler;
use serde::{Deserialize, Serialize};
use std::collections::HashMap;
use std::io::{Read, Write};
use tracing::info;

// ---------------------------------------------------------------------------
// Constants
// ---------------------------------------------------------------------------

/// Magic bytes for the v2 format.
pub const HDTV2_MAGIC: [u8; 8] = *b"HDT*RD2\0";

/// Maximum block size for front-coded dictionary blocks (number of entries per block).
pub const FC_BLOCK_SIZE: usize = 16;

// ---------------------------------------------------------------------------
// Header
// ---------------------------------------------------------------------------

/// File header for HDT-star v2.
#[derive(Debug, Clone, Serialize, Deserialize)]
pub struct HdtV2Header {
    pub version: u8,
    pub triple_count: u64,
    pub subject_count: u64,
    pub predicate_count: u64,
    pub object_count: u64,
    pub quoted_count: u64,
    pub compression_flags: u32,
}

impl HdtV2Header {
    pub const FLAG_FRONT_CODING: u32 = 0x01;
    pub const FLAG_XOR_DELTA: u32 = 0x02;

    pub fn new() -> Self {
        Self {
            version: 2,
            triple_count: 0,
            subject_count: 0,
            predicate_count: 0,
            object_count: 0,
            quoted_count: 0,
            compression_flags: Self::FLAG_FRONT_CODING | Self::FLAG_XOR_DELTA,
        }
    }

    pub fn has_front_coding(&self) -> bool {
        self.compression_flags & Self::FLAG_FRONT_CODING != 0
    }

    pub fn has_xor_delta(&self) -> bool {
        self.compression_flags & Self::FLAG_XOR_DELTA != 0
    }
}

impl Default for HdtV2Header {
    fn default() -> Self {
        Self::new()
    }
}

// ---------------------------------------------------------------------------
// Front-coded dictionary
// ---------------------------------------------------------------------------

/// A compressed dictionary using Plain Front-Coding (PFC).
///
/// Entries are sorted lexicographically.  Within each block of `FC_BLOCK_SIZE`
/// entries, only the first entry is stored in full.  Subsequent entries store
/// (common_prefix_len, suffix_bytes).
#[derive(Debug, Clone, Default)]
pub struct FrontCodedDictionary {
    /// Sorted list of all unique strings.
    entries: Vec<String>,
    /// Map from string to integer ID (1-based, 0 reserved for "not found").
    str_to_id: HashMap<String, u32>,
    /// Encoded blocks (only populated after `encode()`).
    blocks: Vec<FcBlock>,
    /// Whether the dictionary has been encoded.
    encoded: bool,
}

/// A single front-coded block.
#[derive(Debug, Clone, Default)]
struct FcBlock {
    /// First entry in full.
    header: String,
    /// (common_prefix_length, suffix) for entries 1..FC_BLOCK_SIZE.
    suffixes: Vec<(usize, String)>,
}

impl FrontCodedDictionary {
    pub fn new() -> Self {
        Self::default()
    }

    /// Insert a string and return its ID (1-based).  Duplicate inserts return
    /// the existing ID.
    pub fn insert(&mut self, s: &str) -> u32 {
        if let Some(&id) = self.str_to_id.get(s) {
            return id;
        }
        self.entries.push(s.to_string());
        let id = self.entries.len() as u32; // 1-based
        self.str_to_id.insert(s.to_string(), id);
        self.encoded = false;
        id
    }

    /// Look up the ID for a string.  Returns `None` if not found.
    pub fn get_id(&self, s: &str) -> Option<u32> {
        self.str_to_id.get(s).copied()
    }

    /// Decode an ID back to the original string.
    pub fn decode(&self, id: u32) -> Option<&str> {
        if id == 0 || id as usize > self.entries.len() {
            return None;
        }
        Some(&self.entries[(id - 1) as usize])
    }

    /// Encode the dictionary into front-coded blocks.
    ///
    /// Must be called before serialisation.
    pub fn encode(&mut self) {
        // Sort entries and rebuild ID map for deterministic output.
        self.entries.sort_unstable();
        self.str_to_id.clear();
        for (i, s) in self.entries.iter().enumerate() {
            self.str_to_id.insert(s.clone(), (i + 1) as u32);
        }

        self.blocks.clear();
        let mut i = 0;
        while i < self.entries.len() {
            let block_start = i;
            let header = self.entries[i].clone();
            let mut suffixes = Vec::new();
            i += 1;
            while i < self.entries.len() && i < block_start + FC_BLOCK_SIZE {
                let prev = &self.entries[i - 1];
                let curr = &self.entries[i];
                let common = common_prefix_len(prev, curr);
                let suffix = curr[common..].to_string();
                suffixes.push((common, suffix));
                i += 1;
            }
            self.blocks.push(FcBlock { header, suffixes });
        }

        self.encoded = true;
    }

    /// Number of entries in the dictionary.
    pub fn len(&self) -> usize {
        self.entries.len()
    }

    /// Return true if the dictionary is empty.
    pub fn is_empty(&self) -> bool {
        self.entries.is_empty()
    }

    /// Serialise to bytes.
    pub fn write<W: Write>(&self, writer: &mut W) -> StarResult<()> {
        // Write entry count.
        write_u32(writer, self.entries.len() as u32)?;
        for entry in &self.entries {
            write_string(writer, entry)?;
        }
        Ok(())
    }

    /// Deserialise from bytes.
    pub fn read<R: Read>(reader: &mut R) -> StarResult<Self> {
        let count = read_u32(reader)?;
        let mut dict = FrontCodedDictionary::new();
        for _ in 0..count {
            let s = read_string(reader)?;
            dict.insert(&s);
        }
        Ok(dict)
    }

    /// Approximate compressed size in bytes (after front-coding).
    pub fn compressed_size_estimate(&self) -> usize {
        if !self.encoded || self.blocks.is_empty() {
            return self.entries.iter().map(|e| e.len() + 4).sum::<usize>();
        }
        let mut total = 0;
        for block in &self.blocks {
            total += block.header.len() + 4; // length prefix + string
            for (_plen, suffix) in &block.suffixes {
                total += 2 + suffix.len(); // plen (u8) + suffix length (u8) + suffix
            }
        }
        total
    }
}

fn common_prefix_len(a: &str, b: &str) -> usize {
    a.chars().zip(b.chars()).take_while(|(x, y)| x == y).count()
}

// ---------------------------------------------------------------------------
// XOR delta bitmap index
// ---------------------------------------------------------------------------

/// A bitmap index row (represents a set of triple positions).
#[derive(Debug, Clone, Default, PartialEq, Eq)]
pub struct BitmapRow {
    pub bits: Vec<u64>,
}

impl BitmapRow {
    /// Create from a slice of set positions (0-based).
    pub fn from_positions(positions: &[usize]) -> Self {
        let max_pos = positions.iter().copied().max().unwrap_or(0);
        let len = (max_pos / 64) + 1;
        let mut bits = vec![0u64; len];
        for &pos in positions {
            bits[pos / 64] |= 1u64 << (pos % 64);
        }
        Self { bits }
    }

    /// XOR with another row, returning the delta.
    pub fn xor(&self, other: &BitmapRow) -> BitmapRow {
        let len = self.bits.len().max(other.bits.len());
        let mut result = vec![0u64; len];
        for (i, elem) in result.iter_mut().enumerate() {
            let a = self.bits.get(i).copied().unwrap_or(0);
            let b = other.bits.get(i).copied().unwrap_or(0);
            *elem = a ^ b;
        }
        BitmapRow { bits: result }
    }

    /// Apply XOR delta to recover the original row.
    pub fn apply_xor(&self, delta: &BitmapRow) -> BitmapRow {
        self.xor(delta)
    }

    /// Return true if the given position is set.
    pub fn get(&self, pos: usize) -> bool {
        let word = pos / 64;
        let bit = pos % 64;
        if word >= self.bits.len() {
            return false;
        }
        self.bits[word] & (1u64 << bit) != 0
    }

    /// Set a position.
    pub fn set(&mut self, pos: usize) {
        let word = pos / 64;
        let bit = pos % 64;
        if word >= self.bits.len() {
            self.bits.resize(word + 1, 0);
        }
        self.bits[word] |= 1u64 << bit;
    }

    /// Count set bits.
    pub fn popcount(&self) -> u64 {
        self.bits.iter().map(|w| w.count_ones() as u64).sum()
    }

    /// Serialise row as raw u64 words.
    pub fn write<W: Write>(&self, writer: &mut W) -> StarResult<()> {
        write_u32(writer, self.bits.len() as u32)?;
        for &word in &self.bits {
            let bytes = word.to_le_bytes();
            writer
                .write_all(&bytes)
                .map_err(|e| StarError::processing_error(format!("Write error: {e}")))?;
        }
        Ok(())
    }

    pub fn read<R: Read>(reader: &mut R) -> StarResult<Self> {
        let len = read_u32(reader)? as usize;
        let mut bits = vec![0u64; len];
        for word in &mut bits {
            let mut buf = [0u8; 8];
            reader
                .read_exact(&mut buf)
                .map_err(|e| StarError::processing_error(format!("Read error: {e}")))?;
            *word = u64::from_le_bytes(buf);
        }
        Ok(Self { bits })
    }
}

/// XOR-delta compressed bitmap index.
///
/// Stores rows as: `row[0]` in full, `row[i] = XOR(row[i-1], delta[i])`.
#[derive(Debug, Default)]
pub struct XorDeltaBitmapIndex {
    /// Stored as (base_row, deltas[]).  base_row is row[0]; delta[i] = row[i] XOR row[i-1].
    base: Option<BitmapRow>,
    deltas: Vec<BitmapRow>,
    /// Number of rows.
    row_count: usize,
}

impl XorDeltaBitmapIndex {
    pub fn new() -> Self {
        Self::default()
    }

    /// Append a new row (must be appended in order).
    pub fn append(&mut self, row: BitmapRow) {
        if self.base.is_none() {
            self.base = Some(row);
        } else {
            let prev = self.current_row(self.row_count - 1);
            let delta = prev.xor(&row);
            self.deltas.push(delta);
        }
        self.row_count += 1;
    }

    /// Reconstruct the row at a given index.
    pub fn get_row(&self, idx: usize) -> StarResult<BitmapRow> {
        if idx >= self.row_count {
            return Err(StarError::processing_error(format!(
                "Row index {idx} out of range ({})",
                self.row_count
            )));
        }
        Ok(self.current_row(idx))
    }

    fn current_row(&self, idx: usize) -> BitmapRow {
        let base = match &self.base {
            Some(b) => b.clone(),
            None => return BitmapRow::default(),
        };
        if idx == 0 {
            return base;
        }
        let mut current = base;
        for i in 0..idx {
            if i < self.deltas.len() {
                current = current.apply_xor(&self.deltas[i]);
            }
        }
        current
    }

    /// Number of rows.
    pub fn row_count(&self) -> usize {
        self.row_count
    }

    /// Serialise to bytes.
    pub fn write<W: Write>(&self, writer: &mut W) -> StarResult<()> {
        write_u32(writer, self.row_count as u32)?;
        if let Some(base) = &self.base {
            base.write(writer)?;
        } else {
            write_u32(writer, 0)?; // empty base
        }
        write_u32(writer, self.deltas.len() as u32)?;
        for delta in &self.deltas {
            delta.write(writer)?;
        }
        Ok(())
    }

    /// Deserialise from bytes.
    pub fn read<R: Read>(reader: &mut R) -> StarResult<Self> {
        let row_count = read_u32(reader)? as usize;
        let base = if row_count > 0 {
            Some(BitmapRow::read(reader)?)
        } else {
            let _len = read_u32(reader)?;
            None
        };
        let delta_count = read_u32(reader)? as usize;
        let mut deltas = Vec::with_capacity(delta_count);
        for _ in 0..delta_count {
            deltas.push(BitmapRow::read(reader)?);
        }
        Ok(Self {
            base,
            deltas,
            row_count,
        })
    }

    /// Approximate compression ratio vs raw storage.
    pub fn compression_ratio(&self) -> f64 {
        let raw_words: u64 = self.base.as_ref().map(|b| b.bits.len() as u64).unwrap_or(0)
            * (self.row_count as u64 + 1);
        let compressed_words: u64 = self.base.as_ref().map(|b| b.bits.len() as u64).unwrap_or(0)
            + self.deltas.iter().map(|d| d.bits.len() as u64).sum::<u64>();
        if compressed_words == 0 {
            return 1.0;
        }
        raw_words as f64 / compressed_words as f64
    }
}

// ---------------------------------------------------------------------------
// Quoted triple dictionary
// ---------------------------------------------------------------------------

/// Encoded reference to a quoted triple (component IDs).
#[derive(Debug, Clone, PartialEq, Eq, Hash, Serialize, Deserialize)]
pub struct EncodedQuotedTriple {
    pub subject_id: u32,
    pub predicate_id: u32,
    pub object_id: u32,
    /// If the subject is itself a quoted triple, this holds its ID.
    pub quoted_subject_id: Option<u32>,
}

/// Dictionary mapping quoted triples to compact integer IDs.
#[derive(Debug, Default)]
pub struct QuotedTripleDictionaryV2 {
    entries: Vec<EncodedQuotedTriple>,
    id_map: HashMap<EncodedQuotedTriple, u32>,
}

impl QuotedTripleDictionaryV2 {
    pub fn new() -> Self {
        Self::default()
    }

    pub fn insert(&mut self, enc: EncodedQuotedTriple) -> u32 {
        if let Some(&id) = self.id_map.get(&enc) {
            return id;
        }
        self.entries.push(enc.clone());
        let id = self.entries.len() as u32;
        self.id_map.insert(enc, id);
        id
    }

    pub fn get_id(&self, enc: &EncodedQuotedTriple) -> Option<u32> {
        self.id_map.get(enc).copied()
    }

    pub fn decode(&self, id: u32) -> Option<&EncodedQuotedTriple> {
        if id == 0 || id as usize > self.entries.len() {
            return None;
        }
        Some(&self.entries[(id - 1) as usize])
    }

    pub fn len(&self) -> usize {
        self.entries.len()
    }

    pub fn is_empty(&self) -> bool {
        self.entries.is_empty()
    }
}

// ---------------------------------------------------------------------------
// HdtStarV2Builder
// ---------------------------------------------------------------------------

/// Builder for the HDT-star v2 binary format.
pub struct HdtStarV2Builder {
    subject_dict: FrontCodedDictionary,
    predicate_dict: FrontCodedDictionary,
    object_dict: FrontCodedDictionary,
    quoted_dict: QuotedTripleDictionaryV2,
    /// (subject_id, predicate_id, object_id) triples (after encoding).
    encoded_triples: Vec<(u32, u32, u32)>,
    #[allow(dead_code)]
    profiler: Profiler,
}

impl HdtStarV2Builder {
    pub fn new() -> Self {
        Self {
            subject_dict: FrontCodedDictionary::new(),
            predicate_dict: FrontCodedDictionary::new(),
            object_dict: FrontCodedDictionary::new(),
            quoted_dict: QuotedTripleDictionaryV2::new(),
            encoded_triples: Vec::new(),
            profiler: Profiler::new(),
        }
    }

    /// Add a single triple to the builder.
    pub fn add_triple(&mut self, triple: &StarTriple) -> StarResult<()> {
        let s_id = self.encode_term_as_subject(&triple.subject)?;
        let p_id = self.encode_term_as_predicate(&triple.predicate)?;
        let o_id = self.encode_term_as_object(&triple.object)?;
        self.encoded_triples.push((s_id, p_id, o_id));
        Ok(())
    }

    fn encode_term_as_subject(&mut self, term: &StarTerm) -> StarResult<u32> {
        match term {
            StarTerm::QuotedTriple(qt) => {
                let s = self.encode_term_as_subject(&qt.subject)?;
                let p = self.encode_term_as_predicate(&qt.predicate)?;
                let o = self.encode_term_as_object(&qt.object)?;
                let enc = EncodedQuotedTriple {
                    subject_id: s,
                    predicate_id: p,
                    object_id: o,
                    quoted_subject_id: None,
                };
                Ok(self.quoted_dict.insert(enc))
            }
            _ => {
                let key = term_string(term);
                Ok(self.subject_dict.insert(&key))
            }
        }
    }

    fn encode_term_as_predicate(&mut self, term: &StarTerm) -> StarResult<u32> {
        let key = term_string(term);
        Ok(self.predicate_dict.insert(&key))
    }

    fn encode_term_as_object(&mut self, term: &StarTerm) -> StarResult<u32> {
        match term {
            StarTerm::QuotedTriple(qt) => {
                let s = self.encode_term_as_subject(&qt.subject)?;
                let p = self.encode_term_as_predicate(&qt.predicate)?;
                let o = self.encode_term_as_object(&qt.object)?;
                let enc = EncodedQuotedTriple {
                    subject_id: s,
                    predicate_id: p,
                    object_id: o,
                    quoted_subject_id: None,
                };
                Ok(self.quoted_dict.insert(enc))
            }
            _ => {
                let key = term_string(term);
                Ok(self.object_dict.insert(&key))
            }
        }
    }

    /// Statistics snapshot.
    pub fn statistics(&self) -> HdtV2Statistics {
        HdtV2Statistics {
            triple_count: self.encoded_triples.len(),
            subject_count: self.subject_dict.len(),
            predicate_count: self.predicate_dict.len(),
            object_count: self.object_dict.len(),
            quoted_count: self.quoted_dict.len(),
        }
    }

    /// Serialise the entire HDT-star v2 structure.
    pub fn write<W: Write>(&mut self, writer: &mut W) -> StarResult<()> {
        // Encode front-coded dictionaries.
        self.subject_dict.encode();
        self.predicate_dict.encode();
        self.object_dict.encode();

        // Build XOR-delta bitmap indices.
        let spo_index = self.build_spo_index();

        // Write magic.
        writer
            .write_all(&HDTV2_MAGIC)
            .map_err(|e| StarError::processing_error(format!("Write error: {e}")))?;

        // Write header.
        let header = HdtV2Header {
            version: 2,
            triple_count: self.encoded_triples.len() as u64,
            subject_count: self.subject_dict.len() as u64,
            predicate_count: self.predicate_dict.len() as u64,
            object_count: self.object_dict.len() as u64,
            quoted_count: self.quoted_dict.len() as u64,
            compression_flags: HdtV2Header::FLAG_FRONT_CODING | HdtV2Header::FLAG_XOR_DELTA,
        };
        let header_bytes = serde_json::to_vec(&header)
            .map_err(|e| StarError::processing_error(format!("Header serialization error: {e}")))?;
        write_u32(writer, header_bytes.len() as u32)?;
        writer
            .write_all(&header_bytes)
            .map_err(|e| StarError::processing_error(format!("Write error: {e}")))?;

        // Write dictionaries.
        self.subject_dict.write(writer)?;
        self.predicate_dict.write(writer)?;
        self.object_dict.write(writer)?;

        // Write quoted triple count + entries.
        write_u32(writer, self.quoted_dict.len() as u32)?;
        for entry in &self.quoted_dict.entries {
            write_u32(writer, entry.subject_id)?;
            write_u32(writer, entry.predicate_id)?;
            write_u32(writer, entry.object_id)?;
        }

        // Write XOR delta index.
        spo_index.write(writer)?;

        info!(
            "HDT-star v2 written: {} triples, {} subjects, {} predicates, {} objects, {} quoted",
            header.triple_count,
            header.subject_count,
            header.predicate_count,
            header.object_count,
            header.quoted_count
        );

        Ok(())
    }

    fn build_spo_index(&self) -> XorDeltaBitmapIndex {
        let mut index = XorDeltaBitmapIndex::new();
        // Group by subject → build one bitmap row per distinct subject.
        let mut by_subject: HashMap<u32, Vec<usize>> = HashMap::new();
        for (i, &(s, _p, _o)) in self.encoded_triples.iter().enumerate() {
            by_subject.entry(s).or_default().push(i);
        }
        let mut subjects: Vec<u32> = by_subject.keys().copied().collect();
        subjects.sort_unstable();
        for s in subjects {
            let positions = &by_subject[&s];
            let row = BitmapRow::from_positions(positions);
            index.append(row);
        }
        index
    }
}

impl Default for HdtStarV2Builder {
    fn default() -> Self {
        Self::new()
    }
}

fn term_string(term: &StarTerm) -> String {
    match term {
        StarTerm::NamedNode(n) => format!("<{}>", n.iri),
        StarTerm::BlankNode(b) => format!("_:{}", b.id),
        StarTerm::Literal(l) => {
            let lang = l.language.as_deref().unwrap_or("");
            let dt = l
                .datatype
                .as_ref()
                .map(|d| d.iri.as_str())
                .unwrap_or("xsd:string");
            format!("\"{}\"@{}^^{}", l.value, lang, dt)
        }
        StarTerm::QuotedTriple(qt) => format!(
            "<<{}|{}|{}>>",
            term_string(&qt.subject),
            term_string(&qt.predicate),
            term_string(&qt.object)
        ),
        StarTerm::Variable(v) => format!("?{}", v.name),
    }
}

// ---------------------------------------------------------------------------
// HdtStarV2Reader
// ---------------------------------------------------------------------------

/// Reader for the HDT-star v2 binary format.
pub struct HdtStarV2Reader {
    pub header: HdtV2Header,
    subject_dict: FrontCodedDictionary,
    predicate_dict: FrontCodedDictionary,
    object_dict: FrontCodedDictionary,
    quoted_dict: QuotedTripleDictionaryV2,
    spo_index: XorDeltaBitmapIndex,
}

impl HdtStarV2Reader {
    /// Deserialise an HDT-star v2 structure from a byte reader.
    pub fn read<R: Read>(reader: &mut R) -> StarResult<Self> {
        // Read and verify magic.
        let mut magic = [0u8; 8];
        reader
            .read_exact(&mut magic)
            .map_err(|e| StarError::processing_error(format!("Read error: {e}")))?;
        if magic != HDTV2_MAGIC {
            return Err(StarError::processing_error(
                "Invalid HDT-star v2 magic bytes",
            ));
        }

        // Read header.
        let header_len = read_u32(reader)? as usize;
        let mut header_bytes = vec![0u8; header_len];
        reader
            .read_exact(&mut header_bytes)
            .map_err(|e| StarError::processing_error(format!("Read error: {e}")))?;
        let header: HdtV2Header = serde_json::from_slice(&header_bytes).map_err(|e| {
            StarError::processing_error(format!("Header deserialization error: {e}"))
        })?;

        // Read dictionaries.
        let subject_dict = FrontCodedDictionary::read(reader)?;
        let predicate_dict = FrontCodedDictionary::read(reader)?;
        let object_dict = FrontCodedDictionary::read(reader)?;

        // Read quoted triple dictionary.
        let quoted_count = read_u32(reader)? as usize;
        let mut quoted_dict = QuotedTripleDictionaryV2::new();
        for _ in 0..quoted_count {
            let s = read_u32(reader)?;
            let p = read_u32(reader)?;
            let o = read_u32(reader)?;
            quoted_dict.insert(EncodedQuotedTriple {
                subject_id: s,
                predicate_id: p,
                object_id: o,
                quoted_subject_id: None,
            });
        }

        // Read XOR delta index.
        let spo_index = XorDeltaBitmapIndex::read(reader)?;

        Ok(Self {
            header,
            subject_dict,
            predicate_dict,
            object_dict,
            quoted_dict,
            spo_index,
        })
    }

    /// Statistics about the loaded dataset.
    pub fn statistics(&self) -> HdtV2Statistics {
        HdtV2Statistics {
            triple_count: self.header.triple_count as usize,
            subject_count: self.subject_dict.len(),
            predicate_count: self.predicate_dict.len(),
            object_count: self.object_dict.len(),
            quoted_count: self.quoted_dict.len(),
        }
    }

    /// Return the number of rows in the SPO index.
    pub fn spo_row_count(&self) -> usize {
        self.spo_index.row_count()
    }

    /// Decode a subject by ID.
    pub fn decode_subject(&self, id: u32) -> Option<&str> {
        self.subject_dict.decode(id)
    }

    /// Decode a predicate by ID.
    pub fn decode_predicate(&self, id: u32) -> Option<&str> {
        self.predicate_dict.decode(id)
    }

    /// Decode an object by ID.
    pub fn decode_object(&self, id: u32) -> Option<&str> {
        self.object_dict.decode(id)
    }
}

// ---------------------------------------------------------------------------
// Statistics
// ---------------------------------------------------------------------------

/// Statistics for an HDT-star v2 dataset.
#[derive(Debug, Clone)]
pub struct HdtV2Statistics {
    pub triple_count: usize,
    pub subject_count: usize,
    pub predicate_count: usize,
    pub object_count: usize,
    pub quoted_count: usize,
}

// ---------------------------------------------------------------------------
// I/O primitives
// ---------------------------------------------------------------------------

fn write_u32<W: Write>(writer: &mut W, v: u32) -> StarResult<()> {
    writer
        .write_all(&v.to_le_bytes())
        .map_err(|e| StarError::processing_error(format!("Write error: {e}")))
}

fn read_u32<R: Read>(reader: &mut R) -> StarResult<u32> {
    let mut buf = [0u8; 4];
    reader
        .read_exact(&mut buf)
        .map_err(|e| StarError::processing_error(format!("Read error: {e}")))?;
    Ok(u32::from_le_bytes(buf))
}

fn write_string<W: Write>(writer: &mut W, s: &str) -> StarResult<()> {
    let bytes = s.as_bytes();
    write_u32(writer, bytes.len() as u32)?;
    writer
        .write_all(bytes)
        .map_err(|e| StarError::processing_error(format!("Write error: {e}")))
}

fn read_string<R: Read>(reader: &mut R) -> StarResult<String> {
    let len = read_u32(reader)? as usize;
    let mut buf = vec![0u8; len];
    reader
        .read_exact(&mut buf)
        .map_err(|e| StarError::processing_error(format!("Read error: {e}")))?;
    String::from_utf8(buf).map_err(|e| StarError::processing_error(format!("UTF-8 error: {e}")))
}

// ---------------------------------------------------------------------------
// Tests
// ---------------------------------------------------------------------------

#[cfg(test)]
mod tests {
    use super::*;
    use crate::{StarTerm, StarTriple};

    fn make_triple(s: &str, p: &str, o: &str) -> StarTriple {
        StarTriple::new(
            StarTerm::iri(s).unwrap(),
            StarTerm::iri(p).unwrap(),
            StarTerm::iri(o).unwrap(),
        )
    }

    fn make_quoted_triple(
        qs: &str,
        qp: &str,
        qo: &str,
        meta_pred: &str,
        meta_obj: &str,
    ) -> StarTriple {
        let inner = make_triple(qs, qp, qo);
        StarTriple::new(
            StarTerm::QuotedTriple(Box::new(inner)),
            StarTerm::iri(meta_pred).unwrap(),
            StarTerm::iri(meta_obj).unwrap(),
        )
    }

    // --- FrontCodedDictionary tests ---

    #[test]
    fn test_fcd_insert_and_lookup() {
        let mut dict = FrontCodedDictionary::new();
        let id1 = dict.insert("http://example.org/alice");
        let id2 = dict.insert("http://example.org/bob");
        let id3 = dict.insert("http://example.org/alice"); // duplicate
        assert_ne!(id1, id2);
        assert_eq!(id1, id3, "Duplicate insert should return same ID");
    }

    #[test]
    fn test_fcd_decode() {
        let mut dict = FrontCodedDictionary::new();
        let id = dict.insert("http://example.org/test");
        assert_eq!(dict.decode(id), Some("http://example.org/test"));
        assert_eq!(dict.decode(0), None);
        assert_eq!(dict.decode(9999), None);
    }

    #[test]
    fn test_fcd_encode_sorts() {
        let mut dict = FrontCodedDictionary::new();
        dict.insert("http://z.org/z");
        dict.insert("http://a.org/a");
        dict.insert("http://m.org/m");
        dict.encode();
        // After encoding, entries should be sorted.
        assert_eq!(dict.entries[0], "http://a.org/a");
        assert_eq!(dict.entries[1], "http://m.org/m");
        assert_eq!(dict.entries[2], "http://z.org/z");
    }

    #[test]
    fn test_fcd_compressed_size_smaller_than_raw() {
        let mut dict = FrontCodedDictionary::new();
        for i in 0..100 {
            dict.insert(&format!("http://example.org/resource/{i}"));
        }
        dict.encode();
        let compressed = dict.compressed_size_estimate();
        let raw: usize = dict.entries.iter().map(|e| e.len() + 4).sum();
        // Front-coding should achieve meaningful compression for IRIs with common prefix.
        assert!(
            compressed <= raw,
            "Compressed ({compressed}) should be <= raw ({raw})"
        );
    }

    #[test]
    fn test_fcd_roundtrip() {
        let mut dict = FrontCodedDictionary::new();
        for i in 0..20 {
            dict.insert(&format!("http://example.org/term{i}"));
        }
        let mut buf = Vec::new();
        dict.write(&mut buf).unwrap();
        let restored = FrontCodedDictionary::read(&mut buf.as_slice()).unwrap();
        assert_eq!(restored.len(), dict.len());
        // All original strings must be retrievable.
        for (i, s) in dict.entries.iter().enumerate() {
            let id = restored.get_id(s);
            assert!(id.is_some(), "Term {i} ({s}) not found after roundtrip");
        }
    }

    #[test]
    fn test_fcd_empty_dict() {
        let dict = FrontCodedDictionary::new();
        assert_eq!(dict.len(), 0);
        assert!(dict.is_empty());
    }

    // --- BitmapRow tests ---

    #[test]
    fn test_bitmap_row_set_and_get() {
        let mut row = BitmapRow::default();
        row.set(0);
        row.set(63);
        row.set(64);
        assert!(row.get(0));
        assert!(row.get(63));
        assert!(row.get(64));
        assert!(!row.get(1));
        assert!(!row.get(65));
    }

    #[test]
    fn test_bitmap_row_from_positions() {
        let row = BitmapRow::from_positions(&[0, 5, 10, 63, 128]);
        assert!(row.get(0));
        assert!(row.get(5));
        assert!(row.get(10));
        assert!(row.get(63));
        assert!(row.get(128));
        assert!(!row.get(1));
    }

    #[test]
    fn test_bitmap_row_xor_self_zero() {
        let row = BitmapRow::from_positions(&[1, 3, 5, 7]);
        let delta = row.xor(&row);
        assert_eq!(delta.popcount(), 0, "XOR with self should be zero");
    }

    #[test]
    fn test_bitmap_row_xor_roundtrip() {
        let a = BitmapRow::from_positions(&[1, 5, 10]);
        let b = BitmapRow::from_positions(&[5, 10, 15]);
        let delta = a.xor(&b);
        let recovered = a.apply_xor(&delta);
        assert_eq!(recovered, b, "XOR roundtrip should recover original");
    }

    #[test]
    fn test_bitmap_row_popcount() {
        let row = BitmapRow::from_positions(&[0, 1, 2, 3, 4]);
        assert_eq!(row.popcount(), 5);
    }

    #[test]
    fn test_bitmap_row_roundtrip() {
        let row = BitmapRow::from_positions(&[0, 64, 128, 192]);
        let mut buf = Vec::new();
        row.write(&mut buf).unwrap();
        let restored = BitmapRow::read(&mut buf.as_slice()).unwrap();
        assert_eq!(row, restored);
    }

    // --- XorDeltaBitmapIndex tests ---

    #[test]
    fn test_xor_delta_index_single_row() {
        let mut idx = XorDeltaBitmapIndex::new();
        let row = BitmapRow::from_positions(&[0, 1, 2]);
        idx.append(row.clone());
        assert_eq!(idx.row_count(), 1);
        let retrieved = idx.get_row(0).unwrap();
        assert_eq!(retrieved, row);
    }

    #[test]
    fn test_xor_delta_index_multiple_rows() {
        let mut idx = XorDeltaBitmapIndex::new();
        let rows: Vec<BitmapRow> = (0..5usize)
            .map(|i| BitmapRow::from_positions(&[i, i + 5, i + 10]))
            .collect();
        for r in &rows {
            idx.append(r.clone());
        }
        assert_eq!(idx.row_count(), 5);
        for (i, expected) in rows.iter().enumerate() {
            let got = idx.get_row(i).unwrap();
            assert_eq!(&got, expected, "Row {i} mismatch after XOR delta");
        }
    }

    #[test]
    fn test_xor_delta_index_out_of_range() {
        let idx = XorDeltaBitmapIndex::new();
        let result = idx.get_row(0);
        assert!(result.is_err());
    }

    #[test]
    fn test_xor_delta_index_roundtrip() {
        let mut idx = XorDeltaBitmapIndex::new();
        for i in 0..10usize {
            idx.append(BitmapRow::from_positions(&[i, i + 100]));
        }
        let mut buf = Vec::new();
        idx.write(&mut buf).unwrap();
        let restored = XorDeltaBitmapIndex::read(&mut buf.as_slice()).unwrap();
        assert_eq!(restored.row_count(), 10);
        for i in 0..10 {
            let expected = idx.get_row(i).unwrap();
            let got = restored.get_row(i).unwrap();
            assert_eq!(got, expected, "Roundtrip mismatch at row {i}");
        }
    }

    #[test]
    fn test_xor_delta_compression_ratio() {
        let mut idx = XorDeltaBitmapIndex::new();
        // Similar rows → high compression.
        let base = BitmapRow::from_positions(&(0..100usize).collect::<Vec<_>>());
        for _ in 0..10 {
            idx.append(base.clone());
        }
        let ratio = idx.compression_ratio();
        // All rows identical → deltas are all-zero → high ratio.
        assert!(
            ratio > 1.0,
            "Compression ratio should be > 1.0 for identical rows, got {ratio}"
        );
    }

    // --- HdtStarV2Builder / Reader roundtrip tests ---

    #[test]
    fn test_builder_add_and_write_basic() {
        let mut builder = HdtStarV2Builder::new();
        for i in 0..10 {
            builder
                .add_triple(&make_triple(
                    &format!("http://ex.org/s{i}"),
                    "http://ex.org/p",
                    &format!("http://ex.org/o{i}"),
                ))
                .unwrap();
        }
        let mut buf = Vec::new();
        builder.write(&mut buf).unwrap();
        assert!(!buf.is_empty());
    }

    #[test]
    fn test_builder_statistics() {
        let mut builder = HdtStarV2Builder::new();
        for i in 0..5 {
            builder
                .add_triple(&make_triple(
                    &format!("http://ex.org/s{i}"),
                    "http://ex.org/p",
                    &format!("http://ex.org/o{i}"),
                ))
                .unwrap();
        }
        let stats = builder.statistics();
        assert_eq!(stats.triple_count, 5);
        assert!(stats.subject_count >= 1);
        assert!(stats.predicate_count >= 1);
        assert!(stats.object_count >= 1);
    }

    #[test]
    fn test_roundtrip_basic_triples() {
        let mut builder = HdtStarV2Builder::new();
        for i in 0..5 {
            builder
                .add_triple(&make_triple(
                    &format!("http://ex.org/s{i}"),
                    "http://ex.org/p",
                    &format!("http://ex.org/o{i}"),
                ))
                .unwrap();
        }
        let mut buf = Vec::new();
        builder.write(&mut buf).unwrap();

        let reader = HdtStarV2Reader::read(&mut buf.as_slice()).unwrap();
        let stats = reader.statistics();
        assert_eq!(stats.triple_count, 5);
        assert!(stats.subject_count >= 1);
    }

    #[test]
    fn test_roundtrip_quoted_triples() {
        let mut builder = HdtStarV2Builder::new();
        builder
            .add_triple(&make_quoted_triple(
                "http://ex.org/a",
                "http://ex.org/b",
                "http://ex.org/c",
                "http://ex.org/certainty",
                "http://ex.org/high",
            ))
            .unwrap();
        let stats = builder.statistics();
        assert_eq!(stats.quoted_count, 1);

        let mut buf = Vec::new();
        builder.write(&mut buf).unwrap();
        let reader = HdtStarV2Reader::read(&mut buf.as_slice()).unwrap();
        assert_eq!(reader.statistics().quoted_count, 1);
    }

    #[test]
    fn test_magic_bytes_verified() {
        // Write valid data then corrupt the magic.
        let mut builder = HdtStarV2Builder::new();
        builder
            .add_triple(&make_triple("http://a", "http://b", "http://c"))
            .unwrap();
        let mut buf = Vec::new();
        builder.write(&mut buf).unwrap();
        buf[0] ^= 0xFF; // corrupt first byte
        let result = HdtStarV2Reader::read(&mut buf.as_slice());
        assert!(result.is_err(), "Corrupted magic should fail");
    }

    #[test]
    fn test_header_flags() {
        let h = HdtV2Header::new();
        assert!(h.has_front_coding());
        assert!(h.has_xor_delta());
    }

    #[test]
    fn test_quoted_triple_dictionary_insert_dedup() {
        let mut qd = QuotedTripleDictionaryV2::new();
        let enc = EncodedQuotedTriple {
            subject_id: 1,
            predicate_id: 2,
            object_id: 3,
            quoted_subject_id: None,
        };
        let id1 = qd.insert(enc.clone());
        let id2 = qd.insert(enc.clone());
        assert_eq!(id1, id2);
        assert_eq!(qd.len(), 1);
    }

    #[test]
    fn test_large_dataset_compression() {
        let mut builder = HdtStarV2Builder::new();
        for i in 0..1000 {
            builder
                .add_triple(&make_triple(
                    &format!("http://example.org/subject/{i}"),
                    "http://example.org/predicate/knows",
                    &format!("http://example.org/object/{}", i % 100),
                ))
                .unwrap();
        }
        let mut buf = Vec::new();
        builder.write(&mut buf).unwrap();
        // Check that dict compression actually stored common prefixes.
        let reader = HdtStarV2Reader::read(&mut buf.as_slice()).unwrap();
        let stats = reader.statistics();
        assert_eq!(stats.triple_count, 1000);
        assert_eq!(stats.predicate_count, 1);
        assert_eq!(stats.object_count, 100);
    }

    #[test]
    fn test_spo_index_row_count() {
        let mut builder = HdtStarV2Builder::new();
        // Add triples with 5 distinct subjects.
        for s in 0..5 {
            for o in 0..3 {
                builder
                    .add_triple(&make_triple(
                        &format!("http://ex.org/s{s}"),
                        "http://ex.org/p",
                        &format!("http://ex.org/o{o}"),
                    ))
                    .unwrap();
            }
        }
        let mut buf = Vec::new();
        builder.write(&mut buf).unwrap();
        let reader = HdtStarV2Reader::read(&mut buf.as_slice()).unwrap();
        assert_eq!(
            reader.spo_row_count(),
            5,
            "SPO index should have 5 rows (one per subject)"
        );
    }
}