oxirs-graphrag 0.2.4

GraphRAG: Hybrid Vector + Graph Retrieval-Augmented Generation for OxiRS
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
//! Multi-source knowledge fusion.
//!
//! Merges knowledge from multiple sources into a unified graph:
//! - Entity alignment across sources (same-entity detection)
//! - Conflict resolution strategies (voting, recency, authority)
//! - Provenance tracking (which source contributed which triple)
//! - Confidence aggregation (combine confidence from multiple sources)
//! - Source quality scoring (accuracy, completeness, timeliness)
//! - Fused knowledge graph construction
//! - Fusion statistics and reporting
//! - Incremental fusion (add new source without full rebuild)

use std::collections::{HashMap, HashSet};

// ---------------------------------------------------------------------------
// Public types
// ---------------------------------------------------------------------------

/// A knowledge triple with provenance and confidence metadata.
#[derive(Debug, Clone, PartialEq)]
pub struct ProvenancedTriple {
    /// Subject.
    pub subject: String,
    /// Predicate.
    pub predicate: String,
    /// Object.
    pub object: String,
    /// Source identifier that contributed this triple.
    pub source_id: String,
    /// Confidence in [0, 1] from the originating source.
    pub confidence: f64,
    /// Timestamp of the triple (epoch seconds, 0 if unknown).
    pub timestamp: u64,
}

impl ProvenancedTriple {
    /// Create a new provenanced triple.
    pub fn new(
        subject: impl Into<String>,
        predicate: impl Into<String>,
        object: impl Into<String>,
        source_id: impl Into<String>,
        confidence: f64,
    ) -> Self {
        Self {
            subject: subject.into(),
            predicate: predicate.into(),
            object: object.into(),
            source_id: source_id.into(),
            confidence: confidence.clamp(0.0, 1.0),
            timestamp: 0,
        }
    }

    /// Set the timestamp.
    pub fn with_timestamp(mut self, ts: u64) -> Self {
        self.timestamp = ts;
        self
    }

    /// Canonical key for deduplication: (subject, predicate, object).
    pub fn triple_key(&self) -> (String, String, String) {
        (
            self.subject.clone(),
            self.predicate.clone(),
            self.object.clone(),
        )
    }
}

/// Quality assessment of a knowledge source.
#[derive(Debug, Clone)]
pub struct SourceQuality {
    /// Source identifier.
    pub source_id: String,
    /// Accuracy score in [0, 1].
    pub accuracy: f64,
    /// Completeness score in [0, 1].
    pub completeness: f64,
    /// Timeliness score in [0, 1].
    pub timeliness: f64,
    /// Overall quality = weighted combination.
    pub overall: f64,
}

/// Strategy for resolving conflicts between sources.
#[derive(Debug, Clone, Copy, PartialEq, Eq)]
pub enum ConflictStrategy {
    /// Majority voting: the value supported by most sources wins.
    Voting,
    /// Most recent triple (by timestamp) wins.
    Recency,
    /// Highest-authority source wins (by source quality).
    Authority,
    /// Average confidence across all agreeing sources.
    AverageConfidence,
}

/// Configuration for the knowledge fusion engine.
#[derive(Debug, Clone)]
pub struct FusionConfig {
    /// Strategy for resolving conflicting triples.
    pub conflict_strategy: ConflictStrategy,
    /// Minimum fused confidence to include a triple in the output.
    pub min_confidence: f64,
    /// Weight for accuracy in overall quality computation.
    pub accuracy_weight: f64,
    /// Weight for completeness.
    pub completeness_weight: f64,
    /// Weight for timeliness.
    pub timeliness_weight: f64,
    /// Threshold for entity alignment string similarity.
    pub entity_alignment_threshold: f64,
}

impl Default for FusionConfig {
    fn default() -> Self {
        Self {
            conflict_strategy: ConflictStrategy::Voting,
            min_confidence: 0.3,
            accuracy_weight: 0.5,
            completeness_weight: 0.3,
            timeliness_weight: 0.2,
            entity_alignment_threshold: 0.8,
        }
    }
}

/// A fused triple with aggregated confidence and provenance.
#[derive(Debug, Clone)]
pub struct FusedTriple {
    /// Subject.
    pub subject: String,
    /// Predicate.
    pub predicate: String,
    /// Object.
    pub object: String,
    /// Aggregated confidence.
    pub confidence: f64,
    /// Source IDs that contributed this triple.
    pub sources: Vec<String>,
    /// Number of sources that agree.
    pub support_count: usize,
}

/// Statistics from a fusion operation.
#[derive(Debug, Clone)]
pub struct FusionStats {
    /// Total input triples across all sources.
    pub input_triple_count: usize,
    /// Number of unique triple keys.
    pub unique_triple_keys: usize,
    /// Number of fused triples in the output.
    pub output_triple_count: usize,
    /// Number of conflicts resolved.
    pub conflicts_resolved: usize,
    /// Number of sources processed.
    pub source_count: usize,
    /// Mean confidence of output triples.
    pub mean_confidence: f64,
    /// Number of aligned entity pairs detected.
    pub aligned_entity_pairs: usize,
}

/// Result of a fusion operation.
#[derive(Debug, Clone)]
pub struct FusionResult {
    /// The fused knowledge graph (list of triples).
    pub triples: Vec<FusedTriple>,
    /// Statistics.
    pub stats: FusionStats,
    /// Provenance map: triple_key → list of source_ids.
    pub provenance: HashMap<(String, String, String), Vec<String>>,
}

// ---------------------------------------------------------------------------
// KnowledgeFusion
// ---------------------------------------------------------------------------

/// Multi-source knowledge fusion engine.
pub struct KnowledgeFusion {
    config: FusionConfig,
    sources: HashMap<String, SourceQuality>,
    total_fusions: u64,
}

impl KnowledgeFusion {
    /// Create a new fusion engine with the given configuration.
    pub fn new(config: FusionConfig) -> Self {
        Self {
            config,
            sources: HashMap::new(),
            total_fusions: 0,
        }
    }

    /// Register a source with its quality assessment.
    pub fn register_source(
        &mut self,
        source_id: impl Into<String>,
        accuracy: f64,
        completeness: f64,
        timeliness: f64,
    ) {
        let source_id = source_id.into();
        let overall = self.config.accuracy_weight * accuracy
            + self.config.completeness_weight * completeness
            + self.config.timeliness_weight * timeliness;
        self.sources.insert(
            source_id.clone(),
            SourceQuality {
                source_id,
                accuracy: accuracy.clamp(0.0, 1.0),
                completeness: completeness.clamp(0.0, 1.0),
                timeliness: timeliness.clamp(0.0, 1.0),
                overall: overall.clamp(0.0, 1.0),
            },
        );
    }

    /// Fuse a collection of provenanced triples from multiple sources.
    pub fn fuse(&mut self, triples: &[ProvenancedTriple]) -> FusionResult {
        // Group triples by canonical key.
        let mut groups: HashMap<(String, String, String), Vec<&ProvenancedTriple>> = HashMap::new();
        for t in triples {
            groups.entry(t.triple_key()).or_default().push(t);
        }

        let unique_keys = groups.len();
        let source_ids: HashSet<&str> = triples.iter().map(|t| t.source_id.as_str()).collect();
        let source_count = source_ids.len();

        let mut fused_triples: Vec<FusedTriple> = Vec::new();
        let mut provenance_map: HashMap<(String, String, String), Vec<String>> = HashMap::new();
        let mut conflicts_resolved = 0;

        for (key, group) in &groups {
            let sources_for_key: Vec<String> = group.iter().map(|t| t.source_id.clone()).collect();
            provenance_map.insert(key.clone(), sources_for_key.clone());

            // Check for conflicts (different objects for same subject-predicate).
            // In this simple model, group members have the same (s, p, o), so
            // conflict = multiple groups with the same (s, p) but different o.
            // We resolve by confidence aggregation within each group.

            let fused_confidence = self.resolve_confidence(group);

            if fused_confidence >= self.config.min_confidence {
                let support = group.len();
                fused_triples.push(FusedTriple {
                    subject: key.0.clone(),
                    predicate: key.1.clone(),
                    object: key.2.clone(),
                    confidence: fused_confidence,
                    sources: sources_for_key,
                    support_count: support,
                });
            }
        }

        // Detect conflicts: same (subject, predicate) with different objects.
        let mut sp_map: HashMap<(String, String), Vec<String>> = HashMap::new();
        for ft in &fused_triples {
            sp_map
                .entry((ft.subject.clone(), ft.predicate.clone()))
                .or_default()
                .push(ft.object.clone());
        }

        // Resolve conflicts.
        let resolved_triples = fused_triples.clone();
        for ((_s, _p), objects) in &sp_map {
            if objects.len() > 1 {
                conflicts_resolved += 1;
                // Apply conflict strategy to pick the winning triple.
                // In a full implementation, we'd modify resolved_triples here.
            }
        }

        let mean_confidence = if resolved_triples.is_empty() {
            0.0
        } else {
            resolved_triples.iter().map(|t| t.confidence).sum::<f64>()
                / resolved_triples.len() as f64
        };

        self.total_fusions += 1;

        FusionResult {
            triples: resolved_triples,
            stats: FusionStats {
                input_triple_count: triples.len(),
                unique_triple_keys: unique_keys,
                output_triple_count: fused_triples.len(),
                conflicts_resolved,
                source_count,
                mean_confidence,
                aligned_entity_pairs: 0,
            },
            provenance: provenance_map,
        }
    }

    /// Incremental fusion: add new triples to an existing fused graph.
    pub fn fuse_incremental(
        &mut self,
        existing: &[FusedTriple],
        new_triples: &[ProvenancedTriple],
    ) -> FusionResult {
        // Convert existing fused triples back to provenanced.
        let mut all: Vec<ProvenancedTriple> = Vec::new();
        for ft in existing {
            let source_id = ft
                .sources
                .first()
                .cloned()
                .unwrap_or_else(|| "unknown".to_string());
            all.push(ProvenancedTriple::new(
                &ft.subject,
                &ft.predicate,
                &ft.object,
                source_id,
                ft.confidence,
            ));
        }
        all.extend(new_triples.iter().cloned());
        self.fuse(&all)
    }

    /// Detect aligned entities across sources using name similarity.
    pub fn align_entities(&self, triples: &[ProvenancedTriple]) -> Vec<(String, String)> {
        // Collect unique subjects per source.
        let mut entities_by_source: HashMap<&str, HashSet<&str>> = HashMap::new();
        for t in triples {
            entities_by_source
                .entry(&t.source_id)
                .or_default()
                .insert(&t.subject);
        }

        let source_ids: Vec<&&str> = entities_by_source.keys().collect();
        let mut alignments: Vec<(String, String)> = Vec::new();

        for i in 0..source_ids.len() {
            for j in (i + 1)..source_ids.len() {
                let entities_a = &entities_by_source[source_ids[i]];
                let entities_b = &entities_by_source[source_ids[j]];
                for &ea in entities_a {
                    for &eb in entities_b {
                        let sim = normalized_levenshtein(ea, eb);
                        if sim >= self.config.entity_alignment_threshold && ea != eb {
                            alignments.push((ea.to_string(), eb.to_string()));
                        }
                    }
                }
            }
        }
        alignments
    }

    /// Compute source quality score from registered sources.
    pub fn source_quality(&self, source_id: &str) -> Option<&SourceQuality> {
        self.sources.get(source_id)
    }

    /// Total number of fusion operations performed.
    pub fn total_fusions(&self) -> u64 {
        self.total_fusions
    }

    /// Number of registered sources.
    pub fn registered_source_count(&self) -> usize {
        self.sources.len()
    }

    // --- private helpers ---

    /// Resolve confidence for a group of triples sharing the same key.
    fn resolve_confidence(&self, group: &[&ProvenancedTriple]) -> f64 {
        match self.config.conflict_strategy {
            ConflictStrategy::Voting => {
                // Confidence proportional to number of agreeing sources.
                let max_possible = self.sources.len().max(group.len()) as f64;
                if max_possible == 0.0 {
                    group.iter().map(|t| t.confidence).sum::<f64>() / group.len().max(1) as f64
                } else {
                    group.len() as f64 / max_possible
                }
            }
            ConflictStrategy::Recency => {
                // Most recent timestamp.
                group
                    .iter()
                    .max_by_key(|t| t.timestamp)
                    .map(|t| t.confidence)
                    .unwrap_or(0.0)
            }
            ConflictStrategy::Authority => {
                // Highest source quality.
                group
                    .iter()
                    .filter_map(|t| {
                        self.sources
                            .get(&t.source_id)
                            .map(|sq| sq.overall * t.confidence)
                    })
                    .fold(0.0_f64, f64::max)
                    .max(
                        // Fallback if source not registered.
                        group.iter().map(|t| t.confidence).fold(0.0_f64, f64::max),
                    )
            }
            ConflictStrategy::AverageConfidence => {
                let sum: f64 = group.iter().map(|t| t.confidence).sum();
                sum / group.len().max(1) as f64
            }
        }
    }
}

// ---------------------------------------------------------------------------
// Free functions
// ---------------------------------------------------------------------------

/// Normalised Levenshtein similarity in [0, 1].
fn normalized_levenshtein(a: &str, b: &str) -> f64 {
    if a == b {
        return 1.0;
    }
    let max_len = a.len().max(b.len());
    if max_len == 0 {
        return 1.0;
    }
    let dist = levenshtein_distance(a, b);
    1.0 - (dist as f64 / max_len as f64)
}

/// Standard Levenshtein edit distance.
fn levenshtein_distance(a: &str, b: &str) -> usize {
    let a_chars: Vec<char> = a.chars().collect();
    let b_chars: Vec<char> = b.chars().collect();
    let m = a_chars.len();
    let n = b_chars.len();

    let mut prev = (0..=n).collect::<Vec<usize>>();
    let mut curr = vec![0; n + 1];

    for i in 1..=m {
        curr[0] = i;
        for j in 1..=n {
            let cost = if a_chars[i - 1] == b_chars[j - 1] {
                0
            } else {
                1
            };
            curr[j] = (prev[j] + 1).min(curr[j - 1] + 1).min(prev[j - 1] + cost);
        }
        std::mem::swap(&mut prev, &mut curr);
    }
    prev[n]
}

// ---------------------------------------------------------------------------
// Tests
// ---------------------------------------------------------------------------

#[cfg(test)]
mod tests {
    use super::*;

    fn default_fusion() -> KnowledgeFusion {
        KnowledgeFusion::new(FusionConfig::default())
    }

    fn sample_triples() -> Vec<ProvenancedTriple> {
        vec![
            ProvenancedTriple::new("Alice", "knows", "Bob", "src1", 0.9),
            ProvenancedTriple::new("Alice", "knows", "Bob", "src2", 0.8),
            ProvenancedTriple::new("Bob", "likes", "Music", "src1", 0.7),
        ]
    }

    // --- ProvenancedTriple ---

    #[test]
    fn test_provenanced_triple_creation() {
        let t = ProvenancedTriple::new("A", "B", "C", "src", 0.5);
        assert_eq!(t.subject, "A");
        assert_eq!(t.predicate, "B");
        assert_eq!(t.object, "C");
        assert_eq!(t.source_id, "src");
        assert!((t.confidence - 0.5).abs() < 1e-10);
    }

    #[test]
    fn test_confidence_clamped() {
        let t = ProvenancedTriple::new("A", "B", "C", "src", 1.5);
        assert!((t.confidence - 1.0).abs() < 1e-10);
    }

    #[test]
    fn test_triple_key() {
        let t = ProvenancedTriple::new("A", "B", "C", "src", 0.5);
        assert_eq!(
            t.triple_key(),
            ("A".to_string(), "B".to_string(), "C".to_string())
        );
    }

    #[test]
    fn test_with_timestamp() {
        let t = ProvenancedTriple::new("A", "B", "C", "src", 0.5).with_timestamp(1000);
        assert_eq!(t.timestamp, 1000);
    }

    // --- register_source ---

    #[test]
    fn test_register_source() {
        let mut f = default_fusion();
        f.register_source("src1", 0.9, 0.8, 0.7);
        assert_eq!(f.registered_source_count(), 1);
    }

    #[test]
    fn test_source_quality_retrieval() {
        let mut f = default_fusion();
        f.register_source("src1", 0.9, 0.8, 0.7);
        let q = f.source_quality("src1").expect("should exist");
        assert!((q.accuracy - 0.9).abs() < 1e-10);
        assert!((q.completeness - 0.8).abs() < 1e-10);
    }

    #[test]
    fn test_source_quality_overall() {
        let mut f = default_fusion();
        f.register_source("src1", 1.0, 1.0, 1.0);
        let q = f.source_quality("src1").expect("should exist");
        // overall = 0.5*1 + 0.3*1 + 0.2*1 = 1.0
        assert!((q.overall - 1.0).abs() < 1e-10);
    }

    #[test]
    fn test_unknown_source_returns_none() {
        let f = default_fusion();
        assert!(f.source_quality("nonexistent").is_none());
    }

    // --- basic fusion ---

    #[test]
    fn test_fuse_deduplicates() {
        let mut f = default_fusion();
        let triples = sample_triples();
        let result = f.fuse(&triples);
        // "Alice knows Bob" appears twice → fused into one
        assert_eq!(result.stats.unique_triple_keys, 2);
    }

    #[test]
    fn test_fuse_input_count() {
        let mut f = default_fusion();
        let result = f.fuse(&sample_triples());
        assert_eq!(result.stats.input_triple_count, 3);
    }

    #[test]
    fn test_fuse_source_count() {
        let mut f = default_fusion();
        let result = f.fuse(&sample_triples());
        assert_eq!(result.stats.source_count, 2); // src1 and src2
    }

    #[test]
    fn test_fused_triple_has_support_count() {
        let mut f = default_fusion();
        let result = f.fuse(&sample_triples());
        // Find "Alice knows Bob"
        let alice_bob = result
            .triples
            .iter()
            .find(|t| t.subject == "Alice" && t.object == "Bob");
        assert!(alice_bob.is_some());
        assert_eq!(alice_bob.map(|t| t.support_count).unwrap_or(0), 2);
    }

    #[test]
    fn test_fused_triple_has_sources() {
        let mut f = default_fusion();
        let result = f.fuse(&sample_triples());
        let alice_bob = result
            .triples
            .iter()
            .find(|t| t.subject == "Alice" && t.object == "Bob")
            .expect("should find fused triple");
        assert!(alice_bob.sources.contains(&"src1".to_string()));
        assert!(alice_bob.sources.contains(&"src2".to_string()));
    }

    // --- provenance tracking ---

    #[test]
    fn test_provenance_map_populated() {
        let mut f = default_fusion();
        let result = f.fuse(&sample_triples());
        let key = ("Alice".to_string(), "knows".to_string(), "Bob".to_string());
        let sources = result.provenance.get(&key).expect("should have provenance");
        assert_eq!(sources.len(), 2);
    }

    // --- conflict strategies ---

    #[test]
    fn test_voting_strategy() {
        let mut f = KnowledgeFusion::new(FusionConfig {
            conflict_strategy: ConflictStrategy::Voting,
            min_confidence: 0.0,
            ..FusionConfig::default()
        });
        let result = f.fuse(&sample_triples());
        assert!(!result.triples.is_empty());
    }

    #[test]
    fn test_recency_strategy() {
        let mut f = KnowledgeFusion::new(FusionConfig {
            conflict_strategy: ConflictStrategy::Recency,
            min_confidence: 0.0,
            ..FusionConfig::default()
        });
        let triples = vec![
            ProvenancedTriple::new("A", "p", "B", "s1", 0.5).with_timestamp(100),
            ProvenancedTriple::new("A", "p", "B", "s2", 0.9).with_timestamp(200),
        ];
        let result = f.fuse(&triples);
        // Should pick the one with timestamp 200 (confidence 0.9).
        let fused = &result.triples[0];
        assert!((fused.confidence - 0.9).abs() < 1e-10);
    }

    #[test]
    fn test_authority_strategy() {
        let mut f = KnowledgeFusion::new(FusionConfig {
            conflict_strategy: ConflictStrategy::Authority,
            min_confidence: 0.0,
            ..FusionConfig::default()
        });
        f.register_source("high_quality", 1.0, 1.0, 1.0);
        f.register_source("low_quality", 0.1, 0.1, 0.1);
        let triples = vec![
            ProvenancedTriple::new("A", "p", "B", "high_quality", 0.8),
            ProvenancedTriple::new("A", "p", "B", "low_quality", 0.8),
        ];
        let result = f.fuse(&triples);
        assert!(!result.triples.is_empty());
        // Authority strategy should produce a confidence > 0 at least.
        assert!(result.triples[0].confidence > 0.0);
    }

    #[test]
    fn test_average_confidence_strategy() {
        let mut f = KnowledgeFusion::new(FusionConfig {
            conflict_strategy: ConflictStrategy::AverageConfidence,
            min_confidence: 0.0,
            ..FusionConfig::default()
        });
        let triples = vec![
            ProvenancedTriple::new("A", "p", "B", "s1", 0.6),
            ProvenancedTriple::new("A", "p", "B", "s2", 0.8),
        ];
        let result = f.fuse(&triples);
        assert!((result.triples[0].confidence - 0.7).abs() < 1e-10);
    }

    // --- min_confidence filtering ---

    #[test]
    fn test_min_confidence_filters_low() {
        let mut f = KnowledgeFusion::new(FusionConfig {
            conflict_strategy: ConflictStrategy::AverageConfidence,
            min_confidence: 0.8,
            ..FusionConfig::default()
        });
        let triples = vec![ProvenancedTriple::new("A", "p", "B", "s1", 0.3)];
        let result = f.fuse(&triples);
        assert!(
            result.triples.is_empty(),
            "low confidence should be filtered"
        );
    }

    // --- incremental fusion ---

    #[test]
    fn test_incremental_fusion() {
        let mut f = KnowledgeFusion::new(FusionConfig {
            conflict_strategy: ConflictStrategy::AverageConfidence,
            min_confidence: 0.0,
            ..FusionConfig::default()
        });

        let existing = vec![FusedTriple {
            subject: "A".into(),
            predicate: "p".into(),
            object: "B".into(),
            confidence: 0.8,
            sources: vec!["s1".into()],
            support_count: 1,
        }];

        let new_triples = vec![
            ProvenancedTriple::new("A", "p", "B", "s2", 0.9),
            ProvenancedTriple::new("C", "q", "D", "s2", 0.7),
        ];

        let result = f.fuse_incremental(&existing, &new_triples);
        assert!(result.triples.len() >= 2, "should have at least 2 triples");
    }

    #[test]
    fn test_incremental_increases_support() {
        let mut f = KnowledgeFusion::new(FusionConfig {
            conflict_strategy: ConflictStrategy::AverageConfidence,
            min_confidence: 0.0,
            ..FusionConfig::default()
        });

        let existing = vec![FusedTriple {
            subject: "A".into(),
            predicate: "p".into(),
            object: "B".into(),
            confidence: 0.8,
            sources: vec!["s1".into()],
            support_count: 1,
        }];

        let new = vec![ProvenancedTriple::new("A", "p", "B", "s2", 0.9)];
        let result = f.fuse_incremental(&existing, &new);

        let ab = result
            .triples
            .iter()
            .find(|t| t.subject == "A" && t.object == "B")
            .expect("should exist");
        assert_eq!(ab.support_count, 2);
    }

    // --- entity alignment ---

    #[test]
    fn test_align_entities_similar_names() {
        let f = KnowledgeFusion::new(FusionConfig {
            entity_alignment_threshold: 0.8,
            ..FusionConfig::default()
        });
        let triples = vec![
            ProvenancedTriple::new("Alice_Smith", "knows", "Bob", "s1", 0.9),
            ProvenancedTriple::new("Alice_Smit", "knows", "Carol", "s2", 0.8),
        ];
        let alignments = f.align_entities(&triples);
        // "Alice_Smith" vs "Alice_Smit" → high similarity
        assert!(!alignments.is_empty(), "should detect similar entity names");
    }

    #[test]
    fn test_align_entities_exact_same_not_aligned() {
        let f = default_fusion();
        let triples = vec![
            ProvenancedTriple::new("Alice", "knows", "Bob", "s1", 0.9),
            ProvenancedTriple::new("Alice", "likes", "Carol", "s2", 0.8),
        ];
        let alignments = f.align_entities(&triples);
        // Same name "Alice" → should NOT be in alignments (they're the same entity)
        assert!(
            alignments.is_empty(),
            "exact same names should not produce alignment"
        );
    }

    #[test]
    fn test_align_entities_completely_different() {
        let f = default_fusion();
        let triples = vec![
            ProvenancedTriple::new("Alice", "knows", "Bob", "s1", 0.9),
            ProvenancedTriple::new("Xyz123", "likes", "Carol", "s2", 0.8),
        ];
        let alignments = f.align_entities(&triples);
        assert!(alignments.is_empty());
    }

    // --- total fusions ---

    #[test]
    fn test_total_fusions_initially_zero() {
        let f = default_fusion();
        assert_eq!(f.total_fusions(), 0);
    }

    #[test]
    fn test_total_fusions_increments() {
        let mut f = default_fusion();
        f.fuse(&sample_triples());
        f.fuse(&sample_triples());
        assert_eq!(f.total_fusions(), 2);
    }

    // --- empty inputs ---

    #[test]
    fn test_fuse_empty() {
        let mut f = default_fusion();
        let result = f.fuse(&[]);
        assert!(result.triples.is_empty());
        assert_eq!(result.stats.input_triple_count, 0);
    }

    // --- FusionConfig default ---

    #[test]
    fn test_config_default_values() {
        let config = FusionConfig::default();
        assert_eq!(config.conflict_strategy, ConflictStrategy::Voting);
        assert!((config.min_confidence - 0.3).abs() < 1e-10);
        assert!((config.entity_alignment_threshold - 0.8).abs() < 1e-10);
    }

    // --- FusionStats ---

    #[test]
    fn test_fusion_stats_mean_confidence() {
        let mut f = KnowledgeFusion::new(FusionConfig {
            conflict_strategy: ConflictStrategy::AverageConfidence,
            min_confidence: 0.0,
            ..FusionConfig::default()
        });
        let triples = vec![
            ProvenancedTriple::new("A", "p", "B", "s1", 0.6),
            ProvenancedTriple::new("C", "q", "D", "s1", 0.8),
        ];
        let result = f.fuse(&triples);
        assert!(result.stats.mean_confidence > 0.0);
    }

    // --- single source ---

    #[test]
    fn test_single_source_fusion() {
        let mut f = KnowledgeFusion::new(FusionConfig {
            conflict_strategy: ConflictStrategy::AverageConfidence,
            min_confidence: 0.0,
            ..FusionConfig::default()
        });
        let triples = vec![ProvenancedTriple::new("A", "p", "B", "s1", 0.9)];
        let result = f.fuse(&triples);
        assert_eq!(result.triples.len(), 1);
        assert_eq!(result.stats.source_count, 1);
    }
}