oxirs-embed 0.2.4

Knowledge graph embeddings with TransE, ComplEx, and custom models
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
//! TuckER: Tucker Decomposition for Knowledge Graph Embeddings
//!
//! TuckER is a tensor factorization model that performs link prediction
//! using Tucker decomposition on the binary tensor representation of knowledge graphs.
//!
//! Reference: Balažević et al. "TuckER: Tensor Factorization for Knowledge Graph Completion" (2019)

use crate::models::{common::*, BaseModel};
use crate::{EmbeddingModel, ModelConfig, ModelStats, TrainingStats, Triple, Vector};
use anyhow::{anyhow, Result};
use async_trait::async_trait;
use scirs2_core::ndarray_ext::{Array2, Array3};
use scirs2_core::random::{Random, Rng, RngExt, SliceRandom};
use std::time::Instant;
use tracing::{debug, info};
use uuid::Uuid;

/// TuckER embedding model
#[derive(Debug)]
pub struct TuckER {
    /// Base model functionality
    base: BaseModel,
    /// Entity embeddings matrix (num_entities × entity_dim)
    entity_embeddings: Array2<f64>,
    /// Relation embeddings matrix (num_relations × relation_dim)  
    relation_embeddings: Array2<f64>,
    /// Core tensor for Tucker decomposition
    core_tensor: Array3<f64>,
    /// Whether embeddings have been initialized
    embeddings_initialized: bool,
    /// Entity embedding dimension
    entity_dim: usize,
    /// Relation embedding dimension
    relation_dim: usize,
    /// Core tensor dimensions
    core_dims: (usize, usize, usize),
    /// Dropout rate for training
    dropout_rate: f64,
    /// Batch normalization parameters
    batch_norm: bool,
}

impl TuckER {
    /// Create a new TuckER model
    pub fn new(config: ModelConfig) -> Self {
        let base = BaseModel::new(config.clone());

        // Get TuckER-specific parameters from model_params
        let entity_dim = config
            .model_params
            .get("entity_dim")
            .map(|&v| v as usize)
            .unwrap_or(config.dimensions);
        let relation_dim = config
            .model_params
            .get("relation_dim")
            .map(|&v| v as usize)
            .unwrap_or(config.dimensions);
        let core_dim1 = config
            .model_params
            .get("core_dim1")
            .map(|&v| v as usize)
            .unwrap_or(config.dimensions);
        let core_dim2 = config
            .model_params
            .get("core_dim2")
            .map(|&v| v as usize)
            .unwrap_or(config.dimensions);
        let core_dim3 = config
            .model_params
            .get("core_dim3")
            .map(|&v| v as usize)
            .unwrap_or(config.dimensions);
        let dropout_rate = config
            .model_params
            .get("dropout_rate")
            .copied()
            .unwrap_or(0.3);
        let batch_norm = config
            .model_params
            .get("batch_norm")
            .map(|&v| v > 0.0)
            .unwrap_or(true);

        Self {
            base,
            entity_embeddings: Array2::zeros((0, entity_dim)),
            relation_embeddings: Array2::zeros((0, relation_dim)),
            core_tensor: Array3::zeros((core_dim1, core_dim2, core_dim3)),
            embeddings_initialized: false,
            entity_dim,
            relation_dim,
            core_dims: (core_dim1, core_dim2, core_dim3),
            dropout_rate,
            batch_norm,
        }
    }

    /// Initialize embeddings after entities and relations are known
    fn initialize_embeddings(&mut self) {
        if self.embeddings_initialized {
            return;
        }

        let num_entities = self.base.num_entities();
        let num_relations = self.base.num_relations();

        if num_entities == 0 || num_relations == 0 {
            return;
        }

        let mut rng = Random::seed(self.base.config.seed.unwrap_or_else(|| {
            use std::time::{SystemTime, UNIX_EPOCH};
            SystemTime::now()
                .duration_since(UNIX_EPOCH)
                .expect("SystemTime should be after UNIX_EPOCH")
                .as_secs()
        }));

        // Initialize entity embeddings with Xavier initialization
        self.entity_embeddings = xavier_init(
            (num_entities, self.entity_dim),
            self.entity_dim,
            self.entity_dim,
            &mut rng,
        );

        // Initialize relation embeddings with Xavier initialization
        self.relation_embeddings = xavier_init(
            (num_relations, self.relation_dim),
            self.relation_dim,
            self.relation_dim,
            &mut rng,
        );

        // Initialize core tensor with Xavier initialization
        let total_elements = self.core_dims.0 * self.core_dims.1 * self.core_dims.2;
        let std_dev = (2.0 / total_elements as f64).sqrt();

        for elem in self.core_tensor.iter_mut() {
            *elem = rng.random_range(-std_dev..std_dev);
        }

        // Normalize embeddings
        normalize_embeddings(&mut self.entity_embeddings);
        normalize_embeddings(&mut self.relation_embeddings);

        self.embeddings_initialized = true;
        debug!(
            "Initialized TuckER embeddings: {} entities ({}D), {} relations ({}D), core tensor {:?}",
            num_entities, self.entity_dim, num_relations, self.relation_dim, self.core_dims
        );
    }

    /// Score a triple using TuckER scoring function
    fn score_triple_ids(
        &self,
        subject_id: usize,
        predicate_id: usize,
        object_id: usize,
    ) -> Result<f64> {
        if !self.embeddings_initialized {
            return Err(anyhow!("Model not trained"));
        }

        let h = self.entity_embeddings.row(subject_id);
        let r = self.relation_embeddings.row(predicate_id);
        let t = self.entity_embeddings.row(object_id);

        // Compute Tucker decomposition score
        // score = Σ_i,j,k h_i * r_j * t_k * W_ijk
        let mut score = 0.0;

        for i in 0..self.core_dims.0.min(h.len()) {
            for j in 0..self.core_dims.1.min(r.len()) {
                for k in 0..self.core_dims.2.min(t.len()) {
                    score += h[i] * r[j] * t[k] * self.core_tensor[(i, j, k)];
                }
            }
        }

        Ok(score)
    }

    /// Compute gradients for Tucker decomposition
    fn compute_gradients(
        &self,
        pos_triple: (usize, usize, usize),
        neg_triple: (usize, usize, usize),
        _learning_rate: f64,
    ) -> Result<(Array2<f64>, Array2<f64>, Array3<f64>)> {
        let (pos_s, pos_p, pos_o) = pos_triple;
        let (neg_s, neg_p, neg_o) = neg_triple;

        let mut entity_grads = Array2::zeros(self.entity_embeddings.raw_dim());
        let mut relation_grads = Array2::zeros(self.relation_embeddings.raw_dim());
        let mut core_grads = Array3::zeros(self.core_tensor.raw_dim());

        // Compute scores
        let pos_score = self.score_triple_ids(pos_s, pos_p, pos_o)?;
        let neg_score = self.score_triple_ids(neg_s, neg_p, neg_o)?;

        // Logistic loss gradient
        let pos_sigmoid = 1.0 / (1.0 + (-pos_score).exp());
        let neg_sigmoid = 1.0 / (1.0 + (-neg_score).exp());

        let pos_grad = pos_sigmoid - 1.0;
        let neg_grad = neg_sigmoid;

        // Compute gradients for positive triple
        self.compute_triple_gradients(
            pos_triple,
            pos_grad,
            &mut entity_grads,
            &mut relation_grads,
            &mut core_grads,
        );

        // Compute gradients for negative triple
        self.compute_triple_gradients(
            neg_triple,
            neg_grad,
            &mut entity_grads,
            &mut relation_grads,
            &mut core_grads,
        );

        Ok((entity_grads, relation_grads, core_grads))
    }

    /// Compute gradients for a single triple
    fn compute_triple_gradients(
        &self,
        triple: (usize, usize, usize),
        loss_grad: f64,
        entity_grads: &mut Array2<f64>,
        relation_grads: &mut Array2<f64>,
        core_grads: &mut Array3<f64>,
    ) {
        let (s, p, o) = triple;

        let h = self.entity_embeddings.row(s);
        let r = self.relation_embeddings.row(p);
        let t = self.entity_embeddings.row(o);

        // Gradients w.r.t. entity embeddings
        for i in 0..self.core_dims.0.min(h.len()) {
            let mut h_grad = 0.0;
            for j in 0..self.core_dims.1.min(r.len()) {
                for k in 0..self.core_dims.2.min(t.len()) {
                    h_grad += r[j] * t[k] * self.core_tensor[(i, j, k)];
                }
            }
            entity_grads[[s, i]] += loss_grad * h_grad;
        }

        for k in 0..self.core_dims.2.min(t.len()) {
            let mut t_grad = 0.0;
            for i in 0..self.core_dims.0.min(h.len()) {
                for j in 0..self.core_dims.1.min(r.len()) {
                    t_grad += h[i] * r[j] * self.core_tensor[(i, j, k)];
                }
            }
            entity_grads[[o, k]] += loss_grad * t_grad;
        }

        // Gradients w.r.t. relation embeddings
        for j in 0..self.core_dims.1.min(r.len()) {
            let mut r_grad = 0.0;
            for i in 0..self.core_dims.0.min(h.len()) {
                for k in 0..self.core_dims.2.min(t.len()) {
                    r_grad += h[i] * t[k] * self.core_tensor[(i, j, k)];
                }
            }
            relation_grads[[p, j]] += loss_grad * r_grad;
        }

        // Gradients w.r.t. core tensor
        for i in 0..self.core_dims.0.min(h.len()) {
            for j in 0..self.core_dims.1.min(r.len()) {
                for k in 0..self.core_dims.2.min(t.len()) {
                    core_grads[[i, j, k]] += loss_grad * h[i] * r[j] * t[k];
                }
            }
        }
    }

    /// Perform one training epoch
    async fn train_epoch(&mut self, learning_rate: f64) -> Result<f64> {
        let mut rng = Random::seed(self.base.config.seed.unwrap_or_else(|| {
            use std::time::{SystemTime, UNIX_EPOCH};
            SystemTime::now()
                .duration_since(UNIX_EPOCH)
                .expect("SystemTime should be after UNIX_EPOCH")
                .as_secs()
        }));

        let mut total_loss = 0.0;
        let num_batches = (self.base.triples.len() + self.base.config.batch_size - 1)
            / self.base.config.batch_size;

        // Create shuffled batches
        let mut shuffled_triples = self.base.triples.clone();
        shuffled_triples.shuffle(&mut rng);

        for batch_triples in shuffled_triples.chunks(self.base.config.batch_size) {
            let mut batch_entity_grads = Array2::zeros(self.entity_embeddings.raw_dim());
            let mut batch_relation_grads = Array2::zeros(self.relation_embeddings.raw_dim());
            let mut batch_core_grads = Array3::zeros(self.core_tensor.raw_dim());
            let mut batch_loss = 0.0;

            for &pos_triple in batch_triples {
                // Generate negative samples
                let neg_samples = self
                    .base
                    .generate_negative_samples(self.base.config.negative_samples, &mut rng);

                for neg_triple in neg_samples {
                    // Compute scores
                    let pos_score =
                        self.score_triple_ids(pos_triple.0, pos_triple.1, pos_triple.2)?;
                    let neg_score =
                        self.score_triple_ids(neg_triple.0, neg_triple.1, neg_triple.2)?;

                    // Logistic loss
                    let pos_loss = -(1.0 / (1.0 + (-pos_score).exp())).ln();
                    let neg_loss = -(1.0 / (1.0 + neg_score.exp())).ln();
                    let loss = pos_loss + neg_loss;
                    batch_loss += loss;

                    // Compute and accumulate gradients
                    let (entity_grads, relation_grads, core_grads) =
                        self.compute_gradients(pos_triple, neg_triple, learning_rate)?;

                    batch_entity_grads += &entity_grads;
                    batch_relation_grads += &relation_grads;
                    batch_core_grads += &core_grads;
                }
            }

            // Apply gradients with L2 regularization
            if batch_loss > 0.0 {
                gradient_update(
                    &mut self.entity_embeddings,
                    &batch_entity_grads,
                    learning_rate,
                    self.base.config.l2_reg,
                );

                gradient_update(
                    &mut self.relation_embeddings,
                    &batch_relation_grads,
                    learning_rate,
                    self.base.config.l2_reg,
                );

                // Update core tensor
                for ((_i, _j, _k), value) in self.core_tensor.indexed_iter_mut() {
                    // Note: We're not using batch_core_grads here as it's not properly aligned
                    // This is a simplified update that should be improved in the future
                    let reg_term = self.base.config.l2_reg * *value;
                    *value -= learning_rate * reg_term;
                }

                // Apply dropout to embeddings
                if self.dropout_rate > 0.0 {
                    apply_dropout(&mut self.entity_embeddings, self.dropout_rate, &mut rng);
                    apply_dropout(&mut self.relation_embeddings, self.dropout_rate, &mut rng);
                }

                // Normalize embeddings
                normalize_embeddings(&mut self.entity_embeddings);
                normalize_embeddings(&mut self.relation_embeddings);
            }

            total_loss += batch_loss;
        }

        Ok(total_loss / num_batches as f64)
    }
}

#[async_trait]
impl EmbeddingModel for TuckER {
    fn config(&self) -> &ModelConfig {
        &self.base.config
    }

    fn model_id(&self) -> &Uuid {
        &self.base.model_id
    }

    fn model_type(&self) -> &'static str {
        "TuckER"
    }

    fn add_triple(&mut self, triple: Triple) -> Result<()> {
        self.base.add_triple(triple)
    }

    async fn train(&mut self, epochs: Option<usize>) -> Result<TrainingStats> {
        let start_time = Instant::now();
        let max_epochs = epochs.unwrap_or(self.base.config.max_epochs);

        // Initialize embeddings if needed
        self.initialize_embeddings();

        if !self.embeddings_initialized {
            return Err(anyhow!("No training data available"));
        }

        let mut loss_history = Vec::new();
        let learning_rate = self.base.config.learning_rate;

        info!("Starting TuckER training for {} epochs", max_epochs);

        for epoch in 0..max_epochs {
            let epoch_loss = self.train_epoch(learning_rate).await?;
            loss_history.push(epoch_loss);

            if epoch % 100 == 0 {
                debug!("Epoch {}: loss = {:.6}", epoch, epoch_loss);
            }

            // Simple convergence check
            if epoch > 10 && epoch_loss < 1e-6 {
                info!("Converged at epoch {} with loss {:.6}", epoch, epoch_loss);
                break;
            }
        }

        self.base.mark_trained();
        let training_time = start_time.elapsed().as_secs_f64();

        Ok(TrainingStats {
            epochs_completed: loss_history.len(),
            final_loss: loss_history.last().copied().unwrap_or(0.0),
            training_time_seconds: training_time,
            convergence_achieved: loss_history.last().copied().unwrap_or(f64::INFINITY) < 1e-6,
            loss_history,
        })
    }

    fn get_entity_embedding(&self, entity: &str) -> Result<Vector> {
        if !self.embeddings_initialized {
            return Err(anyhow!("Model not trained"));
        }

        let entity_id = self
            .base
            .get_entity_id(entity)
            .ok_or_else(|| anyhow!("Entity not found: {}", entity))?;

        let embedding = self.entity_embeddings.row(entity_id).to_owned();
        Ok(ndarray_to_vector(&embedding))
    }

    fn get_relation_embedding(&self, relation: &str) -> Result<Vector> {
        if !self.embeddings_initialized {
            return Err(anyhow!("Model not trained"));
        }

        let relation_id = self
            .base
            .get_relation_id(relation)
            .ok_or_else(|| anyhow!("Relation not found: {}", relation))?;

        let embedding = self.relation_embeddings.row(relation_id).to_owned();
        Ok(ndarray_to_vector(&embedding))
    }

    fn score_triple(&self, subject: &str, predicate: &str, object: &str) -> Result<f64> {
        let subject_id = self
            .base
            .get_entity_id(subject)
            .ok_or_else(|| anyhow!("Subject not found: {}", subject))?;
        let predicate_id = self
            .base
            .get_relation_id(predicate)
            .ok_or_else(|| anyhow!("Predicate not found: {}", predicate))?;
        let object_id = self
            .base
            .get_entity_id(object)
            .ok_or_else(|| anyhow!("Object not found: {}", object))?;

        self.score_triple_ids(subject_id, predicate_id, object_id)
    }

    fn predict_objects(
        &self,
        subject: &str,
        predicate: &str,
        k: usize,
    ) -> Result<Vec<(String, f64)>> {
        if !self.embeddings_initialized {
            return Err(anyhow!("Model not trained"));
        }

        let subject_id = self
            .base
            .get_entity_id(subject)
            .ok_or_else(|| anyhow!("Subject not found: {}", subject))?;
        let predicate_id = self
            .base
            .get_relation_id(predicate)
            .ok_or_else(|| anyhow!("Predicate not found: {}", predicate))?;

        let mut scores = Vec::new();

        for object_id in 0..self.base.num_entities() {
            let score = self.score_triple_ids(subject_id, predicate_id, object_id)?;
            let object_name = self
                .base
                .get_entity(object_id)
                .expect("entity should exist for valid id")
                .clone();
            scores.push((object_name, score));
        }

        scores.sort_by(|a, b| b.1.partial_cmp(&a.1).unwrap_or(std::cmp::Ordering::Equal));
        scores.truncate(k);

        Ok(scores)
    }

    fn predict_subjects(
        &self,
        predicate: &str,
        object: &str,
        k: usize,
    ) -> Result<Vec<(String, f64)>> {
        if !self.embeddings_initialized {
            return Err(anyhow!("Model not trained"));
        }

        let predicate_id = self
            .base
            .get_relation_id(predicate)
            .ok_or_else(|| anyhow!("Predicate not found: {}", predicate))?;
        let object_id = self
            .base
            .get_entity_id(object)
            .ok_or_else(|| anyhow!("Object not found: {}", object))?;

        let mut scores = Vec::new();

        for subject_id in 0..self.base.num_entities() {
            let score = self.score_triple_ids(subject_id, predicate_id, object_id)?;
            let subject_name = self
                .base
                .get_entity(subject_id)
                .expect("entity should exist for valid id")
                .clone();
            scores.push((subject_name, score));
        }

        scores.sort_by(|a, b| b.1.partial_cmp(&a.1).unwrap_or(std::cmp::Ordering::Equal));
        scores.truncate(k);

        Ok(scores)
    }

    fn predict_relations(
        &self,
        subject: &str,
        object: &str,
        k: usize,
    ) -> Result<Vec<(String, f64)>> {
        if !self.embeddings_initialized {
            return Err(anyhow!("Model not trained"));
        }

        let subject_id = self
            .base
            .get_entity_id(subject)
            .ok_or_else(|| anyhow!("Subject not found: {}", subject))?;
        let object_id = self
            .base
            .get_entity_id(object)
            .ok_or_else(|| anyhow!("Object not found: {}", object))?;

        let mut scores = Vec::new();

        for predicate_id in 0..self.base.num_relations() {
            let score = self.score_triple_ids(subject_id, predicate_id, object_id)?;
            let predicate_name = self
                .base
                .get_relation(predicate_id)
                .expect("relation should exist for valid id")
                .clone();
            scores.push((predicate_name, score));
        }

        scores.sort_by(|a, b| b.1.partial_cmp(&a.1).unwrap_or(std::cmp::Ordering::Equal));
        scores.truncate(k);

        Ok(scores)
    }

    fn get_entities(&self) -> Vec<String> {
        self.base.get_entities()
    }

    fn get_relations(&self) -> Vec<String> {
        self.base.get_relations()
    }

    fn get_stats(&self) -> ModelStats {
        self.base.get_stats("TuckER")
    }

    fn save(&self, path: &str) -> Result<()> {
        info!("Saving TuckER model to {}", path);
        Ok(())
    }

    fn load(&mut self, path: &str) -> Result<()> {
        info!("Loading TuckER model from {}", path);
        Ok(())
    }

    fn clear(&mut self) {
        self.base.clear();
        self.entity_embeddings = Array2::zeros((0, self.entity_dim));
        self.relation_embeddings = Array2::zeros((0, self.relation_dim));
        self.core_tensor = Array3::zeros(self.core_dims);
        self.embeddings_initialized = false;
    }

    fn is_trained(&self) -> bool {
        self.base.is_trained
    }

    async fn encode(&self, _texts: &[String]) -> Result<Vec<Vec<f32>>> {
        Err(anyhow!(
            "Knowledge graph embedding model does not support text encoding"
        ))
    }
}

/// Apply dropout to embeddings
fn apply_dropout<R: Rng>(embeddings: &mut Array2<f64>, dropout_rate: f64, rng: &mut Random<R>) {
    for elem in embeddings.iter_mut() {
        if rng.random::<f64>() < dropout_rate {
            *elem = 0.0;
        } else {
            *elem /= 1.0 - dropout_rate;
        }
    }
}

#[cfg(test)]
mod tests {
    use super::*;
    use crate::NamedNode;

    #[tokio::test]
    #[cfg_attr(debug_assertions, ignore = "Training tests require release builds")]
    async fn test_tucker_basic() -> Result<()> {
        let mut config = ModelConfig::default()
            .with_dimensions(50)
            .with_max_epochs(10)
            .with_seed(42);

        // Add TuckER-specific parameters
        config.model_params.insert("entity_dim".to_string(), 50.0);
        config.model_params.insert("relation_dim".to_string(), 50.0);
        config.model_params.insert("core_dim1".to_string(), 50.0);
        config.model_params.insert("core_dim2".to_string(), 50.0);
        config.model_params.insert("core_dim3".to_string(), 50.0);
        config.model_params.insert("dropout_rate".to_string(), 0.1);

        let mut model = TuckER::new(config);

        // Add test triples
        let alice = NamedNode::new("http://example.org/alice")?;
        let knows = NamedNode::new("http://example.org/knows")?;
        let bob = NamedNode::new("http://example.org/bob")?;

        model.add_triple(Triple::new(alice.clone(), knows.clone(), bob.clone()))?;
        model.add_triple(Triple::new(bob.clone(), knows.clone(), alice.clone()))?;

        // Train
        let stats = model.train(Some(5)).await?;
        assert!(stats.epochs_completed > 0);

        // Test embeddings
        let alice_emb = model.get_entity_embedding("http://example.org/alice")?;
        assert_eq!(alice_emb.dimensions, 50);

        // Test scoring
        let score = model.score_triple(
            "http://example.org/alice",
            "http://example.org/knows",
            "http://example.org/bob",
        )?;

        // Score should be a finite number
        assert!(score.is_finite());

        Ok(())
    }

    #[test]
    fn test_tucker_creation() {
        let config = ModelConfig::default();
        let tucker = TuckER::new(config);
        assert!(!tucker.embeddings_initialized);
        assert_eq!(tucker.model_type(), "TuckER");
    }
}