oxirs-arq 0.3.1

Jena-style SPARQL algebra with extension points and query optimization
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
//! Federation-aware query planning pass.
//!
//! This pass rewrites a SPARQL algebra so that triple patterns whose subject,
//! predicate, or object IRI sits inside a *known federated dataset namespace*
//! get wrapped in [`Algebra::Service`] nodes that delegate to the appropriate
//! remote SPARQL endpoint.
//!
//! The pass is dependency-light: it operates against a [`SourceSelectivityProvider`]
//! trait that downstream callers (typically `oxirs-federate`) can implement.
//! This keeps `oxirs-arq` decoupled from the heavy federation runtime while
//! still letting the planner make federation-aware cost choices.
//!
//! # Concept
//!
//! Given a query like:
//!
//! ```sparql
//! SELECT ?s ?o WHERE {
//!     ?s <http://example.com/dbpedia/property> ?o .
//! }
//! ```
//!
//! and a registered federated dataset for the namespace `http://example.com/dbpedia/`,
//! the planner will rewrite the BGP into:
//!
//! ```text
//! Service { endpoint = "https://dbpedia.org/sparql", pattern = Bgp([..]), silent = false }
//! ```
//!
//! At execution time the [`crate::executor::QueryExecutor`] hands such
//! `Service` nodes off to the federation runtime (typically
//! `oxirs-federate::endpoint_client`).
//!
//! # Cost Model
//!
//! The pass also feeds the registered cost model: each `Service` node costs
//! the round-trip overhead of a federated call plus the source's reported
//! selectivity for the BGP.  Adaptive plans can use feedback from
//! [`crate::optimizer::adaptive::AdaptiveStatsStore`] to re-issue patterns
//! against alternate endpoints if a source becomes slow or unreliable.

use std::collections::HashMap;
use std::sync::Arc;

use crate::algebra::{Algebra, Term, TriplePattern};
use oxirs_core::model::NamedNode;

// ─────────────────────────────────────────────────────────────────────────────
// Trait: SourceSelectivityProvider
// ─────────────────────────────────────────────────────────────────────────────

/// Estimated selectivity of a federated triple pattern at a particular source.
///
/// Lower numbers mean *more selective* (fewer matching results); higher numbers
/// mean *less selective* (more matching results).  The selectivity is used by
/// the cost model to choose between alternative federated sources.
#[derive(Debug, Clone, Copy, PartialEq)]
pub struct FederatedSelectivity {
    /// Estimated number of matching solutions (cardinality).
    pub estimated_cardinality: f64,
    /// Round-trip latency to the source, in milliseconds.
    pub estimated_latency_ms: f64,
    /// Confidence in the estimate, 0.0–1.0.  1.0 means "from VoID metadata",
    /// 0.5 means "from runtime feedback", 0.1 means "no information".
    pub confidence: f64,
}

impl Default for FederatedSelectivity {
    fn default() -> Self {
        // No information: treat as a moderately costly call.
        Self {
            estimated_cardinality: 1_000.0,
            estimated_latency_ms: 100.0,
            confidence: 0.1,
        }
    }
}

/// Bridge trait between the ARQ planner and the federation runtime.
///
/// Implementations describe (a) which IRI namespaces map to which endpoints
/// and (b) how to estimate per-pattern selectivity at each endpoint.
///
/// `oxirs-federate` provides a concrete impl backed by its
/// `source_selector::SourceSelector`; downstream embedders may also write
/// custom implementations to integrate with proprietary federation registries.
pub trait SourceSelectivityProvider: Send + Sync {
    /// Resolve an IRI to a federated endpoint URL, if any.
    ///
    /// A return value of `None` indicates the IRI is local to the current
    /// dataset and should not be federated.
    fn endpoint_for_iri(&self, iri: &NamedNode) -> Option<String>;

    /// Estimate selectivity of a triple pattern at a given endpoint.
    ///
    /// Implementations may consult VoID descriptions, ASK probes, or runtime
    /// feedback.  The default is a uniform "no information" estimate.
    fn pattern_selectivity(&self, endpoint: &str, pattern: &TriplePattern) -> FederatedSelectivity {
        let _ = (endpoint, pattern);
        FederatedSelectivity::default()
    }

    /// Whether the endpoint should use silent semantics (errors swallowed).
    fn silent_default(&self, endpoint: &str) -> bool {
        let _ = endpoint;
        false
    }
}

// ─────────────────────────────────────────────────────────────────────────────
// Static / in-memory provider — used for testing and as a basic registration
// surface for embedders without oxirs-federate.
// ─────────────────────────────────────────────────────────────────────────────

/// Lightweight in-memory implementation of [`SourceSelectivityProvider`].
///
/// Each registered entry maps an IRI namespace prefix to an endpoint URL with
/// an associated selectivity estimate.  Patterns whose IRIs share the prefix
/// are rewritten to delegate to that endpoint.
#[derive(Debug, Default, Clone)]
pub struct StaticSourceProvider {
    /// `prefix -> (endpoint, selectivity, silent)` entries.
    /// The longest matching prefix wins.
    entries: Vec<StaticSourceEntry>,
}

#[derive(Debug, Clone)]
struct StaticSourceEntry {
    prefix: String,
    endpoint: String,
    selectivity: FederatedSelectivity,
    silent: bool,
}

impl StaticSourceProvider {
    /// Create an empty provider.
    pub fn new() -> Self {
        Self::default()
    }

    /// Register a federated namespace.
    pub fn register(
        &mut self,
        prefix: impl Into<String>,
        endpoint: impl Into<String>,
        selectivity: FederatedSelectivity,
    ) -> &mut Self {
        self.entries.push(StaticSourceEntry {
            prefix: prefix.into(),
            endpoint: endpoint.into(),
            selectivity,
            silent: false,
        });
        self.sort_by_specificity();
        self
    }

    /// Register a federated namespace with `SILENT` semantics enabled.
    ///
    /// Errors from the remote endpoint will be swallowed at execution time.
    pub fn register_silent(
        &mut self,
        prefix: impl Into<String>,
        endpoint: impl Into<String>,
        selectivity: FederatedSelectivity,
    ) -> &mut Self {
        self.entries.push(StaticSourceEntry {
            prefix: prefix.into(),
            endpoint: endpoint.into(),
            selectivity,
            silent: true,
        });
        self.sort_by_specificity();
        self
    }

    /// Number of registered namespaces.
    pub fn len(&self) -> usize {
        self.entries.len()
    }

    /// Whether the provider is empty.
    pub fn is_empty(&self) -> bool {
        self.entries.is_empty()
    }

    fn sort_by_specificity(&mut self) {
        // Longest prefix first, so longer prefixes take precedence over shorter
        // ones.  Stable sort preserves registration order for equal-length
        // prefixes.
        self.entries
            .sort_by_key(|entry| std::cmp::Reverse(entry.prefix.len()));
    }

    fn lookup(&self, iri: &str) -> Option<&StaticSourceEntry> {
        self.entries.iter().find(|e| iri.starts_with(&e.prefix))
    }
}

impl SourceSelectivityProvider for StaticSourceProvider {
    fn endpoint_for_iri(&self, iri: &NamedNode) -> Option<String> {
        self.lookup(iri.as_str()).map(|e| e.endpoint.clone())
    }

    fn pattern_selectivity(&self, endpoint: &str, pattern: &TriplePattern) -> FederatedSelectivity {
        // Find the entry whose endpoint matches and the pattern shares an IRI
        // prefix.  If multiple entries map to the same endpoint, take the most
        // specific one (longest prefix); this is the first in entries due to
        // sort_by_specificity.
        for entry in &self.entries {
            if entry.endpoint != endpoint {
                continue;
            }
            if pattern_uses_prefix(pattern, &entry.prefix) {
                return entry.selectivity;
            }
        }
        FederatedSelectivity::default()
    }

    fn silent_default(&self, endpoint: &str) -> bool {
        self.entries
            .iter()
            .find(|e| e.endpoint == endpoint)
            .map(|e| e.silent)
            .unwrap_or(false)
    }
}

fn pattern_uses_prefix(pattern: &TriplePattern, prefix: &str) -> bool {
    pattern_term_uses_prefix(&pattern.subject, prefix)
        || pattern_term_uses_prefix(&pattern.predicate, prefix)
        || pattern_term_uses_prefix(&pattern.object, prefix)
}

fn pattern_term_uses_prefix(term: &Term, prefix: &str) -> bool {
    match term {
        Term::Iri(node) => node.as_str().starts_with(prefix),
        _ => false,
    }
}

// ─────────────────────────────────────────────────────────────────────────────
// FederatedPlanner — the actual rewriting pass
// ─────────────────────────────────────────────────────────────────────────────

/// Cost-based federation-aware query planner.
///
/// Walks an [`Algebra`] tree and rewrites BGPs whose triple patterns refer to
/// known federated datasets into [`Algebra::Service`] nodes.  Patterns that
/// resolve to multiple possible endpoints are routed to the source with the
/// best estimated cost (cardinality × latency / confidence).
pub struct FederatedPlanner {
    provider: Arc<dyn SourceSelectivityProvider>,
    /// Static cost weight balancing latency vs cardinality.  Higher values
    /// penalize slow endpoints more aggressively.
    latency_weight: f64,
}

impl FederatedPlanner {
    /// Create a new planner using the given source provider.
    pub fn new(provider: Arc<dyn SourceSelectivityProvider>) -> Self {
        Self {
            provider,
            latency_weight: 1.0,
        }
    }

    /// Override the latency cost weight (default 1.0).
    pub fn with_latency_weight(mut self, weight: f64) -> Self {
        self.latency_weight = weight;
        self
    }

    /// Apply the federated planning pass to `algebra`.
    ///
    /// Returns the rewritten algebra plus the set of endpoints touched (useful
    /// for downstream cost accounting and observability).
    pub fn plan(&self, algebra: Algebra) -> FederatedPlanOutcome {
        let mut report = PlanReport::default();
        let rewritten = self.rewrite(algebra, &mut report);
        FederatedPlanOutcome {
            algebra: rewritten,
            endpoints_used: report.endpoints,
            patterns_federated: report.patterns_federated,
        }
    }

    fn rewrite(&self, algebra: Algebra, report: &mut PlanReport) -> Algebra {
        match algebra {
            Algebra::Bgp(patterns) => self.rewrite_bgp(patterns, report),
            Algebra::Join { left, right } => Algebra::Join {
                left: Box::new(self.rewrite(*left, report)),
                right: Box::new(self.rewrite(*right, report)),
            },
            Algebra::LeftJoin {
                left,
                right,
                filter,
            } => Algebra::LeftJoin {
                left: Box::new(self.rewrite(*left, report)),
                right: Box::new(self.rewrite(*right, report)),
                filter,
            },
            Algebra::Union { left, right } => Algebra::Union {
                left: Box::new(self.rewrite(*left, report)),
                right: Box::new(self.rewrite(*right, report)),
            },
            Algebra::Filter { pattern, condition } => Algebra::Filter {
                pattern: Box::new(self.rewrite(*pattern, report)),
                condition,
            },
            Algebra::Extend {
                pattern,
                variable,
                expr,
            } => Algebra::Extend {
                pattern: Box::new(self.rewrite(*pattern, report)),
                variable,
                expr,
            },
            Algebra::Minus { left, right } => Algebra::Minus {
                left: Box::new(self.rewrite(*left, report)),
                right: Box::new(self.rewrite(*right, report)),
            },
            // Existing SERVICE nodes are passed through unchanged — we never
            // re-federate something that already names its endpoint.
            Algebra::Service {
                endpoint,
                pattern,
                silent,
            } => {
                if let Term::Iri(node) = &endpoint {
                    report.endpoints.insert(node.as_str().to_string(), 1);
                }
                Algebra::Service {
                    endpoint,
                    pattern,
                    silent,
                }
            }
            Algebra::Graph { graph, pattern } => Algebra::Graph {
                graph,
                pattern: Box::new(self.rewrite(*pattern, report)),
            },
            Algebra::Project { pattern, variables } => Algebra::Project {
                pattern: Box::new(self.rewrite(*pattern, report)),
                variables,
            },
            Algebra::Distinct { pattern } => Algebra::Distinct {
                pattern: Box::new(self.rewrite(*pattern, report)),
            },
            Algebra::Reduced { pattern } => Algebra::Reduced {
                pattern: Box::new(self.rewrite(*pattern, report)),
            },
            Algebra::Slice {
                pattern,
                offset,
                limit,
            } => Algebra::Slice {
                pattern: Box::new(self.rewrite(*pattern, report)),
                offset,
                limit,
            },
            Algebra::OrderBy {
                pattern,
                conditions,
            } => Algebra::OrderBy {
                pattern: Box::new(self.rewrite(*pattern, report)),
                conditions,
            },
            Algebra::Group {
                pattern,
                variables,
                aggregates,
            } => Algebra::Group {
                pattern: Box::new(self.rewrite(*pattern, report)),
                variables,
                aggregates,
            },
            Algebra::Having { pattern, condition } => Algebra::Having {
                pattern: Box::new(self.rewrite(*pattern, report)),
                condition,
            },
            // PropertyPath patterns are kept local — federation of property
            // paths requires endpoint capability negotiation that the
            // SourceSelectivityProvider abstraction does not currently model.
            other => other,
        }
    }

    fn rewrite_bgp(&self, patterns: Vec<TriplePattern>, report: &mut PlanReport) -> Algebra {
        if patterns.is_empty() {
            return Algebra::Bgp(patterns);
        }

        // Group patterns by the endpoint we want to ship them to.  Patterns
        // whose IRIs do not match any registered namespace stay in the
        // `local` bucket.
        let mut local: Vec<TriplePattern> = Vec::new();
        let mut federated: HashMap<String, Vec<TriplePattern>> = HashMap::new();

        for pattern in patterns {
            match self.choose_endpoint(&pattern) {
                Some(endpoint) => {
                    federated.entry(endpoint).or_default().push(pattern);
                }
                None => local.push(pattern),
            }
        }

        if federated.is_empty() {
            // Nothing to federate — pass through.
            return Algebra::Bgp(local);
        }

        // Build the rewritten algebra: chain Joins of (local BGP) ⋈ (per-endpoint
        // SERVICE BGPs).  Order by endpoint cost so the cheapest one is
        // joined first, giving the executor more pruning leverage.
        let mut services: Vec<(String, Vec<TriplePattern>, f64)> = federated
            .into_iter()
            .map(|(endpoint, patterns)| {
                let cost = self.endpoint_cost(&endpoint, &patterns);
                (endpoint, patterns, cost)
            })
            .collect();
        services.sort_by(|a, b| a.2.partial_cmp(&b.2).unwrap_or(std::cmp::Ordering::Equal));

        // Track patterns_federated for the outcome report.
        report.patterns_federated += services.iter().map(|(_, p, _)| p.len()).sum::<usize>();
        for (endpoint, patterns, _) in &services {
            *report.endpoints.entry(endpoint.clone()).or_insert(0) += patterns.len();
        }

        let mut iter = services.into_iter().map(|(endpoint, patterns, _)| {
            let endpoint_node = NamedNode::new_unchecked(&endpoint);
            let silent = self.provider.silent_default(&endpoint);
            Algebra::Service {
                endpoint: Term::Iri(endpoint_node),
                pattern: Box::new(Algebra::Bgp(patterns)),
                silent,
            }
        });

        // Start with the cheapest service node (or local BGP, if any patterns
        // remained local), then join the rest in cost-ascending order.
        let mut current = if local.is_empty() {
            // SAFETY: we already checked federated.is_empty() above and
            // returned, so iter has at least one element.
            match iter.next() {
                Some(node) => node,
                None => Algebra::Bgp(Vec::new()),
            }
        } else {
            Algebra::Bgp(local)
        };

        for service in iter {
            current = Algebra::Join {
                left: Box::new(current),
                right: Box::new(service),
            };
        }

        current
    }

    fn choose_endpoint(&self, pattern: &TriplePattern) -> Option<String> {
        // Pick whichever IRI in the triple has the most specific endpoint
        // mapping.  Prefer predicate > subject > object since predicates are
        // typically the most discriminating.
        for term in [&pattern.predicate, &pattern.subject, &pattern.object] {
            if let Term::Iri(node) = term {
                if let Some(endpoint) = self.provider.endpoint_for_iri(node) {
                    return Some(endpoint);
                }
            }
        }
        None
    }

    fn endpoint_cost(&self, endpoint: &str, patterns: &[TriplePattern]) -> f64 {
        // Aggregate selectivity over all patterns shipped to this endpoint.
        // Cost = Σ(cardinality) + latency_weight × max(latency).
        let mut total_card = 0.0;
        let mut max_latency = 0.0f64;
        let mut min_confidence = 1.0f64;
        for pattern in patterns {
            let sel = self.provider.pattern_selectivity(endpoint, pattern);
            total_card += sel.estimated_cardinality;
            max_latency = max_latency.max(sel.estimated_latency_ms);
            min_confidence = min_confidence.min(sel.confidence);
        }
        // Adjust by inverse of confidence: low-confidence estimates carry a
        // small penalty so the planner prefers known-good sources.
        let confidence_penalty = if min_confidence > 0.0 {
            1.0 / min_confidence
        } else {
            10.0
        };
        (total_card + self.latency_weight * max_latency) * confidence_penalty.sqrt()
    }
}

// ─────────────────────────────────────────────────────────────────────────────
// Outcome / report
// ─────────────────────────────────────────────────────────────────────────────

/// Result of running [`FederatedPlanner::plan`].
#[derive(Debug, Clone)]
pub struct FederatedPlanOutcome {
    /// The rewritten algebra.
    pub algebra: Algebra,
    /// Map of endpoint URL → number of patterns shipped to it.
    pub endpoints_used: HashMap<String, usize>,
    /// Total number of triple patterns federated (sum across endpoints).
    pub patterns_federated: usize,
}

impl FederatedPlanOutcome {
    /// Whether the rewrite emitted any federated nodes.
    pub fn touched_federation(&self) -> bool {
        self.patterns_federated > 0
    }
}

#[derive(Debug, Default)]
struct PlanReport {
    endpoints: HashMap<String, usize>,
    patterns_federated: usize,
}

// ─────────────────────────────────────────────────────────────────────────────
// Tests
// ─────────────────────────────────────────────────────────────────────────────

#[cfg(test)]
mod tests {
    use super::*;
    use crate::algebra::{Term, TriplePattern, Variable};

    fn iri(s: &str) -> Term {
        Term::Iri(NamedNode::new_unchecked(s))
    }

    fn var(name: &str) -> Term {
        Term::Variable(Variable::new(name).expect("valid variable name"))
    }

    fn pattern(s: Term, p: Term, o: Term) -> TriplePattern {
        TriplePattern {
            subject: s,
            predicate: p,
            object: o,
        }
    }

    fn dbpedia_provider() -> StaticSourceProvider {
        let mut provider = StaticSourceProvider::new();
        provider.register(
            "http://dbpedia.org/",
            "https://dbpedia.org/sparql",
            FederatedSelectivity {
                estimated_cardinality: 100.0,
                estimated_latency_ms: 80.0,
                confidence: 0.9,
            },
        );
        provider
    }

    #[test]
    fn test_pattern_with_known_predicate_emits_service() {
        let provider = Arc::new(dbpedia_provider());
        let planner = FederatedPlanner::new(provider);

        let alg = Algebra::Bgp(vec![pattern(
            var("s"),
            iri("http://dbpedia.org/property/birthDate"),
            var("o"),
        )]);

        let outcome = planner.plan(alg);
        assert!(outcome.touched_federation());
        assert_eq!(outcome.patterns_federated, 1);
        assert!(outcome
            .endpoints_used
            .contains_key("https://dbpedia.org/sparql"));
        match outcome.algebra {
            Algebra::Service { endpoint, .. } => match endpoint {
                Term::Iri(node) => assert_eq!(node.as_str(), "https://dbpedia.org/sparql"),
                other => panic!("expected IRI endpoint, got {other:?}"),
            },
            other => panic!("expected Service node, got {other:?}"),
        }
    }

    #[test]
    fn test_local_only_pattern_passes_through() {
        let provider = Arc::new(dbpedia_provider());
        let planner = FederatedPlanner::new(provider);

        let alg = Algebra::Bgp(vec![pattern(
            iri("http://example.org/local/alice"),
            iri("http://example.org/local/knows"),
            var("friend"),
        )]);

        let outcome = planner.plan(alg.clone());
        assert!(!outcome.touched_federation());
        assert_eq!(outcome.algebra, alg);
    }

    #[test]
    fn test_mixed_local_and_federated_emits_join() {
        let provider = Arc::new(dbpedia_provider());
        let planner = FederatedPlanner::new(provider);

        let alg = Algebra::Bgp(vec![
            pattern(
                var("s"),
                iri("http://example.org/local/labelOf"),
                var("label"),
            ),
            pattern(
                var("s"),
                iri("http://dbpedia.org/property/birthDate"),
                var("date"),
            ),
        ]);

        let outcome = planner.plan(alg);
        assert!(outcome.touched_federation());
        assert_eq!(outcome.patterns_federated, 1);
        // Result should be Join { local-BGP, Service { ... } }
        match outcome.algebra {
            Algebra::Join { left, right } => {
                assert!(matches!(*left, Algebra::Bgp(_)));
                assert!(matches!(*right, Algebra::Service { .. }));
            }
            other => panic!("expected Join, got {other:?}"),
        }
    }

    #[test]
    fn test_two_federations_join_in_cost_order() {
        let mut provider = StaticSourceProvider::new();
        // Cheaper source: small cardinality, low latency.
        provider.register(
            "http://cheap.example/",
            "https://cheap.example/sparql",
            FederatedSelectivity {
                estimated_cardinality: 10.0,
                estimated_latency_ms: 20.0,
                confidence: 0.9,
            },
        );
        // Expensive source: large cardinality, high latency.
        provider.register(
            "http://pricy.example/",
            "https://pricy.example/sparql",
            FederatedSelectivity {
                estimated_cardinality: 10_000.0,
                estimated_latency_ms: 500.0,
                confidence: 0.9,
            },
        );

        let planner = FederatedPlanner::new(Arc::new(provider));

        let alg = Algebra::Bgp(vec![
            pattern(
                var("s"),
                iri("http://pricy.example/data#predicate"),
                var("o1"),
            ),
            pattern(
                var("s"),
                iri("http://cheap.example/data#predicate"),
                var("o2"),
            ),
        ]);

        let outcome = planner.plan(alg);
        assert_eq!(outcome.patterns_federated, 2);

        // Top-level should be a Join. Cheaper endpoint (lowest cost) should
        // be the left operand.
        match outcome.algebra {
            Algebra::Join { left, right } => {
                let extract_endpoint = |alg: &Algebra| -> Option<String> {
                    if let Algebra::Service {
                        endpoint: Term::Iri(node),
                        ..
                    } = alg
                    {
                        return Some(node.as_str().to_string());
                    }
                    None
                };
                let left_ep = extract_endpoint(&left);
                let right_ep = extract_endpoint(&right);
                assert_eq!(left_ep.as_deref(), Some("https://cheap.example/sparql"));
                assert_eq!(right_ep.as_deref(), Some("https://pricy.example/sparql"));
            }
            other => panic!("expected Join, got {other:?}"),
        }
    }

    #[test]
    fn test_silent_default_propagates() {
        let mut provider = StaticSourceProvider::new();
        provider.register_silent(
            "http://flaky.example/",
            "https://flaky.example/sparql",
            FederatedSelectivity::default(),
        );
        let planner = FederatedPlanner::new(Arc::new(provider));

        let alg = Algebra::Bgp(vec![pattern(
            var("s"),
            iri("http://flaky.example/data#p"),
            var("o"),
        )]);

        let outcome = planner.plan(alg);
        match outcome.algebra {
            Algebra::Service { silent, .. } => assert!(silent),
            other => panic!("expected Service, got {other:?}"),
        }
    }

    #[test]
    fn test_pre_existing_service_passes_through() {
        let provider = Arc::new(dbpedia_provider());
        let planner = FederatedPlanner::new(provider);

        let original = Algebra::Service {
            endpoint: iri("https://other.example/sparql"),
            pattern: Box::new(Algebra::Bgp(vec![pattern(
                var("s"),
                iri("http://example.org/local/p"),
                var("o"),
            )])),
            silent: true,
        };

        let outcome = planner.plan(original.clone());
        assert_eq!(outcome.algebra, original);
        assert!(outcome
            .endpoints_used
            .contains_key("https://other.example/sparql"));
    }

    #[test]
    fn test_recursive_into_filter() {
        let provider = Arc::new(dbpedia_provider());
        let planner = FederatedPlanner::new(provider);

        let inner = Algebra::Bgp(vec![pattern(
            var("s"),
            iri("http://dbpedia.org/property/birthDate"),
            var("o"),
        )]);
        let alg = Algebra::Filter {
            pattern: Box::new(inner),
            condition: crate::algebra::Expression::Variable(
                Variable::new("o").expect("valid variable"),
            ),
        };

        let outcome = planner.plan(alg);
        assert!(outcome.touched_federation());
        assert!(matches!(
            outcome.algebra,
            Algebra::Filter {
                pattern: _,
                condition: _,
            }
        ));
    }

    #[test]
    fn test_static_source_provider_longest_prefix_wins() {
        let mut provider = StaticSourceProvider::new();
        provider.register(
            "http://example.org/",
            "https://wide.example/sparql",
            FederatedSelectivity::default(),
        );
        provider.register(
            "http://example.org/specific/",
            "https://narrow.example/sparql",
            FederatedSelectivity::default(),
        );

        let iri_specific = NamedNode::new_unchecked("http://example.org/specific/foo");
        let iri_wide = NamedNode::new_unchecked("http://example.org/foo");
        assert_eq!(
            provider.endpoint_for_iri(&iri_specific).as_deref(),
            Some("https://narrow.example/sparql")
        );
        assert_eq!(
            provider.endpoint_for_iri(&iri_wide).as_deref(),
            Some("https://wide.example/sparql")
        );
    }

    #[test]
    fn test_outcome_default() {
        let outcome = FederatedPlanOutcome {
            algebra: Algebra::Bgp(vec![]),
            endpoints_used: HashMap::new(),
            patterns_federated: 0,
        };
        assert!(!outcome.touched_federation());
    }
}