oxipage-core 0.4.0

Oxipage 코어 라이브러리 — Axum 서버 부트스트랩, SQLite 마이그레이션, Extension trait, SSR 스냅샷, 레이트리밋
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368

//! Setup wizard Extension hook integration tests.
//!
//! `Extension` trait의 `setup_wizard_step` / `external_api_keys` /
//! `seed_sample_data` hook이 setup API와 제대로 통합되는지 검증.
//! 코어가 도메인 필드를 모른다 — 확장이 자기 데이터를 제공한다.

use async_trait::async_trait;
use axum::body::Body;
use axum::http::{Request, StatusCode};
use oxipage_core::config::Config;
use oxipage_core::extension::{
    Extension, ExternalApiKey, ExternalKeyScope, Lang, LobbyCard, Migration, SetupField,
    SetupFieldKind, SetupSaveHandler, SetupStep,
};
use oxipage_core::registry::ExtensionRegistry;
use oxipage_core::state::AppState;
use std::sync::Arc;
use tower::ServiceExt;

// ─── 테스트용 확장 ────────────────────────────────────────

struct DemoExt {
    step_id: &'static str,
}

struct DemoSaveHandler;

#[async_trait]
impl SetupSaveHandler for DemoSaveHandler {
    async fn save(
        &self,
        _ctx: &AppState,
        _form: &serde_json::Map<String, serde_json::Value>,
    ) -> anyhow::Result<()> {
        Ok(())
    }
}

#[async_trait]
impl Extension for DemoExt {
    fn id(&self) -> &'static str {
        "demo"
    }
    fn display_name(&self, lang: Lang) -> String {
        match lang {
            Lang::Ko => "데모".to_string(),
            Lang::En => "Demo".to_string(),
        }
    }
    fn migrations(&self) -> Vec<Migration> {
        vec![Migration {
            version: 1,
            name: "init",
            sql: "CREATE TABLE IF NOT EXISTS demo_t (id INTEGER PRIMARY KEY, name TEXT)",
        }]
    }
    fn table_names(&self) -> Vec<&'static str> {
        vec!["demo_t"]
    }
    fn routes(&self) -> axum::Router<AppState> {
        axum::Router::new()
    }
    async fn lobby_summary(&self, _ctx: &AppState) -> Option<LobbyCard> {
        None
    }
    fn setup_wizard_step(&self) -> Option<SetupStep> {
        Some(SetupStep {
            id: self.step_id,
            title_ko: "데모 step",
            title_en: "Demo step",
            description_ko: "데모 step 설명",
            description_en: "Demo step description",
            fields: vec![SetupField {
                name: "name",
                label_ko: "이름",
                label_en: "Name",
                kind: SetupFieldKind::Text,
                required: true,
                placeholder_ko: None,
                placeholder_en: None,
            }],
            save_handler: Arc::new(DemoSaveHandler),
            prefill: std::collections::BTreeMap::new(),
        })
    }
    fn external_api_keys(&self) -> Vec<ExternalApiKey> {
        vec![ExternalApiKey {
            id: "demo_key",
            label_ko: "데모 키",
            label_en: "Demo key",
            env_var: "OXIPAGE_DEMO_KEY",
            required: false,
            scope: ExternalKeyScope::EnvOnly,
        }]
    }
    async fn seed_sample_data(&self, _ctx: &AppState) -> anyhow::Result<()> {
        Ok(())
    }
}

struct KeyOnlyExt;

#[async_trait]
impl Extension for KeyOnlyExt {
    fn id(&self) -> &'static str {
        "key_only"
    }
    fn display_name(&self, lang: Lang) -> String {
        match lang {
            Lang::Ko => "키온리".to_string(),
            Lang::En => "KeyOnly".to_string(),
        }
    }
    fn migrations(&self) -> Vec<Migration> {
        vec![]
    }
    fn table_names(&self) -> Vec<&'static str> {
        vec![]
    }
    fn routes(&self) -> axum::Router<AppState> {
        axum::Router::new()
    }
    async fn lobby_summary(&self, _ctx: &AppState) -> Option<LobbyCard> {
        None
    }
    fn external_api_keys(&self) -> Vec<ExternalApiKey> {
        vec![ExternalApiKey {
            id: "alpha",
            label_ko: "알파",
            label_en: "Alpha",
            env_var: "OXIPAGE_ALPHA",
            required: false,
            scope: ExternalKeyScope::EnvOnly,
        }]
    }
}
/// build_app 결과 router에 loopback `ConnectInfo<SocketAddr>`를 주입.
/// setup_gate 미들웨어가 loopback 검증에 의존하므로 테스트에서 필요.
async fn inject_loopback(
    mut req: Request<Body>,
    next: axum::middleware::Next,
) -> axum::response::Response {
    let addr: std::net::SocketAddr = "127.0.0.1:12345".parse().unwrap();
    req.extensions_mut()
        .insert(axum::extract::ConnectInfo(addr));
    next.run(req).await
}

fn with_loopback(router: axum::Router) -> axum::Router {
    router.layer(axum::middleware::from_fn(inject_loopback))
}

async fn build_app_with_toml_enabled(
    extensions: Vec<Arc<dyn Extension>>,
    toml_enabled: &[String],
) -> axum::Router {
    let pool = oxipage_core::db::connect_memory().await.unwrap();
    let registry = Arc::new(ExtensionRegistry::new(extensions));
    registry.run_migrations(&pool, toml_enabled).await.unwrap();
    let state = AppState {
        db: pool,
        config: Arc::new(Config::default()),
        registry,
        wasm_loader: None,
        site_override: Arc::new(tokio::sync::RwLock::new(None)),
        builders: Arc::new(vec![]),
    };
    with_loopback(oxipage_core::http::build_app(state))
}
async fn build_app(extensions: Vec<Arc<dyn Extension>>) -> axum::Router {
    let pool = oxipage_core::db::connect_memory().await.unwrap();
    let registry = Arc::new(ExtensionRegistry::new(extensions));
    registry.run_migrations(&pool, &[]).await.unwrap();
    let state = AppState {
        db: pool,
        config: Arc::new(Config::default()),
        registry,
        wasm_loader: None,
        site_override: Arc::new(tokio::sync::RwLock::new(None)),
        builders: Arc::new(vec![]),
    };
    with_loopback(oxipage_core::http::build_app(state))
}

#[tokio::test]
async fn unknown_step_returns_404() {
    let app = build_app(vec![Arc::new(DemoExt { step_id: "demo" })]).await;
    let res = app
        .oneshot(
            Request::post("/api/console/setup/extension-step/missing")
                .header("content-type", "application/json")
                .body(Body::from("{}"))
                .unwrap(),
        )
        .await
        .unwrap();
    assert_eq!(res.status(), StatusCode::NOT_FOUND);
}

#[tokio::test]
async fn setup_status_includes_extension_steps() {
    let app = build_app(vec![Arc::new(DemoExt { step_id: "demo" })]).await;
    let res = app
        .oneshot(
            Request::get("/api/console/setup/status")
                .body(Body::empty())
                .unwrap(),
        )
        .await
        .unwrap();
    assert_eq!(res.status(), StatusCode::OK);
    let body = axum::body::to_bytes(res.into_body(), usize::MAX)
        .await
        .unwrap();
    let json: serde_json::Value = serde_json::from_slice(&body).unwrap();
    let steps = json["data"]["extension_steps"].as_array().unwrap();
    assert_eq!(steps.len(), 1);
    assert_eq!(steps[0]["id"], "demo");
    assert_eq!(steps[0]["title_ko"], "데모 step");
    assert_eq!(steps[0]["fields"][0]["name"], "name");
    // SetupFieldKind가 flatten되어야 클라이언트가 `field.type`로 직접 읽을 수 있다.
    // (bug 회귀: nested {kind:{type:...}} 직렬화 시 textarea가 input으로 렌더됨.)
    let field = &steps[0]["fields"][0];
    assert_eq!(
        field["type"], "text",
        "SetupFieldKind must serialize as top-level `type`"
    );
    assert!(
        field.get("kind").is_none(),
        "SetupFieldKind must be flattened, not nested under `kind`"
    );
}

#[tokio::test]
async fn setup_status_includes_external_api_keys() {
    let app = build_app(vec![
        Arc::new(DemoExt { step_id: "demo" }),
        Arc::new(KeyOnlyExt),
    ])
    .await;
    let res = app
        .oneshot(
            Request::get("/api/console/setup/status")
                .body(Body::empty())
                .unwrap(),
        )
        .await
        .unwrap();
    let body = axum::body::to_bytes(res.into_body(), usize::MAX)
        .await
        .unwrap();
    let json: serde_json::Value = serde_json::from_slice(&body).unwrap();
    let keys = json["data"]["external_api_keys"].as_array().unwrap();
    let ids: Vec<&str> = keys.iter().map(|k| k["id"].as_str().unwrap()).collect();
    assert!(ids.contains(&"demo_key"));
    assert!(ids.contains(&"alpha"));
}

#[tokio::test]
async fn external_keys_handler_dispatches_to_extension() {
    let app = build_app(vec![Arc::new(DemoExt { step_id: "demo" })]).await;
    let res = app
        .oneshot(
            Request::post("/api/console/setup/external-keys")
                .header("content-type", "application/json")
                .body(Body::from(r#"{"values":{"demo_key":"secret"}}"#))
                .unwrap(),
        )
        .await
        .unwrap();
    assert_eq!(res.status(), StatusCode::OK);
    // env var가 process env에 set되었는지 확인 (EnvOnly scope)
    assert_eq!(
        std::env::var("OXIPAGE_DEMO_KEY").ok().as_deref(),
        Some("secret"),
    );
}

/// 미활성 확장은 extension_steps/external_api_keys에서 제외되어야 한다.
/// (P2 §is_active gate 회귀 테스트 — 이 게이트를 제거하면 모든 테스트가 그대로 통과한다.)
#[tokio::test]
async fn disabled_extension_excluded_from_status() {
    // demo 비활성, key_only만 활성.
    let app = build_app_with_toml_enabled(
        vec![Arc::new(DemoExt { step_id: "demo" }), Arc::new(KeyOnlyExt)],
        &["key_only".to_string()],
    )
    .await;
    let res = app
        .oneshot(
            Request::get("/api/console/setup/status")
                .body(Body::empty())
                .unwrap(),
        )
        .await
        .unwrap();
    let body = axum::body::to_bytes(res.into_body(), usize::MAX)
        .await
        .unwrap();
    let json: serde_json::Value = serde_json::from_slice(&body).unwrap();
    let steps = json["data"]["extension_steps"].as_array().unwrap();
    let step_ids: Vec<&str> = steps.iter().map(|s| s["id"].as_str().unwrap()).collect();
    assert!(
        !step_ids.contains(&"demo"),
        "disabled extension's step must be excluded, got: {step_ids:?}"
    );
    let keys = json["data"]["external_api_keys"].as_array().unwrap();
    let key_ids: Vec<&str> = keys.iter().map(|k| k["id"].as_str().unwrap()).collect();
    assert!(
        !key_ids.contains(&"demo_key"),
        "disabled extension's key must be excluded, got: {key_ids:?}"
    );
    assert!(
        key_ids.contains(&"alpha"),
        "active extension's key must remain"
    );
}

/// disable된 확장의 extension-step POST는 404로 거부되어야 한다.
#[tokio::test]
async fn disabled_extension_step_returns_404() {
    let app = build_app_with_toml_enabled(
        vec![Arc::new(DemoExt { step_id: "demo" }), Arc::new(KeyOnlyExt)],
        &["key_only".to_string()],
    )
    .await;
    let res = app
        .oneshot(
            Request::post("/api/console/setup/extension-step/demo")
                .header("content-type", "application/json")
                .body(Body::from("{}"))
                .unwrap(),
        )
        .await
        .unwrap();
    // setup 단계에서 disabled 확장은 step 자체가 노출 안 되고 직접 POST도 거부됨.
    assert_eq!(res.status(), StatusCode::NOT_FOUND);
}

/// external_keys POST는 disabled 확장의 키를 침묵히 무시해야 한다.
/// (admin이 실수로 구 키를 보내도 안전.)
#[tokio::test]
async fn external_keys_ignores_disabled_extension_keys() {
    let app = build_app_with_toml_enabled(
        vec![Arc::new(DemoExt { step_id: "demo" }), Arc::new(KeyOnlyExt)],
        &["key_only".to_string()],
    )
    .await;
    let res = app
        .oneshot(
            Request::post("/api/console/setup/external-keys")
                .header("content-type", "application/json")
                .body(Body::from(
                    r#"{"values":{"demo_key":"should-be-ignored","alpha":"kept"}}"#,
                ))
                .unwrap(),
        )
        .await
        .unwrap();
    assert_eq!(res.status(), StatusCode::OK);
    // demo_key (disabled): env 안 바뀌어야 함.
    assert_ne!(
        std::env::var("OXIPAGE_DEMO_KEY").ok().as_deref(),
        Some("should-be-ignored")
    );
    // alpha (active): env에 저장됨.
    assert_eq!(std::env::var("OXIPAGE_ALPHA").ok().as_deref(), Some("kept"));
}