oxios-kernel 0.3.0

Oxios kernel: supervisor, event bus, state store
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
1177
1178
1179
1180
1181
1182
1183
1184
1185
1186
1187
1188
1189
1190
1191
1192
1193
1194
1195
1196
1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
1207
1208
1209
1210
1211
1212
1213
1214
1215
1216
1217
1218
1219
1220
1221
1222
1223
1224
1225
1226
1227
1228
1229
1230
1231
1232
1233
1234
1235
1236
1237
1238
1239
1240
1241
1242
1243
1244
1245
1246
1247
1248
1249
1250
1251
1252
1253
1254
1255
1256
1257
1258
1259
1260
1261
1262
1263
1264
1265
1266
1267
1268
1269
1270
1271
1272
1273
1274
1275
1276
1277
1278
1279
1280
1281
1282
1283
1284
1285
1286
1287
1288
1289
1290
1291
1292
1293
1294
1295
1296
1297
1298
1299
1300
1301
1302
1303
1304
1305
1306
1307
1308
1309
1310
1311
1312
1313
1314
1315
1316
1317
1318
1319
1320
1321
1322
1323
1324
1325
1326
1327
1328
1329
1330
1331
1332
1333
1334
1335
1336
1337
1338
1339
1340
1341
1342
1343
1344
1345
1346
1347
1348
1349
1350
1351
1352
1353
1354
1355
1356
1357
1358
1359
1360
1361
1362
1363
1364
1365
1366
1367
1368
1369
1370
1371
1372
1373
1374
1375
1376
1377
1378
1379
1380
1381
1382
1383
1384
1385
1386
1387
1388
//! Programs: OS-level installable applications for AI agents.
//!
//! A program is the OS-level concept of an installable application.
//! Like Unix has /bin programs, Oxios has programs that agents can "execute"
//! to gain capabilities through their SKILL.md instruction files.
//!
//! # Structure
//!
//! A program directory contains:
//! - `program.toml` - metadata (name, version, description, tools, dependencies)
//! - `SKILL.md` - instruction file (like a man page)
//! - optional `bin/` - executables
//! - optional `config/` - configuration files
//!
//! # Philosophy
//!
//! Programs are READ-ONLY instruction sets. They don't execute themselves;
//! they provide guidelines and tools that agents consume. Think of them as
//! man pages that come with metadata for discovery.

mod installer;
mod parser;
mod types;

pub use types::{
    ArgumentDef, HostRequirementsCheck, InstallSource, McpServerConfig, Program,
    ProgramHostRequirements, ProgramMeta, ProgramState, ToolDef,
};

use std::collections::HashMap;
use std::fs;
use std::path::{Path, PathBuf};

use anyhow::{Context, Result};
use tokio::sync::RwLock;

use crate::host_tools::HostToolValidator;

use installer::copy_dir_all;

/// Program manager — handles installation, uninstallation, and discovery
pub struct ProgramManager {
    /// Directory where programs are installed
    programs_dir: PathBuf,
    /// In-memory cache of installed programs
    installed: RwLock<HashMap<String, Program>>,
}

impl ProgramManager {
    /// Create a new program manager
    pub fn new(programs_dir: PathBuf) -> Self {
        Self {
            programs_dir,
            installed: RwLock::new(HashMap::new()),
        }
    }

    /// Get the programs directory path
    pub fn programs_dir(&self) -> &Path {
        &self.programs_dir
    }

    /// Initialize the program manager, loading all installed programs
    pub async fn init(&self) -> Result<()> {
        self.load_all().await
    }

    /// Load all programs from the programs directory.
    /// If the directory is empty, bootstrap from the `.programs/` directory in the oxios repo root.
    async fn load_all(&self) -> Result<()> {
        if !self.programs_dir.exists() {
            fs::create_dir_all(&self.programs_dir)?;
        }

        // Count installed programs
        let count = fs::read_dir(&self.programs_dir)?
            .filter_map(|e| e.ok())
            .filter(|e| e.path().is_dir())
            .count();

        // Bootstrap from `.programs/` (oxios repo root) if directory is empty.
        // This allows `.programs/` in the repo to serve as the default program source.
        if count == 0 {
            Self::bootstrap_defaults(&self.programs_dir).await?;
        }

        let mut installed = self.installed.write().await;
        for entry in fs::read_dir(&self.programs_dir)? {
            let entry = entry?;
            let path = entry.path();
            if path.is_dir() {
                if let Ok(program) = self.load_program(&path) {
                    installed.insert(program.meta.name.clone(), program);
                }
            }
        }

        Ok(())
    }

    /// Bootstrap default programs from the `.programs/` directory in the oxios repo root.
    /// This copies (not symlinks) so the programs directory is self-contained.
    async fn bootstrap_defaults(target_dir: &Path) -> Result<()> {
        let source_dir = PathBuf::from(env!("CARGO_MANIFEST_DIR")).join(".programs");
        if !source_dir.exists() {
            tracing::info!("No .programs/ directory found, skipping bootstrap");
            return Ok(());
        }

        tracing::info!(source = %source_dir.display(), "Bootstrapping default programs");

        for entry in fs::read_dir(&source_dir)? {
            let entry = entry?;
            let src = entry.path();
            if src.is_dir() {
                let name = match src.file_name().map(|n| n.to_string_lossy().into_owned()) {
                    Some(n) if !n.is_empty() => n,
                    _ => continue,
                };
                let dest = target_dir.join(&*name);

                // Only copy if not already present
                if !dest.exists() {
                    copy_dir_all(&src, &dest)?;
                    tracing::info!(program = %name, "Bootstrapped default program");
                }
            }
        }

        Ok(())
    }

    /// Load a single program from a directory
    fn load_program(&self, path: &Path) -> Result<Program> {
        let meta = ProgramMeta::load_from_dir(path)?;

        let skill_path = path.join("SKILL.md");
        let skill_content = if skill_path.exists() {
            fs::read_to_string(&skill_path).unwrap_or_default()
        } else {
            String::new()
        };

        Ok(Program {
            meta,
            path: path.to_path_buf(),
            skill_content,
            enabled: self
                .load_program_state(path)
                .map(|s| s.enabled)
                .unwrap_or(true),
        })
    }

    /// List all installed programs
    pub async fn list_programs(&self) -> Vec<Program> {
        let installed = self.installed.read().await;
        installed.values().cloned().collect()
    }

    /// List all enabled programs
    pub async fn list_enabled(&self) -> Vec<Program> {
        let installed = self.installed.read().await;
        installed.values().filter(|p| p.enabled).cloned().collect()
    }

    /// Get a specific program by name
    pub async fn get_program(&self, name: &str) -> Option<Program> {
        let installed = self.installed.read().await;
        installed.get(name).cloned()
    }

    /// Install a program from a directory
    pub async fn install(&self, source_path: &Path) -> Result<Program> {
        // Load the source program
        let source_meta = ProgramMeta::load_from_dir(source_path)?;
        let source_skill = source_path.join("SKILL.md");
        let skill_content = if source_skill.exists() {
            fs::read_to_string(&source_skill)?
        } else {
            String::new()
        };

        // Create the destination path
        let dest_path = self.programs_dir.join(&source_meta.name);
        if dest_path.exists() {
            anyhow::bail!("Program '{}' is already installed", source_meta.name);
        }

        // Copy the directory recursively
        copy_dir_all(source_path, &dest_path)?;

        // Create initial state file
        let state = ProgramState::new();
        let state_json = serde_json::to_string_pretty(&state)?;
        fs::write(dest_path.join("state.json"), state_json)?;

        // Create the program entry
        let program = Program {
            meta: source_meta,
            path: dest_path,
            skill_content,
            enabled: true,
        };

        // Add to the installed map
        let mut installed = self.installed.write().await;
        installed.insert(program.meta.name.clone(), program.clone());

        Ok(program)
    }

    /// Install a program from an [InstallSource].
    pub async fn install_from(&self, source: InstallSource) -> Result<Program> {
        match source {
            InstallSource::Local(path) => self.install_from_local(&path).await,
            InstallSource::Git { url, branch } => {
                self.install_from_git(&url, branch.as_deref()).await
            }
            InstallSource::Tarball { url } => self.install_from_tarball(&url).await,
        }
    }

    /// Install a program from a local directory path.
    async fn install_from_local(&self, source_path: &Path) -> Result<Program> {
        self.install(source_path).await
    }

    /// Install a program by cloning a git repository, then installing the result.
    async fn install_from_git(&self, url: &str, branch: Option<&str>) -> Result<Program> {
        // Create a temporary directory for the clone.
        let temp_dir = tempfile::tempdir().map_err(|e| anyhow::anyhow!("tempfile: {}", e))?;
        let clone_path = temp_dir.path();

        // Clone the repository.
        tracing::info!(url, branch = ?branch, "Cloning git repository");
        let mut cmd = tokio::process::Command::new("git");
        cmd.arg("clone");
        if let Some(branch) = branch {
            cmd.arg("--branch").arg(branch);
        }
        cmd.arg("--depth").arg("1");
        cmd.arg(url);
        cmd.arg(clone_path);

        let output = cmd
            .output()
            .await
            .with_context(|| format!("Failed to run git clone for '{}'", url))?;

        if !output.status.success() {
            anyhow::bail!(
                "git clone failed (exit {}): {}",
                output.status,
                String::from_utf8_lossy(&output.stderr)
            );
        }

        // Find the cloned program directory (single top-level directory expected).
        let entries: Vec<_> = std::fs::read_dir(clone_path)?
            .filter_map(|e| e.ok())
            .filter(|e| e.path().is_dir())
            .collect();

        let program_dir = if entries.len() == 1 {
            entries
                .into_iter()
                .next()
                .map(|e| e.path())
                .unwrap_or_else(|| clone_path.to_path_buf())
        } else {
            clone_path.to_path_buf()
        };

        let program = self.install(&program_dir).await?;

        tracing::info!(name = %program.meta.name, "Program installed from git");
        Ok(program)
    }

    /// Install a program by downloading and extracting a tarball.
    async fn install_from_tarball(&self, url: &str) -> Result<Program> {
        // Create a temporary directory for download and extraction.
        let temp_dir = tempfile::tempdir().map_err(|e| anyhow::anyhow!("tempfile: {}", e))?;
        let download_path = temp_dir.path().join("program.tar.gz");
        let extract_base = temp_dir.path().join("extracted");

        // Download the tarball with curl.
        tracing::info!(url, "Downloading tarball");
        let curl = tokio::process::Command::new("curl")
            .arg("-fsSL")
            .arg("-o")
            .arg(&download_path)
            .arg(url)
            .output()
            .await
            .with_context(|| format!("Failed to run curl for '{}'", url))?;

        if !curl.status.success() {
            anyhow::bail!(
                "curl failed (exit {}): {}",
                curl.status,
                String::from_utf8_lossy(&curl.stderr)
            );
        }

        // Extract the tarball.
        tracing::info!("Extracting tarball");
        let tar = tokio::process::Command::new("tar")
            .arg("-xzf")
            .arg(&download_path)
            .arg("-C")
            .arg(&extract_base)
            .output()
            .await
            .with_context(|| "Failed to run tar to extract tarball")?;

        if !tar.status.success() {
            anyhow::bail!(
                "tar extraction failed (exit {}): {}",
                tar.status,
                String::from_utf8_lossy(&tar.stderr)
            );
        }

        // Find the extracted program directory.
        let entries: Vec<_> = std::fs::read_dir(&extract_base)?
            .filter_map(|e| e.ok())
            .filter(|e| e.path().is_dir())
            .collect();

        let program_dir = if entries.len() == 1 {
            entries
                .into_iter()
                .next()
                .map(|e| e.path())
                .unwrap_or_else(|| extract_base.to_path_buf())
        } else {
            extract_base.to_path_buf()
        };

        let program = self.install(&program_dir).await?;

        tracing::info!(name = %program.meta.name, "Program installed from tarball");
        Ok(program)
    }

    /// Uninstall a program
    pub async fn uninstall(&self, name: &str) -> Result<()> {
        let mut installed = self.installed.write().await;

        let program = installed
            .remove(name)
            .ok_or_else(|| anyhow::anyhow!("Program '{}' not found", name))?;

        // Remove the directory
        if program.path.exists() {
            fs::remove_dir_all(&program.path)?;
        }

        Ok(())
    }

    /// Enable or disable a program (persisted across restarts).
    pub async fn set_enabled(&self, name: &str, enabled: bool) -> Result<()> {
        let mut installed = self.installed.write().await;

        let program = installed
            .get_mut(name)
            .ok_or_else(|| anyhow::anyhow!("Program '{}' not found", name))?;

        program.enabled = enabled;

        // Persist to state.json
        self.persist_state(&program.path, enabled)?;

        tracing::info!(name, enabled, "Program enabled state persisted");
        Ok(())
    }

    /// Check if host requirements are met for a program
    pub async fn check_host_requirements(&self, name: &str) -> Result<HostRequirementsCheck> {
        let installed = self.installed.read().await;

        let program = installed
            .get(name)
            .ok_or_else(|| anyhow::anyhow!("Program '{}' not found", name))?;

        let validator = HostToolValidator::new(
            program.meta.host_requirements.required.clone(),
            program.meta.host_requirements.optional.clone(),
        );

        let missing_required = validator.validate_required();
        let optional_status = validator.check_optional();

        Ok(HostRequirementsCheck {
            program_name: name.to_string(),
            missing_required,
            optional_available: optional_status,
        })
    }

    /// Get tool schemas for all enabled programs
    pub async fn all_tool_schemas(&self) -> Vec<ToolDef> {
        let installed = self.installed.read().await;
        installed
            .values()
            .filter(|p| p.enabled)
            .flat_map(|p| p.meta.tools.clone())
            .collect()
    }

    /// Get skill content for a specific program
    pub async fn get_skill_content(&self, name: &str) -> Option<String> {
        let installed = self.installed.read().await;
        installed.get(name).map(|p| p.skill_content.clone())
    }

    /// Upgrade an existing program, or install if not present.
    ///
    /// Compares versions using SemVer. If the new version is the same,
    /// returns the existing program (no-op). If different, performs
    /// atomic replace: uninstall old → install new, preserving the
    /// enabled state.
    pub async fn upgrade(&self, source_path: &Path) -> Result<Program> {
        let source_meta = ProgramMeta::load_from_dir(source_path)?;

        // Check if already installed
        let existing = self.get_program(&source_meta.name).await;

        if let Some(ref old) = existing {
            let cmp = compare_versions(&source_meta.version, &old.meta.version);
            match cmp {
                VersionCmp::Equal => {
                    tracing::info!(
                        name = %source_meta.name,
                        version = %source_meta.version,
                        "Program already at same version — no upgrade needed"
                    );
                    return Ok(old.clone());
                }
                VersionCmp::Older => {
                    tracing::warn!(
                        name = %source_meta.name,
                        old = %old.meta.version,
                        new = %source_meta.version,
                        "Downgrade requested — proceeding"
                    );
                }
                VersionCmp::Newer => {
                    tracing::info!(
                        name = %source_meta.name,
                        old = %old.meta.version,
                        new = %source_meta.version,
                        "Upgrading program"
                    );
                }
            }

            // Preserve enabled state across upgrade
            let was_enabled = old.enabled;

            // Atomic upgrade: copy to temp, validate, then swap
            let target_path = self.programs_dir.join(&source_meta.name);
            let temp_path = self
                .programs_dir
                .join(format!(".tmp-upgrade-{}", source_meta.name));

            // Clean up any leftover temp directory from a failed previous upgrade
            if temp_path.exists() {
                let _ = fs::remove_dir_all(&temp_path);
            }

            // Step 1: Copy source to temp directory
            if let Err(e) = copy_dir_all(source_path, &temp_path) {
                let _ = fs::remove_dir_all(&temp_path);
                return Err(e.context("Failed to copy program to temp directory for upgrade"));
            }

            // Step 2: Parse and validate the new program from the temp directory
            let new_meta = match ProgramMeta::load_from_dir(&temp_path) {
                Ok(meta) => meta,
                Err(e) => {
                    let _ = fs::remove_dir_all(&temp_path);
                    return Err(e.context("Failed to validate upgraded program"));
                }
            };

            let skill_path = temp_path.join("SKILL.md");
            let skill_content = if skill_path.exists() {
                fs::read_to_string(&skill_path).unwrap_or_default()
            } else {
                String::new()
            };

            // Step 3: Create state file in temp directory
            let state = ProgramState::new().with_enabled(was_enabled);
            let state_json = serde_json::to_string_pretty(&state)?;
            fs::write(temp_path.join("state.json"), state_json)?;

            // Step 4: Remove old directory and rename temp to target
            if target_path.exists() {
                fs::remove_dir_all(&target_path)?;
            }
            fs::rename(&temp_path, &target_path)?;

            // Step 5: Update in-memory cache
            let program = Program {
                meta: new_meta,
                path: target_path,
                skill_content,
                enabled: was_enabled,
            };

            let mut installed = self.installed.write().await;
            installed.insert(program.meta.name.clone(), program.clone());

            tracing::info!(
                name = %program.meta.name,
                version = %program.meta.version,
                enabled = program.enabled,
                "Program upgraded"
            );

            Ok(program)
        } else {
            // Not installed — just install
            tracing::info!(
                name = %source_meta.name,
                "Program not installed — performing fresh install"
            );
            self.install(source_path).await
        }
    }

    // ── State Persistence Helpers ──

    /// Load program state from state.json in the program directory.
    fn load_program_state(&self, path: &Path) -> Result<ProgramState> {
        let state_path = path.join("state.json");
        if !state_path.exists() {
            return Ok(ProgramState::default());
        }
        let json = fs::read_to_string(&state_path)?;
        let state: ProgramState = serde_json::from_str(&json)?;
        Ok(state)
    }

    /// Persist enabled state to state.json in the program directory.
    fn persist_state(&self, program_path: &Path, enabled: bool) -> Result<()> {
        let mut state = self.load_program_state(program_path).unwrap_or_default();
        state.enabled = enabled;
        state.last_modified = chrono::Utc::now().to_rfc3339();
        let state_json = serde_json::to_string_pretty(&state)?;
        fs::write(program_path.join("state.json"), state_json)?;
        Ok(())
    }
}

// ── Version Comparison ─────────────────────────────────────────────────────────

/// Result of comparing two SemVer version strings.
#[derive(Debug, Clone, Copy, PartialEq, Eq)]
enum VersionCmp {
    /// Versions are identical.
    Equal,
    /// First version is newer.
    Newer,
    /// First version is older.
    Older,
}

/// Compare two SemVer version strings (major.minor.patch).
///
/// Handles `v` prefix and missing components gracefully.
fn compare_versions(a: &str, b: &str) -> VersionCmp {
    let parse = |v: &str| -> Vec<u32> {
        v.strip_prefix('v')
            .unwrap_or(v)
            .split('.')
            .filter_map(|s| s.parse().ok())
            .collect()
    };
    let va = parse(a);
    let vb = parse(b);
    for i in 0..va.len().max(vb.len()) {
        let na = va.get(i).unwrap_or(&0);
        let nb = vb.get(i).unwrap_or(&0);
        match na.cmp(nb) {
            std::cmp::Ordering::Greater => return VersionCmp::Newer,
            std::cmp::Ordering::Less => return VersionCmp::Older,
            std::cmp::Ordering::Equal => continue,
        }
    }
    VersionCmp::Equal
}

#[cfg(test)]
mod tests {
    use super::*;
    use std::fs;

    // --- ProgramMeta tests ---

    #[test]
    fn test_program_meta_load_minimal() {
        let temp_dir = tempfile::tempdir().unwrap();
        let program_dir = temp_dir.path();

        // Create a minimal program.toml
        let toml_content = r#"
[program]
name = "test-program"
version = "1.0.0"
description = "A test program"
author = "Test Author"

[tools]
my_tool = { description = "A test tool" }
"#;

        fs::write(program_dir.join("program.toml"), toml_content).unwrap();
        fs::write(
            program_dir.join("SKILL.md"),
            "# Test Program\n\nThis is a test.",
        )
        .unwrap();

        let meta = ProgramMeta::load_from_dir(program_dir).unwrap();

        assert_eq!(meta.name, "test-program");
        assert_eq!(meta.version, "1.0.0");
        assert_eq!(meta.description, "A test program");
        assert_eq!(meta.author, "Test Author");
        assert_eq!(meta.tools.len(), 1);
        assert_eq!(meta.tools[0].name, "my_tool");
        assert_eq!(meta.tools[0].description, "A test tool");
        assert!(meta.tools[0].arguments.is_empty());
    }

    #[test]
    fn test_program_meta_with_tools_and_args() {
        let temp_dir = tempfile::tempdir().unwrap();
        let program_dir = temp_dir.path();

        let toml_content = r#"
[program]
name = "rich-program"
version = "2.0.0"
description = "A program with rich tools"
author = "Author"

[tools.greet]
description = "Greets a user"
arguments = [
    { name = "name", description = "User name", required = true },
    { name = "loud", description = "Shout", required = false, default = "false" }
]

[tools.farewell]
description = "Says goodbye"
arguments = []
"#;

        fs::write(program_dir.join("program.toml"), toml_content).unwrap();

        let meta = ProgramMeta::load_from_dir(program_dir).unwrap();

        assert_eq!(meta.tools.len(), 2);

        // Find greet by name (order may vary).
        let greet = meta
            .tools
            .iter()
            .find(|t| t.name == "greet")
            .expect("greet tool");
        assert_eq!(greet.arguments.len(), 2);

        // Verify arguments exist and have correct structure.
        let name_arg = greet
            .arguments
            .iter()
            .find(|a| a.name == "name")
            .expect("name arg");
        assert!(name_arg.required, "name should be required");
        assert_eq!(name_arg.description, "User name");

        let loud_arg = greet
            .arguments
            .iter()
            .find(|a| a.name == "loud")
            .expect("loud arg");
        assert_eq!(loud_arg.default, Some("false".to_string()));
    }

    #[test]
    fn test_program_meta_with_dependencies() {
        let temp_dir = tempfile::tempdir().unwrap();
        let program_dir = temp_dir.path();

        let toml_content = r#"
[program]
name = "test-with-deps"
version = "1.0.0"
description = "A test program with dependencies"
author = "Test Author"

[host_requirements]
required = ["git", "gh"]
optional = ["jq", "curl"]
"#;

        fs::write(program_dir.join("program.toml"), toml_content).unwrap();

        let meta = ProgramMeta::load_from_dir(program_dir).unwrap();

        assert_eq!(meta.host_requirements.required, vec!["git", "gh"]);
        assert_eq!(meta.host_requirements.optional, vec!["jq", "curl"]);
    }

    #[test]
    fn test_program_meta_missing_file() {
        let temp_dir = tempfile::tempdir().unwrap();
        let program_dir = temp_dir.path();

        // No program.toml — should error.
        let result = ProgramMeta::load_from_dir(program_dir);
        assert!(result.is_err());
    }

    #[test]
    fn test_program_meta_empty_optional_sections() {
        let temp_dir = tempfile::tempdir().unwrap();
        let program_dir = temp_dir.path();

        let toml_content = r#"
[program]
name = "minimal"
version = "1.0.0"
description = "Minimal"
author = "X"
"#;

        fs::write(program_dir.join("program.toml"), toml_content).unwrap();

        let meta = ProgramMeta::load_from_dir(program_dir).unwrap();

        assert!(meta.tools.is_empty());
        assert!(meta.host_requirements.required.is_empty());
        assert!(meta.host_requirements.optional.is_empty());
        assert!(meta.dependencies.is_empty());
    }

    #[test]
    fn test_requires_tools_parsed() {
        let temp_dir = tempfile::tempdir().unwrap();
        let program_dir = temp_dir.path();

        let toml_content = r#"
[program]
name = "needs-tools"
version = "1.0.0"
description = "A program that requires tools"
author = "Test"

[requires_tools]
names = ["read", "exec"]
"#;

        fs::write(program_dir.join("program.toml"), toml_content).unwrap();

        let meta = ProgramMeta::load_from_dir(program_dir).unwrap();

        assert_eq!(meta.dependencies, vec!["read", "exec"]);
    }

    #[test]
    fn test_requires_tools_empty() {
        let temp_dir = tempfile::tempdir().unwrap();
        let program_dir = temp_dir.path();

        let toml_content = r#"
[program]
name = "no-reqs"
version = "1.0.0"
description = "No requirements"
author = "Test"

[requires_tools]
names = []
"#;

        fs::write(program_dir.join("program.toml"), toml_content).unwrap();

        let meta = ProgramMeta::load_from_dir(program_dir).unwrap();

        assert!(meta.dependencies.is_empty());
    }

    #[test]
    fn test_requires_tools_single() {
        let temp_dir = tempfile::tempdir().unwrap();
        let program_dir = temp_dir.path();

        let toml_content = r#"
[program]
name = "single-req"
version = "1.0.0"
description = "Single requirement"
author = "Test"

[requires_tools]
names = ["grep"]
"#;

        fs::write(program_dir.join("program.toml"), toml_content).unwrap();

        let meta = ProgramMeta::load_from_dir(program_dir).unwrap();

        assert_eq!(meta.dependencies, vec!["grep"]);
    }

    // --- ProgramManager tests ---

    #[tokio::test]
    async fn test_program_manager_init_creates_dir() {
        let temp_dir = tempfile::tempdir().unwrap();
        let programs_dir = temp_dir.path().join("programs");

        let manager = ProgramManager::new(programs_dir.clone());
        manager.init().await.unwrap();

        assert!(programs_dir.exists());
    }

    #[tokio::test]
    async fn test_list_programs_empty() {
        let temp_dir = tempfile::tempdir().unwrap();
        let programs_dir = temp_dir.path().join("programs");

        let manager = ProgramManager::new(programs_dir.clone());
        manager.init().await.unwrap();

        let programs = manager.list_programs().await;
        assert!(programs.is_empty());
    }

    #[tokio::test]
    async fn test_get_program_nonexistent() {
        let temp_dir = tempfile::tempdir().unwrap();
        let manager = ProgramManager::new(temp_dir.path().join("programs"));
        manager.init().await.unwrap();

        assert!(manager.get_program("nonexistent").await.is_none());
    }

    #[tokio::test]
    async fn test_install_program() {
        let temp_dir = tempfile::tempdir().unwrap();
        let programs_dir = temp_dir.path().join("programs");
        let source_dir = temp_dir.path().join("source-program");

        // Create source program.
        fs::create_dir_all(&source_dir).unwrap();
        let toml = r#"
[program]
name = "my-program"
version = "1.0.0"
description = "My program"
author = "Test"

[tools.hello]
description = "Says hello"
"#;
        fs::write(source_dir.join("program.toml"), toml).unwrap();
        fs::write(source_dir.join("SKILL.md"), "# My Program\n\nDoes things.").unwrap();

        let manager = ProgramManager::new(programs_dir.clone());
        manager.init().await.unwrap();

        let installed = manager.install(&source_dir).await.unwrap();

        assert_eq!(installed.meta.name, "my-program");
        assert_eq!(installed.meta.version, "1.0.0");
        assert!(installed.enabled);
        assert!(!installed.skill_content.is_empty());

        // Verify it's listed.
        let programs = manager.list_programs().await;
        assert_eq!(programs.len(), 1);
        assert_eq!(programs[0].meta.name, "my-program");

        // Verify directory exists.
        assert!(programs_dir.join("my-program").exists());
    }

    #[tokio::test]
    async fn test_install_duplicate_fails() {
        let temp_dir = tempfile::tempdir().unwrap();
        let programs_dir = temp_dir.path().join("programs");
        let source1 = temp_dir.path().join("src1");
        let source2 = temp_dir.path().join("src2");

        for src in [&source1, &source2] {
            fs::create_dir_all(src).unwrap();
            let toml = r#"
[program]
name = "dup"
version = "1.0.0"
description = "X"
author = "X"
"#;
            fs::write(src.join("program.toml"), toml).unwrap();
        }

        let manager = ProgramManager::new(programs_dir.clone());
        manager.init().await.unwrap();

        manager.install(&source1).await.unwrap();
        let result = manager.install(&source2).await;
        assert!(result.is_err());
        assert!(result
            .unwrap_err()
            .to_string()
            .contains("already installed"));
    }

    #[tokio::test]
    async fn test_uninstall_program() {
        let temp_dir = tempfile::tempdir().unwrap();
        let programs_dir = temp_dir.path().join("programs");
        let source = temp_dir.path().join("to-uninstall");

        fs::create_dir_all(&source).unwrap();
        fs::write(
            source.join("program.toml"),
            r#"
[program]
name = "removable"
version = "1.0.0"
description = "X"
author = "X"
"#,
        )
        .unwrap();

        let manager = ProgramManager::new(programs_dir.clone());
        manager.init().await.unwrap();

        manager.install(&source).await.unwrap();
        assert!(manager.get_program("removable").await.is_some());

        manager.uninstall("removable").await.unwrap();
        assert!(manager.get_program("removable").await.is_none());

        // Directory should be gone.
        assert!(!programs_dir.join("removable").exists());
    }

    #[tokio::test]
    async fn test_uninstall_nonexistent_fails() {
        let temp_dir = tempfile::tempdir().unwrap();
        let manager = ProgramManager::new(temp_dir.path().join("programs"));
        manager.init().await.unwrap();

        let result = manager.uninstall("nonexistent").await;
        assert!(result.is_err());
    }

    #[tokio::test]
    async fn test_set_enabled() {
        let temp_dir = tempfile::tempdir().unwrap();
        let programs_dir = temp_dir.path().join("programs");
        let source = temp_dir.path().join("toggle-me");

        fs::create_dir_all(&source).unwrap();
        fs::write(
            source.join("program.toml"),
            r#"
[program]
name = "toggle-me"
version = "1.0.0"
description = "X"
author = "X"
"#,
        )
        .unwrap();

        let manager = ProgramManager::new(programs_dir.clone());
        manager.init().await.unwrap();

        manager.install(&source).await.unwrap();

        let prog = manager.get_program("toggle-me").await.unwrap();
        assert!(prog.enabled);

        manager.set_enabled("toggle-me", false).await.unwrap();
        let prog = manager.get_program("toggle-me").await.unwrap();
        assert!(!prog.enabled);

        manager.set_enabled("toggle-me", true).await.unwrap();
        let prog = manager.get_program("toggle-me").await.unwrap();
        assert!(prog.enabled);
    }

    #[tokio::test]
    async fn test_all_tool_schemas() {
        let temp_dir = tempfile::tempdir().unwrap();
        let programs_dir = temp_dir.path().join("programs");

        // Install two programs with tools.
        for (name, tool_name) in [("prog-a", "tool-a"), ("prog-b", "tool-b")] {
            let src = temp_dir.path().join(name);
            fs::create_dir_all(&src).unwrap();
            let toml = format!(
                r#"
[program]
name = "{}"
version = "1.0.0"
description = "X"
author = "X"

[tools.{}]
description = "A tool"
"#,
                name, tool_name
            );
            fs::write(src.join("program.toml"), toml).unwrap();
        }

        let manager = ProgramManager::new(programs_dir.clone());
        manager.init().await.unwrap();

        // Install prog-a (enabled by default), disable prog-b.
        let src_a = temp_dir.path().join("prog-a");
        let src_b = temp_dir.path().join("prog-b");
        manager.install(&src_a).await.unwrap();
        manager.install(&src_b).await.unwrap();
        manager.set_enabled("prog-b", false).await.unwrap();

        let schemas = manager.all_tool_schemas().await;
        assert_eq!(schemas.len(), 1);
        assert_eq!(schemas[0].name, "tool-a");
    }

    #[tokio::test]
    async fn test_get_skill_content() {
        let temp_dir = tempfile::tempdir().unwrap();
        let programs_dir = temp_dir.path().join("programs");
        let source = temp_dir.path().join("skill-test");

        fs::create_dir_all(&source).unwrap();
        fs::write(
            source.join("program.toml"),
            r#"
[program]
name = "skill-test"
version = "1.0.0"
description = "X"
author = "X"
"#,
        )
        .unwrap();
        fs::write(
            source.join("SKILL.md"),
            "# Skill Test\n\nUse this program like so.",
        )
        .unwrap();

        let manager = ProgramManager::new(programs_dir.clone());
        manager.init().await.unwrap();

        manager.install(&source).await.unwrap();

        let content = manager.get_skill_content("skill-test").await;
        assert!(content.is_some());
        assert!(content.unwrap().contains("Skill Test"));
    }

    #[tokio::test]
    async fn test_check_host_requirements() {
        let temp_dir = tempfile::tempdir().unwrap();
        let programs_dir = temp_dir.path().join("programs");
        let source = temp_dir.path().join("req-check");

        fs::create_dir_all(&source).unwrap();
        fs::write(
            source.join("program.toml"),
            r#"
[program]
name = "req-check"
version = "1.0.0"
description = "X"
author = "X"

[host_requirements]
required = ["git"]
optional = ["echo", "nonexistent-tool-xyz"]
"#,
        )
        .unwrap();

        let manager = ProgramManager::new(programs_dir.clone());
        manager.init().await.unwrap();

        manager.install(&source).await.unwrap();

        let check = manager.check_host_requirements("req-check").await.unwrap();
        assert_eq!(check.program_name, "req-check");
        // git should be available on most systems.
        assert!(check.missing_required.is_empty());
        // Optional tools status.
        assert!(check.optional_available["echo"]);
        assert!(!check.optional_available["nonexistent-tool-xyz"]);
    }

    #[tokio::test]
    async fn test_check_host_requirements_program_not_found() {
        let temp_dir = tempfile::tempdir().unwrap();
        let manager = ProgramManager::new(temp_dir.path().join("programs"));
        manager.init().await.unwrap();

        let result = manager.check_host_requirements("ghost").await;
        assert!(result.is_err());
    }

    #[test]
    fn test_copy_dir_all() {
        let temp_dir = tempfile::tempdir().unwrap();
        let src = temp_dir.path().join("src");
        let dst = temp_dir.path().join("dst");

        fs::create_dir_all(src.join("subdir")).unwrap();
        fs::write(src.join("file.txt"), "content").unwrap();
        fs::write(src.join("subdir").join("nested.txt"), "nested").unwrap();

        copy_dir_all(&src, &dst).unwrap();

        assert!(dst.join("file.txt").exists());
        assert!(dst.join("subdir").join("nested.txt").exists());
        assert_eq!(fs::read_to_string(dst.join("file.txt")).unwrap(), "content");
    }

    // ── Version Comparison Tests ──

    #[test]
    fn test_compare_versions_equal() {
        assert_eq!(compare_versions("1.0.0", "1.0.0"), VersionCmp::Equal);
        assert_eq!(compare_versions("2.3.4", "2.3.4"), VersionCmp::Equal);
    }

    #[test]
    fn test_compare_versions_newer() {
        assert_eq!(compare_versions("2.0.0", "1.0.0"), VersionCmp::Newer);
        assert_eq!(compare_versions("1.1.0", "1.0.0"), VersionCmp::Newer);
        assert_eq!(compare_versions("1.0.1", "1.0.0"), VersionCmp::Newer);
        assert_eq!(compare_versions("1.0.0", "0.9.9"), VersionCmp::Newer);
    }

    #[test]
    fn test_compare_versions_older() {
        assert_eq!(compare_versions("1.0.0", "2.0.0"), VersionCmp::Older);
        assert_eq!(compare_versions("1.0.0", "1.1.0"), VersionCmp::Older);
    }

    #[test]
    fn test_compare_versions_with_v_prefix() {
        assert_eq!(compare_versions("v1.0.0", "1.0.0"), VersionCmp::Equal);
        assert_eq!(compare_versions("v2.0.0", "v1.0.0"), VersionCmp::Newer);
    }

    #[test]
    fn test_compare_versions_missing_components() {
        assert_eq!(compare_versions("1.0", "1.0.0"), VersionCmp::Equal);
        assert_eq!(compare_versions("2", "1.0.0"), VersionCmp::Newer);
    }

    // ── State Persistence Tests ──

    #[test]
    fn test_program_state_default() {
        let state = ProgramState::default();
        assert!(state.enabled);
        assert!(!state.installed_at.is_empty());
        assert!(!state.last_modified.is_empty());
    }

    #[test]
    fn test_program_state_with_enabled() {
        let state = ProgramState::new().with_enabled(false);
        assert!(!state.enabled);
    }

    #[tokio::test]
    async fn test_state_json_created_on_install() {
        let temp_dir = tempfile::tempdir().unwrap();
        let programs_dir = temp_dir.path().join("programs");
        let source_dir = temp_dir.path().join("source");
        fs::create_dir_all(&source_dir).unwrap();
        fs::write(
            source_dir.join("program.toml"),
            r#"
[program]
name = "state-test"
version = "1.0.0"
description = "Test"
author = "Test"
"#,
        )
        .unwrap();
        fs::write(source_dir.join("SKILL.md"), "# Test").unwrap();

        let manager = ProgramManager::new(programs_dir);
        manager.init().await.unwrap();
        let program = manager.install(&source_dir).await.unwrap();

        // state.json should exist
        let state_path = program.path.join("state.json");
        assert!(state_path.exists());

        let state: ProgramState =
            serde_json::from_str(&fs::read_to_string(&state_path).unwrap()).unwrap();
        assert!(state.enabled);
    }

    #[tokio::test]
    async fn test_set_enabled_persists() {
        let temp_dir = tempfile::tempdir().unwrap();
        let programs_dir = temp_dir.path().join("programs");
        let source_dir = temp_dir.path().join("source");
        fs::create_dir_all(&source_dir).unwrap();
        fs::write(
            source_dir.join("program.toml"),
            r#"
[program]
name = "toggle-test"
version = "1.0.0"
description = "Test"
author = "Test"
"#,
        )
        .unwrap();
        fs::write(source_dir.join("SKILL.md"), "# Test").unwrap();

        let manager = ProgramManager::new(programs_dir);
        manager.init().await.unwrap();
        let program = manager.install(&source_dir).await.unwrap();

        // Disable
        manager.set_enabled("toggle-test", false).await.unwrap();

        // Verify state.json reflects disabled
        let state: ProgramState =
            serde_json::from_str(&fs::read_to_string(program.path.join("state.json")).unwrap())
                .unwrap();
        assert!(!state.enabled);

        // Re-enable
        manager.set_enabled("toggle-test", true).await.unwrap();
        let state: ProgramState =
            serde_json::from_str(&fs::read_to_string(program.path.join("state.json")).unwrap())
                .unwrap();
        assert!(state.enabled);
    }

    #[tokio::test]
    async fn test_enabled_state_survives_reload() {
        let temp_dir = tempfile::tempdir().unwrap();
        let programs_dir = temp_dir.path().join("programs");
        let source_dir = temp_dir.path().join("source");
        fs::create_dir_all(&source_dir).unwrap();
        fs::write(
            source_dir.join("program.toml"),
            r#"
[program]
name = "persist-test"
version = "1.0.0"
description = "Test"
author = "Test"
"#,
        )
        .unwrap();
        fs::write(source_dir.join("SKILL.md"), "# Test").unwrap();

        // First manager: install and disable
        let manager = ProgramManager::new(programs_dir.clone());
        manager.init().await.unwrap();
        manager.install(&source_dir).await.unwrap();
        manager.set_enabled("persist-test", false).await.unwrap();
        drop(manager);

        // Second manager: reload from disk — state should be disabled
        let manager2 = ProgramManager::new(programs_dir);
        manager2.init().await.unwrap();
        let reloaded = manager2.get_program("persist-test").await.unwrap();
        assert!(!reloaded.enabled, "disabled state should survive restart");
    }

    // ── Upgrade Tests ──

    fn make_program_dir(parent: &Path, name: &str, version: &str) -> PathBuf {
        let dir = parent.join(name);
        fs::create_dir_all(&dir).unwrap();
        let toml = format!(
            "[program]\nname = \"{}\"\nversion = \"{}\"\ndescription = \"Test\"\nauthor = \"Test\"\n",
            name, version,
        );
        fs::write(dir.join("program.toml"), toml).unwrap();
        fs::write(dir.join("SKILL.md"), "# Test").unwrap();
        dir
    }

    #[tokio::test]
    async fn test_upgrade_same_version_is_noop() {
        let temp_dir = tempfile::tempdir().unwrap();
        let programs_dir = temp_dir.path().join("programs");

        let manager = ProgramManager::new(programs_dir);
        manager.init().await.unwrap();

        // Install v1.0.0
        let v1_dir = make_program_dir(temp_dir.path(), "up-test", "1.0.0");
        manager.install(&v1_dir).await.unwrap();

        // Upgrade to same v1.0.0 — should be no-op
        let v1_dir2 = make_program_dir(&temp_dir.path().join("v1copy"), "up-test", "1.0.0");
        let result = manager.upgrade(&v1_dir2).await.unwrap();
        assert_eq!(result.meta.version, "1.0.0");
    }

    #[tokio::test]
    async fn test_upgrade_newer_version() {
        let temp_dir = tempfile::tempdir().unwrap();
        let programs_dir = temp_dir.path().join("programs");

        let manager = ProgramManager::new(programs_dir);
        manager.init().await.unwrap();

        // Install v1.0.0
        let v1_dir = make_program_dir(temp_dir.path(), "up-test", "1.0.0");
        manager.install(&v1_dir).await.unwrap();

        // Upgrade to v2.0.0
        let v2_dir = make_program_dir(&temp_dir.path().join("v2"), "up-test", "2.0.0");
        let result = manager.upgrade(&v2_dir).await.unwrap();
        assert_eq!(result.meta.version, "2.0.0");
    }

    #[tokio::test]
    async fn test_upgrade_preserves_enabled_state() {
        let temp_dir = tempfile::tempdir().unwrap();
        let programs_dir = temp_dir.path().join("programs");

        let manager = ProgramManager::new(programs_dir);
        manager.init().await.unwrap();

        // Install v1.0.0 and disable it
        let v1_dir = make_program_dir(temp_dir.path(), "up-test", "1.0.0");
        manager.install(&v1_dir).await.unwrap();
        manager.set_enabled("up-test", false).await.unwrap();

        // Upgrade to v2.0.0 — should stay disabled
        let v2_dir = make_program_dir(&temp_dir.path().join("v2"), "up-test", "2.0.0");
        let result = manager.upgrade(&v2_dir).await.unwrap();
        assert_eq!(result.meta.version, "2.0.0");
        assert!(
            !result.enabled,
            "disabled state should be preserved across upgrade"
        );
    }

    #[tokio::test]
    async fn test_upgrade_installs_if_not_present() {
        let temp_dir = tempfile::tempdir().unwrap();
        let programs_dir = temp_dir.path().join("programs");

        let manager = ProgramManager::new(programs_dir);
        manager.init().await.unwrap();

        // Upgrade without prior install — should just install
        let v1_dir = make_program_dir(temp_dir.path(), "fresh-test", "1.0.0");
        let result = manager.upgrade(&v1_dir).await.unwrap();
        assert_eq!(result.meta.name, "fresh-test");
        assert_eq!(result.meta.version, "1.0.0");
        assert!(result.enabled);
    }
}