oximedia-codec 0.1.4

Video codec implementations for OxiMedia
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
//! MJPEG decoder implementation.
//!
//! Wraps the `oximedia-image` JPEG baseline decoder to decode
//! Motion JPEG video — each packet is an independently JPEG-encoded frame.

use super::types::MjpegFrameInfo;
use crate::error::{CodecError, CodecResult};
use crate::frame::{FrameType, Plane, VideoFrame};
use crate::traits::VideoDecoder;
use oximedia_core::{CodecId, PixelFormat, Rational, Timestamp};
use oximedia_image::jpeg::JpegDecoder;

/// MJPEG decoder.
///
/// Each incoming packet is an independent JPEG image. The decoder
/// wraps `oximedia-image`'s JPEG decoder and converts the output
/// to `VideoFrame` with planar YUV or packed RGB format.
///
/// # Architecture
///
/// - Receives compressed MJPEG packets (each is a standalone JPEG frame)
/// - Decodes via `oximedia-image::jpeg::JpegDecoder`
/// - Converts decoded RGB pixels to the requested output format
/// - Produces `VideoFrame` with correct timestamps
#[derive(Debug)]
pub struct MjpegDecoder {
    /// Expected frame width (0 = auto-detect from first frame).
    width: u32,
    /// Expected frame height (0 = auto-detect from first frame).
    height: u32,
    /// Output pixel format.
    output_format: PixelFormat,
    /// Internal JPEG decoder.
    jpeg_decoder: JpegDecoder,
    /// Pending decoded frames.
    output_queue: Vec<VideoFrame>,
    /// Whether the decoder has been flushed.
    flushed: bool,
    /// Number of frames decoded.
    frame_count: u64,
}

impl MjpegDecoder {
    /// Create a new MJPEG decoder.
    ///
    /// # Arguments
    ///
    /// * `width` - Expected frame width (0 for auto-detect)
    /// * `height` - Expected frame height (0 for auto-detect)
    #[must_use]
    pub fn new(width: u32, height: u32) -> Self {
        Self {
            width,
            height,
            output_format: PixelFormat::Rgb24,
            jpeg_decoder: JpegDecoder::new(),
            output_queue: Vec::new(),
            flushed: false,
            frame_count: 0,
        }
    }

    /// Create a decoder with a specific output format.
    #[must_use]
    pub fn with_output_format(mut self, format: PixelFormat) -> Self {
        self.output_format = format;
        self
    }

    /// Get the number of frames decoded so far.
    #[must_use]
    pub fn frame_count(&self) -> u64 {
        self.frame_count
    }

    /// Probe an MJPEG packet to extract frame metadata without full decoding.
    ///
    /// # Errors
    ///
    /// Returns error if the data is not valid JPEG.
    pub fn probe_frame(data: &[u8]) -> CodecResult<MjpegFrameInfo> {
        if data.len() < 4 {
            return Err(CodecError::InvalidBitstream(
                "MJPEG data too short".to_string(),
            ));
        }

        // Check SOI
        if data[0] != 0xFF || data[1] != 0xD8 {
            return Err(CodecError::InvalidBitstream(
                "Not a JPEG frame (missing SOI)".to_string(),
            ));
        }

        // Check for AVI1 marker
        let marker_type = if Self::find_avi1_marker(data) {
            super::types::MjpegMarkerType::Avi1
        } else {
            super::types::MjpegMarkerType::Plain
        };

        // Find SOF0 to extract dimensions
        let (width, height) = Self::extract_dimensions(data)?;

        Ok(MjpegFrameInfo {
            width,
            height,
            marker_type,
            compressed_size: data.len(),
        })
    }

    /// Check if an AVI1 APP0 marker is present.
    fn find_avi1_marker(data: &[u8]) -> bool {
        // Search for "AVI1" string in APP0 segments
        data.windows(4).any(|w| w == b"AVI1")
    }

    /// Extract width and height from JPEG SOF0 segment.
    fn extract_dimensions(data: &[u8]) -> CodecResult<(u32, u32)> {
        let mut pos = 2; // Skip SOI

        while pos + 3 < data.len() {
            if data[pos] != 0xFF {
                pos += 1;
                continue;
            }

            let marker = data[pos + 1];
            pos += 2;

            match marker {
                0xC0 => {
                    // SOF0 — baseline DCT
                    if pos + 7 <= data.len() {
                        let _len = u16::from_be_bytes([data[pos], data[pos + 1]]);
                        let _precision = data[pos + 2];
                        let height = u16::from_be_bytes([data[pos + 3], data[pos + 4]]) as u32;
                        let width = u16::from_be_bytes([data[pos + 5], data[pos + 6]]) as u32;
                        return Ok((width, height));
                    }
                    return Err(CodecError::InvalidBitstream(
                        "SOF0 segment too short".to_string(),
                    ));
                }
                0xD9 => break, // EOI
                0xDA => break, // SOS — no SOF0 found before scan data
                0x00 | 0xFF => {
                    // Padding/stuffing
                    continue;
                }
                _ => {
                    // Skip segment
                    if pos + 1 < data.len() {
                        let seg_len = u16::from_be_bytes([data[pos], data[pos + 1]]) as usize;
                        pos += seg_len;
                    } else {
                        break;
                    }
                }
            }
        }

        Err(CodecError::InvalidBitstream(
            "No SOF0 marker found in JPEG data".to_string(),
        ))
    }

    /// Strip the AVI1 marker from MJPEG data to produce standard JPEG.
    ///
    /// Some JPEG decoders do not understand the AVI1 APP0 segment.
    /// This removes it while preserving the rest of the JPEG stream.
    fn strip_avi1_marker(data: &[u8]) -> Vec<u8> {
        let mut result = Vec::with_capacity(data.len());
        let mut pos = 0;

        // Copy SOI
        if data.len() >= 2 {
            result.extend_from_slice(&data[..2]);
            pos = 2;
        }

        while pos + 3 < data.len() {
            if data[pos] == 0xFF && data[pos + 1] == 0xE0 {
                // APP0 segment
                if pos + 3 < data.len() {
                    let seg_len = u16::from_be_bytes([data[pos + 2], data[pos + 3]]) as usize;
                    let seg_end = pos + 2 + seg_len;

                    // Check if this APP0 contains AVI1
                    let is_avi1 = pos + 6 < data.len() && data[pos + 4..].starts_with(b"AVI1");

                    if is_avi1 {
                        // Skip this segment entirely
                        pos = seg_end.min(data.len());
                        continue;
                    }
                }
            }

            // Not an AVI1 segment — copy the rest of the stream
            result.extend_from_slice(&data[pos..]);
            break;
        }

        if result.len() <= 2 && pos < data.len() {
            // Edge case: no APP0 segments found, copy everything after SOI
            result.extend_from_slice(&data[pos..]);
        }

        result
    }

    /// Decode a JPEG packet into a VideoFrame.
    fn decode_packet_inner(&mut self, data: &[u8], pts: i64) -> CodecResult<()> {
        if data.len() < 4 {
            return Err(CodecError::InvalidBitstream(
                "MJPEG packet too short".to_string(),
            ));
        }

        // Strip AVI1 marker if present (decode as standard JPEG)
        let clean_data = Self::strip_avi1_marker(data);

        // Decode JPEG
        let jpeg_frame = self
            .jpeg_decoder
            .decode(&clean_data)
            .map_err(|e| CodecError::DecoderError(format!("MJPEG decode failed: {e}")))?;

        // Auto-detect dimensions from first frame
        if self.width == 0 {
            self.width = jpeg_frame.width;
        }
        if self.height == 0 {
            self.height = jpeg_frame.height;
        }

        // Convert JpegFrame (interleaved RGB) to VideoFrame
        let video_frame = self.jpeg_frame_to_video_frame(&jpeg_frame, pts)?;
        self.output_queue.push(video_frame);
        self.frame_count += 1;

        Ok(())
    }

    /// Convert a decoded JpegFrame to a VideoFrame in the requested output format.
    fn jpeg_frame_to_video_frame(
        &self,
        jpeg_frame: &oximedia_image::jpeg::JpegFrame,
        pts: i64,
    ) -> CodecResult<VideoFrame> {
        let width = jpeg_frame.width;
        let height = jpeg_frame.height;
        let pixels = &jpeg_frame.pixels;

        match self.output_format {
            PixelFormat::Rgb24 => {
                let mut frame = VideoFrame::new(PixelFormat::Rgb24, width, height);
                frame.timestamp = Timestamp::new(pts, Rational::new(1, 1000));
                frame.frame_type = FrameType::Key;
                frame.planes = vec![Plane::with_dimensions(
                    pixels.clone(),
                    (width * 3) as usize,
                    width,
                    height,
                )];
                Ok(frame)
            }
            PixelFormat::Yuv420p => self.rgb_to_yuv420p(pixels, width, height, pts),
            PixelFormat::Yuv444p => self.rgb_to_yuv444p(pixels, width, height, pts),
            other => Err(CodecError::InvalidParameter(format!(
                "MJPEG decoder does not support output format: {other:?}"
            ))),
        }
    }

    /// Convert interleaved RGB to YUV 4:2:0 planar VideoFrame.
    fn rgb_to_yuv420p(
        &self,
        rgb: &[u8],
        width: u32,
        height: u32,
        pts: i64,
    ) -> CodecResult<VideoFrame> {
        let w = width as usize;
        let h = height as usize;
        let chroma_w = (w + 1) / 2;
        let chroma_h = (h + 1) / 2;

        let mut y_plane = vec![0u8; w * h];
        let mut u_plane = vec![128u8; chroma_w * chroma_h];
        let mut v_plane = vec![128u8; chroma_w * chroma_h];

        // First pass: compute all Y values
        for row in 0..h {
            for col in 0..w {
                let pix_idx = (row * w + col) * 3;
                if pix_idx + 2 < rgb.len() {
                    let r = rgb[pix_idx];
                    let g = rgb[pix_idx + 1];
                    let b = rgb[pix_idx + 2];
                    let (y, _cb, _cr) = oximedia_image::jpeg::rgb_to_ycbcr(r, g, b);
                    y_plane[row * w + col] = y.clamp(0.0, 255.0) as u8;
                }
            }
        }

        // Second pass: compute Cb/Cr for 2x2 blocks (average)
        for c_row in 0..chroma_h {
            for c_col in 0..chroma_w {
                let mut sum_cb = 0.0f32;
                let mut sum_cr = 0.0f32;
                let mut count = 0u32;

                for dy in 0..2 {
                    let row = c_row * 2 + dy;
                    if row >= h {
                        continue;
                    }
                    for dx in 0..2 {
                        let col = c_col * 2 + dx;
                        if col >= w {
                            continue;
                        }
                        let pix_idx = (row * w + col) * 3;
                        if pix_idx + 2 < rgb.len() {
                            let r = rgb[pix_idx];
                            let g = rgb[pix_idx + 1];
                            let b = rgb[pix_idx + 2];
                            let (_y, cb, cr) = oximedia_image::jpeg::rgb_to_ycbcr(r, g, b);
                            sum_cb += cb;
                            sum_cr += cr;
                            count += 1;
                        }
                    }
                }

                if count > 0 {
                    let c_idx = c_row * chroma_w + c_col;
                    u_plane[c_idx] = (sum_cb / count as f32).clamp(0.0, 255.0) as u8;
                    v_plane[c_idx] = (sum_cr / count as f32).clamp(0.0, 255.0) as u8;
                }
            }
        }

        let mut frame = VideoFrame::new(PixelFormat::Yuv420p, width, height);
        frame.timestamp = Timestamp::new(pts, Rational::new(1, 1000));
        frame.frame_type = FrameType::Key;
        frame.planes = vec![
            Plane::with_dimensions(y_plane, w, width, height),
            Plane::with_dimensions(u_plane, chroma_w, (width + 1) / 2, (height + 1) / 2),
            Plane::with_dimensions(v_plane, chroma_w, (width + 1) / 2, (height + 1) / 2),
        ];
        Ok(frame)
    }

    /// Convert interleaved RGB to YUV 4:4:4 planar VideoFrame.
    fn rgb_to_yuv444p(
        &self,
        rgb: &[u8],
        width: u32,
        height: u32,
        pts: i64,
    ) -> CodecResult<VideoFrame> {
        let w = width as usize;
        let h = height as usize;
        let plane_size = w * h;

        let mut y_plane = vec![0u8; plane_size];
        let mut u_plane = vec![128u8; plane_size];
        let mut v_plane = vec![128u8; plane_size];

        for idx in 0..plane_size {
            let pix_idx = idx * 3;
            if pix_idx + 2 < rgb.len() {
                let r = rgb[pix_idx];
                let g = rgb[pix_idx + 1];
                let b = rgb[pix_idx + 2];
                let (y, cb, cr) = oximedia_image::jpeg::rgb_to_ycbcr(r, g, b);
                y_plane[idx] = y.clamp(0.0, 255.0) as u8;
                u_plane[idx] = cb.clamp(0.0, 255.0) as u8;
                v_plane[idx] = cr.clamp(0.0, 255.0) as u8;
            }
        }

        let mut frame = VideoFrame::new(PixelFormat::Yuv444p, width, height);
        frame.timestamp = Timestamp::new(pts, Rational::new(1, 1000));
        frame.frame_type = FrameType::Key;
        frame.planes = vec![
            Plane::with_dimensions(y_plane, w, width, height),
            Plane::with_dimensions(u_plane, w, width, height),
            Plane::with_dimensions(v_plane, w, width, height),
        ];
        Ok(frame)
    }
}

impl VideoDecoder for MjpegDecoder {
    fn codec(&self) -> CodecId {
        CodecId::Mjpeg
    }

    fn send_packet(&mut self, data: &[u8], pts: i64) -> CodecResult<()> {
        if self.flushed {
            return Err(CodecError::InvalidParameter(
                "Cannot send packets after flush".to_string(),
            ));
        }
        self.decode_packet_inner(data, pts)
    }

    fn receive_frame(&mut self) -> CodecResult<Option<VideoFrame>> {
        if self.output_queue.is_empty() {
            Ok(None)
        } else {
            Ok(Some(self.output_queue.remove(0)))
        }
    }

    fn flush(&mut self) -> CodecResult<()> {
        self.flushed = true;
        // MJPEG has no buffered packets — each packet produces output immediately.
        Ok(())
    }

    fn reset(&mut self) {
        self.output_queue.clear();
        self.flushed = false;
        self.frame_count = 0;
    }

    fn output_format(&self) -> Option<PixelFormat> {
        Some(self.output_format)
    }

    fn dimensions(&self) -> Option<(u32, u32)> {
        if self.width > 0 && self.height > 0 {
            Some((self.width, self.height))
        } else {
            None
        }
    }
}

#[cfg(test)]
mod tests {
    use super::*;
    use crate::frame::Plane;
    use crate::traits::VideoEncoder;

    /// Create a minimal valid JPEG for testing.
    /// We use the actual encoder to produce real JPEG data.
    fn make_test_jpeg(width: u32, height: u32) -> Vec<u8> {
        use super::super::encoder::MjpegEncoder;
        use super::super::types::MjpegConfig;

        let config = MjpegConfig::new(width, height)
            .expect("valid config")
            .with_quality(85)
            .with_pixel_format(PixelFormat::Rgb24);
        let mut encoder = MjpegEncoder::new(config).expect("valid encoder");

        let size = (width * height * 3) as usize;
        let data = vec![128u8; size];
        let mut frame = VideoFrame::new(PixelFormat::Rgb24, width, height);
        frame.planes = vec![Plane::with_dimensions(
            data,
            (width * 3) as usize,
            width,
            height,
        )];
        frame.timestamp = Timestamp::new(0, Rational::new(1, 1000));
        frame.frame_type = FrameType::Key;

        encoder.send_frame(&frame).expect("encode failed");
        let pkt = encoder
            .receive_packet()
            .expect("receive failed")
            .expect("expected packet");
        pkt.data
    }

    #[test]
    fn test_decoder_creation() {
        let decoder = MjpegDecoder::new(640, 480);
        assert_eq!(decoder.codec(), CodecId::Mjpeg);
        assert_eq!(decoder.dimensions(), Some((640, 480)));
    }

    #[test]
    fn test_decoder_auto_detect_dimensions() {
        let decoder = MjpegDecoder::new(0, 0);
        assert_eq!(decoder.dimensions(), None);
    }

    #[test]
    fn test_decoder_output_format() {
        let decoder = MjpegDecoder::new(640, 480);
        assert_eq!(decoder.output_format(), Some(PixelFormat::Rgb24));

        let decoder = MjpegDecoder::new(640, 480).with_output_format(PixelFormat::Yuv420p);
        assert_eq!(decoder.output_format(), Some(PixelFormat::Yuv420p));
    }

    #[test]
    fn test_decode_jpeg_packet() {
        let jpeg_data = make_test_jpeg(16, 16);
        let mut decoder = MjpegDecoder::new(16, 16);

        let result = decoder.send_packet(&jpeg_data, 0);
        assert!(result.is_ok(), "decode failed: {result:?}");

        let frame = decoder
            .receive_frame()
            .expect("receive failed")
            .expect("expected frame");
        assert_eq!(frame.width, 16);
        assert_eq!(frame.height, 16);
        assert_eq!(frame.format, PixelFormat::Rgb24);
        assert_eq!(frame.frame_type, FrameType::Key);
        assert!(!frame.planes.is_empty());
    }

    #[test]
    fn test_decode_to_yuv420p() {
        let jpeg_data = make_test_jpeg(16, 16);
        let mut decoder = MjpegDecoder::new(16, 16).with_output_format(PixelFormat::Yuv420p);

        decoder.send_packet(&jpeg_data, 0).expect("decode failed");
        let frame = decoder
            .receive_frame()
            .expect("receive failed")
            .expect("expected frame");

        assert_eq!(frame.format, PixelFormat::Yuv420p);
        assert_eq!(frame.planes.len(), 3);
        // Y plane: full resolution
        assert_eq!(frame.planes[0].data.len(), 16 * 16);
        // Cb/Cr planes: half resolution
        assert_eq!(frame.planes[1].data.len(), 8 * 8);
        assert_eq!(frame.planes[2].data.len(), 8 * 8);
    }

    #[test]
    fn test_decode_multiple_packets() {
        let jpeg_data = make_test_jpeg(16, 16);
        let mut decoder = MjpegDecoder::new(16, 16);

        for i in 0..5 {
            decoder.send_packet(&jpeg_data, i).expect("decode failed");
            let frame = decoder
                .receive_frame()
                .expect("receive failed")
                .expect("expected frame");
            assert_eq!(frame.timestamp.pts, i);
        }

        assert_eq!(decoder.frame_count(), 5);
    }

    #[test]
    fn test_decode_invalid_data() {
        let mut decoder = MjpegDecoder::new(16, 16);
        let result = decoder.send_packet(&[0x00, 0x00, 0x00, 0x00], 0);
        assert!(result.is_err());
    }

    #[test]
    fn test_decode_too_short() {
        let mut decoder = MjpegDecoder::new(16, 16);
        let result = decoder.send_packet(&[0xFF, 0xD8], 0);
        assert!(result.is_err());
    }

    #[test]
    fn test_flush_prevents_more_packets() {
        let mut decoder = MjpegDecoder::new(16, 16);
        decoder.flush().expect("flush should succeed");

        let jpeg_data = make_test_jpeg(16, 16);
        let result = decoder.send_packet(&jpeg_data, 0);
        assert!(result.is_err());
    }

    #[test]
    fn test_reset() {
        let mut decoder = MjpegDecoder::new(16, 16);
        decoder.flush().expect("flush");
        decoder.reset();

        // Should be able to decode again after reset
        let jpeg_data = make_test_jpeg(16, 16);
        let result = decoder.send_packet(&jpeg_data, 0);
        assert!(result.is_ok());
    }

    #[test]
    fn test_probe_frame() {
        let jpeg_data = make_test_jpeg(16, 16);
        let info = MjpegDecoder::probe_frame(&jpeg_data);
        assert!(info.is_ok(), "probe failed: {info:?}");

        let info = info.expect("probe result");
        assert_eq!(info.width, 16);
        assert_eq!(info.height, 16);
        assert_eq!(info.compressed_size, jpeg_data.len());
    }

    #[test]
    fn test_probe_invalid_data() {
        let result = MjpegDecoder::probe_frame(&[0x00, 0x01, 0x02, 0x03]);
        assert!(result.is_err());
    }

    #[test]
    fn test_probe_too_short() {
        let result = MjpegDecoder::probe_frame(&[0xFF]);
        assert!(result.is_err());
    }

    #[test]
    fn test_strip_avi1_marker() {
        // Build JPEG with AVI1
        let jpeg_data = make_test_jpeg(16, 16);
        // The encoder adds AVI1, so stripping should produce valid JPEG
        let stripped = MjpegDecoder::strip_avi1_marker(&jpeg_data);
        assert!(stripped.len() <= jpeg_data.len());
        // Should start with SOI
        assert_eq!(stripped[0], 0xFF);
        assert_eq!(stripped[1], 0xD8);
    }

    #[test]
    fn test_encoder_decoder_roundtrip() {
        use super::super::encoder::MjpegEncoder;
        use super::super::types::MjpegConfig;

        // Create encoder
        let config = MjpegConfig::new(16, 16)
            .expect("valid config")
            .with_quality(95) // High quality for better roundtrip fidelity
            .with_pixel_format(PixelFormat::Rgb24);
        let mut encoder = MjpegEncoder::new(config).expect("valid encoder");

        // Create a test frame with known pixel values
        let w = 16u32;
        let h = 16u32;
        let mut rgb_data = vec![0u8; (w * h * 3) as usize];
        for y in 0..h {
            for x in 0..w {
                let idx = ((y * w + x) * 3) as usize;
                rgb_data[idx] = 200; // R
                rgb_data[idx + 1] = 100; // G
                rgb_data[idx + 2] = 50; // B
            }
        }

        let mut frame = VideoFrame::new(PixelFormat::Rgb24, w, h);
        frame.planes = vec![Plane::with_dimensions(
            rgb_data.clone(),
            (w * 3) as usize,
            w,
            h,
        )];
        frame.timestamp = Timestamp::new(42, Rational::new(1, 1000));
        frame.frame_type = FrameType::Key;

        // Encode
        encoder.send_frame(&frame).expect("encode failed");
        let pkt = encoder
            .receive_packet()
            .expect("receive failed")
            .expect("expected packet");

        // Decode
        let mut decoder = MjpegDecoder::new(w, h);
        decoder
            .send_packet(&pkt.data, pkt.pts)
            .expect("decode failed");
        let decoded = decoder
            .receive_frame()
            .expect("receive failed")
            .expect("expected frame");

        assert_eq!(decoded.width, w);
        assert_eq!(decoded.height, h);
        assert_eq!(decoded.format, PixelFormat::Rgb24);

        // JPEG is lossy, but uniform input should produce close output.
        // Check a few pixels are within tolerance (JPEG quantization error).
        let decoded_rgb = &decoded.planes[0].data;
        let tolerance = 15i32; // JPEG lossy tolerance
        for y in 2..14 {
            for x in 2..14 {
                let idx = ((y * w + x) * 3) as usize;
                if idx + 2 < decoded_rgb.len() {
                    let dr = (decoded_rgb[idx] as i32 - 200).abs();
                    let dg = (decoded_rgb[idx + 1] as i32 - 100).abs();
                    let db = (decoded_rgb[idx + 2] as i32 - 50).abs();
                    assert!(
                        dr <= tolerance && dg <= tolerance && db <= tolerance,
                        "Pixel ({x},{y}) too far: R={} G={} B={} (expected 200,100,50)",
                        decoded_rgb[idx],
                        decoded_rgb[idx + 1],
                        decoded_rgb[idx + 2]
                    );
                }
            }
        }
    }

    #[test]
    fn test_auto_detect_dimensions_on_decode() {
        let jpeg_data = make_test_jpeg(32, 24);
        let mut decoder = MjpegDecoder::new(0, 0);

        assert_eq!(decoder.dimensions(), None);
        decoder.send_packet(&jpeg_data, 0).expect("decode failed");
        // After decoding first frame, dimensions should be auto-detected
        assert_eq!(decoder.dimensions(), Some((32, 24)));
    }
}