oxigrid 0.1.2

Pure Rust Energy Systems Simulation & Optimization Library
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
//! Flexible Ramping Product (FRP) Optimization.
//!
//! The FRP is a market product procured by grid operators to manage net-load
//! variability from renewable integration.  It reserves *headroom* (upward)
//! and *footroom* (downward) in generators so that the system can ramp quickly
//! if the net load forecast is wrong.
//!
//! # Algorithm (merit-order dispatch)
//!
//! For each hour `h`:
//! 1. Compute **available FRP up** for each generator:
//!    `avail_up = min(P_max − P_current, ramp_up_rate)`
//! 2. Compute **available FRP down** for each generator:
//!    `avail_down = min(P_current − P_min, ramp_down_rate)`
//! 3. Sort committed generators by energy cost (merit order, cheapest first).
//! 4. Assign FRP in merit order until the hourly requirement is met or
//!    all headroom/footroom is exhausted.
//! 5. Record unserved \[MW\] if the requirement cannot be fully met.
//!
//! # References
//! CAISO (2014) *Flexible Ramping Product Technical Analysis*.
//! Gu, Y. & Xie, L. (2014) "Stochastic Look-Ahead Economic Dispatch
//! With Variable Generation Resources", *IEEE Trans. Power Syst.*

use serde::{Deserialize, Serialize};
use thiserror::Error;

// ─── Error ────────────────────────────────────────────────────────────────────

/// Errors from the FRP optimizer.
#[derive(Debug, Error)]
pub enum FrpError {
    /// Hour dimension mismatch between config and generator schedule.
    #[error("schedule length {got} does not match n_hours {expected}")]
    ScheduleLengthMismatch { got: usize, expected: usize },
    /// Invalid configuration.
    #[error("invalid FRP config: {0}")]
    InvalidConfig(String),
}

// ─── Configuration ────────────────────────────────────────────────────────────

/// Configuration for the Flexible Ramping Product optimizer.
#[derive(Debug, Clone, Serialize, Deserialize)]
pub struct FrpConfig {
    /// Number of dispatch hours.
    pub n_hours: usize,
    /// Number of generators.
    pub n_generators: usize,
    /// Required upward ramping capability \[MW\] per hour.
    pub ramping_requirement_mw_per_h: Vec<f64>,
    /// Required downward ramping capability \[MW\] per hour.
    pub down_ramp_requirement_mw_per_h: Vec<f64>,
    /// Payment rate for FRP capability \[USD/MW\].
    pub frp_price_usd_per_mw: f64,
    /// Spinning reserve price \[USD/MW\].
    pub reserve_price_usd_per_mw: f64,
}

// ─── Generator ────────────────────────────────────────────────────────────────

/// A generator participating in the FRP market.
#[derive(Debug, Clone, Serialize, Deserialize)]
pub struct RampingGenerator {
    /// Generator identifier.
    pub id: usize,
    /// Minimum stable output \[MW\].
    pub p_min_mw: f64,
    /// Maximum rated output \[MW\].
    pub p_max_mw: f64,
    /// Maximum upward ramp capability \[MW/h\].
    pub ramp_up_mw_per_h: f64,
    /// Maximum downward ramp capability \[MW/h\].
    pub ramp_down_mw_per_h: f64,
    /// Marginal energy cost \[USD/MWh\].
    pub cost_per_mwh: f64,
    /// Hourly commitment schedule (`true` = online).
    pub commitment: Vec<bool>,
    /// Pre-determined energy dispatch \[MW\] per hour.
    pub dispatch_mw: Vec<f64>,
}

// ─── Result ───────────────────────────────────────────────────────────────────

/// Result of the FRP optimization.
#[derive(Debug, Clone, Serialize, Deserialize)]
pub struct FrpResult {
    /// Upward FRP allocated per generator per hour \[MW\]:
    /// `upward_frp_mw[hour][generator_index]`.
    pub upward_frp_mw: Vec<Vec<f64>>,
    /// Downward FRP allocated per generator per hour \[MW\]:
    /// `downward_frp_mw[hour][generator_index]`.
    pub downward_frp_mw: Vec<Vec<f64>>,
    /// Whether the hourly up-ramp requirement is met.
    pub frp_requirement_met: Vec<bool>,
    /// Total FRP procurement cost \[USD\].
    pub frp_cost_usd: f64,
    /// Unmet upward ramping requirement \[MW\] per hour.
    pub unserved_frp_mw: Vec<f64>,
    /// Hours where the upward FRP constraint is exactly tight (binding).
    pub binding_hours: Vec<usize>,
}

// ─── Optimizer ────────────────────────────────────────────────────────────────

/// Flexible Ramping Product optimizer.
///
/// # Example
/// ```rust
/// use oxigrid::optimize::dispatch::ramp_product::{
///     FrpConfig, FrpOptimizer, RampingGenerator,
/// };
///
/// let config = FrpConfig {
///     n_hours: 2,
///     n_generators: 1,
///     ramping_requirement_mw_per_h: vec![50.0, 50.0],
///     down_ramp_requirement_mw_per_h: vec![30.0, 30.0],
///     frp_price_usd_per_mw: 5.0,
///     reserve_price_usd_per_mw: 3.0,
/// };
/// let mut opt = FrpOptimizer::new(config);
/// opt.add_generator(RampingGenerator {
///     id: 0, p_min_mw: 0.0, p_max_mw: 200.0,
///     ramp_up_mw_per_h: 100.0, ramp_down_mw_per_h: 80.0,
///     cost_per_mwh: 30.0,
///     commitment: vec![true, true],
///     dispatch_mw: vec![100.0, 110.0],
/// });
/// let result = opt.optimize().unwrap();
/// assert!(result.frp_requirement_met[0]);
/// ```
pub struct FrpOptimizer {
    config: FrpConfig,
    generators: Vec<RampingGenerator>,
}

impl FrpOptimizer {
    /// Create a new FRP optimizer with the given configuration.
    pub fn new(config: FrpConfig) -> Self {
        Self {
            config,
            generators: Vec::new(),
        }
    }

    /// Register a generator for FRP market participation.
    pub fn add_generator(&mut self, gen: RampingGenerator) {
        self.generators.push(gen);
    }

    /// Run the merit-order FRP allocation.
    pub fn optimize(&self) -> Result<FrpResult, FrpError> {
        let n_h = self.config.n_hours;

        // Validate
        if self.config.ramping_requirement_mw_per_h.len() != n_h {
            return Err(FrpError::InvalidConfig(
                "ramping_requirement_mw_per_h length != n_hours".into(),
            ));
        }
        if self.config.down_ramp_requirement_mw_per_h.len() != n_h {
            return Err(FrpError::InvalidConfig(
                "down_ramp_requirement_mw_per_h length != n_hours".into(),
            ));
        }
        for gen in &self.generators {
            if gen.commitment.len() != n_h {
                return Err(FrpError::ScheduleLengthMismatch {
                    got: gen.commitment.len(),
                    expected: n_h,
                });
            }
            if gen.dispatch_mw.len() != n_h {
                return Err(FrpError::ScheduleLengthMismatch {
                    got: gen.dispatch_mw.len(),
                    expected: n_h,
                });
            }
        }

        let n_gen = self.generators.len();
        let mut upward_frp_mw: Vec<Vec<f64>> = vec![vec![0.0; n_gen]; n_h];
        let mut downward_frp_mw: Vec<Vec<f64>> = vec![vec![0.0; n_gen]; n_h];
        let mut frp_requirement_met: Vec<bool> = vec![false; n_h];
        let mut unserved_frp_mw: Vec<f64> = vec![0.0; n_h];
        let mut binding_hours: Vec<usize> = Vec::new();
        let mut total_frp_cost: f64 = 0.0;

        // Merit-order index: sort generators by cost (cheapest first)
        let mut merit_order: Vec<usize> = (0..n_gen).collect();
        merit_order.sort_by(|&a, &b| {
            self.generators[a]
                .cost_per_mwh
                .partial_cmp(&self.generators[b].cost_per_mwh)
                .unwrap_or(std::cmp::Ordering::Equal)
        });

        for h in 0..n_h {
            let req_up = self.config.ramping_requirement_mw_per_h[h];
            let req_dn = self.config.down_ramp_requirement_mw_per_h[h];

            let mut remaining_up = req_up;
            let mut remaining_dn = req_dn;

            for &gi in &merit_order {
                let gen = &self.generators[gi];
                if !gen.commitment[h] {
                    continue; // offline generators cannot provide FRP
                }

                let dispatch = gen.dispatch_mw[h];

                // Upward FRP = min(headroom, ramp_up_rate)
                let headroom = (gen.p_max_mw - dispatch).max(0.0);
                let avail_up = headroom.min(gen.ramp_up_mw_per_h);
                let alloc_up = avail_up.min(remaining_up);
                upward_frp_mw[h][gi] = alloc_up;
                remaining_up -= alloc_up;
                total_frp_cost += alloc_up * self.config.frp_price_usd_per_mw;

                // Downward FRP = min(footroom, ramp_down_rate)
                let footroom = (dispatch - gen.p_min_mw).max(0.0);
                let avail_dn = footroom.min(gen.ramp_down_mw_per_h);
                let alloc_dn = avail_dn.min(remaining_dn);
                downward_frp_mw[h][gi] = alloc_dn;
                remaining_dn -= alloc_dn;
            }

            unserved_frp_mw[h] = remaining_up.max(0.0);
            frp_requirement_met[h] = remaining_up <= 1e-6; // effectively zero

            let served_up = req_up - remaining_up.max(0.0);
            // Binding: served within 1 MW of requirement
            if (served_up - req_up).abs() <= 1.0 && req_up > 0.0 {
                binding_hours.push(h);
            }
        }

        Ok(FrpResult {
            upward_frp_mw,
            downward_frp_mw,
            frp_requirement_met,
            frp_cost_usd: total_frp_cost,
            unserved_frp_mw,
            binding_hours,
        })
    }
}

// ─── Tests ────────────────────────────────────────────────────────────────────

#[cfg(test)]
mod tests {
    use super::*;

    fn single_gen_config(n_hours: usize, req_up: f64) -> FrpConfig {
        FrpConfig {
            n_hours,
            n_generators: 1,
            ramping_requirement_mw_per_h: vec![req_up; n_hours],
            down_ramp_requirement_mw_per_h: vec![req_up * 0.5; n_hours],
            frp_price_usd_per_mw: 5.0,
            reserve_price_usd_per_mw: 3.0,
        }
    }

    fn gen_online(n_h: usize, pmax: f64, ramp: f64, dispatch: f64, cost: f64) -> RampingGenerator {
        RampingGenerator {
            id: 0,
            p_min_mw: 0.0,
            p_max_mw: pmax,
            ramp_up_mw_per_h: ramp,
            ramp_down_mw_per_h: ramp,
            cost_per_mwh: cost,
            commitment: vec![true; n_h],
            dispatch_mw: vec![dispatch; n_h],
        }
    }

    // ── Test 1 ─────────────────────────────────────────────────────────────────
    /// Sufficient ramp capacity → all hours met.
    #[test]
    fn test_sufficient_ramp_capacity_all_met() {
        let mut opt = FrpOptimizer::new(single_gen_config(3, 50.0));
        // P_max=200, dispatch=100 → headroom=100, ramp=120 → avail=100 > req=50
        opt.add_generator(gen_online(3, 200.0, 120.0, 100.0, 30.0));
        let res = opt.optimize().expect("optimize failed");
        for h in 0..3 {
            assert!(
                res.frp_requirement_met[h],
                "hour {h} requirement must be met"
            );
            assert_eq!(res.unserved_frp_mw[h], 0.0, "no unserved FRP at hour {h}");
        }
    }

    // ── Test 2 ─────────────────────────────────────────────────────────────────
    /// Generator at max output (no headroom) → unserved FRP = requirement.
    #[test]
    fn test_insufficient_capacity_unserved() {
        let mut opt = FrpOptimizer::new(single_gen_config(2, 50.0));
        // dispatch == P_max → headroom = 0
        opt.add_generator(gen_online(2, 100.0, 100.0, 100.0, 30.0));
        let res = opt.optimize().expect("optimize failed");
        for h in 0..2 {
            assert!(
                !res.frp_requirement_met[h],
                "requirement must be unmet when no headroom"
            );
            assert!(
                (res.unserved_frp_mw[h] - 50.0).abs() < 1e-9,
                "unserved must equal requirement when headroom=0"
            );
        }
    }

    // ── Test 3 ─────────────────────────────────────────────────────────────────
    /// Merit order: cheapest generator provides FRP first.
    #[test]
    fn test_merit_order_cheapest_first() {
        let n_h = 1;
        let config = FrpConfig {
            n_hours: n_h,
            n_generators: 2,
            ramping_requirement_mw_per_h: vec![30.0],
            down_ramp_requirement_mw_per_h: vec![20.0],
            frp_price_usd_per_mw: 10.0,
            reserve_price_usd_per_mw: 5.0,
        };
        let mut opt = FrpOptimizer::new(config);
        // Generator 0: expensive, plenty of headroom
        opt.add_generator(RampingGenerator {
            id: 0,
            p_min_mw: 0.0,
            p_max_mw: 200.0,
            ramp_up_mw_per_h: 100.0,
            ramp_down_mw_per_h: 80.0,
            cost_per_mwh: 80.0,
            commitment: vec![true],
            dispatch_mw: vec![100.0],
        });
        // Generator 1: cheap, plenty of headroom
        opt.add_generator(RampingGenerator {
            id: 1,
            p_min_mw: 0.0,
            p_max_mw: 200.0,
            ramp_up_mw_per_h: 100.0,
            ramp_down_mw_per_h: 80.0,
            cost_per_mwh: 20.0,
            commitment: vec![true],
            dispatch_mw: vec![100.0],
        });

        let res = opt.optimize().expect("optimize failed");
        // Cheap generator (index 1 in the array, first in merit order) should
        // provide the full 30 MW; expensive (index 0) should provide nothing.
        assert!(
            res.upward_frp_mw[0][1] >= 30.0 - 1e-9,
            "cheap generator (index 1) should provide 30 MW FRP"
        );
        assert!(
            res.upward_frp_mw[0][0] < 1e-9,
            "expensive generator should not be dispatched for FRP"
        );
    }

    // ── Test 4 ─────────────────────────────────────────────────────────────────
    /// Ramp rate constrains available FRP even when headroom is large.
    #[test]
    fn test_ramp_rate_constraint_limits_frp() {
        let mut opt = FrpOptimizer::new(single_gen_config(1, 100.0));
        // P_max=200, dispatch=0 → headroom=200, but ramp_up=40 → avail_up=40 < req=100
        opt.add_generator(gen_online(1, 200.0, 40.0, 0.0, 30.0));
        let res = opt.optimize().expect("optimize failed");
        assert!(
            !res.frp_requirement_met[0],
            "ramp-limited: requirement of 100 MW should not be met with ramp=40"
        );
        assert!(
            (res.unserved_frp_mw[0] - 60.0).abs() < 1e-9,
            "unserved = 100 - 40 = 60"
        );
        assert!(
            (res.upward_frp_mw[0][0] - 40.0).abs() < 1e-9,
            "allocated FRP = ramp limit = 40 MW"
        );
    }

    // ── Test 5 ─────────────────────────────────────────────────────────────────
    /// Binding hours correctly identified (hours where req is exactly met).
    #[test]
    fn test_binding_hours_identified() {
        let n_h = 3;
        let config = FrpConfig {
            n_hours: n_h,
            n_generators: 1,
            ramping_requirement_mw_per_h: vec![50.0, 80.0, 50.0],
            down_ramp_requirement_mw_per_h: vec![20.0; n_h],
            frp_price_usd_per_mw: 5.0,
            reserve_price_usd_per_mw: 3.0,
        };
        let mut opt = FrpOptimizer::new(config);
        // headroom = 200 - 100 = 100; ramp = 50 → avail_up = 50
        // Hours 0,2: req=50, served=50 → binding
        // Hour 1: req=80, served=50 → NOT binding (unserved)
        opt.add_generator(gen_online(n_h, 200.0, 50.0, 100.0, 30.0));
        let res = opt.optimize().expect("optimize failed");
        assert!(
            res.binding_hours.contains(&0),
            "hour 0 (req=50, avail=50) should be binding"
        );
        assert!(
            res.binding_hours.contains(&2),
            "hour 2 (req=50, avail=50) should be binding"
        );
    }

    // ── Test 6: cost is non-negative ──────────────────────────────────────────
    #[test]
    fn test_frp_cost_non_negative() {
        let mut opt = FrpOptimizer::new(single_gen_config(4, 20.0));
        opt.add_generator(gen_online(4, 150.0, 80.0, 80.0, 40.0));
        let res = opt.optimize().expect("optimize failed");
        assert!(res.frp_cost_usd >= 0.0);
    }

    // ── Test 7: offline generator skipped ─────────────────────────────────────
    #[test]
    fn test_offline_generator_skipped() {
        let n_h = 3;
        let req = 50.0;
        let config = FrpConfig {
            n_hours: n_h,
            n_generators: 1,
            ramping_requirement_mw_per_h: vec![req; n_h],
            down_ramp_requirement_mw_per_h: vec![req * 0.5; n_h],
            frp_price_usd_per_mw: 5.0,
            reserve_price_usd_per_mw: 3.0,
        };
        let mut opt = FrpOptimizer::new(config);
        opt.add_generator(RampingGenerator {
            id: 0,
            p_min_mw: 0.0,
            p_max_mw: 200.0,
            ramp_up_mw_per_h: 100.0,
            ramp_down_mw_per_h: 80.0,
            cost_per_mwh: 30.0,
            commitment: vec![false; n_h],
            dispatch_mw: vec![100.0; n_h],
        });
        let res = opt
            .optimize()
            .expect("optimize should succeed with offline generator");
        for h in 0..n_h {
            assert_eq!(
                res.upward_frp_mw[h][0], 0.0,
                "offline generator must not be allocated FRP at hour {h}"
            );
            assert!(
                (res.unserved_frp_mw[h] - req).abs() < 1e-9,
                "unserved must equal requirement at hour {h} when all generators offline"
            );
        }
    }

    // ── Test 8: schedule length mismatch returns error ─────────────────────────
    #[test]
    fn test_schedule_length_mismatch_error() {
        let n_h = 4;
        let mut opt = FrpOptimizer::new(single_gen_config(n_h, 50.0));
        // commitment has length 2, not 4 → should trigger ScheduleLengthMismatch
        opt.add_generator(RampingGenerator {
            id: 0,
            p_min_mw: 0.0,
            p_max_mw: 200.0,
            ramp_up_mw_per_h: 100.0,
            ramp_down_mw_per_h: 80.0,
            cost_per_mwh: 30.0,
            commitment: vec![true, true], // length 2, not 4
            dispatch_mw: vec![100.0; n_h],
        });
        let result = opt.optimize();
        assert!(
            matches!(result, Err(FrpError::ScheduleLengthMismatch { .. })),
            "expected ScheduleLengthMismatch error, got {result:?}"
        );
    }

    // ── Test 9: downward FRP allocated correctly ───────────────────────────────
    #[test]
    fn test_downward_frp_allocated() {
        let config = FrpConfig {
            n_hours: 1,
            n_generators: 1,
            ramping_requirement_mw_per_h: vec![0.0], // no upward requirement
            down_ramp_requirement_mw_per_h: vec![60.0],
            frp_price_usd_per_mw: 5.0,
            reserve_price_usd_per_mw: 3.0,
        };
        let mut opt = FrpOptimizer::new(config);
        opt.add_generator(RampingGenerator {
            id: 0,
            p_min_mw: 0.0,
            p_max_mw: 200.0,
            ramp_up_mw_per_h: 100.0,
            ramp_down_mw_per_h: 80.0,
            cost_per_mwh: 30.0,
            commitment: vec![true],
            dispatch_mw: vec![100.0], // footroom = 100, ramp_down=80 > req=60
        });
        let res = opt.optimize().expect("optimize should succeed");
        assert!(
            (res.downward_frp_mw[0][0] - 60.0).abs() < 1e-9,
            "downward FRP must be 60.0 MW (limited by requirement, not ramp or footroom)"
        );
    }

    // ── Test 10: FRP cost = allocated MW × price ───────────────────────────────
    #[test]
    fn test_frp_cost_equals_allocated_times_price() {
        let price = 10.0;
        let req = 30.0;
        let config = FrpConfig {
            n_hours: 1,
            n_generators: 1,
            ramping_requirement_mw_per_h: vec![req],
            down_ramp_requirement_mw_per_h: vec![0.0],
            frp_price_usd_per_mw: price,
            reserve_price_usd_per_mw: 3.0,
        };
        let mut opt = FrpOptimizer::new(config);
        // headroom = 200 - 50 = 150, ramp = 100 → avail = 100 > req = 30
        opt.add_generator(gen_online(1, 200.0, 100.0, 50.0, 30.0));
        let res = opt.optimize().expect("optimize should succeed");
        let expected_cost = req * price; // 300.0
        assert!(
            (res.frp_cost_usd - expected_cost).abs() < 1e-9,
            "cost must equal allocated ({req} MW) × price ({price} USD/MW) = {expected_cost}, got {}",
            res.frp_cost_usd
        );
    }

    // ── Test 11: zero requirement → all hours met ──────────────────────────────
    #[test]
    fn test_zero_requirement_all_met() {
        let n_h = 5;
        let config = FrpConfig {
            n_hours: n_h,
            n_generators: 1,
            ramping_requirement_mw_per_h: vec![0.0; n_h],
            down_ramp_requirement_mw_per_h: vec![0.0; n_h],
            frp_price_usd_per_mw: 5.0,
            reserve_price_usd_per_mw: 3.0,
        };
        let mut opt = FrpOptimizer::new(config);
        opt.add_generator(gen_online(n_h, 200.0, 100.0, 100.0, 30.0));
        let res = opt
            .optimize()
            .expect("optimize should succeed with zero requirements");
        for h in 0..n_h {
            assert!(
                res.frp_requirement_met[h],
                "zero requirement must always be met at hour {h}"
            );
            assert_eq!(
                res.unserved_frp_mw[h], 0.0,
                "unserved must be 0.0 when requirement is 0.0 at hour {h}"
            );
        }
    }

    // ── Test 12: two generators share the FRP requirement ─────────────────────
    #[test]
    fn test_multiple_generators_share_load() {
        let req = 50.0;
        let config = FrpConfig {
            n_hours: 1,
            n_generators: 2,
            ramping_requirement_mw_per_h: vec![req],
            down_ramp_requirement_mw_per_h: vec![0.0],
            frp_price_usd_per_mw: 5.0,
            reserve_price_usd_per_mw: 3.0,
        };
        let mut opt = FrpOptimizer::new(config);
        // Each generator: headroom=130-100=30, ramp=50 → avail_up=30
        // Together: 30+30=60 >= req=50
        for id in 0..2_usize {
            opt.add_generator(RampingGenerator {
                id,
                p_min_mw: 0.0,
                p_max_mw: 130.0,
                ramp_up_mw_per_h: 50.0,
                ramp_down_mw_per_h: 50.0,
                cost_per_mwh: 30.0 + id as f64, // slightly different costs
                commitment: vec![true],
                dispatch_mw: vec![100.0],
            });
        }
        let res = opt.optimize().expect("optimize should succeed");
        let total_up: f64 = res.upward_frp_mw[0].iter().sum();
        assert!(
            (total_up - req).abs() < 1e-9,
            "total upward FRP must equal requirement {req}, got {total_up}"
        );
    }

    // ── Test 13: no generators → all unserved ─────────────────────────────────
    #[test]
    fn test_no_generators_returns_unserved() {
        let req = 40.0;
        // n_generators=1 in config but we add no generator to the optimizer
        let config = FrpConfig {
            n_hours: 1,
            n_generators: 1,
            ramping_requirement_mw_per_h: vec![req],
            down_ramp_requirement_mw_per_h: vec![20.0],
            frp_price_usd_per_mw: 5.0,
            reserve_price_usd_per_mw: 3.0,
        };
        let opt = FrpOptimizer::new(config);
        // No generator added — optimizer must still return Ok with all unserved
        let res = opt
            .optimize()
            .expect("optimize must succeed even with no generators");
        assert!(
            (res.unserved_frp_mw[0] - req).abs() < 1e-9,
            "all requirement must be unserved when no generators present, got {}",
            res.unserved_frp_mw[0]
        );
    }
}