oxideav-core 0.1.1

Core types for oxideav — timestamps, packets, frames, media formats (pure Rust, no C deps)
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
//! Shared bit-level I/O — MSB-first and LSB-first readers and writers.
//!
//! Every `oxideav-*` codec crate used to ship its own bitwriter /
//! bitreader implementation. Those implementations converged on the
//! same two layouts (MSB-first for ~everything, LSB-first for Vorbis)
//! with only cosmetic method-name differences, so the core copy lives
//! here and each codec crate pulls it in via `oxideav_core::bits`.
//!
//! # Bit orders
//!
//! * [`BitReader`] / [`BitWriter`] — **MSB-first**. Within each byte
//!   the high bit is read/written first. This matches AAC, MP1/2/3,
//!   FLAC, Speex, H.263/4, MPEG-1/2/4 video, and just about every
//!   modern codec bitstream.
//! * [`BitReaderLsb`] / [`BitWriterLsb`] — **LSB-first**. Within each
//!   byte the low bit is read/written first. Vorbis I §2.1.4 packs
//!   its bitstream this way.
//!
//! Both variants carry a 64-bit accumulator so callers can request up
//! to 32 bits per call without straddling refill logic. 64-bit values
//! are handled in two halves by `read_u64` / `write_u64`.
//!
//! # Method naming
//!
//! Every writer exposes both of these names for the same operation —
//! historical drift across the codec crates made both common, and
//! keeping both as aliases lets migration stay mechanical:
//!
//! * `write_u32(value, n)` ≡ `write_bits(value, n)`  — append low `n` bits
//! * `finish(self)`        ≡ `into_bytes(self)`      — pad + consume
//!
//! Similarly `skip(n)` and `consume(n)` are aliases on the reader.

use crate::{Error, Result};

// ==================== MSB-first ====================

/// MSB-first bit reader over a borrowed byte slice.
///
/// Copy+Clone: the reader owns no heap state, only a borrowed slice
/// and a handful of counters, so `let saved = br;` followed by a
/// later `br = saved;` is a valid checkpoint/restore — some codec
/// parsers (e.g. MPEG-4 Part 2's VOP resync) use exactly that pattern.
#[derive(Clone, Copy)]
pub struct BitReader<'a> {
    data: &'a [u8],
    /// Index of the next byte to load into the accumulator.
    byte_pos: usize,
    /// Bits buffered from `data`, left-aligned (high bit = next to consume).
    acc: u64,
    /// Valid bits currently in `acc`, in the range `0..=64`.
    bits_in_acc: u32,
}

impl<'a> BitReader<'a> {
    pub fn new(data: &'a [u8]) -> Self {
        Self {
            data,
            byte_pos: 0,
            acc: 0,
            bits_in_acc: 0,
        }
    }

    /// Start reading at a specific byte offset (useful for parsers that
    /// need to re-anchor into the middle of a buffer without copying).
    pub fn with_position(data: &'a [u8], byte_pos: usize) -> Self {
        let byte_pos = byte_pos.min(data.len());
        Self {
            data,
            byte_pos,
            acc: 0,
            bits_in_acc: 0,
        }
    }

    /// Bits already consumed from the logical stream.
    pub fn bit_position(&self) -> u64 {
        self.byte_pos as u64 * 8 - self.bits_in_acc as u64
    }

    /// Byte offset of the reader (floor of `bit_position / 8`).
    pub fn byte_position(&self) -> usize {
        (self.bit_position() / 8) as usize
    }

    /// Total remaining bits (buffered + unread from the slice).
    pub fn bits_remaining(&self) -> u64 {
        self.bits_in_acc as u64 + ((self.data.len() - self.byte_pos) as u64) * 8
    }

    /// True if the reader is positioned on a byte boundary.
    pub fn is_byte_aligned(&self) -> bool {
        self.bits_in_acc % 8 == 0
    }

    /// Skip remaining bits in the current byte, leaving the reader byte-aligned.
    pub fn align_to_byte(&mut self) {
        let drop = self.bits_in_acc % 8;
        self.acc <<= drop;
        self.bits_in_acc -= drop;
    }

    fn refill(&mut self) {
        while self.bits_in_acc <= 56 && self.byte_pos < self.data.len() {
            self.acc |= (self.data[self.byte_pos] as u64) << (56 - self.bits_in_acc);
            self.bits_in_acc += 8;
            self.byte_pos += 1;
        }
    }

    /// Read `n` bits (0..=32) as an unsigned integer.
    pub fn read_u32(&mut self, n: u32) -> Result<u32> {
        debug_assert!(n <= 32, "BitReader::read_u32 supports up to 32 bits");
        if n == 0 {
            return Ok(0);
        }
        if self.bits_in_acc < n {
            self.refill();
            if self.bits_in_acc < n {
                return Err(Error::invalid("bitreader: out of bits"));
            }
        }
        let v = (self.acc >> (64 - n)) as u32;
        self.acc <<= n;
        self.bits_in_acc -= n;
        Ok(v)
    }

    /// Read `n` bits (0..=64) as an unsigned integer.
    pub fn read_u64(&mut self, n: u32) -> Result<u64> {
        debug_assert!(n <= 64);
        if n <= 32 {
            return self.read_u32(n).map(|v| v as u64);
        }
        let hi = self.read_u32(n - 32)? as u64;
        let lo = self.read_u32(32)? as u64;
        Ok((hi << 32) | lo)
    }

    /// Read `n` bits as a signed integer, sign-extended from the high bit.
    pub fn read_i32(&mut self, n: u32) -> Result<i32> {
        if n == 0 {
            return Ok(0);
        }
        let raw = self.read_u32(n)? as i32;
        let shift = 32 - n;
        Ok((raw << shift) >> shift)
    }

    /// Read a single bit as a bool.
    pub fn read_bit(&mut self) -> Result<bool> {
        Ok(self.read_u32(1)? != 0)
    }

    /// Read a single bit as `0` or `1` (some codec specs phrase flags this way).
    pub fn read_u1(&mut self) -> Result<u32> {
        self.read_u32(1)
    }

    /// Peek `n` bits (0..=32) without consuming them.
    pub fn peek_u32(&mut self, n: u32) -> Result<u32> {
        debug_assert!(n <= 32);
        if n == 0 {
            return Ok(0);
        }
        if self.bits_in_acc < n {
            self.refill();
            if self.bits_in_acc < n {
                return Err(Error::invalid("bitreader: out of bits for peek"));
            }
        }
        Ok((self.acc >> (64 - n)) as u32)
    }

    /// Discard `n` bits.
    pub fn skip(&mut self, n: u32) -> Result<()> {
        let mut left = n;
        while left > 32 {
            self.read_u32(32)?;
            left -= 32;
        }
        self.read_u32(left)?;
        Ok(())
    }

    /// Alias for [`Self::skip`] — some spec wordings prefer "consume".
    pub fn consume(&mut self, n: u32) -> Result<()> {
        self.skip(n)
    }

    /// Read a unary-coded value: the count of leading zero bits, terminated
    /// by a single `1`. Used by FLAC Rice residuals and any other codec
    /// that needs variable-length counts. Uses `leading_zeros()` on the
    /// 64-bit accumulator for the fast path.
    pub fn read_unary(&mut self) -> Result<u32> {
        let mut count = 0u32;
        loop {
            if self.bits_in_acc == 0 {
                self.refill();
                if self.bits_in_acc == 0 {
                    return Err(Error::invalid("bitreader: out of bits in unary code"));
                }
            }
            let lz_total = self.acc.leading_zeros();
            let lz_avail = lz_total.min(self.bits_in_acc);
            count = count
                .checked_add(lz_avail)
                .ok_or_else(|| Error::invalid("bitreader: unary count overflow"))?;
            // Shifting a u64 by 64 is UB in Rust — guard that case. It only
            // arises for very long zero runs.
            if lz_avail >= 64 {
                self.acc = 0;
            } else {
                self.acc <<= lz_avail;
            }
            self.bits_in_acc -= lz_avail;
            if lz_avail < lz_total || self.bits_in_acc == 0 {
                continue;
            }
            // Consume the terminating 1 bit.
            self.acc <<= 1;
            self.bits_in_acc -= 1;
            return Ok(count);
        }
    }

    /// Read `n` bytes. Requires the reader to be byte-aligned.
    pub fn read_bytes(&mut self, n: usize) -> Result<Vec<u8>> {
        if !self.is_byte_aligned() {
            return Err(Error::invalid(
                "bitreader: read_bytes requires byte alignment",
            ));
        }
        self.align_to_byte();
        let start = self.byte_pos - (self.bits_in_acc as usize / 8);
        // `bits_in_acc` is a multiple of 8 here (because we're aligned); each
        // full byte in the accumulator is one unconsumed input byte whose
        // `byte_pos` has already been advanced — so the actual logical cursor
        // is `byte_pos - bits_in_acc / 8`.
        if start + n > self.data.len() {
            return Err(Error::invalid("bitreader: read_bytes past end"));
        }
        let out = self.data[start..start + n].to_vec();
        // Advance: empty the accumulator and re-anchor `byte_pos` past the
        // copied region.
        self.acc = 0;
        self.bits_in_acc = 0;
        self.byte_pos = start + n;
        Ok(out)
    }
}

/// MSB-first bit writer over an internal byte buffer.
pub struct BitWriter {
    data: Vec<u8>,
    /// Bits buffered at the *high* end of `acc` (next-to-emit at top).
    acc: u64,
    /// Valid bits currently in `acc` (0..=64).
    bits_in_acc: u32,
}

impl BitWriter {
    pub fn new() -> Self {
        Self {
            data: Vec::new(),
            acc: 0,
            bits_in_acc: 0,
        }
    }

    pub fn with_capacity(cap: usize) -> Self {
        Self {
            data: Vec::with_capacity(cap),
            acc: 0,
            bits_in_acc: 0,
        }
    }

    /// Total bits written so far (including any in the unflushed accumulator).
    pub fn bit_position(&self) -> u64 {
        self.data.len() as u64 * 8 + self.bits_in_acc as u64
    }

    /// Bytes of output produced so far (excluding any unflushed partial byte).
    pub fn byte_len(&self) -> usize {
        self.data.len()
    }

    /// True if the writer is currently on a byte boundary.
    pub fn is_byte_aligned(&self) -> bool {
        self.bits_in_acc % 8 == 0
    }

    /// Append `n` bits (0..=32) from the low `n` bits of `value`, MSB first.
    pub fn write_u32(&mut self, value: u32, n: u32) {
        debug_assert!(n <= 32, "BitWriter::write_u32 supports up to 32 bits");
        if n == 0 {
            return;
        }
        let mask: u32 = if n == 32 { u32::MAX } else { (1u32 << n) - 1 };
        let v = (value & mask) as u64;
        let shift = 64 - self.bits_in_acc - n;
        self.acc |= v << shift;
        self.bits_in_acc += n;
        while self.bits_in_acc >= 8 {
            let byte = (self.acc >> 56) as u8;
            self.data.push(byte);
            self.acc <<= 8;
            self.bits_in_acc -= 8;
        }
    }

    /// Alias of [`Self::write_u32`] — some codec crates historically
    /// spell this `write_bits`.
    pub fn write_bits(&mut self, value: u32, n: u32) {
        self.write_u32(value, n)
    }

    /// Append up to 64 bits.
    pub fn write_u64(&mut self, value: u64, n: u32) {
        debug_assert!(n <= 64);
        if n <= 32 {
            self.write_u32(value as u32, n);
        } else {
            self.write_u32((value >> 32) as u32, n - 32);
            self.write_u32(value as u32, 32);
        }
    }

    /// Append `n` bits interpreted as a signed integer. Only the low
    /// `n` bits of the 2's-complement representation are written.
    pub fn write_i32(&mut self, value: i32, n: u32) {
        self.write_u32(value as u32, n);
    }

    pub fn write_bit(&mut self, bit: bool) {
        self.write_u32(bit as u32, 1);
    }

    /// Emit a unary-coded value: `n` zero bits followed by a single `1`.
    /// Inverse of [`BitReader::read_unary`].
    pub fn write_unary(&mut self, n: u32) {
        let mut remaining = n;
        while remaining >= 32 {
            self.write_u32(0, 32);
            remaining -= 32;
        }
        if remaining > 0 {
            self.write_u32(0, remaining);
        }
        self.write_bit(true);
    }

    pub fn write_byte(&mut self, b: u8) {
        self.write_u32(b as u32, 8);
    }

    /// Append a slice of bytes. Fast path when byte-aligned.
    pub fn write_bytes(&mut self, bytes: &[u8]) {
        if self.is_byte_aligned() {
            // Flush the accumulator (which is already at 0 bits_in_acc).
            self.data.extend_from_slice(bytes);
        } else {
            for &b in bytes {
                self.write_u32(b as u32, 8);
            }
        }
    }

    /// Pad to the next byte boundary with zero bits.
    pub fn align_to_byte(&mut self) {
        let pad = (8 - self.bits_in_acc % 8) % 8;
        if pad > 0 {
            self.write_u32(0, pad);
        }
    }

    /// Alias of [`Self::align_to_byte`] — MPEG-4 video spells it
    /// `align_to_byte_zero` since the spec also defines alternate
    /// align-with-ones tails in other contexts.
    pub fn align_to_byte_zero(&mut self) {
        self.align_to_byte()
    }

    /// Borrow the bytes accumulated so far (excluding any unflushed partial byte).
    pub fn bytes(&self) -> &[u8] {
        &self.data
    }

    /// Alias of [`Self::bytes`] — some codec crates spell this `buffer`.
    pub fn buffer(&self) -> &[u8] {
        &self.data
    }

    /// Pad with zero bits to the next byte boundary, then return the bytes.
    pub fn finish(mut self) -> Vec<u8> {
        if self.bits_in_acc > 0 {
            let byte = (self.acc >> 56) as u8;
            self.data.push(byte);
            self.acc = 0;
            self.bits_in_acc = 0;
        }
        self.data
    }

    /// Alias of [`Self::finish`] — some codec crates spell this `into_bytes`.
    pub fn into_bytes(self) -> Vec<u8> {
        self.finish()
    }
}

impl Default for BitWriter {
    fn default() -> Self {
        Self::new()
    }
}

// ==================== LSB-first (Vorbis) ====================

/// LSB-first bit reader. See [module docs](self) for the LSB convention.
///
/// Copy+Clone for the same reason as [`BitReader`] — no heap state.
#[derive(Clone, Copy)]
pub struct BitReaderLsb<'a> {
    data: &'a [u8],
    byte_pos: usize,
    /// Buffered bits, low-aligned (next bit to emit is bit 0 of `acc`).
    acc: u64,
    bits_in_acc: u32,
}

impl<'a> BitReaderLsb<'a> {
    pub fn new(data: &'a [u8]) -> Self {
        Self {
            data,
            byte_pos: 0,
            acc: 0,
            bits_in_acc: 0,
        }
    }

    pub fn bit_position(&self) -> u64 {
        self.byte_pos as u64 * 8 - self.bits_in_acc as u64
    }

    pub fn is_byte_aligned(&self) -> bool {
        self.bits_in_acc % 8 == 0
    }

    fn refill(&mut self) {
        while self.bits_in_acc <= 56 && self.byte_pos < self.data.len() {
            self.acc |= (self.data[self.byte_pos] as u64) << self.bits_in_acc;
            self.bits_in_acc += 8;
            self.byte_pos += 1;
        }
    }

    pub fn read_u32(&mut self, n: u32) -> Result<u32> {
        debug_assert!(n <= 32, "BitReaderLsb::read_u32 supports up to 32 bits");
        if n == 0 {
            return Ok(0);
        }
        if self.bits_in_acc < n {
            self.refill();
            if self.bits_in_acc < n {
                return Err(Error::Eof);
            }
        }
        let mask = if n == 32 { u32::MAX } else { (1u32 << n) - 1 };
        let v = (self.acc as u32) & mask;
        self.acc >>= n;
        self.bits_in_acc -= n;
        Ok(v)
    }

    pub fn read_u64(&mut self, n: u32) -> Result<u64> {
        debug_assert!(n <= 64);
        if n == 0 {
            return Ok(0);
        }
        if n <= 32 {
            return Ok(self.read_u32(n)? as u64);
        }
        let lo = self.read_u32(32)? as u64;
        let hi = self.read_u32(n - 32)? as u64;
        Ok(lo | (hi << 32))
    }

    pub fn read_i32(&mut self, n: u32) -> Result<i32> {
        if n == 0 {
            return Ok(0);
        }
        let raw = self.read_u32(n)? as i32;
        let shift = 32 - n;
        Ok((raw << shift) >> shift)
    }

    pub fn read_bit(&mut self) -> Result<bool> {
        Ok(self.read_u32(1)? != 0)
    }
}

/// LSB-first bit writer — inverse of [`BitReaderLsb`].
pub struct BitWriterLsb {
    data: Vec<u8>,
    /// Bits held over from the last partial byte, low-aligned.
    acc: u64,
    bits_in_acc: u32,
}

impl BitWriterLsb {
    pub fn new() -> Self {
        Self {
            data: Vec::new(),
            acc: 0,
            bits_in_acc: 0,
        }
    }

    pub fn with_capacity(cap: usize) -> Self {
        Self {
            data: Vec::with_capacity(cap),
            acc: 0,
            bits_in_acc: 0,
        }
    }

    pub fn bit_position(&self) -> u64 {
        self.data.len() as u64 * 8 + self.bits_in_acc as u64
    }

    pub fn write_u32(&mut self, value: u32, n: u32) {
        debug_assert!(n <= 32, "BitWriterLsb::write_u32 supports up to 32 bits");
        if n == 0 {
            return;
        }
        let mask: u32 = if n == 32 { u32::MAX } else { (1u32 << n) - 1 };
        let v = value & mask;
        self.acc |= (v as u64) << self.bits_in_acc;
        self.bits_in_acc += n;
        while self.bits_in_acc >= 8 {
            self.data.push((self.acc & 0xFF) as u8);
            self.acc >>= 8;
            self.bits_in_acc -= 8;
        }
    }

    pub fn write_u64(&mut self, value: u64, n: u32) {
        debug_assert!(n <= 64);
        if n <= 32 {
            self.write_u32(value as u32, n);
        } else {
            self.write_u32(value as u32, 32);
            self.write_u32((value >> 32) as u32, n - 32);
        }
    }

    pub fn write_bit(&mut self, bit: bool) {
        self.write_u32(bit as u32, 1);
    }

    /// Pad to the next byte boundary with zero bits.
    pub fn align_to_byte(&mut self) {
        let pad = (8 - self.bits_in_acc % 8) % 8;
        self.write_u32(0, pad);
    }

    pub fn finish(mut self) -> Vec<u8> {
        if self.bits_in_acc > 0 {
            self.data.push((self.acc & 0xFF) as u8);
            self.acc = 0;
            self.bits_in_acc = 0;
        }
        self.data
    }
}

impl Default for BitWriterLsb {
    fn default() -> Self {
        Self::new()
    }
}

#[cfg(test)]
mod tests {
    use super::*;

    // ---- MSB ----

    #[test]
    fn msb_roundtrip_byte() {
        let mut w = BitWriter::new();
        for &b in &[1u32, 0, 1, 0, 0, 1, 0, 1] {
            w.write_u32(b, 1);
        }
        assert_eq!(w.finish(), vec![0xA5]);
    }

    #[test]
    fn msb_roundtrip_varied_widths() {
        let mut bw = BitWriter::new();
        let writes: Vec<(u32, u32)> = vec![
            (0b1, 1),
            (0b10101, 5),
            (0b111100001111, 12),
            (0xDEADBEEF, 32),
            (0b001, 3),
            (0xC, 4),
            (0xABCD, 16),
            (0x12345, 20),
            (0, 8),
            (0xFFFFFFFF, 32),
        ];
        for &(v, n) in &writes {
            bw.write_u32(v, n);
        }
        let bytes = bw.finish();
        let mut br = BitReader::new(&bytes);
        for &(v, n) in &writes {
            let got = br.read_u32(n).unwrap();
            let mask = if n == 32 { u32::MAX } else { (1 << n) - 1 };
            assert_eq!(got, v & mask, "mismatch for ({v:#x}, {n})");
        }
    }

    #[test]
    fn msb_signed_extension() {
        let mut br = BitReader::new(&[0xFF]);
        assert_eq!(br.read_i32(4).unwrap(), -1);
        assert_eq!(br.read_i32(4).unwrap(), -1);
    }

    #[test]
    fn msb_peek_skip() {
        let mut br = BitReader::new(&[0xFF, 0x00]);
        assert_eq!(br.peek_u32(12).unwrap(), 0xFF0);
        br.skip(4).unwrap();
        assert_eq!(br.read_u32(8).unwrap(), 0xF0);
    }

    #[test]
    fn msb_alignment() {
        let mut br = BitReader::new(&[0xFF, 0x55]);
        br.read_u32(3).unwrap();
        assert!(!br.is_byte_aligned());
        br.align_to_byte();
        assert!(br.is_byte_aligned());
        assert_eq!(br.read_u32(8).unwrap(), 0x55);
    }

    #[test]
    fn msb_write_bytes_fast_path() {
        let mut w = BitWriter::new();
        w.write_bytes(&[0x11, 0x22, 0x33]);
        assert_eq!(w.finish(), vec![0x11, 0x22, 0x33]);
    }

    #[test]
    fn msb_write_bytes_unaligned() {
        let mut w = BitWriter::new();
        w.write_u32(0b101, 3);
        w.write_bytes(&[0xFF, 0x00]);
        // 3 bits + 2*8 = 19 bits → 3 bytes after zero-pad.
        let out = w.finish();
        assert_eq!(out.len(), 3);
    }

    #[test]
    fn msb_write_bits_alias() {
        let mut w = BitWriter::new();
        w.write_bits(0xA, 4);
        w.write_u32(0x5, 4);
        assert_eq!(w.finish(), vec![0xA5]);
    }

    #[test]
    fn msb_into_bytes_alias() {
        let mut w = BitWriter::new();
        w.write_u32(0xA5, 8);
        assert_eq!(w.into_bytes(), vec![0xA5]);
    }

    #[test]
    fn msb_read_u64_high_bits() {
        // Write 0x1234567890ABCDEF as 64 bits MSB-first, read back.
        let mut w = BitWriter::new();
        w.write_u64(0x1234567890ABCDEF, 64);
        let bytes = w.finish();
        let mut r = BitReader::new(&bytes);
        assert_eq!(r.read_u64(64).unwrap(), 0x1234567890ABCDEF);
    }

    #[test]
    fn msb_unary_roundtrip() {
        let mut w = BitWriter::new();
        let counts: Vec<u32> = vec![0, 1, 7, 31, 32, 33, 64, 65, 100];
        for &c in &counts {
            w.write_unary(c);
        }
        let bytes = w.finish();
        let mut r = BitReader::new(&bytes);
        for &c in &counts {
            assert_eq!(r.read_unary().unwrap(), c, "unary roundtrip for {c}");
        }
    }

    #[test]
    fn msb_read_bytes_aligned() {
        let mut br = BitReader::new(&[0xAA, 0xBB, 0xCC, 0xDD]);
        let _ = br.read_u32(8).unwrap();
        let got = br.read_bytes(2).unwrap();
        assert_eq!(got, vec![0xBB, 0xCC]);
        assert_eq!(br.read_u32(8).unwrap(), 0xDD);
    }

    // ---- LSB ----

    #[test]
    fn lsb_roundtrip_byte() {
        let mut w = BitWriterLsb::new();
        for &b in &[1u32, 0, 1, 0, 0, 1, 0, 1] {
            w.write_u32(b, 1);
        }
        assert_eq!(w.finish(), vec![0xA5]);
    }

    #[test]
    fn lsb_multi_byte() {
        let mut w = BitWriterLsb::new();
        w.write_u32(0x3412, 16);
        let bytes = w.finish();
        assert_eq!(bytes, vec![0x12, 0x34]);
        let mut r = BitReaderLsb::new(&bytes);
        assert_eq!(r.read_u32(16).unwrap(), 0x3412);
    }

    #[test]
    fn lsb_roundtrip_varied_widths() {
        let mut bw = BitWriterLsb::new();
        let writes: Vec<(u32, u32)> = vec![(5, 3), (0xABCD, 16), (0x1234567, 27), (1, 1)];
        for &(v, n) in &writes {
            bw.write_u32(v, n);
        }
        let bytes = bw.finish();
        let mut r = BitReaderLsb::new(&bytes);
        for &(v, n) in &writes {
            assert_eq!(r.read_u32(n).unwrap(), v);
        }
    }
}