oxide-framework-core 0.1.0

Core runtime and framework logic for the Oxide web framework.
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
1177
1178
1179
1180
1181
1182
1183
1184
1185
1186
1187
1188
1189
1190
1191
1192
1193
1194
1195
1196
1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
1207
1208
1209
1210
1211
1212
1213
1214
1215
1216
1217
1218
1219
1220
1221
1222
1223
1224
1225
1226
1227
1228
1229
1230
1231
1232
1233
1234
1235
1236
1237
1238
1239
1240
1241
1242
1243
1244
1245
1246
1247
1248
1249
1250
1251
1252
1253
1254
1255
1256
1257
1258
1259
1260
1261
1262
1263
1264
1265
1266
1267
1268
1269
1270
1271
1272
1273
1274
1275
1276
1277
1278
1279
1280
1281
1282
1283
1284
1285
1286
1287
1288
1289
1290
1291
1292
1293
1294
1295
1296
1297
1298
1299
1300
1301
1302
1303
1304
1305
1306
1307
1308
1309
1310
1311
1312
1313
1314
1315
1316
1317
1318
1319
1320
1321
1322
1323
1324
1325
1326
1327
1328
1329
1330
1331
1332
1333
1334
1335
1336
1337
1338
1339
1340
1341
1342
1343
1344
1345
1346
1347
1348
1349
1350
1351
1352
1353
1354
1355
1356
1357
1358
1359
1360
1361
1362
1363
1364
1365
1366
1367
1368
1369
1370
1371
1372
1373
1374
1375
1376
1377
1378
1379
1380
1381
1382
1383
1384
1385
1386
1387
1388
1389
1390
1391
use oxide_framework_core::{App, ApiResponse, Config, Data, Json, OxideRouter, Path};
use reqwest::Client;
use serde::{Deserialize, Serialize};
use std::sync::atomic::{AtomicU64, Ordering};
use std::sync::Arc;

// ============================================================================
// Helpers
// ============================================================================

async fn hello() -> &'static str {
    "hello"
}

async fn echo_body(body: String) -> String {
    body
}

#[derive(Serialize, Deserialize, Debug)]
struct Msg {
    text: String,
}

async fn json_ok() -> ApiResponse<Msg> {
    ApiResponse::ok(Msg {
        text: "hi".into(),
    })
}

async fn greet(Path(name): Path<String>) -> String {
    format!("hello {name}")
}

async fn slow_handler() -> &'static str {
    tokio::time::sleep(std::time::Duration::from_secs(5)).await;
    "done"
}

async fn fast_handler() -> &'static str {
    "fast"
}

async fn crash_handler() -> &'static str {
    panic!("handler exploded")
}

// ============================================================================
// 1. Server Boot
// ============================================================================

#[tokio::test]
async fn test_server_starts_and_responds() {
    let server = App::new()
        .disable_request_logging()
        .get("/", hello)
        .into_test_server()
        .await;

    let res = reqwest::get(server.url("/")).await.unwrap();
    assert_eq!(res.status(), 200);
    assert_eq!(res.text().await.unwrap(), "hello");
}

// ============================================================================
// 2. Routing
// ============================================================================

#[tokio::test]
async fn test_get_route() {
    let server = App::new()
        .disable_request_logging()
        .get("/ping", || async { "pong" })
        .into_test_server()
        .await;

    let res = reqwest::get(server.url("/ping")).await.unwrap();
    assert_eq!(res.text().await.unwrap(), "pong");
}

#[tokio::test]
async fn test_post_route() {
    let server = App::new()
        .disable_request_logging()
        .post("/echo", echo_body)
        .into_test_server()
        .await;

    let client = Client::new();
    let res = client
        .post(server.url("/echo"))
        .body("payload")
        .send()
        .await
        .unwrap();
    assert_eq!(res.status(), 200);
    assert_eq!(res.text().await.unwrap(), "payload");
}

#[tokio::test]
async fn test_put_delete_patch() {
    let server = App::new()
        .disable_request_logging()
        .put("/r", || async { "put" })
        .delete("/r", || async { "delete" })
        .patch("/r", || async { "patch" })
        .into_test_server()
        .await;

    let client = Client::new();

    let res = client.put(server.url("/r")).send().await.unwrap();
    assert_eq!(res.text().await.unwrap(), "put");

    let res = client.delete(server.url("/r")).send().await.unwrap();
    assert_eq!(res.text().await.unwrap(), "delete");

    let res = client.patch(server.url("/r")).send().await.unwrap();
    assert_eq!(res.text().await.unwrap(), "patch");
}

#[tokio::test]
async fn test_path_params() {
    let server = App::new()
        .disable_request_logging()
        .get("/users/{name}", greet)
        .into_test_server()
        .await;

    let res = reqwest::get(server.url("/users/alice")).await.unwrap();
    assert_eq!(res.text().await.unwrap(), "hello alice");
}

#[tokio::test]
async fn test_nested_routes() {
    let api = OxideRouter::new()
        .get("/health", || async { "ok" })
        .get("/version", || async { "1.0" });

    let server = App::new()
        .disable_request_logging()
        .nest("/api", api)
        .into_test_server()
        .await;

    let res = reqwest::get(server.url("/api/health")).await.unwrap();
    assert_eq!(res.text().await.unwrap(), "ok");

    let res = reqwest::get(server.url("/api/version")).await.unwrap();
    assert_eq!(res.text().await.unwrap(), "1.0");
}

#[tokio::test]
async fn test_404_unknown_route() {
    let server = App::new()
        .disable_request_logging()
        .get("/", hello)
        .into_test_server()
        .await;

    let res = reqwest::get(server.url("/nonexistent")).await.unwrap();
    assert_eq!(res.status(), 404);
}

#[tokio::test]
async fn test_method_not_allowed() {
    let server = App::new()
        .disable_request_logging()
        .get("/only-get", hello)
        .into_test_server()
        .await;

    let client = Client::new();
    let res = client.post(server.url("/only-get")).send().await.unwrap();
    assert_eq!(res.status(), 405);
}

#[tokio::test]
async fn test_api_response_json_envelope() {
    let server = App::new()
        .disable_request_logging()
        .get("/json", json_ok)
        .into_test_server()
        .await;

    let res = reqwest::get(server.url("/json")).await.unwrap();
    assert_eq!(res.status(), 200);

    let body: serde_json::Value = res.json().await.unwrap();
    assert_eq!(body["status"], 200);
    assert_eq!(body["data"]["text"], "hi");
}

// ============================================================================
// 3. CORS Validation
// ============================================================================

#[tokio::test]
async fn test_cors_preflight_returns_ok() {
    let server = App::new()
        .disable_request_logging()
        .cors_permissive()
        .get("/", hello)
        .into_test_server()
        .await;

    let client = Client::new();
    let res = client
        .request(reqwest::Method::OPTIONS, server.url("/"))
        .header("Origin", "http://example.com")
        .header("Access-Control-Request-Method", "POST")
        .send()
        .await
        .unwrap();

    let status = res.status().as_u16();
    assert!(status == 200 || status == 204, "preflight status was {status}");
    assert!(res.headers().contains_key("access-control-allow-origin"));
    assert!(res.headers().contains_key("access-control-allow-methods"));
}

#[tokio::test]
async fn test_cors_headers_on_normal_response() {
    let server = App::new()
        .disable_request_logging()
        .cors_permissive()
        .get("/", hello)
        .into_test_server()
        .await;

    let client = Client::new();
    let res = client
        .get(server.url("/"))
        .header("Origin", "http://example.com")
        .send()
        .await
        .unwrap();

    assert_eq!(res.status(), 200);
    let acao = res
        .headers()
        .get("access-control-allow-origin")
        .expect("missing CORS header on normal response");
    assert_eq!(acao.to_str().unwrap(), "*");
}

#[tokio::test]
async fn test_cors_headers_on_429_response() {
    let server = App::new()
        .disable_request_logging()
        .cors_permissive()
        .rate_limit(1, 60)
        .get("/", hello)
        .into_test_server()
        .await;

    let client = Client::new();

    // Exhaust the limit
    let _ = client.get(server.url("/")).send().await;

    // This should be 429 AND still have CORS headers
    let res = client
        .get(server.url("/"))
        .header("Origin", "http://example.com")
        .send()
        .await
        .unwrap();

    assert_eq!(res.status(), 429);
    assert!(
        res.headers().contains_key("access-control-allow-origin"),
        "CORS headers missing on 429 response — layer order is wrong"
    );
}

#[tokio::test]
async fn test_cors_headers_on_408_response() {
    let server = App::new()
        .disable_request_logging()
        .cors_permissive()
        .request_timeout(1)
        .get("/slow", slow_handler)
        .into_test_server()
        .await;

    let client = Client::new();
    let res = client
        .get(server.url("/slow"))
        .header("Origin", "http://example.com")
        .send()
        .await
        .unwrap();

    assert_eq!(res.status(), 408);
    assert!(
        res.headers().contains_key("access-control-allow-origin"),
        "CORS headers missing on 408 response — layer order is wrong"
    );
}

#[tokio::test]
async fn test_cors_restricted_origin_allowed() {
    let server = App::new()
        .disable_request_logging()
        .cors_origins(["http://allowed.com"])
        .get("/", hello)
        .into_test_server()
        .await;

    let client = Client::new();
    let res = client
        .get(server.url("/"))
        .header("Origin", "http://allowed.com")
        .send()
        .await
        .unwrap();

    assert_eq!(res.status(), 200);
    let acao = res
        .headers()
        .get("access-control-allow-origin")
        .expect("allowed origin should get CORS header");
    assert_eq!(acao.to_str().unwrap(), "http://allowed.com");
}

#[tokio::test]
async fn test_cors_restricted_origin_blocked() {
    let server = App::new()
        .disable_request_logging()
        .cors_origins(["http://allowed.com"])
        .get("/", hello)
        .into_test_server()
        .await;

    let client = Client::new();
    let res = client
        .get(server.url("/"))
        .header("Origin", "http://evil.com")
        .send()
        .await
        .unwrap();

    // Request succeeds but no CORS header — browser will block it
    assert_eq!(res.status(), 200);
    assert!(
        !res.headers().contains_key("access-control-allow-origin"),
        "disallowed origin should NOT get CORS header"
    );
}

#[tokio::test]
async fn test_no_cors_when_not_configured() {
    let server = App::new()
        .disable_request_logging()
        .get("/", hello)
        .into_test_server()
        .await;

    let client = Client::new();
    let res = client
        .get(server.url("/"))
        .header("Origin", "http://example.com")
        .send()
        .await
        .unwrap();

    assert!(!res.headers().contains_key("access-control-allow-origin"));
}

// ============================================================================
// 4. Rate Limiting
// ============================================================================

#[tokio::test]
async fn test_rate_limit_allows_within_limit() {
    let server = App::new()
        .disable_request_logging()
        .rate_limit(10, 60)
        .get("/", hello)
        .into_test_server()
        .await;

    let client = Client::new();
    for _ in 0..10 {
        let res = client.get(server.url("/")).send().await.unwrap();
        assert_eq!(res.status(), 200, "request within limit should succeed");
    }
}

#[tokio::test]
async fn test_rate_limit_blocks_over_limit() {
    let server = App::new()
        .disable_request_logging()
        .rate_limit(5, 60)
        .get("/", hello)
        .into_test_server()
        .await;

    let client = Client::new();

    for _ in 0..5 {
        let res = client.get(server.url("/")).send().await.unwrap();
        assert_eq!(res.status(), 200);
    }

    // 6th request should be blocked
    let res = client.get(server.url("/")).send().await.unwrap();
    assert_eq!(res.status(), 429);

    let body: serde_json::Value = res.json().await.unwrap();
    assert_eq!(body["status"], 429);
    assert_eq!(body["error"], "rate limit exceeded");
}

#[tokio::test]
async fn test_rate_limit_returns_retry_after() {
    let server = App::new()
        .disable_request_logging()
        .rate_limit(1, 120)
        .get("/", hello)
        .into_test_server()
        .await;

    let client = Client::new();
    let _ = client.get(server.url("/")).send().await;

    let res = client.get(server.url("/")).send().await.unwrap();
    assert_eq!(res.status(), 429);

    let retry_after = res
        .headers()
        .get("retry-after")
        .expect("429 should include Retry-After header");
    assert_eq!(retry_after.to_str().unwrap(), "120");
}

#[tokio::test]
async fn test_rate_limit_per_ip_isolation() {
    let server = App::new()
        .disable_request_logging()
        .rate_limit(2, 60)
        .get("/", hello)
        .into_test_server()
        .await;

    let client = Client::new();

    // Exhaust limit for IP "10.0.0.1"
    for _ in 0..2 {
        let _ = client
            .get(server.url("/"))
            .header("X-Forwarded-For", "10.0.0.1")
            .send()
            .await;
    }

    let res = client
        .get(server.url("/"))
        .header("X-Forwarded-For", "10.0.0.1")
        .send()
        .await
        .unwrap();
    assert_eq!(res.status(), 429, "IP 10.0.0.1 should be rate-limited");

    // Different IP should still work
    let res = client
        .get(server.url("/"))
        .header("X-Forwarded-For", "10.0.0.2")
        .send()
        .await
        .unwrap();
    assert_eq!(res.status(), 200, "IP 10.0.0.2 should NOT be rate-limited");
}

#[tokio::test]
async fn test_rate_limit_resets_after_window() {
    let server = App::new()
        .disable_request_logging()
        .rate_limit(2, 2) // 2 requests per 2 seconds
        .get("/", hello)
        .into_test_server()
        .await;

    let client = Client::new();

    // Exhaust limit
    for _ in 0..2 {
        let _ = client.get(server.url("/")).send().await;
    }
    let res = client.get(server.url("/")).send().await.unwrap();
    assert_eq!(res.status(), 429);

    // Wait for window to reset
    tokio::time::sleep(std::time::Duration::from_secs(3)).await;

    let res = client.get(server.url("/")).send().await.unwrap();
    assert_eq!(res.status(), 200, "should succeed after window reset");
}

#[tokio::test]
async fn test_rate_limit_concurrent_requests() {
    let server = App::new()
        .disable_request_logging()
        .rate_limit(50, 60)
        .get("/", hello)
        .into_test_server()
        .await;

    let client = Client::new();
    let url = server.url("/");

    let mut handles = Vec::new();
    for _ in 0..100 {
        let c = client.clone();
        let u = url.clone();
        handles.push(tokio::spawn(async move {
            c.get(&u).send().await.unwrap().status()
        }));
    }

    let mut ok_count = 0u64;
    let mut limited_count = 0u64;

    for h in handles {
        let status = h.await.unwrap();
        if status == 200 {
            ok_count += 1;
        } else if status == 429 {
            limited_count += 1;
        } else {
            panic!("unexpected status: {status}");
        }
    }

    assert_eq!(ok_count, 50, "exactly 50 requests should succeed");
    assert_eq!(limited_count, 50, "exactly 50 requests should be rate-limited");
    assert_eq!(ok_count + limited_count, 100, "no requests lost");
}

// ============================================================================
// 5. Timeout
// ============================================================================

#[tokio::test]
async fn test_timeout_returns_408() {
    let server = App::new()
        .disable_request_logging()
        .request_timeout(1)
        .get("/slow", slow_handler)
        .into_test_server()
        .await;

    let res = reqwest::get(server.url("/slow")).await.unwrap();
    assert_eq!(res.status(), 408);

    let body: serde_json::Value = res.json().await.unwrap();
    assert_eq!(body["status"], 408);
    assert_eq!(body["error"], "request timeout");
}

#[tokio::test]
async fn test_fast_handler_not_timed_out() {
    let server = App::new()
        .disable_request_logging()
        .request_timeout(5)
        .get("/fast", fast_handler)
        .into_test_server()
        .await;

    let res = reqwest::get(server.url("/fast")).await.unwrap();
    assert_eq!(res.status(), 200);
    assert_eq!(res.text().await.unwrap(), "fast");
}

// ============================================================================
// 6. State & Config Extractors
// ============================================================================

struct Counter {
    value: AtomicU64,
}

async fn read_counter(Data(counter): Data<Counter>) -> String {
    counter.value.load(Ordering::Relaxed).to_string()
}

async fn increment_counter(Data(counter): Data<Counter>) -> String {
    counter.value.fetch_add(1, Ordering::Relaxed);
    "incremented".to_string()
}

async fn read_config(Config(cfg): Config) -> String {
    cfg.app_name.clone()
}

#[tokio::test]
async fn test_config_extractor() {
    let server = App::new()
        .disable_request_logging()
        .get("/name", read_config)
        .into_test_server()
        .await;

    let res = reqwest::get(server.url("/name")).await.unwrap();
    assert_eq!(res.status(), 200);
    assert_eq!(res.text().await.unwrap(), "oxide-app");
}

#[tokio::test]
async fn test_data_extractor() {
    let counter = Counter {
        value: AtomicU64::new(42),
    };

    let server = App::new()
        .disable_request_logging()
        .state(counter)
        .get("/count", read_counter)
        .into_test_server()
        .await;

    let res = reqwest::get(server.url("/count")).await.unwrap();
    assert_eq!(res.text().await.unwrap(), "42");
}

#[tokio::test]
async fn test_shared_state_mutation() {
    let counter = Counter {
        value: AtomicU64::new(0),
    };

    let server = App::new()
        .disable_request_logging()
        .state(counter)
        .post("/inc", increment_counter)
        .get("/count", read_counter)
        .into_test_server()
        .await;

    let client = Client::new();

    for _ in 0..5 {
        client.post(server.url("/inc")).send().await.unwrap();
    }

    let res = client.get(server.url("/count")).send().await.unwrap();
    assert_eq!(res.text().await.unwrap(), "5");
}

// ============================================================================
// 7. Error Handling & Abuse
// ============================================================================

#[derive(Deserialize)]
struct Payload {
    #[allow(dead_code)]
    name: String,
}

async fn expect_json(Json(_payload): Json<Payload>) -> &'static str {
    "ok"
}

#[tokio::test]
async fn test_malformed_json_returns_client_error() {
    let server = App::new()
        .disable_request_logging()
        .post("/data", expect_json)
        .into_test_server()
        .await;

    let client = Client::new();
    let res = client
        .post(server.url("/data"))
        .header("content-type", "application/json")
        .body("{invalid json!!")
        .send()
        .await
        .unwrap();

    assert!(
        res.status().is_client_error(),
        "malformed JSON should return 4xx, got {}",
        res.status()
    );
}

#[tokio::test]
async fn test_missing_content_type_for_json() {
    let server = App::new()
        .disable_request_logging()
        .post("/data", expect_json)
        .into_test_server()
        .await;

    let client = Client::new();
    let res = client
        .post(server.url("/data"))
        .body(r#"{"name":"test"}"#)
        .send()
        .await
        .unwrap();

    assert!(
        res.status().is_client_error(),
        "missing content-type should return 4xx, got {}",
        res.status()
    );
}

#[tokio::test]
async fn test_empty_body_for_json_route() {
    let server = App::new()
        .disable_request_logging()
        .post("/data", expect_json)
        .into_test_server()
        .await;

    let client = Client::new();
    let res = client
        .post(server.url("/data"))
        .header("content-type", "application/json")
        .send()
        .await
        .unwrap();

    assert!(res.status().is_client_error());
}

// ============================================================================
// 8. Burst / Abuse Testing
// ============================================================================

#[tokio::test]
async fn test_burst_1000_requests_no_crash() {
    let server = App::new()
        .disable_request_logging()
        .get("/", hello)
        .into_test_server()
        .await;

    let client = Client::new();
    let url = server.url("/");

    let mut handles = Vec::new();
    for _ in 0..1000 {
        let c = client.clone();
        let u = url.clone();
        handles.push(tokio::spawn(
            async move { c.get(&u).send().await.unwrap().status() },
        ));
    }

    let mut success = 0u64;
    for h in handles {
        let status = h.await.unwrap();
        assert_eq!(status, 200);
        success += 1;
    }
    assert_eq!(success, 1000);
}

#[tokio::test]
async fn test_burst_with_rate_limit_holds() {
    let server = App::new()
        .disable_request_logging()
        .rate_limit(100, 60)
        .get("/", hello)
        .into_test_server()
        .await;

    let client = Client::new();
    let url = server.url("/");

    let mut handles = Vec::new();
    for _ in 0..500 {
        let c = client.clone();
        let u = url.clone();
        handles.push(tokio::spawn(
            async move { c.get(&u).send().await.unwrap().status() },
        ));
    }

    let mut ok = 0u64;
    let mut limited = 0u64;
    for h in handles {
        match h.await.unwrap().as_u16() {
            200 => ok += 1,
            429 => limited += 1,
            other => panic!("unexpected: {other}"),
        }
    }

    assert_eq!(ok, 100, "exactly 100 should pass");
    assert_eq!(limited, 400, "exactly 400 should be rate-limited");
}

// ============================================================================
// 9. Middleware Interaction (stacking)
// ============================================================================

#[tokio::test]
async fn test_cors_plus_rate_limit_plus_timeout_all_active() {
    let server = App::new()
        .disable_request_logging()
        .cors_permissive()
        .rate_limit(5, 60)
        .request_timeout(2)
        .get("/", hello)
        .get("/slow", slow_handler)
        .into_test_server()
        .await;

    let client = Client::new();

    // Normal request: 200 + CORS
    let res = client
        .get(server.url("/"))
        .header("Origin", "http://example.com")
        .send()
        .await
        .unwrap();
    assert_eq!(res.status(), 200);
    assert!(res.headers().contains_key("access-control-allow-origin"));

    // Timeout: 408 + CORS
    let res = client
        .get(server.url("/slow"))
        .header("Origin", "http://example.com")
        .send()
        .await
        .unwrap();
    assert_eq!(res.status(), 408);
    assert!(res.headers().contains_key("access-control-allow-origin"));

    // Exhaust rate limit (4 more, we used 2 already)
    for _ in 0..4 {
        let _ = client.get(server.url("/")).send().await;
    }

    // Rate limited: 429 + CORS
    let res = client
        .get(server.url("/"))
        .header("Origin", "http://example.com")
        .send()
        .await
        .unwrap();
    assert_eq!(res.status(), 429);
    assert!(res.headers().contains_key("access-control-allow-origin"));
}

#[tokio::test]
async fn test_rate_limit_triggers_before_handler() {
    let counter = Arc::new(AtomicU64::new(0));
    let c = counter.clone();

    let server = App::new()
        .disable_request_logging()
        .rate_limit(3, 60)
        .get("/", move || {
            let c = c.clone();
            async move {
                c.fetch_add(1, Ordering::Relaxed);
                "ok"
            }
        })
        .into_test_server()
        .await;

    let client = Client::new();
    for _ in 0..10 {
        let _ = client.get(server.url("/")).send().await;
    }

    assert_eq!(
        counter.load(Ordering::Relaxed),
        3,
        "handler should only execute 3 times — rate limiter should block the rest"
    );
}

// ============================================================================
// 10. Config Override (env vars)
// ============================================================================

#[tokio::test]
async fn test_env_overrides_config() {
    // SAFETY: single-threaded access in this test; no other test reads these vars.
    unsafe {
        std::env::set_var("OXIDE_PORT", "9999");
        std::env::set_var("OXIDE_APP_NAME", "test-app");
    }

    let config = oxide_framework_core::AppConfig::load(None);

    assert_eq!(config.port, 9999);
    assert_eq!(config.app_name, "test-app");

    unsafe {
        std::env::remove_var("OXIDE_PORT");
        std::env::remove_var("OXIDE_APP_NAME");
    }
}

// ============================================================================
// 11. Preflight Not Rate-Limited
// ============================================================================

#[tokio::test]
async fn test_preflight_not_counted_against_rate_limit() {
    let server = App::new()
        .disable_request_logging()
        .cors_permissive()
        .rate_limit(3, 60)
        .get("/", hello)
        .into_test_server()
        .await;

    let client = Client::new();

    // Send 5 preflight requests — should NOT consume rate limit
    for _ in 0..5 {
        let res = client
            .request(reqwest::Method::OPTIONS, server.url("/"))
            .header("Origin", "http://example.com")
            .header("Access-Control-Request-Method", "GET")
            .send()
            .await
            .unwrap();
        let s = res.status().as_u16();
        assert!(s == 200 || s == 204);
    }

    // All 3 actual requests should still succeed
    for i in 0..3 {
        let res = client.get(server.url("/")).send().await.unwrap();
        assert_eq!(
            res.status(),
            200,
            "request {i} should succeed — preflights shouldn't count"
        );
    }

    // 4th actual request should be rate-limited
    let res = client.get(server.url("/")).send().await.unwrap();
    assert_eq!(res.status(), 429);
}

// ============================================================================
// KILLER TEST 1: Panic Recovery
// ============================================================================

#[tokio::test]
async fn test_panic_recovery_returns_500() {
    let server = App::new()
        .disable_request_logging()
        .get("/crash", crash_handler)
        .get("/ok", || async { "alive" })
        .into_test_server()
        .await;

    let client = Client::new();

    // Panic should become a JSON 500, NOT crash the server
    let res = client.get(server.url("/crash")).send().await.unwrap();
    assert_eq!(res.status(), 500, "panic should produce 500");
    let body: serde_json::Value = res.json().await.unwrap();
    assert_eq!(body["status"], 500);
    assert_eq!(body["error"], "internal server error");

    // Server must still be alive after the panic
    let res = client.get(server.url("/ok")).send().await.unwrap();
    assert_eq!(res.status(), 200);
    assert_eq!(res.text().await.unwrap(), "alive");
}

#[tokio::test]
async fn test_repeated_panics_dont_kill_server() {
    let server = App::new()
        .disable_request_logging()
        .get("/crash", crash_handler)
        .get("/ok", || async { "alive" })
        .into_test_server()
        .await;

    let client = Client::new();

    // Hit the panic endpoint 20 times
    for _ in 0..20 {
        let res = client.get(server.url("/crash")).send().await.unwrap();
        assert_eq!(res.status(), 500);
    }

    // Server still alive
    let res = client.get(server.url("/ok")).send().await.unwrap();
    assert_eq!(res.status(), 200);
    assert_eq!(res.text().await.unwrap(), "alive");
}

#[tokio::test]
async fn test_panic_gets_cors_headers() {
    let server = App::new()
        .disable_request_logging()
        .cors_permissive()
        .get("/crash", crash_handler)
        .into_test_server()
        .await;

    let client = Client::new();
    let res = client
        .get(server.url("/crash"))
        .header("Origin", "http://example.com")
        .send()
        .await
        .unwrap();

    assert_eq!(res.status(), 500);
    assert!(
        res.headers().contains_key("access-control-allow-origin"),
        "CORS headers must be present even on panic 500"
    );
}

// ============================================================================
// KILLER TEST 2: IP Spoofing Bypass
// ============================================================================

#[tokio::test]
async fn test_ip_spoofing_with_header_rotation() {
    let server = App::new()
        .disable_request_logging()
        .rate_limit(2, 60)
        .get("/", hello)
        .into_test_server()
        .await;

    let client = Client::new();

    // Exhaust limit for fake IP
    for _ in 0..2 {
        let _ = client
            .get(server.url("/"))
            .header("X-Forwarded-For", "1.2.3.4")
            .send()
            .await;
    }
    let res = client
        .get(server.url("/"))
        .header("X-Forwarded-For", "1.2.3.4")
        .send()
        .await
        .unwrap();
    assert_eq!(res.status(), 429, "original IP should be blocked");

    // Rotating to a new fake IP bypasses — this is expected per-IP behavior
    let res = client
        .get(server.url("/"))
        .header("X-Forwarded-For", "5.6.7.8")
        .send()
        .await
        .unwrap();
    assert_eq!(res.status(), 200, "new IP bypasses per-IP rate limit");
}

#[tokio::test]
async fn test_no_header_uses_real_tcp_ip() {
    let server = App::new()
        .disable_request_logging()
        .rate_limit(3, 60)
        .get("/", hello)
        .into_test_server()
        .await;

    let client = Client::new();

    // Requests without X-Forwarded-For should use ConnectInfo (127.0.0.1)
    for _ in 0..3 {
        let res = client.get(server.url("/")).send().await.unwrap();
        assert_eq!(res.status(), 200);
    }

    // 4th request from same real IP should be blocked
    let res = client.get(server.url("/")).send().await.unwrap();
    assert_eq!(
        res.status(),
        429,
        "without proxy headers, real TCP IP is used for rate limiting"
    );
}

// ============================================================================
// KILLER TEST 3: Rate Limiter Memory Growth
// ============================================================================

#[tokio::test]
async fn test_rate_limiter_eviction_under_many_unique_ips() {
    let server = App::new()
        .disable_request_logging()
        .rate_limit(1000, 1) // 1-second window so entries expire fast
        .get("/", hello)
        .into_test_server()
        .await;

    let client = Client::new();

    // Flood with 500 unique IPs
    for i in 0u32..500 {
        let ip = format!("10.{}.{}.{}", (i >> 16) & 0xFF, (i >> 8) & 0xFF, i & 0xFF);
        let _ = client
            .get(server.url("/"))
            .header("X-Forwarded-For", &ip)
            .send()
            .await;
    }

    // Wait for entries to expire
    tokio::time::sleep(std::time::Duration::from_secs(2)).await;

    // Send another batch to trigger periodic eviction
    for i in 500u32..700 {
        let ip = format!("10.{}.{}.{}", (i >> 16) & 0xFF, (i >> 8) & 0xFF, i & 0xFF);
        let res = client
            .get(server.url("/"))
            .header("X-Forwarded-For", &ip)
            .send()
            .await
            .unwrap();
        assert_eq!(
            res.status(),
            200,
            "new IPs after eviction window should succeed"
        );
    }

    // Server still responsive
    let res = reqwest::get(server.url("/")).await.unwrap();
    assert_eq!(res.status(), 200);
}

// ============================================================================
// KILLER TEST 4: Sustained Load (10 seconds, 50 concurrent clients)
// ============================================================================

#[tokio::test]
async fn test_sustained_load_10s_no_crashes() {
    let server = App::new()
        .disable_request_logging()
        .get("/", hello)
        .into_test_server()
        .await;

    let client = Client::new();
    let url = server.url("/");
    let duration = std::time::Duration::from_secs(10);
    let start = std::time::Instant::now();

    let total = Arc::new(AtomicU64::new(0));
    let errors = Arc::new(AtomicU64::new(0));

    let mut handles = Vec::new();
    for _ in 0..50 {
        let c = client.clone();
        let u = url.clone();
        let t = total.clone();
        let e = errors.clone();

        handles.push(tokio::spawn(async move {
            while start.elapsed() < duration {
                match c.get(&u).send().await {
                    Ok(res) => {
                        t.fetch_add(1, Ordering::Relaxed);
                        if !res.status().is_success() {
                            e.fetch_add(1, Ordering::Relaxed);
                        }
                    }
                    Err(_) => {
                        e.fetch_add(1, Ordering::Relaxed);
                    }
                }
            }
        }));
    }

    for h in handles {
        h.await.unwrap();
    }

    let total_reqs = total.load(Ordering::Relaxed);
    let total_errors = errors.load(Ordering::Relaxed);

    assert!(
        total_reqs > 1000,
        "should have handled many requests, got {total_reqs}"
    );
    assert_eq!(
        total_errors, 0,
        "no errors expected under sustained load (got {total_errors}/{total_reqs})"
    );

    // Server still responsive after sustained load
    let res = reqwest::get(server.url("/")).await.unwrap();
    assert_eq!(res.status(), 200);
}

#[tokio::test]
async fn test_sustained_load_with_rate_limit() {
    let server = App::new()
        .disable_request_logging()
        .rate_limit(10000, 60)
        .get("/", hello)
        .into_test_server()
        .await;

    let client = Client::new();
    let url = server.url("/");
    let duration = std::time::Duration::from_secs(5);
    let start = std::time::Instant::now();

    let ok_count = Arc::new(AtomicU64::new(0));
    let limited_count = Arc::new(AtomicU64::new(0));
    let conn_errors = Arc::new(AtomicU64::new(0));

    let mut handles = Vec::new();
    for _ in 0..20 {
        let c = client.clone();
        let u = url.clone();
        let ok = ok_count.clone();
        let lim = limited_count.clone();
        let err = conn_errors.clone();

        handles.push(tokio::spawn(async move {
            while start.elapsed() < duration {
                match c.get(&u).send().await {
                    Ok(res) => match res.status().as_u16() {
                        200 => {
                            ok.fetch_add(1, Ordering::Relaxed);
                        }
                        429 => {
                            lim.fetch_add(1, Ordering::Relaxed);
                        }
                        other => panic!("unexpected status: {other}"),
                    },
                    Err(_) => {
                        err.fetch_add(1, Ordering::Relaxed);
                    }
                }
            }
        }));
    }

    for h in handles {
        h.await.unwrap();
    }

    let ok = ok_count.load(Ordering::Relaxed);
    let lim = limited_count.load(Ordering::Relaxed);
    let errs = conn_errors.load(Ordering::Relaxed);

    assert_eq!(errs, 0, "no connection errors expected");
    assert!(ok > 0, "some requests should have succeeded");
    assert_eq!(
        ok, 10000,
        "exactly 10000 requests should pass the rate limiter"
    );
    assert!(lim > 0, "some requests should have been rate-limited");

    // Server still alive
    let res = reqwest::get(server.url("/")).await.unwrap();
    assert!(res.status() == 200 || res.status() == 429);
}

// ============================================================================
// KILLER TEST 5: Middleware Failure Chain
// ============================================================================

#[tokio::test]
async fn test_full_middleware_failure_chain() {
    let server = App::new()
        .disable_request_logging()
        .cors_permissive()
        .rate_limit(3, 60)
        .request_timeout(2)
        .get("/crash", crash_handler)
        .get("/slow", slow_handler)
        .get("/ok", hello)
        .into_test_server()
        .await;

    let client = Client::new();

    // 1. Panic: 500 + CORS headers (uses 1/3 rate limit)
    let res = client
        .get(server.url("/crash"))
        .header("Origin", "http://example.com")
        .send()
        .await
        .unwrap();
    assert_eq!(res.status(), 500, "panic should be 500");
    assert!(
        res.headers().contains_key("access-control-allow-origin"),
        "CORS on panic response"
    );

    // 2. Timeout: 408 + CORS headers (uses 2/3 rate limit)
    let res = client
        .get(server.url("/slow"))
        .header("Origin", "http://example.com")
        .send()
        .await
        .unwrap();
    assert_eq!(res.status(), 408, "slow handler should timeout");
    assert!(
        res.headers().contains_key("access-control-allow-origin"),
        "CORS on timeout response"
    );

    // 3. Normal: 200 + CORS (uses 3/3 rate limit)
    let res = client
        .get(server.url("/ok"))
        .header("Origin", "http://example.com")
        .send()
        .await
        .unwrap();
    assert_eq!(res.status(), 200, "normal request should succeed");
    assert!(
        res.headers().contains_key("access-control-allow-origin"),
        "CORS on success response"
    );

    // 4. Rate limited: 429 + CORS (all 3 spent)
    let res = client
        .get(server.url("/ok"))
        .header("Origin", "http://example.com")
        .send()
        .await
        .unwrap();
    assert_eq!(res.status(), 429, "should be rate limited");
    assert!(
        res.headers().contains_key("access-control-allow-origin"),
        "CORS on rate-limited response"
    );

    // 5. Server still alive — use different IP to bypass rate limit
    let res = client
        .get(server.url("/ok"))
        .header("X-Forwarded-For", "bypass-ip")
        .send()
        .await
        .unwrap();
    assert_eq!(res.status(), 200, "server must survive the full failure chain");
}

#[tokio::test]
async fn test_concurrent_panics_and_normal_requests() {
    let server = App::new()
        .disable_request_logging()
        .get("/crash", crash_handler)
        .get("/ok", || async { "alive" })
        .into_test_server()
        .await;

    let client = Client::new();
    let mut handles = Vec::new();

    // 50 panic requests + 50 normal requests — all concurrent
    for i in 0..100u32 {
        let c = client.clone();
        let path = if i % 2 == 0 { "/crash" } else { "/ok" };
        let url = server.url(path);
        handles.push(tokio::spawn(async move {
            let res = c.get(&url).send().await.unwrap();
            (path, res.status().as_u16())
        }));
    }

    let mut ok_200 = 0u32;
    let mut crash_500 = 0u32;

    for h in handles {
        let (path, status) = h.await.unwrap();
        match (path, status) {
            ("/ok", 200) => ok_200 += 1,
            ("/crash", 500) => crash_500 += 1,
            (p, s) => panic!("unexpected: {p} returned {s}"),
        }
    }

    assert_eq!(crash_500, 50, "all panic requests should return 500");
    assert_eq!(ok_200, 50, "all normal requests should return 200");
}