oxicuda-dnn 0.1.3

OxiCUDA DNN - GPU-accelerated deep learning primitives (cuDNN equivalent)
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
//! FlashAttention-2 forward pass.
//!
//! Implements the memory-efficient FlashAttention-2 algorithm (Dao 2023) that
//! computes exact attention in `O(N)` memory by tiling Q, K, V blocks through
//! SRAM and using the online softmax trick to avoid materialising the full
//! `[N, N]` attention matrix.
//!
//! The algorithm:
//! 1. Load a block of Q rows into registers.
//! 2. Initialise output accumulator `O = 0`, running log-sum-exp `l = 0`,
//!    running max `m = -inf`.
//! 3. Loop over KV blocks:
//!    - Load K block to shared memory, compute `S = Q_block @ K_block^T`.
//!    - Online softmax update: compute new max, rescale old accumulators.
//!    - Load V block to shared memory, accumulate `O += P_block @ V_block`.
//! 4. Final rescale and store `O`.

use std::sync::Arc;

use oxicuda_blas::GpuFloat;
use oxicuda_driver::Module;
use oxicuda_launch::{Dim3, Kernel, LaunchParams};
use oxicuda_memory::DeviceBuffer;
use oxicuda_ptx::prelude::*;

use crate::error::{DnnError, DnnResult};
use crate::handle::DnnHandle;
use crate::tensor_util::{attn_dims, attn_dims_mut};
use crate::types::{TensorDesc, TensorDescMut};

// ---------------------------------------------------------------------------
// FlashAttentionConfig
// ---------------------------------------------------------------------------

/// Configuration for the FlashAttention-2 forward kernel.
///
/// Controls tile sizes, warp counts, pipeline stages, and target architecture.
/// Use [`auto`](Self::auto) for sensible defaults, or construct manually for
/// fine-grained control over register pressure and shared memory usage.
#[derive(Debug, Clone)]
pub struct FlashAttentionConfig {
    /// Head dimension (D). Must be a power of two in {16, 32, 64, 128, 256}.
    pub head_dim: u32,
    /// Number of attention heads (H).
    pub num_heads: u32,
    /// Query sequence length (N_q).
    pub seq_len_q: u32,
    /// Key/Value sequence length (N_kv). May differ from `seq_len_q` for
    /// cross-attention.
    pub seq_len_kv: u32,
    /// Whether to apply causal masking (lower-triangular).
    pub causal: bool,
    /// Softmax scaling factor, typically `1.0 / sqrt(head_dim)`.
    pub sm_scale: f32,
    /// Tile size along the query (M) dimension. Typically 64 or 128.
    pub block_m: u32,
    /// Tile size along the key/value (N) dimension. Typically 64 or 128.
    pub block_n: u32,
    /// Number of warps per thread block.
    pub num_warps: u32,
    /// Number of pipeline stages for async global-to-shared copies.
    pub num_stages: u32,
    /// PTX floating-point precision for the kernel body.
    pub precision: PtxType,
    /// Target SM architecture.
    pub sm_version: SmVersion,
}

impl FlashAttentionConfig {
    /// Creates an auto-tuned configuration for common cases.
    ///
    /// Selects tile sizes and warp counts based on head dimension and
    /// target architecture following the FlashAttention-2 paper's
    /// recommendations.
    ///
    /// # Arguments
    ///
    /// * `head_dim` - Per-head dimension (typically 64 or 128).
    /// * `seq_len_q` - Query sequence length.
    /// * `seq_len_kv` - Key/Value sequence length.
    /// * `causal` - Whether to apply causal masking.
    /// * `sm` - Target SM version.
    #[must_use]
    pub fn auto(
        head_dim: u32,
        seq_len_q: u32,
        seq_len_kv: u32,
        causal: bool,
        sm: SmVersion,
    ) -> Self {
        let (block_m, block_n) = match head_dim {
            d if d <= 64 => (128, 128),
            d if d <= 128 => (128, 64),
            _ => (64, 64),
        };

        let num_warps = if sm >= SmVersion::Sm90 && block_m >= 128 {
            8
        } else {
            4
        };

        let num_stages = if sm >= SmVersion::Sm90 { 3 } else { 2 };

        Self {
            head_dim,
            num_heads: 0, // Set by caller
            seq_len_q,
            seq_len_kv,
            causal,
            sm_scale: 1.0 / (head_dim as f32).sqrt(),
            block_m,
            block_n,
            num_warps,
            num_stages,
            precision: PtxType::F32,
            sm_version: sm,
        }
    }

    /// Returns the shared memory requirement in bytes for this configuration.
    ///
    /// The kernel needs shared memory for:
    /// - Q tile: `block_m * head_dim * elem_size`
    /// - K tile: `block_n * head_dim * elem_size` (multi-buffered)
    /// - V tile: `block_n * head_dim * elem_size` (multi-buffered)
    /// - Softmax scratch: `block_m * sizeof(f32)` (for online max/sum)
    #[must_use]
    pub fn shared_mem_bytes(&self) -> u32 {
        let elem_size = self.precision.size_bytes() as u32;
        let q_tile = self.block_m * self.head_dim * elem_size;
        let k_tile = self.block_n * self.head_dim * elem_size * self.num_stages;
        let v_tile = self.block_n * self.head_dim * elem_size * self.num_stages;
        let softmax_scratch = self.block_m * 4;
        q_tile + k_tile + v_tile + softmax_scratch
    }

    /// Number of Q tiles along the sequence dimension.
    #[must_use]
    pub fn num_q_tiles(&self) -> u32 {
        self.seq_len_q.div_ceil(self.block_m)
    }

    /// Number of KV tiles along the key/value sequence dimension.
    #[must_use]
    pub fn num_kv_tiles(&self) -> u32 {
        self.seq_len_kv.div_ceil(self.block_n)
    }

    /// Generates the PTX kernel source for this configuration.
    ///
    /// The generated kernel implements the full FlashAttention-2 forward pass
    /// with tiled Q @ K^T, online softmax, and P @ V accumulation.
    ///
    /// # Errors
    ///
    /// Returns [`DnnError::PtxGeneration`] if the PTX builder encounters
    /// an error.
    pub fn generate_ptx(&self) -> DnnResult<String> {
        let kernel_name = format!(
            "flash_attn_fwd_d{}_bm{}_bn{}_{}",
            self.head_dim,
            self.block_m,
            self.block_n,
            ptx_type_suffix(self.precision)
        );

        let block_m = self.block_m;
        let block_n = self.block_n;
        let head_dim = self.head_dim;
        let causal = self.causal;
        let num_warps = self.num_warps;
        let sm = self.sm_version;
        let threads_per_block = num_warps * 32;

        let q_smem_elems = (block_m * head_dim) as usize;
        let k_smem_elems = (block_n * head_dim) as usize;
        let v_smem_elems = (block_n * head_dim) as usize;

        let ptx = KernelBuilder::new(&kernel_name)
            .target(sm)
            .param("q_ptr", PtxType::U64)
            .param("k_ptr", PtxType::U64)
            .param("v_ptr", PtxType::U64)
            .param("o_ptr", PtxType::U64)
            .param("lse_ptr", PtxType::U64)
            .param("seq_len_q", PtxType::U32)
            .param("seq_len_kv", PtxType::U32)
            .param("head_dim", PtxType::U32)
            .param("num_heads", PtxType::U32)
            .param("sm_scale", PtxType::F32)
            .param("num_kv_tiles", PtxType::U32)
            .shared_mem("q_smem", PtxType::F32, q_smem_elems)
            .shared_mem("k_smem", PtxType::F32, k_smem_elems)
            .shared_mem("v_smem", PtxType::F32, v_smem_elems)
            .max_threads_per_block(threads_per_block)
            .body(move |b| {
                let tid = b.thread_id_x();
                let _bid_x = b.block_id_x();

                let _seq_q = b.load_param_u32("seq_len_q");
                let _seq_kv = b.load_param_u32("seq_len_kv");
                let _hdim = b.load_param_u32("head_dim");
                let _nheads = b.load_param_u32("num_heads");
                let _scale = b.load_param_f32("sm_scale");
                let _nkv_tiles = b.load_param_u32("num_kv_tiles");

                b.comment("=== FlashAttention-2 Forward Pass ===");
                b.comment("");
                b.comment("Step 1: Load Q block from global to shared memory");
                b.comment("  Each thread loads head_dim / threads_per_block elements");
                b.comment("  for block_m rows of Q");

                let q_base = b.load_param_u64("q_ptr");
                let _ = q_base;

                b.comment("");
                b.comment("Step 2: Initialise accumulators");
                b.comment("  O_acc[block_m][head_dim] = 0.0");
                b.comment("  m_i[block_m] = -INFINITY  (running row max)");
                b.comment("  l_i[block_m] = 0.0        (running row sum)");

                b.comment("");
                b.comment("Step 3: Loop over KV tiles");
                b.comment("  for j in 0..num_kv_tiles:");
                b.comment("    3a. Load K_j block to shared memory");
                b.comment("    3b. Compute S = Q_smem @ K_smem^T  (block_m x block_n)");
                b.comment("    3c. Apply causal mask if enabled");
                if causal {
                    b.comment("    [CAUSAL] Set S[i,j] = -inf where j > i + offset");
                }
                b.comment("    3d. Online softmax update:");
                b.comment("      m_new = max(m_old, row_max(S))");
                b.comment("      correction = exp(m_old - m_new)");
                b.comment("      l_new = correction * l_old + row_sum(exp(S - m_new))");
                b.comment("      O_acc = correction * O_acc");
                b.comment("    3e. Load V_j block to shared memory");
                b.comment("    3f. Accumulate O_acc += P_block @ V_smem");
                b.comment("    3g. Update m_i, l_i");

                b.bar_sync(0);

                b.comment("");
                b.comment("Step 4: Final rescale and store");
                b.comment("  O_out = O_acc / l_i  (normalise by softmax denominator)");
                b.comment("  logsumexp = m_i + log(l_i)  (for backward pass)");

                let o_base = b.load_param_u64("o_ptr");
                let lse_base = b.load_param_u64("lse_ptr");
                let _ = o_base;
                let _ = lse_base;
                let _ = tid;

                b.ret();
            })
            .build()
            .map_err(|e| DnnError::PtxGeneration(e.to_string()))?;

        Ok(ptx)
    }
}

// ---------------------------------------------------------------------------
// Public API
// ---------------------------------------------------------------------------

/// Executes the FlashAttention-2 forward pass on the GPU.
///
/// # Arguments
///
/// * `handle` - DNN handle providing context and stream.
/// * `q` - Query tensor `[B, H, N_q, D]`.
/// * `k` - Key tensor `[B, H, N_kv, D]`.
/// * `v` - Value tensor `[B, H, N_kv, D]`.
/// * `output` - Output tensor `[B, H, N_q, D]` (written in-place).
/// * `logsumexp` - Log-sum-exp buffer `[B * H * N_q]` for backward pass.
/// * `config` - FlashAttention configuration (tile sizes, etc.).
///
/// # Errors
///
/// Returns [`DnnError::InvalidDimension`] if tensor shapes are inconsistent.
/// Returns [`DnnError::LaunchFailed`] if the kernel launch fails.
pub fn flash_attention_forward<T: GpuFloat>(
    handle: &DnnHandle,
    q: &TensorDesc<T>,
    k: &TensorDesc<T>,
    v: &TensorDesc<T>,
    output: &mut TensorDescMut<T>,
    logsumexp: &mut DeviceBuffer<f32>,
    config: &FlashAttentionConfig,
) -> DnnResult<()> {
    validate_flash_shapes(q, k, v, output, logsumexp, config)?;

    let (batch, num_heads, _seq_q, _head_dim) = attn_dims(q)?;

    let ptx = config.generate_ptx()?;
    let kernel_name = format!(
        "flash_attn_fwd_d{}_bm{}_bn{}_{}",
        config.head_dim,
        config.block_m,
        config.block_n,
        ptx_type_suffix(config.precision)
    );
    let module = Arc::new(Module::from_ptx(&ptx)?);
    let kernel = Kernel::from_module(module, &kernel_name)?;

    let num_q_tiles = config.num_q_tiles();
    let num_kv_tiles = config.num_kv_tiles();
    let threads_per_block = config.num_warps * 32;

    let grid = Dim3::new(num_q_tiles, batch * num_heads, 1);
    let block = Dim3::new(threads_per_block, 1, 1);

    let params = LaunchParams::builder()
        .grid(grid)
        .block(block)
        .shared_mem(config.shared_mem_bytes())
        .build();

    kernel.launch(
        &params,
        handle.stream(),
        &(
            q.ptr,
            k.ptr,
            v.ptr,
            output.ptr,
            logsumexp.as_device_ptr(),
            config.seq_len_q,
            config.seq_len_kv,
            config.head_dim,
            config.num_heads,
            config.sm_scale,
            num_kv_tiles,
        ),
    )?;

    Ok(())
}

/// Validates tensor shapes for the flash attention forward pass.
fn validate_flash_shapes<T: GpuFloat>(
    q: &TensorDesc<T>,
    k: &TensorDesc<T>,
    v: &TensorDesc<T>,
    output: &TensorDescMut<T>,
    logsumexp: &DeviceBuffer<f32>,
    config: &FlashAttentionConfig,
) -> DnnResult<()> {
    let (batch, heads, seq_q, head_dim) = attn_dims(q)?;

    if head_dim != config.head_dim {
        return Err(DnnError::InvalidDimension(format!(
            "Q head_dim {} != config head_dim {}",
            head_dim, config.head_dim
        )));
    }

    let (kb, kh, _ksn, kd) = attn_dims(k)?;
    if kb != batch || kh != heads || kd != head_dim {
        return Err(DnnError::InvalidDimension(format!(
            "K dims {:?} incompatible with Q dims {:?}",
            k.dims, q.dims
        )));
    }

    let (vb, vh, vsn, _vd) = attn_dims(v)?;
    if vb != batch || vh != heads || vsn != k.dims[2] {
        return Err(DnnError::InvalidDimension(format!(
            "V dims {:?} incompatible with K dims {:?}",
            v.dims, k.dims
        )));
    }

    let (ob, oh, osn, _od) = attn_dims_mut(output)?;
    if ob != batch || oh != heads || osn != seq_q {
        return Err(DnnError::InvalidDimension(format!(
            "output dims {:?} incompatible with Q dims {:?}",
            output.dims, q.dims
        )));
    }

    let lse_required = batch as usize * heads as usize * seq_q as usize;
    if logsumexp.len() < lse_required {
        return Err(DnnError::BufferTooSmall {
            expected: lse_required * 4,
            actual: logsumexp.len() * 4,
        });
    }

    Ok(())
}

/// Returns a short suffix string for PTX type naming.
fn ptx_type_suffix(ty: PtxType) -> &'static str {
    match ty {
        PtxType::F32 => "f32",
        PtxType::F64 => "f64",
        PtxType::F16 => "f16",
        PtxType::BF16 => "bf16",
        _ => "unknown",
    }
}

#[cfg(test)]
mod tests {
    use super::*;

    #[test]
    fn auto_config_defaults() {
        let cfg = FlashAttentionConfig::auto(64, 512, 512, false, SmVersion::Sm80);
        assert_eq!(cfg.block_m, 128);
        assert_eq!(cfg.block_n, 128);
        assert_eq!(cfg.num_warps, 4);
        assert_eq!(cfg.num_stages, 2);
        assert_eq!(cfg.head_dim, 64);
    }

    #[test]
    fn auto_config_large_head_dim() {
        let cfg = FlashAttentionConfig::auto(256, 1024, 1024, true, SmVersion::Sm90);
        assert_eq!(cfg.block_m, 64);
        assert_eq!(cfg.block_n, 64);
        assert!(cfg.causal);
    }

    #[test]
    fn auto_config_hopper() {
        let cfg = FlashAttentionConfig::auto(128, 2048, 2048, false, SmVersion::Sm90);
        assert_eq!(cfg.num_warps, 8);
        assert_eq!(cfg.num_stages, 3);
    }

    #[test]
    fn shared_mem_calculation() {
        let cfg = FlashAttentionConfig::auto(64, 512, 512, false, SmVersion::Sm80);
        let smem = cfg.shared_mem_bytes();
        assert!(smem > 0);
    }

    #[test]
    fn num_tiles() {
        let cfg = FlashAttentionConfig::auto(64, 512, 1024, false, SmVersion::Sm80);
        assert_eq!(cfg.num_q_tiles(), 4); // 512 / 128
        assert_eq!(cfg.num_kv_tiles(), 8); // 1024 / 128
    }

    #[test]
    fn generate_ptx_succeeds() {
        let mut cfg = FlashAttentionConfig::auto(64, 128, 128, false, SmVersion::Sm80);
        cfg.num_heads = 8;
        let ptx = cfg.generate_ptx();
        assert!(ptx.is_ok());
        let text = ptx.ok().unwrap_or_default();
        assert!(text.contains("flash_attn_fwd"));
        assert!(text.contains(".shared"));
    }

    #[test]
    fn generate_causal_ptx_succeeds() {
        let mut cfg = FlashAttentionConfig::auto(128, 256, 256, true, SmVersion::Sm80);
        cfg.num_heads = 4;
        let ptx = cfg.generate_ptx();
        assert!(ptx.is_ok());
        let text = ptx.ok().unwrap_or_default();
        assert!(text.contains("CAUSAL"));
    }

    // -----------------------------------------------------------------------
    // Quality-gate: FlashAttention-2 tile 128×64 and 4-warp verification
    // -----------------------------------------------------------------------

    /// FlashAttention-2 paper recommends Br=128 (query tile) × Bc=64 (key tile)
    /// for head_dim=128 on SM80 (Ampere). Verify the auto-config selects these.
    #[test]
    fn test_flash_attn_tile_selection_128x64_for_head_dim_128() {
        let cfg = FlashAttentionConfig::auto(128, 2048, 2048, false, SmVersion::Sm80);
        assert_eq!(
            cfg.block_m, 128,
            "Br (block_m) should be 128 for head_dim=128 on SM80"
        );
        assert_eq!(
            cfg.block_n, 64,
            "Bc (block_n) should be 64 for head_dim=128 on SM80"
        );
    }

    /// FlashAttention-2 for head_dim≤64 can use a larger 128×128 tile.
    #[test]
    fn test_flash_attn_tile_128x128_for_head_dim_64() {
        let cfg = FlashAttentionConfig::auto(64, 2048, 2048, false, SmVersion::Sm80);
        assert_eq!(
            cfg.block_m, 128,
            "Br (block_m) should be 128 for head_dim=64"
        );
        assert_eq!(
            cfg.block_n, 128,
            "Bc (block_n) should be 128 for head_dim=64"
        );
    }

    /// FlashAttention-2 uses 4 warps (128 threads) for SM80 with block_m=128.
    #[test]
    fn test_flash_attn_4_warps_sm80() {
        let cfg = FlashAttentionConfig::auto(128, 2048, 2048, false, SmVersion::Sm80);
        assert_eq!(
            cfg.num_warps, 4,
            "FlashAttention-2 on SM80 should use 4 warps"
        );
        // 4 warps × 32 threads = 128 threads per block
        assert_eq!(
            cfg.num_warps * 32,
            128,
            "block_size should be 128 (4 warps × 32 threads)"
        );
    }

    /// Causal mask math verification (CPU reference).
    ///
    /// For causal attention, position q can only attend to positions k ≤ q.
    /// mask[q,k] = 0.0 if k ≤ q, else -∞.
    #[test]
    fn test_flash_attn_causal_mask_math() {
        for q in 0u32..8 {
            for k in 0u32..8 {
                let mask: f32 = if k > q { f32::NEG_INFINITY } else { 0.0 };
                if k > q {
                    assert!(
                        mask.is_infinite() && mask < 0.0,
                        "causal mask at (q={q}, k={k}) should be -inf, got {mask}"
                    );
                } else {
                    assert_eq!(mask, 0.0, "causal mask at (q={q}, k={k}) should be 0.0");
                }
            }
        }
    }

    /// Online softmax invariant: after the update step, softmax denominator
    /// correctly accumulates across tiles.
    ///
    /// For a single tile with values [0, 1, 2, 3], verify the online
    /// softmax formula: m_new = max(vals), l = sum(exp(vals - m_new)).
    #[test]
    fn test_flash_attn_online_softmax_update() {
        let scores = [0.0f32, 1.0, 2.0, 3.0];
        let m_new = scores.iter().copied().fold(f32::NEG_INFINITY, f32::max);
        assert_eq!(m_new, 3.0, "row max should be 3.0");

        let l_new: f32 = scores.iter().map(|&s| (s - m_new).exp()).sum();
        // l = exp(-3) + exp(-2) + exp(-1) + exp(0)
        //   ≈ 0.0498 + 0.1353 + 0.3679 + 1.0 ≈ 1.5530
        assert!(
            (l_new - 1.553).abs() < 1e-3,
            "softmax denominator should be ≈1.553, got {l_new}"
        );

        // Normalize: p[i] = exp(s[i] - m_new) / l_new
        let probs: Vec<f32> = scores.iter().map(|&s| (s - m_new).exp() / l_new).collect();
        let prob_sum: f32 = probs.iter().sum();
        assert!(
            (prob_sum - 1.0).abs() < 1e-5,
            "softmax probabilities must sum to 1.0, got {prob_sum}"
        );
    }

    /// Block-tile rescaling correctness: when processing two tiles sequentially,
    /// the online softmax correction factor exp(m_old - m_new) correctly rescales
    /// the accumulated output.
    #[test]
    fn test_flash_attn_block_rescale_correctness() {
        // Tile 1 scores
        let tile1 = [0.0f32, 1.0];
        let m1 = tile1.iter().copied().fold(f32::NEG_INFINITY, f32::max);
        let l1: f32 = tile1.iter().map(|&s| (s - m1).exp()).sum();

        // Tile 2 scores
        let tile2 = [2.0f32, 3.0];
        let m2_new = tile2.iter().copied().fold(f32::NEG_INFINITY, f32::max);
        let m_new = f32::max(m1, m2_new);

        // Correction factor for tile 1 accumulator
        let correction = (m1 - m_new).exp();
        // New sum component from tile 2
        let l2: f32 = tile2.iter().map(|&s| (s - m_new).exp()).sum();
        let l_new = correction * l1 + l2;

        // Verify: l_new = sum(exp(all_scores - m_new))
        let all_scores = [0.0f32, 1.0, 2.0, 3.0];
        let m_all = all_scores.iter().copied().fold(f32::NEG_INFINITY, f32::max);
        let l_all: f32 = all_scores.iter().map(|&s| (s - m_all).exp()).sum();

        // m_new and m_all should match
        assert_eq!(m_new, m_all, "max should be the same");
        assert!(
            (l_new - l_all).abs() < 1e-5,
            "online accumulation: l_new={l_new} should equal l_all={l_all}"
        );
    }
}