oxibonsai-model 0.1.4

Qwen3-8B Transformer implementation for OxiBonsai 1-bit inference
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
//! Flash Decoding: parallelized decode-phase attention.
//!
//! During inference decoding, we have Q=[1, h, d] and K/V=[S, h, d] where S can be large.
//! Flash Decoding splits the KV sequence into tiles and computes partial softmax in parallel,
//! then combines using the log-sum-exp trick.
//!
//! References: Dao et al. 2023 — "FlashDecoding++"

use rayon::prelude::*;

// ─── FlashDecodeConfig ────────────────────────────────────────────────────────

/// Configuration for flash decoding.
#[derive(Debug, Clone)]
pub struct FlashDecodeConfig {
    /// Number of tiles to split the KV sequence into.
    pub num_tiles: usize,
    /// Scale factor for attention scores: 1/sqrt(head_dim).
    pub scale: f32,
}

impl FlashDecodeConfig {
    /// Create a config with default num_tiles=4 and scale=1/sqrt(head_dim).
    pub fn new(head_dim: usize) -> Self {
        let scale = if head_dim > 0 {
            1.0_f32 / (head_dim as f32).sqrt()
        } else {
            1.0_f32
        };
        Self {
            num_tiles: 4,
            scale,
        }
    }

    /// Set the number of tiles.
    #[must_use]
    pub fn with_num_tiles(mut self, n: usize) -> Self {
        self.num_tiles = n;
        self
    }
}

// ─── flash_decode_tile ───────────────────────────────────────────────────────

/// Compute partial attention output for a single tile.
///
/// Returns `(output_tile, max_score, log_sum_exp)`.
///
/// The log-sum-exp trick:
/// ```text
/// m  = max(scores)
/// sum = Σ exp(score_i - m)
/// lse = m + ln(sum)
/// output = Σ (exp(score_i - m) / sum) * v_i
/// ```
fn flash_decode_tile(
    query: &[f32],
    keys_tile: &[f32],
    values_tile: &[f32],
    tile_len: usize,
    head_dim: usize,
    scale: f32,
) -> (Vec<f32>, f32, f32) {
    // Compute dot-product scores
    let mut scores: Vec<f32> = (0..tile_len)
        .map(|t| {
            let k_start = t * head_dim;
            let k_vec = &keys_tile[k_start..k_start + head_dim];
            query
                .iter()
                .zip(k_vec.iter())
                .map(|(q, k)| q * k)
                .sum::<f32>()
                * scale
        })
        .collect();

    // Find max for numerical stability (log-sum-exp trick)
    let max_score = scores.iter().cloned().fold(f32::NEG_INFINITY, f32::max);

    if !max_score.is_finite() {
        // All -inf: return zero output
        return (
            vec![0.0_f32; head_dim],
            f32::NEG_INFINITY,
            f32::NEG_INFINITY,
        );
    }

    // Shift scores and compute softmax weights
    for s in scores.iter_mut() {
        *s = (*s - max_score).exp();
    }
    let sum: f32 = scores.iter().sum();
    let log_sum_exp = max_score + sum.ln();

    // Weighted sum of values
    let mut output = vec![0.0_f32; head_dim];
    for (t, &w) in scores.iter().enumerate() {
        let v_start = t * head_dim;
        let v_vec = &values_tile[v_start..v_start + head_dim];
        for d in 0..head_dim {
            output[d] += w * v_vec[d];
        }
    }

    // Normalize by sum
    if sum > 0.0 {
        for o in output.iter_mut() {
            *o /= sum;
        }
    }

    (output, max_score, log_sum_exp)
}

// ─── combine_tile_outputs ────────────────────────────────────────────────────

/// Combine tile outputs using log-sum-exp reduction.
///
/// Each tile has a partial output, max score, and log-sum-exp value.
/// The final output is the weighted combination where each tile is weighted
/// by `exp(lse_i - global_lse)`.
fn combine_tile_outputs(
    tile_outputs: &[Vec<f32>],
    tile_max_scores: &[f32],
    tile_lse: &[f32],
    head_dim: usize,
) -> Vec<f32> {
    debug_assert_eq!(tile_outputs.len(), tile_lse.len());
    debug_assert_eq!(tile_outputs.len(), tile_max_scores.len());

    if tile_outputs.is_empty() {
        return vec![0.0_f32; head_dim];
    }
    if tile_outputs.len() == 1 {
        return tile_outputs[0].clone();
    }

    // Filter out tiles with -inf lse (empty or all-masked tiles)
    let valid: Vec<usize> = (0..tile_lse.len())
        .filter(|&i| tile_lse[i].is_finite())
        .collect();

    if valid.is_empty() {
        return vec![0.0_f32; head_dim];
    }
    if valid.len() == 1 {
        return tile_outputs[valid[0]].clone();
    }

    // Global log-sum-exp across tile LSEs
    let global_lse_max = valid
        .iter()
        .map(|&i| tile_lse[i])
        .fold(f32::NEG_INFINITY, f32::max);

    let global_sum: f32 = valid
        .iter()
        .map(|&i| (tile_lse[i] - global_lse_max).exp())
        .sum();
    let global_lse = global_lse_max + global_sum.ln();

    // Combine: output = Σ_tile exp(lse_tile - global_lse) * output_tile
    let mut combined = vec![0.0_f32; head_dim];
    for &i in &valid {
        let weight = (tile_lse[i] - global_lse).exp();
        for d in 0..head_dim {
            combined[d] += weight * tile_outputs[i][d];
        }
    }

    combined
}

// ─── flash_decode_single_head ─────────────────────────────────────────────────

/// Compute attention for a single query token against full KV cache.
///
/// - `query`:   shape `[head_dim]`
/// - `keys`:    shape `[seq_len * head_dim]` (row-major: token is outer dim)
/// - `values`:  shape `[seq_len * head_dim]`
/// - Returns:   shape `[head_dim]`
pub fn flash_decode_single_head(
    query: &[f32],
    keys: &[f32],
    values: &[f32],
    seq_len: usize,
    head_dim: usize,
    config: &FlashDecodeConfig,
) -> Result<Vec<f32>, FlashDecodeError> {
    if seq_len == 0 {
        return Err(FlashDecodeError::EmptyKv);
    }
    if query.len() != head_dim {
        return Err(FlashDecodeError::DimMismatch {
            q_dim: query.len(),
            k_dim: head_dim,
        });
    }
    if keys.len() != seq_len * head_dim {
        return Err(FlashDecodeError::DimMismatch {
            q_dim: query.len(),
            k_dim: keys.len() / seq_len.max(1),
        });
    }
    if values.len() != seq_len * head_dim {
        return Err(FlashDecodeError::DimMismatch {
            q_dim: query.len(),
            k_dim: values.len() / seq_len.max(1),
        });
    }

    // Clamp num_tiles to seq_len
    let num_tiles = config.num_tiles.min(seq_len).max(1);

    let tile_size_base = seq_len / num_tiles;
    let remainder = seq_len % num_tiles;

    let mut tile_outputs: Vec<Vec<f32>> = Vec::with_capacity(num_tiles);
    let mut tile_max_scores: Vec<f32> = Vec::with_capacity(num_tiles);
    let mut tile_lse: Vec<f32> = Vec::with_capacity(num_tiles);

    let mut offset = 0usize;
    for tile_idx in 0..num_tiles {
        // Distribute remainder tokens among the first `remainder` tiles
        let tile_len = tile_size_base + if tile_idx < remainder { 1 } else { 0 };
        if tile_len == 0 {
            break;
        }

        let k_start = offset * head_dim;
        let k_end = k_start + tile_len * head_dim;
        let v_start = offset * head_dim;
        let v_end = v_start + tile_len * head_dim;

        let (out, max_s, lse) = flash_decode_tile(
            query,
            &keys[k_start..k_end],
            &values[v_start..v_end],
            tile_len,
            head_dim,
            config.scale,
        );
        tile_outputs.push(out);
        tile_max_scores.push(max_s);
        tile_lse.push(lse);

        offset += tile_len;
    }

    Ok(combine_tile_outputs(
        &tile_outputs,
        &tile_max_scores,
        &tile_lse,
        head_dim,
    ))
}

// ─── flash_decode_multi_head ─────────────────────────────────────────────────

/// Multi-head flash decode: compute attention across all heads in parallel (via rayon).
///
/// - `queries`: shape `[num_heads * head_dim]`
/// - `keys`:    shape `[seq_len * num_heads * head_dim]` (token-major)
/// - `values`:  same shape as `keys`
///
/// Returns flattened `[num_heads * head_dim]`.
pub fn flash_decode_multi_head(
    queries: &[f32],
    keys: &[f32],
    values: &[f32],
    num_heads: usize,
    seq_len: usize,
    head_dim: usize,
    config: &FlashDecodeConfig,
) -> Result<Vec<f32>, FlashDecodeError> {
    if seq_len == 0 {
        return Err(FlashDecodeError::EmptyKv);
    }
    if queries.len() != num_heads * head_dim {
        return Err(FlashDecodeError::DimMismatch {
            q_dim: queries.len(),
            k_dim: head_dim,
        });
    }

    // Re-index keys/values from [seq_len, num_heads, head_dim] to per-head
    // [seq_len, head_dim] slices for each head.
    // We build per-head key and value buffers.
    let per_head_keys: Vec<Vec<f32>> = (0..num_heads)
        .map(|h| {
            let mut buf = vec![0.0_f32; seq_len * head_dim];
            for t in 0..seq_len {
                let src_start = t * num_heads * head_dim + h * head_dim;
                let dst_start = t * head_dim;
                buf[dst_start..dst_start + head_dim]
                    .copy_from_slice(&keys[src_start..src_start + head_dim]);
            }
            buf
        })
        .collect();

    let per_head_values: Vec<Vec<f32>> = (0..num_heads)
        .map(|h| {
            let mut buf = vec![0.0_f32; seq_len * head_dim];
            for t in 0..seq_len {
                let src_start = t * num_heads * head_dim + h * head_dim;
                let dst_start = t * head_dim;
                buf[dst_start..dst_start + head_dim]
                    .copy_from_slice(&values[src_start..src_start + head_dim]);
            }
            buf
        })
        .collect();

    // Process each head in parallel using rayon
    let results: Vec<Result<Vec<f32>, FlashDecodeError>> = (0..num_heads)
        .into_par_iter()
        .map(|h| {
            let q_start = h * head_dim;
            let q_vec = &queries[q_start..q_start + head_dim];
            flash_decode_single_head(
                q_vec,
                &per_head_keys[h],
                &per_head_values[h],
                seq_len,
                head_dim,
                config,
            )
        })
        .collect();

    // Flatten results
    let mut output = vec![0.0_f32; num_heads * head_dim];
    for (h, res) in results.into_iter().enumerate() {
        let head_out = res?;
        let start = h * head_dim;
        output[start..start + head_dim].copy_from_slice(&head_out);
    }

    Ok(output)
}

// ─── flash_vs_naive_error ─────────────────────────────────────────────────────

/// Compare flash decode vs naive attention (for testing).
///
/// Returns the mean absolute error between the two implementations.
pub fn flash_vs_naive_error(
    query: &[f32],
    keys: &[f32],
    values: &[f32],
    seq_len: usize,
    head_dim: usize,
) -> Result<f32, FlashDecodeError> {
    if seq_len == 0 {
        return Err(FlashDecodeError::EmptyKv);
    }
    if query.len() != head_dim {
        return Err(FlashDecodeError::DimMismatch {
            q_dim: query.len(),
            k_dim: head_dim,
        });
    }

    // Flash decode output
    let config = FlashDecodeConfig::new(head_dim);
    let flash_out = flash_decode_single_head(query, keys, values, seq_len, head_dim, &config)?;

    // Naive attention output
    let scale = config.scale;
    let mut scores: Vec<f32> = (0..seq_len)
        .map(|t| {
            let k_start = t * head_dim;
            let k_vec = &keys[k_start..k_start + head_dim];
            query
                .iter()
                .zip(k_vec.iter())
                .map(|(q, k)| q * k)
                .sum::<f32>()
                * scale
        })
        .collect();

    // Softmax
    let max_s = scores.iter().cloned().fold(f32::NEG_INFINITY, f32::max);
    for s in scores.iter_mut() {
        *s = (*s - max_s).exp();
    }
    let sum: f32 = scores.iter().sum();
    if sum > 0.0 {
        for s in scores.iter_mut() {
            *s /= sum;
        }
    }

    // Weighted sum of values
    let mut naive_out = vec![0.0_f32; head_dim];
    for (t, &w) in scores.iter().enumerate() {
        let v_start = t * head_dim;
        for d in 0..head_dim {
            naive_out[d] += w * values[v_start + d];
        }
    }

    // Mean absolute error
    let mae = flash_out
        .iter()
        .zip(naive_out.iter())
        .map(|(a, b)| (a - b).abs())
        .sum::<f32>()
        / head_dim as f32;

    Ok(mae)
}

// ─── FlashDecodeError ────────────────────────────────────────────────────────

/// Errors from flash decode operations.
#[derive(Debug, thiserror::Error)]
pub enum FlashDecodeError {
    #[error("empty KV sequence")]
    EmptyKv,

    #[error("dimension mismatch: query has {q_dim}, keys have {k_dim}")]
    DimMismatch { q_dim: usize, k_dim: usize },

    #[error("num_tiles ({0}) exceeds seq_len ({1})")]
    TooManyTiles(usize, usize),

    #[error("invalid config: {0}")]
    InvalidConfig(String),
}

// ─── Tests ───────────────────────────────────────────────────────────────────

#[cfg(test)]
mod tests {
    use super::*;

    fn make_deterministic_data(seq_len: usize, head_dim: usize) -> (Vec<f32>, Vec<f32>, Vec<f32>) {
        let query: Vec<f32> = (0..head_dim).map(|i| 0.1 * i as f32).collect();
        let keys: Vec<f32> = (0..seq_len * head_dim)
            .map(|i| 0.05 * i as f32 + 0.01)
            .collect();
        let values: Vec<f32> = (0..seq_len * head_dim)
            .map(|i| 0.02 * i as f32 + 0.1)
            .collect();
        (query, keys, values)
    }

    #[test]
    fn flash_decode_config_default() {
        let head_dim = 64usize;
        let cfg = FlashDecodeConfig::new(head_dim);
        let expected_scale = 1.0_f32 / (head_dim as f32).sqrt();
        assert!(
            (cfg.scale - expected_scale).abs() < 1e-6,
            "scale mismatch: {} vs {}",
            cfg.scale,
            expected_scale
        );
        assert_eq!(cfg.num_tiles, 4);
    }

    #[test]
    fn flash_decode_single_head_matches_naive() {
        let head_dim = 16;
        let seq_len = 32;
        let (q, k, v) = make_deterministic_data(seq_len, head_dim);
        let mae = flash_vs_naive_error(&q, &k, &v, seq_len, head_dim)
            .expect("flash_vs_naive_error failed");
        assert!(
            mae < 1e-5,
            "MAE between flash and naive exceeds threshold: {mae}"
        );
    }

    #[test]
    fn flash_decode_empty_kv_error() {
        let head_dim = 8;
        let config = FlashDecodeConfig::new(head_dim);
        let q = vec![0.1f32; head_dim];
        let result = flash_decode_single_head(&q, &[], &[], 0, head_dim, &config);
        assert!(
            matches!(result, Err(FlashDecodeError::EmptyKv)),
            "expected EmptyKv, got {result:?}"
        );
    }

    #[test]
    fn flash_decode_dim_mismatch_error() {
        let head_dim = 8;
        let config = FlashDecodeConfig::new(head_dim);
        // query has wrong length
        let q = vec![0.1f32; head_dim + 2];
        let k = vec![0.1f32; head_dim];
        let v = vec![0.1f32; head_dim];
        let result = flash_decode_single_head(&q, &k, &v, 1, head_dim, &config);
        assert!(
            matches!(result, Err(FlashDecodeError::DimMismatch { .. })),
            "expected DimMismatch, got {result:?}"
        );
    }

    #[test]
    fn flash_decode_single_token() {
        // seq_len=1: output should equal value[0] (since softmax of single element = 1.0)
        let head_dim = 4;
        let config = FlashDecodeConfig::new(head_dim);
        let q = vec![1.0f32, 0.0, 0.0, 0.0];
        let k = vec![0.5f32, 0.5, 0.5, 0.5]; // single key
        let v = vec![3.0f32, 1.0, 2.0, 4.0]; // single value

        let out = flash_decode_single_head(&q, &k, &v, 1, head_dim, &config)
            .expect("flash_decode_single_head failed");

        for (i, (&o, &expected)) in out.iter().zip(v.iter()).enumerate() {
            assert!(
                (o - expected).abs() < 1e-5,
                "output[{i}] = {o}, expected {expected}"
            );
        }
    }

    #[test]
    fn flash_decode_uniform_keys() {
        // When all keys are identical and uniform queries, output = average of values
        // Actually: uniform attention weights → output = mean of values per dimension
        let head_dim = 4;
        let seq_len = 4;
        let config = FlashDecodeConfig::new(head_dim);
        let q = vec![0.1f32; head_dim];
        let k = vec![0.1f32; seq_len * head_dim]; // identical keys

        // Values: row t has all elements = (t+1) as f32
        let v: Vec<f32> = (0..seq_len)
            .flat_map(|t| vec![(t + 1) as f32; head_dim])
            .collect();

        let out = flash_decode_single_head(&q, &k, &v, seq_len, head_dim, &config)
            .expect("flash_decode_single_head failed");

        // With uniform keys, all attention weights equal 1/seq_len
        // Expected output per dim = mean of [1, 2, 3, 4] = 2.5
        let expected = 2.5_f32;
        for (i, &o) in out.iter().enumerate() {
            assert!(
                (o - expected).abs() < 1e-4,
                "output[{i}] = {o}, expected {expected}"
            );
        }
    }

    #[test]
    fn flash_decode_tile_count_1() {
        let head_dim = 8;
        let seq_len = 16;
        let config = FlashDecodeConfig::new(head_dim).with_num_tiles(1);
        let (q, k, v) = make_deterministic_data(seq_len, head_dim);
        let result = flash_decode_single_head(&q, &k, &v, seq_len, head_dim, &config);
        assert!(result.is_ok(), "num_tiles=1 should be valid: {result:?}");
    }

    #[test]
    fn flash_decode_tile_count_many() {
        let head_dim = 8;
        let seq_len = 16;
        let config = FlashDecodeConfig::new(head_dim).with_num_tiles(8);
        let (q, k, v) = make_deterministic_data(seq_len, head_dim);
        let result = flash_decode_single_head(&q, &k, &v, seq_len, head_dim, &config);
        assert!(
            result.is_ok(),
            "num_tiles=8 with seq_len=16 failed: {result:?}"
        );
    }

    #[test]
    fn flash_vs_naive_error_small() {
        let head_dim = 32;
        let seq_len = 64;
        let (q, k, v) = make_deterministic_data(seq_len, head_dim);
        let mae = flash_vs_naive_error(&q, &k, &v, seq_len, head_dim)
            .expect("flash_vs_naive_error failed");
        assert!(mae < 1e-4, "MAE too large: {mae}");
    }

    #[test]
    fn flash_decode_multi_head_shape() {
        let num_heads = 4;
        let head_dim = 8;
        let seq_len = 16;
        let config = FlashDecodeConfig::new(head_dim);

        let queries = vec![0.1f32; num_heads * head_dim];
        let keys = vec![0.05f32; seq_len * num_heads * head_dim];
        let values = vec![0.2f32; seq_len * num_heads * head_dim];

        let out = flash_decode_multi_head(
            &queries, &keys, &values, num_heads, seq_len, head_dim, &config,
        )
        .expect("multi_head flash decode failed");

        assert_eq!(
            out.len(),
            num_heads * head_dim,
            "output shape mismatch: {} vs {}",
            out.len(),
            num_heads * head_dim
        );
    }

    #[test]
    fn flash_decode_multi_head_matches_naive_per_head() {
        let num_heads = 2;
        let head_dim = 8;
        let seq_len = 16;
        let config = FlashDecodeConfig::new(head_dim);

        // Deterministic data
        let queries: Vec<f32> = (0..num_heads * head_dim).map(|i| 0.1 * i as f32).collect();
        let keys: Vec<f32> = (0..seq_len * num_heads * head_dim)
            .map(|i| 0.05 * (i % 17) as f32 + 0.01)
            .collect();
        let values: Vec<f32> = (0..seq_len * num_heads * head_dim)
            .map(|i| 0.02 * (i % 13) as f32 + 0.1)
            .collect();

        let flash_out = flash_decode_multi_head(
            &queries, &keys, &values, num_heads, seq_len, head_dim, &config,
        )
        .expect("multi_head flash decode failed");

        // Check each head individually against naive attention
        for h in 0..num_heads {
            let q_vec = &queries[h * head_dim..(h + 1) * head_dim];

            // Extract per-head K/V
            let mut k_head = vec![0.0f32; seq_len * head_dim];
            let mut v_head = vec![0.0f32; seq_len * head_dim];
            for t in 0..seq_len {
                let src_k = t * num_heads * head_dim + h * head_dim;
                let src_v = t * num_heads * head_dim + h * head_dim;
                let dst = t * head_dim;
                k_head[dst..dst + head_dim].copy_from_slice(&keys[src_k..src_k + head_dim]);
                v_head[dst..dst + head_dim].copy_from_slice(&values[src_v..src_v + head_dim]);
            }

            let naive_config = FlashDecodeConfig::new(head_dim).with_num_tiles(1);
            let naive_out =
                flash_decode_single_head(q_vec, &k_head, &v_head, seq_len, head_dim, &naive_config)
                    .expect("naive single head failed");

            let head_flash = &flash_out[h * head_dim..(h + 1) * head_dim];
            let mae: f32 = head_flash
                .iter()
                .zip(naive_out.iter())
                .map(|(a, b)| (a - b).abs())
                .sum::<f32>()
                / head_dim as f32;
            assert!(
                mae < 1e-4,
                "head {h}: MAE between multi_head flash and single-head naive = {mae}"
            );
        }
    }

    #[test]
    fn combine_tiles_single_tile() {
        let head_dim = 4;
        let tile_out = vec![1.0f32, 2.0, 3.0, 4.0];
        let combined = combine_tile_outputs(
            std::slice::from_ref(&tile_out),
            &[0.5_f32],
            &[1.0_f32],
            head_dim,
        );
        // Single tile: output == tile output
        for (i, (&c, &t)) in combined.iter().zip(tile_out.iter()).enumerate() {
            assert!((c - t).abs() < 1e-5, "combined[{i}] = {c}, expected {t}");
        }
    }

    #[test]
    fn flash_decode_long_sequence() {
        let head_dim = 16;
        let seq_len = 128;
        let config = FlashDecodeConfig::new(head_dim).with_num_tiles(8);
        let (q, k, v) = make_deterministic_data(seq_len, head_dim);
        let result = flash_decode_single_head(&q, &k, &v, seq_len, head_dim, &config);
        assert!(
            result.is_ok(),
            "long sequence (seq_len=128) failed: {result:?}"
        );
        let out = result.expect("already checked");
        assert_eq!(out.len(), head_dim);
        for (i, &o) in out.iter().enumerate() {
            assert!(o.is_finite(), "output[{i}] = {o} is not finite");
        }
    }
}