oxframe_2d/

shader.rs

//! A shader node: WGSL `Params` plus `shade`, checked with naga.
//!
//! The waves preset is rasterized on the CPU, so a check without a GPU
//! still paints it. Both backends then draw that image, which keeps the
//! preset the same on either one. The lens_drops preset reads the frame
//! drawn before it (see [`crate::post`]). A custom `shade` is type-checked
//! on every draw (a changed file is picked up without a rebuild) and is
//! not executed.

use std::cell::Cell;

use kurbo::{Affine, Point};
use oxframe_core::{Color, Signal};

use crate::draw::Primitive;
use crate::graph::{NodeData, NodeKind};
use crate::image::RasterImage;

/// Where the WGSL text comes from. Stored on a shader node.
#[doc(hidden)]
#[derive(Clone)]
pub enum ShaderCode {
    /// Source kept on the node.
    Wgsl(String),
    /// Read again on every draw, so an edit shows up without a rebuild.
    File(std::path::PathBuf),
}

/// Which built-in a shader node runs. Stored on a shader node.
#[doc(hidden)]
#[derive(Debug, Clone, Copy, PartialEq, Eq)]
pub enum Preset {
    /// User WGSL: checked, not executed.
    Custom,
    /// [`waves`](crate::waves): painted inside the node's box.
    Waves,
    /// [`lens_drops`](crate::lens_drops): changes the frame drawn before it.
    LensDrops,
}

impl Preset {
    /// `"custom"`, `"waves"` or `"lens_drops"`.
    pub fn name(self) -> &'static str {
        match self {
            Self::Custom => "custom",
            Self::Waves => "waves",
            Self::LensDrops => "lens_drops",
        }
    }
}

/// Parameters of the lens_drops preset, all numbers.
const LENS_PARAMS: [&str; 3] = ["wetness", "seed", "drop_size"];

/// Inputs the lens_drops preset reads.
const LENS_INPUTS: [&str; 1] = ["scene"];

/// One value passed to `Params`. Stored on a shader node.
#[doc(hidden)]
pub struct Uniform {
    pub name: String,
    pub value: UniformValue,
}

/// A number, a point, a color, or a bool stored as 0 or 1.
#[doc(hidden)]
#[allow(dead_code)]
pub enum UniformValue {
    /// An `f32` field.
    Num(Signal<f64>),
    /// A `vec2<f32>` field.
    Vec2(Signal<kurbo::Vec2>),
    /// A `vec4<f32>` color field.
    Color(Signal<Color>),
    /// A `bool` field, stored as 0 or 1 so it can be animated.
    Bool(Signal<f64>),
}

/// A WGSL problem found while painting.
#[derive(Debug, Clone, PartialEq)]
pub struct ShaderDiag {
    /// `.name(..)`, or the node kind and id.
    pub node: String,
    /// `file:line` of the `add` call, when it was recorded.
    pub source: Option<String>,
    /// `shader_error`, `param_unknown`, or `shader_slow`.
    pub rule: &'static str,
    /// What to change.
    pub hint: String,
}

const WAVES: &str = r#"struct Params { amp: f32, speed: f32, deep: vec4<f32>, foam: vec4<f32> }
@group(1) @binding(0) var<uniform> p: Params;

fn shade(i: ShadeIn) -> vec4<f32> {
    let h = sin(i.world.x * 0.008 + ox.time * p.speed) * p.amp;
    let t = smoothstep(h - 0.02, h + 0.02, i.uv.y - 0.5);
    return mix(p.foam, p.deep, t);
}
"#;

/// WGSL of the waves preset.
pub(crate) fn waves_wgsl() -> &'static str {
    WAVES
}

#[cfg(not(target_arch = "wasm32"))]
const PRELUDE: &str = r#"struct Ox {
    time: f32,
    frame: f32,
    resolution: vec2<f32>,
    size: vec2<f32>,
    seed: f32,
    view: mat4x4<f32>,
    progress: f32,
}
@group(0) @binding(0) var<uniform> ox: Ox;

struct ShadeIn {
    uv: vec2<f32>,
    local: vec2<f32>,
    world: vec2<f32>,
    screen: vec2<f32>,
}

"#;

#[cfg(not(target_arch = "wasm32"))]
const EPILOGUE: &str = r#"
struct _OxVertexOut {
    @builtin(position) pos: vec4<f32>,
    @location(0) uv: vec2<f32>,
    @location(1) local: vec2<f32>,
    @location(2) world: vec2<f32>,
    @location(3) screen: vec2<f32>,
}

@vertex
fn _ox_vs(@builtin(vertex_index) index: u32) -> _OxVertexOut {
    var positions = array<vec2<f32>, 3>(
        vec2<f32>(-1.0, -1.0),
        vec2<f32>(3.0, -1.0),
        vec2<f32>(-1.0, 3.0),
    );
    let p = positions[index];
    var out: _OxVertexOut;
    out.pos = vec4<f32>(p, 0.0, 1.0);
    out.uv = vec2<f32>(p.x * 0.5 + 0.5, 0.5 - p.y * 0.5);
    out.local = out.uv;
    out.world = out.uv;
    out.screen = out.uv;
    return out;
}

@fragment
fn _ox_fs(in: _OxVertexOut) -> @location(0) vec4<f32> {
    var s: ShadeIn;
    s.uv = in.uv;
    s.local = in.local;
    s.world = in.world;
    s.screen = in.screen;
    return shade(s);
}
"#;

thread_local! {
    static DRAFT: Cell<bool> = const { Cell::new(false) };
    static BUDGET_MS: Cell<f64> = const { Cell::new(250.0) };
    static DIAGS: std::cell::RefCell<Vec<ShaderDiag>> = const { std::cell::RefCell::new(Vec::new()) };
}

pub(crate) fn clear_diags() {
    DIAGS.with(|d| d.borrow_mut().clear());
}

pub(crate) fn push_diag(diag: ShaderDiag) {
    DIAGS.with(|d| d.borrow_mut().push(diag));
}

pub(crate) fn take_diags() -> Vec<ShaderDiag> {
    DIAGS.with(|d| std::mem::take(&mut *d.borrow_mut()))
}

/// Restores the previous draft flag when dropped.
pub struct ShaderDraft {
    prev: bool,
}

impl Drop for ShaderDraft {
    fn drop(&mut self) {
        DRAFT.with(|d| d.set(self.prev));
    }
}

/// Paints shader nodes at half resolution until dropped.
///
/// Timings and positions stay the same. `oxframe check` uses this so a
/// shader layer does not dominate the budget.
pub fn draft_shaders() -> ShaderDraft {
    let prev = DRAFT.with(Cell::get);
    DRAFT.with(|d| d.set(true));
    ShaderDraft { prev }
}

/// Milliseconds a shader raster may take before `shader_slow`.
pub fn set_shader_budget_ms(ms: f64) {
    BUDGET_MS.with(|b| b.set(ms));
}

fn draft() -> bool {
    DRAFT.with(Cell::get)
}

fn budget_ms() -> f64 {
    BUDGET_MS.with(Cell::get)
}

/// Compile and parameter problems for this node, and a video that could
/// not be opened. Empty for other nodes.
pub(crate) fn problems(n: &NodeData) -> Vec<ShaderDiag> {
    if let NodeKind::Video { data, .. } = &n.kind {
        return data
            .problem
            .iter()
            .map(|p| ShaderDiag {
                node: label(n),
                source: n.source.clone(),
                rule: "video_unavailable",
                hint: format!("{}: {p}", data.path.display()),
            })
            .collect();
    }
    let NodeKind::Shader {
        code,
        uniforms,
        preset,
        inputs,
        ..
    } = &n.kind
    else {
        return Vec::new();
    };
    let label = label(n);
    let source = n.source.clone();
    let diag = |hint: String| {
        vec![ShaderDiag {
            node: label.clone(),
            source: source.clone(),
            rule: "param_unknown",
            hint,
        }]
    };
    let known: &[&str] = match preset {
        Preset::LensDrops => &LENS_INPUTS,
        Preset::Waves => &[],
        // Inputs of a custom shade are not executed, so any name is kept.
        Preset::Custom => &[],
    };
    if *preset != Preset::Custom {
        for (name, _) in inputs {
            if !known.contains(&name.as_str()) {
                return diag(unknown("input", name, known));
            }
        }
    }
    if *preset == Preset::LensDrops {
        for u in uniforms {
            if !LENS_PARAMS.contains(&u.name.as_str()) {
                return diag(unknown("parameter", &u.name, &LENS_PARAMS));
            }
            if !matches!(u.value, UniformValue::Num(_)) {
                return diag(format!("`{}` of lens_drops is a number.", u.name));
            }
        }
        return Vec::new();
    }
    let text = match load(code) {
        Ok(text) => text,
        Err(hint) => {
            return vec![ShaderDiag {
                node: label,
                source,
                rule: "shader_error",
                hint,
            }];
        }
    };
    match check_wgsl(&text, uniforms) {
        Ok(()) => Vec::new(),
        Err(diag) => vec![ShaderDiag {
            node: label,
            source,
            rule: diag.0,
            hint: diag.1,
        }],
    }
}

/// Raster of a waves node, or nothing when this node is not the preset.
pub(crate) fn raster(
    n: &NodeData,
    size: (f64, f64),
    tf: Affine,
    time: f64,
    opacity: f64,
) -> Option<Primitive> {
    let NodeKind::Shader {
        preset, uniforms, ..
    } = &n.kind
    else {
        return None;
    };
    if *preset != Preset::Waves {
        return None;
    }
    let (w, h) = (size.0.max(1.0), size.1.max(1.0));
    let scale = if draft() { 0.5 } else { 1.0 };
    let iw = ((w * scale).round() as u32).clamp(1, 1920);
    let ih = ((h * scale).round() as u32).clamp(1, 1080);
    let (amp, speed, deep, foam) = wave_uniforms(uniforms);
    let started = Stopwatch::start();
    let mut rgba = vec![0u8; iw as usize * ih as usize * 4];
    for py in 0..ih {
        for px in 0..iw {
            let lx = (f64::from(px) + 0.5) / f64::from(iw) * w - w / 2.0;
            let ly = (f64::from(py) + 0.5) / f64::from(ih) * h - h / 2.0;
            let world = tf * Point::new(lx, ly);
            let uv_y = (f64::from(py) + 0.5) / f64::from(ih);
            let crest = (world.x * 0.008 + time * speed).sin() * amp;
            let t = smoothstep(crest - 0.02, crest + 0.02, uv_y - 0.5);
            let c = mix(foam, deep, t, opacity);
            let i = (py as usize * iw as usize + px as usize) * 4;
            rgba[i] = byte(c.r);
            rgba[i + 1] = byte(c.g);
            rgba[i + 2] = byte(c.b);
            rgba[i + 3] = byte(c.a);
        }
    }
    let ms = started.millis();
    if ms > budget_ms() {
        push_diag(ShaderDiag {
            node: label(n),
            source: n.source.clone(),
            rule: "shader_slow",
            hint: format!(
                "This shader took {ms:.0} ms in draft. The budget is {:.0} ms.",
                budget_ms()
            ),
        });
    }
    let rect = kurbo::Rect::new(-w / 2.0, -h / 2.0, w / 2.0, h / 2.0);
    Some(Primitive::Image {
        image: std::rc::Rc::new(RasterImage {
            width: iw,
            height: ih,
            id: hash_bytes(&rgba),
            rgba,
        }),
        rect,
        opacity: 1.0,
    })
}

/// The frame marker of a lens_drops node, or nothing for other shaders.
///
/// `area` is the node's box in scene coordinates. The node reads the frame
/// drawn before it whatever its input is named: a backdrop outside a layer
/// is the frame.
pub(crate) fn read_frame(
    n: &NodeData,
    size: (f64, f64),
    tf: Affine,
    time: f64,
    opacity: f64,
) -> Option<crate::post::Shade> {
    let NodeKind::Shader {
        preset: Preset::LensDrops,
        uniforms,
        ..
    } = &n.kind
    else {
        return None;
    };
    let num = |name: &str, default: f64| {
        uniforms
            .iter()
            .find_map(|u| match (&u.name[..], &u.value) {
                (m, UniformValue::Num(v)) if m == name => Some(v.get()),
                _ => None,
            })
            .unwrap_or(default)
    };
    let (w, h) = (size.0.max(0.0), size.1.max(0.0));
    let area = tf.transform_rect_bbox(kurbo::Rect::new(-w / 2.0, -h / 2.0, w / 2.0, h / 2.0));
    Some(crate::post::Shade {
        op: crate::post::ShadeOp::LensDrops {
            wetness: num("wetness", 0.6),
            seed: num("seed", 0.0).max(0.0) as u64,
            scale: num("drop_size", 1.0),
            time,
        },
        opacity,
        area: Some(area),
    })
}

/// `no input `x`. Did you mean `y`? Available: …` for a preset.
fn unknown(what: &str, name: &str, known: &[&str]) -> String {
    let list = if known.is_empty() {
        "none".to_owned()
    } else {
        known.join(", ")
    };
    match closest(name, known) {
        Some(n) => format!("no {what} `{name}`. Did you mean `{n}`? Available: {list}."),
        None => format!("no {what} `{name}`. Available: {list}."),
    }
}

/// Wall clock for `shader_slow`.
///
/// `Instant::now()` panics on `wasm32-unknown-unknown`, which ended the
/// playground's waves example in "unreachable executed". A check never runs
/// in the browser, so there the watch reads 0 and `shader_slow` stays quiet.
#[cfg(not(target_arch = "wasm32"))]
struct Stopwatch(std::time::Instant);

#[cfg(target_arch = "wasm32")]
struct Stopwatch;

impl Stopwatch {
    fn start() -> Self {
        #[cfg(not(target_arch = "wasm32"))]
        {
            Self(std::time::Instant::now())
        }
        #[cfg(target_arch = "wasm32")]
        {
            Self
        }
    }

    fn millis(&self) -> f64 {
        #[cfg(not(target_arch = "wasm32"))]
        {
            self.0.elapsed().as_secs_f64() * 1000.0
        }
        #[cfg(target_arch = "wasm32")]
        {
            0.0
        }
    }
}

fn wave_uniforms(uniforms: &[Uniform]) -> (f64, f64, Color, Color) {
    let mut amp = 0.05;
    let mut speed = 1.0;
    let mut deep = Color::BLACK;
    let mut foam = Color::WHITE;
    for u in uniforms {
        match (&u.name[..], &u.value) {
            ("amp", UniformValue::Num(v)) => amp = v.get(),
            ("speed", UniformValue::Num(v)) => speed = v.get(),
            ("deep", UniformValue::Color(v)) => deep = v.get(),
            ("foam", UniformValue::Color(v)) => foam = v.get(),
            _ => {}
        }
    }
    (amp, speed, deep, foam)
}

fn load(code: &ShaderCode) -> Result<String, String> {
    match code {
        ShaderCode::Wgsl(text) => Ok(text.clone()),
        ShaderCode::File(path) => read_file(path),
    }
}

#[cfg(not(target_arch = "wasm32"))]
fn read_file(path: &std::path::Path) -> Result<String, String> {
    std::fs::read_to_string(path).map_err(|e| format!("{}: {e}", path.display()))
}

#[cfg(target_arch = "wasm32")]
fn read_file(path: &std::path::Path) -> Result<String, String> {
    let _ = path;
    Err("a shader file is read by the native renderer".into())
}

fn label(n: &NodeData) -> String {
    n.name
        .clone()
        .unwrap_or_else(|| format!("{}#{}", n.kind.name(), n.id.0))
}

#[cfg(target_arch = "wasm32")]
fn check_wgsl(_text: &str, _uniforms: &[Uniform]) -> Result<(), (&'static str, String)> {
    Ok(())
}

#[cfg(not(target_arch = "wasm32"))]
fn check_wgsl(text: &str, uniforms: &[Uniform]) -> Result<(), (&'static str, String)> {
    let full = format!("{PRELUDE}{text}{EPILOGUE}");
    let module = naga::front::wgsl::parse_str(&full).map_err(|e| {
        (
            "shader_error",
            shift_lines(&e.emit_to_string(&full), prelude_lines()),
        )
    })?;
    naga::valid::Validator::new(
        naga::valid::ValidationFlags::all(),
        naga::valid::Capabilities::all(),
    )
    .validate(&module)
    .map_err(|e| ("shader_error", shift_lines(&e.to_string(), prelude_lines())))?;
    let fields = params_of(&module).ok_or((
        "shader_error",
        "the shader has no `struct Params`".to_string(),
    ))?;
    match params(uniforms, &fields) {
        Ok(()) => Ok(()),
        Err(hint) => Err(("param_unknown", hint)),
    }
}

#[cfg(not(target_arch = "wasm32"))]
fn prelude_lines() -> usize {
    PRELUDE.lines().count()
}

/// naga reports lines in the wrapped source. Subtract the prelude so the
/// number points at the user's text.
#[cfg(not(target_arch = "wasm32"))]
fn shift_lines(message: &str, by: usize) -> String {
    let chars: Vec<char> = message.chars().collect();
    let mut out = String::with_capacity(message.len());
    let mut i = 0;
    while i < chars.len() {
        if chars[i] == ':' && i + 1 < chars.len() && chars[i + 1].is_ascii_digit() {
            let start = i + 1;
            let mut end = start;
            while end < chars.len() && chars[end].is_ascii_digit() {
                end += 1;
            }
            let digits: String = chars[start..end].iter().collect();
            let line: usize = digits.parse().unwrap_or(0);
            out.push(':');
            out.push_str(&line.saturating_sub(by).to_string());
            i = end;
        } else {
            out.push(chars[i]);
            i += 1;
        }
    }
    out
}

#[cfg(not(target_arch = "wasm32"))]
enum WgslTy {
    F32,
    Vec2,
    Vec4,
    Bool,
    Other,
}

#[cfg(not(target_arch = "wasm32"))]
fn params_of(module: &naga::Module) -> Option<Vec<(String, WgslTy)>> {
    for (_, ty) in module.types.iter() {
        if ty.name.as_deref() != Some("Params") {
            continue;
        }
        let naga::TypeInner::Struct { members, .. } = &ty.inner else {
            continue;
        };
        return Some(
            members
                .iter()
                .map(|m| {
                    let name = m.name.clone().unwrap_or_default();
                    (name, wgsl_ty(&module.types[m.ty].inner))
                })
                .collect(),
        );
    }
    None
}

#[cfg(not(target_arch = "wasm32"))]
fn wgsl_ty(inner: &naga::TypeInner) -> WgslTy {
    match inner {
        naga::TypeInner::Scalar(s) if s.kind == naga::ScalarKind::Float && s.width == 4 => {
            WgslTy::F32
        }
        naga::TypeInner::Scalar(s) if s.kind == naga::ScalarKind::Bool => WgslTy::Bool,
        naga::TypeInner::Vector { size, scalar }
            if scalar.kind == naga::ScalarKind::Float
                && scalar.width == 4
                && *size == naga::VectorSize::Bi =>
        {
            WgslTy::Vec2
        }
        naga::TypeInner::Vector { size, scalar }
            if scalar.kind == naga::ScalarKind::Float
                && scalar.width == 4
                && *size == naga::VectorSize::Quad =>
        {
            WgslTy::Vec4
        }
        _ => WgslTy::Other,
    }
}

#[cfg(not(target_arch = "wasm32"))]
fn params(uniforms: &[Uniform], fields: &[(String, WgslTy)]) -> Result<(), String> {
    let names: Vec<&str> = fields.iter().map(|(n, _)| n.as_str()).collect();
    let list = names.join(", ");
    for u in uniforms {
        let Some((_, ty)) = fields.iter().find(|(n, _)| n == &u.name) else {
            let near = closest(&u.name, &names);
            let hint = match near {
                Some(n) => format!(
                    "no parameter `{}`. Did you mean `{n}`? Available: {list}.",
                    u.name
                ),
                None => format!("no parameter `{}`. Available: {list}.", u.name),
            };
            return Err(hint);
        };
        if !type_matches(&u.value, ty) {
            return Err(format!(
                "`{}` is {} in Params, but the scene sets {}.",
                u.name,
                ty_name(ty),
                value_name(&u.value)
            ));
        }
    }
    for (name, _) in fields {
        if !uniforms.iter().any(|u| u.name == *name) {
            return Err(format!(
                "Params.{name} has no value. Set it with `.uniform(\"{name}\", ...)`."
            ));
        }
    }
    Ok(())
}

#[cfg(not(target_arch = "wasm32"))]
fn type_matches(value: &UniformValue, ty: &WgslTy) -> bool {
    matches!(
        (value, ty),
        (UniformValue::Num(_), WgslTy::F32)
            | (UniformValue::Vec2(_), WgslTy::Vec2)
            | (UniformValue::Color(_), WgslTy::Vec4)
            | (UniformValue::Bool(_), WgslTy::Bool)
    )
}

#[cfg(not(target_arch = "wasm32"))]
fn ty_name(ty: &WgslTy) -> &'static str {
    match ty {
        WgslTy::F32 => "f32",
        WgslTy::Vec2 => "vec2<f32>",
        WgslTy::Vec4 => "vec4<f32>",
        WgslTy::Bool => "bool",
        WgslTy::Other => "another type",
    }
}

#[cfg(not(target_arch = "wasm32"))]
fn value_name(value: &UniformValue) -> &'static str {
    match value {
        UniformValue::Num(_) => "a number",
        UniformValue::Vec2(_) => "a point",
        UniformValue::Color(_) => "a color",
        UniformValue::Bool(_) => "a bool",
    }
}

fn closest<'a>(name: &str, options: &[&'a str]) -> Option<&'a str> {
    options
        .iter()
        .copied()
        .filter(|o| edit(name, o) <= 3 && *o != name)
        .min_by_key(|o| edit(name, o))
}

fn edit(a: &str, b: &str) -> usize {
    let a: Vec<char> = a.chars().collect();
    let b: Vec<char> = b.chars().collect();
    let mut prev: Vec<usize> = (0..=b.len()).collect();
    let mut cur = vec![0; b.len() + 1];
    for (i, ca) in a.iter().enumerate() {
        cur[0] = i + 1;
        for (j, cb) in b.iter().enumerate() {
            let cost = usize::from(ca != cb);
            cur[j + 1] = (prev[j + 1] + 1).min(cur[j] + 1).min(prev[j] + cost);
        }
        std::mem::swap(&mut prev, &mut cur);
    }
    prev[b.len()]
}

fn smoothstep(e0: f64, e1: f64, x: f64) -> f64 {
    let t = if (e1 - e0).abs() < 1e-9 {
        if x < e0 { 0.0 } else { 1.0 }
    } else {
        ((x - e0) / (e1 - e0)).clamp(0.0, 1.0)
    };
    t * t * (3.0 - 2.0 * t)
}

fn mix(foam: Color, deep: Color, t: f64, opacity: f64) -> Color {
    let t = t as f32;
    let a = opacity.clamp(0.0, 1.0) as f32;
    Color {
        r: foam.r + (deep.r - foam.r) * t,
        g: foam.g + (deep.g - foam.g) * t,
        b: foam.b + (deep.b - foam.b) * t,
        a: (foam.a + (deep.a - foam.a) * t) * a,
    }
}

fn byte(c: f32) -> u8 {
    (c.clamp(0.0, 1.0) * 255.0).round() as u8
}

fn hash_bytes(bytes: &[u8]) -> u64 {
    let mut h: u64 = 0xcbf2_9ce4_8422_2325;
    for &b in bytes {
        h = (h ^ u64::from(b)).wrapping_mul(0x0100_0000_01b3);
    }
    h
}

#[cfg(test)]
mod tests {
    use super::*;
    use crate::builder::NodeBuilder;
    use crate::{SceneGraph, View};
    use std::rc::Rc;

    fn paint(f: impl FnOnce(View)) -> Rc<SceneGraph> {
        let graph = SceneGraph::new(320, 180);
        graph.enter(|| f(View::current()));
        graph
    }

    fn image_of(graph: &SceneGraph) -> Rc<RasterImage> {
        let items = graph.draw_list();
        for item in &items {
            if let Primitive::Image { image, .. } = &item.prim {
                return image.clone();
            }
        }
        panic!("waves did not paint, diags: {:?}", graph.shader_diags());
    }

    #[test]
    fn waves_put_foam_above_deep_water() {
        let graph = paint(|view| {
            view.add(crate::waves().width(200.0).height(80.0));
        });
        let image = image_of(&graph);
        let px = |x: u32, y: u32| {
            let i = (y * image.width + x) as usize * 4;
            image.rgba[i + 2]
        };
        let mid = image.width / 2;
        assert!(
            px(mid, 2) > px(mid, image.height - 3),
            "the crest is the lighter foam"
        );
        assert!(
            graph.shader_diags().is_empty(),
            "{:?}",
            graph.shader_diags()
        );
    }

    #[test]
    fn the_crest_moves_along_the_wave() {
        let graph = paint(|view| {
            view.add(crate::waves().amp(0.2).width(200.0).height(80.0));
        });
        let a = image_of(&graph).rgba.clone();
        graph.set_time(1.0);
        let b = image_of(&graph).rgba.clone();
        assert_ne!(a, b);
    }

    #[test]
    fn a_misspelled_uniform_names_the_real_one() {
        let graph = paint(|view| {
            view.add(
                crate::Shader::source(waves_wgsl())
                    .uniform("ampp", 0.1)
                    .uniform("speed", 1.0)
                    .uniform_color("deep", Color::BLACK)
                    .uniform_color("foam", Color::WHITE)
                    .width(40.0)
                    .height(20.0)
                    .name("sea"),
            );
        });
        let _ = graph.draw_list();
        let diag = graph
            .shader_diags()
            .into_iter()
            .find(|d| d.rule == "param_unknown")
            .expect("param_unknown");
        assert_eq!(diag.node, "sea");
        assert!(diag.hint.contains("amp"), "{diag:?}");
    }

    #[test]
    fn a_broken_shader_is_an_error() {
        let graph = paint(|view| {
            view.add(
                crate::Shader::source("this is not wgsl")
                    .width(40.0)
                    .height(20.0),
            );
        });
        let _ = graph.draw_list();
        assert!(
            graph
                .shader_diags()
                .iter()
                .any(|d| d.rule == "shader_error"),
            "{:?}",
            graph.shader_diags()
        );
    }

    #[cfg(not(target_arch = "wasm32"))]
    #[test]
    fn editing_the_file_is_seen_on_the_next_draw() {
        let dir = std::env::temp_dir().join(format!("oxframe-shader-{}", std::process::id()));
        std::fs::create_dir_all(&dir).unwrap();
        let path = dir.join("sea.wgsl");
        std::fs::write(&path, "this is not wgsl").unwrap();
        let graph = paint(|view| {
            view.add(crate::Shader::file(&path).width(40.0).height(20.0));
        });
        let _ = graph.draw_list();
        assert!(
            graph
                .shader_diags()
                .iter()
                .any(|d| d.rule == "shader_error"),
            "{:?}",
            graph.shader_diags()
        );
        std::fs::write(&path, waves_wgsl()).unwrap();
        let _ = graph.draw_list();
        let diags = graph.shader_diags();
        assert!(diags.iter().all(|d| d.rule != "shader_error"), "{diags:?}");
        let _ = std::fs::remove_dir_all(&dir);
    }

    fn rules(graph: &SceneGraph) -> Vec<&'static str> {
        let _ = graph.draw_list();
        graph.shader_diags().iter().map(|d| d.rule).collect()
    }

    fn reads_frame(graph: &SceneGraph) -> bool {
        graph
            .draw_list()
            .iter()
            .any(|i| matches!(i.prim, Primitive::ReadFrame(_)))
    }

    #[test]
    fn lens_drops_read_the_frame() {
        let graph = paint(|view| {
            view.add(
                crate::lens_drops()
                    .fullscreen()
                    .input("scene", crate::Input::frame()),
            );
        });
        assert!(graph.has_post());
        assert!(reads_frame(&graph));
        assert!(rules(&graph).is_empty(), "{:?}", graph.shader_diags());
        let passes = crate::pass_graph(&graph.draw_list());
        assert!(
            passes
                .iter()
                .any(|p| p.kind == crate::PassKind::Effect && p.shader == Some("lens_drops"))
        );
    }

    #[test]
    fn a_misspelled_input_or_parameter_names_the_real_one() {
        let graph = paint(|view| {
            view.add(
                crate::lens_drops()
                    .input("scen", crate::Input::frame())
                    .name("lens"),
            );
        });
        let _ = graph.draw_list();
        let diag = &graph.shader_diags()[0];
        assert_eq!((diag.rule, diag.node.as_str()), ("param_unknown", "lens"));
        assert!(diag.hint.contains("`scene`"), "{diag:?}");

        let graph = paint(|view| {
            view.add(crate::lens_drops().uniform("wetnes", 1.0));
        });
        let _ = graph.draw_list();
        let diag = &graph.shader_diags()[0];
        assert!(diag.hint.contains("`wetness`"), "{diag:?}");

        let graph = paint(|view| {
            view.add(crate::waves().input("scene", crate::Input::frame()));
        });
        assert_eq!(rules(&graph), ["param_unknown"]);
    }

    #[test]
    fn a_lens_inside_a_fading_group_is_an_input_cycle() {
        let graph = paint(|view| {
            let group = view.add(crate::Group::new().opacity(0.5));
            group.add(crate::Rect::new().size(20.0));
            group.add(crate::lens_drops().fullscreen());
        });
        assert_eq!(rules(&graph), ["input_cycle"]);
        assert!(!reads_frame(&graph), "the lens is skipped");
    }

    #[test]
    fn an_effect_inside_an_effect_is_an_input_cycle() {
        let graph = paint(|view| {
            let outer = view.add(crate::Group::new());
            let inner = outer.add(crate::Rect::new().size(20.0));
            outer.effect(crate::ripple());
            inner.effect(crate::ripple());
        });
        assert_eq!(rules(&graph), ["input_cycle"]);
        let items = graph.draw_list();
        let begins = items
            .iter()
            .filter(|i| matches!(i.prim, Primitive::BeginEffect(_)))
            .count();
        assert_eq!(begins, 1, "only the outer effect runs");
        let passes = crate::pass_graph(&items);
        assert!(
            passes
                .iter()
                .any(|p| p.kind == crate::PassKind::Effect && p.shader == Some("ripple"))
        );
    }

    #[test]
    fn effect_signals_animate_the_marker() {
        let graph = SceneGraph::new(320, 180);
        let effect = graph.enter(|| {
            View::current()
                .add(crate::Rect::new().size(40.0))
                .effect(crate::ripple().strength(0.0))
        });
        let strength = |graph: &SceneGraph| {
            graph.draw_list().iter().find_map(|i| match &i.prim {
                Primitive::BeginEffect(s) => match s.op {
                    crate::post::ShadeOp::Ripple { strength, .. } => Some(strength),
                    _ => None,
                },
                _ => None,
            })
        };
        assert_eq!(strength(&graph), Some(0.0));
        graph.enter(|| effect.strength().set(0.7));
        assert_eq!(strength(&graph), Some(0.7));
    }

    #[test]
    fn a_slow_raster_is_reported() {
        let graph = paint(|view| {
            view.add(crate::waves().width(180.0).height(80.0).name("sea"));
        });
        set_shader_budget_ms(0.0);
        let _ = graph.draw_list();
        set_shader_budget_ms(250.0);
        assert!(
            graph.shader_diags().iter().any(|d| d.rule == "shader_slow"),
            "{:?}",
            graph.shader_diags()
        );
    }
}