otel-arrow-dfe-engine 0.61.0

Async pipeline engine
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
// Copyright The OpenTelemetry Authors
// SPDX-License-Identifier: Apache-2.0

use super::{DstRng, SimClock, dst_seeds};
use crate::Interests;
use crate::clock;
use crate::control::{
    AckMsg, ControlSenders, NackMsg, NodeControlMsg, PipelineCompletionMsg, RuntimeControlMsg,
    pipeline_completion_msg_channel,
};
use crate::message::{ExporterInbox, Message, ProcessorInbox, Receiver};
use crate::node::NodeType;
use crate::pipeline_ctrl::PipelineCompletionMsgDispatcher;
use crate::testing::dst::common::{
    DstPData, build_manager, create_mock_control_sender, empty_node_metric_handles, frame,
    setup_dst_runtime, yield_cycles,
};
use crate::testing::test_nodes;
use otel_arrow_dfe_channel::mpsc;
use otel_arrow_dfe_config::policy::TelemetryPolicy;
use otel_arrow_dfe_telemetry::reporter::MetricsReporter;
use std::cell::RefCell;
use std::collections::HashSet;
use std::rc::Rc;
use std::time::Duration;
use tokio::time::timeout;

// Use a short flush interval in DST so control-plane metric code stays active
// during the seeded backpressure sweep without introducing long waits.
const DST_CONTROL_PLANE_METRICS_FLUSH_INTERVAL: Duration = Duration::from_millis(10);

#[derive(Debug, Default)]
struct FlowState {
    admitted: HashSet<u64>,
    forwarded: HashSet<u64>,
    completed: HashSet<u64>,
    ack_count: usize,
    nack_count: usize,
    receiver_blocked_count: usize,
    processor_timer_ticks: usize,
    processor_paused_seen: bool,
    processor_resumed_seen: bool,
    receiver_drain_seen: bool,
    receiver_drained_sent: bool,
    processor_shutdown_seen: bool,
    exporter_shutdown_seen: bool,
    runtime_noise_sent: usize,
}

// Seeded end-to-end pressure scenario: the receiver keeps admitting until the
// bounded pdata path blocks, the processor alternates between paused and
// resumed admission, the exporter schedules delayed completions, and unrelated
// runtime-control noise competes with all of it. This is the representative
// "interblock" case where no single component should wedge the others.
async fn run_backpressure_interblock_seed(seed: u64) {
    let clock = SimClock::new();
    let _clock_guard = clock.install();
    let (rt, local_tasks) = setup_dst_runtime();

    rt.block_on(local_tasks.run_until(async move {
        let mut rng = DstRng::new(seed);
        let nodes = test_nodes(vec!["receiver", "processor", "exporter"]);
        let receiver_id = nodes[0].clone();
        let processor_id = nodes[1].clone();
        let exporter_id = nodes[2].clone();

        let mut control_senders = ControlSenders::new();
        let mut receiver_control_rx = None;
        let mut processor_control_rx = None;
        let mut exporter_control_rx = None;
        for (node, node_type, capacity) in [
            (receiver_id.clone(), NodeType::Receiver, 16usize),
            (processor_id.clone(), NodeType::Processor, 8usize),
            (exporter_id.clone(), NodeType::Exporter, 8usize),
        ] {
            let (sender, receiver) = create_mock_control_sender::<DstPData>(capacity);
            control_senders.register(node.clone(), node_type, sender);
            match node.index {
                idx if idx == receiver_id.index => receiver_control_rx = Some(receiver),
                idx if idx == processor_id.index => processor_control_rx = Some(receiver),
                idx if idx == exporter_id.index => exporter_control_rx = Some(receiver),
                _ => unreachable!("unexpected node id"),
            }
        }

        let (manager, runtime_tx, _scope, pipeline_context) =
            build_manager::<DstPData>(32, control_senders.clone());
        let (completion_tx, completion_rx) = pipeline_completion_msg_channel(16);
        let dispatcher = PipelineCompletionMsgDispatcher::new(
            pipeline_context,
            completion_rx,
            control_senders.clone(),
            empty_node_metric_handles(),
            MetricsReporter::create_new_and_receiver(16).1,
            DST_CONTROL_PLANE_METRICS_FLUSH_INTERVAL,
            TelemetryPolicy::default(),
            crate::terminal_state::TerminalMetricsDeadline::default(),
        );

        let manager_handle = tokio::task::spawn_local(async move { manager.run().await });
        let dispatcher_handle = tokio::task::spawn_local(async move { dispatcher.run().await });

        let (recv_to_proc_tx, recv_to_proc_rx) = mpsc::Channel::<DstPData>::new(4);
        let (proc_to_export_tx, proc_to_export_rx) = mpsc::Channel::<DstPData>::new(4);

        let state = Rc::new(RefCell::new(FlowState::default()));
        let total_messages = 24 + rng.gen_range(8) as u64;
        let max_inflight = 4usize + rng.gen_range(2);

        let receiver_state = state.clone();
        let receiver_runtime_tx = runtime_tx.clone();
        let receiver_handle = tokio::task::spawn_local(async move {
            let mut control_rx = receiver_control_rx.expect("receiver control receiver");
            let mut pending = None;
            let mut next_id = 0u64;
            let mut draining = false;
            let drained_reported = false;

            loop {
                if draining {
                    if !drained_reported {
                        receiver_runtime_tx
                            .send(RuntimeControlMsg::ReceiverDrained {
                                node_id: receiver_id.index,
                            })
                            .await
                            .expect("receiver drained should be sent");
                        receiver_state.borrow_mut().receiver_drained_sent = true;
                    }
                    break;
                }

                if pending.is_none() && next_id < total_messages {
                    let msg_id = next_id;
                    next_id += 1;
                    pending = Some(DstPData::with_frames(
                        msg_id,
                        vec![
                            frame(
                                receiver_id.index,
                                Interests::NODE_OUTPUT_METRICS,
                                msg_id * 10 + 1,
                            ),
                            frame(
                                processor_id.index,
                                Interests::ACKS
                                    | Interests::NACKS
                                    | if msg_id.is_multiple_of(3) {
                                        Interests::RETURN_DATA
                                    } else {
                                        Interests::empty()
                                    },
                                msg_id * 10 + 2,
                            ),
                            frame(
                                exporter_id.index,
                                Interests::NODE_INPUT_METRICS,
                                msg_id * 10 + 3,
                            ),
                        ],
                    ));
                }

                if let Some(pdata) = pending.take() {
                    tokio::select! {
                        biased;

                        ctrl = control_rx.recv() => match ctrl {
                            Ok(NodeControlMsg::DrainIngress { .. }) => {
                                receiver_state.borrow_mut().receiver_drain_seen = true;
                                draining = true;
                                pending = Some(pdata);
                            }
                            Ok(NodeControlMsg::Shutdown { .. }) => {
                                break;
                            }
                            Ok(_) => {
                                pending = Some(pdata);
                            }
                            Err(_) => break,
                        },

                        _ = tokio::task::yield_now() => {
                            let msg_id = pdata.id;
                            match recv_to_proc_tx.send(pdata) {
                                Ok(()) => {
                                    let _ = receiver_state.borrow_mut().admitted.insert(msg_id);
                                }
                                Err(otel_arrow_dfe_channel::error::SendError::Full(pdata)) => {
                                    receiver_state.borrow_mut().receiver_blocked_count += 1;
                                    pending = Some(pdata);
                                }
                                Err(otel_arrow_dfe_channel::error::SendError::Closed(_)) => break,
                            }
                        }
                    }
                } else {
                    match control_rx.recv().await {
                        Ok(NodeControlMsg::DrainIngress { .. }) => {
                            receiver_state.borrow_mut().receiver_drain_seen = true;
                            draining = true;
                        }
                        Ok(NodeControlMsg::Shutdown { .. }) => break,
                        Ok(_) => {}
                        Err(_) => break,
                    }
                }
            }

            drop(recv_to_proc_tx);
        });

        let processor_state = state.clone();
        let processor_handle = tokio::task::spawn_local(async move {
            let mut inflight = 0usize;
            let mut was_paused = false;
            let mut msg_channel = ProcessorInbox::new(
                processor_control_rx.expect("processor control receiver"),
                Receiver::Local(crate::local::message::LocalReceiver::mpsc(recv_to_proc_rx)),
                processor_id.index,
                Interests::empty(),
            );

            while let Ok(msg) = msg_channel.recv_when(inflight < max_inflight).await {
                let paused = inflight >= max_inflight;
                if paused {
                    processor_state.borrow_mut().processor_paused_seen = true;
                } else if was_paused {
                    processor_state.borrow_mut().processor_resumed_seen = true;
                }
                was_paused = paused;

                match msg {
                    Message::PData(pdata) => {
                        let msg_id = pdata.id;
                        proc_to_export_tx
                            .send_async(pdata)
                            .await
                            .expect("processor should forward pdata");
                        inflight += 1;
                        let _ = processor_state.borrow_mut().forwarded.insert(msg_id);
                    }
                    Message::Control(NodeControlMsg::Ack(ack)) => {
                        inflight = inflight.saturating_sub(1);
                        let mut state = processor_state.borrow_mut();
                        state.ack_count += 1;
                        let inserted = state.completed.insert(ack.accepted.id);
                        assert!(inserted, "seed={seed}: duplicate ack completion");
                    }
                    Message::Control(NodeControlMsg::Nack(nack)) => {
                        inflight = inflight.saturating_sub(1);
                        let mut state = processor_state.borrow_mut();
                        state.nack_count += 1;
                        let inserted = state.completed.insert(nack.refused.id);
                        assert!(inserted, "seed={seed}: duplicate nack completion");
                    }
                    Message::Control(NodeControlMsg::TimerTick {}) => {
                        processor_state.borrow_mut().processor_timer_ticks += 1;
                    }
                    Message::Control(NodeControlMsg::Shutdown { .. }) => {
                        processor_state.borrow_mut().processor_shutdown_seen = true;
                        break;
                    }
                    Message::Control(_) => {}
                }
            }

            drop(proc_to_export_tx);
        });

        let exporter_state = state.clone();
        let exporter_completion_tx = completion_tx.clone();
        let exporter_handle = tokio::task::spawn_local(async move {
            struct ScheduledCompletion {
                when: std::time::Instant,
                pdata: DstPData,
                permanent: bool,
                nack: bool,
            }

            let mut msg_channel = ExporterInbox::new(
                exporter_control_rx.expect("exporter control receiver"),
                Receiver::Local(crate::local::message::LocalReceiver::mpsc(proc_to_export_rx)),
                exporter_id.index,
                Interests::empty(),
            );
            let mut scheduled: Vec<ScheduledCompletion> = Vec::new();

            loop {
                let next_due = scheduled.iter().map(|item| item.when).min();

                tokio::select! {
                    biased;

                    _ = async {
                        if let Some(when) = next_due
                            && when > clock::now()
                        {
                            clock::sleep_until(when).await;
                        }
                    }, if next_due.is_some() => {
                        let now = clock::now();
                        let mut ready = Vec::new();
                        let mut pending = Vec::with_capacity(scheduled.len());
                        for item in scheduled.drain(..) {
                            if item.when <= now {
                                ready.push(item);
                            } else {
                                pending.push(item);
                            }
                        }
                        scheduled = pending;

                        for item in ready {
                            if item.nack {
                                let nack = if item.permanent {
                                    NackMsg::new_permanent("dst-permanent", item.pdata)
                                } else {
                                    NackMsg::new("dst-temporary", item.pdata)
                                };
                                exporter_completion_tx
                                    .send(PipelineCompletionMsg::DeliverNack { nack })
                                    .await
                                    .expect("exporter should deliver nack");
                            } else {
                                exporter_completion_tx
                                    .send(PipelineCompletionMsg::DeliverAck {
                                        ack: AckMsg::new(item.pdata),
                                    })
                                    .await
                                    .expect("exporter should deliver ack");
                            }
                        }
                    }

                    msg = msg_channel.recv() => match msg {
                        Ok(Message::PData(pdata)) => {
                            let msg_id = pdata.id;
                            let delay_ms = 2 + ((msg_id + seed) % 4);
                            scheduled.push(ScheduledCompletion {
                                when: clock::now() + Duration::from_millis(delay_ms),
                                permanent: msg_id.is_multiple_of(11),
                                nack: msg_id.is_multiple_of(7),
                                pdata,
                            });
                        }
                        Ok(Message::Control(NodeControlMsg::Shutdown { .. })) => {
                            exporter_state.borrow_mut().exporter_shutdown_seen = true;
                            break;
                        }
                        Ok(Message::Control(_)) => {}
                        Err(_) => break,
                    }
                }
            }
        });

        runtime_tx
            .send(RuntimeControlMsg::StartTimer {
                node_id: processor_id.index,
                duration: Duration::from_millis(3),
            })
            .await
            .unwrap();

        let completion_target = total_messages as usize;
        for step in 0..400usize {
            for _ in 0..(2 + rng.gen_range(3)) {
                runtime_tx
                    .send(RuntimeControlMsg::CancelTelemetryTimer {
                        node_id: exporter_id.index,
                        _temp: Default::default(),
                    })
                    .await
                    .unwrap();
                state.borrow_mut().runtime_noise_sent += 1;
            }

            clock.advance(Duration::from_millis(1));
            yield_cycles(4).await;

            let done = {
                let state = state.borrow();
                state.completed.len() == completion_target
                    && state.admitted.len() == completion_target
                    && state.forwarded.len() == completion_target
                    && state.processor_paused_seen
                    && state.processor_resumed_seen
                    && state.processor_timer_ticks > 0
                    && state.receiver_blocked_count > 0
            };

            if done {
                assert!(
                    step < 399,
                    "seed={seed}: backpressure scenario only completed at final step"
                );
                break;
            }

            if step == 399 {
                let snapshot = state.borrow();
                panic!(
                    "seed={seed}: heavy ingress scenario stalled: admitted={}, forwarded={}, completed={}, blocked={}, timer_ticks={}, paused={}, resumed={}",
                    snapshot.admitted.len(),
                    snapshot.forwarded.len(),
                    snapshot.completed.len(),
                    snapshot.receiver_blocked_count,
                    snapshot.processor_timer_ticks,
                    snapshot.processor_paused_seen,
                    snapshot.processor_resumed_seen,
                );
            }
        }

        {
            let snapshot = state.borrow();
            assert_eq!(
                snapshot.admitted.len(),
                completion_target,
                "seed={seed}: receiver did not admit all expected pdata"
            );
            assert_eq!(
                snapshot.forwarded.len(),
                completion_target,
                "seed={seed}: processor did not forward all admitted pdata"
            );
            assert_eq!(
                snapshot.completed.len(),
                completion_target,
                "seed={seed}: processor did not observe terminal completion for all forwarded pdata"
            );
            assert!(
                snapshot.ack_count > 0 && snapshot.nack_count > 0,
                "seed={seed}: scenario should exercise both ack and nack completions"
            );
        }

        runtime_tx
            .send(RuntimeControlMsg::Shutdown {
                deadline: clock.now() + Duration::from_millis(50),
                reason: format!("dst-heavy-ingress-{seed}"),
            })
            .await
            .unwrap();
        clock.advance(Duration::from_millis(1));
        yield_cycles(8).await;

        timeout(Duration::from_secs(1), receiver_handle)
            .await
            .expect("receiver should exit")
            .unwrap();

        clock.advance(Duration::from_millis(5));
        yield_cycles(8).await;

        timeout(Duration::from_secs(1), processor_handle)
            .await
            .expect("processor should exit")
            .unwrap();
        timeout(Duration::from_secs(1), exporter_handle)
            .await
            .expect("exporter should exit")
            .unwrap();

        drop(completion_tx);
        drop(runtime_tx);

        timeout(Duration::from_secs(1), manager_handle)
            .await
            .expect("manager should exit")
            .unwrap()
            .expect("manager should succeed");
        timeout(Duration::from_secs(1), dispatcher_handle)
            .await
            .expect("dispatcher should exit")
            .unwrap()
            .expect("dispatcher should succeed");

        let snapshot = state.borrow();
        assert!(
            snapshot.receiver_drain_seen,
            "seed={seed}: receiver did not observe DrainIngress"
        );
        assert!(
            snapshot.receiver_drained_sent,
            "seed={seed}: receiver did not report ReceiverDrained"
        );
        assert!(
            snapshot.processor_shutdown_seen,
            "seed={seed}: processor did not observe Shutdown"
        );
        assert!(
            snapshot.exporter_shutdown_seen,
            "seed={seed}: exporter did not observe Shutdown"
        );
        assert!(
            snapshot.runtime_noise_sent > 0,
            "seed={seed}: runtime noise was not generated"
        );
    }));
}

// Drive a seeded heavy-ingress scenario with bounded pdata channels, processor
// admission gating, mixed Ack/Nack completion traffic, and runtime noise. This
// documents the interblock class the refactor was designed to keep live.
#[test]
fn dst_heavy_ingress_backpressure_seeded() {
    for seed in dst_seeds(&[7, 23, 31], 8) {
        futures::executor::block_on(run_backpressure_interblock_seed(seed));
    }
}