ostool-server 0.2.0

Server for managing development boards, serial sessions, and TFTP artifacts
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
use std::time::Duration;

use anyhow::Context;
use axum::extract::ws::{Message, WebSocket};
use base64::Engine;
use futures_util::{Sink, SinkExt, StreamExt};
use serde::Deserialize;
use tokio::io::{AsyncReadExt, AsyncWriteExt};
use tokio::task::JoinHandle;
use tokio_serial::SerialPortBuilderExt;

use crate::{
    config::BoardConfig,
    power::{PowerAction, PowerActionError},
    serial::discovery::resolve_serial_config,
    session::SessionState,
    state::AppState,
};

#[derive(Debug, Deserialize)]
struct ClientControlMessage {
    #[serde(rename = "type")]
    kind: String,
    encoding: Option<String>,
    data: Option<String>,
}

pub async fn run_serial_ws(
    socket: WebSocket,
    state: AppState,
    session: std::sync::Arc<SessionState>,
) {
    let result = run_serial_ws_inner(socket, &state, session.clone()).await;
    session.clear_serial_connected();
    if let Err(err) = result {
        log::warn!("serial websocket ended with error: {err:#}");
    }
}

async fn run_serial_ws_inner(
    socket: WebSocket,
    state: &AppState,
    session: std::sync::Arc<SessionState>,
) -> anyhow::Result<()> {
    let session_id = session.snapshot().await.id;
    let board = session.board().clone();
    let serial = board
        .serial
        .as_ref()
        .ok_or_else(|| anyhow::anyhow!("board has no serial configuration"))?;
    let resolved_serial = resolve_serial_config(serial)?;
    let port = tokio_serial::new(&resolved_serial.current_device_path, serial.baud_rate)
        .timeout(Duration::from_millis(200))
        .open_native_async()
        .with_context(|| {
            format!(
                "failed to open serial port {}",
                resolved_serial.current_device_path
            )
        })?;

    let (mut ws_sender, mut ws_receiver) = socket.split();
    let (mut serial_rx, mut serial_tx) = tokio::io::split(port);
    let mut serial_buffer = [0u8; 1024];
    let mut power_on_task = Some(spawn_power_action_task(
        state.clone(),
        board.clone(),
        PowerAction::On,
    ));
    let power_linked = true;
    let mut shutdown_rx = session.subscribe_shutdown();

    ws_sender
        .send(Message::Text(r#"{"type":"opened"}"#.to_string().into()))
        .await
        .ok();
    let result = async {
        loop {
            if let Some(task) = power_on_task.as_mut() {
                tokio::select! {
                    power_result = task => {
                        power_on_task = None;
                        match power_result {
                            Ok(Ok(_)) => {}
                            Ok(Err(err)) => {
                                let message = format!("automatic power-on failed: {err}");
                                log::warn!("session `{session_id}` {message}");
                                send_power_on_failure_and_close(&mut ws_sender, &message).await;
                                break;
                            }
                            Err(err) => {
                                let message = format!("automatic power-on task join failed: {err}");
                                log::warn!("session `{session_id}` {message}");
                                send_power_on_failure_and_close(&mut ws_sender, &message).await;
                                break;
                            }
                        }
                    }
                    changed = shutdown_rx.changed() => {
                        if changed.is_ok() && *shutdown_rx.borrow() {
                            let _ = ws_sender
                                .send(Message::Text(r#"{"type":"closed"}"#.to_string().into()))
                                .await;
                            break;
                        }
                    }
                    maybe_message = ws_receiver.next() => {
                        let Some(message) = maybe_message else {
                            break;
                        };
                        match message {
                            Ok(Message::Binary(bytes)) => {
                                write_serial_payload(&mut serial_tx, &bytes).await?;
                            }
                            Ok(Message::Text(text)) => {
                                let control: ClientControlMessage = serde_json::from_str(&text)?;
                                match control.kind.as_str() {
                                    "close" => {
                                        let _ = ws_sender
                                            .send(Message::Text(r#"{"type":"closed"}"#.to_string().into()))
                                            .await;
                                        break;
                                    }
                                    "tx" => {
                                        let Some(data) = control.data.as_deref() else {
                                            anyhow::bail!("missing tx data");
                                        };
                                        let payload = match control.encoding.as_deref() {
                                            Some("base64") => base64::engine::general_purpose::STANDARD
                                                .decode(data)
                                                .context("invalid base64 payload")?,
                                            Some("utf8") | None => data.as_bytes().to_vec(),
                                            Some(other) => anyhow::bail!("unsupported encoding `{other}`"),
                                        };
                                        write_serial_payload(&mut serial_tx, &payload).await?;
                                    }
                                    other => anyhow::bail!("unsupported websocket control type `{other}`"),
                                }
                            }
                            Ok(Message::Close(_)) => break,
                            Ok(Message::Ping(payload)) => {
                                ws_sender.send(Message::Pong(payload)).await.ok();
                            }
                            Ok(Message::Pong(_)) => {}
                            Err(err) => return Err(err.into()),
                        }
                        let _ = session.heartbeat().await;
                    }
                    read = serial_rx.read(&mut serial_buffer) => {
                        let read = read.context("serial read failed")?;
                        if read == 0 {
                            break;
                        }
                        ws_sender
                            .send(Message::Binary(serial_buffer[..read].to_vec().into()))
                            .await
                            .context("failed to send serial output over websocket")?;
                        let _ = session.heartbeat().await;
                    }
                }
            } else {
                tokio::select! {
                    changed = shutdown_rx.changed() => {
                        if changed.is_ok() && *shutdown_rx.borrow() {
                            let _ = ws_sender
                                .send(Message::Text(r#"{"type":"closed"}"#.to_string().into()))
                                .await;
                            break;
                        }
                    }
                    maybe_message = ws_receiver.next() => {
                        let Some(message) = maybe_message else {
                            break;
                        };
                        match message {
                            Ok(Message::Binary(bytes)) => {
                                write_serial_payload(&mut serial_tx, &bytes).await?;
                            }
                            Ok(Message::Text(text)) => {
                                let control: ClientControlMessage = serde_json::from_str(&text)?;
                                match control.kind.as_str() {
                                    "close" => {
                                        let _ = ws_sender
                                            .send(Message::Text(r#"{"type":"closed"}"#.to_string().into()))
                                            .await;
                                        break;
                                    }
                                    "tx" => {
                                        let Some(data) = control.data.as_deref() else {
                                            anyhow::bail!("missing tx data");
                                        };
                                        let payload = match control.encoding.as_deref() {
                                            Some("base64") => base64::engine::general_purpose::STANDARD
                                                .decode(data)
                                                .context("invalid base64 payload")?,
                                            Some("utf8") | None => data.as_bytes().to_vec(),
                                            Some(other) => anyhow::bail!("unsupported encoding `{other}`"),
                                        };
                                        write_serial_payload(&mut serial_tx, &payload).await?;
                                    }
                                    other => anyhow::bail!("unsupported websocket control type `{other}`"),
                                }
                            }
                            Ok(Message::Close(_)) => break,
                            Ok(Message::Ping(payload)) => {
                                ws_sender.send(Message::Pong(payload)).await.ok();
                            }
                            Ok(Message::Pong(_)) => {}
                            Err(err) => return Err(err.into()),
                        }
                        let _ = session.heartbeat().await;
                    }
                    read = serial_rx.read(&mut serial_buffer) => {
                        let read = read.context("serial read failed")?;
                        if read == 0 {
                            break;
                        }
                        ws_sender
                            .send(Message::Binary(serial_buffer[..read].to_vec().into()))
                            .await
                            .context("failed to send serial output over websocket")?;
                        let _ = session.heartbeat().await;
                    }
                }
            }
        }

        Ok(())
    }
    .await;

    let result =
        finalize_power_linked_session(state, &board, power_linked, power_on_task, result).await;
    let _ = state
        .request_session_stop(&session_id, crate::session::SessionStopReason::SerialClosed)
        .await;
    let _ = ws_sender.send(Message::Close(None)).await;
    result
}

fn spawn_power_action_task(
    state: AppState,
    board: BoardConfig,
    action: PowerAction,
) -> JoinHandle<Result<String, PowerActionError>> {
    tokio::spawn(async move { state.execute_board_power_action(&board, action).await })
}

async fn cleanup_power_link(
    board: &BoardConfig,
    power_linked: bool,
    power_on_task: Option<JoinHandle<Result<String, PowerActionError>>>,
) {
    if !power_linked {
        return;
    }

    if let Some(task) = power_on_task {
        match task.await {
            Ok(Ok(_)) => {}
            Ok(Err(err)) => {
                log::warn!(
                    "session `{}` power-on task ended with error: {err}",
                    board.id
                )
            }
            Err(err) => log::warn!("session `{}` power-on task join failed: {err}", board.id),
        }
    }
}

async fn finalize_power_linked_session<T>(
    _state: &AppState,
    board: &BoardConfig,
    power_linked: bool,
    power_on_task: Option<JoinHandle<Result<String, PowerActionError>>>,
    result: anyhow::Result<T>,
) -> anyhow::Result<T> {
    cleanup_power_link(board, power_linked, power_on_task).await;
    result
}

async fn send_power_on_failure_and_close<S>(ws_sender: &mut S, message: &str)
where
    S: Sink<Message> + Unpin,
{
    let payload = serde_json::json!({
        "type": "error",
        "message": message,
    })
    .to_string();
    let _ = ws_sender.send(Message::Text(payload.into())).await;
    let _ = ws_sender
        .send(Message::Text(r#"{"type":"closed"}"#.to_string().into()))
        .await;
    let _ = ws_sender.send(Message::Close(None)).await;
}

async fn write_serial_payload(
    port: &mut tokio::io::WriteHalf<tokio_serial::SerialStream>,
    payload: &[u8],
) -> anyhow::Result<()> {
    port.write_all(payload).await?;
    port.flush().await?;
    Ok(())
}

#[cfg(test)]
mod tests {
    use std::{
        fs,
        pin::Pin,
        task::{Context, Poll},
        time::Duration,
    };

    use axum::extract::ws::Message;
    use futures_util::Sink;
    use tempfile::tempdir;

    use super::{
        ClientControlMessage, cleanup_power_link, finalize_power_linked_session,
        send_power_on_failure_and_close,
    };
    use crate::{
        build_app_state,
        config::{
            BoardConfig, BootConfig, BuiltinTftpConfig, CustomPowerManagement,
            PowerManagementConfig, PxeProfile, ServerConfig, TftpConfig,
        },
        power::PowerActionError,
        tftp::service::{TftpManager, build_tftp_manager},
    };

    #[derive(Default)]
    struct VecSink {
        messages: Vec<Message>,
    }

    impl Sink<Message> for VecSink {
        type Error = ();

        fn poll_ready(
            self: Pin<&mut Self>,
            _cx: &mut Context<'_>,
        ) -> Poll<Result<(), Self::Error>> {
            Poll::Ready(Ok(()))
        }

        fn start_send(self: Pin<&mut Self>, item: Message) -> Result<(), Self::Error> {
            self.get_mut().messages.push(item);
            Ok(())
        }

        fn poll_flush(
            self: Pin<&mut Self>,
            _cx: &mut Context<'_>,
        ) -> Poll<Result<(), Self::Error>> {
            Poll::Ready(Ok(()))
        }

        fn poll_close(
            self: Pin<&mut Self>,
            _cx: &mut Context<'_>,
        ) -> Poll<Result<(), Self::Error>> {
            Poll::Ready(Ok(()))
        }
    }

    #[test]
    fn control_message_parses_close_type() {
        let message: ClientControlMessage = serde_json::from_str(r#"{"type":"close"}"#).unwrap();
        assert_eq!(message.kind, "close");
    }

    async fn test_state(root: &std::path::Path) -> crate::AppState {
        let config_path = root.join(".ostool-server.toml");
        let config = ServerConfig {
            listen_addr: "127.0.0.1:0".parse().unwrap(),
            data_dir: root.join("data"),
            board_dir: root.join("boards"),
            dtb_dir: root.join("dtbs"),
            tftp: TftpConfig::Builtin(BuiltinTftpConfig::default_with_root(root.join("tftp"))),
            ..ServerConfig::default()
        };
        let manager: std::sync::Arc<dyn TftpManager> = build_tftp_manager(&config.tftp);
        build_app_state(config_path, config, manager).await.unwrap()
    }

    #[tokio::test]
    async fn cleanup_waits_for_power_on_task_before_power_off() {
        let dir = tempdir().unwrap();
        let output_path = dir.path().join("power.log");
        let board = BoardConfig {
            id: "demo".into(),
            board_type: "demo".into(),
            tags: vec![],
            serial: None,
            power_management: PowerManagementConfig::Custom(CustomPowerManagement {
                power_on_cmd: String::new(),
                power_off_cmd: format!("printf 'off\\n' >> {}", output_path.display()),
            }),
            boot: BootConfig::Pxe(PxeProfile::default()),
            notes: None,
            disabled: false,
        };

        let power_on_task = tokio::spawn(async move {
            tokio::time::sleep(Duration::from_millis(20)).await;
            fs::write(&output_path, "on\n").unwrap();
            Ok::<String, PowerActionError>("executed".into())
        });

        cleanup_power_link(&board, true, Some(power_on_task)).await;

        let content = fs::read_to_string(dir.path().join("power.log")).unwrap();
        assert_eq!(content, "on\n");
    }

    #[tokio::test]
    async fn finalize_runs_power_off_even_when_session_errors() {
        let dir = tempdir().unwrap();
        let output_path = dir.path().join("power.log");
        let state = test_state(dir.path()).await;
        let board = BoardConfig {
            id: "demo".into(),
            board_type: "demo".into(),
            tags: vec![],
            serial: None,
            power_management: PowerManagementConfig::Custom(CustomPowerManagement {
                power_on_cmd: String::new(),
                power_off_cmd: format!("printf 'off\\n' >> {}", output_path.display()),
            }),
            boot: BootConfig::Pxe(PxeProfile::default()),
            notes: None,
            disabled: false,
        };

        let power_on_task =
            tokio::spawn(async { Ok::<String, PowerActionError>("executed".into()) });
        let result = finalize_power_linked_session::<()>(
            &state,
            &board,
            true,
            Some(power_on_task),
            Err(anyhow::anyhow!("websocket send failed")),
        )
        .await;

        assert!(result.is_err());
        assert!(!output_path.exists());
    }

    #[tokio::test]
    async fn power_on_failure_sends_error_then_close_messages() {
        let mut sender = VecSink::default();
        send_power_on_failure_and_close(&mut sender, "automatic power-on failed").await;
        let mut messages = sender.messages.into_iter();
        let first = messages.next().unwrap();
        let second = messages.next().unwrap();
        let third = messages.next().unwrap();

        match first {
            Message::Text(text) => assert!(text.contains(r#""type":"error""#)),
            other => panic!("unexpected first message: {other:?}"),
        }
        match second {
            Message::Text(text) => assert_eq!(text, r#"{"type":"closed"}"#),
            other => panic!("unexpected second message: {other:?}"),
        }
        assert!(matches!(third, Message::Close(_)));
    }
}