orchestral-runtime 0.3.1

A runtime for reliable, interactive AI agents.
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
use std::sync::atomic::{AtomicBool, Ordering};
use std::sync::Arc;
use std::time::{Duration, Instant};

use async_trait::async_trait;
use futures_util::{stream, StreamExt};
use orchestral_agent_protocol_testkit::{
    ProviderFixtureFactory, ProviderScenario, ScriptedStatelessFactory, SessionfulRecoverFactory,
    TestProbes,
};
use orchestral_core::agent_protocol::{
    reference::AgentRunStatus,
    spi::{
        AgentJournalStore, AgentProvider, AgentRecovery, AgentRecoveryRequest, AgentStart,
        AgentStartError, InMemoryAgentJournalStore,
    },
    wire::{
        AgentAdmission, AgentCommand, AgentCommandEnvelope, AgentDescriptorEnvelope, AgentEvent,
        AgentEventDraft, AgentEventId, AgentExecutionRef, AgentProtocolError,
        AgentProtocolErrorCode, AgentProviderStreamItem, AgentStartRequest, CommandId, Content,
        PendingRequest, PendingRequestKind, PendingRequestPayload, ProviderBindingRef,
        ProviderCommandDisposition, RequestId,
    },
};
use orchestral_runtime::{AgentClient, AgentController};
use tokio::sync::Notify;

struct RecoveryOrderProvider {
    inner: Arc<dyn AgentProvider>,
    journal: Arc<InMemoryAgentJournalStore>,
    confirmed_after_restore: Arc<AtomicBool>,
    committed_prefix_received: Arc<AtomicBool>,
    fail_after_restore: bool,
}

struct CommandThenDisconnectProvider {
    inner: Arc<dyn AgentProvider>,
    disconnect: Arc<Notify>,
}

struct DescriptorOverrideProvider {
    inner: Arc<dyn AgentProvider>,
    descriptor: AgentDescriptorEnvelope,
}

struct StalledRecoveryProvider {
    inner: Arc<dyn AgentProvider>,
}

struct SettledRequestRecoveryProvider {
    descriptor: AgentDescriptorEnvelope,
}

impl SettledRequestRecoveryProvider {
    fn run_started(run_id: &orchestral_core::agent_protocol::wire::RunId) -> AgentEventDraft {
        AgentEventDraft {
            event_id: AgentEventId::new(format!("settled-{run_id}-started")),
            run_id: run_id.clone(),
            causation_id: None,
            source_fingerprint: None,
            payload: AgentEvent::RunStarted,
        }
    }

    fn request_opened(run_id: &orchestral_core::agent_protocol::wire::RunId) -> AgentEventDraft {
        AgentEventDraft {
            event_id: AgentEventId::new(format!("settled-{run_id}-request-opened")),
            run_id: run_id.clone(),
            causation_id: None,
            source_fingerprint: None,
            payload: AgentEvent::RequestOpened {
                request: PendingRequest {
                    request_id: RequestId::new("settled-request"),
                    blocking: true,
                    payload: PendingRequestPayload::Input {
                        prompt: vec![Content::text("temporary native prompt")],
                        input_schema: None,
                    },
                },
            },
        }
    }

    fn request_closed(run_id: &orchestral_core::agent_protocol::wire::RunId) -> AgentEventDraft {
        AgentEventDraft {
            event_id: AgentEventId::new(format!("settled-{run_id}-request-closed")),
            run_id: run_id.clone(),
            causation_id: None,
            source_fingerprint: None,
            payload: AgentEvent::RequestClosed {
                request_id: RequestId::new("settled-request"),
                reason: "native owner resolved the request".to_owned(),
            },
        }
    }
}

#[async_trait]
impl AgentProvider for SettledRequestRecoveryProvider {
    fn describe(&self) -> AgentDescriptorEnvelope {
        self.descriptor.clone()
    }

    async fn start(&self, request: AgentStartRequest) -> Result<AgentStart, AgentStartError> {
        let execution = AgentExecutionRef::for_start(&request, &self.descriptor)
            .map_err(AgentStartError::OutcomeUnknown)?;
        let run_id = execution.run_id.clone();
        let stream = stream::iter(vec![
            Ok(AgentProviderStreamItem::Event(Box::new(Self::run_started(
                &run_id,
            )))),
            Ok(AgentProviderStreamItem::Event(Box::new(
                Self::request_opened(&run_id),
            ))),
            Ok(AgentProviderStreamItem::Event(Box::new(
                Self::request_closed(&run_id),
            ))),
            Err(AgentProtocolError::new(
                AgentProtocolErrorCode::ProviderUnavailable,
                "fixture transport disconnected",
            )),
        ])
        .boxed();
        Ok(AgentStart {
            execution,
            admission: AgentAdmission::default(),
            stream,
        })
    }

    async fn command(
        &self,
        execution: &AgentExecutionRef,
        command: AgentCommandEnvelope,
    ) -> Result<ProviderCommandDisposition, AgentProtocolError> {
        Ok(ProviderCommandDisposition {
            command_id: command.command_id,
            run_id: execution.run_id.clone(),
            outcome: orchestral_core::agent_protocol::wire::ProviderCommandOutcome::Unsupported {
                feature: "fixture commands".to_owned(),
            },
            duplicate: false,
        })
    }

    async fn recover(
        &self,
        request: AgentRecoveryRequest,
    ) -> Result<AgentRecovery, AgentProtocolError> {
        request.validate_for(&self.descriptor)?;
        let replay = stream::iter(vec![Ok(AgentProviderStreamItem::Event(Box::new(
            Self::run_started(&request.execution.run_id),
        )))])
        .chain(stream::pending())
        .boxed();
        Ok(AgentRecovery::reattached(replay))
    }
}

#[async_trait]
impl AgentProvider for StalledRecoveryProvider {
    fn describe(&self) -> AgentDescriptorEnvelope {
        self.inner.describe()
    }

    async fn start(&self, request: AgentStartRequest) -> Result<AgentStart, AgentStartError> {
        self.inner.start(request).await
    }

    async fn command(
        &self,
        execution: &AgentExecutionRef,
        command: AgentCommandEnvelope,
    ) -> Result<ProviderCommandDisposition, AgentProtocolError> {
        self.inner.command(execution, command).await
    }

    async fn recover(
        &self,
        _request: AgentRecoveryRequest,
    ) -> Result<AgentRecovery, AgentProtocolError> {
        Ok(AgentRecovery::reattached(stream::pending().boxed()))
    }
}

#[async_trait]
impl AgentProvider for DescriptorOverrideProvider {
    fn describe(&self) -> AgentDescriptorEnvelope {
        self.descriptor.clone()
    }

    async fn start(&self, request: AgentStartRequest) -> Result<AgentStart, AgentStartError> {
        self.inner.start(request).await
    }

    async fn command(
        &self,
        execution: &AgentExecutionRef,
        command: AgentCommandEnvelope,
    ) -> Result<ProviderCommandDisposition, AgentProtocolError> {
        self.inner.command(execution, command).await
    }

    async fn recover(
        &self,
        request: AgentRecoveryRequest,
    ) -> Result<AgentRecovery, AgentProtocolError> {
        self.inner.recover(request).await
    }
}

#[async_trait]
impl AgentProvider for CommandThenDisconnectProvider {
    fn describe(&self) -> AgentDescriptorEnvelope {
        self.inner.describe()
    }

    async fn start(&self, request: AgentStartRequest) -> Result<AgentStart, AgentStartError> {
        let started = self.inner.start(request).await?;
        let disconnect = self.disconnect.clone();
        let stream = started
            .stream
            .take(1)
            .chain(stream::once(async move {
                disconnect.notified().await;
                Err(AgentProtocolError::new(
                    AgentProtocolErrorCode::ProviderUnavailable,
                    "fixture stream disconnected after command",
                ))
            }))
            .boxed();
        Ok(AgentStart {
            execution: started.execution,
            admission: started.admission,
            stream,
        })
    }

    async fn command(
        &self,
        execution: &AgentExecutionRef,
        command: AgentCommandEnvelope,
    ) -> Result<ProviderCommandDisposition, AgentProtocolError> {
        self.inner.command(execution, command).await
    }

    async fn recover(
        &self,
        request: AgentRecoveryRequest,
    ) -> Result<AgentRecovery, AgentProtocolError> {
        self.inner.recover(request).await
    }
}

#[async_trait]
impl AgentProvider for RecoveryOrderProvider {
    fn describe(&self) -> AgentDescriptorEnvelope {
        self.inner.describe()
    }

    async fn start(&self, request: AgentStartRequest) -> Result<AgentStart, AgentStartError> {
        self.inner.start(request).await
    }

    async fn command(
        &self,
        execution: &AgentExecutionRef,
        command: AgentCommandEnvelope,
    ) -> Result<ProviderCommandDisposition, AgentProtocolError> {
        self.inner.command(execution, command).await
    }

    async fn recover(
        &self,
        request: AgentRecoveryRequest,
    ) -> Result<AgentRecovery, AgentProtocolError> {
        let run_id = request.execution.run_id.clone();
        self.committed_prefix_received.store(
            request.committed_provider_prefix.iter().any(|draft| {
                draft.run_id == run_id && matches!(draft.payload, AgentEvent::RunStarted)
            }),
            Ordering::SeqCst,
        );
        let recovered = self.inner.recover(request).await?;
        let (stream, inner_confirmation) = recovered.into_parts();
        let journal = self.journal.clone();
        let confirmed_after_restore = self.confirmed_after_restore.clone();
        let fail_after_restore = self.fail_after_restore;
        Ok(AgentRecovery::staged(stream, async move {
            let stored = journal.load_run(&run_id).await.map_err(|error| {
                AgentProtocolError::new(
                    AgentProtocolErrorCode::ProviderUnavailable,
                    format!("could not inspect Host recovery journal: {error}"),
                )
            })?;
            let restored_is_durable = stored.is_some_and(|run| {
                run.records.iter().any(|record| {
                    matches!(&record.event.payload, AgentEvent::ContinuityRestored { .. })
                })
            });
            if !restored_is_durable {
                return Err(AgentProtocolError::new(
                    AgentProtocolErrorCode::InvalidTransition,
                    "Provider recovery was confirmed before ContinuityRestored was durable",
                ));
            }
            inner_confirmation.await?;
            confirmed_after_restore.store(true, Ordering::SeqCst);
            if fail_after_restore {
                return Err(AgentProtocolError::new(
                    AgentProtocolErrorCode::ProviderUnavailable,
                    "reconstructed Provider work could not be resumed",
                ));
            }
            Ok(())
        }))
    }
}

#[tokio::test]
async fn controller_drives_provider_stream_into_one_inspectable_terminal_run() {
    let factory = ScriptedStatelessFactory::conformant().expect("fixture descriptor");
    let scenario = ProviderScenario::standard(&factory.descriptor()).expect("fixture scenario");
    let provider = factory.create(scenario.clone(), TestProbes::default());
    let controller = Arc::new(
        AgentController::new(provider, ProviderBindingRef::new("conformance-binding"))
            .expect("controller binds provider"),
    );

    let execution = controller
        .start(scenario.start_request.run.clone())
        .await
        .expect("run starts");
    let terminal = controller
        .wait_for_terminal(&execution.run_id)
        .await
        .expect("provider reaches terminal");
    let journal = controller
        .events(&execution.run_id, 0)
        .await
        .expect("journal replays");

    assert_eq!(terminal.state.status(), AgentRunStatus::Delivered);
    assert_eq!(terminal.last_run_seq, Some(3));
    assert_eq!(
        journal
            .iter()
            .map(|record| record.event.run_seq)
            .collect::<Vec<_>>(),
        vec![1, 2, 3]
    );
    assert_eq!(
        controller
            .inspect(&execution.run_id)
            .await
            .expect("run remains inspectable"),
        terminal
    );
}

#[tokio::test]
async fn one_thousand_fake_provider_runs_keep_control_plane_p95_below_100ms() {
    const RUNS: usize = 1_000;
    let mut latencies = Vec::with_capacity(RUNS);

    for _ in 0..RUNS {
        let factory = ScriptedStatelessFactory::conformant().expect("fixture descriptor");
        let scenario = ProviderScenario::standard(&factory.descriptor()).expect("fixture scenario");
        let provider = factory.create(scenario.clone(), TestProbes::default());
        let controller = Arc::new(
            AgentController::new(
                provider,
                ProviderBindingRef::new("latency-conformance-binding"),
            )
            .expect("controller binds the fake Provider"),
        );

        let started = Instant::now();
        let execution = controller
            .start(scenario.start_request.run)
            .await
            .expect("fake Run starts");
        let terminal = controller
            .wait_for_terminal(&execution.run_id)
            .await
            .expect("fake Run reaches terminal");
        latencies.push(started.elapsed());
        assert_eq!(terminal.state.status(), AgentRunStatus::Delivered);
    }

    latencies.sort_unstable();
    let p95 = latencies[(RUNS * 95).div_ceil(100) - 1];
    assert!(
        p95 <= Duration::from_millis(100),
        "Agent Protocol control-plane p95 was {p95:?}"
    );
}

#[tokio::test]
async fn a_new_controller_rehydrates_inspect_and_events_from_the_agent_journal() {
    let factory = ScriptedStatelessFactory::conformant().expect("fixture descriptor");
    let scenario = ProviderScenario::standard(&factory.descriptor()).expect("fixture scenario");
    let journal = Arc::new(InMemoryAgentJournalStore::default());
    let first = Arc::new(
        AgentController::with_journal_store(
            factory.create(scenario.clone(), TestProbes::default()),
            ProviderBindingRef::new("durable-binding"),
            journal.clone(),
        )
        .expect("first controller binds provider"),
    );
    let execution = first
        .start(scenario.start_request.run.clone())
        .await
        .expect("run starts");
    let before_restart = first
        .wait_for_terminal(&execution.run_id)
        .await
        .expect("run reaches terminal before restart");
    drop(first);

    let restarted = AgentController::with_journal_store(
        factory.create(scenario, TestProbes::default()),
        ProviderBindingRef::new("durable-binding"),
        journal,
    )
    .expect("restarted controller binds the same Provider contract");
    let after_restart = restarted
        .inspect(&execution.run_id)
        .await
        .expect("inspect lazily rehydrates without restarting native work");
    let records = restarted
        .events(&execution.run_id, 1)
        .await
        .expect("durable pagination remains available");

    assert_eq!(after_restart, before_restart);
    assert_eq!(
        records
            .iter()
            .map(|record| record.event.run_seq)
            .collect::<Vec<_>>(),
        vec![2, 3]
    );
}

#[tokio::test]
async fn a_descriptor_upgrade_identifies_an_old_run_without_rehydrating_it() {
    let factory = ScriptedStatelessFactory::conformant().expect("fixture descriptor");
    let scenario = ProviderScenario::standard(&factory.descriptor()).expect("fixture scenario");
    let journal = Arc::new(InMemoryAgentJournalStore::default());
    let first = Arc::new(
        AgentController::with_journal_store(
            factory.create(scenario.clone(), TestProbes::default()),
            ProviderBindingRef::new("durable-binding"),
            journal.clone(),
        )
        .expect("first controller binds provider"),
    );
    let execution = first
        .start(scenario.start_request.run.clone())
        .await
        .expect("run starts");
    first
        .wait_for_terminal(&execution.run_id)
        .await
        .expect("run reaches terminal before upgrade");
    drop(first);

    let mut upgraded_descriptor = factory.descriptor().descriptor;
    upgraded_descriptor
        .accepted_content_types
        .insert("image/png".to_owned());
    let upgraded_descriptor = AgentDescriptorEnvelope::seal(upgraded_descriptor)
        .expect("upgraded descriptor remains valid");
    let upgraded_provider = Arc::new(DescriptorOverrideProvider {
        inner: factory.create(scenario, TestProbes::default()),
        descriptor: upgraded_descriptor,
    });
    let upgraded = AgentController::with_journal_store(
        upgraded_provider,
        ProviderBindingRef::new("durable-binding"),
        journal,
    )
    .expect("upgraded controller binds provider");

    assert!(!upgraded
        .can_control_run(&execution.run_id)
        .await
        .expect("old registration remains discoverable"));
    assert!(matches!(
        upgraded.inspect(&execution.run_id).await,
        Err(orchestral_runtime::AgentControlError::Protocol(error))
            if error.code == AgentProtocolErrorCode::RunIdConflict
    ));
}

#[tokio::test]
async fn recovery_continuation_opens_only_after_continuity_restore_is_durable() {
    let factory = SessionfulRecoverFactory::new().expect("fixture descriptor");
    let mut scenario = ProviderScenario::standard(&factory.descriptor()).expect("fixture scenario");
    scenario.immediate_events.truncate(1);
    let journal = Arc::new(InMemoryAgentJournalStore::default());
    let confirmed_after_restore = Arc::new(AtomicBool::new(false));
    let committed_prefix_received = Arc::new(AtomicBool::new(false));
    let provider = Arc::new(RecoveryOrderProvider {
        inner: factory.create(scenario.clone(), TestProbes::default()),
        journal: journal.clone(),
        confirmed_after_restore: confirmed_after_restore.clone(),
        committed_prefix_received: committed_prefix_received.clone(),
        fail_after_restore: false,
    });
    let controller = Arc::new(
        AgentController::with_journal_store(
            provider,
            ProviderBindingRef::new("conformance-binding"),
            journal.clone(),
        )
        .expect("controller binds provider"),
    );

    let execution = controller
        .start(scenario.start_request.run)
        .await
        .expect("non-terminal run starts");
    let first_loss = controller
        .wait_for_terminal(&execution.run_id)
        .await
        .expect_err("finite non-terminal stream becomes Unknown");
    assert!(matches!(
        first_loss,
        orchestral_runtime::AgentControlError::ContinuityUnknown(_)
    ));

    controller
        .recover(&execution.run_id)
        .await
        .expect("matching Provider prefix restores continuity");

    assert!(confirmed_after_restore.load(Ordering::SeqCst));
    assert!(committed_prefix_received.load(Ordering::SeqCst));
    let stored = journal
        .load_run(&execution.run_id)
        .await
        .expect("journal remains readable")
        .expect("run remains registered");
    assert!(stored
        .records
        .iter()
        .any(|record| { matches!(&record.event.payload, AgentEvent::ContinuityRestored { .. }) }));
}

#[tokio::test]
async fn recovery_rejects_a_provider_that_never_replays_its_committed_prefix() {
    let factory = SessionfulRecoverFactory::new().expect("fixture descriptor");
    let mut scenario = ProviderScenario::standard(&factory.descriptor()).expect("fixture scenario");
    scenario.immediate_events.truncate(1);
    let provider = Arc::new(StalledRecoveryProvider {
        inner: factory.create(scenario.clone(), TestProbes::default()),
    });
    let controller = Arc::new(
        AgentController::new(provider, ProviderBindingRef::new("conformance-binding"))
            .expect("controller binds provider"),
    );

    let execution = controller
        .start(scenario.start_request.run)
        .await
        .expect("non-terminal run starts");
    controller
        .wait_for_terminal(&execution.run_id)
        .await
        .expect_err("finite non-terminal stream becomes Unknown");

    let started = Instant::now();
    let error = controller
        .recover(&execution.run_id)
        .await
        .expect_err("a missing recovery prefix is rejected");
    assert!(matches!(
        error,
        orchestral_runtime::AgentControlError::RecoveryMismatch(ref run_id)
            if run_id == &execution.run_id
    ));
    assert!(started.elapsed() < Duration::from_secs(3));
}

#[tokio::test]
async fn recovery_accepts_a_request_lifecycle_that_settled_before_disconnect() {
    let factory = SessionfulRecoverFactory::new().expect("fixture descriptor");
    let mut descriptor = factory.descriptor().descriptor;
    descriptor
        .capabilities
        .pending_request_kinds
        .insert(PendingRequestKind::Input);
    let descriptor = AgentDescriptorEnvelope::seal(descriptor).expect("fixture descriptor seals");
    let scenario = ProviderScenario::standard(&descriptor).expect("fixture scenario");
    let provider = Arc::new(SettledRequestRecoveryProvider {
        descriptor: descriptor.clone(),
    });
    let controller = Arc::new(
        AgentController::new(provider, ProviderBindingRef::new("conformance-binding"))
            .expect("controller binds provider"),
    );

    let execution = controller
        .start(scenario.start_request.run)
        .await
        .expect("run starts");
    assert!(matches!(
        controller.wait_for_terminal(&execution.run_id).await,
        Err(orchestral_runtime::AgentControlError::ContinuityUnknown(_))
    ));

    let recovered = controller
        .recover(&execution.run_id)
        .await
        .expect("settled request history is Host-proven and need not be replayed");
    assert_eq!(recovered.state.status(), AgentRunStatus::Running);
    let records = controller.events(&execution.run_id, 0).await.unwrap();
    assert!(records
        .iter()
        .any(|record| { matches!(record.event.payload, AgentEvent::ContinuityRestored { .. }) }));
}

#[tokio::test]
async fn recovery_uses_host_committed_command_dispositions_without_stream_replay() {
    let factory = SessionfulRecoverFactory::new().expect("fixture descriptor");
    let mut scenario = ProviderScenario::standard(&factory.descriptor()).expect("fixture scenario");
    scenario.immediate_events.truncate(1);
    let disconnect = Arc::new(Notify::new());
    let provider = Arc::new(CommandThenDisconnectProvider {
        inner: factory.create(scenario.clone(), TestProbes::default()),
        disconnect: disconnect.clone(),
    });
    let controller = Arc::new(
        AgentController::new(
            provider,
            ProviderBindingRef::new("command-recovery-binding"),
        )
        .expect("controller binds provider"),
    );

    let execution = controller
        .start(scenario.start_request.run)
        .await
        .expect("non-terminal run starts");
    let command = AgentCommandEnvelope::new(
        CommandId::new("command-before-restart"),
        execution.run_id.clone(),
        None,
        AgentCommand::Steer {
            content: vec![Content::text("continue")],
        },
    )
    .expect("command is valid");
    controller
        .command(command)
        .await
        .expect("command disposition is Host-committed");
    disconnect.notify_one();
    controller
        .wait_for_terminal(&execution.run_id)
        .await
        .expect_err("fixture disconnect makes continuity unknown");

    controller
        .recover(&execution.run_id)
        .await
        .expect("native replay plus Host command evidence restores continuity");
    let events = controller
        .events(&execution.run_id, 0)
        .await
        .expect("journal remains readable");
    assert!(events.iter().any(|record| matches!(
        record.event.payload,
        AgentEvent::CommandDispositionRecorded { .. }
    )));
    assert!(events
        .iter()
        .any(|record| matches!(record.event.payload, AgentEvent::ContinuityRestored { .. })));
}

#[tokio::test]
async fn failed_recovery_confirmation_returns_the_run_to_unknown() {
    let factory = SessionfulRecoverFactory::new().expect("fixture descriptor");
    let mut scenario = ProviderScenario::standard(&factory.descriptor()).expect("fixture scenario");
    scenario.immediate_events.truncate(1);
    let journal = Arc::new(InMemoryAgentJournalStore::default());
    let provider = Arc::new(RecoveryOrderProvider {
        inner: factory.create(scenario.clone(), TestProbes::default()),
        journal: journal.clone(),
        confirmed_after_restore: Arc::new(AtomicBool::new(false)),
        committed_prefix_received: Arc::new(AtomicBool::new(false)),
        fail_after_restore: true,
    });
    let controller = Arc::new(
        AgentController::with_journal_store(
            provider,
            ProviderBindingRef::new("conformance-binding"),
            journal,
        )
        .expect("controller binds provider"),
    );

    let execution = controller
        .start(scenario.start_request.run)
        .await
        .expect("non-terminal run starts");
    controller
        .wait_for_terminal(&execution.run_id)
        .await
        .expect_err("finite non-terminal stream becomes Unknown");

    let error = controller
        .recover(&execution.run_id)
        .await
        .expect_err("failed Provider continuation rejects recovery");
    assert!(matches!(
        error,
        orchestral_runtime::AgentControlError::Protocol(ref error)
            if error.code == AgentProtocolErrorCode::ProviderUnavailable
    ));
    let view = controller
        .inspect(&execution.run_id)
        .await
        .expect("Run remains inspectable after failed continuation");
    assert_eq!(view.state.status(), AgentRunStatus::Unknown);
}

#[tokio::test]
async fn sdk_returns_unknown_as_a_recoverable_turn_boundary() {
    let factory = SessionfulRecoverFactory::new().expect("fixture descriptor");
    let mut scenario = ProviderScenario::standard(&factory.descriptor()).expect("fixture scenario");
    scenario.immediate_events.truncate(1);
    let controller = Arc::new(
        AgentController::new(
            factory.create(scenario, TestProbes::default()),
            ProviderBindingRef::new("conformance-binding"),
        )
        .expect("controller binds provider"),
    );
    let client = AgentClient::new(
        controller,
        orchestral_core::agent_protocol::wire::AgentSessionId::new("conformance-session"),
    );
    let handle = client
        .start_with_run_id(
            orchestral_core::agent_protocol::wire::RunId::new("conformance-run"),
            vec![orchestral_core::agent_protocol::wire::Content::text(
                "complete the deterministic fixture",
            )],
        )
        .await
        .expect("non-terminal fixture starts");

    let turn = tokio::time::timeout(Duration::from_secs(1), handle.wait_until_blocked())
        .await
        .expect("SDK does not hang after Provider continuity is lost")
        .expect("Unknown is returned as an inspectable boundary");

    assert_eq!(turn.status(), AgentRunStatus::Unknown);
    assert!(!turn.is_waiting());
}

#[tokio::test]
async fn command_retries_bind_the_complete_envelope_and_survive_controller_restart() {
    let factory = SessionfulRecoverFactory::new().unwrap();
    let mut scenario = ProviderScenario::standard(&factory.descriptor()).unwrap();
    scenario.immediate_events.truncate(1);
    let provider = Arc::new(CommandThenDisconnectProvider {
        inner: factory.create(scenario.clone(), TestProbes::default()),
        disconnect: Arc::new(Notify::new()),
    });
    let journal = Arc::new(InMemoryAgentJournalStore::default());
    let binding = ProviderBindingRef::new("command-identity-test");
    let controller = Arc::new(
        AgentController::with_journal_store(provider.clone(), binding.clone(), journal.clone())
            .unwrap(),
    );
    let execution = controller.start(scenario.start_request.run).await.unwrap();
    let command = AgentCommandEnvelope::new(
        CommandId::new("immutable-command"),
        execution.run_id.clone(),
        None,
        AgentCommand::Steer {
            content: vec![Content::text("first content")],
        },
    )
    .unwrap();
    controller.command(command.clone()).await.unwrap();
    assert!(controller.command(command.clone()).await.unwrap().duplicate);
    let changed = AgentCommandEnvelope::new(
        command.command_id.clone(),
        execution.run_id.clone(),
        None,
        AgentCommand::Steer {
            content: vec![Content::text("changed content")],
        },
    )
    .unwrap();
    let error = controller
        .command(changed)
        .await
        .expect_err("changed input must not reuse an acknowledgement");
    assert!(matches!(
        error,
        orchestral_runtime::AgentControlError::Protocol(AgentProtocolError {
            code: AgentProtocolErrorCode::DuplicateConflict,
            ..
        })
    ));
    let replacement = AgentController::with_journal_store(provider, binding, journal).unwrap();
    assert_eq!(
        replacement
            .recorded_command(&execution.run_id, &command.command_id)
            .await
            .unwrap(),
        Some(command)
    );
}