ora-worker 0.4.2

Part of the Ora scheduler framework.
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
//! Worker implementation.

use std::{
    collections::HashMap, iter::once, mem, num::NonZeroUsize, pin::pin, sync::Arc, time::Duration,
};

use futures::{stream::FuturesUnordered, StreamExt, TryStreamExt};
use ora_common::task::WorkerSelector;
use parking_lot::Mutex;
use thiserror::Error;
use tokio::{
    sync::{mpsc, oneshot, Semaphore},
    task::JoinHandle,
};
use tokio_util::sync::CancellationToken;
use tracing::Instrument;
use uuid::Uuid;

use crate::{
    registry::{noop::NoopWorkerRegistry, HeartbeatData, WorkerMetadata, WorkerRegistry},
    store::{ReadyTask, WorkerStore, WorkerStoreEvent},
    RawHandler, TaskContext,
};

/// Options for a [`Worker`].
#[derive(Debug, Clone)]
pub struct WorkerOptions {
    /// The amount of concurrent tasks that can be spawned.
    pub concurrent_tasks: NonZeroUsize,
    /// The timeout after which a task is forcibly cancelled
    /// after receiving a cancellation request.
    pub cancellation_timeout: Duration,
}

impl Default for WorkerOptions {
    fn default() -> Self {
        // Rather conservative by default.
        Self {
            concurrent_tasks: NonZeroUsize::new(4).unwrap(),
            cancellation_timeout: Duration::from_secs(30),
        }
    }
}

/// A worker where workers can be registered
/// and are executed whenever tasks are ready.
pub struct Worker<S, R = NoopWorkerRegistry> {
    store: S,
    registry: R,
    metadata: WorkerMetadata,
    id: Uuid,
    handlers: HashMap<WorkerSelector, Arc<dyn RawHandler + Send + Sync>>,
    semaphore: Arc<Semaphore>,
    running_tasks: Arc<Mutex<HashMap<Uuid, RunningTask>>>,
    options: WorkerOptions,
    shutdown_send: mpsc::Sender<oneshot::Sender<()>>,
    shutdown_recv: mpsc::Receiver<oneshot::Sender<()>>,
}

impl<S: std::fmt::Debug> std::fmt::Debug for Worker<S> {
    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
        f.debug_struct("Worker")
            .field("store", &self.store)
            .field("handlers", &self.handlers.keys().collect::<Vec<_>>())
            .field("semaphore", &self.semaphore)
            .field("options", &self.options)
            .finish_non_exhaustive()
    }
}

impl<S> Worker<S>
where
    S: WorkerStore + 'static,
{
    /// Create a new worker with the default options.
    pub fn new(store: S) -> Self {
        Self::new_with_options(store, WorkerOptions::default())
    }

    /// Create a new worker.
    pub fn new_with_options(store: S, options: WorkerOptions) -> Self {
        let (send, recv) = mpsc::channel(1);
        Self {
            store,
            registry: NoopWorkerRegistry,
            metadata: WorkerMetadata::default(),
            id: Uuid::new_v4(),
            handlers: HashMap::new(),
            semaphore: Arc::new(Semaphore::new(options.concurrent_tasks.get())),
            running_tasks: Arc::default(),
            options,
            shutdown_send: send,
            shutdown_recv: recv,
        }
    }
}

impl<S, R> Worker<S, R> {
    /// Register a handler for the worker.
    ///
    /// # Panics
    ///
    /// Panics if a handler was already registered with a matching [`WorkerSelector`].
    pub fn register_handler(&mut self, worker: Arc<dyn RawHandler + Send + Sync>) -> &mut Self {
        let selector = worker.selector();

        assert!(
            !self.handlers.contains_key(worker.selector()),
            "a worker is already registered with the given selector: {selector:?}"
        );

        if let Some(task) = worker.supported_task() {
            self.metadata.supported_tasks.push(task);
        }

        self.handlers.insert(worker.selector().clone(), worker);
        self
    }

    /// Set the registry for this worker.
    pub fn with_registry<R2>(self, registry: R2) -> Worker<S, R2> {
        Worker {
            store: self.store,
            registry,
            metadata: self.metadata,
            id: self.id,
            handlers: self.handlers,
            semaphore: self.semaphore,
            running_tasks: self.running_tasks,
            options: self.options,
            shutdown_send: self.shutdown_send,
            shutdown_recv: self.shutdown_recv,
        }
    }

    /// Set the name of this worker.
    #[must_use]
    pub fn with_name(mut self, name: impl Into<String>) -> Self {
        self.metadata.name = Some(name.into());
        self
    }

    /// Set the description of this worker.
    #[must_use]
    pub fn with_description(mut self, description: impl Into<String>) -> Self {
        self.metadata.description = Some(description.into());
        self
    }

    /// Set the version of this worker.
    #[must_use]
    pub fn with_version(mut self, version: impl Into<String>) -> Self {
        self.metadata.version = Some(version.into());
        self
    }

    /// Get a handle to this worker.
    pub fn handle(&self) -> WorkerHandle {
        WorkerHandle {
            chan: self.shutdown_send.clone(),
        }
    }

    /// Get the worker selectors for the handlers
    /// registered with this worker.
    pub fn handlers(&self) -> impl Iterator<Item = &WorkerSelector> {
        self.handlers.keys()
    }

    /// Return the count of handlers registered.
    #[must_use]
    pub fn handler_count(&self) -> usize {
        self.handlers.len()
    }

    /// Get the metadata for this worker.
    #[must_use]
    pub fn metadata(&self) -> &WorkerMetadata {
        &self.metadata
    }
}

impl<S, R> Worker<S, R>
where
    S: WorkerStore + 'static,
    R: WorkerRegistry,
{
    /// Run the worker indefinitely.
    ///
    /// # Errors
    ///
    /// The function returns on any store error.
    ///
    /// # Panics
    ///
    /// Only panics due to bugs.
    #[tracing::instrument(skip_all)]
    #[allow(clippy::too_many_lines)]
    pub async fn run(mut self) -> Result<(), Error> {
        /// The timeout for registry operations,
        /// these are optional and should not block
        /// the worker for long periods.
        const REGISTRY_TIMEOUT: Duration = Duration::from_secs(5);

        macro_rules! wait_shutdown_all {
            ($confirm:expr) => {
                let running_tasks = mem::take(&mut *self.running_tasks.lock());

                let mut tasks: FuturesUnordered<_> = running_tasks
                    .into_iter()
                    .map(|(task_id, task)| {
                        let task = task;
                        let store = self.store.clone();
                        async move {
                            tracing::warn!(%task_id, "cancelling task due to shutdown");
                            if let Err(error) =
                                store.task_cancelled(task_id).await.map_err(store_error)
                            {
                                tracing::error!(?error, "failed to cancel task");
                            }

                            task.context.cancellation.cancel();
                            let _ = task.handle.await;
                        }
                    })
                    .collect();

                while tasks.next().await.is_some() {}

                let _ = ($confirm).send(());
                return Ok(());
            };
        }

        let selectors = self.handlers.keys().cloned().collect::<Vec<_>>();

        let (rt_errors_send, mut rt_errors_recv) = mpsc::channel::<Error>(1);

        if let Ok(shutdown_confirm) = self.shutdown_recv.try_recv() {
            let _ = shutdown_confirm.send(());
            return Ok(());
        }

        let mut events = pin!(self.store.events(&selectors).await.map_err(store_error)?);

        if let Ok(shutdown_confirm) = self.shutdown_recv.try_recv() {
            let _ = shutdown_confirm.send(());
            return Ok(());
        }

        self.spawn_tasks(
            self.store
                .ready_tasks(&selectors)
                .await
                .map_err(store_error)?
                .into_iter(),
            rt_errors_send.clone(),
        )
        .await?;

        if let Ok(shutdown_confirm) = self.shutdown_recv.try_recv() {
            wait_shutdown_all!(shutdown_confirm);
        }

        let mut heartbeat_interval =
            tokio::time::interval(self.registry.heartbeat_interval().try_into().unwrap());
        heartbeat_interval.set_missed_tick_behavior(tokio::time::MissedTickBehavior::Skip);

        let res = loop {
            tokio::select! {
                error = rt_errors_recv.recv() => {
                    break Err(error.unwrap());
                }
                Some(shutdown_confirm) = self.shutdown_recv.recv() => {
                    wait_shutdown_all!(shutdown_confirm);
                }
                event = events.try_next() => {
                    let event = event.map_err(store_error)?.ok_or(Error::UnexpectedEventStreamEnd)?;
                    match event {
                        WorkerStoreEvent::TaskReady(task) => {
                            self.spawn_tasks(once(task), rt_errors_send.clone()).await?;
                        },
                        WorkerStoreEvent::TaskCancelled(task_id) => {
                            if let Some(task) = self.running_tasks.lock().remove(&task_id) {
                                task.context.cancellation.cancel();
                            }
                        }
                    }
                }
                _ = heartbeat_interval.tick() => {
                    let heartbeat_fut = tokio::time::timeout(
                        REGISTRY_TIMEOUT,
                        async {
                            let res = self.registry.heartbeat(self.id, &HeartbeatData {}).await?;

                            if res.should_register {
                                self.registry.register_worker(self.id, &self.metadata).await?;
                            }

                            Result::<(), R::Error>::Ok(())
                        },
                    );

                    if self.registry.enabled() {
                        match heartbeat_fut.await {
                            Ok(Ok(())) => {}
                            Ok(Err(error)) => {
                                let err = Error::Registry(Box::new(error));
                                tracing::warn!(?err, "heartbeat failed");
                            }
                            Err(_) => {
                                tracing::warn!("timed out while sending registry heartbeat");
                            }
                        }
                    }
                }
            }
        };

        if self.registry.enabled() {
            match tokio::time::timeout(REGISTRY_TIMEOUT, self.registry.unregister_worker(self.id))
                .await
            {
                Ok(Ok(())) => {}
                Ok(Err(error)) => {
                    let err = Error::Registry(Box::new(error));
                    tracing::warn!(?err, "unregister failed");
                }
                Err(_) => {
                    tracing::warn!("timed out while sending unregister");
                }
            }
        }

        res
    }

    #[tracing::instrument(skip_all)]
    async fn spawn_tasks(
        &mut self,
        tasks: impl Iterator<Item = ReadyTask>,
        rt_errors: mpsc::Sender<Error>,
    ) -> Result<(), Error> {
        for task in tasks {
            let worker = self
                .handlers
                .get(&task.definition.worker_selector)
                .ok_or(Error::HandlerNotFound)?
                .clone();

            let permit = self.semaphore.clone().acquire_owned().await.unwrap();

            let should_run = self
                .store
                .select_task(task.id, self.id)
                .await
                .map_err(store_error)?;

            if !should_run {
                tracing::debug!(task_id = %task.id, "dropping task");
                continue;
            }

            let context = TaskContext {
                task_id: task.id,
                cancellation: CancellationToken::new(),
            };

            let cancellation_timeout = self.options.cancellation_timeout;
            let store = self.store.clone();
            let running_tasks = self.running_tasks.clone();

            let task_span = tracing::info_span!(
                "run_task",
                task_id = %task.id,
                kind = &*task.definition.worker_selector.kind,
            );

            let ctx = context.clone();
            let rt_errors = rt_errors.clone();

            let task_handle = tokio::spawn(async move {
                let _permit = permit;

                let cancellation = ctx.cancellation.clone();
                let mut worker_fut = worker.run(ctx, task.definition);

                if let Err(error) = store.task_started(task.id).await {
                    let _ = rt_errors.send(store_error(error)).await;
                    return;
                }

                tokio::select! {
                    _ = cancellation.cancelled() => {
                        tokio::select! {
                            _ = tokio::time::sleep(cancellation_timeout) => {}
                            res = &mut worker_fut => {
                                match res {
                                    Ok(output) => {
                                        if let Err(error) = store.task_succeeded(task.id, output, worker.output_format()).await {
                                            let _ = rt_errors.send(store_error(error)).await;
                                        }
                                    },
                                    Err(error) => {
                                        if let Err(error) = store.task_failed(task.id, format!("{error:?}")).await {
                                            let _ = rt_errors.send(store_error(error)).await;
                                        }
                                    }
                                }
                            }
                        }
                    }
                    res = &mut worker_fut => {
                        match res {
                            Ok(output) => {
                                if let Err(error) = store.task_succeeded(task.id, output, worker.output_format()).await {
                                    let _ = rt_errors.send(store_error(error)).await;
                                }
                            },
                            Err(error) => {
                                if let Err(error) = store.task_failed(task.id, format!("{error:?}")).await {
                                    let _ = rt_errors.send(store_error(error)).await;
                                }
                            }
                        }
                    }
                }

                running_tasks.lock().remove(&task.id);
            }.instrument(task_span));

            self.running_tasks.lock().insert(
                task.id,
                RunningTask {
                    context,
                    handle: task_handle,
                },
            );
        }
        Ok(())
    }
}

/// A handle to a worker that can be used for graceful shutdowns.
#[derive(Debug, Clone)]
#[must_use]
pub struct WorkerHandle {
    chan: mpsc::Sender<oneshot::Sender<()>>,
}

impl WorkerHandle {
    /// Shutdown the worker by cancelling all tasks and waiting for them
    /// to finish.
    ///
    /// If the worker does not exist anymore, this is effectively a no-op.
    /// If the worker is not yet started, this will wait for the worker to start
    /// and will shut it down immediately.
    pub async fn shutdown(&self) {
        let (send, recv) = oneshot::channel();
        let _ = self.chan.send(send).await;
        let _ = recv.await;
    }
}

/// A worker error.
#[derive(Debug, Error)]
pub enum Error {
    /// A specific handler was not found, but the
    /// still received the task. This
    /// is either a bug in the worker selector
    /// or the store.
    #[error("received task but no matching handler was found")]
    HandlerNotFound,
    /// The store event stream ended unexpectedly.
    #[error("unexpected end of event stream")]
    UnexpectedEventStreamEnd,
    /// A store error.
    #[error("store error: {0:?}")]
    Store(Box<dyn std::error::Error + Send + Sync>),
    /// A registry error.
    #[error("registry error: {0:?}")]
    Registry(Box<dyn std::error::Error + Send + Sync>),
}

struct RunningTask {
    context: TaskContext,
    handle: JoinHandle<()>,
}

fn store_error<E: std::error::Error + Send + Sync + 'static>(error: E) -> Error {
    Error::Store(Box::new(error))
}