openvm-cuda-common 2.0.0

CUDA common utils
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
#![allow(non_camel_case_types, non_upper_case_globals, non_snake_case)]

use std::{
    collections::{BTreeMap, HashMap},
    ffi::c_void,
    sync::Arc,
};

use bytesize::ByteSize;

use super::cuda::*;
use crate::{
    common::set_device,
    error::MemoryError,
    stream::{device_synchronize, CudaEvent, CudaStream, StreamGuard},
};

#[link(name = "cudart")]
extern "C" {
    fn cudaMemGetInfo(free_bytes: *mut usize, total_bytes: *mut usize) -> i32;
}

// ============================================================================
// Configuration
// ============================================================================

const DEFAULT_VA_SIZE: usize = 8 << 40; // 8 TB

/// Configuration for the Virtual Memory Pool.
///
/// Use `VpmmConfig::from_env()` to load from environment variables,
/// or construct directly for testing.
#[derive(Debug, Clone)]
pub(super) struct VpmmConfig {
    /// Page size override. If `None`, uses CUDA's minimum granularity for the device.
    pub page_size: Option<usize>,
    /// Virtual address space size per reserved chunk (default: 8 TB).
    pub va_size: usize,
    /// Number of pages to preallocate at startup (default: 0).
    pub initial_pages: usize,
}

impl Default for VpmmConfig {
    fn default() -> Self {
        Self {
            page_size: None,
            va_size: DEFAULT_VA_SIZE,
            initial_pages: 0,
        }
    }
}

impl VpmmConfig {
    /// Load configuration from environment variables:
    /// - `VPMM_PAGE_SIZE`: Page size in bytes (must be multiple of CUDA granularity)
    /// - `VPMM_VA_SIZE`: Virtual address space size per chunk (default: 8 TB)
    /// - `VPMM_PAGES`: Number of pages to preallocate (default: 0)
    pub fn from_env() -> Self {
        let page_size = std::env::var("VPMM_PAGE_SIZE").ok().map(|val| {
            let size: usize = val.parse().expect("VPMM_PAGE_SIZE must be a valid number");
            assert!(size > 0, "VPMM_PAGE_SIZE must be > 0");
            size
        });

        let va_size = match std::env::var("VPMM_VA_SIZE") {
            Ok(val) => {
                let size: usize = val.parse().expect("VPMM_VA_SIZE must be a valid number");
                assert!(size > 0, "VPMM_VA_SIZE must be > 0");
                size
            }
            Err(_) => DEFAULT_VA_SIZE,
        };

        let initial_pages = match std::env::var("VPMM_PAGES") {
            Ok(val) => val.parse().expect("VPMM_PAGES must be a valid number"),
            Err(_) => 0,
        };

        Self {
            page_size,
            va_size,
            initial_pages,
        }
    }
}

// ============================================================================
// VPMM allocation records
// ============================================================================

/// Allocation record for the VPMM path.
pub(super) struct VpmmRecord {
    size: usize,
    stream: StreamGuard,
}

impl VpmmRecord {
    pub(super) fn size(&self) -> usize {
        self.size
    }
}

// ============================================================================
// Pool Implementation
// ============================================================================

/// Metadata for a free region in the virtual address space.
#[derive(Debug, Clone)]
struct FreeRegionMeta {
    size: usize,
    event: Arc<CudaEvent>,
    stream: StreamGuard,
    id: usize,
}

/// Remapped region that will be unmapped when the event completes.
#[derive(Debug)]
struct ZombieRegion {
    ptr: CUdeviceptr,
    size: usize,
    event: Arc<CudaEvent>,
}

/// Virtual memory pool implementation.
pub(super) struct VirtualMemoryPool {
    // Virtual address space roots
    pub(super) roots: Vec<CUdeviceptr>,

    // Map for all active pages
    active_pages: HashMap<CUdeviceptr, CUmemGenericAllocationHandle>,

    // Free regions in virtual space (sorted by address)
    free_regions: BTreeMap<CUdeviceptr, FreeRegionMeta>,

    // Active allocations: (ptr, record)
    malloc_regions: HashMap<CUdeviceptr, VpmmRecord>,

    // Unmapped regions: (ptr, size)
    unmapped_regions: BTreeMap<CUdeviceptr, usize>,

    // Zombie regions: (remapped, but not unmapped yet)
    zombie_regions: Vec<ZombieRegion>,

    // Number of free calls (used to assign ids to free regions)
    free_num: usize,

    // Granularity size: (page % 2MB must be 0)
    pub(super) page_size: usize,

    // Reserved virtual address span in bytes
    va_size: usize,

    // Device ordinal
    pub(super) device_id: i32,
}

/// # Safety
/// `VirtualMemoryPool` is not internally synchronized. These impls are safe because
/// all access goes through `Mutex<MemoryManager>` in the parent module.
unsafe impl Send for VirtualMemoryPool {}
unsafe impl Sync for VirtualMemoryPool {}

impl VirtualMemoryPool {
    pub(super) fn new(config: VpmmConfig) -> Self {
        let device_id = set_device().unwrap();

        // Check VPMM support and resolve page_size
        let (root, page_size, va_size) = unsafe {
            match vpmm_check_support(device_id) {
                Ok(_) => {
                    let granularity = vpmm_min_granularity(device_id).unwrap();

                    // Resolve page_size: use config override or device granularity
                    let page_size = match config.page_size {
                        Some(size) => {
                            assert!(
                                size > 0 && size % granularity == 0,
                                "VPMM_PAGE_SIZE must be > 0 and multiple of {}",
                                granularity
                            );
                            size
                        }
                        None => granularity,
                    };

                    // Validate va_size
                    let va_size = config.va_size;
                    assert!(
                        va_size > 0 && va_size.is_multiple_of(page_size),
                        "VPMM_VA_SIZE must be > 0 and multiple of page size ({})",
                        page_size
                    );

                    // Reserve initial VA chunk
                    let va_base = vpmm_reserve(va_size, page_size).unwrap();
                    tracing::debug!(
                        "VPMM: Reserved virtual address space {} with page size {}",
                        ByteSize::b(va_size as u64),
                        ByteSize::b(page_size as u64)
                    );
                    (va_base, page_size, va_size)
                }
                Err(_) => {
                    tracing::warn!("VPMM not supported, falling back to cudaMallocAsync");
                    (0, usize::MAX, 0)
                }
            }
        };

        let mut pool = Self {
            roots: vec![root],
            active_pages: HashMap::new(),
            free_regions: BTreeMap::new(),
            malloc_regions: HashMap::new(),
            unmapped_regions: if va_size > 0 {
                BTreeMap::from_iter([(root, va_size)])
            } else {
                BTreeMap::new()
            },
            zombie_regions: Vec::new(),
            free_num: 0,
            page_size,
            va_size,
            device_id,
        };

        // Preallocate pages if requested (skip if VPMM not supported)
        if config.initial_pages > 0 && page_size != usize::MAX {
            let alloc_size = config.initial_pages * page_size;
            let init_stream = StreamGuard::new(CudaStream::new_non_blocking().unwrap());
            if let Err(e) = pool.defragment_or_create_new_pages(alloc_size, &init_stream) {
                let mut free_mem = 0usize;
                let mut total_mem = 0usize;
                unsafe {
                    cudaMemGetInfo(&mut free_mem, &mut total_mem);
                }
                panic!(
                    "VPMM preallocation failed: {:?}\n\
                     Config: pages={}, page_size={}\n\
                     GPU Memory: free={}, total={}",
                    e,
                    config.initial_pages,
                    ByteSize::b(page_size as u64),
                    ByteSize::b(free_mem as u64),
                    ByteSize::b(total_mem as u64)
                );
            }
            // Ensure the event recorded during pre-allocation is completed before
            // any caller uses the pool. Without this, find_best_fit's Phase 1b
            // may see the event as not-yet-completed (race with GPU processing)
            // and fall through to defragment_or_create_new_pages, remapping the
            // pre-allocated pages to a different VA location.
            init_stream.synchronize().expect("init_stream sync failed");
        }

        pool
    }

    // ========================================================================
    // Tracked (explicit-stream) path
    // ========================================================================

    /// Allocates memory from the pool's free regions.
    /// Attempts defragmentation if no suitable free region exists.
    /// Returns an error if there's insufficient memory even after defragmentation.
    pub(super) fn malloc_internal(
        &mut self,
        requested: usize,
        stream: &StreamGuard,
    ) -> Result<*mut c_void, MemoryError> {
        debug_assert!(
            requested != 0 && requested.is_multiple_of(self.page_size),
            "Requested size must be a multiple of the page size"
        );

        // Phase 0: Cleanup zombie regions
        self.cleanup_zombie_regions();

        // Phase 1: Zero-cost attempts
        let mut best_region = self.find_best_fit(requested, stream);

        if best_region.is_none() {
            // Phase 2: Defragmentation
            best_region = self.defragment_or_create_new_pages(requested, stream)?;
        }

        if let Some(ptr) = best_region {
            let region = self
                .free_regions
                .remove(&ptr)
                .expect("BUG: free region address not found after find_best_fit");

            // If region is larger, return the untouched tail with its original guard metadata.
            if region.size > requested {
                self.reinsert_split_free_region(
                    ptr + requested as u64,
                    region.size - requested,
                    region,
                );
            }

            self.malloc_regions.insert(
                ptr,
                VpmmRecord {
                    size: requested,
                    stream: stream.clone(),
                },
            );
            return Ok(ptr as *mut c_void);
        }

        Err(MemoryError::OutOfMemory {
            requested,
            available: self.free_regions.values().map(|r| r.size).sum(),
        })
    }

    /// Phase 1 best-fit: prefer same-stream regions via `Arc::ptr_eq`.
    fn find_best_fit(&mut self, requested: usize, stream: &StreamGuard) -> Option<CUdeviceptr> {
        let mut candidates: Vec<(CUdeviceptr, &mut FreeRegionMeta)> = self
            .free_regions
            .iter_mut()
            .filter(|(_, region)| region.size >= requested)
            .map(|(addr, region)| (*addr, region))
            .collect();

        if candidates.is_empty() {
            return None;
        }

        // 1a. Prefer same stream (smallest fit) — could be not completed
        if let Some((addr, _)) = candidates
            .iter()
            .filter(|(_, region)| region.stream == *stream)
            .min_by_key(|(_, region)| region.size)
        {
            return Some(*addr);
        }

        // 1b. Other streams (smallest fit) — ONLY if already completed (no sync)
        candidates
            .iter_mut()
            .filter(|(_, region)| region.event.completed())
            .min_by_key(|(_, region)| region.size)
            .map(|(addr, region)| {
                region.stream = stream.clone();
                *addr
            })
    }

    /// Frees a pointer and returns the size of the freed memory.
    /// Coalesces adjacent free regions.
    ///
    /// The `StreamGuard` must be dropped by the caller AFTER releasing the memory manager lock.
    pub(super) fn free_internal(
        &mut self,
        ptr: *mut c_void,
    ) -> Result<(usize, StreamGuard), MemoryError> {
        let ptr = ptr as CUdeviceptr;
        let record = self
            .malloc_regions
            .remove(&ptr)
            .ok_or(MemoryError::InvalidPointer)?;

        let size = record.size();
        self.free_region_insert(ptr, size, &record.stream);

        Ok((size, record.stream))
    }

    // ========================================================================
    // Shared helpers
    // ========================================================================

    /// Reclaims zombie regions whose events have completed.
    ///
    /// Zombies are old regions that have been double-mapped to new locations during defrag.
    /// Once the associated event completes (meaning no GPU work is using the old VA),
    /// we can safely unmap the old VA and return it to `unmapped_regions` for reuse.
    fn cleanup_zombie_regions(&mut self) {
        let mut i = 0;
        while i < self.zombie_regions.len() {
            if self.zombie_regions[i].event.completed() {
                let zombie = self.zombie_regions.swap_remove(i);
                if let Err(e) = unsafe { vpmm_unmap(zombie.ptr, zombie.size) } {
                    tracing::error!(
                        "vpmm_unmap (zombie) failed: addr={:#x}, size={}: {:?}",
                        zombie.ptr,
                        zombie.size,
                        e
                    );
                }
                self.insert_unmapped_region(zombie.ptr, zombie.size);
            } else {
                i += 1;
            }
        }
    }

    /// Inserts a new free region for `(ptr, size)` into the free regions map, possibly merging
    /// with adjacent same-stream regions. Records a new event on the stream.
    ///
    /// Returns the starting pointer and size of the (possibly merged) free region.
    fn free_region_insert(
        &mut self,
        mut ptr: CUdeviceptr,
        mut size: usize,
        stream: &StreamGuard,
    ) -> (CUdeviceptr, usize) {
        // Potential merge with next neighbor
        if let Some((&next_ptr, next_region)) = self.free_regions.range(ptr + 1..).next() {
            if next_region.stream == *stream && ptr + size as u64 == next_ptr {
                let next_region = self.free_regions.remove(&next_ptr).unwrap();
                size += next_region.size;
            }
        }
        // Potential merge with previous neighbor
        if let Some((&prev_ptr, prev_region)) = self.free_regions.range(..ptr).next_back() {
            if prev_region.stream == *stream && prev_ptr + prev_region.size as u64 == ptr {
                let prev_region = self.free_regions.remove(&prev_ptr).unwrap();
                ptr = prev_ptr;
                size += prev_region.size;
            }
        }
        let event = Arc::new(CudaEvent::new().unwrap());
        event.record_on(stream).unwrap();
        let id = self.free_num;
        self.free_num += 1;

        self.free_regions.insert(
            ptr,
            FreeRegionMeta {
                size,
                event,
                stream: stream.clone(),
                id,
            },
        );
        (ptr, size)
    }

    /// Reinsert the untouched tail of a split free region without recording a new event.
    ///
    /// No new synchronization point was created for these pages, so they keep the original
    /// event, stream affinity, and age ordering.
    fn reinsert_split_free_region(
        &mut self,
        ptr: CUdeviceptr,
        size: usize,
        region: FreeRegionMeta,
    ) {
        debug_assert!(size > 0);
        self.free_regions
            .insert(ptr, FreeRegionMeta { size, ..region });
    }

    /// Return the base address of a virtual hole large enough for `requested` bytes.
    fn take_unmapped_region(&mut self, requested: usize) -> Result<CUdeviceptr, MemoryError> {
        debug_assert!(requested != 0);
        debug_assert_eq!(requested % self.page_size, 0);

        if requested > self.va_size {
            return Err(MemoryError::RequestedExceedsVaChunk {
                requested,
                va_size: self.va_size,
            });
        }

        if let Some((&addr, &size)) = self
            .unmapped_regions
            .iter()
            .filter(|(_, region_size)| **region_size >= requested)
            .min_by_key(|(_, region_size)| *region_size)
        {
            self.unmapped_regions.remove(&addr);
            if size > requested {
                self.unmapped_regions
                    .insert(addr + requested as u64, size - requested);
            }
            return Ok(addr);
        }

        let addr = unsafe {
            vpmm_reserve(self.va_size, self.page_size).map_err(|_| MemoryError::ReserveFailed {
                size: self.va_size,
                page_size: self.page_size,
            })?
        };
        self.roots.push(addr);
        self.insert_unmapped_region(addr + requested as u64, self.va_size - requested);
        Ok(addr)
    }

    /// Insert a hole back into the unmapped set, coalescing with neighbors.
    fn insert_unmapped_region(&mut self, mut addr: CUdeviceptr, mut size: usize) {
        if size == 0 {
            return;
        }

        if let Some((&prev_addr, &prev_size)) = self.unmapped_regions.range(..addr).next_back() {
            if prev_addr + prev_size as u64 == addr {
                self.unmapped_regions.remove(&prev_addr);
                addr = prev_addr;
                size += prev_size;
            }
        }

        if let Some((&next_addr, &next_size)) = self.unmapped_regions.range(addr + 1..).next() {
            if addr + size as u64 == next_addr {
                self.unmapped_regions.remove(&next_addr);
                size += next_size;
            }
        }

        self.unmapped_regions.insert(addr, size);
    }

    /// Roll back partially allocated pages when allocation fails.
    fn rollback_new_pages(
        &mut self,
        reserved_ptr: CUdeviceptr,
        reserved_size: usize,
        allocated_pages: &[(CUdeviceptr, CUmemGenericAllocationHandle)],
    ) {
        for (addr, handle) in allocated_pages {
            if let Err(e) = unsafe { vpmm_unmap(*addr, self.page_size) } {
                tracing::error!(
                    "rollback: vpmm_unmap failed: addr={:#x}, size={}: {:?}",
                    addr,
                    self.page_size,
                    e
                );
            }
            self.active_pages.remove(addr);
            if let Err(e) = unsafe { vpmm_release(*handle) } {
                tracing::error!("rollback: vpmm_release failed: handle={}: {:?}", handle, e);
            }
        }
        self.insert_unmapped_region(reserved_ptr, reserved_size);
    }

    // ========================================================================
    // Defragmentation
    // ========================================================================

    /// Defragments the pool by reusing existing holes and, if needed, reserving more VA space.
    /// Moves just enough pages to satisfy `requested`, keeping the remainder in place.
    ///
    /// The returned pointer, if not `None`, is guaranteed to exist as a key in `free_regions`.
    fn defragment_or_create_new_pages(
        &mut self,
        requested: usize,
        stream: &StreamGuard,
    ) -> Result<Option<CUdeviceptr>, MemoryError> {
        debug_assert_eq!(requested % self.page_size, 0);
        if requested == 0 {
            return Ok(None);
        }

        let total_free_size = self.free_regions.values().map(|r| r.size).sum::<usize>();
        tracing::debug!(
            "VPMM: Defragging or creating new pages: requested={}, free={}",
            ByteSize::b(requested as u64),
            ByteSize::b(total_free_size as u64),
        );

        // Find a best fit unmapped region
        let dst = self.take_unmapped_region(requested)?;
        // Sentinel value until we have a valid free region pointer from allocation
        let mut allocated_ptr = CUdeviceptr::MAX;

        let mut allocated_dst = dst;
        let mut allocate_size = requested.saturating_sub(total_free_size);
        debug_assert_eq!(allocate_size % self.page_size, 0);
        let mut allocated_pages: Vec<(CUdeviceptr, CUmemGenericAllocationHandle)> = Vec::new();
        while allocated_dst < dst + allocate_size as u64 {
            let handle = unsafe {
                match vpmm_create_physical(self.device_id, self.page_size) {
                    Ok(handle) => handle,
                    Err(e) => {
                        tracing::error!(
                            "vpmm_create_physical failed: device={}, page_size={}: {:?}",
                            self.device_id,
                            self.page_size,
                            e
                        );
                        if e.is_out_of_memory() {
                            self.rollback_new_pages(dst, requested, &allocated_pages);
                            return Err(MemoryError::OutOfMemory {
                                requested: allocate_size,
                                available: (allocated_dst - dst) as usize,
                            });
                        } else {
                            return Err(MemoryError::from(e));
                        }
                    }
                }
            };
            unsafe {
                vpmm_map(allocated_dst, self.page_size, handle).map_err(|e| {
                    tracing::error!(
                        "vpmm_map failed: addr={:#x}, page_size={}, handle={}: {:?}",
                        allocated_dst,
                        self.page_size,
                        handle,
                        e
                    );
                    MemoryError::from(e)
                })?;
            }
            self.active_pages.insert(allocated_dst, handle);
            allocated_pages.push((allocated_dst, handle));
            allocated_dst += self.page_size as u64;
        }
        debug_assert_eq!(allocated_dst, dst + allocate_size as u64);
        if allocate_size > 0 {
            tracing::debug!(
                "VPMM: Allocated {} bytes. Total allocated: {}",
                ByteSize::b(allocate_size as u64),
                ByteSize::b(self.memory_usage() as u64)
            );
            unsafe {
                vpmm_set_access(dst, allocate_size, self.device_id).map_err(|e| {
                    tracing::error!(
                        "vpmm_set_access failed: addr={:#x}, size={}, device={}: {:?}",
                        dst,
                        allocate_size,
                        self.device_id,
                        e
                    );
                    MemoryError::from(e)
                })?;
            }
            let (merged_ptr, merged_size) = self.free_region_insert(dst, allocate_size, stream);
            debug_assert!(merged_size >= allocate_size);
            allocated_ptr = merged_ptr;
            allocate_size = merged_size;
        }

        let mut remaining = requested.saturating_sub(allocate_size);
        if remaining == 0 {
            debug_assert_ne!(
                allocated_ptr,
                CUdeviceptr::MAX,
                "Allocation returned no valid free region"
            );
            return Ok(Some(allocated_ptr));
        }
        debug_assert!(allocate_size == 0 || allocated_ptr <= dst);

        // Pull free regions; prefer same stream, then oldest-first for other streams
        let mut to_defrag: Vec<(CUdeviceptr, usize)> = Vec::new();
        let mut ordered_free_regions: Vec<_> = self
            .free_regions
            .iter()
            .filter(|(&addr, _)| allocate_size == 0 || addr != allocated_ptr)
            .map(|(&addr, region)| (region.stream != *stream, region.id, addr))
            .collect();
        ordered_free_regions.sort_by_key(|(is_other, id, _)| (*is_other, *id));
        for (other_stream, _, addr) in ordered_free_regions {
            if remaining == 0 {
                break;
            }

            let region = self
                .free_regions
                .remove(&addr)
                .expect("BUG: free region disappeared");

            if other_stream && !region.event.completed() {
                // Make the caller's stream wait on the cross-stream event
                stream.wait(&region.event)?;
            }

            let take = remaining.min(region.size);

            self.zombie_regions.push(ZombieRegion {
                ptr: addr,
                size: take,
                event: region.event.clone(),
            });

            to_defrag.push((addr, take));
            remaining -= take;

            if region.size > take {
                let leftover_addr = addr + take as u64;
                let leftover_size = region.size - take;
                self.reinsert_split_free_region(leftover_addr, leftover_size, region);
            }
        }
        let remapped_ptr = self.remap_regions(to_defrag, allocated_dst, stream)?;
        let result = std::cmp::min(allocated_ptr, remapped_ptr);
        debug_assert!(allocate_size == 0 || allocated_ptr == remapped_ptr);
        debug_assert_ne!(
            result,
            CUdeviceptr::MAX,
            "Both allocation and remapping returned no valid free region"
        );
        Ok(Some(result))
    }

    fn remap_regions(
        &mut self,
        regions: Vec<(CUdeviceptr, usize)>,
        dst: CUdeviceptr,
        stream: &StreamGuard,
    ) -> Result<CUdeviceptr, MemoryError> {
        if regions.is_empty() {
            return Ok(CUdeviceptr::MAX);
        }

        let bytes_to_remap = regions.iter().map(|(_, size)| *size).sum::<usize>();
        tracing::debug!(
            "VPMM: Remapping {} regions. Total size = {}",
            regions.len(),
            ByteSize::b(bytes_to_remap as u64)
        );

        let mut curr_dst = dst;
        for (region_addr, region_size) in regions {
            let num_pages = region_size / self.page_size;
            for i in 0..num_pages {
                let page = region_addr + (i * self.page_size) as u64;
                let handle = self
                    .active_pages
                    .remove(&page)
                    .expect("BUG: active page not found during remapping");
                unsafe {
                    vpmm_map(curr_dst, self.page_size, handle).map_err(|e| {
                        tracing::error!(
                            "vpmm_map (remap) failed: dst={:#x}, page_size={}, handle={}: {:?}",
                            curr_dst,
                            self.page_size,
                            handle,
                            e
                        );
                        MemoryError::from(e)
                    })?;
                }
                self.active_pages.insert(curr_dst, handle);
                curr_dst += self.page_size as u64;
            }
        }

        debug_assert_eq!(curr_dst - dst, bytes_to_remap as u64);

        unsafe {
            vpmm_set_access(dst, bytes_to_remap, self.device_id).map_err(|e| {
                tracing::error!(
                    "vpmm_set_access (remap) failed: addr={:#x}, size={}, device={}: {:?}",
                    dst,
                    bytes_to_remap,
                    self.device_id,
                    e
                );
                MemoryError::from(e)
            })?;
        }
        let (remapped_ptr, _) = self.free_region_insert(dst, bytes_to_remap, stream);
        Ok(remapped_ptr)
    }

    /// Returns the total physical memory currently mapped in this pool (in bytes).
    pub(super) fn memory_usage(&self) -> usize {
        self.active_pages.len() * self.page_size
    }
}

impl Drop for VirtualMemoryPool {
    fn drop(&mut self) {
        device_synchronize().unwrap();

        // Unmap zombie regions first
        for zombie in self.zombie_regions.drain(..) {
            unsafe {
                vpmm_unmap(zombie.ptr, zombie.size).unwrap();
            }
        }

        for (ptr, handle) in self.active_pages.drain() {
            unsafe {
                vpmm_unmap(ptr, self.page_size).unwrap();
                vpmm_release(handle).unwrap();
            }
        }

        for root in self.roots.drain(..) {
            unsafe {
                vpmm_release_va(root, self.va_size).unwrap();
            }
        }
    }
}

impl Default for VirtualMemoryPool {
    fn default() -> Self {
        Self::new(VpmmConfig::from_env())
    }
}

#[allow(unused)]
impl std::fmt::Debug for VirtualMemoryPool {
    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
        writeln!(
            f,
            "VMPool (VA_SIZE={}, PAGE_SIZE={})",
            ByteSize::b(self.va_size as u64),
            ByteSize::b(self.page_size as u64)
        )?;

        let reserved = self.roots.len() * self.va_size;
        let allocated = self.memory_usage();
        let free_bytes: usize = self.free_regions.values().map(|r| r.size).sum();
        let malloc_bytes: usize = self.malloc_regions.values().map(|r| r.size()).sum();
        let unmapped_bytes: usize = self.unmapped_regions.values().sum();
        let zombies_bytes: usize = self.zombie_regions.iter().map(|r| r.size).sum();

        writeln!(
            f,
            "Total: reserved={}, allocated={}, free={}, malloc={}, unmapped={}, (zombies={})",
            ByteSize::b(reserved as u64),
            ByteSize::b(allocated as u64),
            ByteSize::b(free_bytes as u64),
            ByteSize::b(malloc_bytes as u64),
            ByteSize::b(unmapped_bytes as u64),
            ByteSize::b(zombies_bytes as u64),
        )?;

        let mut regions: Vec<(CUdeviceptr, usize, String)> = Vec::new();
        for (addr, region) in &self.free_regions {
            regions.push((
                *addr,
                region.size,
                format!("free ({:?})", region.stream.as_raw()),
            ));
        }
        for (addr, record) in &self.malloc_regions {
            regions.push((*addr, record.size(), "malloc".to_string()));
        }
        for (addr, size) in &self.unmapped_regions {
            regions.push((*addr, *size, "unmapped".to_string()));
        }
        regions.sort_by_key(|(addr, _, _)| *addr);

        write!(f, "Regions: ")?;
        for (_, size, label) in regions.iter() {
            write!(f, "[{} {}]", label, ByteSize::b(*size as u64))?;
        }
        Ok(())
    }
}

#[cfg(test)]
mod tests {
    use std::sync::Arc;

    use super::{FreeRegionMeta, VirtualMemoryPool, VpmmConfig};
    use crate::stream::{CudaEvent, CudaStream, StreamGuard};

    fn test_stream() -> StreamGuard {
        StreamGuard::new(CudaStream::new_non_blocking().unwrap())
    }

    #[test]
    fn test_defrag_leftover_preserves_original_metadata() {
        let config = VpmmConfig {
            page_size: None,
            va_size: 1 << 30,
            initial_pages: 2,
        };
        let mut pool = VirtualMemoryPool::new(config);

        if pool.page_size == usize::MAX {
            println!("VPMM not supported, skipping test");
            return;
        }

        let page_size = pool.page_size;
        let stream = test_stream();
        let foreign_stream = test_stream();

        let ptr = pool.malloc_internal(2 * page_size, &stream).unwrap();
        pool.free_internal(ptr).unwrap();

        let (&free_addr, region) = pool.free_regions.iter_mut().next().unwrap();
        let original_event = Arc::new(CudaEvent::new().unwrap());
        original_event.record_on(&foreign_stream).unwrap();
        *region = FreeRegionMeta {
            size: region.size,
            event: original_event.clone(),
            stream: foreign_stream.clone(),
            id: 42,
        };

        let leftover_addr = free_addr + page_size as u64;
        pool.defragment_or_create_new_pages(page_size, &stream)
            .unwrap()
            .unwrap();

        let leftover = pool.free_regions.get(&leftover_addr).unwrap();
        assert_eq!(leftover.size, page_size);
        assert_eq!(leftover.stream, foreign_stream);
        assert_eq!(leftover.id, 42);
        assert!(Arc::ptr_eq(&leftover.event, &original_event));
    }
}