1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
//! Reverse dependency index from layer sites to composed prim indices.
//!
//! For each composed [`PrimIndex`], records the `(layer_index, site_path)`
//! pairs read by its graph. When an authoring change reports "layer L
//! changed at path P", [`Dependencies::lookup_with_ancestors`] (plus
//! [`subtree_lookup`](Self::subtree_lookup) for fanout downward) returns
//! the prim indices that need invalidating.
//!
//! Single-layer-stack equivalent of C++ `Pcp_Dependencies`. Because
//! [`IndexCache`](super::IndexCache) owns exactly one layer stack, the outer key is
//! `layer_index` rather than a layer-stack reference.
use std::collections::{HashMap, HashSet};
use crate::sdf::Path;
use super::prim_graph::ArcType;
use super::prim_index::PrimIndex;
use super::LayerId;
#[derive(Debug, Default)]
pub(super) struct Dependencies {
/// `per_layer[layer_id][site_path]` = prim index paths that read this site.
per_layer: HashMap<LayerId, HashMap<Path, Vec<Path>>>,
/// Reverse map for cheap removal: prim_index_path → list of (layer, site)
/// it registered. Avoids re-walking the index when invalidating.
by_prim: HashMap<Path, Vec<(LayerId, Path)>>,
}
impl Dependencies {
/// Register every `(layer_id, node.path)` site referenced by `index` as a
/// dependency of `prim_index_path`. Replaces any prior registration for the
/// same prim. A site whose node spans several sublayers registers each member
/// layer, so a change to any of them fans out to this prim.
///
/// The implicit "self" edge — a Root node whose path equals the prim's
/// own path — is skipped to keep the map compact. C++
/// `PcpDependencyTypeRoot` follows the same rule.
pub(super) fn add(&mut self, prim_index_path: &Path, index: &PrimIndex, all_layers: &[LayerId]) {
// Clear any previous registration before adding the new one.
self.remove(prim_index_path);
// `seen` provides O(1) dedup as we walk graph nodes; the parallel
// `registered` Vec preserves insertion order for the reverse-map
// entry (the order is irrelevant to lookups but helps debug).
let mut seen: HashSet<(LayerId, Path)> = HashSet::new();
let mut registered: Vec<(LayerId, Path)> = Vec::new();
// Include culled arc nodes (empty targets) and inert relocation-source
// nodes: authoring a spec at such a site must invalidate this prim so the
// node un-culls / re-relocates on recomposition.
for node in index.dependency_nodes() {
if node.arc == ArcType::Root && node.path == *prim_index_path {
continue;
}
for (layer, _) in node.layers() {
let key = (layer, node.path.clone());
if !seen.insert(key.clone()) {
continue;
}
registered.push(key);
self.per_layer
.entry(layer)
.or_default()
.entry(node.path.clone())
.or_default()
.push(prim_index_path.clone());
}
}
// Ensure the prim's own path is findable on every layer. Without
// this, cached misses (empty `PrimIndex`) and self-Root-only
// indices have no reverse-map entry, so an authoring change that
// names exactly this path on a layer the graph doesn't already
// touch cannot reach them via `lookup_with_ancestors`. Synthetic
// self-registrations are cheap and let the dependency map serve as
// the single source of truth for "which prims observe site X on layer L".
for &li in all_layers {
let key = (li, prim_index_path.clone());
if !seen.insert(key.clone()) {
continue;
}
registered.push(key);
self.per_layer
.entry(li)
.or_default()
.entry(prim_index_path.clone())
.or_default()
.push(prim_index_path.clone());
}
self.by_prim.insert(prim_index_path.clone(), registered);
}
/// Drop all registered `(layer, site)` entries for `prim_index_path`.
pub(super) fn remove(&mut self, prim_index_path: &Path) {
let Some(sites) = self.by_prim.remove(prim_index_path) else {
return;
};
for (li, site) in sites {
if let Some(map) = self.per_layer.get_mut(&li) {
if let Some(deps) = map.get_mut(&site) {
deps.retain(|p| p != prim_index_path);
if deps.is_empty() {
map.remove(&site);
}
}
}
}
}
/// Drop all entries.
pub(super) fn clear(&mut self) {
self.per_layer.clear();
self.by_prim.clear();
}
/// Find prim indices that depend on `(layer_id, site_path)` or on any
/// ancestor of `site_path`.
///
/// The ancestor walk matches C++ `Pcp_DidChangeDependents` (changes.cpp):
/// an arc introduced at `/Foo` makes `/Foo/Bar`'s composed index depend
/// transitively on opinions at `/Foo`, so a change at `/Foo` invalidates
/// `/Foo/Bar` too.
pub(super) fn lookup_with_ancestors(&self, layer_id: LayerId, site_path: &Path) -> Vec<Path> {
let Some(map) = self.per_layer.get(&layer_id) else {
return Vec::new();
};
let mut out: Vec<Path> = Vec::new();
let mut seen: HashSet<Path> = HashSet::new();
let mut cursor = Some(site_path.clone());
while let Some(p) = cursor {
if let Some(deps) = map.get(&p) {
for d in deps {
if seen.insert(d.clone()) {
out.push(d.clone());
}
}
}
if p.is_abs_root() {
break;
}
cursor = p.parent();
}
out
}
/// Find prim indices whose dependency site is at or below `prefix` in
/// `layer_index`.
///
/// Used to fan out an invalidation downward (a significant change at
/// `/Foo` must drop every cached index whose graph touches `/Foo/*`).
/// Linear scan over the layer's dependency map — matches the cost
/// profile of the previous full-cache invalidation in the worst case
/// and is strictly cheaper on the single-prim authoring path.
//
// TODO: back the per-layer map with an `SdfPathTable`-like trie so
// this becomes an `O(log n + k)` subtree range query. Same primitive
// needed by `IndexCache::drop_index_subtree`.
//
// TODO: snapshot a `culled_dependencies` set per prim index. The
// `Indexer` culls weaker nodes during composition; without a snapshot,
// an inert spec added at a culled site fails to un-cull the node on
// next composition.
pub(super) fn subtree_lookup(&self, layer_id: LayerId, prefix: &Path) -> Vec<Path> {
let Some(map) = self.per_layer.get(&layer_id) else {
return Vec::new();
};
let mut out: Vec<Path> = Vec::new();
let mut seen: HashSet<Path> = HashSet::new();
for (site, deps) in map {
if site.has_prefix(prefix) {
for d in deps {
if seen.insert(d.clone()) {
out.push(d.clone());
}
}
}
}
out
}
}
#[cfg(test)]
mod tests {
use super::*;
use crate::pcp::mapping::MapFunction;
use crate::pcp::prim_graph::Node;
fn p(s: &str) -> Path {
Path::new(s).expect("valid path")
}
/// A deterministic test layer id for the n-th synthetic layer.
fn l(n: u32) -> LayerId {
LayerId::from_raw(n)
}
fn make_index(prim_path: &Path, nodes: Vec<(ArcType, LayerId, Path)>) -> PrimIndex {
let mut idx = PrimIndex::default();
for (arc, layer_id, node_path) in nodes {
let map = MapFunction::from_pair_identity(node_path.clone(), prim_path.clone());
idx.push_node(Node::new(layer_id, node_path, arc, map.clone(), map, false));
}
idx
}
#[test]
fn synthetic_self_registration_covers_empty_index() {
// An index with only a self-Root edge contributes no graph-derived
// dependencies (the Root-at-own-path is intentionally skipped to
// keep the map compact). The synthetic self-registration ensures
// the prim path is still findable on every layer.
let mut deps = Dependencies::default();
let foo = p("/Foo");
let index = make_index(&foo, vec![(ArcType::Root, l(0), foo.clone())]);
deps.add(&foo, &index, &[l(0), l(1)]);
assert_eq!(deps.lookup_with_ancestors(l(0), &foo), vec![foo.clone()]);
assert_eq!(deps.lookup_with_ancestors(l(1), &foo), vec![foo.clone()]);
}
#[test]
fn reference_arc_registers_dependency() {
let mut deps = Dependencies::default();
let here = p("/World/Inst");
let there = p("/Model");
let index = make_index(
&here,
vec![
(ArcType::Root, l(0), here.clone()),
(ArcType::Reference, l(1), there.clone()),
],
);
deps.add(&here, &index, &[l(0), l(1)]);
assert_eq!(deps.lookup_with_ancestors(l(1), &there), vec![here.clone()]);
}
#[test]
fn ancestor_walk_finds_dep() {
let mut deps = Dependencies::default();
let here = p("/A/B");
let arc_site = p("/X/Y");
let index = make_index(
&here,
vec![
(ArcType::Root, l(0), here.clone()),
(ArcType::Inherit, l(0), arc_site.clone()),
],
);
deps.add(&here, &index, &[l(0)]);
// A change at /X/Y/Child should still invalidate /A/B (it depends
// transitively on /X/Y).
assert_eq!(deps.lookup_with_ancestors(l(0), &p("/X/Y/Child")), vec![here.clone()]);
}
#[test]
fn subtree_lookup_finds_descendants() {
let mut deps = Dependencies::default();
let a = p("/A");
let b = p("/B");
let xy = p("/X/Y");
let xy_child = p("/X/Y/Child");
deps.add(
&a,
&make_index(&a, vec![(ArcType::Reference, l(0), xy.clone())]),
&[l(0)],
);
deps.add(
&b,
&make_index(&b, vec![(ArcType::Reference, l(0), xy_child.clone())]),
&[l(0)],
);
// Subtree at /X/Y catches both sites.
let mut found = deps.subtree_lookup(l(0), &p("/X"));
found.sort();
assert_eq!(found, vec![a.clone(), b.clone()]);
}
#[test]
fn remove_drops_all_entries() {
let mut deps = Dependencies::default();
let here = p("/A");
let there = p("/X");
deps.add(
&here,
&make_index(&here, vec![(ArcType::Reference, l(0), there.clone())]),
&[l(0)],
);
assert!(!deps.lookup_with_ancestors(l(0), &there).is_empty());
deps.remove(&here);
assert!(deps.lookup_with_ancestors(l(0), &there).is_empty());
}
}