openiwan 0.2.0

An independently implemented iWAN client and protocol library
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
use super::http::{HttpRequest, HttpTransport};
use super::provider::{ProviderConfig, TokenRequestFormat};
use crate::{Error, Result};
use base64::Engine;
use jsonwebtoken::jwk::{Jwk, JwkSet};
use jsonwebtoken::{Algorithm, DecodingKey, Validation, decode, decode_header};
use rand::RngCore;
use serde::Deserialize;
use serde_json::Value;
use sha2::{Digest, Sha256};
use url::Url;
use zeroize::Zeroizing;

#[derive(Debug, Clone, Deserialize)]
struct DiscoveryDocument {
    issuer: String,
    authorization_endpoint: String,
    token_endpoint: String,
    jwks_uri: String,
    id_token_signing_alg_values_supported: Vec<String>,
    code_challenge_methods_supported: Vec<String>,
}

pub struct PendingAuthorization {
    authorization_url: Url,
    discovery: DiscoveryDocument,
    state: Zeroizing<String>,
    nonce: Zeroizing<String>,
    code_verifier: Zeroizing<String>,
}

impl std::fmt::Debug for PendingAuthorization {
    fn fmt(&self, formatter: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
        formatter
            .debug_struct("PendingAuthorization")
            .field("authorization_url", &"[REDACTED]")
            .field("state", &"[REDACTED]")
            .field("nonce", &"[REDACTED]")
            .field("code_verifier", &"[REDACTED]")
            .finish_non_exhaustive()
    }
}

impl PendingAuthorization {
    pub fn authorization_url(&self) -> &Url {
        &self.authorization_url
    }
}

pub(crate) struct OidcIdentity {
    pub access_token: Zeroizing<String>,
    pub username: String,
}

impl std::fmt::Debug for OidcIdentity {
    fn fmt(&self, formatter: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
        formatter
            .debug_struct("OidcIdentity")
            .field("access_token", &"[REDACTED]")
            .field("username", &self.username)
            .finish()
    }
}

#[derive(Deserialize)]
struct TokenResponse {
    access_token: String,
    id_token: String,
}

pub fn begin<T: HttpTransport>(
    provider: &ProviderConfig,
    transport: &T,
) -> Result<PendingAuthorization> {
    let discovery_url = format!(
        "{}/.well-known/openid-configuration",
        provider.oidc.issuer.trim_end_matches('/')
    );
    let response = transport.execute(HttpRequest {
        method: "GET",
        url: discovery_url,
        headers: Vec::new(),
        body: Vec::new(),
    })?;
    if response.status != 200 {
        return Err(Error::Oidc(format!(
            "discovery returned HTTP {}",
            response.status
        )));
    }
    let discovery: DiscoveryDocument = serde_json::from_slice(&response.body)
        .map_err(|error| Error::Oidc(format!("invalid discovery document: {error}")))?;
    validate_discovery(provider, &discovery)?;

    let code_verifier = random_urlsafe(64);
    let code_challenge = base64::engine::general_purpose::URL_SAFE_NO_PAD
        .encode(Sha256::digest(code_verifier.as_bytes()));
    let state = random_urlsafe(32);
    let nonce = random_urlsafe(32);
    let mut authorization_url =
        parse_https_url("authorization endpoint", &discovery.authorization_endpoint)?;
    authorization_url
        .query_pairs_mut()
        .append_pair("client_id", &provider.oidc.client_id)
        .append_pair("redirect_uri", &provider.oidc.redirect_uri)
        .append_pair("response_type", "code")
        .append_pair("scope", &provider.oidc.scopes.join(" "))
        .append_pair("code_challenge", &code_challenge)
        .append_pair("code_challenge_method", "S256")
        .append_pair("state", &state)
        .append_pair("nonce", &nonce);

    Ok(PendingAuthorization {
        authorization_url,
        discovery,
        state: Zeroizing::new(state),
        nonce: Zeroizing::new(nonce),
        code_verifier: Zeroizing::new(code_verifier),
    })
}

pub(crate) fn complete<T: HttpTransport>(
    provider: &ProviderConfig,
    transport: &T,
    pending: &PendingAuthorization,
    redirect_url: &str,
) -> Result<OidcIdentity> {
    let redirect = Url::parse(redirect_url)
        .map_err(|error| Error::Oidc(format!("invalid callback URL: {error}")))?;
    validate_redirect_uri(&provider.oidc.redirect_uri, &redirect)?;
    let query: std::collections::HashMap<String, String> =
        redirect.query_pairs().into_owned().collect();
    if let Some(error) = query.get("error") {
        let description = query
            .get("error_description")
            .map_or("", |value| value.as_str());
        return Err(Error::Oidc(format!(
            "authorization server returned {error}: {description}"
        )));
    }
    let returned_state = query
        .get("state")
        .ok_or_else(|| Error::Oidc("callback URL has no state".into()))?;
    if returned_state.as_bytes() != pending.state.as_bytes() {
        return Err(Error::Oidc("callback state mismatch".into()));
    }
    let code = Zeroizing::new(
        query
            .get("code")
            .cloned()
            .ok_or_else(|| Error::Oidc("callback URL has no authorization code".into()))?,
    );

    let (content_type, body) = token_request_body(provider, &code, &pending.code_verifier)?;
    let response = transport.execute(HttpRequest {
        method: "POST",
        url: pending.discovery.token_endpoint.clone(),
        headers: vec![("Content-Type".into(), content_type.into())],
        body,
    })?;
    if response.status != 200 {
        return Err(Error::Oidc(format!(
            "token endpoint returned HTTP {}",
            response.status
        )));
    }
    let response_body = Zeroizing::new(response.body);
    let token: TokenResponse = serde_json::from_slice(&response_body)
        .map_err(|error| Error::Oidc(format!("invalid token response: {error}")))?;
    if token.access_token.is_empty() || token.id_token.is_empty() {
        return Err(Error::Oidc(
            "token response is missing access_token or id_token".into(),
        ));
    }
    let access_token = Zeroizing::new(token.access_token);
    let id_token = Zeroizing::new(token.id_token);
    let claims = validate_id_token(provider, transport, pending, &id_token)?;
    let username = extract_username(provider, &claims)?;
    Ok(OidcIdentity {
        access_token,
        username,
    })
}

fn validate_discovery(provider: &ProviderConfig, discovery: &DiscoveryDocument) -> Result<()> {
    if discovery.issuer.trim_end_matches('/') != provider.oidc.issuer.trim_end_matches('/') {
        return Err(Error::Oidc(
            "discovery issuer does not match the provider configuration".into(),
        ));
    }
    for (name, value) in [
        (
            "authorization endpoint",
            discovery.authorization_endpoint.as_str(),
        ),
        ("token endpoint", discovery.token_endpoint.as_str()),
        ("JWKS endpoint", discovery.jwks_uri.as_str()),
    ] {
        let _ = parse_https_url(name, value)?;
    }
    if !discovery
        .code_challenge_methods_supported
        .iter()
        .any(|method| method == "S256")
    {
        return Err(Error::Oidc(
            "authorization server does not advertise PKCE S256".into(),
        ));
    }
    if discovery.id_token_signing_alg_values_supported.is_empty() {
        return Err(Error::Oidc(
            "authorization server advertises no ID token signing algorithms".into(),
        ));
    }
    Ok(())
}

fn validate_redirect_uri(expected: &str, actual: &Url) -> Result<()> {
    let expected = Url::parse(expected)
        .map_err(|error| Error::Oidc(format!("invalid configured redirect URI: {error}")))?;
    if expected.scheme() != actual.scheme()
        || expected.username() != actual.username()
        || expected.password() != actual.password()
        || expected.host_str() != actual.host_str()
        || expected.port() != actual.port()
        || expected.path() != actual.path()
        || actual.fragment().is_some()
    {
        return Err(Error::Oidc(
            "callback URL does not match the configured redirect URI".into(),
        ));
    }
    Ok(())
}

fn token_request_body(
    provider: &ProviderConfig,
    code: &str,
    code_verifier: &str,
) -> Result<(&'static str, Vec<u8>)> {
    match provider.oidc.token_request_format {
        TokenRequestFormat::Json => {
            let value = serde_json::json!({
                "client_id": provider.oidc.client_id,
                "code": code,
                "code_verifier": code_verifier,
                "redirect_uri": provider.oidc.redirect_uri,
                "grant_type": "authorization_code",
            });
            serde_json::to_vec(&value)
                .map(|body| ("application/json", body))
                .map_err(|error| Error::Oidc(format!("serialize token request: {error}")))
        }
        TokenRequestFormat::Form => {
            let body = url::form_urlencoded::Serializer::new(String::new())
                .append_pair("client_id", &provider.oidc.client_id)
                .append_pair("code", code)
                .append_pair("code_verifier", code_verifier)
                .append_pair("redirect_uri", &provider.oidc.redirect_uri)
                .append_pair("grant_type", "authorization_code")
                .finish()
                .into_bytes();
            Ok(("application/x-www-form-urlencoded", body))
        }
    }
}

fn validate_id_token<T: HttpTransport>(
    provider: &ProviderConfig,
    transport: &T,
    pending: &PendingAuthorization,
    token: &str,
) -> Result<Value> {
    let header = decode_header(token)
        .map_err(|error| Error::Oidc(format!("invalid ID token header: {error}")))?;
    if !matches!(
        header.alg,
        Algorithm::RS256
            | Algorithm::RS384
            | Algorithm::RS512
            | Algorithm::PS256
            | Algorithm::PS384
            | Algorithm::PS512
            | Algorithm::ES256
            | Algorithm::ES384
    ) {
        return Err(Error::Oidc(
            "ID token must use an approved asymmetric signature algorithm".into(),
        ));
    }
    let algorithm_name = format!("{:?}", header.alg);
    if !pending
        .discovery
        .id_token_signing_alg_values_supported
        .iter()
        .any(|supported| supported == &algorithm_name)
    {
        return Err(Error::Oidc(format!(
            "ID token algorithm {algorithm_name} is not advertised by the issuer"
        )));
    }

    let response = transport.execute(HttpRequest {
        method: "GET",
        url: pending.discovery.jwks_uri.clone(),
        headers: Vec::new(),
        body: Vec::new(),
    })?;
    if response.status != 200 {
        return Err(Error::Oidc(format!(
            "JWKS endpoint returned HTTP {}",
            response.status
        )));
    }
    let jwks: JwkSet = serde_json::from_slice(&response.body)
        .map_err(|error| Error::Oidc(format!("invalid JWKS response: {error}")))?;
    let jwk = select_jwk(&jwks, header.kid.as_deref())?;
    let key = DecodingKey::from_jwk(jwk)
        .map_err(|error| Error::Oidc(format!("unsupported JWK: {error}")))?;
    let mut validation = Validation::new(header.alg);
    validation.set_audience(&[provider.oidc.client_id.as_str()]);
    validation.set_issuer(&[pending.discovery.issuer.as_str()]);
    validation.set_required_spec_claims(&["exp", "iss", "aud"]);
    let token_data = decode::<Value>(token, &key, &validation)
        .map_err(|error| Error::Oidc(format!("ID token validation failed: {error}")))?;
    let claims = token_data.claims;
    let nonce = claims
        .get("nonce")
        .and_then(Value::as_str)
        .ok_or_else(|| Error::Oidc("ID token has no nonce".into()))?;
    if nonce.as_bytes() != pending.nonce.as_bytes() {
        return Err(Error::Oidc("ID token nonce mismatch".into()));
    }
    Ok(claims)
}

fn select_jwk<'a>(set: &'a JwkSet, key_id: Option<&str>) -> Result<&'a Jwk> {
    match key_id {
        Some(key_id) => set
            .find(key_id)
            .ok_or_else(|| Error::Oidc(format!("JWKS has no key with id {key_id:?}"))),
        None if set.keys.len() == 1 => Ok(&set.keys[0]),
        None => Err(Error::Oidc(
            "ID token has no key id and JWKS contains multiple keys".into(),
        )),
    }
}

fn extract_username(provider: &ProviderConfig, claims: &Value) -> Result<String> {
    for name in &provider.oidc.username_claims {
        if let Some(value) = claims.get(name).and_then(Value::as_str)
            && !value.trim().is_empty()
        {
            return Ok(value.to_owned());
        }
    }
    Err(Error::Oidc(format!(
        "ID token contains none of the configured username claims: {}",
        provider.oidc.username_claims.join(", ")
    )))
}

fn parse_https_url(name: &str, value: &str) -> Result<Url> {
    let url = Url::parse(value).map_err(|error| Error::Oidc(format!("invalid {name}: {error}")))?;
    if url.scheme() != "https" || url.host_str().is_none() {
        return Err(Error::Oidc(format!("{name} must use HTTPS")));
    }
    Ok(url)
}

fn random_urlsafe(length: usize) -> String {
    let mut bytes = vec![0_u8; length];
    rand::rngs::OsRng.fill_bytes(&mut bytes);
    base64::engine::general_purpose::URL_SAFE_NO_PAD.encode(bytes)
}

#[cfg(test)]
mod tests {
    use super::*;
    use crate::managed::http::{HttpResponse, HttpTransport};
    use crate::managed::provider::{
        ControllerConfig, OidcConfig, PROVIDER_VERSION, TokenRequestFormat,
    };
    use jsonwebtoken::{EncodingKey, Header, encode};
    use std::collections::VecDeque;
    use std::sync::Mutex;

    #[derive(Default)]
    struct MockTransport {
        responses: Mutex<VecDeque<HttpResponse>>,
        requests: Mutex<Vec<HttpRequest>>,
    }

    impl MockTransport {
        fn push_json(&self, value: Value) {
            self.responses.lock().unwrap().push_back(HttpResponse {
                status: 200,
                body: serde_json::to_vec(&value).unwrap(),
            });
        }
    }

    impl HttpTransport for MockTransport {
        fn execute(&self, request: HttpRequest) -> Result<HttpResponse> {
            self.requests.lock().unwrap().push(request);
            self.responses
                .lock()
                .unwrap()
                .pop_front()
                .ok_or_else(|| Error::Http("mock response queue is empty".into()))
        }
    }

    fn provider() -> ProviderConfig {
        ProviderConfig {
            version: PROVIDER_VERSION,
            id: "test".into(),
            display_name: "Test".into(),
            dns_servers: Vec::new(),
            require_auth_verify_echo: false,
            xor_key_bytes: 16,
            oidc: OidcConfig {
                issuer: "https://auth.example.test".into(),
                client_id: "client-id".into(),
                redirect_uri: "com.example.app://oauth2redirect".into(),
                scopes: vec!["openid".into(), "profile".into()],
                username_claims: vec!["name".into(), "sub".into()],
                token_request_format: TokenRequestFormat::Json,
            },
            controller: ControllerConfig {
                base_url: "https://controller.example.test".into(),
                domain: "iwan.example".into(),
                app_id: "controller-example".into(),
                app_secret: "secret".into(),
                auth_path: "/m/auth".into(),
                keepalive_path: "/m/keepalive".into(),
                config_path: "/m/config".into(),
                device_type: "android".into(),
                oem_name: "example-oem".into(),
            },
        }
    }

    fn discovery() -> Value {
        serde_json::json!({
            "issuer": "https://auth.example.test",
            "authorization_endpoint": "https://auth.example.test/authorize",
            "token_endpoint": "https://auth.example.test/token",
            "jwks_uri": "https://auth.example.test/jwks",
            "id_token_signing_alg_values_supported": ["RS256"],
            "code_challenge_methods_supported": ["S256"]
        })
    }

    #[test]
    fn redirect_requires_exact_origin_path_and_state() {
        let actual = Url::parse("com.example.app://oauth2redirect?code=x&state=y").unwrap();
        validate_redirect_uri("com.example.app://oauth2redirect", &actual).unwrap();
        assert!(validate_redirect_uri("com.example.app://other", &actual).is_err());
        assert!(
            validate_redirect_uri(
                "com.example.app://oauth2redirect",
                &Url::parse("com.attacker.app://oauth2redirect?code=x&state=y").unwrap()
            )
            .is_err()
        );
    }

    #[test]
    fn validates_full_pkce_oidc_exchange() {
        let provider = provider();
        let transport = MockTransport::default();
        transport.push_json(discovery());
        let pending = begin(&provider, &transport).unwrap();
        let query: std::collections::HashMap<_, _> = pending
            .authorization_url()
            .query_pairs()
            .into_owned()
            .collect();
        assert_eq!(query.get("code_challenge_method").unwrap(), "S256");
        assert_eq!(query.get("nonce").unwrap(), pending.nonce.as_str());
        assert_eq!(query.get("state").unwrap(), pending.state.as_str());

        let now = jsonwebtoken::get_current_timestamp();
        let claims = serde_json::json!({
            "iss": "https://auth.example.test",
            "aud": "client-id",
            "exp": now + 3600,
            "iat": now,
            "nonce": pending.nonce.as_str(),
            "name": "alice"
        });
        let mut header = Header::new(Algorithm::RS256);
        header.kid = Some("rsa01".into());
        let private_key = include_bytes!("../../tests/fixtures/test_rsa_private.pem");
        let id_token = encode(
            &header,
            &claims,
            &EncodingKey::from_rsa_pem(private_key).unwrap(),
        )
        .unwrap();
        transport.push_json(serde_json::json!({
            "access_token": "access-token-value",
            "id_token": id_token
        }));
        transport.push_json(serde_json::json!({
            "keys": [{
                "kty": "RSA",
                "n": "yRE6rHuNR0QbHO3H3Kt2pOKGVhQqGZXInOduQNxXzuKlvQTLUTv4l4sggh5_CYYi_cvI-SXVT9kPWSKXxJXBXd_4LkvcPuUakBoAkfh-eiFVMh2VrUyWyj3MFl0HTVF9KwRXLAcwkREiS3npThHRyIxuy0ZMeZfxVL5arMhw1SRELB8HoGfG_AtH89BIE9jDBHZ9dLelK9a184zAf8LwoPLxvJb3Il5nncqPcSfKDDodMFBIMc4lQzDKL5gvmiXLXB1AGLm8KBjfE8s3L5xqi-yUod-j8MtvIj812dkS4QMiRVN_by2h3ZY8LYVGrqZXZTcgn2ujn8uKjXLZVD5TdQ",
                "e": "AQAB",
                "kid": "rsa01",
                "alg": "RS256",
                "use": "sig"
            }]
        }));

        let redirect = format!(
            "com.example.app://oauth2redirect?code=authorization-code&state={}",
            pending.state.as_str()
        );
        let identity = complete(&provider, &transport, &pending, &redirect).unwrap();
        assert_eq!(identity.username, "alice");
        assert_eq!(identity.access_token.as_str(), "access-token-value");

        let requests = transport.requests.lock().unwrap();
        assert_eq!(requests.len(), 3);
        assert_eq!(requests[1].method, "POST");
        assert_eq!(requests[1].url, "https://auth.example.test/token");
        assert!(String::from_utf8_lossy(&requests[1].body).contains("\"code_verifier\""));
    }

    #[test]
    fn rejects_callback_state_before_token_exchange() {
        let provider = provider();
        let transport = MockTransport::default();
        transport.push_json(discovery());
        let pending = begin(&provider, &transport).unwrap();
        let error = complete(
            &provider,
            &transport,
            &pending,
            "com.example.app://oauth2redirect?code=x&state=wrong",
        )
        .unwrap_err();
        assert!(matches!(error, Error::Oidc(_)));
        assert_eq!(transport.requests.lock().unwrap().len(), 1);
    }
}