opendata-log 0.2.1

Key-oriented log database built on SlateDB
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
#![allow(dead_code)]

//! Log segment management.
//!
//! This module provides the [`LogSegment`] abstraction for logical partitioning
//! of log data. Segments are sequential, non-overlapping ranges of sequence numbers
//! that enable efficient seeking, retention management, and cross-key operations.

use std::collections::BTreeMap;
use std::ops::Range;
use std::time::Duration;

use common::Record;

use crate::config::SegmentConfig;
use crate::error::Result;
use crate::model::Segment;
use crate::model::SegmentId;
use crate::serde::{SegmentMeta, SegmentMetaKey};

/// A logical segment of the log.
///
/// `LogSegment` is a first-class object representing a segment in the log.
/// Segments group entries across all keys within a range of sequence numbers.
///
/// Currently tracks only ID and metadata, but designed to eventually hold
/// additional state such as key listings.
#[derive(Debug, Clone, PartialEq, Eq)]
pub(crate) struct LogSegment {
    id: SegmentId,
    meta: SegmentMeta,
}

impl LogSegment {
    /// Creates a new log segment.
    pub(crate) fn new(id: SegmentId, meta: SegmentMeta) -> Self {
        Self { id, meta }
    }

    /// Returns the segment's unique identifier.
    pub fn id(&self) -> SegmentId {
        self.id
    }

    /// Returns the segment's metadata.
    pub fn meta(&self) -> &SegmentMeta {
        &self.meta
    }
}

impl From<LogSegment> for Segment {
    fn from(seg: LogSegment) -> Self {
        Segment {
            id: seg.id,
            start_seq: seg.meta.start_seq,
            start_time_ms: seg.meta.start_time_ms,
        }
    }
}

/// Result of assigning a segment for a write batch.
#[derive(Debug, Clone)]
pub(crate) struct SegmentAssignment {
    /// The segment for this write.
    pub(crate) segment: LogSegment,
    /// Whether this is a newly created segment.
    pub(crate) is_new: bool,
}

/// In-memory cache of segments loaded from storage.
///
/// Provides fast access to segment metadata without repeated storage reads.
///
/// Keyed by `start_seq` to optimize `find_covering` queries.
#[derive(Clone)]
pub(crate) struct SegmentCache {
    /// Segments keyed by their starting sequence number.
    segments: BTreeMap<u64, LogSegment>,
    /// Configuration for segment management.
    config: SegmentConfig,
}

impl SegmentCache {
    /// Creates a new cache by loading all segments from storage.
    pub(crate) async fn open(
        storage: &crate::storage::LogStorageRead,
        config: SegmentConfig,
    ) -> Result<Self> {
        let loaded = storage.scan_segments(0..u32::MAX).await?;

        let mut segments = BTreeMap::new();
        for segment in loaded {
            segments.insert(segment.meta.start_seq, segment);
        }

        Ok(Self { segments, config })
    }

    /// Creates an empty cache for testing.
    #[cfg(test)]
    fn new() -> Self {
        Self {
            segments: BTreeMap::new(),
            config: SegmentConfig::default(),
        }
    }

    /// Returns the latest segment, if any exist.
    pub(crate) fn latest(&self) -> Option<LogSegment> {
        self.segments.values().next_back().cloned()
    }

    /// Returns all segments ordered by start sequence.
    pub(crate) fn all(&self) -> Vec<LogSegment> {
        self.segments.values().cloned().collect()
    }

    /// Finds segments covering the given sequence range.
    pub(crate) fn find_covering(&self, range: &Range<u64>) -> Vec<LogSegment> {
        if range.start >= range.end {
            return Vec::new();
        }

        // Find the first segment that could contain range.start.
        // This is the segment with the largest start_seq <= range.start.
        let mut result = Vec::new();
        let mut iter = self.segments.range(..=range.start).rev();

        if let Some((_, first_seg)) = iter.next() {
            result.push(first_seg.clone());
        }

        // Add all segments starting within our query range
        for (_, seg) in self
            .segments
            .range(range.start.saturating_add(1)..range.end)
        {
            result.push(seg.clone());
        }

        result
    }

    /// Adds a segment to the cache.
    pub(crate) fn insert(&mut self, segment: LogSegment) {
        self.segments.insert(segment.meta.start_seq, segment);
    }

    /// Refreshes the cache by loading segments from storage.
    ///
    /// If `after_segment_id` is `Some(id)`, only loads segments with id > `id` and appends them.
    /// If `after_segment_id` is `None`, reloads all segments.
    pub(crate) async fn refresh(
        &mut self,
        storage: &crate::storage::LogStorageRead,
        after_segment_id: Option<SegmentId>,
    ) -> Result<()> {
        let loaded = match after_segment_id {
            Some(id) => {
                storage
                    .scan_segments(id.saturating_add(1)..u32::MAX)
                    .await?
            }
            None => storage.scan_segments(0..u32::MAX).await?,
        };

        if after_segment_id.is_none() {
            self.segments.clear();
        }

        for segment in loaded {
            self.segments.insert(segment.meta.start_seq, segment);
        }

        Ok(())
    }

    /// Assigns a segment for a write batch.
    ///
    /// Determines whether to use an existing segment or create a new one based on
    /// the seal interval and `force_seal`. If a new segment is created, its metadata
    /// record is appended to `records` and the cache is updated.
    pub(crate) fn assign_segment(
        &mut self,
        current_time_ms: i64,
        start_seq: u64,
        records: &mut Vec<Record>,
        force_seal: bool,
    ) -> SegmentAssignment {
        let latest = self.latest();
        let needs_new_segment = force_seal
            || Self::should_roll(self.config.seal_interval, current_time_ms, latest.as_ref());

        if needs_new_segment {
            let segment_id = latest.map(|s| s.id + 1).unwrap_or(0);
            let meta = SegmentMeta::new(start_seq, current_time_ms);
            let key = SegmentMetaKey::new(segment_id).serialize();
            let value = meta.serialize();
            records.push(Record::new(key, value));

            let segment = LogSegment::new(segment_id, meta);
            self.insert(segment.clone());
            SegmentAssignment {
                segment,
                is_new: true,
            }
        } else {
            // Safe to unwrap: should_roll returns true if latest is None
            SegmentAssignment {
                segment: latest.unwrap(),
                is_new: false,
            }
        }
    }

    /// Checks if a new segment should be created based on seal interval.
    fn should_roll(
        seal_interval: Option<Duration>,
        current_time_ms: i64,
        latest: Option<&LogSegment>,
    ) -> bool {
        // No latest segment means we need to create the first one
        let Some(latest) = latest else {
            return true;
        };

        // No seal interval means we never roll (use existing segment)
        let Some(seal_interval) = seal_interval else {
            return false;
        };

        let seal_interval_ms = seal_interval.as_millis() as i64;
        let segment_age_ms = current_time_ms - latest.meta().start_time_ms;
        segment_age_ms >= seal_interval_ms
    }
}

#[cfg(test)]
mod tests {
    use super::*;
    use crate::storage::LogStorage;

    // Helper to create a segment and write it to storage + cache
    async fn write_segment(
        storage: &LogStorage,
        cache: &mut SegmentCache,
        meta: SegmentMeta,
    ) -> LogSegment {
        let segment_id = match cache.latest() {
            Some(latest) => latest.id + 1,
            None => 0,
        };
        let segment = LogSegment::new(segment_id, meta);
        storage.write_segment(&segment).await.unwrap();
        cache.insert(segment.clone());
        segment
    }

    #[tokio::test]
    async fn should_return_none_when_no_segments_exist() {
        // given
        let storage = LogStorage::in_memory();
        let cache = SegmentCache::open(&storage.as_read(), SegmentConfig::default())
            .await
            .unwrap();

        // when
        let latest = cache.latest();

        // then
        assert!(latest.is_none());
    }

    #[tokio::test]
    async fn should_write_first_segment_with_id_zero() {
        // given
        let storage = LogStorage::in_memory();
        let mut cache = SegmentCache::open(&storage.as_read(), SegmentConfig::default())
            .await
            .unwrap();
        let meta = SegmentMeta::new(0, 1000);

        // when
        let segment = write_segment(&storage, &mut cache, meta.clone()).await;

        // then
        assert_eq!(segment.id(), 0);
        assert_eq!(segment.meta(), &meta);
    }

    #[tokio::test]
    async fn should_increment_segment_id_on_subsequent_writes() {
        // given
        let storage = LogStorage::in_memory();
        let mut cache = SegmentCache::open(&storage.as_read(), SegmentConfig::default())
            .await
            .unwrap();

        // when
        let seg0 = write_segment(&storage, &mut cache, SegmentMeta::new(0, 1000)).await;
        let seg1 = write_segment(&storage, &mut cache, SegmentMeta::new(100, 2000)).await;
        let seg2 = write_segment(&storage, &mut cache, SegmentMeta::new(200, 3000)).await;

        // then
        assert_eq!(seg0.id(), 0);
        assert_eq!(seg1.id(), 1);
        assert_eq!(seg2.id(), 2);
    }

    #[tokio::test]
    async fn should_return_latest_segment() {
        // given
        let storage = LogStorage::in_memory();
        let mut cache = SegmentCache::open(&storage.as_read(), SegmentConfig::default())
            .await
            .unwrap();
        write_segment(&storage, &mut cache, SegmentMeta::new(0, 1000)).await;
        write_segment(&storage, &mut cache, SegmentMeta::new(100, 2000)).await;

        // when
        let latest = cache.latest();

        // then
        assert_eq!(latest.unwrap().id(), 1);
    }

    #[tokio::test]
    async fn should_scan_all_segments() {
        // given
        let storage = LogStorage::in_memory();
        let mut cache = SegmentCache::open(&storage.as_read(), SegmentConfig::default())
            .await
            .unwrap();
        write_segment(&storage, &mut cache, SegmentMeta::new(0, 1000)).await;
        write_segment(&storage, &mut cache, SegmentMeta::new(100, 2000)).await;
        write_segment(&storage, &mut cache, SegmentMeta::new(200, 3000)).await;

        // when
        let segments = cache.all();

        // then
        assert_eq!(segments.len(), 3);
        assert_eq!(segments[0].id(), 0);
        assert_eq!(segments[1].id(), 1);
        assert_eq!(segments[2].id(), 2);
    }

    #[tokio::test]
    async fn should_persist_segments_to_storage() {
        // given
        let storage = LogStorage::in_memory();
        let mut cache = SegmentCache::open(&storage.as_read(), SegmentConfig::default())
            .await
            .unwrap();
        write_segment(&storage, &mut cache, SegmentMeta::new(0, 1000)).await;
        write_segment(&storage, &mut cache, SegmentMeta::new(100, 2000)).await;

        // when - reopen cache from same storage
        let cache2 = SegmentCache::open(&storage.as_read(), SegmentConfig::default())
            .await
            .unwrap();
        let segments = cache2.all();

        // then
        assert_eq!(segments.len(), 2);
        assert_eq!(segments[0].id(), 0);
        assert_eq!(segments[0].meta().start_seq, 0);
        assert_eq!(segments[1].id(), 1);
        assert_eq!(segments[1].meta().start_seq, 100);
    }

    #[tokio::test]
    async fn should_find_segments_by_seq_range_all() {
        // given: segments at seq 0, 100, 200
        let storage = LogStorage::in_memory();
        let mut cache = SegmentCache::open(&storage.as_read(), SegmentConfig::default())
            .await
            .unwrap();
        write_segment(&storage, &mut cache, SegmentMeta::new(0, 1000)).await;
        write_segment(&storage, &mut cache, SegmentMeta::new(100, 2000)).await;
        write_segment(&storage, &mut cache, SegmentMeta::new(200, 3000)).await;

        // when: query all sequences
        let segments = cache.find_covering(&(0..u64::MAX));

        // then: all segments match
        assert_eq!(segments.len(), 3);
    }

    #[tokio::test]
    async fn should_find_segments_by_seq_range_single() {
        // given: segments at seq 0, 100, 200
        let storage = LogStorage::in_memory();
        let mut cache = SegmentCache::open(&storage.as_read(), SegmentConfig::default())
            .await
            .unwrap();
        write_segment(&storage, &mut cache, SegmentMeta::new(0, 1000)).await;
        write_segment(&storage, &mut cache, SegmentMeta::new(100, 2000)).await;
        write_segment(&storage, &mut cache, SegmentMeta::new(200, 3000)).await;

        // when: query seq 50..60 (within first segment)
        let segments = cache.find_covering(&(50..60));

        // then: only first segment matches
        assert_eq!(segments.len(), 1);
        assert_eq!(segments[0].id(), 0);
    }

    #[tokio::test]
    async fn should_find_segments_by_seq_range_spanning() {
        // given: segments at seq 0, 100, 200
        let storage = LogStorage::in_memory();
        let mut cache = SegmentCache::open(&storage.as_read(), SegmentConfig::default())
            .await
            .unwrap();
        write_segment(&storage, &mut cache, SegmentMeta::new(0, 1000)).await;
        write_segment(&storage, &mut cache, SegmentMeta::new(100, 2000)).await;
        write_segment(&storage, &mut cache, SegmentMeta::new(200, 3000)).await;

        // when: query seq 50..150 (spans first and second segment)
        let segments = cache.find_covering(&(50..150));

        // then: first two segments match
        assert_eq!(segments.len(), 2);
        assert_eq!(segments[0].id(), 0);
        assert_eq!(segments[1].id(), 1);
    }

    #[tokio::test]
    async fn should_find_segments_by_seq_range_unbounded_end() {
        // given: segments at seq 0, 100, 200
        let storage = LogStorage::in_memory();
        let mut cache = SegmentCache::open(&storage.as_read(), SegmentConfig::default())
            .await
            .unwrap();
        write_segment(&storage, &mut cache, SegmentMeta::new(0, 1000)).await;
        write_segment(&storage, &mut cache, SegmentMeta::new(100, 2000)).await;
        write_segment(&storage, &mut cache, SegmentMeta::new(200, 3000)).await;

        // when: query seq 150.. (from middle of second segment to end)
        let segments = cache.find_covering(&(150..u64::MAX));

        // then: second and third segments match
        assert_eq!(segments.len(), 2);
        assert_eq!(segments[0].id(), 1);
        assert_eq!(segments[1].id(), 2);
    }

    #[tokio::test]
    async fn should_find_no_segments_when_range_before_all() {
        // given: segments starting at seq 100
        let storage = LogStorage::in_memory();
        let mut cache = SegmentCache::open(&storage.as_read(), SegmentConfig::default())
            .await
            .unwrap();
        write_segment(&storage, &mut cache, SegmentMeta::new(100, 1000)).await;

        // when: query seq 0..50 (before any segment data)
        let segments = cache.find_covering(&(0..50));

        // then: no segments match (segment starts at 100)
        assert_eq!(segments.len(), 0);
    }

    #[tokio::test]
    async fn should_find_no_segments_when_storage_empty() {
        // given: no segments
        let storage = LogStorage::in_memory();
        let cache = SegmentCache::open(&storage.as_read(), SegmentConfig::default())
            .await
            .unwrap();

        // when: query any range
        let segments = cache.find_covering(&(0..u64::MAX));

        // then: no segments
        assert_eq!(segments.len(), 0);
    }

    #[tokio::test]
    async fn should_find_last_segment_when_range_after_all() {
        // given: segments at seq 0, 100, 200
        let storage = LogStorage::in_memory();
        let mut cache = SegmentCache::open(&storage.as_read(), SegmentConfig::default())
            .await
            .unwrap();
        write_segment(&storage, &mut cache, SegmentMeta::new(0, 1000)).await;
        write_segment(&storage, &mut cache, SegmentMeta::new(100, 2000)).await;
        write_segment(&storage, &mut cache, SegmentMeta::new(200, 3000)).await;

        // when: query seq 500..600 (after all segment starts)
        let segments = cache.find_covering(&(500..600));

        // then: last segment matches (it could contain seqs 200+)
        assert_eq!(segments.len(), 1);
        assert_eq!(segments[0].id(), 2);
    }

    #[tokio::test]
    async fn should_find_segment_when_query_starts_at_boundary() {
        // given: segments at seq 0, 100, 200
        let storage = LogStorage::in_memory();
        let mut cache = SegmentCache::open(&storage.as_read(), SegmentConfig::default())
            .await
            .unwrap();
        write_segment(&storage, &mut cache, SegmentMeta::new(0, 1000)).await;
        write_segment(&storage, &mut cache, SegmentMeta::new(100, 2000)).await;
        write_segment(&storage, &mut cache, SegmentMeta::new(200, 3000)).await;

        // when: query starting exactly at segment boundary
        let segments = cache.find_covering(&(100..150));

        // then: only the segment starting at 100 matches
        assert_eq!(segments.len(), 1);
        assert_eq!(segments[0].id(), 1);
    }

    #[tokio::test]
    async fn should_find_segments_with_unbounded_start() {
        // given: segments at seq 0, 100, 200
        let storage = LogStorage::in_memory();
        let mut cache = SegmentCache::open(&storage.as_read(), SegmentConfig::default())
            .await
            .unwrap();
        write_segment(&storage, &mut cache, SegmentMeta::new(0, 1000)).await;
        write_segment(&storage, &mut cache, SegmentMeta::new(100, 2000)).await;
        write_segment(&storage, &mut cache, SegmentMeta::new(200, 3000)).await;

        // when: query with unbounded start ..150
        let segments = cache.find_covering(&(0..150));

        // then: first two segments match
        assert_eq!(segments.len(), 2);
        assert_eq!(segments[0].id(), 0);
        assert_eq!(segments[1].id(), 1);
    }

    #[tokio::test]
    async fn should_roll_returns_false_when_no_seal_interval() {
        // given: no seal interval, no latest segment
        let should_roll = SegmentCache::should_roll(None, 1000, None);

        // then: should roll (no segment exists)
        assert!(should_roll);
    }

    #[tokio::test]
    async fn should_roll_returns_true_when_no_segments_exist() {
        // given: seal interval configured but no segments
        let seal_interval = Some(Duration::from_secs(3600));

        // when
        let should_roll = SegmentCache::should_roll(seal_interval, 1000, None);

        // then: should roll to create first segment
        assert!(should_roll);
    }

    #[tokio::test]
    async fn should_roll_returns_false_when_within_interval() {
        // given: segment created at time 1000, seal interval 1 hour
        let seal_interval = Some(Duration::from_secs(3600));
        let segment = LogSegment::new(0, SegmentMeta::new(0, 1000));

        // when: current time is 1000 + 30 minutes
        let current_time_ms = 1000 + 30 * 60 * 1000;
        let should_roll = SegmentCache::should_roll(seal_interval, current_time_ms, Some(&segment));

        // then
        assert!(!should_roll);
    }

    #[tokio::test]
    async fn should_roll_returns_true_when_interval_exceeded() {
        // given: segment created at time 1000, seal interval 1 hour
        let seal_interval = Some(Duration::from_secs(3600));
        let segment = LogSegment::new(0, SegmentMeta::new(0, 1000));

        // when: current time is 1000 + 2 hours
        let current_time_ms = 1000 + 2 * 60 * 60 * 1000;
        let should_roll = SegmentCache::should_roll(seal_interval, current_time_ms, Some(&segment));

        // then
        assert!(should_roll);
    }

    #[tokio::test]
    async fn should_roll_returns_true_when_exactly_at_interval() {
        // given: segment created at time 1000, seal interval 1 hour
        let seal_interval = Some(Duration::from_secs(3600));
        let segment = LogSegment::new(0, SegmentMeta::new(0, 1000));

        // when: current time is exactly at the interval boundary
        let current_time_ms = 1000 + 60 * 60 * 1000;
        let should_roll = SegmentCache::should_roll(seal_interval, current_time_ms, Some(&segment));

        // then: at boundary should roll
        assert!(should_roll);
    }

    #[tokio::test]
    async fn should_roll_returns_false_without_seal_interval_when_segment_exists() {
        // given: no seal interval, segment exists
        let segment = LogSegment::new(0, SegmentMeta::new(0, 1000));

        // when
        let should_roll = SegmentCache::should_roll(None, 999999999, Some(&segment));

        // then: never rolls without seal_interval when segment exists
        assert!(!should_roll);
    }

    #[tokio::test]
    async fn assign_segment_creates_first_segment_when_none_exist() {
        // given
        let storage = LogStorage::in_memory();
        let mut cache = SegmentCache::open(&storage.as_read(), SegmentConfig::default())
            .await
            .unwrap();
        let mut records = Vec::new();

        // when
        let assignment = cache.assign_segment(1000, 0, &mut records, false);

        // then
        assert!(assignment.is_new);
        assert_eq!(assignment.segment.id(), 0);
        assert_eq!(assignment.segment.meta().start_seq, 0);
        assert_eq!(assignment.segment.meta().start_time_ms, 1000);
        assert_eq!(records.len(), 1); // segment meta record added
        // cache is updated
        assert_eq!(cache.latest().unwrap().id(), 0);
    }

    #[tokio::test]
    async fn assign_segment_returns_existing_segment_when_within_interval() {
        // given: segment exists, within seal interval
        let storage = LogStorage::in_memory();
        let config = SegmentConfig {
            seal_interval: Some(Duration::from_secs(3600)),
        };
        let mut cache = SegmentCache::open(&storage.as_read(), config)
            .await
            .unwrap();
        write_segment(&storage, &mut cache, SegmentMeta::new(0, 1000)).await;
        let mut records = Vec::new();

        // when: request 30 minutes later
        let current_time_ms = 1000 + 30 * 60 * 1000;
        let assignment = cache.assign_segment(current_time_ms, 100, &mut records, false);

        // then: returns existing segment, no new record
        assert!(!assignment.is_new);
        assert_eq!(assignment.segment.id(), 0);
        assert_eq!(records.len(), 0);
        // still only one segment in cache
        assert_eq!(cache.all().len(), 1);
    }

    #[tokio::test]
    async fn assign_segment_creates_new_segment_when_interval_exceeded() {
        // given: segment at time 1000, seal interval 1 hour
        let storage = LogStorage::in_memory();
        let config = SegmentConfig {
            seal_interval: Some(Duration::from_secs(3600)),
        };
        let mut cache = SegmentCache::open(&storage.as_read(), config)
            .await
            .unwrap();
        write_segment(&storage, &mut cache, SegmentMeta::new(0, 1000)).await;
        let mut records = Vec::new();

        // when: request 2 hours later
        let current_time_ms = 1000 + 2 * 60 * 60 * 1000;
        let assignment = cache.assign_segment(current_time_ms, 100, &mut records, false);

        // then: creates new segment and updates cache
        assert!(assignment.is_new);
        assert_eq!(assignment.segment.id(), 1);
        assert_eq!(assignment.segment.meta().start_seq, 100);
        assert_eq!(records.len(), 1);
        assert_eq!(cache.all().len(), 2);
    }

    #[tokio::test]
    async fn assign_segment_force_seal_creates_new_segment() {
        // given: segment exists, within seal interval
        let storage = LogStorage::in_memory();
        let config = SegmentConfig {
            seal_interval: Some(Duration::from_secs(3600)),
        };
        let mut cache = SegmentCache::open(&storage.as_read(), config)
            .await
            .unwrap();
        write_segment(&storage, &mut cache, SegmentMeta::new(0, 1000)).await;
        let mut records = Vec::new();

        // when: force_seal overrides interval check
        let current_time_ms = 1000 + 30 * 60 * 1000;
        let assignment = cache.assign_segment(current_time_ms, 100, &mut records, true);

        // then: new segment created despite being within interval
        assert!(assignment.is_new);
        assert_eq!(assignment.segment.id(), 1);
        assert_eq!(cache.all().len(), 2);
    }

    #[tokio::test]
    async fn assign_segment_creates_correct_segment_meta_record() {
        // given
        let storage = LogStorage::in_memory();
        let mut cache = SegmentCache::open(&storage.as_read(), SegmentConfig::default())
            .await
            .unwrap();
        let mut records = Vec::new();

        // when
        let assignment = cache.assign_segment(5000, 42, &mut records, false);

        // then: verify the record can be deserialized
        assert_eq!(records.len(), 1);
        let key = SegmentMetaKey::deserialize(&records[0].key).unwrap();
        let meta = SegmentMeta::deserialize(&records[0].value).unwrap();
        assert_eq!(key.segment_id, assignment.segment.id());
        assert_eq!(meta.start_seq, 42);
        assert_eq!(meta.start_time_ms, 5000);
    }
}