opencrabs 0.3.55

The autonomous, self-improving AI agent. Single Rust binary. Every channel. Install with: cargo install opencrabs
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
//! Fallback Provider Chain & Vision Model Tests
//!
//! Tests for the fallback provider chain configuration, runtime fallback
//! behavior, and per-provider vision model swapping.

// --- Fallback chain config ---

mod fallback_chain {
    use crate::brain::provider::factory::fallback_chain;
    use crate::config::FallbackProviderConfig;

    #[test]
    fn empty_config_returns_empty_chain() {
        let cfg = FallbackProviderConfig::default();
        assert!(fallback_chain(&cfg).is_empty());
    }

    #[test]
    fn legacy_single_provider() {
        let cfg = FallbackProviderConfig {
            enabled: true,
            provider: Some("openrouter".into()),
            providers: vec![],
        };
        assert_eq!(fallback_chain(&cfg), vec!["openrouter"]);
    }

    #[test]
    fn providers_array_only() {
        let cfg = FallbackProviderConfig {
            enabled: true,
            provider: None,
            providers: vec!["anthropic".into(), "openai".into()],
        };
        assert_eq!(fallback_chain(&cfg), vec!["anthropic", "openai"]);
    }

    #[test]
    fn array_plus_legacy_appended() {
        let cfg = FallbackProviderConfig {
            enabled: true,
            provider: Some("gemini".into()),
            providers: vec!["anthropic".into(), "openai".into()],
        };
        assert_eq!(fallback_chain(&cfg), vec!["anthropic", "openai", "gemini"]);
    }

    #[test]
    fn legacy_deduped_if_already_in_array() {
        let cfg = FallbackProviderConfig {
            enabled: true,
            provider: Some("anthropic".into()),
            providers: vec!["anthropic".into(), "openai".into()],
        };
        // "anthropic" already in array — should NOT be appended again
        assert_eq!(fallback_chain(&cfg), vec!["anthropic", "openai"]);
    }

    #[test]
    fn single_provider_in_array() {
        let cfg = FallbackProviderConfig {
            enabled: true,
            provider: None,
            providers: vec!["minimax".into()],
        };
        assert_eq!(fallback_chain(&cfg), vec!["minimax"]);
    }

    #[test]
    fn deserialization_from_toml_array() {
        let toml_str = r#"
enabled = true
providers = ["openrouter", "anthropic"]
"#;
        let cfg: FallbackProviderConfig = toml::from_str(toml_str).unwrap();
        assert!(cfg.enabled);
        assert_eq!(cfg.providers, vec!["openrouter", "anthropic"]);
        assert!(cfg.provider.is_none());
    }

    #[test]
    fn deserialization_from_toml_legacy() {
        let toml_str = r#"
enabled = true
provider = "openrouter"
"#;
        let cfg: FallbackProviderConfig = toml::from_str(toml_str).unwrap();
        assert!(cfg.enabled);
        assert_eq!(cfg.provider, Some("openrouter".into()));
        assert!(cfg.providers.is_empty());
    }

    #[test]
    fn deserialization_from_toml_both() {
        let toml_str = r#"
enabled = true
provider = "gemini"
providers = ["anthropic", "openai"]
"#;
        let cfg: FallbackProviderConfig = toml::from_str(toml_str).unwrap();
        let chain = fallback_chain(&cfg);
        assert_eq!(chain, vec!["anthropic", "openai", "gemini"]);
    }
}

// --- Fallback provider runtime ---

mod fallback_runtime {
    use crate::brain::provider::{
        FallbackProvider, LLMRequest, LLMResponse, Provider, ProviderError, ProviderStream,
    };
    use async_trait::async_trait;
    use std::sync::Arc;
    use std::sync::atomic::{AtomicUsize, Ordering};

    /// A mock provider that fails N times, then succeeds.
    struct MockProvider {
        name: String,
        fail_count: AtomicUsize,
        max_failures: usize,
    }

    impl MockProvider {
        fn always_fail(name: &str) -> Self {
            Self {
                name: name.to_string(),
                fail_count: AtomicUsize::new(0),
                max_failures: usize::MAX,
            }
        }

        fn always_succeed(name: &str) -> Self {
            Self {
                name: name.to_string(),
                fail_count: AtomicUsize::new(0),
                max_failures: 0,
            }
        }
    }

    #[async_trait]
    impl Provider for MockProvider {
        async fn complete(
            &self,
            _request: LLMRequest,
        ) -> crate::brain::provider::error::Result<LLMResponse> {
            let count = self.fail_count.fetch_add(1, Ordering::SeqCst);
            if count < self.max_failures {
                // Use RateLimitExceeded so FallbackProvider's should_try_next
                // guard (is_retryable) falls through to the next provider.
                // Internal errors are intentionally treated as hard failures.
                Err(ProviderError::RateLimitExceeded(format!(
                    "{} mock failure #{}",
                    self.name,
                    count + 1
                )))
            } else {
                Ok(LLMResponse {
                    id: format!("{}-response", self.name),
                    model: "mock-model".into(),
                    content: vec![],
                    stop_reason: None,
                    usage: crate::brain::provider::TokenUsage {
                        input_tokens: 0,
                        output_tokens: 0,
                        ..Default::default()
                    },
                    streaming_active_secs: None,
                })
            }
        }

        async fn stream(
            &self,
            _request: LLMRequest,
        ) -> crate::brain::provider::error::Result<ProviderStream> {
            let count = self.fail_count.fetch_add(1, Ordering::SeqCst);
            if count < self.max_failures {
                Err(ProviderError::RateLimitExceeded(format!(
                    "{} stream mock failure #{}",
                    self.name,
                    count + 1
                )))
            } else {
                Ok(Box::pin(futures::stream::empty()))
            }
        }

        fn name(&self) -> &str {
            &self.name
        }

        fn default_model(&self) -> &str {
            "mock-model"
        }

        fn supported_models(&self) -> Vec<String> {
            vec!["mock-model".into()]
        }

        fn context_window(&self, _model: &str) -> Option<u32> {
            Some(4096)
        }

        fn calculate_cost(&self, _model: &str, _input: u32, _output: u32) -> f64 {
            0.0
        }
    }

    fn mock_request() -> LLMRequest {
        LLMRequest {
            model: "mock-model".into(),
            messages: vec![],
            system: None,
            max_tokens: None,
            temperature: None,
            tools: None,
            stream: false,
            metadata: None,
            working_directory: None,
            session_id: None,
        }
    }

    #[tokio::test]
    async fn primary_succeeds_no_fallback_tried() {
        let primary = Arc::new(MockProvider::always_succeed("primary"));
        let fallback = Arc::new(MockProvider::always_succeed("fallback"));
        let provider = FallbackProvider::new(primary, vec![fallback.clone()]);

        let resp = provider.complete(mock_request()).await.unwrap();
        assert_eq!(resp.id, "primary-response");
        // Fallback should not have been called
        assert_eq!(fallback.fail_count.load(Ordering::SeqCst), 0);
    }

    #[tokio::test]
    async fn primary_fails_first_fallback_succeeds() {
        let primary = Arc::new(MockProvider::always_fail("primary"));
        let fb1 = Arc::new(MockProvider::always_succeed("fallback1"));
        let provider = FallbackProvider::new(primary, vec![fb1]);

        let resp = provider.complete(mock_request()).await.unwrap();
        assert_eq!(resp.id, "fallback1-response");
    }

    #[tokio::test]
    async fn primary_fails_first_fallback_fails_second_succeeds() {
        let primary = Arc::new(MockProvider::always_fail("primary"));
        let fb1 = Arc::new(MockProvider::always_fail("fallback1"));
        let fb2 = Arc::new(MockProvider::always_succeed("fallback2"));
        let provider = FallbackProvider::new(primary, vec![fb1, fb2]);

        let resp = provider.complete(mock_request()).await.unwrap();
        assert_eq!(resp.id, "fallback2-response");
    }

    #[tokio::test]
    async fn all_fail_returns_last_error() {
        let primary = Arc::new(MockProvider::always_fail("primary"));
        let fb1 = Arc::new(MockProvider::always_fail("fallback1"));
        let fb2 = Arc::new(MockProvider::always_fail("fallback2"));
        let provider = FallbackProvider::new(primary, vec![fb1, fb2]);

        let err = provider.complete(mock_request()).await.unwrap_err();
        // Sticky fallback tries in order; when all fail, the last error
        // (from the final fallback tried) is surfaced.
        assert!(err.to_string().contains("fallback2"));
    }

    #[tokio::test]
    async fn no_fallbacks_primary_error_propagated() {
        let primary = Arc::new(MockProvider::always_fail("primary"));
        let provider = FallbackProvider::new(primary, vec![]);

        let err = provider.complete(mock_request()).await.unwrap_err();
        assert!(err.to_string().contains("primary"));
    }

    #[tokio::test]
    async fn stream_primary_fails_fallback_succeeds() {
        let primary = Arc::new(MockProvider::always_fail("primary"));
        let fb1 = Arc::new(MockProvider::always_succeed("fallback1"));
        let provider = FallbackProvider::new(primary, vec![fb1]);

        // The assertion is the unwrap: the fallback stream must succeed. The
        // stream itself is must_use, so discard it explicitly.
        let _ = provider.stream(mock_request()).await.unwrap();
    }

    #[tokio::test]
    async fn stream_all_fail() {
        let primary = Arc::new(MockProvider::always_fail("primary"));
        let fb1 = Arc::new(MockProvider::always_fail("fallback1"));
        let provider = FallbackProvider::new(primary, vec![fb1]);

        match provider.stream(mock_request()).await {
            Ok(_) => panic!("Expected error when all providers fail"),
            Err(e) => assert!(e.to_string().contains("fallback1")),
        }
    }

    #[tokio::test]
    async fn delegates_name_to_primary() {
        let primary = Arc::new(MockProvider::always_succeed("my-primary"));
        let provider = FallbackProvider::new(primary, vec![]);
        assert_eq!(provider.name(), "my-primary");
    }

    #[tokio::test]
    async fn delegates_default_model_to_primary() {
        let primary = Arc::new(MockProvider::always_succeed("p"));
        let provider = FallbackProvider::new(primary, vec![]);
        assert_eq!(provider.default_model(), "mock-model");
    }
}

// --- Vision model ---

mod vision_model {
    use crate::brain::provider::Provider;
    use crate::brain::provider::custom_openai_compatible::OpenAIProvider;

    #[test]
    fn no_vision_model_by_default() {
        let provider = OpenAIProvider::new("test-key".into());
        assert!(!provider.supports_vision());
    }

    #[test]
    fn with_vision_model_enables_vision() {
        let provider =
            OpenAIProvider::new("test-key".into()).with_vision_model("gpt-5-nano".into());
        assert!(provider.supports_vision());
    }

    #[test]
    fn vision_model_accessor() {
        let provider =
            OpenAIProvider::new("test-key".into()).with_vision_model("gpt-5-nano".into());
        assert_eq!(provider.vision_model(), Some("gpt-5-nano"));

        let no_vision = OpenAIProvider::new("test-key".into());
        assert_eq!(no_vision.vision_model(), None);
    }

    #[test]
    fn vision_model_config_roundtrip() {
        let toml_str = r#"
enabled = true
api_key = "test"
default_model = "MiniMax-M2.7"
vision_model = "MiniMax-Text-01"
"#;
        let cfg: crate::config::ProviderConfig = toml::from_str(toml_str).unwrap();
        assert_eq!(cfg.vision_model, Some("MiniMax-Text-01".into()));
        assert_eq!(cfg.default_model, Some("MiniMax-M2.7".into()));
    }

    #[test]
    fn vision_model_absent_in_config() {
        let toml_str = r#"
enabled = true
api_key = "test"
default_model = "gpt-4"
"#;
        let cfg: crate::config::ProviderConfig = toml::from_str(toml_str).unwrap();
        assert!(cfg.vision_model.is_none());
    }

    #[tokio::test]
    async fn factory_config_wires_vision_model() {
        use crate::config::{Config, ProviderConfig, ProviderConfigs};

        let config = Config {
            providers: ProviderConfigs {
                openai: Some(ProviderConfig {
                    enabled: true,
                    api_key: Some("test-key".into()),
                    base_url: None,
                    default_model: Some("gpt-4".into()),
                    models: vec![],
                    vision_model: Some("gpt-5-nano".into()),
                    ..Default::default()
                }),
                ..Default::default()
            },
            ..Default::default()
        };

        let provider = crate::brain::provider::factory::create_provider(&config)
            .await
            .unwrap();
        assert!(provider.supports_vision());
    }

    #[tokio::test]
    async fn factory_config_no_vision_model() {
        use crate::config::{Config, ProviderConfig, ProviderConfigs};

        let config = Config {
            providers: ProviderConfigs {
                openai: Some(ProviderConfig {
                    enabled: true,
                    api_key: Some("test-key".into()),
                    base_url: None,
                    default_model: Some("gpt-4".into()),
                    models: vec![],
                    vision_model: None,
                    ..Default::default()
                }),
                ..Default::default()
            },
            ..Default::default()
        };

        let provider = crate::brain::provider::factory::create_provider(&config)
            .await
            .unwrap();
        assert!(!provider.supports_vision());
    }
}

// --- Factory fallback wiring ---

mod factory_fallback {
    use crate::config::{Config, FallbackProviderConfig, ProviderConfig, ProviderConfigs};

    #[tokio::test]
    async fn no_fallback_returns_primary_directly() {
        let config = Config {
            providers: ProviderConfigs {
                openai: Some(ProviderConfig {
                    enabled: true,
                    api_key: Some("test-key".into()),
                    base_url: None,
                    default_model: None,
                    models: vec![],
                    vision_model: None,
                    ..Default::default()
                }),
                ..Default::default()
            },
            ..Default::default()
        };

        let provider = crate::brain::provider::factory::create_provider(&config)
            .await
            .unwrap();
        assert_eq!(provider.name(), "openai");
    }

    #[tokio::test]
    async fn fallback_disabled_returns_primary_directly() {
        let config = Config {
            providers: ProviderConfigs {
                openai: Some(ProviderConfig {
                    enabled: true,
                    api_key: Some("test-key".into()),
                    base_url: None,
                    default_model: None,
                    models: vec![],
                    vision_model: None,
                    ..Default::default()
                }),
                fallback: Some(FallbackProviderConfig {
                    enabled: false,
                    provider: Some("anthropic".into()),
                    providers: vec![],
                }),
                ..Default::default()
            },
            ..Default::default()
        };

        let provider = crate::brain::provider::factory::create_provider(&config)
            .await
            .unwrap();
        // Should be plain openai, not wrapped in fallback
        assert_eq!(provider.name(), "openai");
    }

    #[tokio::test]
    async fn no_provider_no_fallback_returns_placeholder() {
        let config = Config {
            providers: ProviderConfigs::default(),
            ..Default::default()
        };

        let provider = crate::brain::provider::factory::create_provider(&config)
            .await
            .unwrap();
        assert_eq!(provider.name(), "none");
    }

    #[tokio::test]
    async fn fallback_with_unconfigured_providers_skipped() {
        // Fallback lists providers that don't have API keys — should skip them gracefully
        let config = Config {
            providers: ProviderConfigs {
                fallback: Some(FallbackProviderConfig {
                    enabled: true,
                    provider: None,
                    providers: vec!["anthropic".into(), "openai".into()],
                }),
                ..Default::default()
            },
            ..Default::default()
        };

        // No providers configured at all — should end up with placeholder
        let provider = crate::brain::provider::factory::create_provider(&config)
            .await
            .unwrap();
        assert_eq!(provider.name(), "none");
    }
}

// --- Active provider vision discovery ---

mod active_provider_vision {
    use crate::brain::provider::factory::active_provider_vision;
    use crate::config::{Config, ProviderConfig, ProviderConfigs};

    #[test]
    fn returns_none_when_no_providers() {
        let config = Config::default();
        assert!(active_provider_vision(&config).is_none());
    }

    #[test]
    fn returns_none_when_no_vision_model() {
        let config = Config {
            providers: ProviderConfigs {
                openai: Some(ProviderConfig {
                    enabled: true,
                    api_key: Some("key".into()),
                    base_url: None,
                    default_model: None,
                    models: vec![],
                    vision_model: None,
                    ..Default::default()
                }),
                ..Default::default()
            },
            ..Default::default()
        };
        assert!(active_provider_vision(&config).is_none());
    }

    #[test]
    fn returns_vision_model_from_active_provider() {
        let config = Config {
            providers: ProviderConfigs {
                minimax: Some(ProviderConfig {
                    enabled: true,
                    api_key: Some("minimax-key".into()),
                    base_url: Some("https://api.minimax.io/v1".into()),
                    default_model: Some("MiniMax-M2.7".into()),
                    models: vec![],
                    vision_model: Some("MiniMax-Text-01".into()),
                    ..Default::default()
                }),
                ..Default::default()
            },
            ..Default::default()
        };

        let result = active_provider_vision(&config);
        assert!(result.is_some());
        let (api_key, base_url, vision_model) = result.unwrap();
        assert_eq!(api_key, "minimax-key");
        assert!(base_url.contains("minimax"));
        assert_eq!(vision_model, "MiniMax-Text-01");
    }

    #[test]
    fn skips_disabled_provider() {
        let config = Config {
            providers: ProviderConfigs {
                minimax: Some(ProviderConfig {
                    enabled: false,
                    api_key: Some("key".into()),
                    base_url: Some("https://api.minimax.io/v1".into()),
                    default_model: None,
                    models: vec![],
                    vision_model: Some("MiniMax-Text-01".into()),
                    ..Default::default()
                }),
                ..Default::default()
            },
            ..Default::default()
        };
        assert!(active_provider_vision(&config).is_none());
    }

    #[test]
    fn registers_keyless_provider_with_vision_model() {
        // A keyless / local provider (Ollama, llama.cpp, LM Studio) has no API
        // key but still serves vision. Modelled as a custom provider, which is
        // how a local endpoint is configured, and which becomes active without
        // a key. The gate is `vision_model`, so this resolves with an empty
        // Bearer.
        let mut custom = std::collections::BTreeMap::new();
        custom.insert(
            "localllm".to_string(),
            ProviderConfig {
                enabled: true,
                api_key: None,
                base_url: Some("http://localhost:11434/v1".into()),
                vision_model: Some("llava".into()),
                ..Default::default()
            },
        );
        let config = Config {
            providers: ProviderConfigs {
                custom: Some(custom),
                ..Default::default()
            },
            ..Default::default()
        };
        let (api_key, _, vision_model) = active_provider_vision(&config)
            .expect("keyless provider with vision_model must resolve");
        assert_eq!(api_key, "");
        assert_eq!(vision_model, "llava");
    }

    #[test]
    fn picks_first_provider_with_vision_by_priority() {
        let config = Config {
            providers: ProviderConfigs {
                minimax: Some(ProviderConfig {
                    enabled: true,
                    api_key: Some("minimax-key".into()),
                    base_url: Some("https://api.minimax.io/v1".into()),
                    default_model: None,
                    models: vec![],
                    vision_model: Some("MiniMax-Text-01".into()),
                    ..Default::default()
                }),
                openai: Some(ProviderConfig {
                    enabled: true,
                    api_key: Some("openai-key".into()),
                    base_url: None,
                    default_model: None,
                    models: vec![],
                    vision_model: Some("gpt-5-nano".into()),
                    ..Default::default()
                }),
                ..Default::default()
            },
            ..Default::default()
        };

        let (api_key, _, vision_model) = active_provider_vision(&config).unwrap();
        // Minimax has higher priority
        assert_eq!(api_key, "minimax-key");
        assert_eq!(vision_model, "MiniMax-Text-01");
    }
}

// --- Active provider generation discovery ---
// Mirrors the vision-helper suite above. `generation_model` is the
// 2026-05-18 follow-up so binary users can override the image-gen
// model without leaving the TUI.
mod active_provider_generation {
    use crate::brain::provider::factory::{active_provider_generation, effective_generation_model};
    use crate::config::{Config, ProviderConfig, ProviderConfigs};

    #[test]
    fn returns_none_when_no_generation_model_set() {
        let config = Config::default();
        assert!(active_provider_generation(&config).is_none());
    }

    #[test]
    fn returns_override_from_active_provider() {
        let config = Config {
            providers: ProviderConfigs {
                gemini: Some(ProviderConfig {
                    enabled: true,
                    api_key: Some("gemini-key".into()),
                    base_url: Some("https://generativelanguage.googleapis.com/v1beta".into()),
                    default_model: Some("gemini-3.6-flash".into()),
                    generation_model: Some("imagen-4.0-generate-001".into()),
                    ..Default::default()
                }),
                ..Default::default()
            },
            ..Default::default()
        };
        let (api_key, _, model) = active_provider_generation(&config).expect("must resolve");
        assert_eq!(api_key, "gemini-key");
        assert_eq!(model, "imagen-4.0-generate-001");
    }

    #[test]
    fn registers_keyless_provider_with_generation_model() {
        // Mirror of the vision path: a keyless / local custom provider with a
        // `generation_model` set still resolves, with an empty Bearer.
        let mut custom = std::collections::BTreeMap::new();
        custom.insert(
            "localllm".to_string(),
            ProviderConfig {
                enabled: true,
                api_key: None,
                base_url: Some("http://localhost:11434/v1".into()),
                generation_model: Some("sd-xl".into()),
                ..Default::default()
            },
        );
        let config = Config {
            providers: ProviderConfigs {
                custom: Some(custom),
                ..Default::default()
            },
            ..Default::default()
        };
        let (api_key, _, model) = active_provider_generation(&config)
            .expect("keyless provider with generation_model must resolve");
        assert_eq!(api_key, "");
        assert_eq!(model, "sd-xl");
    }

    #[test]
    fn effective_falls_back_to_global_when_no_override() {
        // Provider has no `generation_model` → fall back to the global
        // `image.generation.model` (whose default is the seeded Gemini
        // value from /onboard).
        let config = Config::default();
        let fallback = effective_generation_model(&config);
        assert_eq!(fallback, config.image.generation.model);
    }

    #[test]
    fn effective_prefers_provider_override_over_global() {
        let config = Config {
            providers: ProviderConfigs {
                gemini: Some(ProviderConfig {
                    enabled: true,
                    api_key: Some("gemini-key".into()),
                    base_url: Some("https://generativelanguage.googleapis.com/v1beta".into()),
                    default_model: Some("gemini-3.6-flash".into()),
                    generation_model: Some("imagen-4.0-generate-001".into()),
                    ..Default::default()
                }),
                ..Default::default()
            },
            ..Default::default()
        };
        assert_eq!(
            effective_generation_model(&config),
            "imagen-4.0-generate-001"
        );
    }
}