use onnx_ir_derive::NodeBuilder;
use crate::ir::Argument;
use crate::ir::{ArgType, DType, Node, RawNode, TensorType};
use crate::processor::{
InputSpec, NodeProcessor, NodeSpec, OutputPreferences, OutputSpec, ProcessError,
};
#[derive(Debug, Clone, new)]
pub struct ArgMinConfig {
pub axis: usize,
pub keepdims: bool,
}
#[derive(Debug, Clone, NodeBuilder)]
pub struct ArgMinNode {
pub name: String,
pub inputs: Vec<Argument>,
pub outputs: Vec<Argument>,
pub config: ArgMinConfig,
}
pub(crate) struct ArgMinProcessor;
impl NodeProcessor for ArgMinProcessor {
type Config = ArgMinConfig;
fn spec(&self) -> NodeSpec {
NodeSpec {
min_opset: 11,
max_opset: None,
inputs: InputSpec::Exact(1),
outputs: OutputSpec::Exact(1),
}
}
fn infer_types(
&self,
node: &mut RawNode,
opset: usize,
_output_preferences: &OutputPreferences,
) -> Result<(), ProcessError> {
let tensor = match &node.inputs[0].ty {
ArgType::Tensor(tensor) => tensor,
_ => {
return Err(ProcessError::TypeMismatch {
expected: "Tensor".to_string(),
actual: format!("{:?}", node.inputs[0].ty),
});
}
};
let config = self
.extract_config(node, opset)
.expect("Config extraction failed");
let keepdims = config.keepdims;
if keepdims {
node.outputs[0].ty = ArgType::Tensor(TensorType {
dtype: DType::I64,
rank: tensor.rank,
static_shape: None,
});
} else if tensor.rank == 1 {
node.outputs[0].ty = ArgType::Scalar(DType::I64);
} else {
node.outputs[0].ty = ArgType::Tensor(TensorType {
dtype: DType::I64,
rank: tensor.rank - 1,
static_shape: None,
});
}
Ok(())
}
fn extract_config(&self, node: &RawNode, _opset: usize) -> Result<Self::Config, ProcessError> {
let tensor = match &node.inputs[0].ty {
ArgType::Tensor(tensor) => tensor,
_ => {
return Err(ProcessError::TypeMismatch {
expected: "Tensor".to_string(),
actual: format!("{:?}", node.inputs[0].ty),
});
}
};
let mut axis: i64 = 0;
let mut keepdims = true;
for (key, value) in node.attrs.iter() {
match key.as_str() {
"axis" => axis = value.clone().into_i64(),
"keepdims" => {
let keepdims_val = value.clone().into_i64();
if keepdims_val != 0 && keepdims_val != 1 {
return Err(ProcessError::InvalidAttribute {
name: "keepdims".to_string(),
reason: "Only keepdims=0 or keepdims=1 is supported for argmin in burn"
.to_string(),
});
}
keepdims = keepdims_val != 0;
}
"select_last_index" => {
if value.clone().into_i64() != 0 {
return Err(ProcessError::InvalidAttribute {
name: "select_last_index".to_string(),
reason: "select_last_index=1 is not supported for argmin in burn"
.to_string(),
});
}
}
_ => {
}
}
}
if axis < 0 {
axis += tensor.rank as i64;
}
let config = ArgMinConfig::new(axis as usize, keepdims);
Ok(config)
}
fn build_node(&self, builder: RawNode, opset: usize) -> Node {
let config = self
.extract_config(&builder, opset)
.expect("Config extraction failed");
Node::ArgMin(ArgMinNode {
name: builder.name,
inputs: builder.inputs,
outputs: builder.outputs,
config,
})
}
}
#[cfg(test)]
mod tests {
#![allow(clippy::bool_assert_comparison)]
use super::*;
use crate::ir::{Argument, DType, NodeType};
use crate::node::test_utils::TestNodeBuilder;
fn create_test_node(axis: i64, select_last_index: i64, keepdims: i64) -> RawNode {
TestNodeBuilder::new(NodeType::ArgMin, "test_argmin")
.input_tensor_f32("data", 3, None)
.output_tensor_i64("output", 3, None)
.attr_int("axis", axis)
.attr_int("select_last_index", select_last_index)
.attr_int("keepdims", keepdims)
.build()
}
#[test]
fn test_argmin_config_basic() {
let mut node = create_test_node(0, 0, 1);
let processor = ArgMinProcessor;
let config = processor.extract_config(&node, 16).unwrap();
let prefs = OutputPreferences::new();
processor.infer_types(&mut node, 16, &prefs).unwrap();
assert_eq!(config.axis, 0);
assert_eq!(config.keepdims, true);
}
#[test]
fn test_argmin_config_negative_axis() {
let mut node = create_test_node(-2, 0, 1);
let processor = ArgMinProcessor;
let config = processor.extract_config(&node, 16).unwrap();
let prefs = OutputPreferences::new();
processor.infer_types(&mut node, 16, &prefs).unwrap();
assert_eq!(config.axis, 1); assert_eq!(config.keepdims, true);
}
#[test]
fn test_argmin_config_multiple_inputs() {
let mut node = create_test_node(0, 0, 1);
node.inputs.push(Argument {
name: "extra".to_string(),
ty: ArgType::Tensor(TensorType {
dtype: DType::F32,
rank: 1,
static_shape: None,
}),
value_source: crate::ir::ValueSource::Dynamic,
value_store: None,
});
let processor = ArgMinProcessor;
let spec = processor.spec();
let result = crate::processor::validate_node_spec(&node, 16, &spec);
assert!(matches!(
result,
Err(ProcessError::InvalidInputCount { .. })
));
}
#[test]
fn test_argmin_config_keepdims_supported() {
let mut node_keepdims_0 = create_test_node(0, 0, 0);
let processor = ArgMinProcessor;
let extracted_config_0 = processor.extract_config(&node_keepdims_0, 16).unwrap();
let prefs = OutputPreferences::new();
processor
.infer_types(&mut node_keepdims_0, 16, &prefs)
.unwrap();
assert_eq!(extracted_config_0.axis, 0);
assert_eq!(extracted_config_0.keepdims, false);
let mut node_keepdims_1 = create_test_node(0, 0, 1);
let processor = ArgMinProcessor;
let extracted_config_1 = processor.extract_config(&node_keepdims_1, 16).unwrap();
let prefs = OutputPreferences::new();
processor
.infer_types(&mut node_keepdims_1, 16, &prefs)
.unwrap();
assert_eq!(extracted_config_1.axis, 0);
assert_eq!(extracted_config_1.keepdims, true);
}
#[test]
fn test_argmin_config_keepdims_invalid() {
let node = create_test_node(0, 0, 2);
let processor = ArgMinProcessor;
let result = processor.extract_config(&node, 16);
assert!(matches!(result, Err(ProcessError::InvalidAttribute { .. })));
}
#[test]
fn test_argmin_config_select_last_index_invalid() {
let node = create_test_node(0, 1, 1);
let processor = ArgMinProcessor;
let result = processor.extract_config(&node, 16);
assert!(matches!(result, Err(ProcessError::InvalidAttribute { .. })));
}
#[test]
fn test_argmin_update_outputs_keepdims_0() {
let mut node = TestNodeBuilder::new(NodeType::ArgMin, "test_argmin_keepdims_0")
.attr_int("axis", 1)
.attr_int("keepdims", 0)
.input_tensor_f32("data", 2, None) .output_tensor_i64("output", 2, None) .build();
let processor = ArgMinProcessor;
let _config = processor.extract_config(&node, 16).unwrap();
let prefs = OutputPreferences::new();
processor.infer_types(&mut node, 16, &prefs).unwrap();
match &node.outputs[0].ty {
ArgType::Tensor(tensor) => {
assert_eq!(tensor.rank, 1);
assert_eq!(tensor.dtype, crate::ir::DType::I64);
}
other => panic!("Expected tensor output, got {:?}", other),
}
}
#[test]
fn test_argmin_update_outputs_keepdims_1() {
let mut node = TestNodeBuilder::new(NodeType::ArgMin, "test_argmin_keepdims_1")
.attr_int("axis", 0)
.attr_int("keepdims", 1)
.input_tensor_f32("data", 3, None) .output_tensor_i64("output", 3, None) .build();
let processor = ArgMinProcessor;
let _config = processor.extract_config(&node, 16).unwrap();
let prefs = OutputPreferences::new();
processor.infer_types(&mut node, 16, &prefs).unwrap();
match &node.outputs[0].ty {
ArgType::Tensor(tensor) => {
assert_eq!(tensor.rank, 3);
assert_eq!(tensor.dtype, crate::ir::DType::I64);
}
other => panic!("Expected tensor output, got {:?}", other),
}
}
#[test]
fn test_argmin_update_outputs_keepdims_0_scalar() {
let mut node = TestNodeBuilder::new(NodeType::ArgMin, "test_argmin_1d_keepdims_0")
.attr_int("axis", 0)
.attr_int("keepdims", 0)
.input_tensor_f32("data", 1, None) .output_tensor_i64("output", 1, None) .build();
let processor = ArgMinProcessor;
let _config = processor.extract_config(&node, 16).unwrap();
let prefs = OutputPreferences::new();
processor.infer_types(&mut node, 16, &prefs).unwrap();
match &node.outputs[0].ty {
ArgType::Scalar(elem_type) => {
assert_eq!(*elem_type, crate::ir::DType::I64);
}
other => panic!("Expected scalar output, got {:?}", other),
}
}
}