onlyne-net 1.4.1

Onlyne v1 transport, TLS identity, admission, and reconnect backoff
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
1177
1178
1179
1180
1181
1182
1183
1184
1185
1186
1187
1188
1189
1190
1191
1192
1193
1194
1195
1196
1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
1207
1208
1209
1210
1211
1212
1213
1214
1215
1216
1217
1218
1219
1220
1221
1222
1223
1224
1225
1226
1227
1228
1229
1230
1231
1232
1233
1234
1235
1236
1237
1238
1239
1240
1241
1242
1243
1244
1245
1246
1247
1248
1249
1250
1251
1252
1253
1254
1255
1256
1257
1258
1259
1260
1261
1262
1263
1264
1265
1266
1267
1268
1269
1270
1271
1272
1273
1274
1275
1276
1277
1278
1279
1280
1281
1282
1283
1284
1285
1286
1287
1288
1289
1290
1291
1292
1293
1294
1295
1296
1297
1298
1299
1300
1301
1302
1303
1304
1305
1306
1307
1308
1309
1310
1311
1312
1313
1314
1315
1316
1317
1318
1319
1320
1321
1322
1323
1324
1325
1326
1327
1328
1329
1330
1331
1332
1333
1334
1335
1336
1337
1338
1339
1340
1341
1342
1343
1344
1345
1346
1347
1348
1349
1350
1351
1352
1353
1354
1355
1356
1357
1358
1359
1360
1361
1362
1363
1364
1365
1366
1367
1368
1369
1370
1371
1372
1373
1374
1375
1376
1377
1378
1379
1380
1381
1382
1383
1384
1385
1386
1387
1388
1389
1390
1391
1392
1393
1394
1395
1396
1397
1398
1399
1400
1401
1402
1403
1404
1405
1406
1407
1408
1409
1410
1411
1412
1413
1414
1415
1416
1417
1418
1419
1420
1421
1422
1423
1424
1425
1426
1427
1428
1429
1430
1431
1432
1433
1434
1435
1436
1437
1438
1439
1440
1441
1442
1443
1444
1445
1446
1447
1448
1449
1450
1451
1452
1453
1454
1455
1456
//! The shared authenticated connection handle used by the client and gateway.
//!
//! A [`ConnHandle`] owns one pinned TLS connection to the server, the ed25519
//! admission handshake, the request/response multiplex, the observation stream,
//! the heartbeat, and the reconnect loop. Callers hold clones of the handle and
//! the task behind it stays shared.
//!
//! Outcomes a caller can tell apart:
//!
//! - `Ok(`[`ResBody`]`)` carries every `res` frame, refusals included. The typed
//!   `ErrorPayload::code` names the refusal, and `ResBody::data` keeps the
//!   earlier receipt that a duplicate `op_id` answer attaches.
//! - [`NetError::Unauthorized`] and [`NetError::ProtocolVersion`] arrive from
//!   admission and mean re-key or upgrade. [`is_permanent`] stops the retry loop
//!   on both of them.
//! - [`NetError::Disconnected`] means the pipe died. The supervisor dials again
//!   under [`Backoff`], and the fresh connection serves the same handle.
//! - [`NetError::NotReady`] means the handle sits between connections.
//! - [`NetError::RequestTimeout`] means the caller's own deadline elapsed.

use onlyne_frame::{is_bad_frame, is_too_large, read_frame, write_frame};
use onlyne_proto::{
    ClientOp, ErrorCode, Event, FaultEvent, Frame, GatewayOp, PROTOCOL_VERSION, ResBody, new_id,
};
use rustls::pki_types::ServerName;
use rustls::{ClientConfig, Error as TlsError, ServerConfig};
use serde::Serialize;
use serde::de::DeserializeOwned;
use std::collections::HashMap;
use std::error::Error as StdError;
use std::net::SocketAddr;
use std::sync::Arc;
use std::sync::atomic::{AtomicU8, AtomicU64, Ordering};
use std::time::Duration;
use tokio::io::{AsyncRead, AsyncWrite};
use tokio::net::{TcpListener, TcpStream};
use tokio::sync::{Mutex, broadcast, mpsc, oneshot};
use tokio_rustls::{TlsAcceptor, TlsConnector};

use crate::NetError;
use crate::backoff::Backoff;
use crate::handshake::{DEFAULT_HANDSHAKE_TIMEOUT, connect_with_timeout};
use crate::identity::KeyPair;
use crate::tls::{PinMismatchMarker, client_config};

/// Handle over a client-vocabulary connection.
pub type ClientConn = ConnHandle<ClientOp>;

/// Handle over a gateway-vocabulary connection.
pub type GatewayConn = ConnHandle<GatewayOp>;

/// Local event queue depth, the `resync_lag` of §4 in the plan.
pub const DEFAULT_RESYNC_LAG: usize = 256;

/// Frames a caller may queue before `request` and `send` apply backpressure.
pub const OUTBOUND_QUEUE_DEPTH: usize = 256;

/// `FaultEvent::kind` of the synthetic frame that reports local event loss.
pub const RESYNC_LAG_KIND: &str = "resync_lag";

/// Reason carried by the `bye` frame that [`ConnHandle::close`] writes.
pub const CLOSE_REASON: &str = "close";

const STATE_READY: u8 = 0;
const STATE_RECONNECTING: u8 = 1;
const STATE_CLOSED: u8 = 2;

/// The client half of a pinned TLS connection.
pub type ClientTls = tokio_rustls::client::TlsStream<TcpStream>;

#[derive(Debug)]
pub enum TlsConn {
    Client(ClientTls),
    Server(tokio_rustls::server::TlsStream<TcpStream>),
}

impl TlsConn {
    pub async fn connect(endpoint: &str, pin: &str) -> Result<Self, NetError> {
        Ok(Self::Client(connect_client(endpoint, pin).await?))
    }

    pub async fn connect_with_config(
        endpoint: &str,
        config: ClientConfig,
    ) -> Result<Self, NetError> {
        Ok(Self::Client(
            connect_client_with_config(endpoint, config).await?,
        ))
    }

    pub async fn send_frame<T: Serialize>(&mut self, value: &T) -> Result<(), NetError> {
        match self {
            Self::Client(stream) => write_frame(stream, value).await,
            Self::Server(stream) => write_frame(stream, value).await,
        }
        .map_err(map_frame_error)
    }

    pub async fn recv_frame<T: DeserializeOwned>(&mut self) -> Result<Option<T>, NetError> {
        match self {
            Self::Client(stream) => read_frame(stream).await,
            Self::Server(stream) => read_frame(stream).await,
        }
        .map_err(map_frame_error)
    }
}

/// The wrapper delegates the byte traits, so `accept`, `read_frame`, and
/// `write_frame` take a `TlsConn` from either side without an inner accessor.
impl AsyncRead for TlsConn {
    fn poll_read(
        mut self: std::pin::Pin<&mut Self>,
        cx: &mut std::task::Context<'_>,
        buf: &mut tokio::io::ReadBuf<'_>,
    ) -> std::task::Poll<std::io::Result<()>> {
        match &mut *self {
            Self::Client(stream) => std::pin::Pin::new(stream).poll_read(cx, buf),
            Self::Server(stream) => std::pin::Pin::new(stream).poll_read(cx, buf),
        }
    }
}

impl AsyncWrite for TlsConn {
    fn poll_write(
        mut self: std::pin::Pin<&mut Self>,
        cx: &mut std::task::Context<'_>,
        buf: &[u8],
    ) -> std::task::Poll<std::io::Result<usize>> {
        match &mut *self {
            Self::Client(stream) => std::pin::Pin::new(stream).poll_write(cx, buf),
            Self::Server(stream) => std::pin::Pin::new(stream).poll_write(cx, buf),
        }
    }

    fn poll_flush(
        mut self: std::pin::Pin<&mut Self>,
        cx: &mut std::task::Context<'_>,
    ) -> std::task::Poll<std::io::Result<()>> {
        match &mut *self {
            Self::Client(stream) => std::pin::Pin::new(stream).poll_flush(cx),
            Self::Server(stream) => std::pin::Pin::new(stream).poll_flush(cx),
        }
    }

    fn poll_shutdown(
        mut self: std::pin::Pin<&mut Self>,
        cx: &mut std::task::Context<'_>,
    ) -> std::task::Poll<std::io::Result<()>> {
        match &mut *self {
            Self::Client(stream) => std::pin::Pin::new(stream).poll_shutdown(cx),
            Self::Server(stream) => std::pin::Pin::new(stream).poll_shutdown(cx),
        }
    }
}

#[derive(Debug)]
pub struct TcpListen {
    listener: TcpListener,
}

impl TcpListen {
    pub async fn bind(listen: &str) -> Result<Self, NetError> {
        let listener = TcpListener::bind(listen).await?;
        Ok(Self { listener })
    }

    pub fn local_addr(&self) -> Result<SocketAddr, NetError> {
        Ok(self.listener.local_addr()?)
    }

    /// Accept one TCP connection without running the TLS handshake.
    ///
    /// Keeping the two steps apart lets a caller serve each handshake on its
    /// own task, so a peer that fails or stalls one connection leaves the
    /// listener accepting (plan §4 line 198).
    pub async fn accept(&mut self) -> Result<TcpStream, NetError> {
        Ok(self.listener.accept().await?.0)
    }

    pub async fn accept_next(&mut self, config: &ServerConfig) -> Result<TlsConn, NetError> {
        let stream = self.accept().await?;
        accept_tls(stream, config).await
    }
}

/// Complete the TLS handshake for one accepted connection.
pub async fn accept_tls(stream: TcpStream, config: &ServerConfig) -> Result<TlsConn, NetError> {
    let acceptor = TlsAcceptor::from(Arc::new(config.clone()));
    acceptor
        .accept(stream)
        .await
        .map(TlsConn::Server)
        .map_err(map_tls_io_error)
}

/// Open a pinned TLS connection and hand back the client stream.
async fn connect_client(endpoint: &str, pin: &str) -> Result<ClientTls, NetError> {
    connect_client_with_config(endpoint, client_config(pin)?).await
}

async fn connect_client_with_config(
    endpoint: &str,
    config: ClientConfig,
) -> Result<ClientTls, NetError> {
    let (host, stream) = connect_tcp(endpoint).await?;
    let server_name = ServerName::try_from(host.clone())
        .map_err(|_| NetError::Io(format!("invalid TLS server name {host}")))?;
    let connector = TlsConnector::from(Arc::new(config));
    connector
        .connect(server_name, stream)
        .await
        .map_err(map_tls_io_error)
}

async fn connect_tcp(endpoint: &str) -> Result<(String, TcpStream), NetError> {
    let (host, _) = if let Ok(address) = endpoint.parse::<SocketAddr>() {
        (address.ip().to_string(), address.port())
    } else {
        let (host, port) = endpoint
            .rsplit_once(':')
            .ok_or_else(|| NetError::Io(format!("invalid endpoint {endpoint}")))?;
        (
            host.trim_matches(['[', ']']).to_string(),
            port.parse::<u16>()
                .map_err(|_| NetError::Io(format!("invalid endpoint {endpoint}")))?,
        )
    };
    let mut addresses = tokio::net::lookup_host(endpoint).await?;
    let address = addresses
        .next()
        .ok_or_else(|| NetError::Io(format!("endpoint {endpoint} has no addresses")))?;
    Ok((host, TcpStream::connect(address).await?))
}

fn map_frame_error(error: std::io::Error) -> NetError {
    if is_too_large(&error) {
        NetError::FrameTooLarge
    } else if is_bad_frame(&error) {
        NetError::BadFrame
    } else {
        NetError::Io(error.to_string())
    }
}

fn map_tls_io_error(error: std::io::Error) -> NetError {
    if let Some(source) = error
        .get_ref()
        .and_then(|source| source.downcast_ref::<TlsError>())
    {
        return map_rustls_error(source);
    }
    NetError::Io(error.to_string())
}

fn map_rustls_error(error: &TlsError) -> NetError {
    if let TlsError::Other(other) = error {
        if let Some(marker) = other
            .source()
            .and_then(|source| source.downcast_ref::<PinMismatchMarker>())
        {
            return NetError::PinMismatch {
                expected: marker.expected.clone(),
                got: marker.got.clone(),
            };
        }
    }
    NetError::Io(error.to_string())
}

/// Connection liveness gate shared by client and gateway callers.
#[derive(Debug, Clone, Copy, PartialEq, Eq)]
pub enum ConnReadiness {
    /// An authenticated connection is live and accepts frames.
    Ready,
    /// The supervisor is dialing again after a death.
    Reconnecting,
    /// The connection ended for good; [`ConnHandle::failure`] carries the reason.
    Closed,
}

/// Everything one connection needs beyond its endpoint and identity.
#[derive(Debug, Clone)]
pub struct ConnSettings {
    /// Protocol revision sent in the `hello` challenge response.
    pub protocol: u16,
    /// Software name recorded for fault triage.
    pub agent: String,
    pub version: String,
    /// True when this connection serves an aggregate role.
    pub aggregate: bool,
    /// Interval between `ping` frames.
    pub heartbeat: Duration,
    /// Local event queue depth. Values below two are raised to two.
    pub resync_lag: usize,
    /// Delay schedule for redialing after a death.
    pub backoff: Backoff,
    /// Bound on the admission handshake.
    pub handshake_timeout: Duration,
}

impl Default for ConnSettings {
    fn default() -> Self {
        Self {
            protocol: PROTOCOL_VERSION,
            agent: "onlyne-net".to_string(),
            version: env!("CARGO_PKG_VERSION").to_string(),
            aggregate: false,
            heartbeat: Duration::from_secs(10),
            resync_lag: DEFAULT_RESYNC_LAG,
            backoff: Backoff::new(),
            handshake_timeout: DEFAULT_HANDSHAKE_TIMEOUT,
        }
    }
}

impl ConnSettings {
    /// Settings for a given protocol revision and every other default.
    pub fn new(protocol: u16) -> Self {
        Self {
            protocol,
            ..Self::default()
        }
    }

    /// A ping waits this long for its `pong` before the connection counts dead.
    pub fn pong_deadline(&self) -> Duration {
        self.heartbeat.saturating_mul(2)
    }
}

/// Shared handle over one authenticated, reconnecting connection.
///
/// The observation stream is a `broadcast` channel, so the op payload carries
/// `Clone` beside the serde bounds. `ClientOp`, `GatewayOp`, and `AdminOp` all
/// implement it, and each subscriber clones one frame per delivery.
pub struct ConnHandle<Op: Serialize + DeserializeOwned + Clone + Send + Sync + 'static> {
    inner: Arc<ConnInner<Op>>,
}

impl<Op: Serialize + DeserializeOwned + Clone + Send + Sync + 'static> Clone for ConnHandle<Op> {
    fn clone(&self) -> Self {
        Self {
            inner: Arc::clone(&self.inner),
        }
    }
}

impl<Op: Serialize + DeserializeOwned + Clone + Send + Sync + 'static> std::fmt::Debug
    for ConnHandle<Op>
{
    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
        f.debug_struct("ConnHandle")
            .field("role", &self.inner.role)
            .field("readiness", &self.inner.readiness())
            .finish()
    }
}

impl<Op: Serialize + DeserializeOwned + Clone + Send + Sync + 'static> ConnHandle<Op> {
    /// Adopt an already-connected stream and serve it with the shared loop.
    ///
    /// The caller owns admission: run `handshake::accept` or `handshake::connect`
    /// on the stream first when the surface is keyed. This is the unix-socket and
    /// in-process shape, where `dial`'s TLS and `cert_pin` do not apply. An
    /// attached stream carries no redial plan, so its first death stops the
    /// handle as `Closed` with the reason in `failure`.
    pub fn attach<S>(stream: S, role: &str, settings: ConnSettings) -> Self
    where
        S: AsyncRead + AsyncWrite + Unpin + Send + 'static,
    {
        let settings = ConnSettings {
            resync_lag: settings.resync_lag.max(2),
            ..settings
        };
        spawn_handle(
            stream,
            role,
            &settings,
            AdoptedPlan {
                marker: std::marker::PhantomData,
            },
        )
    }

    /// Role name this connection authenticated as.
    pub fn role(&self) -> &str {
        &self.inner.role
    }

    /// Current liveness of the connection behind this handle.
    pub fn readiness(&self) -> ConnReadiness {
        self.inner.readiness()
    }

    /// Terminal failure, once the supervisor stopped for good.
    pub async fn failure(&self) -> Option<NetError> {
        self.inner.failure.lock().await.clone()
    }

    /// Subscribe to the observation stream. Every consumer holds its own receiver
    /// over the one bounded queue inside this handle.
    pub fn events(&self) -> broadcast::Receiver<Frame<Op>> {
        self.inner.events.subscribe()
    }

    /// Write one request, register a waiter by its `id`, then await the answer.
    ///
    /// The frame keeps a caller-supplied id and receives a generated one when the
    /// id is empty. `BadFrame` answers any frame that opens no request.
    pub async fn request(&self, frame: Frame<Op>, timeout: Duration) -> Result<ResBody, NetError> {
        let frame = assign_id(frame)?;
        let id = frame.id().ok_or(NetError::BadFrame)?.to_string();
        let (waiter, answer) = oneshot::channel();
        {
            let mut pending = self.inner.pending.lock().await;
            pending.insert(id.clone(), waiter);
        }
        if let Err(error) = self.write(frame).await {
            self.inner.pending.lock().await.remove(&id);
            return Err(error);
        }
        match tokio::time::timeout(timeout, answer).await {
            Ok(Ok(Ok(body))) => Ok(body),
            Ok(_) => Err(NetError::Disconnected(
                "the connection died while this request was in flight".to_string(),
            )),
            Err(_) => {
                self.inner.pending.lock().await.remove(&id);
                Err(NetError::RequestTimeout)
            }
        }
    }

    /// Write one frame without registering a waiter.
    pub async fn send(&self, frame: Frame<Op>) -> Result<(), NetError> {
        self.write(assign_id(frame)?).await
    }

    /// Write a `bye` frame and complete every in-flight waiter as a failure.
    pub async fn close(&self) -> Result<(), NetError> {
        self.inner
            .stop(Some(NetError::Disconnected(
                "the handle closed the connection".to_string(),
            )))
            .await;
        let bye = Frame::Bye {
            reason: CLOSE_REASON.to_string(),
        };
        if self.inner.outbound.send(bye).await.is_ok() {
            Ok(())
        } else {
            Err(NetError::Disconnected(
                "the connection task stopped".to_string(),
            ))
        }
    }

    /// Gate one frame on readiness, then queue it for the connection task.
    async fn write(&self, frame: Frame<Op>) -> Result<(), NetError> {
        match self.inner.readiness() {
            ConnReadiness::Ready => {}
            ConnReadiness::Reconnecting => return Err(NetError::NotReady),
            ConnReadiness::Closed => {
                return Err(self
                    .inner
                    .failure
                    .lock()
                    .await
                    .clone()
                    .unwrap_or(NetError::NotReady));
            }
        }
        self.inner
            .outbound
            .send(frame)
            .await
            .map_err(|_| NetError::Disconnected("the connection task stopped".to_string()))
    }
}

/// Give a request frame an `id`, so the server can match its answer.
///
/// Any other frame without an id passes through untouched.
fn assign_id<Op>(frame: Frame<Op>) -> Result<Frame<Op>, NetError> {
    match frame {
        Frame::Req { id, op } if id.is_empty() => Ok(Frame::Req { id: new_id(), op }),
        other => Ok(other),
    }
}

struct ConnInner<Op> {
    role: String,
    outbound: mpsc::Sender<Frame<Op>>,
    events: broadcast::Sender<Frame<Op>>,
    pending: Mutex<HashMap<String, oneshot::Sender<Result<ResBody, NetError>>>>,
    failure: Mutex<Option<NetError>>,
    state: AtomicU8,
    /// Newest `ev` sequence seen, echoed as `pong.server_seq`.
    cursor: AtomicU64,
    /// Events evicted from the local queue since the last report.
    dropped: AtomicU64,
    resync_lag: usize,
}

impl<Op> ConnInner<Op> {
    fn readiness(&self) -> ConnReadiness {
        match self.state.load(Ordering::SeqCst) {
            STATE_READY => ConnReadiness::Ready,
            STATE_RECONNECTING => ConnReadiness::Reconnecting,
            _ => ConnReadiness::Closed,
        }
    }

    fn set_state(&self, state: u8) {
        self.state.store(state, Ordering::SeqCst);
    }

    fn is_stopped(&self) -> bool {
        self.state.load(Ordering::SeqCst) == STATE_CLOSED
    }

    /// Stop for good, recording the reason callers read from `failure`.
    async fn stop(&self, error: Option<NetError>) {
        let error = error.unwrap_or(NetError::Disconnected("the connection closed".to_string()));
        *self.failure.lock().await = Some(error.clone());
        self.set_state(STATE_CLOSED);
        fail_pending(self, error).await;
    }
}

/// How one handle opens each connection after the first.
///
/// `dial` redials its endpoint and runs the `hello` exchange again. A stream the
/// caller adopted carries no redial plan, so its first death stops the handle.
trait Reopen {
    type Stream: AsyncRead + AsyncWrite + Unpin + Send + 'static;

    /// Whether a death can be followed by another connection.
    fn can_redial(&self) -> bool;

    /// Open the next connection.
    fn reopen(&mut self) -> impl Future<Output = Result<Self::Stream, NetError>> + Send;
}

/// One dial plan, reused by every reconnect attempt.
struct DialPlan {
    endpoint: String,
    pin: String,
    role: String,
    keys: KeyPair,
    settings: ConnSettings,
}

impl Reopen for DialPlan {
    type Stream = ClientTls;

    fn can_redial(&self) -> bool {
        true
    }

    async fn reopen(&mut self) -> Result<ClientTls, NetError> {
        establish(self).await
    }
}

/// An already-connected stream, adopted by its caller.
struct AdoptedPlan<S> {
    marker: std::marker::PhantomData<S>,
}

impl<S: AsyncRead + AsyncWrite + Unpin + Send + 'static> Reopen for AdoptedPlan<S> {
    type Stream = S;

    fn can_redial(&self) -> bool {
        false
    }

    async fn reopen(&mut self) -> Result<S, NetError> {
        Err(NetError::Disconnected(
            "the attached stream has no redial".to_string(),
        ))
    }
}

/// Dial an endpoint, verify its pin, finish the `hello` exchange, then serve one
/// shared connection through the returned handle.
///
/// The handle comes back ready. A later death starts the reconnect loop inside
/// the supervisor task, and `request` answers `NetError::NotReady` while that
/// loop dials.
pub async fn dial<Op>(
    endpoint: &str,
    keypair: &KeyPair,
    expected_pin: &str,
    role: &str,
    settings: ConnSettings,
) -> Result<ConnHandle<Op>, NetError>
where
    Op: Serialize + DeserializeOwned + Clone + Send + Sync + 'static,
{
    let settings = ConnSettings {
        resync_lag: settings.resync_lag.max(2),
        ..settings
    };
    let plan = DialPlan {
        endpoint: endpoint.to_string(),
        pin: expected_pin.to_string(),
        role: role.to_string(),
        keys: keypair.clone(),
        settings,
    };
    let stream = establish(&plan).await?;
    let settings = plan.settings.clone();
    Ok(spawn_handle(stream, role, &settings, plan))
}

/// Build the shared channel state, then start the connection task.
fn spawn_handle<P, Op>(
    stream: P::Stream,
    role: &str,
    settings: &ConnSettings,
    plan: P,
) -> ConnHandle<Op>
where
    P: Reopen + Send + 'static,
    Op: Serialize + DeserializeOwned + Clone + Send + Sync + 'static,
{
    let (outbound, outbound_rx) = mpsc::channel(OUTBOUND_QUEUE_DEPTH);
    let (events, _) = broadcast::channel(settings.resync_lag);
    let inner = Arc::new(ConnInner {
        role: role.to_string(),
        outbound,
        events,
        pending: Mutex::new(HashMap::new()),
        failure: Mutex::new(None),
        state: AtomicU8::new(STATE_READY),
        cursor: AtomicU64::new(0),
        dropped: AtomicU64::new(0),
        resync_lag: settings.resync_lag,
    });
    tokio::spawn(run_supervisor(
        stream,
        Arc::clone(&inner),
        outbound_rx,
        settings.clone(),
        plan,
    ));
    ConnHandle { inner }
}

/// Open one authenticated connection: pinned TLS, then the `hello` challenge.
async fn establish(plan: &DialPlan) -> Result<ClientTls, NetError> {
    let mut stream = connect_client(&plan.endpoint, &plan.pin).await?;
    let ack = connect_with_timeout(
        &mut stream,
        &plan.role,
        &plan.keys,
        plan.settings.protocol,
        &plan.settings.agent,
        &plan.settings.version,
        plan.settings.aggregate,
        plan.settings.handshake_timeout,
    )
    .await?;
    if !ack.ok {
        return Err(NetError::Rejected {
            code: "rejected".to_string(),
            message: "the server refused the hello".to_string(),
        });
    }
    if ack.role != plan.role {
        return Err(NetError::Unauthorized(format!(
            "the server bound this connection to role {}, not {}",
            ack.role, plan.role
        )));
    }
    Ok(stream)
}

/// Report whether a failure must surface to the caller with no retry.
///
/// `protocol_version` and `unauthorized` reach the caller directly, so a caller
/// can re-key. A closed handshake and any bare `rejected` answer count as
/// admission refusals too.
pub fn is_permanent(error: &NetError) -> bool {
    match error {
        NetError::ProtocolVersion { .. }
        | NetError::Unauthorized(_)
        | NetError::PinMismatch { .. }
        | NetError::MalformedKey(_)
        | NetError::Crypto(_) => true,
        NetError::Rejected { code, .. } => {
            code == ErrorCode::Unauthorized.as_str()
                || code == ErrorCode::ProtocolVersion.as_str()
                || code == "rejected"
        }
        NetError::HandshakeTimeout
        | NetError::RequestTimeout
        | NetError::NotReady
        | NetError::Disconnected(_)
        | NetError::FrameTooLarge
        | NetError::BadFrame
        | NetError::Io(_) => false,
    }
}

/// Read the evicted-event count carried by a synthetic resync frame.
///
/// The count sits in the frame's `seq` field, and matches `FaultEvent::seq`.
pub fn resync_lag_of<Op>(frame: &Frame<Op>) -> Option<u64> {
    match frame {
        Frame::Ev { seq, event } => match event.as_ref() {
            Event::Fault(fault) if fault.kind == RESYNC_LAG_KIND => Some(*seq),
            _ => None,
        },
        _ => None,
    }
}

/// How one session ended.
enum SessionEnd {
    /// Local `close` or a peer `bye`: the connection ended on purpose.
    Closed(String),
    /// The transport died; the supervisor dials again.
    Dead(NetError),
}

/// Serve one live session, then report how it ended.
async fn run_session<S, Op>(
    stream: &mut S,
    inner: &Arc<ConnInner<Op>>,
    outbound: &mut mpsc::Receiver<Frame<Op>>,
    settings: &ConnSettings,
) -> SessionEnd
where
    S: AsyncRead + AsyncWrite + Unpin,
    Op: Serialize + DeserializeOwned + Clone + Send + Sync + 'static,
{
    let mut heartbeat = tokio::time::interval_at(
        tokio::time::Instant::now() + settings.heartbeat,
        settings.heartbeat,
    );
    heartbeat.set_missed_tick_behavior(tokio::time::MissedTickBehavior::Delay);
    let mut ping_sent: Option<tokio::time::Instant> = None;
    loop {
        tokio::select! {
            outgoing = outbound.recv() => {
                let Some(frame) = outgoing else {
                    return SessionEnd::Closed("the handle dropped".to_string());
                };
                let bye = matches!(frame, Frame::Bye { .. });
                if let Err(error) = write_frame(stream, &frame).await.map_err(map_frame_error) {
                    return SessionEnd::Dead(error);
                }
                if bye {
                    return SessionEnd::Closed("the handle closed the connection".to_string());
                }
            }
            incoming = read_frame::<_, Frame<Op>>(stream) => {
                let frame = match incoming {
                    Ok(Some(frame)) => frame,
                    Ok(None) => {
                        return SessionEnd::Dead(NetError::Disconnected(
                            "the peer closed the connection".to_string(),
                        ));
                    }
                    Err(error) => return SessionEnd::Dead(map_frame_error(error)),
                };
                match frame {
                    Frame::Res { id, body } => settle(inner, &id, body).await,
                    Frame::Ev { seq, event } => {
                        inner.cursor.store(seq, Ordering::SeqCst);
                        publish(inner, Frame::Ev { seq, event });
                    }
                    // The observation cursor travels on `pong`, so subscribers
                    // see it and can ask for a resync from the last good `seq`.
                    Frame::Pong { t, server_seq } => {
                        ping_sent = None;
                        publish(inner, Frame::Pong { t, server_seq });
                    }
                    Frame::Ack { seq } => publish(inner, Frame::Ack { seq }),
                    Frame::Ping { t } => {
                        let pong: Frame<Op> = Frame::Pong {
                            t,
                            server_seq: inner.cursor.load(Ordering::SeqCst),
                        };
                        if let Err(error) = write_frame(stream, &pong).await.map_err(map_frame_error) {
                            return SessionEnd::Dead(error);
                        }
                    }
                    Frame::Bye { reason } => {
                        return SessionEnd::Closed(format!("the peer said bye: {reason}"));
                    }
                    Frame::Req { .. } => {}
                }
            }
            _ = heartbeat.tick() => {
                match ping_sent {
                    Some(sent) if sent.elapsed() >= settings.pong_deadline() => {
                        return SessionEnd::Dead(NetError::Disconnected(format!(
                            "no pong within {:?}",
                            settings.pong_deadline()
                        )));
                    }
                    Some(_) => {}
                    None => {
                        ping_sent = Some(tokio::time::Instant::now());
                        let ping: Frame<Op> = Frame::Ping { t: now_ms() };
                        if let Err(error) = write_frame(stream, &ping).await.map_err(map_frame_error) {
                            return SessionEnd::Dead(error);
                        }
                    }
                }
                report_lag(inner);
            }
        }
    }
}

/// Keep one connection alive, redialing under `Backoff` after every death.
async fn run_supervisor<S, P, Op>(
    mut stream: S,
    inner: Arc<ConnInner<Op>>,
    mut outbound: mpsc::Receiver<Frame<Op>>,
    settings: ConnSettings,
    mut plan: P,
) where
    S: AsyncRead + AsyncWrite + Unpin,
    P: Reopen<Stream = S>,
    Op: Serialize + DeserializeOwned + Clone + Send + Sync + 'static,
{
    let mut backoff = settings.backoff.clone();
    loop {
        match run_session(&mut stream, &inner, &mut outbound, &settings).await {
            SessionEnd::Closed(reason) => {
                inner.stop(Some(NetError::Disconnected(reason))).await;
                return;
            }
            SessionEnd::Dead(error) => {
                inner.set_state(STATE_RECONNECTING);
                fail_pending(&inner, error.clone()).await;
                drain(&mut outbound);
                if !plan.can_redial() {
                    inner
                        .stop(Some(NetError::Disconnected(format!(
                            "{error}; the attached stream has no redial"
                        ))))
                        .await;
                    return;
                }
                loop {
                    if inner.is_stopped() {
                        return;
                    }
                    tokio::time::sleep(backoff.next()).await;
                    if inner.is_stopped() {
                        return;
                    }
                    match plan.reopen().await {
                        Ok(fresh) => {
                            backoff.reset();
                            stream = fresh;
                            inner.set_state(STATE_READY);
                            break;
                        }
                        Err(error) => {
                            if is_permanent(&error) {
                                inner.stop(Some(error)).await;
                                return;
                            }
                        }
                    }
                }
            }
        }
    }
}

/// Drop the frames that belonged to the dead connection.
fn drain<Op>(outbound: &mut mpsc::Receiver<Frame<Op>>) {
    while outbound.try_recv().is_ok() {}
}

/// Hand one `res` body to its waiter.
async fn settle<Op>(inner: &ConnInner<Op>, id: &str, body: ResBody) {
    let waiter = inner.pending.lock().await.remove(id);
    if let Some(waiter) = waiter {
        let _ = waiter.send(Ok(body));
    }
}

async fn fail_pending<Op>(inner: &ConnInner<Op>, error: NetError) {
    let mut pending = inner.pending.lock().await;
    for (_, waiter) in pending.drain() {
        let _ = waiter.send(Err(error.clone()));
    }
}

/// Push one observation frame into the bounded local queue.
///
/// The queue holds `resync_lag` frames for the slowest subscriber. Writing into
/// a full queue evicts that subscriber's oldest frame, so the eviction is
/// counted and the next frame with room reports it once.
fn publish<Op: Clone>(inner: &ConnInner<Op>, frame: Frame<Op>) {
    if inner.events.len() >= inner.resync_lag {
        inner.dropped.fetch_add(1, Ordering::SeqCst);
    }
    report_lag(inner);
    let _ = inner.events.send(frame);
}

/// Report accumulated evictions as one synthetic `resync_lag` frame.
///
/// Two free queue slots are required, so the report and the frame behind it both
/// survive the write.
fn report_lag<Op: Clone>(inner: &ConnInner<Op>) {
    if inner.dropped.load(Ordering::SeqCst) == 0 || inner.events.len() + 2 > inner.resync_lag {
        return;
    }
    let lag = inner.dropped.swap(0, Ordering::SeqCst);
    let _ = inner.events.send(resync_frame(lag));
}

/// One synthetic frame carrying the number of events a subscriber lost.
fn resync_frame<Op>(dropped: u64) -> Frame<Op> {
    Frame::Ev {
        seq: dropped,
        event: Box::new(Event::Fault(FaultEvent {
            kind: RESYNC_LAG_KIND.to_string(),
            reason: format!("{dropped} events fell out of the local queue"),
            seq: Some(dropped),
            ..FaultEvent::default()
        })),
    }
}

fn now_ms() -> i64 {
    std::time::SystemTime::now()
        .duration_since(std::time::UNIX_EPOCH)
        .map(|elapsed| elapsed.as_millis() as i64)
        .unwrap_or(0)
}

#[cfg(test)]
mod tests {
    use super::*;
    use crate::acl::AclTable;
    use crate::handshake::accept;
    use crate::tls::{gen_self_signed, server_config};
    use onlyne_proto::{AckArgs, SpecReloaded};
    use serde_json::json;
    use tokio::sync::oneshot;

    const ROLE: &str = "worker";

    /// One loopback listener carrying a fresh pinned certificate.
    struct Harness {
        listener: TcpListen,
        config: ServerConfig,
        pin: String,
        address: String,
    }

    async fn harness() -> Harness {
        let cert = gen_self_signed("127.0.0.1", 1).unwrap();
        let config = server_config(&cert).unwrap();
        let listener = TcpListen::bind("127.0.0.1:0").await.unwrap();
        let address = listener.local_addr().unwrap().to_string();
        Harness {
            listener,
            config,
            pin: cert.spki_pin,
            address,
        }
    }

    fn settings() -> ConnSettings {
        ConnSettings {
            heartbeat: Duration::from_secs(30),
            backoff: Backoff::with_limits(Duration::from_millis(10), Duration::from_millis(20)),
            ..ConnSettings::default()
        }
    }

    fn table(keys: &[&KeyPair]) -> AclTable {
        AclTable::new(
            keys.iter()
                .map(|key| (ROLE.to_string(), key.public_str(), false)),
            Vec::new(),
        )
        .unwrap()
    }

    fn request() -> Frame<ClientOp> {
        Frame::req(
            String::new(),
            ClientOp::Ack(AckArgs {
                msg_id: "m1".to_string(),
                op_id: None,
                accepted: true,
                reason: None,
            }),
        )
    }

    fn reload(hash: &str) -> Event {
        Event::SpecReloaded(SpecReloaded {
            spec_hash: hash.to_string(),
            roles: 1,
            gateways: 0,
            routes: 0,
        })
    }

    /// Accept one connection and admit it through the real challenge handshake.
    async fn admit(
        listener: &mut TcpListen,
        config: &ServerConfig,
        table: &AclTable,
    ) -> Option<TlsConn> {
        let mut stream = listener.accept_next(config).await.ok()?;
        accept(&mut stream, table, PROTOCOL_VERSION).await.ok()?;
        Some(stream)
    }

    fn event_seq(frame: &Frame<ClientOp>) -> u64 {
        match frame {
            Frame::Ev { seq, .. } => *seq,
            other => panic!("expected an event frame, got {other:?}"),
        }
    }

    async fn wait_for_failure(handle: &ClientConn) -> NetError {
        for _ in 0..300 {
            if let Some(error) = handle.failure().await {
                return error;
            }
            tokio::time::sleep(Duration::from_millis(10)).await;
        }
        panic!("the handle never reported a failure");
    }

    #[tokio::test]
    async fn authenticated_round_trip() {
        let Harness {
            mut listener,
            config,
            pin,
            address,
        } = harness().await;
        let key = KeyPair::from_seed([41; 32]);
        let table = table(&[&key]);
        let server = tokio::spawn(async move {
            let mut stream = admit(&mut listener, &config, &table)
                .await
                .expect("the client is admitted");
            let request: Frame<ClientOp> = read_frame(&mut stream).await.unwrap().unwrap();
            let id = request.id().expect("a request id").to_string();
            assert!(!id.is_empty(), "dial fills an empty request id");
            write_frame(&mut stream, &Frame::ok(id, json!({"roles": ["worker"]})))
                .await
                .unwrap();
        });

        let handle: ClientConn = dial(&address, &key, &pin, ROLE, settings()).await.unwrap();
        assert_eq!(handle.role(), ROLE);
        assert_eq!(handle.readiness(), ConnReadiness::Ready);
        let body = handle
            .request(request(), Duration::from_secs(5))
            .await
            .unwrap();
        assert!(body.ok);
        assert!(body.error.is_none());
        assert_eq!(body.data().unwrap()["roles"][0], "worker");
        server.await.unwrap();
    }

    #[tokio::test]
    async fn wrong_pin_refuses_to_connect() {
        let Harness {
            mut listener,
            config,
            pin,
            address,
        } = harness().await;
        let key = KeyPair::from_seed([42; 32]);
        let table = table(&[&key]);
        let wrong = format!("sha256/{}", "A".repeat(43));
        let server = tokio::spawn(async move {
            let _ = admit(&mut listener, &config, &table).await;
        });

        let error = dial::<ClientOp>(&address, &key, &wrong, ROLE, settings())
            .await
            .unwrap_err();
        match error {
            NetError::PinMismatch { expected, got } => {
                assert_eq!(expected, wrong);
                assert_eq!(got, pin);
            }
            other => panic!("expected a pin mismatch, got {other:?}"),
        }
        server.await.unwrap();
    }

    #[tokio::test]
    async fn unregistered_key_is_refused_at_hello() {
        let Harness {
            mut listener,
            config,
            pin,
            address,
        } = harness().await;
        let registered = KeyPair::from_seed([43; 32]);
        let foreign = KeyPair::from_seed([44; 32]);
        let table = table(&[&registered]);
        let server = tokio::spawn(async move {
            let _ = admit(&mut listener, &config, &table).await;
        });

        let error = dial::<ClientOp>(&address, &foreign, &pin, ROLE, settings())
            .await
            .unwrap_err();
        assert!(
            matches!(&error, NetError::Rejected { code, .. } if code == "unauthorized"),
            "expected an unauthorized refusal, got {error:?}"
        );
        assert!(is_permanent(&error));
        server.await.unwrap();
    }

    #[tokio::test]
    async fn event_during_request_keeps_both_in_order() {
        let Harness {
            mut listener,
            config,
            pin,
            address,
        } = harness().await;
        let key = KeyPair::from_seed([45; 32]);
        let table = table(&[&key]);
        let server = tokio::spawn(async move {
            let mut stream = admit(&mut listener, &config, &table)
                .await
                .expect("the client is admitted");
            let request: Frame<ClientOp> = read_frame(&mut stream).await.unwrap().unwrap();
            let id = request.id().unwrap().to_string();
            write_frame(&mut stream, &Frame::event(41, reload("first")))
                .await
                .unwrap();
            write_frame(&mut stream, &Frame::event(42, reload("second")))
                .await
                .unwrap();
            write_frame(&mut stream, &Frame::ok(id, json!({"settled": true})))
                .await
                .unwrap();
        });

        let handle: ClientConn = dial(&address, &key, &pin, ROLE, settings()).await.unwrap();
        let mut events = handle.events();
        let body = handle
            .request(request(), Duration::from_secs(5))
            .await
            .unwrap();
        assert_eq!(body.data().unwrap()["settled"], true);
        for (seq, hash) in [(41u64, "first"), (42, "second")] {
            match events.recv().await.unwrap() {
                Frame::Ev { seq: seen, event } => match event.as_ref() {
                    Event::SpecReloaded(spec) => {
                        assert_eq!(seen, seq);
                        assert_eq!(spec.spec_hash, hash);
                    }
                    other => panic!("expected a spec reload event, got {other:?}"),
                },
                other => panic!("expected event {seq}, got {other:?}"),
            }
        }
        server.await.unwrap();
    }

    #[tokio::test]
    async fn queue_overflow_reports_the_drop_count_once() {
        let Harness {
            mut listener,
            config,
            pin,
            address,
        } = harness().await;
        let key = KeyPair::from_seed([46; 32]);
        let table = table(&[&key]);
        let (release, hold) = oneshot::channel::<()>();
        let server = tokio::spawn(async move {
            let mut stream = admit(&mut listener, &config, &table)
                .await
                .expect("the client is admitted");
            let request: Frame<ClientOp> = read_frame(&mut stream).await.unwrap().unwrap();
            let id = request.id().unwrap().to_string();
            for seq in 1..=5 {
                write_frame(&mut stream, &Frame::event(seq, reload("flood")))
                    .await
                    .unwrap();
            }
            write_frame(&mut stream, &Frame::ok(id, json!({"seen": 5})))
                .await
                .unwrap();
            hold.await.unwrap();
            write_frame(&mut stream, &Frame::event(6, reload("after")))
                .await
                .unwrap();
        });

        let settings = ConnSettings {
            resync_lag: 2,
            ..settings()
        };
        let handle: ClientConn = dial(&address, &key, &pin, ROLE, settings).await.unwrap();
        let mut events = handle.events();
        let body = handle
            .request(request(), Duration::from_secs(5))
            .await
            .unwrap();
        assert_eq!(
            body.data().unwrap()["seen"],
            5,
            "the answer lands after the five events"
        );
        match events.recv().await {
            Err(broadcast::error::RecvError::Lagged(skipped)) => assert_eq!(skipped, 3),
            other => panic!("expected a lagged receiver, got {other:?}"),
        }
        assert_eq!(event_seq(&events.recv().await.unwrap()), 4);
        assert_eq!(event_seq(&events.recv().await.unwrap()), 5);
        release.send(()).unwrap();
        let report = events.recv().await.unwrap();
        assert_eq!(resync_lag_of(&report), Some(3));
        assert_eq!(event_seq(&events.recv().await.unwrap()), 6);
        server.await.unwrap();
    }

    #[tokio::test]
    async fn missing_pong_ends_the_connection() {
        let Harness {
            mut listener,
            config,
            pin,
            address,
        } = harness().await;
        let key = KeyPair::from_seed([47; 32]);
        let table = table(&[&key]);
        let (release, hold) = oneshot::channel::<()>();
        let server = tokio::spawn(async move {
            let stream = admit(&mut listener, &config, &table)
                .await
                .expect("the client is admitted");
            let _ = hold.await;
            drop(stream);
        });

        let settings = ConnSettings {
            heartbeat: Duration::from_millis(40),
            ..settings()
        };
        let handle: ClientConn = dial(&address, &key, &pin, ROLE, settings).await.unwrap();
        let waiter = handle.clone();
        let pending =
            tokio::spawn(async move { waiter.request(request(), Duration::from_secs(10)).await });
        let outcome = tokio::time::timeout(Duration::from_secs(3), pending)
            .await
            .expect("the death completes the waiter")
            .unwrap();
        assert!(
            matches!(outcome, Err(NetError::Disconnected(_))),
            "expected a disconnect, got {outcome:?}"
        );
        assert_ne!(handle.readiness(), ConnReadiness::Ready);
        let _ = handle.close().await;
        release.send(()).unwrap();
        server.await.unwrap();
    }

    #[tokio::test]
    async fn permanent_refusal_stops_the_retry_loop() {
        let Harness {
            mut listener,
            config,
            pin,
            address,
        } = harness().await;
        let key = KeyPair::from_seed([48; 32]);
        let admitted = table(&[&key]);
        let stranger = AclTable::new(Vec::<(String, String, bool)>::new(), Vec::new()).unwrap();
        let (seen, mut attempts) = mpsc::channel::<u32>(4);
        let server = tokio::spawn(async move {
            let first = admit(&mut listener, &config, &admitted)
                .await
                .expect("the first admission succeeds");
            seen.send(1).await.unwrap();
            drop(first);
            let second = admit(&mut listener, &config, &stranger).await;
            seen.send(2).await.unwrap();
            drop(second);
            let third =
                tokio::time::timeout(Duration::from_millis(600), listener.accept_next(&config))
                    .await;
            seen.send(if third.is_ok() { 3 } else { 0 }).await.unwrap();
        });

        let handle: ClientConn = dial(&address, &key, &pin, ROLE, settings()).await.unwrap();
        assert_eq!(attempts.recv().await.unwrap(), 1);
        let failure = wait_for_failure(&handle).await;
        assert!(
            matches!(&failure, NetError::Rejected { code, .. } if code == "unauthorized"),
            "expected the unauthorized refusal, got {failure:?}"
        );
        assert_eq!(handle.readiness(), ConnReadiness::Closed);
        assert_eq!(attempts.recv().await.unwrap(), 2);
        assert_eq!(attempts.recv().await.unwrap(), 0, "no third dial");
        let refused = handle
            .request(request(), Duration::from_secs(1))
            .await
            .unwrap_err();
        assert!(
            matches!(&refused, NetError::Rejected { code, .. } if code == "unauthorized"),
            "expected the refusal to reach the caller, got {refused:?}"
        );
        server.await.unwrap();
    }

    #[tokio::test]
    async fn close_says_bye_and_fails_in_flight_waiters() {
        let Harness {
            mut listener,
            config,
            pin,
            address,
        } = harness().await;
        let key = KeyPair::from_seed([49; 32]);
        let table = table(&[&key]);
        let (reading, held) = oneshot::channel::<()>();
        let server = tokio::spawn(async move {
            let mut stream = admit(&mut listener, &config, &table)
                .await
                .expect("the client is admitted");
            let _request: Frame<ClientOp> = read_frame(&mut stream).await.unwrap().unwrap();
            reading.send(()).unwrap();
            let bye: Frame<ClientOp> = read_frame(&mut stream).await.unwrap().unwrap();
            match bye {
                Frame::Bye { reason } => assert_eq!(reason, CLOSE_REASON),
                other => panic!("expected a bye frame, got {other:?}"),
            }
        });

        let handle: ClientConn = dial(&address, &key, &pin, ROLE, settings()).await.unwrap();
        let waiter = handle.clone();
        let pending =
            tokio::spawn(async move { waiter.request(request(), Duration::from_secs(10)).await });
        held.await.unwrap();
        handle.close().await.unwrap();
        let outcome = tokio::time::timeout(Duration::from_secs(3), pending)
            .await
            .expect("close completes the waiter")
            .unwrap();
        assert!(
            matches!(outcome, Err(NetError::Disconnected(_))),
            "expected a disconnect, got {outcome:?}"
        );
        assert_eq!(handle.readiness(), ConnReadiness::Closed);
        server.await.unwrap();
    }

    #[cfg(unix)]
    #[tokio::test]
    async fn attach_serves_a_unix_socketpair() {
        use tokio::net::UnixStream;

        let (client, server) = UnixStream::pair().unwrap();
        let server = tokio::spawn(async move {
            let mut stream = server;
            let request: Frame<ClientOp> = read_frame(&mut stream).await.unwrap().unwrap();
            let id = request.id().unwrap().to_string();
            write_frame(&mut stream, &Frame::event(7, reload("unix")))
                .await
                .unwrap();
            write_frame(&mut stream, &Frame::ok(id, json!({"surface": "unix"})))
                .await
                .unwrap();
            let bye: Frame<ClientOp> = read_frame(&mut stream).await.unwrap().unwrap();
            match bye {
                Frame::Bye { reason } => assert_eq!(reason, CLOSE_REASON),
                other => panic!("expected a bye frame, got {other:?}"),
            }
        });

        let handle: ClientConn = ConnHandle::attach(client, ROLE, settings());
        assert_eq!(handle.role(), ROLE);
        assert_eq!(handle.readiness(), ConnReadiness::Ready);
        let mut events = handle.events();
        let body = handle
            .request(request(), Duration::from_secs(5))
            .await
            .unwrap();
        assert_eq!(body.data().unwrap()["surface"], "unix");
        assert_eq!(event_seq(&events.recv().await.unwrap()), 7);
        handle.close().await.unwrap();
        assert_eq!(handle.readiness(), ConnReadiness::Closed);
        assert!(handle.failure().await.is_some());
        server.await.unwrap();

        // A second pair proves the adopted shape stops for good when the peer
        // walks away, since an attached stream carries no redial plan.
        let (client, peer) = UnixStream::pair().unwrap();
        let handle: ClientConn = ConnHandle::attach(client, ROLE, settings());
        drop(peer);
        let failure = wait_for_failure(&handle).await;
        assert!(
            matches!(&failure, NetError::Disconnected(_)),
            "expected a disconnect, got {failure:?}"
        );
        assert_eq!(handle.readiness(), ConnReadiness::Closed);
    }

    #[tokio::test]
    async fn a_silent_peer_times_out_the_request() {
        let Harness {
            mut listener,
            config,
            pin,
            address,
        } = harness().await;
        let key = KeyPair::from_seed([50; 32]);
        let table = table(&[&key]);
        let (release, hold) = oneshot::channel::<()>();
        let server = tokio::spawn(async move {
            let mut stream = admit(&mut listener, &config, &table)
                .await
                .expect("the client is admitted");
            let _request: Frame<ClientOp> = read_frame(&mut stream).await.unwrap().unwrap();
            let _ = hold.await;
        });

        let handle: ClientConn = dial(&address, &key, &pin, ROLE, settings()).await.unwrap();
        let outcome = handle.request(request(), Duration::from_millis(200)).await;
        assert!(
            matches!(outcome, Err(NetError::RequestTimeout)),
            "expected the caller's deadline to fire, got {outcome:?}"
        );
        assert_eq!(
            handle.readiness(),
            ConnReadiness::Ready,
            "the silent peer keeps the link up; only this call gave up"
        );
        let _ = handle.close().await;
        release.send(()).unwrap();
        server.await.unwrap();
    }
}