omni-dev 0.46.0

AI-powered git commit rewriter, PR generator, and MCP server for Jira, Confluence, Datadog, Gmail, and Drive.
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
1177
1178
1179
1180
1181
1182
1183
1184
1185
1186
1187
1188
1189
1190
1191
1192
1193
1194
1195
1196
1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
1207
1208
1209
1210
1211
1212
1213
1214
1215
1216
1217
1218
1219
1220
1221
1222
1223
1224
1225
1226
1227
1228
1229
1230
1231
1232
1233
1234
1235
1236
1237
1238
1239
1240
1241
1242
1243
1244
1245
1246
1247
1248
1249
1250
1251
1252
1253
1254
1255
1256
1257
1258
1259
1260
1261
1262
1263
1264
1265
1266
1267
1268
1269
1270
1271
1272
1273
1274
1275
1276
1277
1278
1279
1280
1281
1282
1283
1284
1285
1286
1287
1288
1289
1290
1291
1292
1293
1294
1295
1296
1297
1298
1299
1300
1301
1302
1303
1304
1305
1306
1307
1308
1309
1310
1311
1312
1313
1314
1315
1316
1317
1318
1319
1320
1321
1322
1323
1324
1325
1326
1327
1328
1329
1330
1331
1332
1333
1334
1335
1336
1337
1338
1339
1340
1341
1342
1343
1344
1345
1346
1347
1348
1349
1350
1351
1352
1353
1354
1355
1356
1357
1358
1359
1360
1361
1362
1363
1364
1365
1366
1367
1368
1369
1370
1371
1372
1373
1374
1375
1376
1377
1378
1379
1380
1381
1382
1383
1384
1385
1386
1387
1388
1389
1390
1391
1392
1393
1394
1395
1396
1397
1398
1399
1400
1401
1402
1403
1404
1405
1406
1407
1408
1409
1410
1411
1412
1413
1414
1415
1416
1417
1418
1419
1420
1421
1422
1423
1424
1425
1426
1427
1428
1429
1430
1431
1432
1433
1434
1435
1436
1437
1438
1439
1440
1441
1442
1443
1444
1445
1446
1447
1448
1449
1450
1451
1452
1453
1454
1455
1456
1457
1458
1459
1460
1461
1462
1463
1464
1465
1466
1467
1468
1469
1470
1471
1472
1473
1474
1475
1476
1477
1478
1479
1480
1481
1482
1483
1484
1485
1486
1487
1488
1489
1490
1491
1492
1493
1494
1495
1496
1497
1498
1499
1500
1501
1502
1503
1504
1505
1506
1507
1508
1509
1510
1511
1512
1513
1514
1515
1516
1517
1518
1519
1520
1521
1522
1523
1524
1525
1526
1527
1528
1529
1530
1531
1532
1533
1534
1535
1536
1537
1538
1539
1540
1541
1542
1543
1544
1545
1546
1547
1548
1549
1550
1551
1552
1553
1554
1555
1556
1557
1558
1559
1560
1561
1562
1563
1564
1565
1566
1567
1568
1569
1570
1571
1572
1573
1574
1575
1576
1577
1578
1579
1580
1581
1582
1583
1584
1585
//! `sort-range` — reorder rows in a caller-named range (issue #1842).
//!
//! ADR-0083 §§3 and 6 initially placed `sortRange` under `SheetsWrite`
//! alone, on a values-only reading — a permutation of the range's own
//! cells is a strict special case of what a `sheets-write` grant already
//! permits via `clear`+`write`. §5 made that provisional on live
//! verification: whether the server carries a row's formatting, notes and
//! data-validation rules along with it when reordering, and what happens
//! to an in-range formula.
//!
//! Live-verified 2026-09-22 against a probe sheet in `omni-dev-test`
//! (issue #1870's plan comments): **formatting, notes and data-validation
//! rules move with the row**, and **an in-range formula moves with its row
//! with its relative references rewritten** to keep pointing at its own
//! row (e.g. `=B3*2` becomes `=B2*2` when its row moves up one). Formatting
//! is `SheetsStructure`'s own subject matter, so §5's fixed consequence
//! applies and the gate is the union of `SheetsWrite` and
//! `SheetsStructure` — [`target_gate::resolve_all`], the same shape
//! `randomize_range.rs` (#1845) and `text_to_columns.rs` took.
//! `sort-range` shipped first on `SheetsWrite` alone (#1842) and was
//! re-gated by #1870 after this verification. The same live run also
//! confirmed §3's record-decoupling caveat: cells in the same rows but
//! outside the selected columns do not move, so a range narrower than its
//! rows can silently detach a record's other columns.
//!
//! Preview intentionally does not read values or attempt to reproduce
//! Sheets' comparison semantics.

#![allow(missing_docs)]

use std::path::PathBuf;
use std::time::{Duration, Instant};

use serde::Serialize;

use crate::cli::drive::format::{write_scalar_jsonl, JsonlSerialize};
use crate::drive::client::DriveClient;
use crate::drive::files_api::FilesApi;
use crate::drive::lease::check::{
    conclude_native_leased_write, gate_optional_leased_write, FromLeaseRefusal, LeaseGateRefusal,
    LeasedWrite,
};
use crate::drive::sheets::api::{
    applied_reply_unreadable_line, BatchUpdateOutcome, RetryHint, SheetsApi,
};
use crate::drive::sheets::client::SheetsClient;
use crate::drive::sheets::grid_range::width_warning;
use crate::drive::sheets::types::{BatchUpdateRequestItem, SortOrder, SortRangeRequest, SortSpec};
use crate::drive::sheets::{a1, grid_range, target_gate};
use crate::drive::types::SheetTargetRefusal;
use crate::drive::write_gate::{self, DecidingRule, DriveOperation, FolderPermissionRule};
use crate::request_log::{self, DriveMutationOutcome};

const LOG_OPERATION: &str = "sheets-sort-range";

/// The operations this verb's gate is the union of, in the order a
/// refusal reports them. `SheetsWrite` for the cell values a sort
/// permutes, `SheetsStructure` for the formatting, notes and
/// data-validation rules live verification found travelling with each
/// row — see the module docs.
const GATE_OPERATIONS: &[DriveOperation] =
    &[DriveOperation::SheetsWrite, DriveOperation::SheetsStructure];

#[derive(Debug, Clone, PartialEq, Eq)]
pub struct SortRangeOptions {
    pub spreadsheet_id: String,
    pub sheet: Option<String>,
    pub range: Option<String>,
    /// Ordered `COLUMN:asc|desc` flags.
    pub sort_by: Vec<String>,
    pub dry_run: bool,
    pub lease_token: Option<String>,
    pub ledger_path: PathBuf,
}

#[derive(Debug, Clone, Serialize, PartialEq, Eq)]
#[serde(tag = "status", rename_all = "kebab-case")]
pub enum SortRangeResult {
    WouldChange {
        range: String,
        sort_specs: Vec<SortSpec>,
        width_warning: Option<String>,
    },
    Changed {
        range: String,
        sort_specs: Vec<SortSpec>,
        width_warning: Option<String>,
    },
    RefusedInvalidRequest {
        detail: String,
    },
    RefusedNotASpreadsheet {
        mime_type: String,
    },
    RefusedShortcut,
    RefusedNoVisibleParents,
    RefusedSheetNotFound {
        title: String,
        available: Vec<String>,
    },
    Blocked {
        /// Which of [`GATE_OPERATIONS`] denied first — the union gate
        /// refuses as soon as one of the two does, and which one it was
        /// is the only actionable part of the message.
        operation: DriveOperation,
        decided_by: Option<DecidingRule>,
    },
    RefusedNoLease,
    RefusedLeaseExpired,
    RefusedLeaseWrongFile,
    RefusedLeaseStale,
    /// The API answered 2xx — the sort **was applied** — but its reply could
    /// not be read (issue #2021). Distinct from [`Self::Failed`].
    AppliedReplyUnreadable {
        /// What was sorted, as recorded for `Changed`.
        summary: String,
        /// Why the reply could not be read.
        detail: String,
        /// Same as [`Self::Changed`].
        range: String,
        /// Same as [`Self::Changed`].
        sort_specs: Vec<SortSpec>,
        /// Same as [`Self::Changed`].
        width_warning: Option<String>,
    },
    Failed {
        detail: String,
    },
}

impl FromLeaseRefusal for SortRangeResult {
    fn from_no_lease() -> Self {
        Self::RefusedNoLease
    }
    fn from_lease_expired() -> Self {
        Self::RefusedLeaseExpired
    }
    fn from_lease_wrong_file() -> Self {
        Self::RefusedLeaseWrongFile
    }
    fn from_lease_stale() -> Self {
        Self::RefusedLeaseStale
    }
    fn from_lease_failed(detail: String) -> Self {
        Self::Failed { detail }
    }
}

impl SortRangeResult {
    fn log_status(&self) -> &'static str {
        match self {
            Self::WouldChange { .. } => "would-change",
            Self::Changed { .. } => "changed",
            Self::RefusedInvalidRequest { .. } => "refused-invalid-request",
            Self::RefusedNotASpreadsheet { .. } => "refused-not-a-spreadsheet",
            Self::RefusedShortcut => "refused-shortcut",
            Self::RefusedNoVisibleParents => "refused-no-visible-parents",
            Self::RefusedSheetNotFound { .. } => "refused-sheet-not-found",
            Self::Blocked { .. } => "blocked",
            Self::RefusedNoLease => "refused-no-lease",
            Self::RefusedLeaseExpired => "refused-lease-expired",
            Self::RefusedLeaseWrongFile => "refused-lease-wrong-file",
            Self::RefusedLeaseStale => "refused-lease-stale",
            Self::AppliedReplyUnreadable { .. } => "applied-reply-unreadable",
            Self::Failed { .. } => "failed",
        }
    }
}

#[derive(Debug, Clone, Serialize, PartialEq, Eq)]
pub struct SortRangeOutcome {
    pub spreadsheet_id: String,
    pub file_name: Option<String>,
    pub resolved_folder_id: Option<String>,
    pub result: SortRangeResult,
}

impl JsonlSerialize for SortRangeOutcome {
    fn write_jsonl(&self, out: &mut dyn std::io::Write) -> anyhow::Result<()> {
        write_scalar_jsonl(self, out)
    }
}

pub async fn sort_range(
    drive: &DriveClient,
    sheets: &SheetsClient,
    opts: &SortRangeOptions,
    rules: &[FolderPermissionRule],
) -> SortRangeOutcome {
    let started = Instant::now();
    let outcome = sort_range_inner(drive, sheets, opts, rules).await;
    if !opts.dry_run {
        record_attempt(&outcome, started.elapsed());
    }
    outcome
}

async fn sort_range_inner(
    drive: &DriveClient,
    sheets: &SheetsClient,
    opts: &SortRangeOptions,
    rules: &[FolderPermissionRule],
) -> SortRangeOutcome {
    let bare = |result| SortRangeOutcome {
        spreadsheet_id: opts.spreadsheet_id.clone(),
        file_name: None,
        resolved_folder_id: None,
        result,
    };
    let composed = match a1::compose(opts.sheet.as_deref(), opts.range.as_deref()) {
        Ok(range) => range,
        Err(err) => {
            return bare(SortRangeResult::RefusedInvalidRequest {
                detail: err.to_string(),
            })
        }
    };
    let sort_specs = match parse_sort_specs(&opts.sort_by) {
        Ok(specs) if !specs.is_empty() => specs,
        Ok(_) => {
            return bare(SortRangeResult::RefusedInvalidRequest {
                detail: "pass at least one --sort-by COLUMN:asc|desc".to_string(),
            })
        }
        Err(detail) => return bare(SortRangeResult::RefusedInvalidRequest { detail }),
    };
    if let Err(detail) = reject_duplicate_sort_columns(&sort_specs) {
        return bare(SortRangeResult::RefusedInvalidRequest { detail });
    }
    let (target, verdict, denied, resolved_folder_id, requires_lease) =
        match target_gate::resolve_all(drive, &opts.spreadsheet_id, GATE_OPERATIONS, rules).await {
            target_gate::TargetGateUnionOutcome::MetadataFetchFailed { detail } => {
                return bare(SortRangeResult::Failed { detail })
            }
            target_gate::TargetGateUnionOutcome::Refused { target, refusal } => {
                let result = match refusal {
                    SheetTargetRefusal::Shortcut => SortRangeResult::RefusedShortcut,
                    SheetTargetRefusal::NotASpreadsheet { mime_type } => {
                        SortRangeResult::RefusedNotASpreadsheet { mime_type }
                    }
                    SheetTargetRefusal::NoVisibleParents => {
                        SortRangeResult::RefusedNoVisibleParents
                    }
                };
                return SortRangeOutcome {
                    spreadsheet_id: opts.spreadsheet_id.clone(),
                    file_name: Some(target.name),
                    resolved_folder_id: None,
                    result,
                };
            }
            target_gate::TargetGateUnionOutcome::GateFetchFailed { target, detail } => {
                return SortRangeOutcome {
                    spreadsheet_id: opts.spreadsheet_id.clone(),
                    file_name: Some(target.name),
                    resolved_folder_id: None,
                    result: SortRangeResult::Failed { detail },
                }
            }
            target_gate::TargetGateUnionOutcome::Gated {
                target,
                verdict,
                denied,
                resolved_folder_id,
                requires_lease,
            } => (target, verdict, denied, resolved_folder_id, requires_lease),
        };
    let gated = |result| SortRangeOutcome {
        spreadsheet_id: opts.spreadsheet_id.clone(),
        file_name: Some(target.name.clone()),
        resolved_folder_id: resolved_folder_id.clone(),
        result,
    };
    if verdict == write_gate::Verdict::Deny {
        // `denied` is `Some` whenever the verdict is `Deny`; the fallback
        // names the first operation rather than inventing one, matching
        // `randomize_range.rs`'s own arm.
        let (operation, decided_by) = denied.unwrap_or((GATE_OPERATIONS[0], None));
        return gated(SortRangeResult::Blocked {
            operation,
            decided_by,
        });
    }
    let api = SheetsApi::new(sheets);
    let workbook = match api.get_spreadsheet(&opts.spreadsheet_id).await {
        Ok(book) => book,
        Err(err) => {
            return gated(SortRangeResult::Failed {
                detail: format!("{err:#}"),
            })
        }
    };
    let (_, grid) = match grid_range::resolve_grid_range(
        &workbook,
        &composed,
        |detail| SortRangeResult::RefusedInvalidRequest { detail },
        |title, available| SortRangeResult::RefusedSheetNotFound { title, available },
    ) {
        Ok(value) => value,
        Err(result) => return gated(result),
    };
    if !grid_range::is_bounded(&grid) {
        return gated(SortRangeResult::RefusedInvalidRequest {
            detail: format!(
                "{composed} is open-ended; sort-range needs a fully bounded range (e.g. A1:D10)"
            ),
        });
    }
    let start_column = grid.start_column_index.unwrap_or(0);
    let end_column = grid.end_column_index.unwrap_or(0);
    if let Some(spec) = sort_specs
        .iter()
        .find(|spec| grid_range::check_column_in_range(spec.dimension_index, &grid).is_err())
    {
        return gated(SortRangeResult::RefusedInvalidRequest {
            detail: format!(
                "sort column {} is outside the selected range's columns {}..{} (zero-based, end exclusive)",
                spec.dimension_index, start_column, end_column
            ),
        });
    }
    let allocated_columns = grid_range::find_sheet_by_id(&workbook, grid.sheet_id)
        .and_then(|sheet| sheet.properties.as_ref())
        .and_then(|props| props.grid_properties.as_ref())
        .and_then(|props| props.column_count);
    let width_warning = width_warning("sorting", start_column, end_column, allocated_columns);
    let request = BatchUpdateRequestItem::SortRange(SortRangeRequest {
        range: grid,
        sort_specs: sort_specs.clone(),
    });
    if opts.dry_run {
        return gated(SortRangeResult::WouldChange {
            range: composed,
            sort_specs,
            width_warning,
        });
    }
    let leased = LeasedWrite {
        log_prefix: "drive sheets sort-range",
        operation: LOG_OPERATION,
        ledger_path: &opts.ledger_path,
        file_id: &opts.spreadsheet_id,
    };
    let files_api = FilesApi::new(drive);
    let lease_grant = match gate_optional_leased_write(
        leased,
        &files_api,
        requires_lease,
        opts.lease_token.as_deref(),
    )
    .await
    {
        Ok(grant) => grant,
        Err(err) => return gated(err.into_result()),
    };
    let result = match conclude_native_leased_write(
        leased,
        &lease_grant,
        &files_api,
        api.batch_update(&opts.spreadsheet_id, vec![request]).await,
        |err| format!("{err:#}"),
    )
    .await
    {
        Ok(BatchUpdateOutcome::Applied(_)) => SortRangeResult::Changed {
            range: composed,
            sort_specs,
            width_warning,
        },
        // Idempotent: re-sorting an already-sorted range is a no-op.
        Ok(BatchUpdateOutcome::AppliedReplyUnreadable { detail }) => {
            SortRangeResult::AppliedReplyUnreadable {
                summary: sorted_summary(&composed, &sort_specs),
                detail,
                range: composed,
                sort_specs,
                width_warning,
            }
        }
        Err(err) => SortRangeResult::Failed {
            detail: format!("{err:#}"),
        },
    };
    gated(result)
}

fn parse_sort_specs(flags: &[String]) -> Result<Vec<SortSpec>, String> {
    flags
        .iter()
        .map(|flag| {
            let (column, order) = flag
                .split_once(':')
                .ok_or_else(|| format!("'{flag}' is not COLUMN:asc|desc"))?;
            let dimension_index = column
                .trim()
                .parse()
                .map_err(|_| format!("'{column}' in '{flag}' is not a column index"))?;
            if dimension_index < 0 {
                return Err(format!(
                    "'{column}' in '{flag}' must be a non-negative column index"
                ));
            }
            let sort_order = match order.trim().to_ascii_lowercase().as_str() {
                "asc" | "ascending" => SortOrder::Ascending,
                "desc" | "descending" => SortOrder::Descending,
                other => return Err(format!("'{other}' in '{flag}' is not 'asc' or 'desc'")),
            };
            Ok(SortSpec {
                dimension_index,
                sort_order,
            })
        })
        .collect()
}

/// Refuses a `--sort-by` list naming the same column more than once
/// (`--sort-by 3:asc --sort-by 3:desc`), matching `delete-duplicates`'
/// `--comparison-column` duplicate refusal. Only the API's own last-one-wins
/// behavior distinguishes such a pair, which is a silent surprise rather
/// than a caller's evident intent (#1941).
fn reject_duplicate_sort_columns(specs: &[SortSpec]) -> Result<(), String> {
    let mut seen = Vec::with_capacity(specs.len());
    for spec in specs {
        if seen.contains(&spec.dimension_index) {
            return Err(format!(
                "--sort-by column {} is given more than once",
                spec.dimension_index
            ));
        }
        seen.push(spec.dimension_index);
    }
    Ok(())
}

fn record_attempt(outcome: &SortRangeOutcome, duration: Duration) {
    request_log::record_drive_mutation(mutation_outcome(outcome, duration));
}

/// The `drivemutation` record for one attempt. Split out from
/// [`record_attempt`] so the logged fields are unit-testable.
fn mutation_outcome(outcome: &SortRangeOutcome, duration: Duration) -> DriveMutationOutcome {
    let decided_by = match &outcome.result {
        SortRangeResult::Blocked { decided_by, .. } => decided_by.as_ref(),
        _ => None,
    };
    let decided_by = write_gate::decided_by_log_fields(decided_by);
    let fields_changed = match &outcome.result {
        SortRangeResult::Changed {
            range, sort_specs, ..
        } => Some(sorted_summary(range, sort_specs)),
        SortRangeResult::AppliedReplyUnreadable { summary, .. } => Some(summary.clone()),
        _ => None,
    };
    let error = match &outcome.result {
        SortRangeResult::RefusedInvalidRequest { detail }
        | SortRangeResult::Failed { detail }
        | SortRangeResult::AppliedReplyUnreadable { detail, .. } => Some(detail.clone()),
        _ => None,
    };
    DriveMutationOutcome {
        operation: LOG_OPERATION,
        file_id: outcome.spreadsheet_id.clone(),
        file_name: outcome.file_name.clone().unwrap_or_default(),
        status: outcome.result.log_status().to_string(),
        resolved_folder_id: outcome.resolved_folder_id.clone(),
        decided_by_folder_id: decided_by.folder_id,
        decided_by_depth: decided_by.depth,
        decided_by_file_id: decided_by.file_id,
        fields_changed,
        error,
        duration,
        ..Default::default()
    }
}

pub fn describe_lines(outcome: &SortRangeOutcome) -> Vec<String> {
    let book = outcome.file_name.as_deref().map_or_else(
        || format!("'{}'", outcome.spreadsheet_id),
        |name| format!("'{name}'"),
    );
    match &outcome.result {
        SortRangeResult::WouldChange {
            range,
            sort_specs,
            width_warning,
        } => grid_range::reorder_caveat_lines(
            "sorting",
            format!(
                "Would sort {range} in {book} by {}",
                render_specs(sort_specs)
            ),
            width_warning.as_deref(),
            false,
            None,
        ),
        SortRangeResult::Changed {
            range,
            sort_specs,
            width_warning,
        } => grid_range::reorder_caveat_lines(
            "sorting",
            format!(
                "Applied sort of {range} in {book} by {}",
                render_specs(sort_specs)
            ),
            width_warning.as_deref(),
            true,
            None,
        ),
        SortRangeResult::RefusedInvalidRequest { detail } => vec![format!("Refused: {detail}")],
        SortRangeResult::RefusedNotASpreadsheet { mime_type } => vec![format!(
            "Refused: {book} is not a Google Sheet (mimeType: {mime_type})"
        )],
        SortRangeResult::RefusedShortcut => vec![format!(
            "Refused: {book} is a shortcut; sort-range doesn't follow shortcuts"
        )],
        SortRangeResult::RefusedNoVisibleParents => {
            vec![format!("Refused: {book} has no visible parent folder")]
        }
        SortRangeResult::RefusedSheetNotFound { title, available } => {
            vec![grid_range::no_sheet_refusal(&book, title, available)]
        }
        SortRangeResult::Blocked {
            operation,
            decided_by,
        } => vec![match decided_by {
            Some(rule) => format!(
                "Blocked: sort-range on {book} refused for {operation} by rule on {} {}{}",
                rule.kind_label(),
                rule.id(),
                rule.depth_suffix()
            ),
            None => format!(
                "Blocked: sort-range on {book} refused by default policy (no matching rule \
                 for {operation})"
            ),
        }],
        SortRangeResult::RefusedNoLease => LeaseGateRefusal::NoLease
            .describe_line(&outcome.spreadsheet_id, &book)
            .into_iter()
            .collect(),
        SortRangeResult::RefusedLeaseExpired => LeaseGateRefusal::Expired
            .describe_line(&outcome.spreadsheet_id, &book)
            .into_iter()
            .collect(),
        SortRangeResult::RefusedLeaseWrongFile => LeaseGateRefusal::WrongFile
            .describe_line(&outcome.spreadsheet_id, &book)
            .into_iter()
            .collect(),
        SortRangeResult::RefusedLeaseStale => LeaseGateRefusal::Stale
            .describe_line(&outcome.spreadsheet_id, &book)
            .into_iter()
            .collect(),
        SortRangeResult::AppliedReplyUnreadable {
            summary,
            detail,
            width_warning,
            ..
        } => {
            let mut lines = grid_range::reorder_caveat_lines(
                "sorting",
                applied_reply_unreadable_line(summary, &book, RetryHint::Idempotent, detail),
                None,
                true,
                None,
            );
            // The width warning is plan-time data, so it survives the
            // unreadable reply; it follows the shared line here.
            lines.splice(
                1..1,
                width_warning
                    .iter()
                    .map(|warning| format!("Warning: {warning}")),
            );
            lines
        }
        SortRangeResult::Failed { detail } => vec![format!("Failed: {detail}")],
    }
}

/// The one-line account of a sort, shared by the audit log and the
/// unreadable-reply line.
fn sorted_summary(range: &str, specs: &[SortSpec]) -> String {
    format!("sorted {range} by {}", render_specs(specs))
}

fn render_specs(specs: &[SortSpec]) -> String {
    specs
        .iter()
        .map(|spec| {
            format!(
                "{} {}",
                spec.dimension_index,
                match spec.sort_order {
                    SortOrder::Ascending => "asc",
                    SortOrder::Descending => "desc",
                }
            )
        })
        .collect::<Vec<_>>()
        .join(", ")
}

#[cfg(test)]
#[allow(clippy::unwrap_used)]
mod tests {
    use super::*;
    use crate::drive::auth::{DriveCredentials, DriveGrantedScopes};
    use crate::drive::sheets::client::SHEETS_API_URL;
    use crate::drive::test_support::seed_lease;
    use crate::drive::types::GOOGLE_SHEET_MIME_TYPE;
    use crate::test_support::env::MapEnv;
    use crate::utils::secret::Secret;
    use std::collections::HashSet;

    async fn clients(server: &wiremock::MockServer) -> (DriveClient, SheetsClient) {
        let credentials = DriveCredentials {
            client_id: "client-1".into(),
            client_secret: Secret::new("secret-1"),
            refresh_token: Secret::new("refresh-1"),
            scope: DriveGrantedScopes::READONLY,
        };
        wiremock::Mock::given(wiremock::matchers::method("POST"))
            .and(wiremock::matchers::path("/token"))
            .respond_with(wiremock::ResponseTemplate::new(200).set_body_json(
                serde_json::json!({"access_token": "test-token", "expires_in": 3600}),
            ))
            .mount(server)
            .await;
        let mut drive = DriveClient::new(&server.uri(), &credentials).unwrap();
        crate::drive::client::test_support::replace_session(
            &mut drive,
            &credentials,
            &format!("{}/token", server.uri()),
        );
        let env = MapEnv::new().with(SHEETS_API_URL, &server.uri());
        let sheets = SheetsClient::from_drive_client_with(&env, &drive).unwrap();
        (drive, sheets)
    }

    async fn mount_metadata(server: &wiremock::MockServer) {
        wiremock::Mock::given(wiremock::matchers::method("GET"))
            .and(wiremock::matchers::path("/drive/v3/files/sheet-1"))
            .respond_with(
                wiremock::ResponseTemplate::new(200).set_body_json(serde_json::json!({
                    "id": "sheet-1", "name": "Budget", "mimeType": GOOGLE_SHEET_MIME_TYPE,
                    "parents": ["parent-1"], "version": "1"
                })),
            )
            .mount(server)
            .await;
        wiremock::Mock::given(wiremock::matchers::method("GET"))
            .and(wiremock::matchers::path("/drive/v3/files/parent-1"))
            .respond_with(
                wiremock::ResponseTemplate::new(200).set_body_json(serde_json::json!({
                    "id": "parent-1", "name": "parent-1",
                    "mimeType": "application/vnd.google-apps.folder", "parents": []
                })),
            )
            .mount(server)
            .await;
        wiremock::Mock::given(wiremock::matchers::method("GET"))
            .and(wiremock::matchers::path("/v4/spreadsheets/sheet-1"))
            .respond_with(
                wiremock::ResponseTemplate::new(200).set_body_json(serde_json::json!({
                    "spreadsheetId": "sheet-1",
                    "sheets": [{"properties": {
                        "sheetId": 0, "title": "Q1",
                        "gridProperties": {"rowCount": 100, "columnCount": 6}
                    }}]
                })),
            )
            .mount(server)
            .await;
    }

    /// `version: "1"` throughout — matches [`options`]'s default (no seeded
    /// lease).
    fn mount_file(id: &str, mime_type: &str, parents: &[&str]) -> wiremock::Mock {
        let parents: Vec<&str> = parents.to_vec();
        wiremock::Mock::given(wiremock::matchers::method("GET"))
            .and(wiremock::matchers::path(format!("/drive/v3/files/{id}")))
            .respond_with(
                wiremock::ResponseTemplate::new(200).set_body_json(serde_json::json!({
                    "id": id, "name": id, "mimeType": mime_type, "parents": parents,
                    "version": "1",
                })),
            )
    }

    fn mount_folder(id: &str) -> wiremock::Mock {
        mount_file(id, "application/vnd.google-apps.folder", &[])
    }

    /// A `spreadsheets.get` reply for `sheet-1` with a single `Q1` sheet
    /// (sheetId 0) whose `gridProperties` omits `columnCount` — so
    /// [`width_warning`] can never learn the sheet's allocated width.
    fn mount_workbook_no_column_count() -> wiremock::Mock {
        wiremock::Mock::given(wiremock::matchers::method("GET"))
            .and(wiremock::matchers::path("/v4/spreadsheets/sheet-1"))
            .respond_with(
                wiremock::ResponseTemplate::new(200).set_body_json(serde_json::json!({
                    "spreadsheetId": "sheet-1",
                    "sheets": [{"properties": {
                        "sheetId": 0, "title": "Q1", "gridProperties": {"rowCount": 100}
                    }}]
                })),
            )
    }

    fn options(dry_run: bool) -> SortRangeOptions {
        SortRangeOptions {
            spreadsheet_id: "sheet-1".into(),
            sheet: Some("Q1".into()),
            range: Some("A2:C10".into()),
            sort_by: vec!["2:desc".into(), "0:asc".into()],
            dry_run,
            lease_token: None,
            ledger_path: PathBuf::from("/tmp/unused-sort-range-ledger"),
        }
    }

    fn rule() -> FolderPermissionRule {
        FolderPermissionRule {
            folder_id: Some("parent-1".into()),
            file_id: None,
            recursive: true,
            allow: GATE_OPERATIONS.iter().copied().collect(),
            deny: HashSet::default(),
            require_lease: false,
        }
    }

    fn rule_requiring_lease() -> FolderPermissionRule {
        FolderPermissionRule {
            require_lease: true,
            ..rule()
        }
    }

    /// Allows `sheets-write` but explicitly denies `sheets-structure` — the
    /// union gate must refuse even though one of its two operations would
    /// have allowed it.
    fn rule_missing_sheets_structure() -> FolderPermissionRule {
        FolderPermissionRule {
            folder_id: Some("parent-1".into()),
            file_id: None,
            recursive: true,
            allow: std::iter::once(DriveOperation::SheetsWrite).collect(),
            deny: std::iter::once(DriveOperation::SheetsStructure).collect(),
            require_lease: false,
        }
    }

    #[test]
    fn parses_ordered_sort_specs() {
        let specs = parse_sort_specs(&["2:desc".into(), "0:ascending".into()]).unwrap();
        assert_eq!(specs[0].dimension_index, 2);
        assert_eq!(specs[0].sort_order, SortOrder::Descending);
        assert_eq!(specs[1].dimension_index, 0);
    }

    #[test]
    fn preview_never_claims_to_predict_sort_order() {
        let outcome = SortRangeOutcome {
            spreadsheet_id: "id".into(),
            file_name: Some("Book".into()),
            resolved_folder_id: None,
            result: SortRangeResult::WouldChange {
                range: "Q1!A1:B3".into(),
                sort_specs: vec![SortSpec {
                    dimension_index: 0,
                    sort_order: SortOrder::Ascending,
                }],
                width_warning: width_warning("sorting", 0, 2, Some(5)),
            },
        };
        let lines = describe_lines(&outcome).join("\n");
        assert!(lines.contains("separate records"));
        assert!(lines.contains("references outside"));
    }

    #[tokio::test]
    async fn dry_run_uses_metadata_without_reading_values_or_mutating() {
        let server = wiremock::MockServer::start().await;
        let (drive, sheets) = clients(&server).await;
        mount_metadata(&server).await;
        let outcome = sort_range(&drive, &sheets, &options(true), &[rule()]).await;
        let SortRangeResult::WouldChange { width_warning, .. } = outcome.result else {
            panic!("expected would-change"); // omni-dev: coverage ignore-line reason="this let-else panic only runs if the match failed to bind the expected variant; this test always constructs that exact variant, so the branch never executes"
        };
        assert!(width_warning
            .unwrap()
            .contains("3 of the sheet's 6 allocated columns"));
        let requests = server.received_requests().await.unwrap();
        // OAuth refresh, the target and workbook reads, plus the parent
        // folder read once per gated operation: `resolve_all` walks the
        // ancestor chain independently for each of `GATE_OPERATIONS`'s two
        // operations, so `parent-1` is fetched twice.
        assert_eq!(requests.len(), 5);
        assert!(requests
            .iter()
            .all(|request| { request.method.as_str() == "GET" || request.url.path() == "/token" }));
    }

    #[tokio::test]
    async fn real_run_sends_one_ordered_sort_range_request() {
        let server = wiremock::MockServer::start().await;
        let (drive, sheets) = clients(&server).await;
        mount_metadata(&server).await;
        wiremock::Mock::given(wiremock::matchers::method("POST"))
            .and(wiremock::matchers::path(
                "/v4/spreadsheets/sheet-1:batchUpdate",
            ))
            .respond_with(
                wiremock::ResponseTemplate::new(200)
                    .set_body_json(serde_json::json!({"replies": [{}]})),
            )
            .mount(&server)
            .await;
        let outcome = sort_range(&drive, &sheets, &options(false), &[rule()]).await;
        assert!(
            matches!(outcome.result, SortRangeResult::Changed { .. }),
            "{outcome:?}"
        );
        let requests = server.received_requests().await.unwrap();
        let batch = requests
            .iter()
            .find(|request| request.url.path().ends_with(":batchUpdate"))
            .unwrap();
        let body: serde_json::Value = serde_json::from_slice(&batch.body).unwrap();
        assert_eq!(
            body["requests"][0]["sortRange"]["range"],
            serde_json::json!({
                "sheetId": 0, "startRowIndex": 1, "endRowIndex": 10,
                "startColumnIndex": 0, "endColumnIndex": 3
            })
        );
        assert_eq!(
            body["requests"][0]["sortRange"]["sortSpecs"],
            serde_json::json!([
                {"dimensionIndex": 2, "sortOrder": "DESCENDING"},
                {"dimensionIndex": 0, "sortOrder": "ASCENDING"}
            ])
        );
    }

    #[tokio::test]
    async fn rejects_sort_column_outside_the_range_before_mutating() {
        let server = wiremock::MockServer::start().await;
        let (drive, sheets) = clients(&server).await;
        mount_metadata(&server).await;
        let mut opts = options(false);
        opts.sort_by = vec!["3:asc".into()];
        let outcome = sort_range(&drive, &sheets, &opts, &[rule()]).await;
        assert!(matches!(
            outcome.result,
            SortRangeResult::RefusedInvalidRequest { .. }
        ));
        assert!(server
            .received_requests()
            .await
            .unwrap()
            .iter()
            .all(|request| { request.method.as_str() == "GET" || request.url.path() == "/token" }));
    }

    // ── refusals before any network call ────────────────────────────────

    #[tokio::test]
    async fn rejects_a_malformed_sort_by_flag_before_any_network_call() {
        let server = wiremock::MockServer::start().await;
        let (drive, sheets) = clients(&server).await;
        // No metadata mocks: a malformed flag must short-circuit first.
        let mut opts = options(false);
        opts.sort_by = vec!["no-colon-here".into()];
        let outcome = sort_range(&drive, &sheets, &opts, &[rule()]).await;
        let SortRangeResult::RefusedInvalidRequest { detail } = &outcome.result else {
            panic!("expected RefusedInvalidRequest, got {:?}", outcome.result); // omni-dev: coverage ignore-line reason="this let-else panic only runs if the match failed to bind the expected variant; this test always constructs that exact variant, so the branch never executes"
        };
        assert!(detail.contains("COLUMN:asc|desc"), "{detail}");
        assert!(outcome.file_name.is_none());
        assert!(server.received_requests().await.unwrap().is_empty());
    }

    #[tokio::test]
    async fn rejects_an_empty_sort_by_list_before_any_network_call() {
        let server = wiremock::MockServer::start().await;
        let (drive, sheets) = clients(&server).await;
        let mut opts = options(false);
        opts.sort_by = vec![];
        let outcome = sort_range(&drive, &sheets, &opts, &[rule()]).await;
        let SortRangeResult::RefusedInvalidRequest { detail } = &outcome.result else {
            panic!("expected RefusedInvalidRequest, got {:?}", outcome.result); // omni-dev: coverage ignore-line reason="this let-else panic only runs if the match failed to bind the expected variant; this test always constructs that exact variant, so the branch never executes"
        };
        assert!(detail.contains("pass at least one --sort-by"), "{detail}");
        assert!(server.received_requests().await.unwrap().is_empty());
    }

    #[tokio::test]
    async fn rejects_a_repeated_sort_column_before_any_network_call() {
        // `--sort-by 3:asc --sort-by 3:desc` silently let the API's
        // last-one-wins behavior decide, with no way for the caller to tell
        // from the command which direction won (#1941).
        let server = wiremock::MockServer::start().await;
        let (drive, sheets) = clients(&server).await;
        let mut opts = options(false);
        opts.sort_by = vec!["3:asc".into(), "3:desc".into()];
        let outcome = sort_range(&drive, &sheets, &opts, &[rule()]).await;
        let SortRangeResult::RefusedInvalidRequest { detail } = &outcome.result else {
            panic!("expected RefusedInvalidRequest, got {:?}", outcome.result); // omni-dev: coverage ignore-line reason="this let-else panic only runs if the match failed to bind the expected variant; this test always constructs that exact variant, so the branch never executes"
        };
        assert!(
            detail.contains("column 3 is given more than once"),
            "{detail}"
        );
        assert!(server.received_requests().await.unwrap().is_empty());
    }

    #[tokio::test]
    async fn rejects_a_negative_sort_column_index_before_any_network_call() {
        let server = wiremock::MockServer::start().await;
        let (drive, sheets) = clients(&server).await;
        let mut opts = options(false);
        opts.sort_by = vec!["-1:asc".into()];
        let outcome = sort_range(&drive, &sheets, &opts, &[rule()]).await;
        let SortRangeResult::RefusedInvalidRequest { detail } = &outcome.result else {
            panic!("expected RefusedInvalidRequest, got {:?}", outcome.result); // omni-dev: coverage ignore-line reason="this let-else panic only runs if the match failed to bind the expected variant; this test always constructs that exact variant, so the branch never executes"
        };
        assert!(detail.contains("non-negative"), "{detail}");
        assert!(server.received_requests().await.unwrap().is_empty());
    }

    #[tokio::test]
    async fn rejects_an_invalid_sort_order_word_before_any_network_call() {
        let server = wiremock::MockServer::start().await;
        let (drive, sheets) = clients(&server).await;
        let mut opts = options(false);
        opts.sort_by = vec!["0:sideways".into()];
        let outcome = sort_range(&drive, &sheets, &opts, &[rule()]).await;
        let SortRangeResult::RefusedInvalidRequest { detail } = &outcome.result else {
            panic!("expected RefusedInvalidRequest, got {:?}", outcome.result); // omni-dev: coverage ignore-line reason="this let-else panic only runs if the match failed to bind the expected variant; this test always constructs that exact variant, so the branch never executes"
        };
        assert!(detail.contains("'asc' or 'desc'"), "{detail}");
        assert!(server.received_requests().await.unwrap().is_empty());
    }

    #[tokio::test]
    async fn rejects_a_range_with_conflicting_sheet_prefix_before_any_network_call() {
        let server = wiremock::MockServer::start().await;
        let (drive, sheets) = clients(&server).await;
        let mut opts = options(false);
        opts.sheet = Some("Other".into());
        opts.range = Some("Sheet1!A1:B2".into());
        let outcome = sort_range(&drive, &sheets, &opts, &[rule()]).await;
        let SortRangeResult::RefusedInvalidRequest { detail } = &outcome.result else {
            panic!("expected RefusedInvalidRequest, got {:?}", outcome.result); // omni-dev: coverage ignore-line reason="this let-else panic only runs if the match failed to bind the expected variant; this test always constructs that exact variant, so the branch never executes"
        };
        assert!(detail.contains("already names a sheet"), "{detail}");
        assert!(server.received_requests().await.unwrap().is_empty());
    }

    // ── refusals surfaced by the target gate ────────────────────────────

    #[tokio::test]
    async fn a_metadata_fetch_failure_surfaces_as_failed() {
        let server = wiremock::MockServer::start().await;
        let (drive, sheets) = clients(&server).await;
        wiremock::Mock::given(wiremock::matchers::method("GET"))
            .and(wiremock::matchers::path("/drive/v3/files/sheet-1"))
            .respond_with(wiremock::ResponseTemplate::new(404).set_body_string("not found"))
            .mount(&server)
            .await;
        let outcome = sort_range(&drive, &sheets, &options(false), &[rule()]).await;
        assert!(matches!(outcome.result, SortRangeResult::Failed { .. }));
    }

    #[tokio::test]
    async fn non_spreadsheet_is_refused_before_any_gate_or_sheets_call() {
        let server = wiremock::MockServer::start().await;
        let (drive, sheets) = clients(&server).await;
        mount_file("sheet-1", "application/pdf", &["parent-1"])
            .mount(&server)
            .await;
        // Deliberately no mock for parent-1 (the gate never runs) and none
        // for any Sheets endpoint.
        let outcome = sort_range(&drive, &sheets, &options(false), &[rule()]).await;
        assert!(matches!(
            outcome.result,
            SortRangeResult::RefusedNotASpreadsheet { .. }
        ));
        let text = describe_lines(&outcome).join("\n");
        assert!(text.contains("is not a Google Sheet"), "{text}");
    }

    #[tokio::test]
    async fn shortcut_is_refused_with_its_own_message_not_the_generic_one() {
        let server = wiremock::MockServer::start().await;
        let (drive, sheets) = clients(&server).await;
        mount_file(
            "sheet-1",
            "application/vnd.google-apps.shortcut",
            &["parent-1"],
        )
        .mount(&server)
        .await;
        let outcome = sort_range(&drive, &sheets, &options(false), &[rule()]).await;
        assert!(matches!(outcome.result, SortRangeResult::RefusedShortcut));
        let text = describe_lines(&outcome).join("\n");
        assert!(text.contains("is a shortcut"), "{text}");
    }

    #[tokio::test]
    async fn a_sheet_with_no_visible_parents_is_refused_distinctly_from_a_blocked_one() {
        let server = wiremock::MockServer::start().await;
        let (drive, sheets) = clients(&server).await;
        mount_file("sheet-1", GOOGLE_SHEET_MIME_TYPE, &[])
            .mount(&server)
            .await;
        let outcome = sort_range(&drive, &sheets, &options(false), &[]).await;
        assert!(matches!(
            outcome.result,
            SortRangeResult::RefusedNoVisibleParents
        ));
    }

    #[tokio::test]
    async fn a_gate_fetch_failure_surfaces_as_failed() {
        let server = wiremock::MockServer::start().await;
        let (drive, sheets) = clients(&server).await;
        mount_file("sheet-1", GOOGLE_SHEET_MIME_TYPE, &["parent-1"])
            .mount(&server)
            .await;
        wiremock::Mock::given(wiremock::matchers::method("GET"))
            .and(wiremock::matchers::path("/drive/v3/files/parent-1"))
            .respond_with(wiremock::ResponseTemplate::new(500).set_body_string("boom"))
            .mount(&server)
            .await;
        let outcome = sort_range(&drive, &sheets, &options(false), &[rule()]).await;
        assert!(matches!(outcome.result, SortRangeResult::Failed { .. }));
    }

    // ── the gate itself ───────────────────────────────────────────────────

    #[tokio::test]
    async fn denied_target_is_blocked_and_records_the_attempt() {
        let server = wiremock::MockServer::start().await;
        let (drive, sheets) = clients(&server).await;
        mount_file("sheet-1", GOOGLE_SHEET_MIME_TYPE, &["parent-1"])
            .mount(&server)
            .await;
        mount_folder("parent-1").mount(&server).await;
        // No workbook or batchUpdate mock: either call would 404.
        let outcome = sort_range(&drive, &sheets, &options(false), &[]).await;
        assert!(
            matches!(
                outcome.result,
                SortRangeResult::Blocked {
                    decided_by: None,
                    ..
                }
            ),
            "{:?}",
            outcome.result
        );
    }

    #[tokio::test]
    async fn a_rule_allowing_sheets_write_but_denying_sheets_structure_is_still_blocked() {
        let server = wiremock::MockServer::start().await;
        let (drive, sheets) = clients(&server).await;
        mount_file("sheet-1", GOOGLE_SHEET_MIME_TYPE, &["parent-1"])
            .mount(&server)
            .await;
        mount_folder("parent-1").mount(&server).await;
        let outcome = sort_range(
            &drive,
            &sheets,
            &options(false),
            &[rule_missing_sheets_structure()],
        )
        .await;
        let lines = describe_lines(&outcome).join("\n");
        assert!(lines.contains("sheets-structure"), "{lines}");
        assert!(lines.contains("rule on folder parent-1"), "{lines}");
        let SortRangeResult::Blocked { operation, .. } = outcome.result else {
            panic!("expected Blocked, got {:?}", outcome.result); // omni-dev: coverage ignore-line reason="this let-else panic only runs if the match failed to bind the expected variant; this test always constructs that exact variant, so the branch never executes"
        };
        assert_eq!(operation, DriveOperation::SheetsStructure);
    }

    #[tokio::test]
    async fn a_workbook_fetch_failure_surfaces_as_failed() {
        let server = wiremock::MockServer::start().await;
        let (drive, sheets) = clients(&server).await;
        mount_file("sheet-1", GOOGLE_SHEET_MIME_TYPE, &["parent-1"])
            .mount(&server)
            .await;
        mount_folder("parent-1").mount(&server).await;
        wiremock::Mock::given(wiremock::matchers::method("GET"))
            .and(wiremock::matchers::path("/v4/spreadsheets/sheet-1"))
            .respond_with(wiremock::ResponseTemplate::new(500).set_body_string("boom"))
            .mount(&server)
            .await;
        let outcome = sort_range(&drive, &sheets, &options(false), &[rule()]).await;
        assert!(matches!(outcome.result, SortRangeResult::Failed { .. }));
    }

    // ── the range itself, once the workbook is in hand ───────────────────

    #[tokio::test]
    async fn a_range_without_a_sheet_prefix_is_refused_as_invalid() {
        let server = wiremock::MockServer::start().await;
        let (drive, sheets) = clients(&server).await;
        mount_metadata(&server).await;
        let mut opts = options(false);
        opts.sheet = None;
        opts.range = Some("A2:C10".into()); // no `Sheet!` prefix, and no `--sheet` either.
        let outcome = sort_range(&drive, &sheets, &opts, &[rule()]).await;
        let SortRangeResult::RefusedInvalidRequest { detail } = &outcome.result else {
            panic!("expected RefusedInvalidRequest, got {:?}", outcome.result); // omni-dev: coverage ignore-line reason="this let-else panic only runs if the match failed to bind the expected variant; this test always constructs that exact variant, so the branch never executes"
        };
        assert!(detail.contains("does not name a sheet"), "{detail}");
        assert!(server
            .received_requests()
            .await
            .unwrap()
            .iter()
            .all(|request| { request.method.as_str() == "GET" || request.url.path() == "/token" }));
    }

    #[tokio::test]
    async fn a_range_naming_an_unknown_sheet_is_refused_with_available_titles() {
        let server = wiremock::MockServer::start().await;
        let (drive, sheets) = clients(&server).await;
        mount_metadata(&server).await;
        let mut opts = options(false);
        opts.sheet = None;
        opts.range = Some("Nope!A2:C10".into());
        let outcome = sort_range(&drive, &sheets, &opts, &[rule()]).await;
        let SortRangeResult::RefusedSheetNotFound { title, available } = &outcome.result else {
            panic!("expected RefusedSheetNotFound, got {:?}", outcome.result); // omni-dev: coverage ignore-line reason="this let-else panic only runs if the match failed to bind the expected variant; this test always constructs that exact variant, so the branch never executes"
        };
        assert_eq!(title, "Nope");
        assert_eq!(available, &["Q1".to_string()]);
    }

    #[tokio::test]
    async fn an_open_ended_range_is_refused_as_invalid() {
        let server = wiremock::MockServer::start().await;
        let (drive, sheets) = clients(&server).await;
        mount_metadata(&server).await;
        let mut opts = options(false);
        opts.sheet = None;
        opts.range = Some("Q1!A:A".into());
        let outcome = sort_range(&drive, &sheets, &opts, &[rule()]).await;
        let SortRangeResult::RefusedInvalidRequest { detail } = &outcome.result else {
            panic!("expected RefusedInvalidRequest, got {:?}", outcome.result); // omni-dev: coverage ignore-line reason="this let-else panic only runs if the match failed to bind the expected variant; this test always constructs that exact variant, so the branch never executes"
        };
        assert!(
            detail.starts_with("Q1!A:A is open-ended"),
            "the range is echoed as given, with no extra quotes: {detail}"
        );
        assert!(server
            .received_requests()
            .await
            .unwrap()
            .iter()
            .all(|request| { request.method.as_str() == "GET" || request.url.path() == "/token" }));
    }

    #[tokio::test]
    async fn a_sheet_with_no_recorded_column_count_gets_the_generic_width_warning() {
        let server = wiremock::MockServer::start().await;
        let (drive, sheets) = clients(&server).await;
        mount_file("sheet-1", GOOGLE_SHEET_MIME_TYPE, &["parent-1"])
            .mount(&server)
            .await;
        mount_folder("parent-1").mount(&server).await;
        mount_workbook_no_column_count().mount(&server).await;
        let outcome = sort_range(&drive, &sheets, &options(true), &[rule()]).await;
        let SortRangeResult::WouldChange { width_warning, .. } = outcome.result else {
            panic!("expected would-change"); // omni-dev: coverage ignore-line reason="this let-else panic only runs if the match failed to bind the expected variant; this test always constructs that exact variant, so the branch never executes"
        };
        assert!(width_warning.unwrap().contains("may be narrower"));
    }

    #[tokio::test]
    async fn a_batch_update_error_is_reported_as_failed() {
        let server = wiremock::MockServer::start().await;
        let (drive, sheets) = clients(&server).await;
        mount_metadata(&server).await;
        wiremock::Mock::given(wiremock::matchers::method("POST"))
            .and(wiremock::matchers::path(
                "/v4/spreadsheets/sheet-1:batchUpdate",
            ))
            .respond_with(wiremock::ResponseTemplate::new(500).set_body_string("boom"))
            .mount(&server)
            .await;
        let outcome = sort_range(&drive, &sheets, &options(false), &[rule()]).await;
        assert!(matches!(outcome.result, SortRangeResult::Failed { .. }));
    }

    #[tokio::test]
    async fn sort_with_an_unreadable_reply_reports_applied_reply_unreadable() {
        let server = wiremock::MockServer::start().await;
        let (drive, sheets) = clients(&server).await;
        mount_metadata(&server).await;
        // 2xx, so the sort WAS applied — but the body is not the reply shape.
        wiremock::Mock::given(wiremock::matchers::method("POST"))
            .and(wiremock::matchers::path(
                "/v4/spreadsheets/sheet-1:batchUpdate",
            ))
            .respond_with(wiremock::ResponseTemplate::new(200).set_body_string("not json"))
            .expect(1)
            .mount(&server)
            .await;
        let outcome = sort_range(&drive, &sheets, &options(false), &[rule()]).await;
        assert_eq!(
            outcome.result.log_status(),
            "applied-reply-unreadable",
            "{outcome:?}"
        );
        let lines = describe_lines(&outcome);
        assert!(
            lines[0].starts_with("Applied, but the reply could not be read"),
            "{lines:?}"
        );
    }

    #[test]
    fn describe_lines_renders_applied_reply_unreadable() {
        let outcome = SortRangeOutcome {
            spreadsheet_id: "sheet-1".into(),
            file_name: Some("Budget".into()),
            resolved_folder_id: None,
            result: SortRangeResult::AppliedReplyUnreadable {
                summary: "sorted Q1!A2:C10 by 2 desc".into(),
                detail: "bad reply".into(),
                range: "Q1!A2:C10".into(),
                sort_specs: vec![SortSpec {
                    dimension_index: 2,
                    sort_order: SortOrder::Descending,
                }],
                width_warning: Some("narrow".to_string()),
            },
        };
        // The plan-time width warning and reference caveat survive, exactly
        // as `Changed` renders them.
        assert_eq!(
            describe_lines(&outcome),
            vec![
                "Applied, but the reply could not be read: sorted Q1!A2:C10 by 2 desc in \
                 'Budget' — check the spreadsheet to confirm (bad reply)",
                "Warning: narrow",
                "  references outside the range may now observe values from a different row"
            ]
        );
    }

    #[test]
    fn the_unreadable_reply_is_logged_with_its_summary_and_detail() {
        let outcome = SortRangeOutcome {
            spreadsheet_id: "sheet-1".into(),
            file_name: Some("Budget".into()),
            resolved_folder_id: None,
            result: SortRangeResult::AppliedReplyUnreadable {
                summary: "sorted Q1!A2:C10 by 2 desc".into(),
                detail: "bad reply".into(),
                range: "Q1!A2:C10".into(),
                sort_specs: vec![],
                width_warning: None,
            },
        };
        let logged = mutation_outcome(&outcome, Duration::ZERO);
        assert_eq!(logged.status, "applied-reply-unreadable");
        assert_eq!(
            logged.fields_changed.as_deref(),
            Some("sorted Q1!A2:C10 by 2 desc")
        );
        assert_eq!(logged.error.as_deref(), Some("bad reply"));
    }

    #[tokio::test]
    async fn a_batch_update_error_under_an_active_lease_records_the_failure() {
        // Unlike `a_batch_update_error_is_reported_as_failed` (no lease held
        // at all), this holds a real lease grant so the failure path also
        // exercises `conclude_native_leased_write`'s own error recording.
        let server = wiremock::MockServer::start().await;
        let (drive, sheets) = clients(&server).await;
        mount_metadata(&server).await;
        wiremock::Mock::given(wiremock::matchers::method("POST"))
            .and(wiremock::matchers::path(
                "/v4/spreadsheets/sheet-1:batchUpdate",
            ))
            .respond_with(wiremock::ResponseTemplate::new(500).set_body_string("boom"))
            .mount(&server)
            .await;
        let ledger_path = tempfile::tempdir().unwrap().keep().join("ledger.jsonl");
        let token = seed_lease(&ledger_path, "sheet-1", "1");
        let mut opts = options(false);
        opts.lease_token = Some(token);
        opts.ledger_path = ledger_path;
        let outcome = sort_range(&drive, &sheets, &opts, &[rule_requiring_lease()]).await;
        assert!(matches!(outcome.result, SortRangeResult::Failed { .. }));
    }

    // ── the Drive write lease (ADR-0080 §9) ─────────────────────────────

    #[tokio::test]
    async fn refuses_without_a_lease_when_the_rule_requires_one() {
        let server = wiremock::MockServer::start().await;
        let (drive, sheets) = clients(&server).await;
        mount_metadata(&server).await;
        // No batchUpdate mock: a refusal must make zero mutating calls.
        let outcome = sort_range(&drive, &sheets, &options(false), &[rule_requiring_lease()]).await;
        assert_eq!(outcome.result, SortRangeResult::RefusedNoLease);
    }

    #[tokio::test]
    async fn refuses_an_unknown_lease_token() {
        let server = wiremock::MockServer::start().await;
        let (drive, sheets) = clients(&server).await;
        mount_metadata(&server).await;
        let mut opts = options(false);
        opts.lease_token = Some("bogus-token".into());
        // Never seeded — no ledger exists at this fresh path.
        opts.ledger_path = tempfile::tempdir().unwrap().keep().join("ledger.jsonl");
        let outcome = sort_range(&drive, &sheets, &opts, &[rule_requiring_lease()]).await;
        assert_eq!(outcome.result, SortRangeResult::RefusedLeaseExpired);
    }

    #[tokio::test]
    async fn refuses_a_lease_bound_to_a_different_file() {
        let server = wiremock::MockServer::start().await;
        let (drive, sheets) = clients(&server).await;
        mount_metadata(&server).await;
        let ledger_path = tempfile::tempdir().unwrap().keep().join("ledger.jsonl");
        let token = seed_lease(&ledger_path, "other-sheet", "1");
        let mut opts = options(false);
        opts.lease_token = Some(token);
        opts.ledger_path = ledger_path;
        let outcome = sort_range(&drive, &sheets, &opts, &[rule_requiring_lease()]).await;
        assert_eq!(outcome.result, SortRangeResult::RefusedLeaseWrongFile);
    }

    #[tokio::test]
    async fn refuses_a_stale_lease() {
        let server = wiremock::MockServer::start().await;
        let (drive, sheets) = clients(&server).await;
        // Live version "1" (`mount_metadata`'s default) but the lease was
        // acquired at "0" — the file has moved since.
        mount_metadata(&server).await;
        let ledger_path = tempfile::tempdir().unwrap().keep().join("ledger.jsonl");
        let token = seed_lease(&ledger_path, "sheet-1", "0");
        let mut opts = options(false);
        opts.lease_token = Some(token);
        opts.ledger_path = ledger_path;
        let outcome = sort_range(&drive, &sheets, &opts, &[rule_requiring_lease()]).await;
        assert_eq!(outcome.result, SortRangeResult::RefusedLeaseStale);
    }

    // ── pure unit coverage: lease-refusal mapping, JSONL, describe/log ──

    #[test]
    fn lease_refusals_map_to_their_sort_range_results() {
        assert_eq!(
            SortRangeResult::from_no_lease(),
            SortRangeResult::RefusedNoLease
        );
        assert_eq!(
            SortRangeResult::from_lease_expired(),
            SortRangeResult::RefusedLeaseExpired
        );
        assert_eq!(
            SortRangeResult::from_lease_wrong_file(),
            SortRangeResult::RefusedLeaseWrongFile
        );
        assert_eq!(
            SortRangeResult::from_lease_stale(),
            SortRangeResult::RefusedLeaseStale
        );
        assert_eq!(
            SortRangeResult::from_lease_failed("ledger unavailable".into()),
            SortRangeResult::Failed {
                detail: "ledger unavailable".into()
            }
        );
    }

    #[test]
    fn write_jsonl_emits_one_line_of_json() {
        let outcome = SortRangeOutcome {
            spreadsheet_id: "sheet-1".into(),
            file_name: Some("Budget".into()),
            resolved_folder_id: Some("parent-1".into()),
            result: SortRangeResult::Changed {
                range: "Q1!A2:C10".into(),
                sort_specs: vec![SortSpec {
                    dimension_index: 0,
                    sort_order: SortOrder::Ascending,
                }],
                width_warning: None,
            },
        };
        let mut buf = Vec::new();
        outcome.write_jsonl(&mut buf).unwrap();
        let text = String::from_utf8(buf).unwrap();
        assert_eq!(text.matches('\n').count(), 1);
        let parsed: serde_json::Value = serde_json::from_str(text.trim()).unwrap();
        assert_eq!(parsed["result"]["status"], "changed");
    }

    /// One of every [`SortRangeResult`] variant.
    ///
    /// The `match` below is exhaustive and wildcard-free on purpose: adding
    /// a variant breaks this build, which is what forces the new arm
    /// through the tests below.
    fn every_sort_range_result() -> Vec<SortRangeResult> {
        let all = vec![
            SortRangeResult::WouldChange {
                range: "Q1!A1:B3".into(),
                sort_specs: vec![SortSpec {
                    dimension_index: 0,
                    sort_order: SortOrder::Ascending,
                }],
                width_warning: None,
            },
            SortRangeResult::Changed {
                range: "Q1!A1:B3".into(),
                sort_specs: vec![SortSpec {
                    dimension_index: 0,
                    sort_order: SortOrder::Descending,
                }],
                width_warning: Some("narrow".to_string()),
            },
            SortRangeResult::RefusedInvalidRequest {
                detail: "bad".into(),
            },
            SortRangeResult::RefusedNotASpreadsheet {
                mime_type: "application/pdf".into(),
            },
            SortRangeResult::RefusedShortcut,
            SortRangeResult::RefusedNoVisibleParents,
            SortRangeResult::RefusedSheetNotFound {
                title: "Nope".into(),
                available: vec!["Q1".into()],
            },
            SortRangeResult::Blocked {
                operation: DriveOperation::SheetsWrite,
                decided_by: None,
            },
            SortRangeResult::Blocked {
                operation: DriveOperation::SheetsStructure,
                decided_by: Some(DecidingRule::Folder {
                    folder_id: "folder-1".into(),
                    depth: 2,
                }),
            },
            SortRangeResult::Blocked {
                operation: DriveOperation::SheetsWrite,
                decided_by: Some(DecidingRule::File {
                    file_id: "sheet-1".into(),
                }),
            },
            SortRangeResult::RefusedNoLease,
            SortRangeResult::RefusedLeaseExpired,
            SortRangeResult::RefusedLeaseWrongFile,
            SortRangeResult::RefusedLeaseStale,
            SortRangeResult::AppliedReplyUnreadable {
                summary: "sorted Q1!A1:B3 by 0 asc".into(),
                detail: "bad reply".into(),
                range: "Q1!A1:B3".into(),
                sort_specs: vec![SortSpec {
                    dimension_index: 0,
                    sort_order: SortOrder::Ascending,
                }],
                width_warning: Some("narrow".to_string()),
            },
            SortRangeResult::Failed {
                detail: "boom".into(),
            },
        ];
        for result in &all {
            match result {
                SortRangeResult::WouldChange { .. }
                | SortRangeResult::Changed { .. }
                | SortRangeResult::RefusedInvalidRequest { .. }
                | SortRangeResult::RefusedNotASpreadsheet { .. }
                | SortRangeResult::RefusedShortcut
                | SortRangeResult::RefusedNoVisibleParents
                | SortRangeResult::RefusedSheetNotFound { .. }
                | SortRangeResult::Blocked { .. }
                | SortRangeResult::RefusedNoLease
                | SortRangeResult::RefusedLeaseExpired
                | SortRangeResult::RefusedLeaseWrongFile
                | SortRangeResult::RefusedLeaseStale
                | SortRangeResult::AppliedReplyUnreadable { .. }
                | SortRangeResult::Failed { .. } => (),
            }
        }
        all
    }

    #[test]
    fn every_describe_arm_renders_at_least_one_line_with_no_control_characters() {
        for result in every_sort_range_result() {
            let outcome = SortRangeOutcome {
                spreadsheet_id: "sheet-1".into(),
                file_name: Some("Quarterly Plan".into()),
                resolved_folder_id: None,
                result,
            };
            let lines = describe_lines(&outcome);
            assert!(
                !lines.is_empty(),
                "describe_lines emitted no lines for {:?}",
                outcome.result
            );
            for line in &lines {
                assert!(
                    !line.chars().any(char::is_control),
                    "describe_lines emitted a control character for {:?}: {lines:?}",
                    outcome.result
                );
            }
        }
    }

    #[test]
    fn describe_lines_falls_back_to_the_spreadsheet_id_with_no_file_name() {
        let outcome = SortRangeOutcome {
            spreadsheet_id: "sheet-1".into(),
            file_name: None,
            resolved_folder_id: None,
            result: SortRangeResult::RefusedShortcut,
        };
        let lines = describe_lines(&outcome);
        assert_eq!(lines.len(), 1);
        assert!(lines[0].contains("'sheet-1'"), "{lines:?}");
    }

    #[test]
    fn blocked_with_no_deciding_rule_names_the_denied_operation() {
        let outcome = SortRangeOutcome {
            spreadsheet_id: "sheet-1".into(),
            file_name: Some("Budget".into()),
            resolved_folder_id: None,
            result: SortRangeResult::Blocked {
                operation: DriveOperation::SheetsStructure,
                decided_by: None,
            },
        };
        let lines = describe_lines(&outcome).join("\n");
        assert!(lines.contains("sheets-structure"), "{lines}");
    }

    #[test]
    fn log_status_covers_every_variant() {
        for result in every_sort_range_result() {
            assert!(!result.log_status().is_empty());
        }
        assert_eq!(
            SortRangeResult::Blocked {
                operation: DriveOperation::SheetsWrite,
                decided_by: None
            }
            .log_status(),
            "blocked"
        );
        assert_eq!(
            SortRangeResult::Changed {
                range: "Q1!A1:B2".into(),
                sort_specs: vec![],
                width_warning: None
            }
            .log_status(),
            "changed"
        );
        assert_eq!(
            SortRangeResult::RefusedLeaseStale.log_status(),
            "refused-lease-stale"
        );
    }
}