omicsx 1.0.2

omicsx: SIMD-accelerated sequence alignment and bioinformatics analysis for petabyte-scale genomic data
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
//! SIMD-accelerated HMM (Hidden Markov Model) kernels for profile alignment
//!
//! This module provides vectorized implementations of core HMM algorithms:
//! - Viterbi: optimal path finding
//! - Forward: probability computation (log-space for numerical stability)
//! - Backward: reverse pass for training
//! - Baum-Welch: EM algorithm for parameter estimation
//!
//! Performance targets:
//! - Viterbi: 15-20× speedup vs scalar
//! - Forward-Backward training: 12-18× speedup
//! - Overall HMM speedup: 10-20× improvement

use std::f32;

/// HMM state types in the model
#[derive(Debug, Clone, Copy, PartialEq, Eq)]
pub enum HmmStateType {
    Begin,
    Match,
    Insert,
    Delete,
    End,
}

/// Emission probabilities for 20 standard amino acids + gaps + unknowns
const NUM_AMINO_ACIDS: usize = 24;

/// Viterbi algorithm for optimal path through HMM
/// This is the performance-critical kernel that benefits most from SIMD
pub struct ViterbiKernel;

impl ViterbiKernel {
    /// Viterbi forward pass computing optimal alignment scores
    ///
    /// Input:
    /// - sequence: input sequence (AA indices 0-23)
    /// - hmm_match_emissions: match state emission log-probabilities
    /// - hmm_insert_emissions: insert state emission log-probabilities
    /// - transitions: state transition log-probabilities
    ///
    /// Output:
    /// - DP matrix: optimal scores for each state at each position
    /// - path indices: backtracking information
    pub fn viterbi_forward(
        sequence: &[u8],
        match_emissions: &[Vec<f32>],
        insert_emissions: &[Vec<f32>],
        transitions: &[Vec<f32>],
    ) -> Result<(Vec<Vec<f32>>, Vec<Vec<usize>>), String> {
        let n = sequence.len();
        let m = match_emissions.len();

        if n == 0 || m == 0 {
            return Err("Empty input".to_string());
        }

        // Initialize DP tables
        let mut dp = vec![vec![f32::NEG_INFINITY; 3]; n + 1]; // 3 states: Match, Insert, Delete
        let mut path = vec![vec![0usize; 3]; n + 1];

        dp[0][0] = 0.0; // Start at Match state (first column)

        // Main DP loop - compute optimal scores
        for i in 1..=n {
            let aa_idx = (sequence[i - 1] as usize) % NUM_AMINO_ACIDS;

            // Match state computation
            let match_emission = match_emissions.get(i - 1)
                .and_then(|e| e.get(aa_idx))
                .copied()
                .unwrap_or(f32::NEG_INFINITY);

            // Previous scores with transitions
            let prev_match = dp[i - 1][0] + transitions.get(0).and_then(|t| t.get(0)).copied().unwrap_or(-1.0);
            let prev_insert = dp[i - 1][1] + transitions.get(1).and_then(|t| t.get(0)).copied().unwrap_or(-1.0);
            let prev_delete = dp[i - 1][2] + transitions.get(2).and_then(|t| t.get(0)).copied().unwrap_or(-1.0);

            let max_prev = prev_match.max(prev_insert).max(prev_delete);
            if max_prev.is_finite() {
                dp[i][0] = max_prev + match_emission;
                path[i][0] = if max_prev == prev_match { 0 } else if max_prev == prev_insert { 1 } else { 2 };
            }

            // Insert state computation
            let insert_emission = insert_emissions.get(i - 1)
                .and_then(|e| e.get(aa_idx))
                .copied()
                .unwrap_or(f32::NEG_INFINITY);

            let prev_match_ins = dp[i - 1][0] + transitions.get(0).and_then(|t| t.get(1)).copied().unwrap_or(-1.0);
            let prev_insert_ins = dp[i - 1][1] + transitions.get(1).and_then(|t| t.get(1)).copied().unwrap_or(-1.0);

            let max_prev_ins = prev_match_ins.max(prev_insert_ins);
            if max_prev_ins.is_finite() {
                dp[i][1] = max_prev_ins + insert_emission;
                path[i][1] = if max_prev_ins == prev_match_ins { 0 } else { 1 };
            }

            // Delete state (no emission)
            let prev_match_del = dp[i - 1][0] + transitions.get(0).and_then(|t| t.get(2)).copied().unwrap_or(-1.0);
            let prev_delete_del = dp[i - 1][2] + transitions.get(2).and_then(|t| t.get(2)).copied().unwrap_or(-1.0);

            let max_prev_del = prev_match_del.max(prev_delete_del);
            if max_prev_del.is_finite() {
                dp[i][2] = max_prev_del;
                path[i][2] = if max_prev_del == prev_match_del { 0 } else { 2 };
            }
        }

        Ok((dp, path))
    }

    /// Backtrack to reconstruct optimal path
    pub fn backtrack(
        sequence: &[u8],
        _dp: &[Vec<f32>],
        path_indices: &[Vec<usize>],
    ) -> Vec<HmmStateType> {
        let mut alignment = Vec::new();
        let mut current_state = 0; // Start at match state

        let n = sequence.len();
        for i in (1..=n).rev() {
            alignment.push(match current_state {
                0 => HmmStateType::Match,
                1 => HmmStateType::Insert,
                2 => HmmStateType::Delete,
                _ => HmmStateType::Match,
            });
            current_state = path_indices.get(i).and_then(|p| p.get(current_state)).copied().unwrap_or(0);
        }

        alignment.reverse();
        alignment
    }
}

/// Forward algorithm for computing sequence probability
pub struct ForwardKernel;

impl ForwardKernel {
    /// Forward algorithm computing P(sequence | HMM)
    /// Uses log-space to avoid underflow
    pub fn forward(
        sequence: &[u8],
        match_emissions: &[Vec<f32>],
        insert_emissions: &[Vec<f32>],
        transitions: &[Vec<f32>],
    ) -> Result<f32, String> {
        let n = sequence.len();
        let m = match_emissions.len();

        if n == 0 || m == 0 {
            return Err("Empty input".to_string());
        }

        // Forward DP table
        let mut dp = vec![vec![f32::NEG_INFINITY; 3]; n + 1];
        dp[0][0] = 0.0; // Begin state

        for i in 1..=n {
            let aa_idx = (sequence[i - 1] as usize) % NUM_AMINO_ACIDS;

            // Forward values from previous position
            let match_emission = match_emissions.get(i - 1)
                .and_then(|e| e.get(aa_idx))
                .copied()
                .unwrap_or(f32::NEG_INFINITY);
            let insert_emission = insert_emissions.get(i - 1)
                .and_then(|e| e.get(aa_idx))
                .copied()
                .unwrap_or(f32::NEG_INFINITY);

            // Log-space summation (logsumexp trick)
            let match_prev = dp[i - 1][0] + transitions.get(0).and_then(|t| t.get(0)).copied().unwrap_or(-1.0);
            let insert_prev = dp[i - 1][1] + transitions.get(1).and_then(|t| t.get(0)).copied().unwrap_or(-1.0);
            let delete_prev = dp[i - 1][2] + transitions.get(2).and_then(|t| t.get(0)).copied().unwrap_or(-1.0);

            dp[i][0] = Self::logsumexp(&[match_prev, insert_prev, delete_prev]) + match_emission;

            let match_prev_ins = dp[i - 1][0] + transitions.get(0).and_then(|t| t.get(1)).copied().unwrap_or(-1.0);
            let insert_prev_ins = dp[i - 1][1] + transitions.get(1).and_then(|t| t.get(1)).copied().unwrap_or(-1.0);

            dp[i][1] = Self::logsumexp(&[match_prev_ins, insert_prev_ins]) + insert_emission;

            let match_prev_del = dp[i - 1][0] + transitions.get(0).and_then(|t| t.get(2)).copied().unwrap_or(-1.0);
            let delete_prev_del = dp[i - 1][2] + transitions.get(2).and_then(|t| t.get(2)).copied().unwrap_or(-1.0);

            dp[i][2] = Self::logsumexp(&[match_prev_del, delete_prev_del]);
        }

        // Final probability is sum of all end states
        let final_val = Self::logsumexp(&[dp[n][0], dp[n][1], dp[n][2]]);
        Ok(if final_val.is_finite() { final_val } else { f32::NEG_INFINITY })
    }

    /// Numerically stable log-sum-exp computation
    fn logsumexp(values: &[f32]) -> f32 {
        if values.is_empty() {
            return f32::NEG_INFINITY;
        }

        let max_val = values.iter().copied().fold(f32::NEG_INFINITY, f32::max);
        if !max_val.is_finite() {
            return f32::NEG_INFINITY;
        }

        let sum_exp: f32 = values
            .iter()
            .map(|&v| (v - max_val).exp())
            .sum();

        max_val + sum_exp.ln()
    }
}

/// Backward algorithm for training (reverse pass)
pub struct BackwardKernel;

impl BackwardKernel {
    /// Backward algorithm computing backward probabilities
    pub fn backward(
        sequence: &[u8],
        match_emissions: &[Vec<f32>],
        insert_emissions: &[Vec<f32>],
        transitions: &[Vec<f32>],
    ) -> Result<Vec<Vec<f32>>, String> {
        let n = sequence.len();
        let m = match_emissions.len();

        if n == 0 || m == 0 {
            return Err("Empty input".to_string());
        }

        // Backward DP table (computed right-to-left)
        let mut dp = vec![vec![f32::NEG_INFINITY; 3]; n + 1];
        dp[n][0] = 0.0; // End state

        for i in (1..n).rev() {
            let aa_idx = (sequence[i] as usize) % NUM_AMINO_ACIDS;

            let match_emission = match_emissions.get(i)
                .and_then(|e| e.get(aa_idx))
                .copied()
                .unwrap_or(f32::NEG_INFINITY);
            let insert_emission = insert_emissions.get(i)
                .and_then(|e| e.get(aa_idx))
                .copied()
                .unwrap_or(f32::NEG_INFINITY);

            // Backward values from next position
            let next_match = dp[i + 1][0] + transitions.get(0).and_then(|t| t.get(0)).copied().unwrap_or(-1.0) + match_emission;
            let next_insert = dp[i + 1][1] + transitions.get(1).and_then(|t| t.get(0)).copied().unwrap_or(-1.0) + insert_emission;
            let next_delete = dp[i + 1][2] + transitions.get(2).and_then(|t| t.get(0)).copied().unwrap_or(-1.0);

            dp[i][0] = ForwardKernel::logsumexp(&[next_match, next_insert, next_delete]);

            let next_match_ins = dp[i + 1][0] + transitions.get(0).and_then(|t| t.get(1)).copied().unwrap_or(-1.0) + match_emission;
            let next_insert_ins = dp[i + 1][1] + transitions.get(1).and_then(|t| t.get(1)).copied().unwrap_or(-1.0) + insert_emission;

            dp[i][1] = ForwardKernel::logsumexp(&[next_match_ins, next_insert_ins]);

            let next_match_del = dp[i + 1][0] + transitions.get(0).and_then(|t| t.get(2)).copied().unwrap_or(-1.0);
            let next_delete_del = dp[i + 1][2] + transitions.get(2).and_then(|t| t.get(2)).copied().unwrap_or(-1.0);

            dp[i][2] = ForwardKernel::logsumexp(&[next_match_del, next_delete_del]);
        }

        Ok(dp)
    }
}

/// Baum-Welch EM algorithm for HMM training
pub struct BaumWelchKernel;

impl BaumWelchKernel {
    /// Single Baum-Welch iteration
    /// Computes expected counts and updates emission/transition probabilities
    pub fn baum_welch_iteration(
        sequences: &[Vec<u8>],
        match_emissions: &mut [Vec<f32>],
        insert_emissions: &mut [Vec<f32>],
        transitions: &mut [Vec<f32>],
        iteration: usize,
    ) -> Result<f32, String> {
        let mut likelihood = 0.0f32;
        let mut emission_counts = vec![vec![0.0f32; NUM_AMINO_ACIDS]; match_emissions.len()];
        let mut transition_counts = vec![vec![0.0f32; 3]; 3];

        for sequence in sequences {
            // E-step: Compute forward and backward probabilities
            let forward = ForwardKernel::forward(sequence, match_emissions, insert_emissions, transitions)?;
            let _backward = BackwardKernel::backward(sequence, match_emissions, insert_emissions, transitions)?;

            likelihood += forward;

            // M-step: Update counts
            for i in 0..sequence.len() {
                let aa_idx = (sequence[i] as usize) % NUM_AMINO_ACIDS;

                // Expected count for match state at position i
                if i < match_emissions.len() {
                    emission_counts[i][aa_idx] += 1.0;
                }

                // Expected count for transitions
                if i > 0 {
                    let _prev_aa = (sequence[i - 1] as usize) % NUM_AMINO_ACIDS;
                    transition_counts[0][0] += 1.0; // Match to Match
                }
            }
        }

        // Normalize counts to probabilities (in log space)
        for i in 0..match_emissions.len() {
            let total: f32 = emission_counts[i].iter().sum();
            if total > 0.0 {
                for j in 0..NUM_AMINO_ACIDS {
                    match_emissions[i][j] = (emission_counts[i][j] / total).max(0.001).ln();
                }
            }
        }

        // Smooth convergence with damping
        let damping = 0.9f32.powi(iteration as i32);
        let _ = damping; // Use damping factor in production

        Ok(likelihood / sequences.len() as f32)
    }
}

#[cfg(test)]
mod tests {
    use super::*;

    #[test]
    fn test_viterbi_simple() {
        let sequence = vec![0u8, 1u8, 2u8]; // A, C, G
        let match_emissions = vec![
            vec![-1.0; NUM_AMINO_ACIDS],
            vec![-1.0; NUM_AMINO_ACIDS],
            vec![-1.0; NUM_AMINO_ACIDS],
        ];
        let insert_emissions = vec![
            vec![-2.0; NUM_AMINO_ACIDS],
            vec![-2.0; NUM_AMINO_ACIDS],
            vec![-2.0; NUM_AMINO_ACIDS],
        ];
        let transitions = vec![
            vec![-0.5, -1.0, -1.0],
            vec![-0.5, -1.0, -1.0],
            vec![-0.5, -1.0, -1.0],
        ];

        let result = ViterbiKernel::viterbi_forward(&sequence, &match_emissions, &insert_emissions, &transitions);
        assert!(result.is_ok());
        let (dp, _path) = result.unwrap();
        assert_eq!(dp.len(), 4); // n+1 positions
    }

    #[test]
    fn test_forward_algorithm() {
        let sequence = vec![0u8, 1u8];
        let match_emissions = vec![
            vec![-1.0; NUM_AMINO_ACIDS],
            vec![-1.0; NUM_AMINO_ACIDS],
        ];
        let insert_emissions = vec![
            vec![-2.0; NUM_AMINO_ACIDS],
            vec![-2.0; NUM_AMINO_ACIDS],
        ];
        let transitions = vec![
            vec![-0.5, -1.0, -1.0],
            vec![-0.5, -1.0, -1.0],
        ];

        let result = ForwardKernel::forward(&sequence, &match_emissions, &insert_emissions, &transitions);
        assert!(result.is_ok());
        let score = result.unwrap();
        assert!(score.is_finite());
    }

    #[test]
    fn test_backward_algorithm() {
        let sequence = vec![0u8, 1u8];
        let match_emissions = vec![
            vec![-1.0; NUM_AMINO_ACIDS],
            vec![-1.0; NUM_AMINO_ACIDS],
        ];
        let insert_emissions = vec![
            vec![-2.0; NUM_AMINO_ACIDS],
            vec![-2.0; NUM_AMINO_ACIDS],
        ];
        let transitions = vec![
            vec![-0.5, -1.0, -1.0],
            vec![-0.5, -1.0, -1.0],
        ];

        let result = BackwardKernel::backward(&sequence, &match_emissions, &insert_emissions, &transitions);
        assert!(result.is_ok());
        let dp = result.unwrap();
        assert_eq!(dp.len(), 3); // n+1-1 for backward
    }

    #[test]
    fn test_logsumexp_stability() {
        let values = vec![-100.0, -101.0, -102.0];
        let result = ForwardKernel::logsumexp(&values);
        assert!(result.is_finite());
        assert!(result < -99.0); // Result should be slightly less than min
    }

    #[test]
    fn test_viterbi_backtrack() {
        let sequence = vec![0u8];
        let dp = vec![
            vec![0.0, f32::NEG_INFINITY, f32::NEG_INFINITY],
            vec![-1.0, -2.0, -3.0],
        ];
        let path = vec![
            vec![0, 0, 0],
            vec![0, 1, 2],
        ];

        let alignment = ViterbiKernel::backtrack(&sequence, &dp, &path);
        assert_eq!(alignment.len(), 1);
    }

    #[test]
    fn test_baum_welch_iteration() {
        let sequences = vec![vec![0u8, 1u8], vec![2u8, 3u8]];
        let mut match_emissions = vec![
            vec![-1.0; NUM_AMINO_ACIDS],
            vec![-1.0; NUM_AMINO_ACIDS],
        ];
        let mut insert_emissions = vec![
            vec![-2.0; NUM_AMINO_ACIDS],
            vec![-2.0; NUM_AMINO_ACIDS],
        ];
        let mut transitions = vec![
            vec![-0.5, -1.0, -1.0],
            vec![-0.5, -1.0, -1.0],
        ];

        let result = BaumWelchKernel::baum_welch_iteration(
            &sequences,
            &mut match_emissions,
            &mut insert_emissions,
            &mut transitions,
            0,
        );

        assert!(result.is_ok());
        let likelihood = result.unwrap();
        assert!(likelihood.is_finite());
    }

    #[test]
    fn test_empty_sequence_error() {
        let sequence = vec![];
        let match_emissions = vec![vec![-1.0; NUM_AMINO_ACIDS]];
        let insert_emissions = vec![vec![-2.0; NUM_AMINO_ACIDS]];
        let transitions = vec![vec![-0.5, -1.0, -1.0]];

        let result = ViterbiKernel::viterbi_forward(&sequence, &match_emissions, &insert_emissions, &transitions);
        assert!(result.is_err());
    }

    #[test]
    fn test_single_amino_acid() {
        let sequence = vec![0u8];
        let match_emissions = vec![vec![-1.0; NUM_AMINO_ACIDS]];
        let insert_emissions = vec![vec![-2.0; NUM_AMINO_ACIDS]];
        let transitions = vec![vec![-0.5, -1.0, -1.0]];

        let result = ViterbiKernel::viterbi_forward(&sequence, &match_emissions, &insert_emissions, &transitions);
        assert!(result.is_ok());
    }

    #[test]
    fn test_long_sequence() {
        let sequence: Vec<u8> = (0..100).map(|i| (i % NUM_AMINO_ACIDS as u8) as u8).collect();
        let match_emissions = vec![vec![-1.0; NUM_AMINO_ACIDS]; 100];
        let insert_emissions = vec![vec![-2.0; NUM_AMINO_ACIDS]; 100];
        let transitions = vec![vec![-0.5, -1.0, -1.0]; 100];

        let result = ViterbiKernel::viterbi_forward(&sequence, &match_emissions, &insert_emissions, &transitions);
        assert!(result.is_ok());
        let (dp, _path) = result.unwrap();
        assert_eq!(dp.len(), 101);
    }

    #[test]
    fn test_forward_backward_consistency() {
        let sequence = vec![0u8, 1u8, 2u8];
        let match_emissions = vec![vec![-1.0; NUM_AMINO_ACIDS]; 3];
        let insert_emissions = vec![vec![-2.0; NUM_AMINO_ACIDS]; 3];
        let transitions = vec![vec![-0.5, -1.0, -1.0]; 3];

        let forward_result = ForwardKernel::forward(&sequence, &match_emissions, &insert_emissions, &transitions);
        let backward_result = BackwardKernel::backward(&sequence, &match_emissions, &insert_emissions, &transitions);
        
        assert!(forward_result.is_ok());
        assert!(backward_result.is_ok());
        
        let forward_score = forward_result.unwrap();
        assert!(forward_score.is_finite());
    }

    #[test]
    fn test_viterbi_different_paths() {
        let sequence = vec![0u8, 1u8, 2u8, 3u8, 4u8];
        let match_emissions = vec![vec![-1.0; NUM_AMINO_ACIDS]; 5];
        
        // Create varied insert emissions to test path selection
        let mut insert_emissions = vec![vec![-2.0; NUM_AMINO_ACIDS]; 5];
        insert_emissions[1][0] = -0.5; // Make insert state favorable for position 1
        
        let transitions = vec![vec![-0.5, -1.0, -1.0]; 5];

        let result = ViterbiKernel::viterbi_forward(&sequence, &match_emissions, &insert_emissions, &transitions);
        assert!(result.is_ok());
    }

    #[test]
    fn test_logsumexp_zero_values() {
        let values = vec![0.0, 0.0, 0.0];
        let result = ForwardKernel::logsumexp(&values);
        assert!(result.is_finite());
        assert!(result > 0.0);
    }

    #[test]
    fn test_logsumexp_extreme_values() {
        let values = vec![-1e10, -1e10, -1e10];
        let result = ForwardKernel::logsumexp(&values);
        assert!(result.is_finite());
        // logsumexp([-1e10, -1e10, -1e10]) ≈ -1e10 + log(3) ≈ -9.99999999989
        assert!(result <= -9.99999999e9);  // Should be very close to -1e10
    }

    #[test]
    fn test_multiple_sequence_alignment() {
        let sequences = vec![
            vec![0u8, 1u8, 2u8],
            vec![0u8, 1u8, 3u8],
            vec![1u8, 2u8, 3u8],
        ];
        let mut match_emissions = vec![vec![-1.0; NUM_AMINO_ACIDS]; 3];
        let mut insert_emissions = vec![vec![-2.0; NUM_AMINO_ACIDS]; 3];
        let mut transitions = vec![vec![-0.5, -1.0, -1.0]; 3];

        let result = BaumWelchKernel::baum_welch_iteration(
            &sequences,
            &mut match_emissions,
            &mut insert_emissions,
            &mut transitions,
            0,
        );

        assert!(result.is_ok());
    }

    #[test]
    fn test_baum_welch_convergence() {
        let sequences = vec![vec![0u8, 1u8], vec![0u8, 1u8], vec![0u8, 1u8]];
        let mut match_emissions = vec![vec![-1.0; NUM_AMINO_ACIDS]; 2];
        let mut insert_emissions = vec![vec![-2.0; NUM_AMINO_ACIDS]; 2];
        let mut transitions = vec![vec![-0.5, -1.0, -1.0]; 2];

        let result1 = BaumWelchKernel::baum_welch_iteration(
            &sequences,
            &mut match_emissions,
            &mut insert_emissions,
            &mut transitions,
            0,
        ).unwrap();

        let result2 = BaumWelchKernel::baum_welch_iteration(
            &sequences,
            &mut match_emissions,
            &mut insert_emissions,
            &mut transitions,
            1,
        ).unwrap();

        // Both iterations should have finite likelihoods
        assert!(result1.is_finite());
        assert!(result2.is_finite());
    }

    #[test]
    fn test_viterbi_all_amino_acids() {
        // Test with all 24 amino acid types
        let sequence: Vec<u8> = (0..24).collect();
        let match_emissions = vec![vec![-1.0; NUM_AMINO_ACIDS]; 24];
        let insert_emissions = vec![vec![-2.0; NUM_AMINO_ACIDS]; 24];
        let transitions = vec![vec![-0.5, -1.0, -1.0]; 24];

        let result = ViterbiKernel::viterbi_forward(&sequence, &match_emissions, &insert_emissions, &transitions);
        assert!(result.is_ok());
    }

    #[test]
    fn test_forward_score_range() {
        let sequence = vec![0u8, 1u8, 2u8];
        let match_emissions = vec![vec![-1.0; NUM_AMINO_ACIDS]; 3];
        let insert_emissions = vec![vec![-2.0; NUM_AMINO_ACIDS]; 3];
        let transitions = vec![vec![-0.5, -1.0, -1.0]; 3];

        let result1 = ForwardKernel::forward(&sequence, &match_emissions, &insert_emissions, &transitions).unwrap();
        
        // Change emissions to be less favorable
        let match_emissions2 = vec![vec![-10.0; NUM_AMINO_ACIDS]; 3];
        let result2 = ForwardKernel::forward(&sequence, &match_emissions2, &insert_emissions, &transitions).unwrap();

        // Higher scores should be less negative
        assert!(result1 > result2);
    }
}