octopeek 0.3.0

//! Detail types and GraphQL queries for on-demand PR and issue fetching.
//!
//! List-level data (inbox) is handled by [`super::query`]. This module covers
//! the richer, per-item detail fetch that is triggered when the user opens a PR
//! or issue in the TUI.

use chrono::{DateTime, Utc};
use serde::{Deserialize, Serialize};

// ── FileChangeKind ────────────────────────────────────────────────────────────

/// The kind of change applied to a file in a pull request.
///
/// Maps from GitHub's GraphQL `PatchStatus` enum whose values are
/// `SCREAMING_SNAKE_CASE`.
#[derive(Debug, Clone, Copy, PartialEq, Eq, Serialize, Deserialize)]
pub enum FileChangeKind {
    Added,
    Modified,
    Deleted,
    Renamed,
    Copied,
    /// `CHANGED` is GitHub's catch-all for submodule updates etc.
    Changed,
}

// ── FileChange ────────────────────────────────────────────────────────────────

/// A single file touched by a pull request.
#[derive(Debug, Clone, Serialize, Deserialize)]
pub struct FileChange {
    /// Repository-relative file path.
    pub path: String,
    /// Lines added in this file.
    pub additions: u32,
    /// Lines removed in this file.
    pub deletions: u32,
    /// Nature of the change.
    pub change_kind: FileChangeKind,
    /// Unified-diff patch text from the REST `pulls/{number}/files` endpoint.
    ///
    /// `None` when the file is binary, when the diff is too large for GitHub to
    /// return inline, or when the supplementary REST fetch was skipped / failed.
    #[serde(default)]
    pub patch: Option<String>,
}

// ── DetailedCheck ─────────────────────────────────────────────────────────────

/// A CI check run attached to the head commit of a pull request.
#[derive(Debug, Clone, Serialize, Deserialize)]
pub struct DetailedCheck {
    /// Name of the individual job/check step.
    pub name: String,
    /// Name of the parent GitHub Actions workflow, if available.
    pub workflow_name: Option<String>,
    /// `CheckStatusState` value (e.g. `"COMPLETED"`, `"IN_PROGRESS"`).
    pub status: String,
    /// `CheckConclusionState` value (e.g. `"SUCCESS"`, `"FAILURE"`), absent
    /// while the run is still in progress.
    pub conclusion: Option<String>,
    /// Wall-clock duration in seconds, derived from `completedAt - startedAt`.
    /// `None` if either timestamp is absent.
    pub duration_seconds: Option<u64>,
    /// URL to the detailed check-run page (if provided by GitHub).
    pub details_url: Option<String>,
}

// ── DetailedReview ────────────────────────────────────────────────────────────

/// A full review body, extending the list-level [`super::types::Review`].
#[derive(Debug, Clone, Serialize, Deserialize)]
pub struct DetailedReview {
    /// GitHub login of the reviewer.
    pub author: String,
    /// State of the review at submission time.
    pub state: crate::github::types::ReviewState,
    /// Markdown body of the review (may be empty for approve-only reviews).
    pub body_markdown: String,
    /// When the review was submitted.
    pub submitted_at: DateTime<Utc>,
}

// ── ReviewThread / ReviewComment ──────────────────────────────────────────────

/// A single inline comment on a specific line or hunk of a file.
#[derive(Debug, Clone, Serialize, Deserialize)]
pub struct ReviewComment {
    /// GraphQL node ID for this comment.
    pub node_id: String,
    /// GitHub login of the comment author.
    pub author: String,
    /// Markdown body of the comment.
    pub body_markdown: String,
    /// When the comment was posted.
    pub created_at: DateTime<Utc>,
    /// Raw unified-diff excerpt GitHub captured when the comment was posted.
    ///
    /// A `@@ -a,b +c,d @@` header plus up to ~10 lines of context ending at
    /// the commented line. All replies in the same thread share the first
    /// comment's hunk; [`ReviewThread::diff_hunk`] promotes it for
    /// convenience. `None` for older cached payloads that predate the
    /// field's addition to the query.
    #[serde(default)]
    pub diff_hunk: Option<String>,
    /// The OID of the commit this comment was originally made on.
    ///
    /// Used to scope the Comments section to threads that originated on a
    /// selected commit. `None` for older cached payloads that predate the
    /// field's addition to the query (`originalCommit { oid }`).
    #[serde(default)]
    pub original_commit_id: Option<String>,
}

/// A thread of inline review comments anchored to a file location.
///
/// A thread may contain multiple replies (`comments`). The `path` and `line`
/// fields anchor it to a specific diff location; `line` is absent for
/// file-level (non-line) threads.
#[derive(Debug, Clone, Serialize, Deserialize)]
pub struct ReviewThread {
    /// GraphQL node ID for this review thread.
    pub node_id: String,
    /// File path the thread is anchored to.
    pub path: String,
    /// Line number in the diff, if the thread is line-anchored.
    ///
    /// Resolution order: prefer `line` (current-diff coordinate) and fall
    /// back to `originalLine` (pre-rebase coordinate) in
    /// [`raw_pr_to_detail`]. Outdated threads typically only have
    /// `originalLine`, so this field is still populated — callers infer
    /// "outdated coordinate" from `is_outdated == true`.
    pub line: Option<u32>,
    /// Start line of a multi-line comment range, if any.
    ///
    /// Non-line comments and single-line anchors both have `start_line`
    /// equal to `None`; a true range has `start_line < line`. UI treatment
    /// of ranges is deferred to a later release; for now we surface the
    /// value so the header can render `"lines A-B"` on ranges.
    pub start_line: Option<u32>,
    /// `true` when all participants resolved the thread.
    pub is_resolved: bool,
    /// `true` when the thread's diff hunk no longer exists in the current diff.
    pub is_outdated: bool,
    /// Diff-hunk excerpt captured when the thread was created.
    ///
    /// Promoted from `comments[0].diff_hunk` at conversion time so renderers
    /// never have to reach into the first comment. `None` when the thread
    /// has no comments (should never happen in practice) or when the cached
    /// payload predates this field.
    #[serde(default)]
    pub diff_hunk: Option<String>,
    /// Comments within this thread, in chronological order.
    pub comments: Vec<ReviewComment>,
}

impl ReviewThread {
    /// Return the OID of the commit on which this thread was originally opened.
    ///
    /// Delegates to the first comment's `original_commit_id`, which matches
    /// the same promotion pattern used for `diff_hunk`: the thread opener's
    /// field speaks for the whole thread. Returns `None` when the field is
    /// absent (old cached payloads) or the thread has no comments.
    pub fn originating_commit_sha(&self) -> Option<&str> {
        self.comments.first()?.original_commit_id.as_deref()
    }
}

// ── IssueComment ──────────────────────────────────────────────────────────────

/// A top-level comment on a pull request or issue (not an inline review comment).
#[derive(Debug, Clone, Serialize, Deserialize)]
pub struct IssueComment {
    /// GraphQL node ID for this comment.
    pub node_id: String,
    /// GitHub login of the comment author.
    pub author: String,
    /// Markdown body of the comment.
    pub body_markdown: String,
    /// When the comment was posted.
    pub created_at: DateTime<Utc>,
}

// ── PrCommit ──────────────────────────────────────────────────────────────────

/// A single commit on a pull request.
///
/// Populated from the `commits(last: 100)` GraphQL selection. The list on
/// [`PrDetail`] is sorted **newest-first** (descending by `committed_at`) to
/// match the ordering GitHub's own Commits tab uses.
#[derive(Debug, Clone, Serialize, Deserialize)]
pub struct PrCommit {
    /// Full 40-character SHA-1 OID.
    pub sha: String,
    /// First 7 characters of `sha` — the conventional short form.
    pub short_sha: String,
    /// First line of the commit message.
    pub headline: String,
    /// `GitActor.name` (the configured Git name, not a GitHub login).
    pub author: String,
    /// When the commit was authored.
    pub committed_at: DateTime<Utc>,
    /// Lines added in this commit.
    pub additions: u32,
    /// Lines removed in this commit.
    pub deletions: u32,
    /// Number of files changed in this commit.
    pub changed_files: u32,
    /// Aggregate CI check state for this commit from `statusCheckRollup.state`.
    ///
    /// `None` when the commit has no CI configured (no `statusCheckRollup`).
    #[serde(default)]
    pub check_state: Option<crate::github::types::CheckState>,
}

// ── PrDetail ─────────────────────────────────────────────────────────────────

/// Full detail for a single pull request, fetched on-demand.
///
/// The list-level [`super::types::PullRequest`] carries only fields needed for
/// the dashboard. This type adds bodies, files, checks, reviews, and threads.
#[derive(Debug, Clone, Serialize, Deserialize)]
pub struct PrDetail {
    /// GraphQL node ID for this pull request.
    pub node_id: String,
    /// `owner/name` repository slug.
    pub repo: String,
    /// PR number within the repository.
    pub number: u32,
    /// PR title.
    pub title: String,
    /// HTML URL.
    pub url: String,
    /// Login of the PR author.
    pub author: String,
    /// Raw Markdown body of the PR description.
    pub body_markdown: String,
    /// Base branch name (e.g. `"main"`).
    pub base_ref: String,
    /// Head branch name (e.g. `"feat/xyz"`).
    pub head_ref: String,
    /// Full OID of the pull request head commit.
    pub head_oid: String,
    /// `true` when the PR is in draft state.
    pub is_draft: bool,
    /// Total lines added across all files.
    pub additions: u32,
    /// Total lines removed across all files.
    pub deletions: u32,
    /// Number of files changed.
    pub changed_files_count: u32,
    /// When the PR was last updated.
    pub updated_at: DateTime<Utc>,
    /// When the PR was created.
    pub created_at: DateTime<Utc>,
    /// `true` when the PR has been merged.
    pub merged: bool,
    /// Files changed by this PR.
    pub files: Vec<FileChange>,
    /// Check runs on the head commit (up to 50).
    pub check_runs: Vec<DetailedCheck>,
    /// Reviews left on this PR (up to 50).
    pub reviews: Vec<DetailedReview>,
    /// Inline review threads (up to 100), each with up to 20 comments.
    pub review_threads: Vec<ReviewThread>,
    /// Top-level PR comments (up to 100).
    pub issue_comments: Vec<IssueComment>,
    /// Commits on this PR (up to 100), sorted newest-first.
    pub commits: Vec<PrCommit>,
}

// ── IssueDetail ───────────────────────────────────────────────────────────────

/// Full detail for a single issue, fetched on-demand.
#[derive(Debug, Clone, Serialize, Deserialize)]
pub struct IssueDetail {
    /// GraphQL node ID for this issue.
    pub node_id: String,
    /// `owner/name` repository slug.
    pub repo: String,
    /// Issue number within the repository.
    pub number: u32,
    /// Issue title.
    pub title: String,
    /// HTML URL.
    pub url: String,
    /// Login of the issue author.
    pub author: String,
    /// Raw Markdown body of the issue.
    pub body_markdown: String,
    /// State of the issue (`"OPEN"` or `"CLOSED"`).
    pub state: String,
    /// When the issue was last updated.
    pub updated_at: DateTime<Utc>,
    /// When the issue was created.
    pub created_at: DateTime<Utc>,
    /// Labels attached to the issue.
    pub labels: Vec<crate::github::types::Label>,
    /// Logins of users assigned to this issue.
    pub assignees: Vec<String>,
    /// Top-level comments on the issue (up to 100).
    pub comments: Vec<IssueComment>,
}

// ── GraphQL query strings ─────────────────────────────────────────────────────

/// GraphQL document for fetching full PR detail.
///
/// Parameters: `$owner: String!`, `$name: String!`, `$number: Int!`
pub(super) const PR_DETAIL_QUERY: &str = r"
query PrDetail($owner: String!, $name: String!, $number: Int!) {
  repository(owner: $owner, name: $name) {
    pullRequest(number: $number) {
      id
      number
      title
      url
      isDraft
      merged
      body
      createdAt
      updatedAt
      additions
      deletions
      changedFiles
      baseRefName
      headRefName
      headRefOid
      author { login }
      files(first: 100) {
        nodes {
          path
          additions
          deletions
          changeType
        }
      }
      commits(last: 100) {
        nodes {
          commit {
            oid
            messageHeadline
            additions
            deletions
            changedFilesIfAvailable
            author {
              name
              date
            }
            statusCheckRollup {
              state
              contexts(first: 50) {
                nodes {
                  ... on CheckRun {
                    name
                    status
                    conclusion
                    startedAt
                    completedAt
                    detailsUrl
                    checkSuite {
                      workflowRun {
                        workflow { name }
                      }
                    }
                  }
                  ... on StatusContext {
                    context
                    state
                    targetUrl
                  }
                }
              }
            }
          }
        }
      }
      reviews(first: 50) {
        nodes {
          author { login }
          state
          body
          submittedAt
        }
      }
      reviewThreads(first: 100) {
        nodes {
          id
          isResolved
          isOutdated
          path
          line
          originalLine
          startLine
          originalStartLine
          comments(first: 20) {
            nodes {
              id
              author { login }
              body
              createdAt
              diffHunk
              originalCommit { oid }
            }
          }
        }
      }
      comments(first: 100) {
        nodes {
          id
          author { login }
          body
          createdAt
        }
      }
    }
  }
}
";

/// GraphQL document for fetching full issue detail.
///
/// Parameters: `$owner: String!`, `$name: String!`, `$number: Int!`
pub(super) const ISSUE_DETAIL_QUERY: &str = r"
query IssueDetail($owner: String!, $name: String!, $number: Int!) {
  repository(owner: $owner, name: $name) {
    issue(number: $number) {
      id
      number
      title
      url
      body
      state
      createdAt
      updatedAt
      author { login }
      labels(first: 30) {
        nodes {
          name
          color
        }
      }
      assignees(first: 20) {
        nodes { login }
      }
      comments(first: 100) {
        nodes {
          id
          author { login }
          body
          createdAt
        }
      }
    }
  }
}
";

// ── Raw deserialization types ─────────────────────────────────────────────────
//
// These mirror the GraphQL response shape exactly.  They are private; callers
// always receive the public domain structs above. The top-level envelope
// (`data` / `errors`) is the generic `GqlEnvelope<RawDetailData>` defined in
// `super::query` so the HTTP client can share one helper across every query.

#[derive(Debug, Deserialize)]
pub(super) struct RawDetailData {
    pub repository: Option<RawDetailRepository>,
}

#[derive(Debug, Deserialize)]
#[serde(rename_all = "camelCase")]
pub(super) struct RawDetailRepository {
    pub pull_request: Option<RawPrDetail>,
    pub issue: Option<RawIssueDetail>,
}

#[derive(Debug, Deserialize)]
#[serde(rename_all = "camelCase")]
pub(super) struct RawPrDetail {
    pub id: String,
    pub number: u32,
    pub title: String,
    pub url: String,
    pub is_draft: bool,
    pub merged: bool,
    pub body: Option<String>,
    pub created_at: DateTime<Utc>,
    pub updated_at: DateTime<Utc>,
    pub additions: u32,
    pub deletions: u32,
    pub changed_files: u32,
    pub base_ref_name: String,
    pub head_ref_name: String,
    pub head_ref_oid: String,
    pub author: Option<RawDetailActor>,
    pub files: RawNodeList<RawFileNode>,
    pub commits: RawNodeList<RawDetailCommitNode>,
    pub reviews: RawNodeList<RawReviewNode>,
    pub review_threads: RawNodeList<RawReviewThreadNode>,
    pub comments: RawNodeList<RawCommentNode>,
}

#[derive(Debug, Deserialize)]
#[serde(rename_all = "camelCase")]
pub(super) struct RawIssueDetail {
    pub id: String,
    pub number: u32,
    pub title: String,
    pub url: String,
    pub body: Option<String>,
    pub state: String,
    pub created_at: DateTime<Utc>,
    pub updated_at: DateTime<Utc>,
    pub author: Option<RawDetailActor>,
    pub labels: RawNodeList<RawLabelNode>,
    pub assignees: RawNodeList<RawDetailActor>,
    pub comments: RawNodeList<RawCommentNode>,
}

#[derive(Debug, Deserialize)]
pub(super) struct RawDetailActor {
    pub login: String,
}

#[derive(Debug, Deserialize)]
pub(super) struct RawNodeList<T> {
    pub nodes: Vec<T>,
}

#[derive(Debug, Deserialize)]
#[serde(rename_all = "camelCase")]
pub(super) struct RawFileNode {
    pub path: String,
    pub additions: u32,
    pub deletions: u32,
    pub change_type: String,
}

#[derive(Debug, Deserialize)]
pub(super) struct RawDetailCommitNode {
    pub commit: RawDetailCommit,
}

#[derive(Debug, Deserialize)]
#[serde(rename_all = "camelCase")]
pub(super) struct RawDetailCommit {
    /// Full 40-character SHA-1.
    pub oid: String,
    /// First line of the commit message.
    pub message_headline: String,
    /// Lines added in this commit.
    pub additions: u32,
    /// Lines removed in this commit.
    pub deletions: u32,
    /// Number of changed files; nullable in the GraphQL schema.
    pub changed_files_if_available: Option<u32>,
    /// Authorship metadata (name + date).
    pub author: Option<RawDetailCommitAuthor>,
    pub status_check_rollup: Option<RawDetailRollup>,
}

/// `GitActor` sub-selection: name and date only (no login — bots lack logins).
#[derive(Debug, Deserialize)]
pub(super) struct RawDetailCommitAuthor {
    /// Configured Git author name (not a GitHub login).
    pub name: Option<String>,
    /// Author date in ISO-8601 format.
    pub date: Option<DateTime<Utc>>,
}

#[derive(Debug, Deserialize)]
pub(super) struct RawDetailRollup {
    /// Aggregate state across all check contexts for this commit.
    pub state: crate::github::types::CheckState,
    pub contexts: RawNodeList<RawDetailCheckContext>,
}

/// Inline-fragment union: either a `CheckRun` or a `StatusContext`.
///
/// `serde`'s `untagged` enum tries each variant in order; `RawDetailCheckRun`
/// is tried first because it has a `name` field that `RawDetailStatusContext`
/// does not (it uses `context`).
#[derive(Debug, Deserialize)]
#[serde(untagged)]
pub(super) enum RawDetailCheckContext {
    CheckRun(RawDetailCheckRun),
    StatusContext(RawDetailStatusContext),
}

#[derive(Debug, Deserialize)]
#[serde(rename_all = "camelCase")]
pub(super) struct RawDetailCheckRun {
    pub name: String,
    pub status: String,
    pub conclusion: Option<String>,
    pub started_at: Option<DateTime<Utc>>,
    pub completed_at: Option<DateTime<Utc>>,
    pub details_url: Option<String>,
    pub check_suite: Option<RawDetailCheckSuite>,
}

#[derive(Debug, Deserialize)]
#[serde(rename_all = "camelCase")]
pub(super) struct RawDetailStatusContext {
    pub context: String,
    pub state: String,
    pub target_url: Option<String>,
}

#[derive(Debug, Deserialize)]
#[serde(rename_all = "camelCase")]
pub(super) struct RawDetailCheckSuite {
    pub workflow_run: Option<RawDetailWorkflowRun>,
}

#[derive(Debug, Deserialize)]
pub(super) struct RawDetailWorkflowRun {
    pub workflow: Option<RawDetailWorkflow>,
}

#[derive(Debug, Deserialize)]
pub(super) struct RawDetailWorkflow {
    pub name: String,
}

#[derive(Debug, Deserialize)]
#[serde(rename_all = "camelCase")]
pub(super) struct RawReviewNode {
    pub author: Option<RawDetailActor>,
    pub state: crate::github::types::ReviewState,
    pub body: Option<String>,
    pub submitted_at: DateTime<Utc>,
}

#[derive(Debug, Deserialize)]
#[serde(rename_all = "camelCase")]
pub(super) struct RawReviewThreadNode {
    pub id: String,
    pub is_resolved: bool,
    pub is_outdated: bool,
    pub path: String,
    /// Preferred line field; falls back to `original_line` when absent.
    pub line: Option<u32>,
    pub original_line: Option<u32>,
    pub start_line: Option<u32>,
    pub original_start_line: Option<u32>,
    pub comments: RawNodeList<RawCommentNode>,
}

#[derive(Debug, Deserialize)]
pub(super) struct RawDetailOriginalCommit {
    pub oid: String,
}

#[derive(Debug, Deserialize)]
#[serde(rename_all = "camelCase")]
pub(super) struct RawCommentNode {
    pub id: String,
    pub author: Option<RawDetailActor>,
    pub body: Option<String>,
    pub created_at: DateTime<Utc>,
    /// Unified-diff excerpt anchoring this comment.
    ///
    /// Present on review-thread comments; absent (and thus `None` via
    /// `#[serde(default)]`) on issue-level comments that share this node
    /// shape but don't expose `diffHunk` in the query.
    #[serde(default)]
    pub diff_hunk: Option<String>,
    /// The commit on which this comment was originally made.
    ///
    /// Present on review-thread comments; absent on issue-level comments.
    #[serde(default)]
    pub original_commit: Option<RawDetailOriginalCommit>,
}

/// Convert a raw GraphQL comment node into the public [`IssueComment`] type.
///
/// The same shape appears on a PR (`raw_pr_to_detail`) and on an issue
/// (`raw_issue_to_detail`); this helper keeps the deleted-author sentinel
/// and the `body.unwrap_or_default()` handling in one place.
fn map_comment_node(c: RawCommentNode) -> IssueComment {
    IssueComment {
        node_id: c.id,
        author: crate::github::author_or_deleted(c.author.map(|a| a.login)),
        body_markdown: c.body.unwrap_or_default(),
        created_at: c.created_at,
    }
}

#[derive(Debug, Deserialize)]
pub(super) struct RawLabelNode {
    pub name: String,
    pub color: String,
}

// ── Domain conversion helpers ─────────────────────────────────────────────────

/// Parse a `changeType` `SCREAMING_SNAKE_CASE` string into [`FileChangeKind`].
///
/// Unknown values fall back to [`FileChangeKind::Changed`] to avoid panics on
/// future GitHub API additions.
fn parse_change_kind(s: &str) -> FileChangeKind {
    match s {
        "ADDED" => FileChangeKind::Added,
        "MODIFIED" => FileChangeKind::Modified,
        "DELETED" => FileChangeKind::Deleted,
        "RENAMED" => FileChangeKind::Renamed,
        "COPIED" => FileChangeKind::Copied,
        // CHANGED and any future unknown values.
        _ => FileChangeKind::Changed,
    }
}

/// Convert a [`RawPrDetail`] to the public [`PrDetail`] domain type.
///
/// The `repo` slug is threaded in from the caller (it is not present in the
/// PR-level GraphQL fragment).
#[allow(clippy::too_many_lines)]
pub(super) fn raw_pr_to_detail(repo: String, raw: RawPrDetail) -> PrDetail {
    let files = raw
        .files
        .nodes
        .into_iter()
        .map(|f| FileChange {
            path: f.path,
            additions: f.additions,
            deletions: f.deletions,
            change_kind: parse_change_kind(&f.change_type),
            patch: None,
        })
        .collect();

    // Materialise the commit node list once so we can walk it twice: once to
    // extract the last commit's CI rollup and once to build the commits list.
    // GraphQL returns commits oldest-first; `last: 100` means the final element
    // is the HEAD commit whose `statusCheckRollup` we use for the Checks section.
    let commit_nodes: Vec<RawDetailCommitNode> = raw.commits.nodes;

    // Dig into commits → last (HEAD) commit → statusCheckRollup → contexts.
    let check_runs = commit_nodes
        .last()
        .and_then(|cn| cn.commit.status_check_rollup.as_ref())
        .map(|rollup| {
            rollup
                .contexts
                .nodes
                .iter()
                .map(|ctx| match ctx {
                    RawDetailCheckContext::CheckRun(cr) => {
                        // Compute duration from the two nullable timestamps.
                        // Both must be `Some` and `completed >= started`.
                        let duration_seconds =
                            cr.started_at.zip(cr.completed_at).and_then(|(s, c)| {
                                let delta = c.signed_duration_since(s).num_seconds();
                                // Cast is safe: negative duration means clock skew;
                                // treat as None rather than wrapping to a huge value.
                                if delta >= 0 {
                                    #[allow(clippy::cast_sign_loss)]
                                    Some(delta as u64)
                                } else {
                                    None
                                }
                            });

                        let workflow_name = cr
                            .check_suite
                            .as_ref()
                            .and_then(|cs| cs.workflow_run.as_ref())
                            .and_then(|wr| wr.workflow.as_ref())
                            .map(|w| w.name.clone());

                        DetailedCheck {
                            name: cr.name.clone(),
                            workflow_name,
                            status: cr.status.clone(),
                            conclusion: cr.conclusion.clone(),
                            duration_seconds,
                            details_url: cr.details_url.clone(),
                        }
                    }
                    RawDetailCheckContext::StatusContext(sc) => DetailedCheck {
                        name: sc.context.clone(),
                        workflow_name: None,
                        status: "COMPLETED".to_owned(),
                        conclusion: Some(sc.state.clone()),
                        duration_seconds: None,
                        details_url: sc.target_url.clone(),
                    },
                })
                .collect()
        })
        .unwrap_or_default();

    // Build the commits list. GraphQL returns oldest-first; we reverse to get
    // newest-first, matching GitHub's own Commits tab ordering.
    let mut commits: Vec<PrCommit> = commit_nodes
        .into_iter()
        .filter_map(|cn| {
            let c = cn.commit;
            // `author` and `author.date` can be null for pathological commits;
            // skip those rather than surfacing a blank row in the UI.
            let author_node = c.author?;
            let committed_at = author_node.date?;
            let author = author_node.name.unwrap_or_else(|| "unknown".to_owned());
            let short_sha: String = c.oid.chars().take(7).collect();
            // Extract the aggregate CI state from the commit's rollup.
            // The `contexts` sub-selection is only used for the HEAD commit's
            // Checks section; for all other commits we only need the top-level
            // `state` scalar.
            let check_state = c.status_check_rollup.map(|r| r.state);
            Some(PrCommit {
                sha: c.oid,
                short_sha,
                headline: c.message_headline,
                author,
                committed_at,
                additions: c.additions,
                deletions: c.deletions,
                changed_files: c.changed_files_if_available.unwrap_or(0),
                check_state,
            })
        })
        .collect();
    // Sort descending by committed_at so newest commit is first (index 0).
    commits.sort_unstable_by_key(|commit| std::cmp::Reverse(commit.committed_at));

    let reviews = raw
        .reviews
        .nodes
        .into_iter()
        .filter_map(|r| {
            // Reviews without an author login are bot-generated or deleted
            // accounts — skip them rather than surfacing a blank name.
            r.author.map(|a| DetailedReview {
                author: a.login,
                state: r.state,
                body_markdown: r.body.unwrap_or_default(),
                submitted_at: r.submitted_at,
            })
        })
        .collect();

    // Each thread node carries a list of comment nodes. We flatten the nested
    // structure into `ReviewThread { comments: Vec<ReviewComment> }`.
    let review_threads = raw
        .review_threads
        .nodes
        .into_iter()
        .map(|t| {
            // `line` is the current-diff line; `original_line` is the pre-rebase
            // line. Prefer `line` (most useful for display); fall back to
            // `original_line` when the hunk has shifted. Same resolution order
            // for the multi-line `start_line` range.
            let line = t.line.or(t.original_line);
            let start_line = t.start_line.or(t.original_start_line);

            let comments: Vec<ReviewComment> = t
                .comments
                .nodes
                .into_iter()
                .map(|c| ReviewComment {
                    node_id: c.id,
                    author: crate::github::author_or_deleted(c.author.map(|a| a.login)),
                    body_markdown: c.body.unwrap_or_default(),
                    created_at: c.created_at,
                    diff_hunk: c.diff_hunk,
                    original_commit_id: c.original_commit.map(|oc| oc.oid),
                })
                .collect();

            // Promote the first comment's diff hunk to the thread level so
            // renderers can ignore the comments list when they only need the
            // code context. All replies in a thread share the opener's hunk.
            let diff_hunk = comments.first().and_then(|c| c.diff_hunk.clone());

            ReviewThread {
                node_id: t.id,
                path: t.path,
                line,
                start_line,
                is_resolved: t.is_resolved,
                is_outdated: t.is_outdated,
                diff_hunk,
                comments,
            }
        })
        .collect();

    let issue_comments = raw.comments.nodes.into_iter().map(map_comment_node).collect();

    PrDetail {
        node_id: raw.id,
        repo,
        number: raw.number,
        title: raw.title,
        url: raw.url,
        author: crate::github::author_or_deleted(raw.author.map(|a| a.login)),
        body_markdown: raw.body.unwrap_or_default(),
        base_ref: raw.base_ref_name,
        head_ref: raw.head_ref_name,
        head_oid: raw.head_ref_oid,
        is_draft: raw.is_draft,
        additions: raw.additions,
        deletions: raw.deletions,
        changed_files_count: raw.changed_files,
        updated_at: raw.updated_at,
        created_at: raw.created_at,
        merged: raw.merged,
        files,
        check_runs,
        reviews,
        review_threads,
        issue_comments,
        commits,
    }
}

/// Convert a [`RawIssueDetail`] to the public [`IssueDetail`] domain type.
pub(super) fn raw_issue_to_detail(repo: String, raw: RawIssueDetail) -> IssueDetail {
    let labels = raw
        .labels
        .nodes
        .into_iter()
        .map(|l| crate::github::types::Label { name: l.name, color: l.color })
        .collect();

    let assignees = raw.assignees.nodes.into_iter().map(|a| a.login).collect();

    let comments = raw.comments.nodes.into_iter().map(map_comment_node).collect();

    IssueDetail {
        node_id: raw.id,
        repo,
        number: raw.number,
        title: raw.title,
        url: raw.url,
        author: crate::github::author_or_deleted(raw.author.map(|a| a.login)),
        body_markdown: raw.body.unwrap_or_default(),
        state: raw.state,
        updated_at: raw.updated_at,
        created_at: raw.created_at,
        labels,
        assignees,
        comments,
    }
}

// ── Tests ─────────────────────────────────────────────────────────────────────

#[cfg(test)]
#[allow(clippy::expect_used, clippy::too_many_lines)]
mod tests {
    use super::*;
    use crate::github::query::GqlEnvelope;

    /// Type alias kept private to the test module so the existing test names
    /// stay unchanged. The envelope is now generic in non-test code.
    type RawDetailResponse = GqlEnvelope<RawDetailData>;

    // ── Fixture helpers ───────────────────────────────────────────────────────

    fn pr_detail_fixture() -> serde_json::Value {
        serde_json::json!({
            "data": {
                "repository": {
                    "pullRequest": {
                        "id": "PR_kwfixture",
                        "number": 42,
                        "title": "feat: add dark mode",
                        "url": "https://github.com/owner/repo/pull/42",
                        "isDraft": false,
                        "merged": false,
                        "body": "## Summary\nAdds dark mode support.",
                        "createdAt": "2024-01-01T10:00:00Z",
                        "updatedAt": "2024-01-02T12:00:00Z",
                        "additions": 150,
                        "deletions": 30,
                        "changedFiles": 5,
                        "baseRefName": "main",
                        "headRefName": "feat/dark-mode",
                        "headRefOid": "abc1234567890abcdef1234567890abcdef123456",
                        "author": { "login": "alice" },
                        "files": {
                            "nodes": [
                                {
                                    "path": "src/theme.rs",
                                    "additions": 100,
                                    "deletions": 10,
                                    "changeType": "MODIFIED"
                                },
                                {
                                    "path": "src/new_file.rs",
                                    "additions": 50,
                                    "deletions": 0,
                                    "changeType": "ADDED"
                                }
                            ]
                        },
                        "commits": {
                            "nodes": [{
                                "commit": {
                                    "oid": "abc1234567890abcdef1234567890abcdef123456",
                                    "messageHeadline": "feat: add dark mode",
                                    "additions": 150,
                                    "deletions": 30,
                                    "changedFilesIfAvailable": 5,
                                    "author": {
                                        "name": "Alice Dev",
                                        "date": "2024-01-02T10:00:00Z"
                                    },
                                    "statusCheckRollup": {
                                        "state": "SUCCESS",
                                        "contexts": {
                                            "nodes": [{
                                                "name": "ci / build",
                                                "status": "COMPLETED",
                                                "conclusion": "SUCCESS",
                                                "startedAt": "2024-01-02T11:00:00Z",
                                                "completedAt": "2024-01-02T11:05:00Z",
                                                "detailsUrl": "https://github.com/checks/1",
                                                "checkSuite": {
                                                    "workflowRun": {
                                                        "workflow": { "name": "CI" }
                                                    }
                                                }
                                            }]
                                        }
                                    }
                                }
                            }]
                        },
                        "reviews": {
                            "nodes": [{
                                "author": { "login": "bob" },
                                "state": "APPROVED",
                                "body": "LGTM!",
                                "submittedAt": "2024-01-02T09:00:00Z"
                            }]
                        },
                        "reviewThreads": {
                            "nodes": [{
                                "id": "PRRT_kwfixture",
                                "isResolved": false,
                                "isOutdated": false,
                                "path": "src/theme.rs",
                                "line": 42,
                                "originalLine": 40,
                                "comments": {
                                    "nodes": [
                                        {
                                            "id": "PRRC_kwfixture1",
                                            "author": { "login": "bob" },
                                            "body": "Consider extracting this constant.",
                                            "createdAt": "2024-01-02T09:05:00Z"
                                        },
                                        {
                                            "id": "PRRC_kwfixture2",
                                            "author": { "login": "alice" },
                                            "body": "Good point, will do.",
                                            "createdAt": "2024-01-02T09:10:00Z"
                                        }
                                    ]
                                }
                            }]
                        },
                        "comments": {
                            "nodes": [{
                                "id": "IC_kwfixture1",
                                "author": { "login": "carol" },
                                "body": "Nice work!",
                                "createdAt": "2024-01-02T10:00:00Z"
                            }]
                        }
                    }
                }
            }
        })
    }

    fn issue_detail_fixture() -> serde_json::Value {
        serde_json::json!({
            "data": {
                "repository": {
                    "issue": {
                        "id": "I_kwfixture",
                        "number": 7,
                        "title": "Bug: crash on empty config",
                        "url": "https://github.com/owner/repo/issues/7",
                        "body": "Reproducible with an empty `config.toml`.",
                        "state": "OPEN",
                        "createdAt": "2024-01-01T08:00:00Z",
                        "updatedAt": "2024-01-01T09:00:00Z",
                        "author": { "login": "dave" },
                        "labels": {
                            "nodes": [
                                { "name": "bug", "color": "ee0701" }
                            ]
                        },
                        "assignees": {
                            "nodes": [{ "login": "alice" }]
                        },
                        "comments": {
                            "nodes": [{
                                "id": "IC_kwfixture2",
                                "author": { "login": "bob" },
                                "body": "I can reproduce this too.",
                                "createdAt": "2024-01-01T08:30:00Z"
                            }]
                        }
                    }
                }
            }
        })
    }

    // ── Deserialization tests ─────────────────────────────────────────────────

    /// Full PR detail fixture must deserialise and convert to `PrDetail`.
    #[test]
    fn pr_detail_deserialises_correctly() {
        let json = pr_detail_fixture();
        let raw: RawDetailResponse = serde_json::from_value(json).expect("deserialise");
        let repo_raw = raw
            .data
            .expect("data")
            .repository
            .expect("repository")
            .pull_request
            .expect("pull_request");
        let detail = raw_pr_to_detail("owner/repo".to_owned(), repo_raw);

        assert_eq!(detail.number, 42);
        assert_eq!(detail.author, "alice");
        assert_eq!(detail.base_ref, "main");
        assert_eq!(detail.head_ref, "feat/dark-mode");
        assert_eq!(detail.additions, 150);
        assert_eq!(detail.changed_files_count, 5);
        assert!(!detail.merged);
    }

    /// Full issue detail fixture must deserialise and convert to `IssueDetail`.
    #[test]
    fn issue_detail_deserialises_correctly() {
        let json = issue_detail_fixture();
        let raw: RawDetailResponse = serde_json::from_value(json).expect("deserialise");
        let repo_raw =
            raw.data.expect("data").repository.expect("repository").issue.expect("issue");
        let detail = raw_issue_to_detail("owner/repo".to_owned(), repo_raw);

        assert_eq!(detail.number, 7);
        assert_eq!(detail.state, "OPEN");
        assert_eq!(detail.assignees, vec!["alice"]);
        assert_eq!(detail.labels.len(), 1);
        assert_eq!(detail.labels[0].name, "bug");
        assert_eq!(detail.comments.len(), 1);
    }

    // ── FileChangeKind mapping ────────────────────────────────────────────────

    /// All documented `changeType` values must map to the correct enum variant.
    #[test]
    fn file_change_kind_all_variants() {
        assert_eq!(parse_change_kind("ADDED"), FileChangeKind::Added);
        assert_eq!(parse_change_kind("MODIFIED"), FileChangeKind::Modified);
        assert_eq!(parse_change_kind("DELETED"), FileChangeKind::Deleted);
        assert_eq!(parse_change_kind("RENAMED"), FileChangeKind::Renamed);
        assert_eq!(parse_change_kind("COPIED"), FileChangeKind::Copied);
        assert_eq!(parse_change_kind("CHANGED"), FileChangeKind::Changed);
    }

    /// Unknown `changeType` values must fall back to `Changed` without panicking.
    #[test]
    fn file_change_kind_unknown_falls_back() {
        assert_eq!(parse_change_kind("FUTURE_VARIANT"), FileChangeKind::Changed);
    }

    // ── duration_seconds computation ──────────────────────────────────────────

    /// `duration_seconds` must be computed correctly from `startedAt` / `completedAt`.
    #[test]
    fn check_run_duration_computed() {
        let json = pr_detail_fixture();
        let raw: RawDetailResponse = serde_json::from_value(json).expect("deserialise");
        let repo_raw = raw
            .data
            .expect("data")
            .repository
            .expect("repository")
            .pull_request
            .expect("pull_request");
        let detail = raw_pr_to_detail("owner/repo".to_owned(), repo_raw);

        assert_eq!(detail.check_runs.len(), 1);
        // 11:05 − 11:00 = 300 seconds
        assert_eq!(detail.check_runs[0].duration_seconds, Some(300));
        assert_eq!(detail.check_runs[0].workflow_name.as_deref(), Some("CI"));
    }

    /// A check run with only `startedAt` set (still in progress) must have
    /// `duration_seconds == None`.
    #[test]
    fn check_run_duration_none_when_incomplete() {
        // Build a minimal PR JSON with only startedAt set.
        let json = serde_json::json!({
            "id": "PR_kwduration",
            "number": 1, "title": "t", "url": "u", "isDraft": false, "merged": false,
            "body": null, "createdAt": "2024-01-01T00:00:00Z",
            "updatedAt": "2024-01-01T00:00:00Z",
            "additions": 0, "deletions": 0, "changedFiles": 0,
            "baseRefName": "main", "headRefName": "feat",
            "headRefOid": "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa",
            "author": null,
            "files": { "nodes": [] },
            "commits": { "nodes": [{
                "commit": {
                    "oid": "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa",
                    "messageHeadline": "wip",
                    "additions": 0,
                    "deletions": 0,
                    "changedFilesIfAvailable": null,
                    "author": { "name": "dev", "date": "2024-01-01T00:00:00Z" },
                    "statusCheckRollup": { "state": "PENDING", "contexts": { "nodes": [{
                        "name": "build",
                        "status": "IN_PROGRESS",
                        "conclusion": null,
                        "startedAt": "2024-01-01T00:00:00Z",
                        "completedAt": null,
                        "detailsUrl": null,
                        "checkSuite": null
                    }] } }
                }
            }] },
            "reviews": { "nodes": [] },
            "reviewThreads": { "nodes": [] },
            "comments": { "nodes": [] }
        });
        let raw: RawPrDetail = serde_json::from_value(json).expect("deserialise");
        let detail = raw_pr_to_detail("owner/repo".to_owned(), raw);
        assert_eq!(detail.check_runs[0].duration_seconds, None);
    }

    // ── ReviewThread multi-comment ────────────────────────────────────────────

    /// A thread with two comments must produce exactly two `ReviewComment` items
    /// in the correct order.
    #[test]
    fn review_thread_preserves_comment_order() {
        let json = pr_detail_fixture();
        let raw: RawDetailResponse = serde_json::from_value(json).expect("deserialise");
        let repo_raw = raw
            .data
            .expect("data")
            .repository
            .expect("repository")
            .pull_request
            .expect("pull_request");
        let detail = raw_pr_to_detail("owner/repo".to_owned(), repo_raw);

        assert_eq!(detail.review_threads.len(), 1);
        let thread = &detail.review_threads[0];
        assert_eq!(thread.comments.len(), 2);
        assert_eq!(thread.comments[0].author, "bob");
        assert_eq!(thread.comments[1].author, "alice");
        // `line` should prefer the `line` field over `originalLine`.
        assert_eq!(thread.line, Some(42));
    }
}