ocsp-stapler 0.4.9

OCSP stapler & client with support for Rustls
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
use std::{
    collections::BTreeMap,
    fmt::{self, Display},
    sync::Arc,
    time::{Duration, Instant},
};

use anyhow::{anyhow, Context, Error};
use arc_swap::ArcSwapOption;
use chrono::{DateTime, FixedOffset, Utc};
use rasn_ocsp::CertStatus;
use rustls::{
    server::{ClientHello, ResolvesServerCert},
    sign::CertifiedKey,
};
use sha1::{Digest, Sha1};
use tokio::sync::mpsc;
use tokio_util::{sync::CancellationToken, task::TaskTracker};
use tracing::{info, warn};
use x509_parser::prelude::*;

#[cfg(feature = "prometheus")]
use prometheus::{
    register_histogram_vec_with_registry, register_int_counter_vec_with_registry,
    register_int_gauge_vec_with_registry, HistogramVec, IntCounterVec, IntGaugeVec, Registry,
};

#[cfg(feature = "prometheus")]
use itertools::Itertools;

use super::{client::Client, Validity, LEEWAY};

type Storage = BTreeMap<Fingerprint, Cert>;

// Uniquely identifies the certificate, contains SHA-1 of the whole certificate body
#[derive(Clone, Hash, PartialEq, Eq, PartialOrd, Ord)]
struct Fingerprint([u8; 20]);

impl From<&CertifiedKey> for Fingerprint {
    fn from(v: &CertifiedKey) -> Self {
        let digest = Sha1::digest(v.cert[0].as_ref());
        Self(digest.into())
    }
}

#[derive(PartialEq, Eq)]
enum RefreshResult {
    StillValid,
    Refreshed,
}

#[derive(Clone)]
struct Cert {
    ckey: Arc<CertifiedKey>,
    subject: String,
    status: CertStatus,
    cert_validity: Validity,
    ocsp_validity: Option<Validity>,
}

impl Display for Cert {
    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
        write!(f, "{}", self.subject)
    }
}

#[cfg(feature = "prometheus")]
#[derive(Clone)]
struct Metrics {
    resolves: IntCounterVec,
    ocsp_requests: IntCounterVec,
    ocsp_requests_duration: HistogramVec,
    certificate_count: IntGaugeVec,
}

#[cfg(feature = "prometheus")]
impl Metrics {
    fn new(registry: &Registry) -> Self {
        Self {
            resolves: register_int_counter_vec_with_registry!(
                format!("ocsp_resolves_total"),
                format!("Counts the number of certificate resolve requests"),
                &["stapled"],
                registry
            )
            .unwrap(),

            ocsp_requests: register_int_counter_vec_with_registry!(
                format!("ocsp_requests_total"),
                format!("Counts the number of OCSP requests"),
                &["status"],
                registry
            )
            .unwrap(),

            ocsp_requests_duration: register_histogram_vec_with_registry!(
                format!("ocsp_requests_duration"),
                format!("Observes OCSP requests duration"),
                &["status"],
                registry
            )
            .unwrap(),

            certificate_count: register_int_gauge_vec_with_registry!(
                format!("ocsp_certificate_count"),
                format!("Current number of certificates in storage"),
                &["status"],
                registry
            )
            .unwrap(),
        }
    }
}

/// Implements OCSP certificate stapling
pub struct Stapler {
    tx: mpsc::Sender<(Fingerprint, Arc<CertifiedKey>)>,
    storage: Arc<ArcSwapOption<Storage>>,
    inner: Arc<dyn ResolvesServerCert>,
    tracker: TaskTracker,
    token: CancellationToken,
    #[cfg(feature = "prometheus")]
    metrics: Option<Metrics>,
}

impl Stapler {
    /// Creates a Stapler with a default OCSP Client and no metrics
    #[cfg(feature = "prometheus")]
    pub fn new(inner: Arc<dyn ResolvesServerCert>) -> Self {
        Self::new_with_client_and_registry(inner, Client::new(), None)
    }

    /// Creates a Stapler with a default OCSP Client and Registry
    #[cfg(feature = "prometheus")]
    pub fn new_with_registry(inner: Arc<dyn ResolvesServerCert>, registry: &Registry) -> Self {
        Self::new_with_client_and_registry(inner, Client::new(), Some(registry))
    }

    /// Creates a Stapler with a provided OCSP Client and no metrics
    #[cfg(feature = "prometheus")]
    pub fn new_with_client(inner: Arc<dyn ResolvesServerCert>, client: Client) -> Self {
        Self::new_with_client_and_registry(inner, client, None)
    }

    /// Creates a Stapler with a provided OCSP Client and Registry
    #[cfg(feature = "prometheus")]
    pub fn new_with_client_and_registry(
        inner: Arc<dyn ResolvesServerCert>,
        client: Client,
        registry: Option<&Registry>,
    ) -> Self {
        let (tx, rx) = mpsc::channel(1024);
        let storage = Arc::new(ArcSwapOption::empty());
        let tracker = TaskTracker::new();
        let token = CancellationToken::new();
        let metrics = registry.map(Metrics::new);

        let mut actor = StaplerActor {
            client,
            storage: BTreeMap::new(),
            rx,
            published: storage.clone(),
            metrics: metrics.clone(),
        };

        // Spawn the background task
        let actor_token = token.clone();
        tracker.spawn(async move {
            actor.run(actor_token).await;
        });

        Self {
            tx,
            storage,
            inner,
            tracker,
            token,
            metrics,
        }
    }

    /// Creates a Stapler with a default OCSP Client and no metrics
    #[cfg(not(feature = "prometheus"))]
    pub fn new(inner: Arc<dyn ResolvesServerCert>) -> Self {
        Self::new_with_client(inner, Client::new())
    }

    /// Creates a Stapler with a default OCSP Client and no metrics (without Prometheus support)
    #[cfg(not(feature = "prometheus"))]
    pub fn new_with_client(inner: Arc<dyn ResolvesServerCert>, client: Client) -> Self {
        let (tx, rx) = mpsc::channel(1024);
        let storage = Arc::new(ArcSwapOption::empty());
        let tracker = TaskTracker::new();
        let token = CancellationToken::new();

        let mut actor = StaplerActor {
            client,
            storage: BTreeMap::new(),
            rx,
            published: storage.clone(),
        };

        // Spawn the background task
        let actor_token = token.clone();
        tracker.spawn(async move {
            actor.run(actor_token).await;
        });

        Self {
            tx,
            storage,
            inner,
            tracker,
            token,
        }
    }

    /// Preloads the certificate into the Stapler before the request to resolve() comes.
    /// This allows e.g. to load certificates with `Must-Staple` extension in a way that
    /// when the first request comes they're already stapled.
    /// Has no effect if the same certificate was already preloaded. Silently discards the certificate
    /// if it's not correct (doens't have the issuer, out of validity window etc)
    pub fn preload(&self, ckey: Arc<CertifiedKey>) {
        if ckey.cert.len() < 2 {
            return;
        }

        let fp = Fingerprint::from(ckey.as_ref());
        let _ = self.tx.try_send((fp, ckey));
    }

    /// Returns the certificate revocation status of the provided CertifiedKey.
    /// It will be None if no successful OCSP request was made.
    pub fn status(&self, ckey: Arc<CertifiedKey>) -> Option<CertStatus> {
        if ckey.cert.len() < 2 {
            return None;
        }

        let fp = Fingerprint::from(ckey.as_ref());
        Some(self.storage.load_full()?.get(&fp)?.status.clone())
    }

    /// Tells the background worker to stop and waits until it does
    pub async fn stop(&self) {
        self.token.cancel();
        self.tracker.close();
        self.tracker.wait().await;
    }

    fn staple(&self, ckey: Arc<CertifiedKey>) -> (Arc<CertifiedKey>, bool) {
        // Check that we have at least two certificates in the chain.
        // Otherwise we can't staple it since we need an issuer certificate too.
        // In this case just return it back unstapled.
        if ckey.cert.len() < 2 {
            return (ckey, false);
        }

        // Compute the fingerprint
        let fp = Fingerprint::from(ckey.as_ref());

        // See if the storage is already published
        if let Some(map) = self.storage.load_full() {
            // Check if we have a certificate with this fingerprint
            if let Some(v) = map.get(&fp) {
                // Check if its OCSP validity is set
                // Otherwise it hasn't been yet stapled or OCSP response has expired
                if v.ocsp_validity.is_some() {
                    return (v.ckey.clone(), true);
                }

                // Return unstapled
                return (ckey, false);
            }
        }

        // In some rare cases of very high load the messages can be lost but since they'll be
        // sent again by subsequent requests - it's not a problem.
        let _ = self.tx.try_send((fp, ckey.clone()));

        // Return the original unstapled cert
        (ckey, false)
    }
}

/// Debug is required for ResolvesServerCert trait
impl fmt::Debug for Stapler {
    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
        write!(f, "OcspStapler")
    }
}

impl ResolvesServerCert for Stapler {
    fn resolve(&self, client_hello: ClientHello) -> Option<Arc<CertifiedKey>> {
        // Try to get the cert from the wrapped resolver
        let ckey = self.inner.resolve(client_hello)?;

        // Process it through stapler
        #[cfg(feature = "prometheus")]
        let (ckey, stapled) = self.staple(ckey);

        #[cfg(not(feature = "prometheus"))]
        let (ckey, _stapled) = self.staple(ckey);

        // Record metrics
        #[cfg(feature = "prometheus")]
        if let Some(v) = &self.metrics {
            v.resolves
                .with_label_values(&[if stapled { "yes" } else { "no" }])
                .inc();
        }

        Some(ckey)
    }
}

async fn refresh_certificate(
    client: &Client,
    now: DateTime<FixedOffset>,
    cert: &mut Cert,
) -> Result<RefreshResult, Error> {
    // Check if this OCSP response is still valid
    if let Some(x) = &cert.ocsp_validity {
        if !x.past_half_validity(now) {
            return Ok(RefreshResult::StillValid);
        }
    }

    // Stapler makes sure that we have at least two certificates in the chain
    let end_entity = cert.ckey.cert[0].as_ref();
    let issuer = cert.ckey.cert[1].as_ref();

    // Query the OCSP responder
    let resp = client
        .query(end_entity, issuer)
        .await
        .context("unable to perform OCSP request")?;

    if !resp.ocsp_validity.valid(now) {
        return Err(anyhow!("the OCSP response is not valid at current time"));
    }

    // Update the OCSP response on the key
    let mut ckey = cert.ckey.as_ref().clone();
    ckey.ocsp = Some(resp.raw);

    // Update values
    cert.ckey = Arc::new(ckey);
    cert.status = resp.cert_status;
    cert.ocsp_validity = Some(resp.ocsp_validity);

    Ok(RefreshResult::Refreshed)
}

struct StaplerActor {
    client: Client,
    storage: Storage,
    rx: mpsc::Receiver<(Fingerprint, Arc<CertifiedKey>)>,
    published: Arc<ArcSwapOption<Storage>>,
    #[cfg(feature = "prometheus")]
    metrics: Option<Metrics>,
}

impl StaplerActor {
    async fn refresh(&mut self, now: DateTime<FixedOffset>) {
        if self.storage.is_empty() {
            return;
        }

        // Remove all expired certificates from the storage to free up resources
        self.storage.retain(|_, v| v.cert_validity.valid(now));

        for cert in self.storage.values_mut() {
            let start = Instant::now();
            let res = refresh_certificate(&self.client, now, cert).await;

            // Record metrics
            #[cfg(feature = "prometheus")]
            if let Some(v) = &self.metrics {
                let lbl = &[if res.is_err() { "error" } else { "ok" }];

                v.ocsp_requests_duration
                    .with_label_values(lbl)
                    .observe(start.elapsed().as_secs_f64());

                v.ocsp_requests.with_label_values(lbl).inc()
            };

            match res {
                Ok(v) => {
                    if v == RefreshResult::Refreshed {
                        info!(
                            "OCSP-Stapler: certificate [{cert}] was refreshed ({}) in {}ms",
                            cert.ocsp_validity.as_ref().unwrap(),
                            start.elapsed().as_millis()
                        );
                    }
                }
                Err(e) => warn!("OCSP-Stapler: unable to refresh certificate [{cert}]: {e:#}"),
            }

            // If the validity is about to expire for whatever reason - clear it.
            // This makes sure we don't serve expired OCSP responses in Stapler::resolve()
            if let Some(v) = &cert.ocsp_validity {
                if v.not_after - now < LEEWAY {
                    info!("OCSP-Stapler: certificate [{cert}] OCSP response has expired");
                    cert.ocsp_validity = None;
                }
            }
        }

        // Publish the updated storage version
        let new = Arc::new(self.storage.clone());
        self.published.store(Some(new));

        // Record some metrics
        #[cfg(feature = "prometheus")]
        if let Some(m) = &self.metrics {
            let status = self.storage.values().map(|x| x.status.clone()).counts();

            for (k, v) in status {
                m.certificate_count
                    .with_label_values(&[&format!("{k:?}")])
                    .set(v as i64);
            }
        }
    }

    fn add_certificate(
        &mut self,
        fp: Fingerprint,
        ckey: Arc<CertifiedKey>,
        now: DateTime<FixedOffset>,
    ) -> Result<bool, Error> {
        if self.storage.contains_key(&fp) {
            return Ok(false);
        }

        // Parse the DER-encoded certificate
        let cert = X509Certificate::from_der(ckey.end_entity_cert().unwrap())
            .context("unable to parse certificate as X.509")?
            .1;

        let cert_validity = Validity::try_from(&cert.validity).context(format!(
            "unable to parse certificate [{}] validity",
            cert.subject
        ))?;

        if !cert_validity.valid(now) {
            return Err(anyhow!(
                "the certificate [{}] is not valid at current time",
                cert.subject
            ));
        }

        let cert = Cert {
            ckey: ckey.clone(),
            subject: cert.subject.to_string(),
            status: CertStatus::Unknown(()),
            cert_validity,
            ocsp_validity: None,
        };

        self.storage.insert(fp, cert);
        Ok(true)
    }

    async fn run(&mut self, token: CancellationToken) {
        let mut interval = tokio::time::interval(Duration::from_secs(60));

        loop {
            tokio::select! {
                biased;

                () = token.cancelled() => {
                    warn!("OCSP-Stapler: exiting");
                    return;
                }

                _ = interval.tick() => {
                    self.refresh(Utc::now().into()).await;
                },

                msg = self.rx.recv() => {
                    if let Some((fp, ckey)) = msg {
                        let now = Utc::now().into();
                        if let Err(e) = self.add_certificate(fp, ckey, now) {
                            warn!("OCSP-Stapler: unable to process certificate: {e:#}");
                        } else {
                            self.refresh(now).await;
                        }
                    }
                }
            }
        }
    }
}

#[cfg(test)]
mod test {
    use super::*;
    use rustls::crypto::ring;

    #[tokio::test]
    async fn test_add_certificate() {
        // Install a cryptography provider, otherwise the OCSP stapler would panic
        ring::default_provider()
            .install_default()
            .unwrap_or_default();

        let ckey = crate::client::test::test_ckey();
        let storage = Arc::new(ArcSwapOption::empty());
        let (_, rx) = mpsc::channel(1024);

        let mut actor = StaplerActor {
            client: Client::new(),
            storage: BTreeMap::new(),
            rx,
            published: storage.clone(),
            metrics: None,
        };

        let fp = Fingerprint::from(&ckey);
        let ckey = Arc::new(ckey);

        // Check that invalid certificate date fails
        let now = DateTime::parse_from_rfc3339("2024-05-25T00:00:00-00:00").unwrap();
        assert!(actor
            .add_certificate(fp.clone(), ckey.clone(), now)
            .is_err());

        // Make sure that both additions succeed and second returns false
        let now = DateTime::parse_from_rfc3339("2024-05-28T00:00:00-00:00").unwrap();
        assert!(actor
            .add_certificate(fp.clone(), ckey.clone(), now)
            .unwrap());
        assert!(!actor
            .add_certificate(fp.clone(), ckey.clone(), now)
            .unwrap());
    }
}