ockam_api 0.93.0

Ockam's request-response API
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
use crate::control_api::http::{build_error_body, ControlApiHttpRequest, ControlApiHttpResponse};
use crate::nodes::NodeManager;
use crate::DefaultAddress;
use http_body_util::{BodyExt, Full};
use hyper::body::{Bytes, Incoming};
use hyper::server::conn::http1;
use hyper::service::service_fn;
use hyper::{body::Incoming as IncomingBody, Request, Response};
use hyper_util::rt::TokioIo;
use ockam_abac::{IncomingAbac, OutgoingAbac, PolicyExpression};
use ockam_core::errcode::{Kind, Origin};
use ockam_core::{
    async_trait, cbor_encode_preallocate, AllowAll, Error, IncomingAccessControl, NeutralMessage,
    OutgoingAccessControl, Processor, Routed, TryClone,
};
use ockam_multiaddr::MultiAddr;
use ockam_node::{Context, MessageSendReceiveOptions};
use ockam_transport_core::TransportError;
use std::net::SocketAddr;
use std::sync::Arc;
use std::time::Duration;
use subtle::ConstantTimeEq;
use tokio::net::TcpListener;

const MAX_REQUEST_SIZE: usize = 256 * 1024;
const TIMEOUT: Duration = Duration::from_secs(30);

pub struct HttpControlNodeApiFrontend {
    node_manager: Arc<NodeManager>,
    listener: TcpListener,
    authentication_token: String,
    context: Option<Arc<Context>>,
    incoming_access_control: Arc<dyn IncomingAccessControl>,
    outgoing_access_control: Arc<dyn OutgoingAccessControl>,
    pub node_resolution: NodeResolution,
}

#[async_trait]
impl Processor for HttpControlNodeApiFrontend {
    type Context = Context;

    async fn initialize(&mut self, context: &mut Self::Context) -> ockam_core::Result<()> {
        // We don't need to clone the whole context each time since send_and_receive already
        // creates dedicated addresses.
        self.context = Some(Arc::new(context.try_clone()?));
        Ok(())
    }

    async fn process(&mut self, _context: &mut Self::Context) -> ockam_core::Result<bool> {
        let context = match self.context.as_ref() {
            Some(context) => context.clone(),
            None => {
                error!("Context not initialized");
                return Ok(false);
            }
        };

        let (stream, _from) = match self.listener.accept().await {
            Ok(data) => data,
            Err(error) => {
                error!("Cannot accept incoming connection {:?}", error);
                return Ok(false);
            }
        };

        let service = {
            let node_manager = self.node_manager.clone();
            let node_resolution = self.node_resolution.clone();
            let authentication_token = self.authentication_token.clone();
            let incoming_access_control = self.incoming_access_control.clone();
            let outgoing_access_control = self.outgoing_access_control.clone();

            service_fn(move |request| {
                Self::route_request(
                    request,
                    context.clone(),
                    node_manager.clone(),
                    node_resolution.clone(),
                    authentication_token.clone(),
                    incoming_access_control.clone(),
                    outgoing_access_control.clone(),
                )
            })
        };

        tokio::spawn(async move {
            if let Err(err) = http1::Builder::new()
                .serve_connection(TokioIo::new(stream), service)
                .await
            {
                error!("HTTP server error: {:?}", err);
            }
        });

        Ok(true)
    }
}

impl HttpControlNodeApiFrontend {
    async fn new(
        node_manager: Arc<NodeManager>,
        bind_address: SocketAddr,
        authentication_token: String,
        node_resolution: NodeResolution,
        incoming_access_control: Arc<dyn IncomingAccessControl>,
        outgoing_access_control: Arc<dyn OutgoingAccessControl>,
    ) -> ockam_core::Result<Self> {
        let listener = TcpListener::bind(bind_address)
            .await
            .map_err(TransportError::from)?;

        Ok(Self {
            node_manager,
            listener,
            authentication_token,
            context: None,
            node_resolution,
            incoming_access_control,
            outgoing_access_control,
        })
    }

    fn bind_address(&self) -> ockam_core::Result<SocketAddr> {
        Ok(self.listener.local_addr().map_err(TransportError::from)?)
    }

    async fn route_request(
        request: Request<IncomingBody>,
        context: Arc<Context>,
        node_manager: Arc<NodeManager>,
        node_resolution: NodeResolution,
        authentication_token: String,
        incoming_access_control: Arc<dyn IncomingAccessControl>,
        outgoing_access_control: Arc<dyn OutgoingAccessControl>,
    ) -> http::Result<Response<Full<Bytes>>> {
        match Self::route_request_impl(
            request,
            context,
            node_manager,
            node_resolution,
            authentication_token,
            incoming_access_control,
            outgoing_access_control,
        )
        .await
        {
            Ok(response) => Ok(response),
            Err(error) => {
                error!("Error processing request: {:?}", error);
                let result = match error.code().kind {
                    Kind::Timeout => Response::builder()
                        .status(504)
                        .header("Content-Type", "application/json")
                        .body(build_error_body("Request timed out")),
                    _ => Response::builder()
                        .status(500)
                        .header("Content-Type", "application/json")
                        .body(build_error_body(&error.to_string())),
                };

                match result {
                    Ok(response) => Ok(response),
                    Err(encoding_error) => {
                        error!("Error encoding error response: {:?}", encoding_error);
                        Response::builder().status(500).body(Full::default())
                    }
                }
            }
        }
    }

    async fn route_request_impl(
        request: Request<IncomingBody>,
        context: Arc<Context>,
        node_manager: Arc<NodeManager>,
        node_resolution: NodeResolution,
        authentication_token: String,
        incoming_access_control: Arc<dyn IncomingAccessControl>,
        outgoing_access_control: Arc<dyn OutgoingAccessControl>,
    ) -> Result<Response<Full<Bytes>>, Error> {
        if let Some(response) = Self::authenticate_request(&request, authentication_token)? {
            return Ok(response);
        }
        info!("Received request for path {}", request.uri().path());

        let uri = request.uri().clone();

        let path = uri.path();
        let first_slash = match path[1..].find('/') {
            Some(index) => index,
            None => {
                error!("Received request with invalid path: {}", path);
                return Err(Error::new(
                    Origin::Api,
                    Kind::Invalid,
                    "Missing node name in request path",
                ));
            }
        };

        let method = request.method().to_string();
        let node_name = &path[1..first_slash + 1];

        let body = http_body_util::Limited::new(request.into_body(), MAX_REQUEST_SIZE);
        let serialized_body = body
            .collect()
            .await
            .map_err(|_| Error::new(Origin::Api, Kind::Io, "Failed to read request body"))?;

        let body = serialized_body.to_bytes();
        let body = if body.is_empty() {
            None
        } else {
            Some(body.to_vec())
        };

        let control_api_request = ControlApiHttpRequest {
            method,
            uri: uri.to_string(),
            body,
        };

        let message = cbor_encode_preallocate(&control_api_request)
            .map_err(|_| Error::new(Origin::Api, Kind::Internal, "Failed to encode request"))?;

        // "self" is shorthand for the current node
        let destination = if node_name == "self" {
            format!("/secure/api/service/{}", DefaultAddress::CONTROL_API)
        } else {
            match &node_resolution {
                NodeResolution::Relay { relay_node } => {
                    format!(
                        "{relay_node}/service/forward_to_{node_name}/secure/api/service/{}",
                        DefaultAddress::CONTROL_API
                    )
                }
                NodeResolution::DirectConnection { pattern, port } => {
                    let node_address = pattern.replace("{name}", node_name);
                    format!(
                        "/dnsaddr/{node_address}/tcp/{port}/secure/api/service/{}",
                        DefaultAddress::CONTROL_API
                    )
                }
            }
        };

        let result = node_manager
            .make_connection(
                &context,
                &destination.parse()?,
                node_manager.identifier(),
                None,
                None,
            )
            .await;
        let node_connection = match result {
            Ok(connection) => connection,
            Err(error) => {
                error!("Failed to create connection to node: {:?}", error);
                return Response::builder()
                    .status(502)
                    .header("Content-Type", "application/json")
                    .body(build_error_body("Node not reachable"))
                    .map_err(Self::map_http_err);
            }
        };

        let result: ockam_core::Result<Routed<NeutralMessage>> = context
            .send_and_receive_extended(
                node_connection.route()?,
                NeutralMessage::from(message),
                MessageSendReceiveOptions::new()
                    .with_timeout(TIMEOUT)
                    .with_incoming_access_control(incoming_access_control)
                    .with_outgoing_access_control(outgoing_access_control),
            )
            .await;

        // close the connection regardless of the result
        node_connection.close(&context, &node_manager)?;

        let response = match result {
            Ok(response) => response,
            Err(error) => {
                return match error.code().kind {
                    Kind::NotFound => {
                        warn!("Node not found: {:?}", error);
                        Response::builder()
                            .status(502)
                            .header("Content-Type", "application/json")
                            .body(build_error_body("Node not reachable"))
                            .map_err(Self::map_http_err)
                    }
                    _ => {
                        warn!("Error processing request: {error:?}");
                        Response::builder()
                            .status(500)
                            .header("Content-Type", "application/json")
                            .body(build_error_body(
                                "Could not communicate with the target node",
                            ))
                            .map_err(Self::map_http_err)
                    }
                }
            }
        };

        let response: ControlApiHttpResponse = minicbor::decode(response.payload())
            .map_err(|_| Error::new(Origin::Api, Kind::Protocol, "Failed to decode response"))?;

        let body = Full::from(Bytes::from(response.body));

        Response::builder()
            .status(response.status)
            .header("Content-Type", "application/json")
            .body(body)
            .map_err(Self::map_http_err)
    }

    fn map_http_err(_error: http::Error) -> ockam_core::Error {
        Error::new(Origin::Api, Kind::Internal, "Failed to build response")
    }

    fn authenticate_request(
        request: &Request<Incoming>,
        authentication_token: String,
    ) -> ockam_core::Result<Option<Response<Full<Bytes>>>> {
        let headers = request.headers();
        let auth_header = match headers.get("Authorization") {
            Some(header) => header,
            None => {
                warn!("Missing authentication token");
                return Ok(Some(
                    Response::builder()
                        .status(401)
                        .header("Content-Type", "application/json")
                        .body(build_error_body("Missing authentication token"))
                        .map_err(Self::map_http_err)?,
                ));
            }
        };

        let authentication_header = match auth_header.to_str() {
            Ok(header) => header,
            Err(_) => {
                warn!("Invalid authentication token header");
                return Ok(Some(
                    Response::builder()
                        .status(401)
                        .header("Content-Type", "application/json")
                        .body(build_error_body("Invalid authentication token header"))
                        .map_err(Self::map_http_err)?,
                ));
            }
        };

        // extract authentication token from header
        let auth_header = authentication_header
            .split_whitespace()
            .last()
            .unwrap_or_default();

        // constant time comparison, to prevent timing attacks
        let authenticated: bool = authentication_token
            .as_bytes()
            .ct_eq(auth_header.as_bytes())
            .into();

        if authenticated {
            Ok(None)
        } else {
            warn!("Invalid authentication token");
            Ok(Some(
                Response::builder()
                    .status(401)
                    .header("Content-Type", "application/json")
                    .body(build_error_body("Invalid authentication token"))
                    .map_err(Self::map_http_err)?,
            ))
        }
    }
}

#[derive(Clone)]
pub enum NodeResolution {
    Relay { relay_node: MultiAddr },
    DirectConnection { pattern: String, port: u16 },
}

impl NodeManager {
    pub async fn create_control_api_frontend(
        self: &Arc<NodeManager>,
        context: &Context,
        bind_address: SocketAddr,
        node_resolution: NodeResolution,
        authentication_token: String,
        policy_expression: Option<PolicyExpression>,
    ) -> ockam_core::Result<SocketAddr> {
        let incoming_access_control: Arc<dyn IncomingAccessControl>;
        let outgoing_access_control: Arc<dyn OutgoingAccessControl>;

        match policy_expression {
            Some(policy_expression) => {
                incoming_access_control = Arc::new(IncomingAbac::create(
                    self.secure_channels.identities().identities_attributes(),
                    self.project_authority(),
                    policy_expression.to_expression(),
                ));
                outgoing_access_control = Arc::new(OutgoingAbac::create(
                    context,
                    self.secure_channels.identities().identities_attributes(),
                    self.project_authority(),
                    policy_expression.to_expression(),
                )?);
            }
            None => {
                incoming_access_control = Arc::new(AllowAll);
                outgoing_access_control = Arc::new(AllowAll);
            }
        }

        let frontend = HttpControlNodeApiFrontend::new(
            self.clone(),
            bind_address,
            authentication_token,
            node_resolution,
            incoming_access_control,
            outgoing_access_control,
        )
        .await?;
        let bind_address = frontend.bind_address()?;
        context.start_processor("http_control_node_api_frontend", frontend)?;
        Ok(bind_address)
    }
}

#[cfg(test)]
mod test {
    use crate::control_api::frontend::NodeResolution;
    use crate::control_api::protocol::common::ErrorResponse;
    use crate::control_api::protocol::inlet::InletStatus;
    use crate::hop::Hop;
    use crate::test_utils::start_manager_for_tests;
    use bytes::Bytes;
    use colorful::core::StrMarker;
    use http::{Request, Response};
    use http_body_util::{BodyExt, Full};
    use hyper_util::rt::TokioIo;
    use ockam_multiaddr::MultiAddr;
    use ockam_node::Context;
    use serde::de::DeserializeOwned;
    use serde::Serialize;
    use std::net::SocketAddr;
    use tokio::net::TcpStream;

    async fn send_http_request<S: Serialize + Send, D: DeserializeOwned + Send>(
        request: Request<S>,
    ) -> Response<D> {
        let host = request.uri().host().expect("uri has no host");
        let port = request.uri().port().expect("uri has no port");

        let addr = format!("{}:{}", host, port);
        let stream = TcpStream::connect(addr).await.unwrap();
        let io = TokioIo::new(stream);

        let (mut sender, conn) = hyper::client::conn::http1::handshake(io).await.unwrap();
        tokio::task::spawn(async move {
            let _ = conn.await;
        });

        // Serialize the body and recreate the request
        let (parts, body) = request.into_parts();
        let body: Full<Bytes> = Full::from(Bytes::from(serde_json::to_vec(&body).unwrap()));
        let request = Request::from_parts(parts, body);

        let response = sender.send_request(request).await.unwrap();

        // Deserialize the body and recreate the response
        let (parts, body) = response.into_parts();
        let serialized_body = body.collect().await.unwrap();
        let bytes = serialized_body.to_bytes();
        let body = serde_json::from_slice(bytes.as_ref()).unwrap();

        Response::from_parts(parts, body)
    }

    #[ockam::test]
    pub async fn authentication_token_validation(context: &mut Context) -> ockam_core::Result<()> {
        let handle = start_manager_for_tests(context, None, None).await?;

        let bind_address = handle
            .node_manager
            .create_control_api_frontend(
                context,
                SocketAddr::from(([127, 0, 0, 1], 0)),
                NodeResolution::Relay {
                    relay_node: MultiAddr::default(),
                },
                "token".to_str(),
                None,
            )
            .await?;

        let response: Response<ErrorResponse> = send_http_request(
            Request::get(format!("http://{bind_address}/node1/tcp-inlets"))
                .body(())
                .unwrap(),
        )
        .await;

        assert_eq!(response.status().as_u16(), 401, "Unauthorized");
        assert_eq!(response.body().message, "Missing authentication token");

        let response: Response<ErrorResponse> = send_http_request(
            Request::get(format!("http://{bind_address}/node1/tcp-inlets"))
                .header("Authorization", "invalid_token")
                .body(())
                .unwrap(),
        )
        .await;

        assert_eq!(response.status().as_u16(), 401, "Unauthorized");
        assert_eq!(response.body().message, "Invalid authentication token");

        let response: Response<ErrorResponse> = send_http_request(
            Request::get(format!("http://{bind_address}/node1/tcp-inlets"))
                .header("Authorization", "Bearer invalid_token")
                .body(())
                .unwrap(),
        )
        .await;

        assert_eq!(response.status().as_u16(), 401, "Unauthorized");
        assert_eq!(response.body().message, "Invalid authentication token");

        let response: Response<ErrorResponse> = send_http_request(
            Request::get(format!("http://{bind_address}/node1/tcp-inlets"))
                .header("Authorization", "Bearer token")
                .body(())
                .unwrap(),
        )
        .await;

        assert_eq!(response.status().as_u16(), 502);

        let response: Response<ErrorResponse> = send_http_request(
            Request::get(format!("http://{bind_address}/node1/tcp-inlets"))
                .header("Authorization", "token")
                .body(())
                .unwrap(),
        )
        .await;

        assert_eq!(response.status().as_u16(), 502);

        Ok(())
    }

    #[ockam::test]
    pub async fn reverse_proxy_using_relay(context: &mut Context) -> ockam_core::Result<()> {
        let handle = start_manager_for_tests(context, None, None).await?;

        let bind_address = handle
            .node_manager
            .create_control_api_frontend(
                context,
                SocketAddr::from(([127, 0, 0, 1], 0)),
                NodeResolution::Relay {
                    relay_node: MultiAddr::default(),
                },
                "token".to_str(),
                None,
            )
            .await?;

        handle
            .node_manager
            .create_control_api_backend(context, None)?;

        context.start_worker("forward_to_node1", Hop)?;

        let response: Response<Vec<InletStatus>> = send_http_request(
            Request::get(format!("http://{bind_address}/node1/tcp-inlets"))
                .header("Authorization", "Bearer token")
                .body(())
                .unwrap(),
        )
        .await;

        assert_eq!(response.status().as_u16(), 200);

        Ok(())
    }

    #[ockam::test]
    pub async fn reverse_proxy_using_relay_non_existing_node(
        context: &mut Context,
    ) -> ockam_core::Result<()> {
        let handle = start_manager_for_tests(context, None, None).await?;

        let bind_address = handle
            .node_manager
            .create_control_api_frontend(
                context,
                SocketAddr::from(([127, 0, 0, 1], 0)),
                NodeResolution::Relay {
                    relay_node: MultiAddr::default(),
                },
                "token".to_str(),
                None,
            )
            .await?;

        handle
            .node_manager
            .create_control_api_backend(context, None)?;

        let response: Response<ErrorResponse> = send_http_request(
            Request::get(format!(
                "http://{bind_address}/non-existing-node/tcp-inlets/"
            ))
            .header("Authorization", "Bearer token")
            .body(())
            .unwrap(),
        )
        .await;

        assert_eq!(response.status().as_u16(), 502, "the node is not reachable");
        assert_eq!(response.body().message, "Node not reachable");

        Ok(())
    }

    #[ockam::test]
    pub async fn reverse_proxy_using_direct_connection(
        context: &mut Context,
    ) -> ockam_core::Result<()> {
        let handle = start_manager_for_tests(context, None, None).await?;

        let bind_address = handle
            .node_manager
            .create_control_api_frontend(
                context,
                SocketAddr::from(([127, 0, 0, 1], 0)),
                NodeResolution::DirectConnection {
                    pattern: "{name}.localhost".to_string(),
                    port: handle.bind_address.port(),
                },
                "token".to_str(),
                None,
            )
            .await?;

        handle
            .node_manager
            .create_control_api_backend(context, None)?;

        let response: Response<Vec<InletStatus>> = send_http_request(
            Request::get(format!("http://{bind_address}/node1/tcp-inlets"))
                .header("Authorization", "Bearer token")
                .body(())
                .unwrap(),
        )
        .await;

        assert_eq!(response.status().as_u16(), 200);

        Ok(())
    }

    #[ockam::test]
    pub async fn reverse_proxy_using_direct_connection_non_existing_node(
        context: &mut Context,
    ) -> ockam_core::Result<()> {
        let handle = start_manager_for_tests(context, None, None).await?;

        let bind_address = handle
            .node_manager
            .create_control_api_frontend(
                context,
                SocketAddr::from(([127, 0, 0, 1], 0)),
                NodeResolution::DirectConnection {
                    pattern: "{name}.localhost".to_string(),
                    port: 0,
                },
                "token".to_str(),
                None,
            )
            .await?;

        handle
            .node_manager
            .create_control_api_backend(context, None)?;

        let response: Response<ErrorResponse> = send_http_request(
            Request::get(format!(
                "http://{bind_address}/non-existing-node/tcp-inlets"
            ))
            .header("Authorization", "Bearer token")
            .body(())
            .unwrap(),
        )
        .await;

        assert_eq!(response.status().as_u16(), 502, "the node is not reachable");
        assert_eq!(response.body().message, "Node not reachable");

        Ok(())
    }
}