oag-core 0.20.5

use std::fmt;
use std::fs;
use std::path::{Path, PathBuf};

use indexmap::IndexMap;
use serde::de;
use serde::{Deserialize, Deserializer};

/// A tool setting that can be a named tool or explicitly disabled.
///
/// In YAML: `"biome"` → `Named("biome")`, `false` → `Disabled`.
/// `true` or absent → treated as "use default" (represented as `None` at the Option level).
#[derive(Debug, Clone, PartialEq, Eq)]
pub enum ToolSetting {
    Named(String),
    Disabled,
}

impl ToolSetting {
    /// Resolve with a default: `None` → `Some(default)`, `Named(s)` → `Some(s)`, `Disabled` → `None`.
    pub fn resolve<'a>(setting: Option<&'a Self>, default: &'a str) -> Option<&'a str> {
        match setting {
            None => Some(default),
            Some(ToolSetting::Named(s)) => Some(s.as_str()),
            Some(ToolSetting::Disabled) => None,
        }
    }
}

impl<'de> Deserialize<'de> for ToolSetting {
    fn deserialize<D>(deserializer: D) -> Result<Self, D::Error>
    where
        D: Deserializer<'de>,
    {
        let value = serde_json::Value::deserialize(deserializer).map_err(de::Error::custom)?;
        match value {
            serde_json::Value::String(s) => Ok(ToolSetting::Named(s)),
            serde_json::Value::Bool(false) => Ok(ToolSetting::Disabled),
            serde_json::Value::Bool(true) => {
                // true means "use default" — caller should treat as absent
                Err(de::Error::custom(
                    "use `false` to disable or a string to name the tool; `true` is treated as default (omit the field)",
                ))
            }
            _ => Err(de::Error::custom(
                "expected a tool name string or `false` to disable",
            )),
        }
    }
}

/// Deserialize the `scaffold` field: `false` → `None`, object → `Some(object)`, absent → `None`.
fn deserialize_scaffold<'de, D>(deserializer: D) -> Result<Option<serde_json::Value>, D::Error>
where
    D: Deserializer<'de>,
{
    let value = Option::<serde_json::Value>::deserialize(deserializer)?;
    match value {
        Some(serde_json::Value::Bool(false)) => Ok(None),
        other => Ok(other),
    }
}

/// Top-level project configuration loaded from `oag.yaml`.
///
/// This is the entry point for all `oag` settings. The config file controls which
/// OpenAPI spec to parse, how operation names are derived, and which code generators
/// to run (each with its own output directory and options).
///
/// # Format detection
///
/// The deserializer auto-detects the config format:
/// - **New format** (recommended): has a `generators` map keyed by generator ID.
/// - **Legacy format**: uses `target`, `output`, `output_options`, and `client` fields.
///   Automatically converted to the new format at load time.
#[derive(Debug, Clone)]
pub struct OagConfig {
    /// Path to the OpenAPI spec file (YAML or JSON). Resolved relative to the
    /// config file's directory. Can be overridden via `oag generate -i <path>`.
    pub input: String,
    /// Controls how operation names are derived from the spec.
    pub naming: NamingConfig,
    /// Map of generator ID → per-generator configuration. Only generators listed
    /// here will run during `oag generate`. Order is preserved (insertion order).
    pub generators: IndexMap<GeneratorId, GeneratorConfig>,
}

impl Default for OagConfig {
    fn default() -> Self {
        Self {
            input: "openapi.yaml".to_string(),
            naming: NamingConfig::default(),
            generators: IndexMap::new(),
        }
    }
}

/// A generator identifier — any string that resolves to a template pack.
///
/// Built-in IDs:
/// - `node-client` — TypeScript/Node API client
/// - `react-swr-client` — React/SWR hooks
/// - `fastapi-server` — Python FastAPI server stubs
///
/// Custom IDs resolve to template packs installed in the data directory
/// or specified via an explicit path.
#[derive(Debug, Clone, PartialEq, Eq, Hash, Deserialize)]
#[serde(transparent)]
pub struct GeneratorId(pub String);

impl GeneratorId {
    pub fn as_str(&self) -> &str {
        &self.0
    }
}

impl fmt::Display for GeneratorId {
    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
        write!(f, "{}", self.0)
    }
}

/// Configuration for a single generator.
///
/// Each entry in the `generators` map deserializes into this struct. All fields
/// except `output` have sensible defaults so a minimal config only needs the
/// output directory.
///
/// # TypeScript-only fields
///
/// `base_url`, `no_jsdoc`, and `source_dir` only affect the TypeScript generators
/// (`node-client` and `react-swr-client`). They are silently ignored by `fastapi-server`.
///
/// # Scaffold
///
/// The `scaffold` field is an opaque JSON object forwarded to the generator.
/// Each generator defines its own scaffold struct (e.g., package name, formatter,
/// test runner, bundler). See the default config for available scaffold options.
#[derive(Debug, Clone, Deserialize)]
#[serde(default)]
pub struct GeneratorConfig {
    /// Output directory for generated files. Required — the generator writes all
    /// files relative to this path. Created automatically if it doesn't exist.
    pub output: String,
    /// How files are organized on disk. Default: `modular`.
    /// - `bundled` — single file containing all types, client, and SSE utilities
    /// - `modular` — separate files per concern (types, client, sse, index)
    /// - `split` — separate files per operation group (see `split_by`)
    pub layout: OutputLayout,
    /// Only used when `layout: split`. Controls how operations are grouped into files.
    /// - `tag` (default) — one file per OpenAPI tag
    /// - `operation` — one file per operation
    /// - `route` — one file per route prefix
    pub split_by: Option<SplitBy>,
    /// Override the API base URL instead of reading it from the spec's `servers` array.
    /// Only affects TypeScript generators. Useful when the spec doesn't include a server
    /// or you need a different URL for development.
    pub base_url: Option<String>,
    /// Disable JSDoc comments on generated types and methods. Default: `false`.
    /// Only affects TypeScript generators.
    pub no_jsdoc: Option<bool>,
    /// Subdirectory within `output` for generated source files. Default: `"src"`.
    /// The scaffold's `tsconfig.json` and `tsdown.config.ts` adapt automatically.
    /// Set to `""` to place source files directly at the output root.
    /// Only affects TypeScript generators.
    pub source_dir: String,
    /// Opaque scaffold configuration forwarded to the generator. Each generator
    /// defines its own scaffold options:
    ///
    /// **TypeScript generators** (`node-client`, `react-swr-client`):
    /// - `package_name` — npm package name (default: derived from spec title)
    /// - `repository` — repository URL for `package.json`
    /// - `existing_repo` — skip all scaffold files, only emit source + root index
    /// - `formatter` — `"biome"` or `false` to disable (default: `"biome"`)
    /// - `test_runner` — `"vitest"` or `false` to disable (default: `"vitest"`)
    /// - `bundler` — `"tsdown"` or `false` to disable (default: `"tsdown"`)
    ///
    /// **Python generator** (`fastapi-server`):
    /// - `package_name` — Python package name for `pyproject.toml`
    /// - `formatter` — `"ruff"` or `false` to disable (default: `"ruff"`)
    /// - `test_runner` — `"pytest"` or `false` to disable (default: `"pytest"`)
    ///
    /// **All generators**:
    /// - `extra_dev_dependencies` — map of additional dev dependency names to version
    ///   specs, merged into the generated `devDependencies` (npm) or `[dependency-groups] dev`
    ///   (Python). Example: `{ "@testing-library/react": "^16.0" }` for npm,
    ///   `{ "factory-boy": ">=3.3" }` for Python.
    ///
    /// Set to `false` to explicitly disable all scaffolding. Omitting the field
    /// entirely also disables scaffolding.
    #[serde(default, deserialize_with = "deserialize_scaffold")]
    pub scaffold: Option<serde_json::Value>,
}

impl Default for GeneratorConfig {
    fn default() -> Self {
        Self {
            output: "src/generated".to_string(),
            layout: OutputLayout::Modular,
            split_by: None,
            base_url: None,
            no_jsdoc: None,
            source_dir: "".to_string(),
            scaffold: None,
        }
    }
}

/// How generated files are laid out on disk.
///
/// # YAML values
///
/// - `bundled` — everything in a single file (e.g., `src/index.ts`)
/// - `modular` — separate files per concern (default, recommended)
/// - `split` — separate files per operation group (requires `split_by`)
#[derive(Debug, Clone, Copy, PartialEq, Eq, Deserialize)]
#[serde(rename_all = "snake_case")]
pub enum OutputLayout {
    /// All types, client, and utilities concatenated into one output file.
    /// Produces `src/index.ts` (TS) or a single combined Python module.
    /// Scaffold files (package.json, tsconfig, etc.) are still separate.
    Bundled,
    /// Separate files per concern. This is the default and recommended layout.
    /// TypeScript: `types.ts`, `client.ts`, `sse.ts`, `guards.ts`, `index.ts`.
    /// Python: `models.py`, `routes.py`, `sse.py`, `app.py`.
    Modular,
    /// Separate files per operation group, determined by `split_by`.
    /// For example, with `split_by: tag`: `src/pets.ts`, `src/users.ts`, etc.
    /// Each file contains the types, client methods, and utilities for that group.
    Split,
}

/// How to split operations into groups when using `OutputLayout::Split`.
///
/// # YAML values
///
/// - `operation` — one file per operation (finest granularity)
/// - `tag` — one file per OpenAPI tag (default, recommended)
/// - `route` — one file per route prefix (e.g., `/pets`, `/users`)
#[derive(Debug, Clone, Copy, PartialEq, Eq, Deserialize)]
#[serde(rename_all = "snake_case")]
pub enum SplitBy {
    /// One file per operation — finest granularity. Each operation gets its own
    /// file with its types, client method, and utilities.
    Operation,
    /// One file per OpenAPI tag — groups related operations together.
    /// Maps directly to `IrModule` groupings from the transform pipeline.
    Tag,
    /// One file per route prefix — groups operations sharing the same path root.
    /// For example, `/pets` and `/pets/{petId}` would share a file.
    Route,
}

/// Naming strategy and operation aliases.
///
/// Controls how operation names (used as function/method names in generated code)
/// are derived from the OpenAPI spec.
#[derive(Debug, Clone, Deserialize)]
#[serde(default)]
pub struct NamingConfig {
    /// How to derive operation names. See [`NamingStrategy`] for options.
    pub strategy: NamingStrategy,
    /// Map from resolved operation name to a custom alias. Applied after the
    /// naming strategy resolves the base name. Useful for shortening verbose
    /// operationIds (e.g., `createChatCompletion` → `chat`).
    #[serde(default)]
    pub aliases: IndexMap<String, String>,
}

impl Default for NamingConfig {
    fn default() -> Self {
        Self {
            strategy: NamingStrategy::UseOperationId,
            aliases: IndexMap::new(),
        }
    }
}

/// How operation names are derived from the OpenAPI spec.
///
/// # YAML values
///
/// - `use_operation_id` — use the `operationId` field directly (default)
/// - `use_route_based` — derive from HTTP method + path (e.g., `GET /pets` → `getPets`)
#[derive(Debug, Clone, Copy, Default, PartialEq, Eq, Deserialize)]
#[serde(rename_all = "snake_case")]
pub enum NamingStrategy {
    /// Use the `operationId` field from the OpenAPI spec as-is.
    /// This is the default and works well when the spec has meaningful operation IDs.
    /// Falls back to route-based naming if `operationId` is missing.
    #[default]
    UseOperationId,
    /// Derive the name from the HTTP method and path.
    /// For example: `GET /pets` → `getPets`, `POST /pets/{petId}` → `createPetsPetId`.
    /// Useful when the spec lacks `operationId` fields or has inconsistent IDs.
    UseRouteBased,
}

// --- Backward-compatible deserialization ---
// Old format had: input, output, target, naming, output_options, client
// New format has: input, naming, generators (map of GeneratorId -> GeneratorConfig)
// We support both.

/// Internal legacy config format for backward compat parsing.
#[derive(Deserialize)]
struct LegacyConfig {
    #[serde(default = "default_input")]
    input: String,
    #[serde(default = "default_output")]
    output: String,
    #[serde(default)]
    target: LegacyTargetKind,
    #[serde(default)]
    naming: NamingConfig,
    #[serde(default)]
    output_options: LegacyOutputOptions,
    #[serde(default)]
    client: LegacyClientConfig,
}

fn default_input() -> String {
    "openapi.yaml".to_string()
}
fn default_output() -> String {
    "src/generated".to_string()
}

#[derive(Debug, Clone, Copy, Default, Deserialize, PartialEq, Eq)]
#[serde(rename_all = "snake_case")]
enum LegacyTargetKind {
    Typescript,
    React,
    #[default]
    All,
}

#[derive(Debug, Clone, Deserialize)]
#[serde(default)]
struct LegacyOutputOptions {
    layout: LegacyOutputLayout,
    index: bool,
    biome: bool,
    tsdown: bool,
    package_name: Option<String>,
    repository: Option<String>,
}

impl Default for LegacyOutputOptions {
    fn default() -> Self {
        Self {
            layout: LegacyOutputLayout::Single,
            index: true,
            biome: true,
            tsdown: true,
            package_name: None,
            repository: None,
        }
    }
}

#[derive(Debug, Clone, Copy, Default, PartialEq, Eq, Deserialize)]
#[serde(rename_all = "snake_case")]
enum LegacyOutputLayout {
    #[default]
    Single,
    Split,
}

#[derive(Debug, Clone, Default, Deserialize)]
#[serde(default)]
struct LegacyClientConfig {
    base_url: Option<String>,
    no_jsdoc: bool,
}

/// Internal new-format config for forward parsing.
#[derive(Deserialize)]
struct NewConfig {
    #[serde(default = "default_input")]
    input: String,
    #[serde(default)]
    naming: NamingConfig,
    generators: IndexMap<GeneratorId, GeneratorConfig>,
}

impl<'de> Deserialize<'de> for OagConfig {
    fn deserialize<D>(deserializer: D) -> Result<Self, D::Error>
    where
        D: Deserializer<'de>,
    {
        // We deserialize into a generic map first to detect the format.
        let value = serde_json::Value::deserialize(deserializer).map_err(de::Error::custom)?;

        // Check if the config has a "generators" key — that's the new format.
        if value.get("generators").is_some() {
            let new_cfg: NewConfig = serde_json::from_value(value).map_err(de::Error::custom)?;
            Ok(OagConfig {
                input: new_cfg.input,
                naming: new_cfg.naming,
                generators: new_cfg.generators,
            })
        } else {
            // Legacy format
            let legacy: LegacyConfig = serde_json::from_value(value).map_err(de::Error::custom)?;
            Ok(convert_legacy(legacy))
        }
    }
}

fn convert_legacy(legacy: LegacyConfig) -> OagConfig {
    let scaffold = Some(serde_json::json!({
        "package_name": legacy.output_options.package_name,
        "repository": legacy.output_options.repository,
        "index": legacy.output_options.index,
        "formatter": if legacy.output_options.biome { serde_json::Value::String("biome".into()) } else { serde_json::Value::Bool(false) },
        "bundler": if legacy.output_options.tsdown { serde_json::Value::String("tsdown".into()) } else { serde_json::Value::Bool(false) },
        "test_runner": serde_json::Value::String("vitest".into()),
    }));

    let base_gen_config = |output: String| GeneratorConfig {
        output,
        layout: OutputLayout::Modular,
        split_by: None,
        base_url: legacy.client.base_url.clone(),
        no_jsdoc: Some(legacy.client.no_jsdoc),
        source_dir: "src".to_string(),
        scaffold: scaffold.clone(),
    };

    let mut generators = IndexMap::new();

    match (&legacy.target, &legacy.output_options.layout) {
        (LegacyTargetKind::Typescript, _) => {
            generators.insert(
                GeneratorId("node-client".into()),
                base_gen_config(legacy.output.clone()),
            );
        }
        (LegacyTargetKind::React, _) => {
            generators.insert(
                GeneratorId("react-swr-client".into()),
                base_gen_config(legacy.output.clone()),
            );
        }
        (LegacyTargetKind::All, LegacyOutputLayout::Single) => {
            // In single layout with target=all, the old behavior was to put
            // everything together using the React generator (which includes TS files).
            // Map this to a single react-swr-client generator.
            generators.insert(
                GeneratorId("react-swr-client".into()),
                base_gen_config(legacy.output.clone()),
            );
        }
        (LegacyTargetKind::All, LegacyOutputLayout::Split) => {
            let ts_output = format!("{}/typescript", legacy.output);
            let react_output = format!("{}/react", legacy.output);
            generators.insert(
                GeneratorId("node-client".into()),
                base_gen_config(ts_output),
            );
            generators.insert(
                GeneratorId("react-swr-client".into()),
                base_gen_config(react_output),
            );
        }
    }

    OagConfig {
        input: legacy.input,
        naming: legacy.naming,
        generators,
    }
}

/// Preferred config file name for new projects.
pub const CONFIG_FILE_NAME: &str = "oag.yaml";

/// Legacy config file name (deprecated, will be removed in a future release).
pub const LEGACY_CONFIG_FILE: &str = ".urmzd.oag.yaml";

/// Config file candidates, checked in priority order.
pub const CONFIG_CANDIDATES: &[&str] = &["oag.yaml", "oag.yml", LEGACY_CONFIG_FILE];

/// Find the first config file that exists in the given directory.
/// Returns `(path, is_legacy)`.
pub fn find_config(dir: &Path) -> Option<(PathBuf, bool)> {
    for &candidate in CONFIG_CANDIDATES {
        let path = dir.join(candidate);
        if path.exists() {
            let is_legacy = candidate == LEGACY_CONFIG_FILE;
            return Some((path, is_legacy));
        }
    }
    None
}

/// Load config from a YAML file. Returns `None` if the file doesn't exist.
pub fn load_config(path: &Path) -> Result<Option<OagConfig>, String> {
    if !path.exists() {
        return Ok(None);
    }
    let content = fs::read_to_string(path)
        .map_err(|e| format!("failed to read config {}: {}", path.display(), e))?;

    let yaml_value: serde_json::Value = serde_yaml_ng::from_str(&content)
        .map_err(|e| format!("failed to parse config {}: {}", path.display(), e))?;

    let config: OagConfig = serde_json::from_value(yaml_value)
        .map_err(|e| format!("failed to parse config {}: {}", path.display(), e))?;
    Ok(Some(config))
}

/// Generate the default config file content (new format).
pub fn default_config_content() -> &'static str {
    include_str!("../default-config.yaml")
}

#[cfg(test)]
mod tests {
    use super::*;

    #[test]
    fn test_default_config() {
        let config = OagConfig::default();
        assert_eq!(config.input, "openapi.yaml");
        assert_eq!(config.naming.strategy, NamingStrategy::UseOperationId);
        assert!(config.naming.aliases.is_empty());
        assert!(config.generators.is_empty());
    }

    #[test]
    fn test_parse_new_format() {
        let yaml = r#"
input: spec.yaml

naming:
  strategy: use_route_based
  aliases:
    createChatCompletion: chat

generators:
  node-client:
    output: out/node
    layout: modular
    base_url: https://api.example.com
    scaffold:
      package_name: "@myorg/client"
      formatter: biome
      bundler: tsdown
  react-swr-client:
    output: out/react
    layout: split
    split_by: tag
"#;
        let value: serde_json::Value = serde_yaml_ng::from_str(yaml).unwrap();
        let config: OagConfig = serde_json::from_value(value).unwrap();
        assert_eq!(config.input, "spec.yaml");
        assert_eq!(config.naming.strategy, NamingStrategy::UseRouteBased);
        assert_eq!(config.generators.len(), 2);

        let node = &config.generators[&GeneratorId("node-client".into())];
        assert_eq!(node.output, "out/node");
        assert_eq!(node.layout, OutputLayout::Modular);
        assert_eq!(node.base_url, Some("https://api.example.com".to_string()));
        assert!(node.scaffold.is_some());
        let scaffold = node.scaffold.as_ref().unwrap();
        assert_eq!(scaffold["package_name"], "@myorg/client");
        assert_eq!(scaffold["formatter"], "biome");
        assert_eq!(scaffold["bundler"], "tsdown");

        let react = &config.generators[&GeneratorId("react-swr-client".into())];
        assert_eq!(react.output, "out/react");
        assert_eq!(react.layout, OutputLayout::Split);
        assert_eq!(react.split_by, Some(SplitBy::Tag));
    }

    #[test]
    fn test_parse_legacy_typescript() {
        let yaml = r#"
input: spec.yaml
output: out
target: typescript
naming:
  strategy: use_operation_id
  aliases: {}
output_options:
  layout: single
  biome: true
  tsdown: true
client:
  base_url: https://api.example.com
  no_jsdoc: true
"#;
        let value: serde_json::Value = serde_yaml_ng::from_str(yaml).unwrap();
        let config: OagConfig = serde_json::from_value(value).unwrap();
        assert_eq!(config.input, "spec.yaml");
        assert_eq!(config.generators.len(), 1);
        assert!(
            config
                .generators
                .contains_key(&GeneratorId("node-client".into()))
        );

        let node_gen = &config.generators[&GeneratorId("node-client".into())];
        assert_eq!(node_gen.output, "out");
        assert_eq!(
            node_gen.base_url,
            Some("https://api.example.com".to_string())
        );
        assert_eq!(node_gen.no_jsdoc, Some(true));
    }

    #[test]
    fn test_parse_legacy_react() {
        let yaml = r#"
input: spec.yaml
output: out
target: react
"#;
        let value: serde_json::Value = serde_yaml_ng::from_str(yaml).unwrap();
        let config: OagConfig = serde_json::from_value(value).unwrap();
        assert_eq!(config.generators.len(), 1);
        assert!(
            config
                .generators
                .contains_key(&GeneratorId("react-swr-client".into()))
        );
    }

    #[test]
    fn test_parse_legacy_all_single() {
        let yaml = r#"
input: spec.yaml
output: out
target: all
output_options:
  layout: single
"#;
        let value: serde_json::Value = serde_yaml_ng::from_str(yaml).unwrap();
        let config: OagConfig = serde_json::from_value(value).unwrap();
        // Single layout with "all" maps to react-swr-client (which includes TS)
        assert_eq!(config.generators.len(), 1);
        assert!(
            config
                .generators
                .contains_key(&GeneratorId("react-swr-client".into()))
        );
    }

    #[test]
    fn test_parse_legacy_all_split() {
        let yaml = r#"
input: spec.yaml
output: out
target: all
output_options:
  layout: split
"#;
        let value: serde_json::Value = serde_yaml_ng::from_str(yaml).unwrap();
        let config: OagConfig = serde_json::from_value(value).unwrap();
        assert_eq!(config.generators.len(), 2);
        assert!(
            config
                .generators
                .contains_key(&GeneratorId("node-client".into()))
        );
        assert!(
            config
                .generators
                .contains_key(&GeneratorId("react-swr-client".into()))
        );
        assert_eq!(
            config.generators[&GeneratorId("node-client".into())].output,
            "out/typescript"
        );
        assert_eq!(
            config.generators[&GeneratorId("react-swr-client".into())].output,
            "out/react"
        );
    }

    #[test]
    fn test_tool_setting_resolve() {
        assert_eq!(ToolSetting::resolve(None, "biome"), Some("biome"));
        assert_eq!(
            ToolSetting::resolve(Some(&ToolSetting::Named("ruff".into())), "biome"),
            Some("ruff")
        );
        assert_eq!(
            ToolSetting::resolve(Some(&ToolSetting::Disabled), "biome"),
            None
        );
    }

    #[test]
    fn test_tool_setting_deserialize() {
        let named: ToolSetting = serde_json::from_value(serde_json::json!("biome")).unwrap();
        assert_eq!(named, ToolSetting::Named("biome".into()));

        let disabled: ToolSetting = serde_json::from_value(serde_json::json!(false)).unwrap();
        assert_eq!(disabled, ToolSetting::Disabled);

        let err = serde_json::from_value::<ToolSetting>(serde_json::json!(true));
        assert!(err.is_err());
    }

    #[test]
    fn test_parse_minimal_config() {
        let yaml = "input: api.yaml\n";
        let value: serde_json::Value = serde_yaml_ng::from_str(yaml).unwrap();
        let config: OagConfig = serde_json::from_value(value).unwrap();
        assert_eq!(config.input, "api.yaml");
        // Legacy format with defaults: target=all, layout=single -> react-swr-client
        assert_eq!(config.generators.len(), 1);
    }

    #[test]
    fn test_scaffold_false_disables_scaffolding() {
        let yaml = r#"
generators:
  node-client:
    output: out/node
    scaffold: false
  fastapi-server:
    output: out/server
    scaffold: false
"#;
        let value: serde_json::Value = serde_yaml_ng::from_str(yaml).unwrap();
        let config: OagConfig = serde_json::from_value(value).unwrap();

        let node = &config.generators[&GeneratorId("node-client".into())];
        assert!(
            node.scaffold.is_none(),
            "scaffold: false should become None"
        );

        let fastapi = &config.generators[&GeneratorId("fastapi-server".into())];
        assert!(
            fastapi.scaffold.is_none(),
            "scaffold: false should become None"
        );
    }

    #[test]
    fn test_scaffold_omitted_is_none() {
        let yaml = r#"
generators:
  node-client:
    output: out/node
"#;
        let value: serde_json::Value = serde_yaml_ng::from_str(yaml).unwrap();
        let config: OagConfig = serde_json::from_value(value).unwrap();

        let node = &config.generators[&GeneratorId("node-client".into())];
        assert!(node.scaffold.is_none());
    }
}