nybl-vm 0.5.0

Bytecode compiler and stack VM for the Nybl programming language
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
use nybl::value::NyblFn;
use nybl::{NyblError, NyblHost, NyblLimits, Value};
use nybl_vm::NyblInstance;
use std::collections::BTreeMap;
use std::rc::Rc;

struct Host;

impl NyblHost for Host {
    fn call(
        &mut self,
        _name: &str,
        _args: &[Value],
        _line: u32,
    ) -> Option<Result<Value, NyblError>> {
        None
    }
}

#[test]
fn load_rejects_a_program_using_a_host_disabled_builtin() {
    let mut host = Host;
    let limits = NyblLimits::standard().with_disabled_builtins(["rand"]);
    let error = NyblInstance::load("pub fn roll() { return rand(6) }", &mut host, &limits)
        .err()
        .expect("load must refuse a disabled-builtin reference");
    assert_eq!(error.message, "builtin `rand` is disabled by the host");
    assert!(error.is_fatal, "disabled builtins are uncatchable");
}

#[test]
fn executed_final_public_declarations_define_the_abi() {
    let mut host = Host;
    let mut instance = NyblInstance::load(
        "pub fn first() { return 1 }\npub fn gone() {}\nfn gone() {}\npub fn first(x) { return x }\npub fn last() { return 3 }",
        &mut host,
        &NyblLimits::standard(),
    )
    .unwrap();
    let entries: Vec<(&str, usize)> = instance
        .entry_points()
        .iter()
        .map(|entry| (entry.name(), entry.arity()))
        .collect();
    assert_eq!(entries, vec![("first", 1), ("last", 0)]);
    assert_eq!(
        instance
            .call("first", &[Value::Int(9)], &mut host)
            .unwrap()
            .inspect(),
        "9"
    );
    assert!(instance.call("gone", &[], &mut host).is_err());
}

#[test]
fn top_level_return_retains_prior_root_state_and_skips_later_entries() {
    let mut host = Host;
    let mut instance = NyblInstance::load(
        "let count = 4\npub fn next() { count += 1; return count }\nreturn\npub fn skipped() {}",
        &mut host,
        &NyblLimits::standard(),
    )
    .unwrap();
    assert_eq!(instance.entry_points().len(), 1);
    assert_eq!(
        instance.call("next", &[], &mut host).unwrap().inspect(),
        "5"
    );
    assert_eq!(
        instance.call("next", &[], &mut host).unwrap().inspect(),
        "6"
    );
    assert!(instance.call("skipped", &[], &mut host).is_err());
}

#[test]
fn callbacks_have_instance_affinity_and_preflight_is_line_zero() {
    let source = "pub fn make() { return fn(x) { return x } }";
    let mut host = Host;
    let mut first = NyblInstance::load(source, &mut host, &NyblLimits::standard()).unwrap();
    let callback = first.call("make", &[], &mut host).unwrap();
    let arity = first.call_value(&callback, &[], &mut host).unwrap_err();
    assert_eq!(arity.line, Some(0));
    assert_eq!(
        first
            .call_value(&callback, &[Value::Int(7)], &mut host)
            .unwrap()
            .inspect(),
        "7"
    );

    let mut second = NyblInstance::load(source, &mut host, &NyblLimits::standard()).unwrap();
    let affinity = second
        .call_value(&callback, &[Value::Int(7)], &mut host)
        .unwrap_err();
    assert_eq!(affinity.line, Some(0));
    assert!(affinity.message.contains("different Nybl engine instance"));
}

#[test]
fn embedding_calls_reject_ref_parameters_as_value_only() {
    let mut host = Host;
    let mut instance = NyblInstance::load(
        r#"
let calls = 0
pub fn mutate(ref value) {
    calls = calls + 1
    value = 99
}
pub fn read_calls() { return calls }
pub fn make_ref_callback() {
    return fn(ref value) { panic("callback body ran") }
}
"#,
        &mut host,
        &NyblLimits::standard(),
    )
    .unwrap();

    let entry_error = instance
        .call("mutate", &[Value::Int(1)], &mut host)
        .unwrap_err();
    assert_eq!(entry_error.line, Some(0));
    assert_eq!(
        entry_error.message,
        "argument 1 to `mutate` must be passed with `ref`"
    );
    assert_eq!(
        entry_error.friendly_hint.as_deref(),
        Some("Write `ref` before argument 1.")
    );
    assert_eq!(
        instance
            .call("read_calls", &[], &mut host)
            .unwrap()
            .inspect(),
        "0"
    );

    let callback = instance.call("make_ref_callback", &[], &mut host).unwrap();
    let callback_error = instance
        .call_value(&callback, &[Value::Int(1)], &mut host)
        .unwrap_err();
    assert_eq!(callback_error.line, Some(0));
    assert_eq!(
        callback_error.message,
        "argument 1 to `fn` must be passed with `ref`"
    );
    assert_eq!(
        callback_error.friendly_hint.as_deref(),
        Some("Write `ref` before argument 1.")
    );
}

#[test]
fn try_call_wraps_foreign_affinity_and_callback_arity_preflight_errors() {
    let mut host = Host;
    let mut first = NyblInstance::load(
        "pub fn make() { return fn() { return 7 } }",
        &mut host,
        &NyblLimits::standard(),
    )
    .unwrap();
    let foreign = first.call("make", &[], &mut host).unwrap();

    let mut second = NyblInstance::load(
        "pub fn probe(f) { return try_call(f) }\npub fn make_arity() { return fn(x) { return x } }",
        &mut host,
        &NyblLimits::standard(),
    )
    .unwrap();
    let affinity = second.call("probe", &[foreign], &mut host).unwrap();
    assert!(affinity.inspect().contains("Result::Err"));
    assert!(
        affinity
            .inspect()
            .contains("different Nybl engine instance")
    );

    let wrong_arity = second.call("make_arity", &[], &mut host).unwrap();
    let arity = second.call("probe", &[wrong_arity], &mut host).unwrap();
    assert!(arity.inspect().contains("Result::Err"));
    assert!(arity.inspect().contains("expects 1 argument"));
}

#[test]
fn uncaught_errors_unwind_transient_state_but_keep_prior_mutations() {
    let mut host = Host;
    let mut instance = NyblInstance::load(
        "let count = 0\npub fn fail() { count += 1; let local = [1, 2]; panic(\"boom\") }\npub fn read() { return count }",
        &mut host,
        &NyblLimits::standard(),
    )
    .unwrap();
    assert!(instance.call("fail", &[], &mut host).is_err());
    assert_eq!(
        instance.call("read", &[], &mut host).unwrap().inspect(),
        "1"
    );
    assert!(instance.call("fail", &[], &mut host).is_err());
    assert_eq!(
        instance.call("read", &[], &mut host).unwrap().inspect(),
        "2"
    );
}

#[test]
fn callback_preframe_errors_do_not_erase_live_root_state() {
    let mut host = Host;
    let mut instance = NyblInstance::load(
        "let count = 0\npub fn bump() { count += 1; return count }\npub fn read() { return count }",
        &mut host,
        &NyblLimits::standard(),
    )
    .unwrap();
    assert_eq!(
        instance.call("bump", &[], &mut host).unwrap().inspect(),
        "1"
    );

    let opaque_body: Rc<dyn std::any::Any> = Rc::new(17_u8);
    let external = Value::Fn(
        NyblFn::try_new_compiled(Vec::new(), Vec::new(), opaque_body, None, 0, 0).unwrap(),
    );
    assert!(instance.call_value(&external, &[], &mut host).is_err());
    assert_eq!(
        instance.call("read", &[], &mut host).unwrap().inspect(),
        "1"
    );
}

#[test]
fn step_budget_resets_for_each_call() {
    let limits = NyblLimits {
        max_steps: 20,
        max_memory: 1024 * 1024,
        ..NyblLimits::standard()
    };
    let mut host = Host;
    let mut instance = NyblInstance::load(
        "pub fn work() { let total = 0; repeat 5 { total += 1 }; return total }",
        &mut host,
        &limits,
    )
    .unwrap();
    assert_eq!(
        instance.call("work", &[], &mut host).unwrap().inspect(),
        "5"
    );
    assert_eq!(
        instance.call("work", &[], &mut host).unwrap().inspect(),
        "5"
    );
}

#[test]
fn prepared_and_batch_calls_preserve_state_limits_and_affinity() {
    let limits = NyblLimits {
        max_steps: 20,
        max_memory: 1024 * 1024,
        ..NyblLimits::standard()
    };
    let source = "let total = 0\npub fn work(n) { repeat 5 { total += 1 }; total += n; return total }\npub fn read() { return total }";
    let mut host = Host;
    let mut instance = NyblInstance::load(source, &mut host, &limits).unwrap();
    let work = instance.prepare_entry("work").unwrap();
    assert_eq!(work.name(), "work");
    assert_eq!(work.arity(), 1);
    assert!(!work.is_variadic());
    assert_eq!(
        instance
            .call_prepared(&work, &[Value::Int(1)], &mut host)
            .unwrap()
            .inspect(),
        "6"
    );
    let calls = [[Value::Int(2)], [Value::Int(3)]];
    let values = instance.call_batch(&work, &calls, &mut host).unwrap();
    assert_eq!(
        values.iter().map(Value::inspect).collect::<Vec<_>>(),
        ["13", "21"]
    );

    let mut other = NyblInstance::load(source, &mut host, &limits).unwrap();
    let error = other
        .call_prepared(&work, &[Value::Int(1)], &mut host)
        .unwrap_err();
    assert!(error.message.contains("different Nybl engine instance"));
}

#[test]
fn batch_stops_on_error_and_keeps_prior_mutations() {
    let mut host = Host;
    let mut instance = NyblInstance::load(
        "let total = 0\npub fn add(n) { total += n; if n == 2 { panic(\"stop\") }; return total }\npub fn read() { return total }",
        &mut host,
        &NyblLimits::standard(),
    )
    .unwrap();
    let add = instance.prepare_entry("add").unwrap();
    let calls = [[Value::Int(1)], [Value::Int(2)], [Value::Int(4)]];
    assert_eq!(
        instance
            .call_batch(&add, &calls, &mut host)
            .unwrap_err()
            .message,
        "stop"
    );
    assert_eq!(
        instance.call("read", &[], &mut host).unwrap().inspect(),
        "3"
    );
}

#[test]
fn batch_retains_persistent_memory_accounting() {
    let limits = NyblLimits {
        max_steps: 100,
        max_memory: 64,
        ..NyblLimits::standard()
    };
    let mut host = Host;
    let mut instance = NyblInstance::load(
        "let values = []\npub fn keep(value) { values.push(value); return values.len() }",
        &mut host,
        &limits,
    )
    .unwrap();
    let keep = instance.prepare_entry("keep").unwrap();
    let calls = (0..32).map(|n| [Value::Int(n)]).collect::<Vec<_>>();
    let error = instance.call_batch(&keep, &calls, &mut host).unwrap_err();
    assert!(error.is_fatal);
    assert!(error.message.contains("Memory limit"));
}

struct ValueHost {
    value: i64,
    seen: Vec<i64>,
}

impl NyblHost for ValueHost {
    fn call(&mut self, name: &str, args: &[Value], line: u32) -> Option<Result<Value, NyblError>> {
        match name {
            "host_value" => Some(Ok(Value::Int(self.value))),
            "observe" => Some(match args {
                [Value::Int(value)] => {
                    self.seen.push(*value);
                    Ok(Value::Int(*value))
                }
                _ => Err(NyblError::runtime("observe expects one Int", line)),
            }),
            _ => None,
        }
    }
}

#[test]
fn prepared_entries_do_not_cache_host_specific_dispatch() {
    let source = "pub fn read() { return host_value() }";
    let limits = NyblLimits::standard();

    let mut walker_host_a = ValueHost {
        value: 11,
        seen: Vec::new(),
    };
    let mut walker = nybl::NyblInstance::load(source, &mut walker_host_a, &limits).unwrap();
    let walker_entry = walker.prepare_entry("read").unwrap();
    assert_eq!(
        walker
            .call_prepared(&walker_entry, &[], &mut walker_host_a)
            .unwrap()
            .inspect(),
        "11"
    );
    let mut walker_host_b = ValueHost {
        value: 22,
        seen: Vec::new(),
    };
    assert_eq!(
        walker
            .call_batch(&walker_entry, &[Vec::<Value>::new()], &mut walker_host_b)
            .unwrap()[0]
            .inspect(),
        "22"
    );

    let mut vm_host_a = ValueHost {
        value: 33,
        seen: Vec::new(),
    };
    let mut vm = NyblInstance::load(source, &mut vm_host_a, &limits).unwrap();
    let vm_entry = vm.prepare_entry("read").unwrap();
    assert_eq!(
        vm.call_prepared(&vm_entry, &[], &mut vm_host_a)
            .unwrap()
            .inspect(),
        "33"
    );
    let mut vm_host_b = ValueHost {
        value: 44,
        seen: Vec::new(),
    };
    assert_eq!(
        vm.call_batch(&vm_entry, &[Vec::<Value>::new()], &mut vm_host_b)
            .unwrap()[0]
            .inspect(),
        "44"
    );
}

#[test]
fn batch_matches_repeated_calls_for_results_state_and_host_effects() {
    let source = "let total = 0\npub fn step(n) { total += observe(n); return total }\npub fn read() { return total }";
    let calls = vec![
        vec![Value::Int(2)],
        vec![Value::Int(3)],
        vec![Value::Int(5)],
    ];
    let limits = NyblLimits::standard();

    let mut walker_repeated_host = ValueHost {
        value: 0,
        seen: Vec::new(),
    };
    let mut walker_repeated =
        nybl::NyblInstance::load(source, &mut walker_repeated_host, &limits).unwrap();
    let walker_repeated_values = calls
        .iter()
        .map(|args| {
            walker_repeated
                .call("step", args, &mut walker_repeated_host)
                .unwrap()
        })
        .collect::<Vec<_>>();
    let walker_repeated_final = walker_repeated
        .call("read", &[], &mut walker_repeated_host)
        .unwrap();

    let mut walker_batch_host = ValueHost {
        value: 0,
        seen: Vec::new(),
    };
    let mut walker_batch =
        nybl::NyblInstance::load(source, &mut walker_batch_host, &limits).unwrap();
    let walker_entry = walker_batch.prepare_entry("step").unwrap();
    let walker_batch_values = walker_batch
        .call_batch(&walker_entry, &calls, &mut walker_batch_host)
        .unwrap();
    let walker_batch_final = walker_batch
        .call("read", &[], &mut walker_batch_host)
        .unwrap();
    assert_eq!(
        walker_batch_values
            .iter()
            .map(Value::inspect)
            .collect::<Vec<_>>(),
        walker_repeated_values
            .iter()
            .map(Value::inspect)
            .collect::<Vec<_>>()
    );
    assert_eq!(
        walker_batch_final.inspect(),
        walker_repeated_final.inspect()
    );
    assert_eq!(walker_batch_host.seen, walker_repeated_host.seen);

    let mut vm_repeated_host = ValueHost {
        value: 0,
        seen: Vec::new(),
    };
    let mut vm_repeated = NyblInstance::load(source, &mut vm_repeated_host, &limits).unwrap();
    let vm_repeated_values = calls
        .iter()
        .map(|args| {
            vm_repeated
                .call("step", args, &mut vm_repeated_host)
                .unwrap()
        })
        .collect::<Vec<_>>();
    let vm_repeated_final = vm_repeated
        .call("read", &[], &mut vm_repeated_host)
        .unwrap();

    let mut vm_batch_host = ValueHost {
        value: 0,
        seen: Vec::new(),
    };
    let mut vm_batch = NyblInstance::load(source, &mut vm_batch_host, &limits).unwrap();
    let vm_entry = vm_batch.prepare_entry("step").unwrap();
    let vm_batch_values = vm_batch
        .call_batch(&vm_entry, &calls, &mut vm_batch_host)
        .unwrap();
    let vm_batch_final = vm_batch.call("read", &[], &mut vm_batch_host).unwrap();
    assert_eq!(
        vm_batch_values
            .iter()
            .map(Value::inspect)
            .collect::<Vec<_>>(),
        vm_repeated_values
            .iter()
            .map(Value::inspect)
            .collect::<Vec<_>>()
    );
    assert_eq!(vm_batch_final.inspect(), vm_repeated_final.inspect());
    assert_eq!(vm_batch_host.seen, vm_repeated_host.seen);
}

#[test]
fn preparing_ref_entry_is_rejected_before_execution() {
    let mut host = Host;
    let instance = NyblInstance::load(
        "pub fn update(ref value) { value = 2 }",
        &mut host,
        &NyblLimits::standard(),
    )
    .unwrap();
    let error = instance.prepare_entry("update").unwrap_err();
    assert!(error.message.contains("cannot be called from the host"));
}

#[test]
fn prepared_batches_are_deterministic_across_walker_and_vm() {
    let source = "pub fn roll(n) { return rand(n) }";
    let calls = [
        [Value::Int(100)],
        [Value::Int(100)],
        [Value::Int(100)],
        [Value::Int(100)],
    ];
    let limits = NyblLimits::standard();

    let mut walker_host = Host;
    let mut walker = nybl::NyblInstance::load(source, &mut walker_host, &limits).unwrap();
    let walker_entry = walker.prepare_entry("roll").unwrap();
    let walker_values = walker
        .call_batch(&walker_entry, &calls, &mut walker_host)
        .unwrap();

    let mut vm_host = Host;
    let mut vm = NyblInstance::load(source, &mut vm_host, &limits).unwrap();
    let vm_entry = vm.prepare_entry("roll").unwrap();
    let vm_values = vm.call_batch(&vm_entry, &calls, &mut vm_host).unwrap();

    assert_eq!(
        walker_values.iter().map(Value::inspect).collect::<Vec<_>>(),
        vm_values.iter().map(Value::inspect).collect::<Vec<_>>()
    );
}

#[test]
fn prepared_variadic_entries_keep_minimum_arity_across_engines() {
    let source = "pub fn collect(first, ..rest) { return rest.len() }";
    let calls = vec![
        vec![Value::Int(1)],
        vec![Value::Int(1), Value::Int(2), Value::Int(3)],
    ];
    let limits = NyblLimits::standard();

    let mut walker_host = Host;
    let mut walker = nybl::NyblInstance::load(source, &mut walker_host, &limits).unwrap();
    let walker_entry = walker.prepare_entry("collect").unwrap();
    assert_eq!(walker_entry.arity(), 1);
    assert!(walker_entry.is_variadic());
    let walker_values = walker
        .call_batch(&walker_entry, &calls, &mut walker_host)
        .unwrap();

    let mut vm_host = Host;
    let mut vm = NyblInstance::load(source, &mut vm_host, &limits).unwrap();
    let vm_entry = vm.prepare_entry("collect").unwrap();
    let vm_values = vm.call_batch(&vm_entry, &calls, &mut vm_host).unwrap();

    assert_eq!(
        walker_values.iter().map(Value::inspect).collect::<Vec<_>>(),
        ["0", "2"]
    );
    assert_eq!(
        walker_values.iter().map(Value::inspect).collect::<Vec<_>>(),
        vm_values.iter().map(Value::inspect).collect::<Vec<_>>()
    );
}

struct ModuleHost {
    modules: BTreeMap<String, String>,
}

impl NyblHost for ModuleHost {
    fn call(
        &mut self,
        _name: &str,
        _args: &[Value],
        _line: u32,
    ) -> Option<Result<Value, NyblError>> {
        None
    }

    fn resolve_module(&mut self, name: &str) -> Option<Result<String, NyblError>> {
        self.modules.get(name).cloned().map(Ok)
    }
}

#[test]
fn imported_module_values_are_authoritative_across_calls_and_callbacks() {
    let mut modules = BTreeMap::new();
    modules.insert(
        "state".to_string(),
        "let count = 0\nlet items = [1]\nfn next() { count += 1; items.push(count); return [count, items] }\nfn via(handle) { count += 1; return handle.count }\nfn make() { return fn() { count += 1; return count } }"
            .to_string(),
    );
    let mut host = ModuleHost { modules };
    let mut instance = NyblInstance::load(
        "use state as state\npub fn next() { return state.next() }\npub fn via() { return state.via(state) }\npub fn make() { return state.make() }",
        &mut host,
        &NyblLimits::standard(),
    )
    .unwrap();
    assert_eq!(
        instance.call("next", &[], &mut host).unwrap().inspect(),
        "[1, [1, 1]]"
    );
    assert_eq!(
        instance.call("next", &[], &mut host).unwrap().inspect(),
        "[2, [1, 1, 2]]"
    );
    assert_eq!(instance.call("via", &[], &mut host).unwrap().inspect(), "3");
    let callback = instance.call("make", &[], &mut host).unwrap();
    assert_eq!(
        instance
            .call_value(&callback, &[], &mut host)
            .unwrap()
            .inspect(),
        "4"
    );
    assert_eq!(instance.call("via", &[], &mut host).unwrap().inspect(), "5");
}

#[test]
fn facade_reexports_share_authoritative_values_with_the_declaring_module() {
    let mut modules = BTreeMap::new();
    modules.insert(
        "leaf".to_string(),
        "let count = 0\nlet items = [0]\nfn bump() { count += 1; items.push(count); return [count, items] }\nfn make() { return fn() { count += 1; return count } }"
            .to_string(),
    );
    modules.insert("facade".to_string(), "use leaf".to_string());
    let mut host = ModuleHost { modules };
    let mut instance = NyblInstance::load(
        "use facade as api\nuse leaf as direct\npub fn bump() { return api.bump() }\npub fn read() { return [api.count, direct.count, api.items, direct.items] }\npub fn make() { return api.make() }",
        &mut host,
        &NyblLimits::standard(),
    )
    .unwrap();

    assert_eq!(
        instance.call("bump", &[], &mut host).unwrap().inspect(),
        "[1, [0, 1]]"
    );
    assert_eq!(
        instance.call("read", &[], &mut host).unwrap().inspect(),
        "[1, 1, [0, 1], [0, 1]]"
    );
    let callback = instance.call("make", &[], &mut host).unwrap();
    assert_eq!(
        instance
            .call_value(&callback, &[], &mut host)
            .unwrap()
            .inspect(),
        "2"
    );
    assert_eq!(
        instance.call("read", &[], &mut host).unwrap().inspect(),
        "[2, 2, [0, 1], [0, 1]]"
    );
}

#[test]
fn flat_imports_read_current_authoritative_values_at_root_and_in_functions() {
    let mut modules = BTreeMap::new();
    modules.insert(
        "leaf".to_string(),
        "let count = 0\nfn bump() { count += 1; return count }".to_string(),
    );
    let mut host = ModuleHost { modules };
    let mut instance = NyblInstance::load(
        "use leaf\nuse leaf as direct\npub fn next() { return direct.bump() }\npub fn read_root() { return count }\npub fn read_selective() { use leaf.{count}; return count }\npub fn read_glob() { use leaf; return count }",
        &mut host,
        &NyblLimits::standard(),
    )
    .unwrap();

    assert_eq!(
        instance.call("next", &[], &mut host).unwrap().inspect(),
        "1"
    );
    assert_eq!(
        instance
            .call("read_root", &[], &mut host)
            .unwrap()
            .inspect(),
        "1"
    );
    assert_eq!(
        instance
            .call("read_selective", &[], &mut host)
            .unwrap()
            .inspect(),
        "1"
    );
    assert_eq!(
        instance.call("next", &[], &mut host).unwrap().inspect(),
        "2"
    );
    assert_eq!(
        instance
            .call("read_glob", &[], &mut host)
            .unwrap()
            .inspect(),
        "2"
    );
}

#[test]
fn failed_facade_load_restores_forwarded_values_and_remains_retryable() {
    let mut modules = BTreeMap::new();
    modules.insert("leaf".to_string(), "let count = 0".to_string());
    modules.insert(
        "bad".to_string(),
        "use leaf\ncount += 1\npanic(\"bad facade\")".to_string(),
    );
    let mut host = ModuleHost { modules };
    let mut instance = NyblInstance::load(
        "use leaf as leaf\npub fn load_bad() { use bad }\npub fn read() { return leaf.count }",
        &mut host,
        &NyblLimits::standard(),
    )
    .unwrap();

    assert!(instance.call("load_bad", &[], &mut host).is_err());
    assert_eq!(
        instance.call("read", &[], &mut host).unwrap().inspect(),
        "1"
    );
    assert!(instance.call("load_bad", &[], &mut host).is_err());
    assert_eq!(
        instance.call("read", &[], &mut host).unwrap().inspect(),
        "2"
    );
}

#[test]
fn facade_local_overwrite_returns_the_forwarded_value_to_its_origin() {
    let mut modules = BTreeMap::new();
    modules.insert(
        "leaf".to_string(),
        "let count = 7\nfn read() { return count }\nfn bump() { count += 1; return count }"
            .to_string(),
    );
    modules.insert(
        "facade".to_string(),
        "use leaf\nlet count = 100\nfn own_bump() { count += 1; return count }".to_string(),
    );
    let mut host = ModuleHost { modules };
    let mut instance = NyblInstance::load(
        "use facade as facade\nuse leaf as leaf\npub fn bump() { return facade.own_bump() }\npub fn leaf_read() { return leaf.read() }\npub fn leaf_bump() { return leaf.bump() }\npub fn read() { return [facade.count, leaf.count] }",
        &mut host,
        &NyblLimits::standard(),
    )
    .unwrap();

    assert_eq!(
        instance.call("read", &[], &mut host).unwrap().inspect(),
        "[100, 7]"
    );
    assert_eq!(
        instance
            .call("leaf_read", &[], &mut host)
            .unwrap()
            .inspect(),
        "7"
    );
    assert_eq!(
        instance
            .call("leaf_bump", &[], &mut host)
            .unwrap()
            .inspect(),
        "8"
    );
    assert_eq!(
        instance.call("bump", &[], &mut host).unwrap().inspect(),
        "101"
    );
    assert_eq!(
        instance.call("read", &[], &mut host).unwrap().inspect(),
        "[101, 8]"
    );
}

#[test]
fn recursive_and_cross_module_calls_restore_authoritative_environments_in_order() {
    let mut modules = BTreeMap::new();
    modules.insert(
        "a".to_string(),
        "let count = 0\nfn recurse(n) { count += 1; if n > 0 { return recurse(n - 1) }; return count }\nfn touch() { count += 1; return count }\nfn enter(other, handle) { count += 10; let inner = other.enter(handle); count += 100; return [inner, count] }\nfn read() { return count }"
            .to_string(),
    );
    modules.insert(
        "b".to_string(),
        "let count = 0\nfn enter(other) { count += 10; let inner = other.touch(); count += 100; return [inner, count] }\nfn read() { return count }"
            .to_string(),
    );
    let mut host = ModuleHost { modules };
    let mut instance = NyblInstance::load(
        "use a as a\nuse b as b\npub fn cross() { return a.enter(b, a) }\npub fn recurse() { return a.recurse(2) }\npub fn read() { return [a.read(), b.read()] }",
        &mut host,
        &NyblLimits::standard(),
    )
    .unwrap();

    assert_eq!(
        instance.call("cross", &[], &mut host).unwrap().inspect(),
        "[[11, 110], 111]"
    );
    assert_eq!(
        instance.call("read", &[], &mut host).unwrap().inspect(),
        "[111, 110]"
    );
    assert_eq!(
        instance.call("recurse", &[], &mut host).unwrap().inspect(),
        "114"
    );
    assert_eq!(
        instance.call("read", &[], &mut host).unwrap().inspect(),
        "[114, 110]"
    );
}

#[test]
fn lazy_modules_borrow_the_currently_active_origin_on_success_and_error() {
    let mut modules = BTreeMap::new();
    modules.insert(
        "a".to_string(),
        "let count = 0\nlet items = [0]\nfn load_b() { count += 1; items.push(1); use b; return [count, items] }\nfn load_bad() { count += 1; items.push(2); use bad }\nfn read() { return [count, items] }"
            .to_string(),
    );
    modules.insert(
        "b".to_string(),
        "use a\ncount += 10\nitems.push(10)".to_string(),
    );
    modules.insert(
        "bad".to_string(),
        "use a.{count, items}\ncount += 100\nitems.push(100)\npanic(\"bad lazy module\")"
            .to_string(),
    );
    let mut host = ModuleHost { modules };
    let mut instance = NyblInstance::load(
        "use a as a\npub fn load_b() { return a.load_b() }\npub fn load_bad() { return a.load_bad() }\npub fn read() { return a.read() }",
        &mut host,
        &NyblLimits::standard(),
    )
    .unwrap();

    assert_eq!(
        instance.call("load_b", &[], &mut host).unwrap().inspect(),
        "[11, [0, 1, 10]]"
    );
    assert!(instance.call("load_bad", &[], &mut host).is_err());
    assert_eq!(
        instance.call("read", &[], &mut host).unwrap().inspect(),
        "[112, [0, 1, 10, 2, 100]]"
    );
}

#[test]
fn fatal_step_and_call_depth_errors_leave_the_instance_reusable() {
    let mut host = Host;
    let step_limits = NyblLimits {
        max_steps: 20,
        max_memory: 1024 * 1024,
        ..NyblLimits::standard()
    };
    let mut step_instance = NyblInstance::load(
        "pub fn spin() { while true {} }\npub fn ok() { return 7 }",
        &mut host,
        &step_limits,
    )
    .unwrap();
    let step_error = step_instance.call("spin", &[], &mut host).unwrap_err();
    assert!(step_error.is_fatal);
    assert_eq!(
        step_instance.call("ok", &[], &mut host).unwrap().inspect(),
        "7"
    );

    let mut depth_instance = NyblInstance::load(
        "pub fn dive() { return dive() }\npub fn ok() { return 8 }",
        &mut host,
        &NyblLimits {
            max_steps: 1_000_000,
            max_memory: 1024 * 1024,
            ..NyblLimits::standard()
        },
    )
    .unwrap();
    let depth_error = depth_instance.call("dive", &[], &mut host).unwrap_err();
    assert!(
        depth_error
            .message
            .contains("Too many nested function calls")
    );
    assert_eq!(
        depth_instance.call("ok", &[], &mut host).unwrap().inspect(),
        "8"
    );
}

struct CountingModuleHost {
    modules: BTreeMap<String, String>,
    resolutions: usize,
}

impl NyblHost for CountingModuleHost {
    fn call(
        &mut self,
        _name: &str,
        _args: &[Value],
        _line: u32,
    ) -> Option<Result<Value, NyblError>> {
        None
    }

    fn resolve_module(&mut self, name: &str) -> Option<Result<String, NyblError>> {
        self.resolutions += 1;
        self.modules.get(name).cloned().map(Ok)
    }
}

#[test]
fn lazy_imports_are_cached_even_when_a_later_host_changes_source() {
    let mut host = CountingModuleHost {
        modules: BTreeMap::from([(
            "dynamic".to_string(),
            "struct Item { value }\nfn Item.double(self) { return self.value * 2 }\nfn make() { return Item { value: 1 } }\nlet value = 1"
                .to_string(),
        )]),
        resolutions: 0,
    };
    let mut instance = NyblInstance::load(
        "pub fn read() { use dynamic as dynamic; return dynamic.value }\npub fn method() { use dynamic as dynamic; return dynamic.make().double() }",
        &mut host,
        &NyblLimits::standard(),
    )
    .unwrap();
    assert_eq!(host.resolutions, 0);
    assert_eq!(
        instance.call("read", &[], &mut host).unwrap().inspect(),
        "1"
    );
    assert_eq!(host.resolutions, 1);

    host.modules
        .insert("dynamic".to_string(), "let value = 2".to_string());
    assert_eq!(
        instance.call("read", &[], &mut host).unwrap().inspect(),
        "1"
    );
    assert_eq!(
        instance.call("method", &[], &mut host).unwrap().inspect(),
        "2"
    );
    assert_eq!(host.resolutions, 1);
}

#[test]
fn retained_types_methods_rng_and_cow_values_survive_across_calls() {
    let mut host = Host;
    let source = "struct Counter { value }\nfn Counter.inc(self) { return Counter { value: self.value + 1 } }\nlet stored = Counter { value: 3 }\nlet items = [1]\npub fn method() { stored = stored.inc(); return stored.value }\npub fn take(value) { value.push(2); return value }\npub fn get() { return items }\npub fn push() { items.push(3); return items }\npub fn random() { return rand(1000000) }\npub fn random_pair() { return [rand(1000000), rand(1000000)] }";
    let mut instance = NyblInstance::load(source, &mut host, &NyblLimits::standard()).unwrap();
    assert_eq!(
        instance.call("method", &[], &mut host).unwrap().inspect(),
        "4"
    );
    assert_eq!(
        instance.call("method", &[], &mut host).unwrap().inspect(),
        "5"
    );

    let original = Value::new_array(vec![Value::Int(1)]);
    assert_eq!(
        instance
            .call("take", std::slice::from_ref(&original), &mut host)
            .unwrap()
            .inspect(),
        "[1, 2]"
    );
    assert_eq!(original.inspect(), "[1]");

    let returned = instance.call("get", &[], &mut host).unwrap();
    let Value::Array(mut external) = returned else {
        panic!("expected array")
    };
    external.try_push(Value::Int(2), 0).unwrap();
    assert_eq!(external.len(), 2);
    assert_eq!(
        instance.call("get", &[], &mut host).unwrap().inspect(),
        "[1]"
    );
    assert_eq!(
        instance.call("push", &[], &mut host).unwrap().inspect(),
        "[1, 3]"
    );
    assert_eq!(external.len(), 2);

    let first = instance.call("random", &[], &mut host).unwrap();
    let second = instance.call("random", &[], &mut host).unwrap();
    let mut comparison = NyblInstance::load(source, &mut host, &NyblLimits::standard()).unwrap();
    assert_eq!(
        comparison
            .call("random_pair", &[], &mut host)
            .unwrap()
            .inspect(),
        format!("[{}, {}]", first.inspect(), second.inspect())
    );
}

struct NestedInstanceHost {
    nested: Option<NyblInstance>,
}

impl NyblHost for NestedInstanceHost {
    fn call(
        &mut self,
        name: &str,
        _args: &[Value],
        _line: u32,
    ) -> Option<Result<Value, NyblError>> {
        if name != "nested_call" {
            return None;
        }
        let mut nested = self.nested.take().expect("nested instance present");
        let result = nested.call("next", &[], self);
        self.nested = Some(nested);
        Some(result)
    }
}

#[test]
fn host_calls_may_nest_a_different_instance_without_crossing_state() {
    let mut plain_host = Host;
    let nested = NyblInstance::load(
        "let count = 0\npub fn next() { count += 1; return count }",
        &mut plain_host,
        &NyblLimits::standard(),
    )
    .unwrap();
    let mut host = NestedInstanceHost {
        nested: Some(nested),
    };
    let mut outer = NyblInstance::load(
        "pub fn invoke() { return nested_call() }",
        &mut host,
        &NyblLimits::standard(),
    )
    .unwrap();

    assert_eq!(outer.call("invoke", &[], &mut host).unwrap().inspect(), "1");
    assert_eq!(outer.call("invoke", &[], &mut host).unwrap().inspect(), "2");
}