numrs2 0.3.3

A Rust implementation inspired by NumPy for numerical computing (NumRS2)
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
1177
1178
1179
1180
1181
1182
1183
1184
1185
1186
1187
1188
1189
1190
1191
1192
1193
1194
1195
1196
1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
1207
1208
1209
1210
1211
1212
1213
1214
1215
1216
1217
1218
1219
1220
1221
1222
1223
1224
1225
1226
1227
1228
1229
1230
1231
1232
1233
1234
1235
1236
1237
1238
1239
1240
1241
1242
1243
1244
1245
1246
1247
1248
1249
1250
1251
1252
1253
1254
1255
1256
1257
1258
1259
1260
1261
1262
1263
1264
1265
1266
1267
1268
1269
1270
1271
1272
1273
1274
1275
1276
1277
1278
1279
1280
1281
1282
1283
1284
1285
1286
1287
1288
1289
1290
1291
1292
1293
1294
1295
1296
1297
1298
1299
1300
1301
1302
1303
1304
1305
1306
1307
1308
1309
1310
1311
1312
1313
1314
1315
1316
1317
1318
1319
1320
1321
1322
1323
1324
1325
1326
1327
1328
1329
1330
1331
1332
1333
1334
1335
1336
1337
1338
1339
1340
1341
1342
1343
1344
//! Advanced random distributions
//!
//! This module provides functions for generating random arrays from various
//! probability distributions, similar to NumPy's random.distributions module.

use crate::array::Array;
use crate::error::Result;
use crate::random::state::RandomState;

// Global generator for convenience
lazy_static::lazy_static! {
    static ref GLOBAL_RANDOM_STATE: std::sync::Mutex<RandomState> = std::sync::Mutex::new(RandomState::new());
}

/// Set the random seed for the global generator
pub fn set_seed(seed: u64) {
    match GLOBAL_RANDOM_STATE.lock() {
        Ok(mut guard) => {
            *guard = RandomState::with_seed(seed);
        }
        Err(poisoned) => {
            // If the lock is poisoned, we can still recover by getting the guard
            // and replacing the state, which will clear the poison
            let mut guard = poisoned.into_inner();
            *guard = RandomState::with_seed(seed);
        }
    }
}

/// Get a reference to the global random state
pub fn get_global_random_state() -> Result<std::sync::MutexGuard<'static, RandomState>> {
    match GLOBAL_RANDOM_STATE.lock() {
        Ok(guard) => Ok(guard),
        Err(poisoned) => {
            // If the lock is poisoned, we can still recover by getting the guard
            // This allows the random number generation to continue working even after a panic
            Ok(poisoned.into_inner())
        }
    }
}

/// Generate random values from a beta distribution using the global generator
///
/// # Arguments
///
/// * `a` - Alpha parameter of the beta distribution
/// * `b` - Beta parameter of the beta distribution
/// * `shape` - Shape of the output array
///
/// # Returns
///
/// An array of random values from the beta distribution
pub fn beta<T>(a: T, b: T, shape: &[usize]) -> Result<Array<T>>
where
    T: num_traits::Float + num_traits::NumCast + Clone + std::fmt::Debug + std::fmt::Display,
{
    let rng = get_global_random_state()?;
    rng.beta(a, b, shape)
}

/// Generate random values from a binomial distribution using the global generator
///
/// # Arguments
///
/// * `n` - Number of trials
/// * `p` - Probability of success in each trial
/// * `shape` - Shape of the output array
///
/// # Returns
///
/// An array of random values from the binomial distribution
pub fn binomial<T>(n: u64, p: f64, shape: &[usize]) -> Result<Array<T>>
where
    T: num_traits::NumCast + Clone + std::fmt::Debug,
{
    let rng = get_global_random_state()?;
    rng.binomial(n, p, shape)
}

/// Generate random values from a chi-square distribution using the global generator
///
/// # Arguments
///
/// * `df` - Degrees of freedom
/// * `shape` - Shape of the output array
///
/// # Returns
///
/// An array of random values from the chi-square distribution
pub fn chisquare<T>(df: T, shape: &[usize]) -> Result<Array<T>>
where
    T: num_traits::Float + num_traits::NumCast + Clone + std::fmt::Debug + std::fmt::Display,
{
    let rng = get_global_random_state()?;
    rng.chisquare(df, shape)
}

/// Generate random values from a Dirichlet distribution using the global generator
///
/// # Arguments
///
/// * `alpha` - Concentration parameters
/// * `shape` - Shape of the output array
///
/// # Returns
///
/// An array of random values from the Dirichlet distribution
pub fn dirichlet<T>(alpha: &[T], shape: &[usize]) -> Result<Array<T>>
where
    T: num_traits::Float + num_traits::NumCast + Clone + std::fmt::Debug + std::fmt::Display,
{
    let rng = get_global_random_state()?;
    rng.dirichlet(alpha, shape)
}

/// Generate random values from a gamma distribution using the global generator
///
/// # Arguments
///
/// * `shape` - Shape parameter of the gamma distribution
/// * `scale` - Scale parameter of the gamma distribution
/// * `output_shape` - Shape of the output array
///
/// # Returns
///
/// An array of random values from the gamma distribution
pub fn gamma<T>(shape_param: T, scale: T, output_shape: &[usize]) -> Result<Array<T>>
where
    T: num_traits::Float + num_traits::NumCast + Clone + std::fmt::Debug + std::fmt::Display,
{
    let rng = get_global_random_state()?;
    rng.gamma(shape_param, scale, output_shape)
}

/// Generate random values from a normal distribution using the global generator
///
/// # Arguments
///
/// * `mean` - Mean of the normal distribution
/// * `std` - Standard deviation of the normal distribution
/// * `shape` - Shape of the output array
///
/// # Returns
///
/// An array of random values from the normal distribution
pub fn normal<T>(mean: T, std: T, shape: &[usize]) -> Result<Array<T>>
where
    T: num_traits::Float + num_traits::NumCast + Clone + std::fmt::Debug + std::fmt::Display,
{
    let rng = get_global_random_state()?;
    rng.normal(mean, std, shape)
}

/// Generate random values from a standard normal distribution using the global generator
///
/// # Arguments
///
/// * `shape` - Shape of the output array
///
/// # Returns
///
/// An array of random values from the standard normal distribution
pub fn standard_normal<T>(shape: &[usize]) -> Result<Array<T>>
where
    T: num_traits::Float + num_traits::NumCast + Clone + std::fmt::Debug + std::fmt::Display,
{
    let rng = get_global_random_state()?;
    rng.standard_normal(shape)
}

/// Generate random values from a Poisson distribution using the global generator
///
/// # Arguments
///
/// * `lam` - Mean of the Poisson distribution
/// * `shape` - Shape of the output array
///
/// # Returns
///
/// An array of random values from the Poisson distribution
pub fn poisson<T>(lam: f64, shape: &[usize]) -> Result<Array<T>>
where
    T: num_traits::NumCast + Clone + std::fmt::Debug,
{
    let rng = get_global_random_state()?;
    rng.poisson(lam, shape)
}

/// Generate random values from a uniform distribution using the global generator
///
/// # Arguments
///
/// * `low` - Lower bound (inclusive)
/// * `high` - Upper bound (inclusive)
/// * `shape` - Shape of the output array
///
/// # Returns
///
/// An array of random values from the uniform distribution
pub fn uniform<T>(low: T, high: T, shape: &[usize]) -> Result<Array<T>>
where
    T: Clone
        + PartialOrd
        + scirs2_core::ndarray::distributions::uniform::SampleUniform
        + num_traits::ToPrimitive
        + num_traits::NumCast,
{
    let rng = get_global_random_state()?;
    rng.uniform(low, high, shape)
}

/// Generate random integers in the range [low, high) using the global generator
///
/// # Arguments
///
/// * `low` - Lower bound (inclusive)
/// * `high` - Upper bound (exclusive)
/// * `shape` - Shape of the output array
///
/// # Returns
///
/// An array of random integers
pub fn integers<T>(low: T, high: T, shape: &[usize]) -> Result<Array<T>>
where
    T: Clone
        + PartialOrd
        + scirs2_core::ndarray::distributions::uniform::SampleUniform
        + Into<i64>
        + TryFrom<i64>
        + num_traits::ToPrimitive,
    <T as TryFrom<i64>>::Error: std::fmt::Debug,
{
    let rng = get_global_random_state()?;
    rng.integers(low, high, shape)
}

/// Generate random values from a log-normal distribution using the global generator
///
/// # Arguments
///
/// * `mean` - Mean of the log-normal distribution
/// * `sigma` - Standard deviation of the log-normal distribution
/// * `shape` - Shape of the output array
///
/// # Returns
///
/// An array of random values from the log-normal distribution
pub fn lognormal<T>(mean: T, sigma: T, shape: &[usize]) -> Result<Array<T>>
where
    T: num_traits::Float + num_traits::NumCast + Clone + std::fmt::Debug + std::fmt::Display,
{
    let rng = get_global_random_state()?;
    rng.lognormal(mean, sigma, shape)
}

/// Generate random values from a Cauchy distribution using the global generator
///
/// # Arguments
///
/// * `loc` - Location parameter
/// * `scale` - Scale parameter
/// * `shape` - Shape of the output array
///
/// # Returns
///
/// An array of random values from the Cauchy distribution
pub fn cauchy<T>(loc: T, scale: T, shape: &[usize]) -> Result<Array<T>>
where
    T: num_traits::Float + num_traits::NumCast + Clone + std::fmt::Debug + std::fmt::Display,
{
    let rng = get_global_random_state()?;
    rng.cauchy(loc, scale, shape)
}

/// Generate random values from a Student's t-distribution using the global generator
///
/// # Arguments
///
/// * `df` - Degrees of freedom
/// * `shape` - Shape of the output array
///
/// # Returns
///
/// An array of random values from the Student's t-distribution
pub fn student_t<T>(df: T, shape: &[usize]) -> Result<Array<T>>
where
    T: num_traits::Float + num_traits::NumCast + Clone + std::fmt::Debug + std::fmt::Display,
{
    let rng = get_global_random_state()?;
    rng.student_t(df, shape)
}

/// Generate random values from an exponential distribution using the global generator
///
/// # Arguments
///
/// * `scale` - Scale parameter
/// * `shape` - Shape of the output array
///
/// # Returns
///
/// An array of random values from the exponential distribution
pub fn exponential<T>(scale: T, shape: &[usize]) -> Result<Array<T>>
where
    T: num_traits::Float + num_traits::NumCast + Clone + std::fmt::Debug + std::fmt::Display,
{
    let rng = get_global_random_state()?;
    rng.exponential(scale, shape)
}

/// Generate random values from a Weibull distribution using the global generator
///
/// # Arguments
///
/// * `shape_param` - Shape parameter of the Weibull distribution
/// * `scale` - Scale parameter of the Weibull distribution
/// * `output_shape` - Shape of the output array
///
/// # Returns
///
/// An array of random values from the Weibull distribution
pub fn weibull<T>(shape_param: T, scale: T, output_shape: &[usize]) -> Result<Array<T>>
where
    T: num_traits::Float + num_traits::NumCast + Clone + std::fmt::Debug + std::fmt::Display,
{
    let rng = get_global_random_state()?;
    rng.weibull(shape_param, scale, output_shape)
}

/// Generate random binary values with given probability of success
///
/// # Arguments
///
/// * `p` - Probability of success
/// * `shape` - Shape of the output array
///
/// # Returns
///
/// An array of random binary values
pub fn bernoulli<T>(p: T, shape: &[usize]) -> Result<Array<T>>
where
    T: num_traits::Float + num_traits::NumCast + Clone + std::fmt::Debug + std::fmt::Display,
{
    let rng = get_global_random_state()?;
    rng.bernoulli(p, shape)
}

/// Generate random values from a Pareto distribution using the global generator
///
/// # Arguments
///
/// * `alpha` - Shape parameter of the Pareto distribution
/// * `shape` - Shape of the output array
///
/// # Returns
///
/// An array of random values from the Pareto distribution
pub fn pareto<T>(alpha: T, shape: &[usize]) -> Result<Array<T>>
where
    T: num_traits::Float + num_traits::NumCast + Clone + std::fmt::Debug + std::fmt::Display,
{
    let rng = get_global_random_state()?;
    rng.pareto(alpha, shape)
}

/// Generate random values from a Triangular distribution using the global generator
///
/// # Arguments
///
/// * `low` - Lower bound
/// * `mode` - Mode (most common value)
/// * `high` - Upper bound
/// * `shape` - Shape of the output array
///
/// # Returns
///
/// An array of random values from the Triangular distribution
pub fn triangular<T>(low: T, mode: T, high: T, shape: &[usize]) -> Result<Array<T>>
where
    T: num_traits::Float + num_traits::NumCast + Clone + std::fmt::Debug + std::fmt::Display,
{
    let rng = get_global_random_state()?;
    rng.triangular(low, mode, high, shape)
}

/// Generate random values from a PERT distribution using the global generator
///
/// # Arguments
///
/// * `min` - Minimum value
/// * `mode` - Mode (most likely value)
/// * `max` - Maximum value
/// * `shape` - Shape of the output array
///
/// # Returns
///
/// An array of random values from the PERT distribution
pub fn pert<T>(min: T, mode: T, max: T, shape: &[usize]) -> Result<Array<T>>
where
    T: num_traits::Float + num_traits::NumCast + Clone + std::fmt::Debug + std::fmt::Display,
{
    let rng = get_global_random_state()?;
    rng.pert(min, mode, max, shape)
}

/// Generate random values from a multivariate normal distribution using the global generator
///
/// # Arguments
///
/// * `mean` - Mean vector
/// * `cov` - Covariance matrix
/// * `size` - Optional shape of the output array
///
/// # Returns
///
/// An array of random values from the multivariate normal distribution
pub fn multivariate_normal<T>(
    mean: &[T],
    cov: &Array<T>,
    size: Option<&[usize]>,
) -> Result<Array<T>>
where
    T: num_traits::Float + num_traits::NumCast + Clone + std::fmt::Debug + std::fmt::Display,
{
    let rng = get_global_random_state()?;
    rng.multivariate_normal(mean, cov, size)
}

/// Generate random values from a Laplace distribution using the global generator
///
/// # Arguments
///
/// * `loc` - Location parameter
/// * `scale` - Scale parameter
/// * `shape` - Shape of the output array
///
/// # Returns
///
/// An array of random values from the Laplace distribution
pub fn laplace<T>(loc: T, scale: T, shape: &[usize]) -> Result<Array<T>>
where
    T: num_traits::Float + num_traits::NumCast + Clone + std::fmt::Debug + std::fmt::Display,
{
    let rng = get_global_random_state()?;
    rng.laplace(loc, scale, shape)
}

/// Generate random values from a Gumbel distribution using the global generator
///
/// # Arguments
///
/// * `loc` - Location parameter
/// * `scale` - Scale parameter
/// * `shape` - Shape of the output array
///
/// # Returns
///
/// An array of random values from the Gumbel distribution
pub fn gumbel<T>(loc: T, scale: T, shape: &[usize]) -> Result<Array<T>>
where
    T: num_traits::Float + num_traits::NumCast + Clone + std::fmt::Debug + std::fmt::Display,
{
    let rng = get_global_random_state()?;
    rng.gumbel(loc, scale, shape)
}

/// Generate random values from a logistic distribution using the global generator
///
/// # Arguments
///
/// * `loc` - Location parameter
/// * `scale` - Scale parameter
/// * `shape` - Shape of the output array
///
/// # Returns
///
/// An array of random values from the logistic distribution
pub fn logistic<T>(loc: T, scale: T, shape: &[usize]) -> Result<Array<T>>
where
    T: num_traits::Float + num_traits::NumCast + Clone + std::fmt::Debug + std::fmt::Display,
{
    let rng = get_global_random_state()?;
    rng.logistic(loc, scale, shape)
}

/// Generate random values from a Rayleigh distribution using the global generator
///
/// # Arguments
///
/// * `scale` - Scale parameter
/// * `shape` - Shape of the output array
///
/// # Returns
///
/// An array of random values from the Rayleigh distribution
pub fn rayleigh<T>(scale: T, shape: &[usize]) -> Result<Array<T>>
where
    T: num_traits::Float + num_traits::NumCast + Clone + std::fmt::Debug + std::fmt::Display,
{
    let rng = get_global_random_state()?;
    rng.rayleigh(scale, shape)
}

/// Generate random values from a Wald (inverse Gaussian) distribution using the global generator
///
/// # Arguments
///
/// * `mean` - Mean parameter
/// * `scale` - Scale parameter
/// * `shape` - Shape of the output array
///
/// # Returns
///
/// An array of random values from the Wald distribution
pub fn wald<T>(mean: T, scale: T, shape: &[usize]) -> Result<Array<T>>
where
    T: num_traits::Float + num_traits::NumCast + Clone + std::fmt::Debug + std::fmt::Display,
{
    let rng = get_global_random_state()?;
    rng.wald(mean, scale, shape)
}

/// Generate random values from a negative binomial distribution using the global generator
///
/// # Arguments
///
/// * `n` - Number of successes
/// * `p` - Probability of a single success
/// * `shape` - Shape of the output array
///
/// # Returns
///
/// An array of random values from the negative binomial distribution
pub fn negative_binomial<T>(n: f64, p: f64, shape: &[usize]) -> Result<Array<T>>
where
    T: num_traits::NumCast + Clone + std::fmt::Debug,
{
    let rng = get_global_random_state()?;
    rng.negative_binomial(n, p, shape)
}

/// Generate random values from a geometric distribution using the global generator
///
/// # Arguments
///
/// * `p` - Success probability
/// * `shape` - Shape of the output array
///
/// # Returns
///
/// An array of random values from the geometric distribution
pub fn geometric<T>(p: f64, shape: &[usize]) -> Result<Array<T>>
where
    T: num_traits::NumCast + Clone + std::fmt::Debug,
{
    let rng = get_global_random_state()?;
    rng.geometric(p, shape)
}

/// Generate random values from a multinomial distribution using the global generator
///
/// # Arguments
///
/// * `n` - Number of trials
/// * `pvals` - Probability vector
/// * `shape` - Optional shape of the output array
///
/// # Returns
///
/// An array of random values from the multinomial distribution
pub fn multinomial<T>(n: usize, pvals: &[f64], shape: Option<&[usize]>) -> Result<Array<T>>
where
    T: num_traits::NumCast + Clone + std::fmt::Debug,
{
    let rng = get_global_random_state()?;
    rng.multinomial(n, pvals, shape)
}

/// Generate random values from a hypergeometric distribution using the global generator
///
/// # Arguments
///
/// * `ngood` - Number of successes in the population
/// * `nbad` - Number of failures in the population
/// * `nsample` - Number of samples drawn
/// * `shape` - Shape of the output array
///
/// # Returns
///
/// An array of random values from the hypergeometric distribution
pub fn hypergeometric<T>(
    ngood: usize,
    nbad: usize,
    nsample: usize,
    shape: &[usize],
) -> Result<Array<T>>
where
    T: num_traits::NumCast + Clone + std::fmt::Debug,
{
    let rng = get_global_random_state()?;
    rng.hypergeometric(ngood, nbad, nsample, shape)
}

/// Generate random values from a zipf distribution using the global generator
///
/// # Arguments
///
/// * `a` - Distribution parameter
/// * `shape` - Shape of the output array
///
/// # Returns
///
/// An array of random values from the zipf distribution
pub fn zipf<T>(a: f64, shape: &[usize]) -> Result<Array<T>>
where
    T: num_traits::NumCast + Clone + std::fmt::Debug,
{
    let rng = get_global_random_state()?;
    rng.zipf(a, shape)
}

/// Generate random values from a logseries distribution using the global generator
///
/// # Arguments
///
/// * `p` - Distribution parameter
/// * `shape` - Shape of the output array
///
/// # Returns
///
/// An array of random values from the logseries distribution
pub fn logseries<T>(p: f64, shape: &[usize]) -> Result<Array<T>>
where
    T: num_traits::NumCast + Clone + std::fmt::Debug,
{
    let rng = get_global_random_state()?;
    rng.logseries(p, shape)
}

/// Generate random values from a noncentral chi-square distribution using the global generator
///
/// # Arguments
///
/// * `df` - Degrees of freedom (must be positive)
/// * `nonc` - Non-centrality parameter (must be non-negative)
/// * `shape` - Shape of the output array
///
/// # Returns
///
/// An array of random values from the noncentral chi-square distribution
pub fn noncentral_chisquare<T>(df: T, nonc: T, shape: &[usize]) -> Result<Array<T>>
where
    T: num_traits::Float + num_traits::NumCast + Clone + std::fmt::Debug + std::fmt::Display,
{
    let rng = get_global_random_state()?;
    rng.noncentral_chisquare(df, nonc, shape)
}

/// Generate random values from a noncentral F distribution using the global generator
///
/// # Arguments
///
/// * `dfnum` - Numerator degrees of freedom (must be positive)
/// * `dfden` - Denominator degrees of freedom (must be positive)
/// * `nonc` - Non-centrality parameter (must be non-negative)
/// * `shape` - Shape of the output array
///
/// # Returns
///
/// An array of random values from the noncentral F distribution
pub fn noncentral_f<T>(dfnum: T, dfden: T, nonc: T, shape: &[usize]) -> Result<Array<T>>
where
    T: num_traits::Float + num_traits::NumCast + Clone + std::fmt::Debug + std::fmt::Display,
{
    let rng = get_global_random_state()?;
    rng.noncentral_f(dfnum, dfden, nonc, shape)
}

/// Generate random values from a von Mises distribution using the global generator
///
/// The von Mises distribution, also known as the circular normal distribution, is a
/// continuous probability distribution on a circle. It is the circular analogue of the
/// normal distribution.
///
/// # Arguments
///
/// * `mu` - Mean direction (in radians)
/// * `kappa` - Concentration parameter (must be non-negative)
/// * `shape` - Shape of the output array
///
/// # Returns
///
/// An array of random values from the von Mises distribution in the range [-π, π)
pub fn vonmises<T>(mu: T, kappa: T, shape: &[usize]) -> Result<Array<T>>
where
    T: num_traits::Float + num_traits::NumCast + Clone + std::fmt::Debug + std::fmt::Display,
{
    let rng = get_global_random_state()?;
    rng.vonmises(mu, kappa, shape)
}

/// Generate random values from a Maxwell-Boltzmann distribution using the global generator
///
/// The Maxwell-Boltzmann distribution describes the velocity of particles in thermal equilibrium.
/// It is closely related to the chi distribution with 3 degrees of freedom.
///
/// # Arguments
///
/// * `scale` - Scale parameter (must be positive)
/// * `shape` - Shape of the output array
///
/// # Returns
///
/// An array of random values from the Maxwell-Boltzmann distribution
pub fn maxwell<T>(scale: T, shape: &[usize]) -> Result<Array<T>>
where
    T: num_traits::Float + num_traits::NumCast + Clone + std::fmt::Debug + std::fmt::Display,
{
    let rng = get_global_random_state()?;
    rng.maxwell(scale, shape)
}

/// Generate random values from a truncated normal distribution using the global generator
///
/// The truncated normal distribution is a normal distribution bounded within a specified range.
/// All values below the lower bound or above the upper bound are excluded and
/// the probability density is rescaled accordingly.
///
/// # Arguments
///
/// * `mean` - Mean of the normal distribution before truncation
/// * `std` - Standard deviation of the normal distribution before truncation (must be positive)
/// * `low` - Lower bound of the truncation
/// * `high` - Upper bound of the truncation (must be greater than low)
/// * `shape` - Shape of the output array
///
/// # Returns
///
/// An array of random values from the truncated normal distribution in the range [low, high]
pub fn truncated_normal<T>(mean: T, std: T, low: T, high: T, shape: &[usize]) -> Result<Array<T>>
where
    T: num_traits::Float + num_traits::NumCast + Clone + std::fmt::Debug + std::fmt::Display,
{
    let rng = get_global_random_state()?;
    rng.truncated_normal(mean, std, low, high, shape)
}

/// Generate random values from a multivariate normal distribution with rotation using the global generator
///
/// This function extends the multivariate normal distribution with an optional rotation matrix.
/// The rotation is applied to the Cholesky factor of the covariance matrix, allowing for
/// coordinate system transformations.
///
/// # Arguments
///
/// * `mean` - Mean vector
/// * `cov` - Covariance matrix (must be positive definite)
/// * `size` - Optional shape of the output array
/// * `rotation` - Optional rotation matrix (must be square with dimensions matching mean vector length)
///
/// # Returns
///
/// An array of random values from the multivariate normal distribution with rotation
pub fn multivariate_normal_with_rotation<T>(
    mean: &[T],
    cov: &Array<T>,
    size: Option<&[usize]>,
    rotation: Option<&Array<T>>,
) -> Result<Array<T>>
where
    T: num_traits::Float + num_traits::NumCast + Clone + std::fmt::Debug + std::fmt::Display,
{
    let rng = get_global_random_state()?;
    rng.multivariate_normal_with_rotation(mean, cov, size, rotation)
}

/// Generate random values from a multivariate t-distribution using the global generator
///
/// The multivariate t-distribution is a generalization of the Student's t-distribution
/// to multiple dimensions. It has heavier tails than the multivariate normal distribution.
///
/// # Arguments
///
/// * `mean` - Mean vector
/// * `cov` - Covariance matrix (must be positive definite)
/// * `df` - Degrees of freedom (must be positive)
/// * `size` - Optional shape of the output array
///
/// # Returns
///
/// An array of random values from the multivariate t-distribution
///
/// # Examples
///
/// ```
/// use numrs2::random::distributions::multivariate_t;
/// use numrs2::array::Array;
///
/// let mean = vec![0.0, 0.0];
/// let cov_data = vec![1.0, 0.5, 0.5, 1.0];
/// let cov = Array::from_vec(cov_data).reshape(&[2, 2]);
/// let samples = multivariate_t(&mean, &cov, 5.0, Some(&[10]));
/// ```
pub fn multivariate_t<T>(
    mean: &[T],
    cov: &Array<T>,
    df: T,
    size: Option<&[usize]>,
) -> Result<Array<T>>
where
    T: num_traits::Float + num_traits::NumCast + Clone + std::fmt::Debug + std::fmt::Display,
{
    let rng = get_global_random_state()?;
    rng.multivariate_t(mean, cov, df, size)
}

/// Generate random values from a Wishart distribution using the global generator
///
/// The Wishart distribution is a generalization of the chi-squared distribution to
/// positive-definite matrices. It's commonly used as the conjugate prior for the
/// precision matrix in multivariate normal distributions.
///
/// # Arguments
///
/// * `df` - Degrees of freedom (must be >= dimension of scale matrix)
/// * `scale` - Scale matrix (positive definite)
/// * `size` - Optional shape of the output array
///
/// # Returns
///
/// An array of random positive-definite matrices from the Wishart distribution
///
/// # Examples
///
/// ```
/// use numrs2::random::distributions::wishart;
/// use numrs2::array::Array;
///
/// let scale_data = vec![1.0, 0.5, 0.5, 1.0];
/// let scale = Array::from_vec(scale_data).reshape(&[2, 2]);
/// let samples = wishart(5.0, &scale, Some(&[3]));
/// // Returns 3 random 2x2 positive-definite matrices
/// ```
pub fn wishart<T>(df: T, scale: &Array<T>, size: Option<&[usize]>) -> Result<Array<T>>
where
    T: num_traits::Float + num_traits::NumCast + Clone + std::fmt::Debug + std::fmt::Display,
{
    let rng = get_global_random_state()?;
    rng.wishart(df, scale, size)
}

/// Generate random values from a Frechet distribution using the global generator
///
/// The Frechet distribution (Type II extreme value distribution) is used in extreme
/// value theory to model the maximum of a large sample of random variables.
///
/// # Arguments
///
/// * `shape` - Shape parameter (alpha, must be positive)
/// * `loc` - Location parameter
/// * `scale` - Scale parameter (must be positive)
/// * `output_shape` - Shape of the output array
///
/// # Returns
///
/// An array of random values from the Frechet distribution
///
/// # Examples
///
/// ```
/// use numrs2::random::distributions::frechet;
///
/// let samples = frechet(2.0, 0.0, 1.0, &[100]);
/// // All values should be > loc (0.0)
/// ```
pub fn frechet<T>(shape: T, loc: T, scale: T, output_shape: &[usize]) -> Result<Array<T>>
where
    T: num_traits::Float + num_traits::NumCast + Clone + std::fmt::Debug + std::fmt::Display,
{
    let rng = get_global_random_state()?;
    rng.frechet(shape, loc, scale, output_shape)
}

/// Generate random values from a Generalized Extreme Value (GEV) distribution using the global generator
///
/// The GEV distribution combines three types of extreme value distributions:
/// - Type I (Gumbel): shape = 0
/// - Type II (Frechet): shape > 0
/// - Type III (Weibull): shape < 0
///
/// # Arguments
///
/// * `shape` - Shape parameter (ξ, xi)
/// * `loc` - Location parameter (μ, mu)
/// * `scale` - Scale parameter (σ, sigma, must be positive)
/// * `output_shape` - Shape of the output array
///
/// # Returns
///
/// An array of random values from the GEV distribution
///
/// # Examples
///
/// ```
/// use numrs2::random::distributions::gev;
///
/// // Gumbel (shape ≈ 0)
/// let gumbel = gev(0.0, 0.0, 1.0, &[100]);
///
/// // Frechet (shape > 0)
/// let frechet = gev(0.5, 0.0, 1.0, &[100]);
///
/// // Weibull (shape < 0)
/// let weibull = gev(-0.5, 0.0, 1.0, &[100]);
/// ```
pub fn gev<T>(shape: T, loc: T, scale: T, output_shape: &[usize]) -> Result<Array<T>>
where
    T: num_traits::Float + num_traits::NumCast + Clone + std::fmt::Debug + std::fmt::Display,
{
    let rng = get_global_random_state()?;
    rng.gev(shape, loc, scale, output_shape)
}

#[cfg(test)]
mod tests {
    use super::*;

    #[test]
    fn test_beta_distribution() {
        let arr = beta(2.0, 5.0, &[10]).expect("test: beta should succeed");
        assert_eq!(arr.shape(), vec![10]);
    }

    #[test]
    fn test_normal_distribution() {
        let arr = normal(0.0, 1.0, &[5, 5]).expect("test: normal should succeed");
        assert_eq!(arr.shape(), vec![5, 5]);
    }

    #[test]
    fn test_standard_normal_distribution() {
        let arr = standard_normal::<f64>(&[3, 3]).expect("test: standard_normal should succeed");
        assert_eq!(arr.shape(), vec![3, 3]);
    }

    #[test]
    fn test_binomial_distribution() {
        let arr = binomial::<u64>(10, 0.5, &[5]).expect("test: binomial should succeed");
        assert_eq!(arr.shape(), vec![5]);

        // Values should be in the range [0, 10]
        for val in arr.to_vec() {
            assert!(val <= 10);
        }
    }

    #[test]
    fn test_gamma_distribution() {
        let arr = gamma(2.0, 2.0, &[10]).expect("test: gamma should succeed");
        assert_eq!(arr.shape(), vec![10]);

        // Gamma values should be positive
        for val in arr.to_vec() {
            assert!(val > 0.0);
        }
    }

    #[test]
    #[ignore = "Seeding behavior changed during SciRS2 migration - requires seeding implementation fix"]
    fn test_set_seed() {
        // Test that the same seed produces the same sequence
        // by generating multiple arrays with the same seed
        let seed1 = 12345u64;
        let seed2 = 54321u64;

        // First sequence with seed1
        set_seed(seed1);
        let arr1_a = normal(0.0, 1.0, &[5]).expect("test: normal should succeed");
        let arr1_b = normal(0.0, 1.0, &[5]).expect("test: normal should succeed");

        // Reset to seed1 and generate the same sequence
        set_seed(seed1);
        let arr2_a = normal(0.0, 1.0, &[5]).expect("test: normal should succeed");
        let arr2_b = normal(0.0, 1.0, &[5]).expect("test: normal should succeed");

        // Verify that resetting the seed reproduces the same sequence
        assert_eq!(
            arr1_a.to_vec(),
            arr2_a.to_vec(),
            "First arrays should be identical"
        );
        assert_eq!(
            arr1_b.to_vec(),
            arr2_b.to_vec(),
            "Second arrays should be identical"
        );

        // Now test with a different seed
        set_seed(seed2);
        let arr3_a = normal(0.0, 1.0, &[5]).expect("test: normal should succeed");

        // Different seeds should produce different results
        assert_ne!(
            arr1_a.to_vec(),
            arr3_a.to_vec(),
            "Different seeds should produce different results"
        );
    }

    #[test]
    fn test_pareto_distribution() {
        let arr = pareto(2.0, &[10]).expect("test: pareto should succeed");
        assert_eq!(arr.shape(), vec![10]);

        // Pareto values should be greater than or equal to 1
        for val in arr.to_vec() {
            assert!(val >= 1.0);
        }
    }

    #[test]
    fn test_triangular_distribution() {
        // Now using our own implementation instead of rand_distr
        let result = triangular(0.0, 2.0, 10.0, &[10]);
        let arr = result.expect("test: triangular should succeed");
        assert_eq!(arr.shape(), vec![10]);

        // Triangular values should be in the range [low, high]
        for val in arr.to_vec() {
            assert!((0.0..=10.0).contains(&val));
        }
    }

    #[test]
    fn test_pert_distribution() {
        let arr = pert(0.0, 5.0, 10.0, &[10]).expect("test: pert should succeed");
        assert_eq!(arr.shape(), vec![10]);

        // PERT values should be in the range [min, max]
        for val in arr.to_vec() {
            assert!((0.0..=10.0).contains(&val));
        }
    }

    #[test]
    fn test_multivariate_normal_distribution() {
        let mean = vec![0.0, 0.0];
        let cov_data = vec![1.0, 0.5, 0.5, 1.0];
        let cov = Array::from_vec(cov_data).reshape(&[2, 2]);

        let arr = multivariate_normal(&mean, &cov, Some(&[10]))
            .expect("test: multivariate_normal should succeed");
        assert_eq!(arr.shape(), vec![10, 2]);
    }

    #[test]
    fn test_laplace_distribution() {
        let arr = laplace(0.0, 1.0, &[10]).expect("test: laplace should succeed");
        assert_eq!(arr.shape(), vec![10]);
    }

    #[test]
    fn test_negative_binomial_distribution() {
        let arr = negative_binomial::<u64>(5.0, 0.5, &[10])
            .expect("test: negative_binomial should succeed");
        assert_eq!(arr.shape(), vec![10]);
    }

    #[test]
    fn test_multinomial_distribution() {
        let pvals = vec![0.2, 0.3, 0.5];
        let arr = multinomial::<u64>(10, &pvals, None).expect("test: multinomial should succeed");
        assert_eq!(arr.shape(), vec![3]);

        // Sum of counts should equal the number of trials
        let sum: u64 = arr.to_vec().iter().sum();
        assert_eq!(sum, 10);
    }

    #[test]
    fn test_noncentral_chisquare_distribution() {
        let arr = noncentral_chisquare(2.0, 1.0, &[10])
            .expect("test: noncentral_chisquare should succeed");
        assert_eq!(arr.shape(), vec![10]);

        // Noncentral chi-square values should be positive
        for val in arr.to_vec() {
            assert!(val > 0.0);
        }
    }

    #[test]
    fn test_noncentral_f_distribution() {
        let arr = noncentral_f(2.0, 5.0, 1.0, &[10]).expect("test: noncentral_f should succeed");
        assert_eq!(arr.shape(), vec![10]);

        // Noncentral F values should be positive
        for val in arr.to_vec() {
            assert!(val > 0.0);
        }
    }

    #[test]
    fn test_vonmises_distribution() {
        let arr = vonmises(0.0, 1.0, &[10]).expect("test: vonmises should succeed");
        assert_eq!(arr.shape(), vec![10]);

        // Von Mises values should be in the range [-π, π)
        for val in arr.to_vec() {
            assert!((-std::f64::consts::PI..std::f64::consts::PI).contains(&val));
        }
    }

    #[test]
    fn test_maxwell_distribution() {
        let arr = maxwell(1.0, &[10]).expect("test: maxwell should succeed");
        assert_eq!(arr.shape(), vec![10]);

        // Maxwell values should be positive
        for val in arr.to_vec() {
            assert!(val > 0.0);
        }
    }

    #[test]
    fn test_truncated_normal_distribution() {
        let low = -2.0;
        let high = 2.0;
        let arr = truncated_normal(0.0, 1.0, low, high, &[10])
            .expect("test: truncated_normal should succeed");
        assert_eq!(arr.shape(), vec![10]);

        // Truncated normal values should be within bounds
        for val in arr.to_vec() {
            assert!(val >= low && val <= high);
        }
    }

    #[test]
    fn test_multivariate_normal_with_rotation() {
        let mean = vec![0.0, 0.0];
        let cov_data = vec![1.0, 0.5, 0.5, 1.0];
        let cov = Array::from_vec(cov_data).reshape(&[2, 2]);

        // Create a rotation matrix for 45 degrees
        let rotation_data = vec![
            std::f64::consts::FRAC_1_SQRT_2,
            std::f64::consts::FRAC_1_SQRT_2, // cos(45°), sin(45°)
            -std::f64::consts::FRAC_1_SQRT_2,
            std::f64::consts::FRAC_1_SQRT_2, // -sin(45°), cos(45°)
        ];
        let rotation = Array::from_vec(rotation_data).reshape(&[2, 2]);

        let arr = multivariate_normal_with_rotation(&mean, &cov, Some(&[5]), Some(&rotation))
            .expect("test: multivariate_normal_with_rotation should succeed");
        assert_eq!(arr.shape(), vec![5, 2]);

        // Test without rotation matrix (should default to regular multivariate normal)
        let arr_no_rot = multivariate_normal_with_rotation(&mean, &cov, Some(&[5]), None)
            .expect("test: multivariate_normal_with_rotation (no rotation) should succeed");
        assert_eq!(arr_no_rot.shape(), vec![5, 2]);
    }

    #[test]
    fn test_multivariate_t_distribution() {
        let mean = vec![0.0, 0.0];
        let cov_data = vec![1.0, 0.3, 0.3, 1.0];
        let cov = Array::from_vec(cov_data).reshape(&[2, 2]);
        let df = 5.0;

        let arr = multivariate_t(&mean, &cov, df, Some(&[10]))
            .expect("test: multivariate_t should succeed");
        assert_eq!(arr.shape(), vec![10, 2]);

        // Test with single sample (no size parameter)
        let arr_single = multivariate_t(&mean, &cov, df, None)
            .expect("test: multivariate_t (single sample) should succeed");
        assert_eq!(arr_single.shape(), vec![2]);
    }

    #[test]
    fn test_multivariate_t_parameter_validation() {
        let mean = vec![0.0, 0.0];
        let cov_data = vec![1.0, 0.3, 0.3, 1.0];
        let cov = Array::from_vec(cov_data).reshape(&[2, 2]);

        // Test with invalid degrees of freedom (df <= 0)
        let result = multivariate_t::<f64>(&mean, &cov, 0.0, Some(&[5]));
        assert!(result.is_err(), "multivariate_t should fail with df = 0");

        let result = multivariate_t::<f64>(&mean, &cov, -1.0, Some(&[5]));
        assert!(
            result.is_err(),
            "multivariate_t should fail with negative df"
        );

        // Test with non-positive-definite covariance
        let bad_cov_data = vec![1.0, 2.0, 2.0, 1.0]; // Not positive definite
        let bad_cov = Array::from_vec(bad_cov_data).reshape(&[2, 2]);
        let result = multivariate_t::<f64>(&mean, &bad_cov, 5.0, Some(&[5]));
        assert!(
            result.is_err(),
            "multivariate_t should fail with non-positive-definite covariance"
        );
    }

    #[test]
    fn test_wishart_distribution() {
        let scale_data = vec![1.0, 0.2, 0.2, 1.0];
        let scale = Array::from_vec(scale_data).reshape(&[2, 2]);
        let df = 5.0;

        let arr = wishart(df, &scale, Some(&[3])).expect("test: wishart should succeed");
        // Should produce 3 matrices of size 2x2
        assert_eq!(arr.shape(), vec![3, 2, 2]);

        // Test with single sample
        let arr_single =
            wishart(df, &scale, None).expect("test: wishart (single sample) should succeed");
        assert_eq!(arr_single.shape(), vec![2, 2]);
    }

    #[test]
    fn test_wishart_parameter_validation() {
        let scale_data = vec![1.0, 0.2, 0.2, 1.0];
        let scale = Array::from_vec(scale_data).reshape(&[2, 2]);

        // Test with df < dimension
        let result = wishart::<f64>(1.0, &scale, Some(&[3]));
        assert!(result.is_err(), "wishart should fail when df < dimension");

        // Test with non-square scale matrix
        let bad_scale_data = vec![1.0, 0.2, 0.2];
        let bad_scale = Array::from_vec(bad_scale_data).reshape(&[3, 1]);
        let result = wishart::<f64>(5.0, &bad_scale, Some(&[3]));
        assert!(
            result.is_err(),
            "wishart should fail with non-square scale matrix"
        );

        // Test with non-positive-definite scale matrix
        let bad_scale_data = vec![1.0, 2.0, 2.0, 1.0]; // Not positive definite
        let bad_scale = Array::from_vec(bad_scale_data).reshape(&[2, 2]);
        let result = wishart::<f64>(5.0, &bad_scale, Some(&[3]));
        assert!(
            result.is_err(),
            "wishart should fail with non-positive-definite scale matrix"
        );
    }

    #[test]
    fn test_frechet_distribution() {
        let arr = frechet(2.0, 0.0, 1.0, &[100]).expect("test: frechet should succeed");
        assert_eq!(arr.shape(), vec![100]);

        // Frechet values should be > loc
        let loc = 0.0;
        for val in arr.to_vec() {
            assert!(val > loc, "Frechet values should be > loc, got {}", val);
        }
    }

    #[test]
    fn test_frechet_parameter_validation() {
        // Test with invalid shape parameter (alpha <= 0)
        let result = frechet::<f64>(0.0, 0.0, 1.0, &[10]);
        assert!(result.is_err(), "frechet should fail with shape = 0");

        let result = frechet::<f64>(-1.0, 0.0, 1.0, &[10]);
        assert!(result.is_err(), "frechet should fail with negative shape");

        // Test with invalid scale parameter (scale <= 0)
        let result = frechet::<f64>(2.0, 0.0, 0.0, &[10]);
        assert!(result.is_err(), "frechet should fail with scale = 0");

        let result = frechet::<f64>(2.0, 0.0, -1.0, &[10]);
        assert!(result.is_err(), "frechet should fail with negative scale");
    }

    #[test]
    fn test_frechet_with_different_parameters() {
        // Test with different location parameter
        let arr = frechet(3.0, 5.0, 2.0, &[50]).expect("test: frechet with loc=5 should succeed");
        assert_eq!(arr.shape(), vec![50]);

        // All values should be > loc
        for val in arr.to_vec() {
            assert!(val > 5.0, "Frechet values should be > 5.0, got {}", val);
        }
    }

    #[test]
    fn test_gev_distribution_gumbel() {
        // Test Gumbel case (shape ≈ 0)
        let arr = gev(0.0, 0.0, 1.0, &[100]).expect("test: gev (Gumbel) should succeed");
        assert_eq!(arr.shape(), vec![100]);

        // Values can be any real number for Gumbel
        // Just verify we got samples
        assert!(!arr.to_vec().is_empty());
    }

    #[test]
    fn test_gev_distribution_frechet() {
        // Test Frechet case (shape > 0)
        let arr = gev(0.5, 0.0, 1.0, &[100]).expect("test: gev (Frechet) should succeed");
        assert_eq!(arr.shape(), vec![100]);

        // For Frechet (xi > 0), values should be > loc when scale > 0
        // Just verify we got samples
        assert!(!arr.to_vec().is_empty());
    }

    #[test]
    fn test_gev_distribution_weibull() {
        // Test Weibull case (shape < 0)
        let arr = gev(-0.5, 0.0, 1.0, &[100]).expect("test: gev (Weibull) should succeed");
        assert_eq!(arr.shape(), vec![100]);

        // For Weibull (xi < 0), values should be < loc + scale/|xi|
        // Just verify we got samples
        assert!(!arr.to_vec().is_empty());
    }

    #[test]
    fn test_gev_parameter_validation() {
        // Test with invalid scale parameter (scale <= 0)
        let result = gev::<f64>(0.0, 0.0, 0.0, &[10]);
        assert!(result.is_err(), "gev should fail with scale = 0");

        let result = gev::<f64>(0.0, 0.0, -1.0, &[10]);
        assert!(result.is_err(), "gev should fail with negative scale");
    }

    #[test]
    fn test_gev_with_different_parameters() {
        // Test with different location and scale
        let arr = gev(0.2, 10.0, 2.0, &[50]).expect("test: gev with custom params should succeed");
        assert_eq!(arr.shape(), vec![50]);

        // Just verify we got valid samples
        assert!(!arr.to_vec().is_empty());
    }
}