numrs2 0.3.3

A Rust implementation inspired by NumPy for numerical computing (NumRS2)
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
//! Version Compatibility and Model Migration
//!
//! Provides utilities for migrating models between different NumRS2 versions,
//! validating model compatibility, and handling schema evolution.

use super::format::{FormatResult, ModelFormat, NumRS2Model, MODEL_FORMAT_VERSION};
use crate::error::NumRs2Error;
use serde::{Deserialize, Serialize};
use std::cmp::Ordering;
use std::fmt;

/// Version information
#[derive(Debug, Clone, PartialEq, Eq, Serialize, Deserialize)]
pub struct VersionInfo {
    /// Major version number
    pub major: u32,
    /// Minor version number
    pub minor: u32,
    /// Patch version number
    pub patch: u32,
}

impl VersionInfo {
    /// Creates a new version info
    pub fn new(major: u32, minor: u32, patch: u32) -> Self {
        Self {
            major,
            minor,
            patch,
        }
    }

    /// Parses a version string (e.g., "0.4.0")
    pub fn parse(version: &str) -> FormatResult<Self> {
        let parts: Vec<&str> = version.split('.').collect();

        if parts.len() != 3 {
            return Err(NumRs2Error::ValueError(format!(
                "Invalid version string: {}",
                version
            )));
        }

        let major = parts[0]
            .parse::<u32>()
            .map_err(|_| NumRs2Error::ValueError(format!("Invalid major version: {}", parts[0])))?;

        let minor = parts[1]
            .parse::<u32>()
            .map_err(|_| NumRs2Error::ValueError(format!("Invalid minor version: {}", parts[1])))?;

        let patch = parts[2]
            .parse::<u32>()
            .map_err(|_| NumRs2Error::ValueError(format!("Invalid patch version: {}", parts[2])))?;

        Ok(Self::new(major, minor, patch))
    }

    /// Checks if this version is compatible with another
    ///
    /// Compatible if major version matches and this version is >= other
    pub fn is_compatible_with(&self, other: &VersionInfo) -> bool {
        self.major == other.major && self >= other
    }

    /// Checks if migration is needed
    pub fn needs_migration(&self, target: &VersionInfo) -> bool {
        self < target
    }
}

impl PartialOrd for VersionInfo {
    fn partial_cmp(&self, other: &Self) -> Option<Ordering> {
        Some(self.cmp(other))
    }
}

impl Ord for VersionInfo {
    fn cmp(&self, other: &Self) -> Ordering {
        match self.major.cmp(&other.major) {
            Ordering::Equal => match self.minor.cmp(&other.minor) {
                Ordering::Equal => self.patch.cmp(&other.patch),
                other => other,
            },
            other => other,
        }
    }
}

impl fmt::Display for VersionInfo {
    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
        write!(f, "{}.{}.{}", self.major, self.minor, self.patch)
    }
}

/// Model validator
pub struct ModelValidator;

impl ModelValidator {
    /// Validates a model
    ///
    /// Checks:
    /// - Format version compatibility
    /// - Magic number correctness
    /// - Layer consistency
    /// - Metadata completeness
    pub fn validate(model: &NumRS2Model) -> FormatResult<()> {
        // Validate format
        Self::validate_format(&model.format)?;

        // Validate metadata
        Self::validate_metadata(model)?;

        // Validate layers
        Self::validate_layers(model)?;

        // Validate optimizer state if present
        if let Some(ref opt_state) = model.optimizer_state {
            Self::validate_optimizer_state(opt_state)?;
        }

        Ok(())
    }

    /// Validates model format
    fn validate_format(format: &ModelFormat) -> FormatResult<()> {
        // Check magic number
        if format.magic != *b"NUMRS2\x00\x00" {
            return Err(NumRs2Error::ValueError(
                "Invalid magic number in model format".to_string(),
            ));
        }

        // Check version
        let _version = VersionInfo::parse(&format.version)?;

        Ok(())
    }

    /// Validates model metadata
    fn validate_metadata(model: &NumRS2Model) -> FormatResult<()> {
        let metadata = &model.metadata;

        // Check required fields
        if metadata.name.is_empty() {
            return Err(NumRs2Error::ValueError(
                "Model name cannot be empty".to_string(),
            ));
        }

        if metadata.version.is_empty() {
            return Err(NumRs2Error::ValueError(
                "Model version cannot be empty".to_string(),
            ));
        }

        // Validate version format
        let _version = VersionInfo::parse(&metadata.version)?;

        Ok(())
    }

    /// Validates model layers
    fn validate_layers(model: &NumRS2Model) -> FormatResult<()> {
        if model.layers.is_empty() {
            return Err(NumRs2Error::ValueError(
                "Model must have at least one layer".to_string(),
            ));
        }

        for (i, layer) in model.layers.iter().enumerate() {
            // Check layer name
            if layer.name.is_empty() {
                return Err(NumRs2Error::ValueError(format!(
                    "Layer {} has empty name",
                    i
                )));
            }

            // Check shapes
            if layer.input_shape.is_empty() {
                return Err(NumRs2Error::ValueError(format!(
                    "Layer {} has empty input shape",
                    layer.name
                )));
            }

            if layer.output_shape.is_empty() {
                return Err(NumRs2Error::ValueError(format!(
                    "Layer {} has empty output shape",
                    layer.name
                )));
            }

            // Check weights
            if layer.weights.is_empty() {
                return Err(NumRs2Error::ValueError(format!(
                    "Layer {} has no weights",
                    layer.name
                )));
            }
        }

        Ok(())
    }

    /// Validates optimizer state
    fn validate_optimizer_state(opt_state: &super::format::OptimizerState) -> FormatResult<()> {
        if opt_state.optimizer_name.is_empty() {
            return Err(NumRs2Error::ValueError(
                "Optimizer name cannot be empty".to_string(),
            ));
        }

        if opt_state.learning_rate <= 0.0 {
            return Err(NumRs2Error::ValueError(
                "Learning rate must be positive".to_string(),
            ));
        }

        Ok(())
    }
}

/// Model migration utilities
pub struct ModelMigration;

impl ModelMigration {
    /// Migrates a model to the current version
    ///
    /// # Arguments
    ///
    /// * `model` - The model to migrate
    ///
    /// # Returns
    ///
    /// A migrated model compatible with the current version
    pub fn migrate_to_current(mut model: NumRS2Model) -> FormatResult<NumRS2Model> {
        let current_version = VersionInfo::parse(MODEL_FORMAT_VERSION)?;
        let model_version = VersionInfo::parse(&model.format.version)?;

        if model_version == current_version {
            // No migration needed
            return Ok(model);
        }

        if !model_version.needs_migration(&current_version) {
            // Model is newer than current version
            return Err(NumRs2Error::ValueError(format!(
                "Model version {} is newer than supported version {}",
                model_version, current_version
            )));
        }

        // Perform migration based on version differences
        model = Self::migrate_from_version(model, &model_version, &current_version)?;

        // Update version
        model.format.version = MODEL_FORMAT_VERSION.to_string();

        Ok(model)
    }

    /// Migrates from a specific version to another
    fn migrate_from_version(
        mut model: NumRS2Model,
        from: &VersionInfo,
        to: &VersionInfo,
    ) -> FormatResult<NumRS2Model> {
        // Migration path: 0.1.x -> 0.2.x -> 0.3.x -> 0.4.x

        if from.major == 0 && from.minor < 2 {
            // Migrate from 0.1.x to 0.2.x
            model = Self::migrate_0_1_to_0_2(model)?;
        }

        if from.major == 0 && from.minor < 3 {
            // Migrate from 0.2.x to 0.3.x
            model = Self::migrate_0_2_to_0_3(model)?;
        }

        if from.major == 0 && from.minor < 4 {
            // Migrate from 0.3.x to 0.4.x
            model = Self::migrate_0_3_to_0_4(model)?;
        }

        Ok(model)
    }

    /// Migrates from 0.1.x to 0.2.x
    fn migrate_0_1_to_0_2(mut model: NumRS2Model) -> FormatResult<NumRS2Model> {
        // Add any 0.1.x -> 0.2.x specific migrations
        // For now, just update metadata
        model.metadata.modified_at = chrono::Utc::now().to_rfc3339();

        Ok(model)
    }

    /// Migrates from 0.2.x to 0.3.x
    fn migrate_0_2_to_0_3(mut model: NumRS2Model) -> FormatResult<NumRS2Model> {
        // Add any 0.2.x -> 0.3.x specific migrations
        model.metadata.modified_at = chrono::Utc::now().to_rfc3339();

        Ok(model)
    }

    /// Migrates from 0.3.x to 0.4.x
    fn migrate_0_3_to_0_4(mut model: NumRS2Model) -> FormatResult<NumRS2Model> {
        // Add any 0.3.x -> 0.4.x specific migrations
        model.metadata.modified_at = chrono::Utc::now().to_rfc3339();

        Ok(model)
    }

    /// Checks if a model can be migrated
    pub fn can_migrate(model: &NumRS2Model) -> bool {
        let current_version = match VersionInfo::parse(MODEL_FORMAT_VERSION) {
            Ok(v) => v,
            Err(_) => return false,
        };

        let model_version = match VersionInfo::parse(&model.format.version) {
            Ok(v) => v,
            Err(_) => return false,
        };

        // Can migrate if major version matches and model version is older
        current_version.major == model_version.major && model_version < current_version
    }
}

/// Convenience function to validate a model
pub fn validate_model_version(model: &NumRS2Model) -> FormatResult<()> {
    ModelValidator::validate(model)
}

/// Convenience function to migrate a model
pub fn migrate_model(model: NumRS2Model) -> FormatResult<NumRS2Model> {
    ModelMigration::migrate_to_current(model)
}

#[cfg(test)]
mod tests {
    use super::*;
    use crate::new_modules::model_io::format::{LayerData, ModelMetadata};
    use scirs2_core::ndarray::Array2;

    #[test]
    fn test_version_info_parsing() {
        let version = VersionInfo::parse("0.4.0");
        assert!(version.is_ok());

        let v = version.expect("test: valid version parse");
        assert_eq!(v.major, 0);
        assert_eq!(v.minor, 4);
        assert_eq!(v.patch, 0);
    }

    #[test]
    fn test_version_info_invalid() {
        let version = VersionInfo::parse("invalid");
        assert!(version.is_err());

        let version = VersionInfo::parse("1.2");
        assert!(version.is_err());

        let version = VersionInfo::parse("1.2.a");
        assert!(version.is_err());
    }

    #[test]
    fn test_version_comparison() {
        let v1 = VersionInfo::new(0, 4, 0);
        let v2 = VersionInfo::new(0, 3, 0);
        let v3 = VersionInfo::new(0, 4, 1);

        assert!(v1 > v2);
        assert!(v3 > v1);
        assert!(v2 < v1);
    }

    #[test]
    fn test_version_compatibility() {
        let v1 = VersionInfo::new(0, 4, 0);
        let v2 = VersionInfo::new(0, 3, 0);
        let v3 = VersionInfo::new(1, 0, 0);

        assert!(v1.is_compatible_with(&v2)); // Same major, v1 >= v2
        assert!(!v2.is_compatible_with(&v1)); // Same major, but v2 < v1
        assert!(!v1.is_compatible_with(&v3)); // Different major
    }

    #[test]
    fn test_version_needs_migration() {
        let v1 = VersionInfo::new(0, 3, 0);
        let v2 = VersionInfo::new(0, 4, 0);

        assert!(v1.needs_migration(&v2));
        assert!(!v2.needs_migration(&v1));
    }

    #[test]
    fn test_version_to_string() {
        let v = VersionInfo::new(0, 4, 0);
        assert_eq!(v.to_string(), "0.4.0");
    }

    #[test]
    fn test_validate_model_success() {
        let metadata = ModelMetadata::builder()
            .name("test_model")
            .version("1.0.0")
            .architecture("MLP")
            .build()
            .expect("test: valid metadata build");

        let layer = LayerData::dense("layer1", Array2::ones((10, 5)), None);
        let model = NumRS2Model::new(metadata, vec![layer]);

        let result = ModelValidator::validate(&model);
        assert!(result.is_ok());
    }

    #[test]
    fn test_validate_model_empty_name() {
        let mut model = create_test_model();
        model.metadata.name = String::new();

        let result = ModelValidator::validate(&model);
        assert!(result.is_err());
    }

    #[test]
    fn test_validate_model_no_layers() {
        let metadata = ModelMetadata::builder()
            .name("test_model")
            .build()
            .expect("test: valid metadata build");

        let model = NumRS2Model::new(metadata, vec![]);

        let result = ModelValidator::validate(&model);
        assert!(result.is_err());
    }

    #[test]
    fn test_validate_format() {
        let format = ModelFormat::default();
        let result = ModelValidator::validate_format(&format);
        assert!(result.is_ok());
    }

    #[test]
    fn test_validate_format_invalid_magic() {
        let format = ModelFormat {
            magic: *b"INVALID\x00",
            ..Default::default()
        };

        let result = ModelValidator::validate_format(&format);
        assert!(result.is_err());
    }

    #[test]
    fn test_can_migrate() {
        let mut model = create_test_model();
        model.format.version = "0.3.0".to_string();

        let can_migrate = ModelMigration::can_migrate(&model);
        assert!(can_migrate);
    }

    #[test]
    fn test_can_migrate_same_version() {
        let model = create_test_model();
        let can_migrate = ModelMigration::can_migrate(&model);
        // Should be false since it's already at current version
        assert!(!can_migrate);
    }

    #[test]
    fn test_migrate_to_current() {
        let mut model = create_test_model();
        model.format.version = "0.3.0".to_string();

        let result = ModelMigration::migrate_to_current(model);
        assert!(result.is_ok());

        let migrated = result.expect("test: valid model migration");
        assert_eq!(migrated.format.version, MODEL_FORMAT_VERSION);
    }

    #[test]
    fn test_migrate_newer_version() {
        let mut model = create_test_model();
        model.format.version = "1.0.0".to_string(); // Future version

        let result = ModelMigration::migrate_to_current(model);
        assert!(result.is_err());
    }

    #[test]
    fn test_convenience_functions() {
        let model = create_test_model();

        // Test validation
        let result = validate_model_version(&model);
        assert!(result.is_ok());

        // Test migration (should work even with current version)
        let result = migrate_model(model);
        assert!(result.is_ok());
    }

    // Helper function
    fn create_test_model() -> NumRS2Model {
        let metadata = ModelMetadata::builder()
            .name("test_model")
            .version("1.0.0")
            .architecture("MLP")
            .build()
            .expect("test: valid metadata build");

        let layer = LayerData::dense("layer1", Array2::ones((10, 5)), None);
        NumRS2Model::new(metadata, vec![layer])
    }

    #[test]
    fn test_validate_optimizer_state() {
        let opt_state = super::super::format::OptimizerState::adam(0.001, 0.9, 0.999, 1e-8);
        let result = ModelValidator::validate_optimizer_state(&opt_state);
        assert!(result.is_ok());
    }

    #[test]
    fn test_validate_optimizer_state_invalid_lr() {
        let mut opt_state = super::super::format::OptimizerState::adam(0.001, 0.9, 0.999, 1e-8);
        opt_state.learning_rate = -0.1;

        let result = ModelValidator::validate_optimizer_state(&opt_state);
        assert!(result.is_err());
    }

    #[test]
    fn test_version_ordering() {
        let mut versions = [
            VersionInfo::new(0, 4, 0),
            VersionInfo::new(0, 2, 0),
            VersionInfo::new(0, 3, 5),
            VersionInfo::new(0, 3, 0),
        ];

        versions.sort();

        assert_eq!(versions[0], VersionInfo::new(0, 2, 0));
        assert_eq!(versions[1], VersionInfo::new(0, 3, 0));
        assert_eq!(versions[2], VersionInfo::new(0, 3, 5));
        assert_eq!(versions[3], VersionInfo::new(0, 4, 0));
    }
}