nu-lint 1.3.0

Linter for Nu shell scripts that helpfully suggests improvements
Documentation 
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109

use super::RULE;

#[test]
fn test_fix_removes_unused_let() {
    let code = r#"let unused = 5
print "hello""#;
    RULE.assert_fix_erases(code, "let unused = 5");
}

#[test]
fn test_fix_removes_unused_mut() {
    let code = r#"mut unused = 5
print "hello""#;
    RULE.assert_fix_erases(code, "mut unused = 5");
}

#[test]
fn test_fix_unused_at_start() {
    let code = r#"let unused = 5
let used = 10
print $used"#;
    let expected = r#"let used = 10
print $used"#;
    RULE.assert_fixed_is(code, expected);
}

#[test]
fn test_fix_unused_in_middle() {
    let code = r#"let a = 1
let unused = 2
let b = 3
print ($a + $b)"#;
    let expected = r#"let a = 1
let b = 3
print ($a + $b)"#;
    RULE.assert_fixed_is(code, expected);
}

#[test]
fn test_fix_one_of_multiple_unused() {
    // When multiple violations exist, each fix is applied separately
    // This test verifies one unused variable is removed per fix application
    let code = r#"let x = 1
let y = 2
print "done""#;
    // After one fix, either x or y is removed (order is non-deterministic)
    let fixed = RULE.apply_first_fix(code);
    let x_removed = !fixed.contains("let x = 1");
    let y_removed = !fixed.contains("let y = 2");
    assert!(
        x_removed || y_removed,
        "Expected at least one of 'let x = 1' or 'let y = 2' to be removed, but got: {fixed}"
    );
}

#[test]
fn test_fix_preserves_used_variables() {
    let code = r#"let used = "hello"
let unused = "world"
print $used"#;
    let expected = r#"let used = "hello"
print $used"#;
    RULE.assert_fixed_is(code, expected);
}

#[test]
fn test_fix_unused_with_complex_rhs() {
    let code = r#"let unused = (1 + 2 * 3)
print "result""#;
    let expected = r#"print "result""#;
    RULE.assert_fixed_is(code, expected);
}

#[test]
fn test_fix_unused_mut_with_list() {
    let code = r#"mut unused = [1, 2, 3]
print "done""#;
    let expected = r#"print "done""#;
    RULE.assert_fixed_is(code, expected);
}

#[test]
fn test_fix_semicolon_first_statement_unused() {
    // When first statement on a semicolon line is unused, remove it and the
    // trailing semicolon
    let code = r#"let unused = 1; let used = 2
print $used"#;
    let expected = r#"let used = 2
print $used"#;
    RULE.assert_fixed_is(code, expected);
}

#[test]
fn test_fix_semicolon_second_statement_unused() {
    // When second statement on a semicolon line is unused, remove the leading
    // semicolon and the statement. The result keeps the first statement on its
    // own line.
    let code = "let used = 1; let unused = 2; print $used";
    let expected = "let used = 1; print $used";
    RULE.assert_fixed_is(code, expected);
}

#[test]
fn test_fix_semicolon_preserves_following_command() {
    // Critical test: ensure following command is NOT removed
    let code = r#"let unused = [1 2]; head -n 10 README.md"#;
    let expected = r#"head -n 10 README.md"#;
    RULE.assert_fixed_is(code, expected);
}