nu-lint 1.3.0

Linter for Nu shell scripts that helpfully suggests improvements
Documentation 
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60

use super::RULE;
use crate::log::init_test_log;

#[test]
fn detect_redundant_in_at_pipeline_start() {
    init_test_log();

    let bad_codes = vec![
        "def get-field [field] { $in | get $field }",
        "def has-key [key] { $in | columns | any { |col| $col == $key } }",
        "def select-column [column] { $in | select $column }",
        "def sort-by-field [field] { $in | sort-by $field }",
        "def multiply [factor] { $in | each { |x| $x * $factor } }",
        "def take-first [n] { $in | first $n }",
    ];

    for code in bad_codes {
        RULE.assert_detects(code);
    }
}

#[test]
fn detect_redundant_in_no_parameters() {
    let bad_codes = vec![
        "def process [] { $in | where active }",
        "def transform [] { $in | each { |x| $x * 2 } }",
        "def filter-positive [] { $in | where $it > 0 }",
        "def get-names [] { $in | select name }",
    ];

    for code in bad_codes {
        RULE.assert_detects(code);
    }
}

#[test]
fn detect_redundant_in_with_spaces() {
    let bad_codes = vec![
        "def process [] { $in| where active }",
        "def process [] {    $in | where active }",
        "def process [] {\n    $in | where active\n}",
    ];

    for code in bad_codes {
        RULE.assert_detects(code);
    }
}

#[test]
fn detect_redundant_in_complex_pipelines() {
    let bad_codes = vec![
        "def process [] { $in | where active | select name | sort-by name }",
        "def calculate [] { $in | each { |x| $x * 2 } | math sum }",
        "def filter-and-count [] { $in | where $it > 5 | length }",
    ];

    for code in bad_codes {
        RULE.assert_detects(code);
    }
}