nu-lint 1.3.0

Linter for Nu shell scripts that helpfully suggests improvements
Documentation 
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126

use super::RULE;
use crate::log::init_test_log;

#[test]
fn test_detect_string_equality_chain_in_function() {
    init_test_log();
    let bad_code = r#"
def get-color [scope: string] {
    if $scope == "wan" {
        "red"
    } else if $scope == "lan" {
        "yellow"
    } else if $scope == "local" {
        "blue"
    } else {
        "green"
    }
}
"#;

    RULE.assert_count(bad_code, 1);
}

#[test]
fn test_detect_inline_if_chain() {
    init_test_log();
    let bad_code = r#"let priority = if $level == "high" { 1 } else if $level == "medium" { 2 } else if $level == "low" { 3 } else { 0 }"#;

    RULE.assert_detects(bad_code);
}

#[test]
fn test_detect_numeric_equality_chain() {
    let bad_code = r#"
if $code == 200 {
    "ok"
} else if $code == 404 {
    "not found"
} else if $code == 500 {
    "server error"
} else {
    "unknown"
}
"#;

    RULE.assert_detects(bad_code);
}

#[test]
fn test_detect_four_branch_equality_chain() {
    let bad_code = r#"
if $status == "pending" {
    1
} else if $status == "approved" {
    2
} else if $status == "rejected" {
    3
} else if $status == "cancelled" {
    4
} else {
    0
}
"#;

    RULE.assert_detects(bad_code);
}

#[test]
fn test_detect_chain_in_closure() {
    let bad_code = r#"
let mapper = {|item|
    if $item == "a" {
        1
    } else if $item == "b" {
        2
    } else if $item == "c" {
        3
    } else {
        0
    }
}
"#;

    RULE.assert_detects(bad_code);
}

#[test]
fn test_detect_minimal_three_branch_chain() {
    let bad_code = r#"
if $x == 1 { "one" } else if $x == 2 { "two" } else if $x == 3 { "three" }
"#;

    RULE.assert_detects(bad_code);
}

#[test]
fn test_detect_chain_with_not_equal_operator() {
    let bad_code = r#"
if $type != "string" {
    "not string"
} else if $type != "int" {
    "not int"
} else if $type != "bool" {
    "not bool"
} else {
    "unknown"
}
"#;

    RULE.assert_detects(bad_code);
}

#[test]
fn test_detect_chain_without_final_else() {
    let bad_code = r#"
if $mode == "read" {
    open $file
} else if $mode == "write" {
    save $file
} else if $mode == "append" {
    $content | save -a $file
}
"#;

    RULE.assert_detects(bad_code);
}