nu-lint 1.2.0

Linter for Nu shell scripts that helpfully suggests improvements
Documentation 
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140

use super::RULE;

#[test]
fn fix_single_list_param() {
    RULE.assert_fixed_contains(
        r#"
def process [items: list<string>] {
    $items | each { print $in }
}
"#,
        "[...items: string]",
    );
}

#[test]
fn fix_list_as_last_required() {
    RULE.assert_fixed_contains(
        r#"
def cmd [name: string, files: list<path>] {
    $files | each { open $in }
}
"#,
        "[name: string, ...files: path]",
    );
}

#[test]
fn fix_list_as_last_optional() {
    RULE.assert_fixed_contains(
        r#"
def cmd [name: string, files?: list<string>] {
    $files | default [] | each { print $in }
}
"#,
        "[name: string, ...files: string]",
    );
}

#[test]
fn fix_untyped_list() {
    RULE.assert_fixed_contains(
        r#"
def process [items: list] {
    $items | length
}
"#,
        "[...items]",
    );
}

#[test]
fn fix_preserves_flags() {
    RULE.assert_fixed_contains(
        r#"
def cmd [items: list<string>, --verbose] {
    if $verbose { print "verbose" }
    $items | each { print $in }
}
"#,
        "[...items: string, --verbose]",
    );
}

#[test]
fn fix_preserves_flag_with_type() {
    RULE.assert_fixed_contains(
        r#"
def cmd [items: list<int>, --count: int] {
    $items | take $count
}
"#,
        "[...items: int, --count: int]",
    );
}

// Tests for call site fixing

#[test]
fn fix_call_site_list_literal() {
    RULE.assert_fixed_is(
        r#"def process [items: list<string>] { $items }
process ["a" "b" "c"]"#,
        r#"def process [...items: string] { $items }
process "a" "b" "c""#,
    );
}

#[test]
fn fix_call_site_variable() {
    RULE.assert_fixed_is(
        r#"def process [items: list<string>] { $items }
let files = ["a" "b"]
process $files"#,
        r#"def process [...items: string] { $items }
let files = ["a" "b"]
process ...$files"#,
    );
}

#[test]
fn fix_call_site_expression() {
    RULE.assert_fixed_is(
        r#"def process [items: list<string>] { $items }
process (["a" "b"])"#,
        r#"def process [...items: string] { $items }
process ...(["a" "b"])"#,
    );
}

#[test]
fn fix_multiple_call_sites() {
    RULE.assert_fixed_is(
        r#"def process [items: list<string>] { $items }
process ["a" "b"]
process ["x" "y" "z"]"#,
        r#"def process [...items: string] { $items }
process "a" "b"
process "x" "y" "z""#,
    );
}

#[test]
fn fix_preserves_other_positional_args() {
    RULE.assert_fixed_is(
        r#"def cmd [name: string, items: list<string>] { $items }
cmd "test" ["a" "b"]"#,
        r#"def cmd [name: string, ...items: string] { $items }
cmd "test" "a" "b""#,
    );
}

#[test]
fn fix_empty_list_call_site() {
    RULE.assert_fixed_is(
        r#"def process [items: list<string>] { $items }
process []"#,
        r#"def process [...items: string] { $items }
process "#,
    );
}