nu-lint 1.1.0

Linter for Nu shell scripts that helpfully suggests improvements
Documentation 
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127

use super::RULE;

#[test]
fn test_simple_append_with_parentheses() {
    let bad_code = r#"
mut list = []
let x = 1
$list = ($list | append $x)
"#;
    RULE.assert_detects(bad_code);
}

#[test]
fn test_simple_append_without_parentheses() {
    let bad_code = r#"
mut a = [1 2]
$a = $a | append 3
"#;
    RULE.assert_detects(bad_code);
}

#[test]
fn test_env_variable_with_parentheses() {
    let bad_code = r#"
mut binding = {}
$env.config.keybindings = ($env.config.keybindings | append $binding)
"#;
    RULE.assert_detects(bad_code);
}

#[test]
fn test_env_variable_without_parentheses() {
    let bad_code = r#"
mut binding = {}
$env.config.keybindings = $env.config.keybindings | append $binding
"#;
    RULE.assert_detects(bad_code);
}

#[test]
fn test_cell_path_with_parentheses() {
    let bad_code = r#"
mut config = {items: []}
mut new_item = 1
$config.items = ($config.items | append $new_item)
"#;
    RULE.assert_detects(bad_code);
}

#[test]
fn test_cell_path_without_parentheses() {
    let bad_code = r#"
mut config = {items: []}
mut new_item = 1
$config.items = $config.items | append $new_item
"#;
    RULE.assert_detects(bad_code);
}

#[test]
fn test_list_literal_value_with_parentheses() {
    let bad_code = r#"
mut list = []
$list = ($list | append [1, 2])
"#;
    RULE.assert_detects(bad_code);
}

#[test]
fn test_list_literal_value_without_parentheses() {
    let bad_code = r#"
mut list = []
$list = $list | append [1, 2]
"#;
    RULE.assert_detects(bad_code);
}

#[test]
fn test_variable_value_with_parentheses() {
    let bad_code = r#"
mut list = []
mut items = [1 2]
$list = ($list | append $items)
"#;
    RULE.assert_detects(bad_code);
}

#[test]
fn test_variable_value_without_parentheses() {
    let bad_code = r#"
mut list = []
mut items = [1 2]
$list = $list | append $items
"#;
    RULE.assert_detects(bad_code);
}

#[test]
fn test_subexpression_value_with_parentheses() {
    let bad_code = r#"
mut list = []
$list = ($list | append (get-items))
"#;
    RULE.assert_detects(bad_code);
}

#[test]
fn test_subexpression_value_without_parentheses() {
    let bad_code = r#"
mut list = []
$list = $list | append (get-items)
"#;
    RULE.assert_detects(bad_code);
}

#[test]
fn test_multiple_separate_assignments() {
    let bad_code = r#"
mut a = []
mut b = []
let x = 1
let y = 2
$a = ($a | append $x)
$b = ($b | append $y)
"#;
    RULE.assert_count(bad_code, 2);
}