ntex 4.0.0-beta.17

Framework for composable network services
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
//! Binary-stream adaptation for WebSocket connections.
use std::{cell::Cell, io, task::Poll};

use crate::codec::{Decoder, Encoder};
use crate::io::{Filter, FilterBuf, FilterLayer, Io, Layer};
use crate::service::{Ctx, Service};

use super::{CloseCode, CloseReason, Codec, Frame, Item, Message};

bitflags::bitflags! {
    #[derive(Copy, Clone, Debug, Eq, PartialEq, Ord, PartialOrd, Hash)]
    struct Flags: u8  {
        const CLOSED       = 0b0001;
        const PEER_CLOSED  = 0b0010;
        const PROTO_ERR    = 0b0100;
    }
}

#[derive(Clone, Debug)]
/// I/O filter that exposes binary WebSocket messages as a byte stream.
///
/// Incoming binary messages and fragments are forwarded as bytes. Text
/// messages are rejected, ping frames receive automatic pong replies, and
/// close frames close the underlying I/O stream.
pub struct WsTransport {
    codec: Codec,
    flags: Cell<Flags>,
    peer_code: Cell<Option<CloseCode>>,
}

impl WsTransport {
    /// Adds a binary WebSocket transport filter to `io`.
    pub fn create<F: Filter>(io: Io<F>, codec: Codec) -> Io<Layer<WsTransport, F>> {
        io.add_filter(WsTransport {
            codec,
            flags: Cell::new(Flags::empty()),
            peer_code: Cell::new(None),
        })
    }

    fn insert_flags(&self, flags: Flags) {
        let mut f = self.flags.get();
        f.insert(flags);
        self.flags.set(f);
    }

    fn send_close(&self, buf: &FilterBuf<'_>, code: Option<CloseCode>) {
        if !self.flags.get().contains(Flags::CLOSED) {
            self.insert_flags(Flags::CLOSED);
            buf.with_write_buffers(|_, w_dst| {
                let reason = code.map(CloseReason::from);
                if self.codec.encode(Message::Close(reason), w_dst).is_err() {
                    // an echoed code this side cannot send, for example 1010
                    // from a server
                    let reason = CloseReason::from(CloseCode::Normal);
                    let _ = self.codec.encode(Message::Close(Some(reason)), w_dst);
                }
            });
        }
    }

    /// Fails the connection: sends a close frame with `code` and starts a
    /// graceful shutdown, so the frame is delivered before the connection
    /// is closed with `err`.
    fn fail(&self, buf: &FilterBuf<'_>, code: CloseCode, err: io::Error) -> io::Error {
        self.insert_flags(Flags::PROTO_ERR);
        self.send_close(buf, Some(code));
        buf.io().close();
        err
    }
}

impl FilterLayer for WsTransport {
    #[inline]
    fn shutdown(&self, buf: &FilterBuf<'_>) -> io::Result<Poll<()>> {
        // echo the peer's close code
        let code = if self.flags.get().contains(Flags::PEER_CLOSED) {
            self.peer_code.get()
        } else {
            Some(CloseCode::Normal)
        };
        self.send_close(buf, code);

        // Wait for the peer's close frame. It cannot arrive after read eof,
        // and a failed connection is not required to wait for it.
        let flags = self.flags.get();
        if flags.intersects(Flags::PEER_CLOSED | Flags::PROTO_ERR) || buf.io().is_read_eof() {
            Ok(Poll::Ready(()))
        } else {
            Ok(Poll::Pending)
        }
    }

    fn process_read_buf(&self, buf: &FilterBuf<'_>) -> io::Result<()> {
        buf.with_read_buffers(|r_src, dst| {
            if let Some(src) = r_src {
                loop {
                    let Some(frame) = self.codec.decode(src).map_err(|e| {
                        log::trace!("Failed to decode ws codec frames: {e:?}");
                        let err = io::Error::new(io::ErrorKind::InvalidData, e);
                        self.fail(buf, CloseCode::Protocol, err)
                    })?
                    else {
                        break;
                    };

                    match frame {
                        // the codec enforces fragment ordering
                        Frame::Binary(bin)
                        | Frame::Continuation(
                            Item::FirstBinary(bin) | Item::Continue(bin) | Item::Last(bin),
                        ) => dst.extend_from_slice(&bin),
                        Frame::Continuation(Item::FirstText(_)) => {
                            return Err(self.fail(
                                buf,
                                CloseCode::Unsupported,
                                io::Error::new(
                                    io::ErrorKind::InvalidData,
                                    "WebSocket Text continuation frames are not supported",
                                ),
                            ));
                        }
                        Frame::Text(_) => {
                            return Err(self.fail(
                                buf,
                                CloseCode::Unsupported,
                                io::Error::new(
                                    io::ErrorKind::InvalidData,
                                    "WebSockets Text frames are not supported",
                                ),
                            ));
                        }
                        Frame::Ping(msg) => {
                            buf.with_write_buffers(|_, w_dst| {
                                let _ = self.codec.encode(Message::Pong(msg), w_dst);
                            });
                        }
                        Frame::Pong(_) => (),
                        Frame::Close(reason) => {
                            self.peer_code.set(reason.map(|r| r.code));
                            self.insert_flags(Flags::PEER_CLOSED);
                            buf.io().close();
                            break;
                        }
                    }
                }
            }
            Ok(())
        })
    }

    fn process_write_buf(&self, buf: &FilterBuf<'_>) -> io::Result<()> {
        buf.with_write_buffers(|w_src, w_dst| -> Result<(), super::error::ProtocolError> {
            if self.flags.get().contains(Flags::CLOSED) {
                // nothing can be sent after the close frame
                w_src.clear();
                return Ok(());
            }
            while let Some(page) = w_src.take() {
                self.codec.encode_page(page, w_dst)?;
            }
            Ok(())
        })
        .map_err(|err| io::Error::new(io::ErrorKind::InvalidData, err))
    }
}

#[derive(Clone, Debug)]
/// Service that adds a [`WsTransport`] filter to an I/O stream.
pub struct WsTransportService {
    codec: Codec,
}

impl WsTransportService {
    /// Creates a transport service using `codec`.
    pub fn new(codec: Codec) -> Self {
        Self { codec }
    }
}

impl<F: Filter> Service<(), Io<F>> for WsTransportService {
    type Res = Io<Layer<WsTransport, F>>;
    type Error = io::Error;

    async fn call(&self, io: Io<F>, _: Ctx<'_, Self, ()>) -> Result<Self::Res, Self::Error> {
        Ok(WsTransport::create(io, self.codec.clone()))
    }
}

#[cfg(test)]
mod tests {
    use std::{cell::Cell, rc::Rc};

    use super::*;
    use crate::io::testing::IoTest;
    use crate::time::{Millis, sleep};
    use crate::util::{BytePages, Bytes, BytesMut};

    #[derive(Debug)]
    struct Passthrough;

    impl FilterLayer for Passthrough {
        fn process_read_buf(&self, buf: &FilterBuf<'_>) -> io::Result<()> {
            buf.with_read_buffers(|src, dst| {
                if let Some(src) = src {
                    dst.extend_from_slice(src);
                    src.clear();
                }
            });
            Ok(())
        }

        fn process_write_buf(&self, buf: &FilterBuf<'_>) -> io::Result<()> {
            buf.with_write_buffers(BytePages::move_to);
            Ok(())
        }
    }

    fn peer_close(code: Option<CloseCode>) -> Bytes {
        let mut dst = BytePages::default();
        Codec::new()
            .set_client_mode()
            .encode(Message::Close(code.map(CloseReason::from)), &mut dst)
            .unwrap();
        Bytes::from(dst)
    }

    fn start_shutdown<F: Filter>(io: Io<F>) -> Rc<Cell<bool>> {
        let done = Rc::new(Cell::new(false));
        let done2 = done.clone();
        crate::rt::spawn(async move {
            let _ = io.shutdown().await;
            done2.set(true);
        });
        done
    }

    fn assert_close_sent(client: &IoTest) {
        assert_close_code(client, Some(CloseCode::Normal));
    }

    fn assert_close_code(client: &IoTest, code: Option<CloseCode>) {
        let mut data = BytesMut::from(&client.read_any()[..]);
        assert_eq!(
            Codec::new().set_client_mode().decode(&mut data).unwrap(),
            Some(Frame::Close(code.map(CloseReason::from)))
        );
    }

    async fn error_sends_close<F: Filter>(
        client: IoTest,
        io: Io<F>,
        input: Bytes,
        code: CloseCode,
    ) {
        client.remote_buffer_cap(1024);
        let io = WsTransport::create(io, Codec::new());

        client.write(input);
        let err = io.recv(&crate::codec::BytesCodec).await.unwrap_err();
        assert_eq!(err.into_inner().kind(), io::ErrorKind::InvalidData);
        sleep(Millis(50)).await;

        assert_close_code(&client, Some(code));
        assert!(io.is_closed());
    }

    #[crate::rt_test]
    async fn invalid_frame_sends_protocol_close() {
        // an unmasked frame from a client
        let (client, server) = IoTest::create();
        let input = Bytes::from_static(&[0x82, 0x01, 0x00]);
        error_sends_close(client, Io::from(server), input, CloseCode::Protocol).await;
    }

    #[crate::rt_test]
    async fn invalid_frame_sends_protocol_close_over_inner_filter() {
        let (client, server) = IoTest::create();
        let io = Io::from(server).add_filter(Passthrough);
        let input = Bytes::from_static(&[0x82, 0x01, 0x00]);
        error_sends_close(client, io, input, CloseCode::Protocol).await;
    }

    #[crate::rt_test]
    async fn text_frame_sends_unsupported_close() {
        let (client, server) = IoTest::create();
        let mut input = BytePages::default();
        Codec::new()
            .set_client_mode()
            .encode(Message::Text("text".into()), &mut input)
            .unwrap();
        let input = Bytes::from(input);
        error_sends_close(client, Io::from(server), input, CloseCode::Unsupported).await;
    }

    async fn shutdown_waits_for_peer_close<F: Filter>(client: IoTest, io: Io<F>) {
        client.remote_buffer_cap(1024);
        let io = WsTransport::create(io, Codec::new());
        let done = start_shutdown(io);
        sleep(Millis(50)).await;

        assert_close_sent(&client);
        assert!(!done.get());

        client.write(peer_close(Some(CloseCode::Normal)));
        sleep(Millis(50)).await;
        assert!(done.get());
    }

    #[crate::rt_test]
    async fn shutdown_waits_for_close_reply() {
        let (client, server) = IoTest::create();
        shutdown_waits_for_peer_close(client, Io::from(server)).await;
    }

    #[crate::rt_test]
    async fn shutdown_waits_for_close_reply_over_inner_filter() {
        let (client, server) = IoTest::create();
        shutdown_waits_for_peer_close(client, Io::from(server).add_filter(Passthrough)).await;
    }

    #[crate::rt_test]
    async fn shutdown_completes_on_read_eof() {
        let (client, server) = IoTest::create();
        client.remote_buffer_cap(1024);
        let done = start_shutdown(WsTransport::create(Io::from(server), Codec::new()));
        sleep(Millis(50)).await;
        assert_close_sent(&client);
        assert!(!done.get());

        client.close().await;
        sleep(Millis(50)).await;
        assert!(done.get());
    }

    async fn peer_close_is_echoed(code: Option<CloseCode>, reply: Option<CloseCode>) {
        let (client, server) = IoTest::create();
        client.remote_buffer_cap(1024);
        let io = WsTransport::create(Io::from(server), Codec::new());

        client.write(peer_close(code));
        assert!(io.recv(&crate::codec::BytesCodec).await.unwrap().is_none());
        sleep(Millis(50)).await;

        assert_close_code(&client, reply);
        assert!(io.is_closed());
    }

    #[crate::rt_test]
    async fn peer_close_code_is_echoed() {
        peer_close_is_echoed(Some(CloseCode::Away), Some(CloseCode::Away)).await;
        peer_close_is_echoed(None, None).await;

        // servers cannot send 1010
        peer_close_is_echoed(Some(CloseCode::Extension), Some(CloseCode::Normal)).await;
    }

    fn peer_frames(msgs: Vec<Message>) -> Bytes {
        let codec = Codec::new().set_client_mode();
        let mut dst = BytePages::default();
        for msg in msgs {
            codec.encode(msg, &mut dst).unwrap();
        }
        Bytes::from(dst)
    }

    #[crate::rt_test]
    async fn binary_frames_are_forwarded() {
        let (client, server) = IoTest::create();
        client.remote_buffer_cap(1024);
        let io = crate::service::Pipeline::new((), WsTransportService::new(Codec::new()))
            .call(Io::from(server))
            .await
            .unwrap();

        client.write(peer_frames(vec![
            Message::Binary(Bytes::from_static(b"one")),
            Message::Pong(Bytes::from_static(b"ignored")),
            Message::Continuation(Item::FirstBinary(Bytes::from_static(b"-two"))),
            Message::Ping(Bytes::from_static(b"ping")),
            Message::Continuation(Item::Continue(Bytes::from_static(b"-three"))),
            Message::Continuation(Item::Last(Bytes::from_static(b"-four"))),
        ]));
        let mut data = BytesMut::new();
        while data.len() < 18 {
            data.extend_from_slice(&io.recv(&crate::codec::BytesCodec).await.unwrap().unwrap());
        }
        assert_eq!(&data[..], b"one-two-three-four");

        // ping gets an automatic pong
        sleep(Millis(50)).await;
        let mut data = BytesMut::from(&client.read_any()[..]);
        assert_eq!(
            Codec::new().set_client_mode().decode(&mut data).unwrap(),
            Some(Frame::Pong(Bytes::from_static(b"ping")))
        );

        // outgoing data is sent as binary frames
        io.send(Bytes::from_static(b"out"), &crate::codec::BytesCodec)
            .await
            .unwrap();
        sleep(Millis(50)).await;
        let mut data = BytesMut::from(&client.read_any()[..]);
        assert_eq!(
            Codec::new().set_client_mode().decode(&mut data).unwrap(),
            Some(Frame::Binary(Bytes::from_static(b"out")))
        );
    }

    #[crate::rt_test]
    async fn text_continuation_sends_unsupported_close() {
        let (client, server) = IoTest::create();
        let input = peer_frames(vec![Message::Continuation(Item::FirstText(
            Bytes::from_static(b"text"),
        ))]);
        error_sends_close(client, Io::from(server), input, CloseCode::Unsupported).await;
    }
}